Make the test gate fail when no tests match
vitest.config.ts set passWithNoTests: true, added in the7dd4abbscaffolding commit when the repo genuinely had no tests yet. Once tests existed it became the same hazard as the oxlint bugs fixed in91f46ff: if the include globs ever stopped matching, the suite would exit 0 having run nothing. Vitest already defaults to failing in that case, so removing the line is the whole fix — a broken glob now reports "No test files found, exiting with code 1". Verified by pointing the globs at a nonexistent directory. Extends the gate check to flag the option coming back, and renames it from check-lint-gate to check-gates now that it covers more than oxlint. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -0,0 +1,14 @@
|
||||
import { describe, expect, it } from "vitest";
|
||||
import { checkGates } from "../../../../scripts/check-gates.mjs";
|
||||
|
||||
describe("quality gates", () => {
|
||||
it("fail on violations instead of silently passing", () => {
|
||||
const violations = checkGates();
|
||||
if (violations.length > 0) {
|
||||
throw new Error(
|
||||
`Gate integrity violations:\n ${violations.join("\n ")}`,
|
||||
);
|
||||
}
|
||||
expect(violations).toHaveLength(0);
|
||||
});
|
||||
});
|
||||
@@ -1,14 +0,0 @@
|
||||
import { describe, expect, it } from "vitest";
|
||||
import { checkLintGate } from "../../../../scripts/check-lint-gate.mjs";
|
||||
|
||||
describe("lint gate", () => {
|
||||
it("fails on warnings instead of silently passing", () => {
|
||||
const violations = checkLintGate();
|
||||
if (violations.length > 0) {
|
||||
throw new Error(
|
||||
`Lint gate integrity violations:\n ${violations.join("\n ")}`,
|
||||
);
|
||||
}
|
||||
expect(violations).toHaveLength(0);
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user