Add Recall Knowledge DC and skill to PF2e stat blocks
All checks were successful
CI / check (push) Successful in 2m29s
CI / build-image (push) Successful in 19s

Display Recall Knowledge line below trait tags showing DC (from level
via standard DC-by-level table, adjusted for rarity) and associated
skill derived from creature type trait. Omitted for D&D creatures and
creatures with no recognized type trait.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Lukas
2026-04-10 18:43:49 +02:00
parent e161645228
commit e2e8297c95
6 changed files with 299 additions and 1 deletions

View File

@@ -25,6 +25,12 @@ const ABILITY_MID_NAME_REGEX = /Goblin Scuttle/;
const ABILITY_MID_DESC_REGEX = /The goblin Steps\./;
const CANTRIPS_REGEX = /Cantrips:/;
const AC_REGEX = /16/;
const RK_DC_13_REGEX = /DC 13/;
const RK_DC_15_REGEX = /DC 15/;
const RK_DC_25_REGEX = /DC 25/;
const RK_HUMANOID_SOCIETY_REGEX = /Humanoid \(Society\)/;
const RK_UNDEAD_RELIGION_REGEX = /Undead \(Religion\)/;
const RK_BEAST_SKILLS_REGEX = /Beast \(Arcana\/Nature\)/;
const GOBLIN_WARRIOR: Pf2eCreature = {
system: "pf2e",
@@ -154,6 +160,53 @@ describe("Pf2eStatBlock", () => {
});
});
describe("recall knowledge", () => {
it("renders Recall Knowledge line for a creature with a recognized type trait", () => {
renderStatBlock(GOBLIN_WARRIOR);
expect(screen.getByText("Recall Knowledge")).toBeInTheDocument();
expect(screen.getByText(RK_DC_13_REGEX)).toBeInTheDocument();
expect(screen.getByText(RK_HUMANOID_SOCIETY_REGEX)).toBeInTheDocument();
});
it("adjusts DC for uncommon rarity", () => {
const uncommonCreature: Pf2eCreature = {
...GOBLIN_WARRIOR,
traits: ["uncommon", "small", "humanoid"],
};
renderStatBlock(uncommonCreature);
expect(screen.getByText(RK_DC_15_REGEX)).toBeInTheDocument();
});
it("adjusts DC for rare rarity", () => {
const rareCreature: Pf2eCreature = {
...GOBLIN_WARRIOR,
level: 5,
traits: ["rare", "medium", "undead"],
};
renderStatBlock(rareCreature);
expect(screen.getByText(RK_DC_25_REGEX)).toBeInTheDocument();
expect(screen.getByText(RK_UNDEAD_RELIGION_REGEX)).toBeInTheDocument();
});
it("shows multiple skills for types with dual skill mapping", () => {
const beastCreature: Pf2eCreature = {
...GOBLIN_WARRIOR,
traits: ["small", "beast"],
};
renderStatBlock(beastCreature);
expect(screen.getByText(RK_BEAST_SKILLS_REGEX)).toBeInTheDocument();
});
it("omits Recall Knowledge when no type trait is recognized", () => {
const noTypeCreature: Pf2eCreature = {
...GOBLIN_WARRIOR,
traits: ["small", "goblin"],
};
renderStatBlock(noTypeCreature);
expect(screen.queryByText("Recall Knowledge")).not.toBeInTheDocument();
});
});
describe("perception and senses", () => {
it("renders perception modifier and senses", () => {
renderStatBlock(GOBLIN_WARRIOR);

View File

@@ -1,5 +1,5 @@
import type { Pf2eCreature, SpellReference } from "@initiative/domain";
import { formatInitiativeModifier } from "@initiative/domain";
import { formatInitiativeModifier, recallKnowledge } from "@initiative/domain";
import { useCallback, useRef, useState } from "react";
import { SpellDetailPopover } from "./spell-detail-popover.js";
import {
@@ -113,6 +113,8 @@ export function Pf2eStatBlock({ creature }: Readonly<Pf2eStatBlockProps>) {
);
const handleCloseSpell = useCallback(() => setOpenSpell(null), []);
const rk = recallKnowledge(creature.level, creature.traits);
const abilityEntries = [
{ label: "Str", mod: creature.abilityMods.str },
{ label: "Dex", mod: creature.abilityMods.dex },
@@ -147,6 +149,12 @@ export function Pf2eStatBlock({ creature }: Readonly<Pf2eStatBlockProps>) {
<p className="mt-1 text-muted-foreground text-xs">
{creature.sourceDisplayName}
</p>
{rk && (
<p className="mt-1 text-sm">
<span className="font-semibold">Recall Knowledge</span> DC {rk.dc}{" "}
&bull; {capitalize(rk.type)} ({rk.skills.join("/")})
</p>
)}
</div>
<SectionDivider />