Add jsinspect-plus structural duplication gate, extract shared helpers

Add jsinspect-plus (AST-based structural duplication detector) to pnpm
check with threshold 50 / min 3 instances. Fix all findings:

- Extract condition icon/color maps to shared condition-styles.ts
- Extract useClickOutside hook (5 components)
- Extract dispatchAction + resolveAndRename in use-encounter
- Extract runEncounterAction in application layer (13 use cases)
- Extract findCombatant helper in domain (9 functions)
- Extract TraitSection in stat-block (4 trait rendering blocks)
- Extract DialogHeader in dialog.tsx (4 dialogs)

Net result: -263 lines across 40 files.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

packages/application/src/add-combatant-use-case.ts

@@ -4,9 +4,9 @@ import {
 	type CombatantInit,
 	type DomainError,
 	type DomainEvent,
-	isDomainError,
 } from "@initiative/domain";
 import type { EncounterStore } from "./ports.js";
+import { runEncounterAction } from "./run-encounter-action.js";
 
 export function addCombatantUseCase(
 	store: EncounterStore,
@@ -14,13 +14,7 @@ export function addCombatantUseCase(
 	name: string,
 	init?: CombatantInit,
 ): DomainEvent[] | DomainError {
-	const encounter = store.get();
-	const result = addCombatant(encounter, id, name, init);
-
-	if (isDomainError(result)) {
-		return result;
-	}
-
-	store.save(result.encounter);
-	return result.events;
+	return runEncounterAction(store, (encounter) =>
+		addCombatant(encounter, id, name, init),
+	);
 }

packages/application/src/adjust-hp-use-case.ts

@@ -3,22 +3,16 @@ import {
 	type CombatantId,
 	type DomainError,
 	type DomainEvent,
-	isDomainError,
 } from "@initiative/domain";
 import type { EncounterStore } from "./ports.js";
+import { runEncounterAction } from "./run-encounter-action.js";
 
 export function adjustHpUseCase(
 	store: EncounterStore,
 	combatantId: CombatantId,
 	delta: number,
 ): DomainEvent[] | DomainError {
-	const encounter = store.get();
-	const result = adjustHp(encounter, combatantId, delta);
-
-	if (isDomainError(result)) {
-		return result;
-	}
-
-	store.save(result.encounter);
-	return result.events;
+	return runEncounterAction(store, (encounter) =>
+		adjustHp(encounter, combatantId, delta),
+	);
 }

packages/application/src/advance-turn-use-case.ts

@@ -2,20 +2,12 @@ import {
 	advanceTurn,
 	type DomainError,
 	type DomainEvent,
-	isDomainError,
 } from "@initiative/domain";
 import type { EncounterStore } from "./ports.js";
+import { runEncounterAction } from "./run-encounter-action.js";
 
 export function advanceTurnUseCase(
 	store: EncounterStore,
 ): DomainEvent[] | DomainError {
-	const encounter = store.get();
-	const result = advanceTurn(encounter);
-
-	if (isDomainError(result)) {
-		return result;
-	}
-
-	store.save(result.encounter);
-	return result.events;
+	return runEncounterAction(store, (encounter) => advanceTurn(encounter));
 }

packages/application/src/clear-encounter-use-case.ts

@@ -2,20 +2,12 @@ import {
 	clearEncounter,
 	type DomainError,
 	type DomainEvent,
-	isDomainError,
 } from "@initiative/domain";
 import type { EncounterStore } from "./ports.js";
+import { runEncounterAction } from "./run-encounter-action.js";
 
 export function clearEncounterUseCase(
 	store: EncounterStore,
 ): DomainEvent[] | DomainError {
-	const encounter = store.get();
-	const result = clearEncounter(encounter);
-
-	if (isDomainError(result)) {
-		return result;
-	}
-
-	store.save(result.encounter);
-	return result.events;
+	return runEncounterAction(store, (encounter) => clearEncounter(encounter));
 }

packages/application/src/edit-combatant-use-case.ts

@@ -3,22 +3,16 @@ import {
 	type DomainError,
 	type DomainEvent,
 	editCombatant,
-	isDomainError,
 } from "@initiative/domain";
 import type { EncounterStore } from "./ports.js";
+import { runEncounterAction } from "./run-encounter-action.js";
 
 export function editCombatantUseCase(
 	store: EncounterStore,
 	id: CombatantId,
 	newName: string,
 ): DomainEvent[] | DomainError {
-	const encounter = store.get();
-	const result = editCombatant(encounter, id, newName);
-
-	if (isDomainError(result)) {
-		return result;
-	}
-
-	store.save(result.encounter);
-	return result.events;
+	return runEncounterAction(store, (encounter) =>
+		editCombatant(encounter, id, newName),
+	);
 }

packages/application/src/remove-combatant-use-case.ts

@@ -2,22 +2,16 @@ import {
 	type CombatantId,
 	type DomainError,
 	type DomainEvent,
-	isDomainError,
 	removeCombatant,
 } from "@initiative/domain";
 import type { EncounterStore } from "./ports.js";
+import { runEncounterAction } from "./run-encounter-action.js";
 
 export function removeCombatantUseCase(
 	store: EncounterStore,
 	id: CombatantId,
 ): DomainEvent[] | DomainError {
-	const encounter = store.get();
-	const result = removeCombatant(encounter, id);
-
-	if (isDomainError(result)) {
-		return result;
-	}
-
-	store.save(result.encounter);
-	return result.events;
+	return runEncounterAction(store, (encounter) =>
+		removeCombatant(encounter, id),
+	);
 }

packages/application/src/retreat-turn-use-case.ts

@@ -1,21 +1,13 @@
 import {
 	type DomainError,
 	type DomainEvent,
-	isDomainError,
 	retreatTurn,
 } from "@initiative/domain";
 import type { EncounterStore } from "./ports.js";
+import { runEncounterAction } from "./run-encounter-action.js";
 
 export function retreatTurnUseCase(
 	store: EncounterStore,
 ): DomainEvent[] | DomainError {
-	const encounter = store.get();
-	const result = retreatTurn(encounter);
-
-	if (isDomainError(result)) {
-		return result;
-	}
-
-	store.save(result.encounter);
-	return result.events;
+	return runEncounterAction(store, (encounter) => retreatTurn(encounter));
 }

packages/application/src/run-encounter-action.ts

@@ -0,0 +1,27 @@
+import {
+	type DomainError,
+	type DomainEvent,
+	type Encounter,
+	isDomainError,
+} from "@initiative/domain";
+import type { EncounterStore } from "./ports.js";
+
+interface EncounterActionResult {
+	readonly encounter: Encounter;
+	readonly events: DomainEvent[];
+}
+
+export function runEncounterAction(
+	store: EncounterStore,
+	action: (encounter: Encounter) => EncounterActionResult | DomainError,
+): DomainEvent[] | DomainError {
+	const encounter = store.get();
+	const result = action(encounter);
+
+	if (isDomainError(result)) {
+		return result;
+	}
+
+	store.save(result.encounter);
+	return result.events;
+}

packages/application/src/set-ac-use-case.ts

@@ -2,23 +2,17 @@ import {
 	type CombatantId,
 	type DomainError,
 	type DomainEvent,
-	isDomainError,
 	setAc,
 } from "@initiative/domain";
 import type { EncounterStore } from "./ports.js";
+import { runEncounterAction } from "./run-encounter-action.js";
 
 export function setAcUseCase(
 	store: EncounterStore,
 	combatantId: CombatantId,
 	value: number | undefined,
 ): DomainEvent[] | DomainError {
-	const encounter = store.get();
-	const result = setAc(encounter, combatantId, value);
-
-	if (isDomainError(result)) {
-		return result;
-	}
-
-	store.save(result.encounter);
-	return result.events;
+	return runEncounterAction(store, (encounter) =>
+		setAc(encounter, combatantId, value),
+	);
 }

packages/application/src/set-hp-use-case.ts

@@ -2,23 +2,17 @@ import {
 	type CombatantId,
 	type DomainError,
 	type DomainEvent,
-	isDomainError,
 	setHp,
 } from "@initiative/domain";
 import type { EncounterStore } from "./ports.js";
+import { runEncounterAction } from "./run-encounter-action.js";
 
 export function setHpUseCase(
 	store: EncounterStore,
 	combatantId: CombatantId,
 	maxHp: number | undefined,
 ): DomainEvent[] | DomainError {
-	const encounter = store.get();
-	const result = setHp(encounter, combatantId, maxHp);
-
-	if (isDomainError(result)) {
-		return result;
-	}
-
-	store.save(result.encounter);
-	return result.events;
+	return runEncounterAction(store, (encounter) =>
+		setHp(encounter, combatantId, maxHp),
+	);
 }

packages/application/src/set-initiative-use-case.ts

@@ -2,23 +2,17 @@ import {
 	type CombatantId,
 	type DomainError,
 	type DomainEvent,
-	isDomainError,
 	setInitiative,
 } from "@initiative/domain";
 import type { EncounterStore } from "./ports.js";
+import { runEncounterAction } from "./run-encounter-action.js";
 
 export function setInitiativeUseCase(
 	store: EncounterStore,
 	combatantId: CombatantId,
 	value: number | undefined,
 ): DomainEvent[] | DomainError {
-	const encounter = store.get();
-	const result = setInitiative(encounter, combatantId, value);
-
-	if (isDomainError(result)) {
-		return result;
-	}
-
-	store.save(result.encounter);
-	return result.events;
+	return runEncounterAction(store, (encounter) =>
+		setInitiative(encounter, combatantId, value),
+	);
 }

packages/application/src/set-temp-hp-use-case.ts

@@ -2,23 +2,17 @@ import {
 	type CombatantId,
 	type DomainError,
 	type DomainEvent,
-	isDomainError,
 	setTempHp,
 } from "@initiative/domain";
 import type { EncounterStore } from "./ports.js";
+import { runEncounterAction } from "./run-encounter-action.js";
 
 export function setTempHpUseCase(
 	store: EncounterStore,
 	combatantId: CombatantId,
 	tempHp: number | undefined,
 ): DomainEvent[] | DomainError {
-	const encounter = store.get();
-	const result = setTempHp(encounter, combatantId, tempHp);
-
-	if (isDomainError(result)) {
-		return result;
-	}
-
-	store.save(result.encounter);
-	return result.events;
+	return runEncounterAction(store, (encounter) =>
+		setTempHp(encounter, combatantId, tempHp),
+	);
 }

packages/application/src/toggle-concentration-use-case.ts

@@ -2,22 +2,16 @@ import {
 	type CombatantId,
 	type DomainError,
 	type DomainEvent,
-	isDomainError,
 	toggleConcentration,
 } from "@initiative/domain";
 import type { EncounterStore } from "./ports.js";
+import { runEncounterAction } from "./run-encounter-action.js";
 
 export function toggleConcentrationUseCase(
 	store: EncounterStore,
 	combatantId: CombatantId,
 ): DomainEvent[] | DomainError {
-	const encounter = store.get();
-	const result = toggleConcentration(encounter, combatantId);
-
-	if (isDomainError(result)) {
-		return result;
-	}
-
-	store.save(result.encounter);
-	return result.events;
+	return runEncounterAction(store, (encounter) =>
+		toggleConcentration(encounter, combatantId),
+	);
 }

packages/application/src/toggle-condition-use-case.ts

@@ -3,23 +3,17 @@ import {
 	type ConditionId,
 	type DomainError,
 	type DomainEvent,
-	isDomainError,
 	toggleCondition,
 } from "@initiative/domain";
 import type { EncounterStore } from "./ports.js";
+import { runEncounterAction } from "./run-encounter-action.js";
 
 export function toggleConditionUseCase(
 	store: EncounterStore,
 	combatantId: CombatantId,
 	conditionId: ConditionId,
 ): DomainEvent[] | DomainError {
-	const encounter = store.get();
-	const result = toggleCondition(encounter, combatantId, conditionId);
-
-	if (isDomainError(result)) {
-		return result;
-	}
-
-	store.save(result.encounter);
-	return result.events;
+	return runEncounterAction(store, (encounter) =>
+		toggleCondition(encounter, combatantId, conditionId),
+	);
 }