Compare commits

..

22 Commits

Author SHA1 Message Date
Lukas
09a801487d Add PF2e weak/elite creature adjustments with stat block toggle
All checks were successful
CI / check (push) Successful in 2m32s
CI / build-image (push) Successful in 19s
Weak/Normal/Elite toggle in PF2e stat block header applies standard
adjustments (level, AC, HP, saves, Perception, attacks, damage) to
individual combatants. Adjusted stats are highlighted blue (elite) or
red (weak). Persisted via creatureAdjustment field on Combatant.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-11 02:24:30 +02:00
Lukas
a44f82127e Add PF2e attack effects, ability frequency, and perception details
All checks were successful
CI / check (push) Successful in 2m31s
CI / build-image (push) Successful in 17s
Show inline on-hit effects on attack lines (e.g., "plus Grab"), frequency
limits on abilities (e.g., "(1/day)"), and perception details text alongside
senses. Strip redundant frequency lines from Foundry descriptions.

Also add resilient PF2e source fetching: batched requests with retry,
graceful handling of ad-blocker-blocked creature files (partial success
with toast warning and re-fetch prompt for missing creatures).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-10 23:37:30 +02:00
Lukas
c3707cf0b6 Add PF2e attack effects, ability frequency, and perception details
Show inline on-hit effects on attack lines (e.g., "plus Grab"), frequency
limits on abilities (e.g., "(1/day)"), and perception details text alongside
senses. Strip redundant frequency lines from Foundry descriptions.

Also add resilient PF2e source fetching: batched requests with retry,
graceful handling of ad-blocker-blocked creature files (partial success
with toast warning and re-fetch prompt for missing creatures).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-10 23:37:03 +02:00
Lukas
1eaeecad32 Add PF2e equipment display with detail popovers in stat blocks
All checks were successful
CI / check (push) Successful in 2m31s
CI / build-image (push) Successful in 17s
Extract shared DetailPopover shell from spell popovers. Normalize
weapon/consumable/equipment/armor items from Foundry data into
mundane (Items line) and detailed (Equipment section with clickable
popovers). Scrolls/wands show embedded spell info. Bump IDB cache v7.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-10 21:11:54 +02:00
Lukas
e2e8297c95 Add Recall Knowledge DC and skill to PF2e stat blocks
All checks were successful
CI / check (push) Successful in 2m29s
CI / build-image (push) Successful in 19s
Display Recall Knowledge line below trait tags showing DC (from level
via standard DC-by-level table, adjusted for rarity) and associated
skill derived from creature type trait. Omitted for D&D creatures and
creatures with no recognized type trait.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-10 18:43:49 +02:00
Lukas
e161645228 Add PF2e spell description popovers in stat blocks
All checks were successful
CI / check (push) Successful in 2m31s
CI / build-image (push) Successful in 26s
Clicking a spell name in a PF2e creature's stat block now opens a
popover (desktop) or bottom sheet (mobile) showing full spell details:
description, traits, rank, range, target, area, duration, defense,
action cost icons, and heightening rules. All data is sourced from
the embedded Foundry VTT spell items already in the bestiary cache.

- Add SpellReference type replacing bare string spell arrays
- Extract full spell data in pf2e-bestiary-adapter (description,
  traits, traditions, range, target, area, duration, defense,
  action cost, heightening, overlays)
- Strip inline heightening text from descriptions to avoid duplication
- Bold save outcome labels (Critical Success/Failure) in descriptions
- Bump DB_VERSION to 6 for cache invalidation
- Add useSwipeToDismissDown hook for mobile bottom sheet
- Portal popover to document.body to escape transformed ancestors

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-10 16:18:08 +02:00
Lukas
9b0cb38897 Fix oxlint --deny-warnings and eliminate all biome-ignores
--deny warnings was a no-op (not a valid category); the correct flag
is --deny-warnings. Fixed all 8 pre-existing warnings and removed
every biome-ignore from source and test files. Simplified the check
script to zero-tolerance: any biome-ignore now fails the build.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-10 16:17:30 +02:00
Lukas
5cb5721a6f Redesign PF2e action icons with diamond-parallel geometry
All checks were successful
CI / check (push) Successful in 2m27s
CI / build-image (push) Successful in 18s
Align cutout edges to 45° angles parallel to outer diamond shape.
Multi-action icons use outlined diamonds with matched border width.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-09 01:07:45 +02:00
Lukas
48795071f7 Hide concentration UI in PF2e mode
All checks were successful
CI / check (push) Successful in 2m26s
CI / build-image (push) Successful in 18s
PF2e uses action-based spell sustaining, not damage-triggered
concentration checks. The Brain icon, purple border accent, and
damage pulse animation are now hidden when PF2e is active, and
the freed gutter column is reclaimed for row content. Concentration
state is preserved so switching back to D&D restores it.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-09 00:25:54 +02:00
Lukas
f721d7e5da Allow /commit skill to be invoked by other skills
All checks were successful
CI / check (push) Successful in 2m26s
CI / build-image (push) Successful in 5s
Remove disable-model-invocation so /ship can delegate to /commit.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-09 00:13:59 +02:00
Lukas
e7930a1431 Add /ship skill for commit, tag, and push workflow
All checks were successful
CI / check (push) Successful in 2m27s
CI / build-image (push) Successful in 18s
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-09 00:09:03 +02:00
Lukas
553e09f280 Enforce maximum values for PF2e numbered conditions
Cap dying (4), doomed (3), wounded (3), and slowed (3) at their
rule-defined maximums. The domain clamps values in setConditionValue
and the condition picker disables the [+] button at the cap.

Closes #31

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-09 00:04:47 +02:00
Lukas
1c107a500b Switch PF2e data source from Pf2eTools to Foundry VTT PF2e
All checks were successful
CI / check (push) Successful in 2m25s
CI / build-image (push) Successful in 23s
Replace the stagnant Pf2eTools bestiary with Foundry VTT PF2e system
data (github.com/foundryvtt/pf2e, v13-dev branch). This gives us 4,355
remaster-era creatures across 49 sources including Monster Core 1+2 and
all adventure paths.

Changes:
- Rewrite index generation script to walk Foundry pack directories
- Rewrite PF2e normalization adapter for Foundry JSON shape (system.*
  fields, items[] for attacks/abilities/spells)
- Add stripFoundryTags utility for Foundry HTML + enrichment syntax
- Implement multi-file source fetching (one request per creature file)
- Add spellcasting section to PF2e stat block (ranked spells + cantrips)
- Add saveConditional and hpDetails to PF2e domain type and stat block
- Add size and rarity to PF2e trait tags
- Filter redundant glossary abilities (healing when in hp.details,
  spell mechanic reminders, allSaves duplicates)
- Add PF2e stat block component tests (22 tests)
- Bump IndexedDB cache version to 5 for clean migration

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-08 21:05:00 +02:00
Lukas
0c235112ee Improve PF2e stat block action icons, triggers, and tag handling
- Replace unicode action cost chars with custom SVG icons (diamond
  with chevron for actions, outlined diamond for free, curved arrow
  for reaction) rendered inline via ActivityCost on TraitBlock
- Add activity icons to attacks (all Strikes default to single action)
- Add trigger/effect rendering for reaction abilities (bold labels)
- Fix nested tag stripping ({@b ...{@spell ...}...}) by looping
- Move icon after ability name to match AoN format

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-08 10:36:30 +02:00
Lukas
57278e0c82 Add PF2e action cost icons to ability names
All checks were successful
CI / check (push) Successful in 2m21s
CI / build-image (push) Successful in 17s
Show Unicode action icons (◆/◆◆/◆◆◆ for actions, ◇ for free,
↺ for reaction) in ability names from the activity field.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-07 16:31:24 +02:00
Lukas
f9cfaa2570 Include traits on PF2e ability blocks
Parse and display traits (concentrate, divine, polymorph, etc.)
on ability entries, matching how attack traits are already shown.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-07 16:29:08 +02:00
Lukas
3e62e54274 Strip all angle brackets in PF2e attack traits and damage
All checks were successful
CI / check (push) Successful in 2m23s
CI / build-image (push) Successful in 17s
Broaden stripDiceBrackets to stripAngleBrackets to handle all
PF2e tools angle-bracket formatting (e.g. <10 feet>, <15 feet>),
not just dice notation. Also strip in damage text.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-07 15:34:28 +02:00
Lukas
12a089dfd7 Fix PF2e condition tooltip descriptions and sort picker alphabetically
Correct inaccurate PF2e condition descriptions against official AoN
rules (blinded, deafened, confused, grabbed, hidden, paralyzed,
unconscious, drained, fascinated, enfeebled, stunned). Sort condition
picker alphabetically per game system.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-07 14:29:49 +02:00
Lukas
65e4db153b Fix PF2e stat block senses and attack trait rendering
All checks were successful
CI / check (push) Successful in 2m20s
CI / build-image (push) Successful in 17s
- Format senses with type (imprecise/precise) and range in feet,
  and strip {@ability} tags (e.g. tremorsense)
- Strip angle-bracket dice notation in attack traits (<d8> → d8)
- Fix existing weakness/resistance tests to nest under defenses
- Fix non-null assertions in 5e bestiary adapter tests

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-07 12:23:08 +02:00
Lukas
8dbff66ce1 Fix "undefined" in PF2e stat block weaknesses/resistances
All checks were successful
CI / check (push) Successful in 2m23s
CI / build-image (push) Successful in 30s
Some PF2e creatures (e.g. Giant Mining Bee) have qualitative
weaknesses without a numeric amount, causing "undefined" to
render in the stat block. Handle missing amounts gracefully.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-07 12:06:22 +02:00
Lukas
e62c49434c Add Pathfinder 2e game system mode
All checks were successful
CI / check (push) Successful in 2m21s
CI / build-image (push) Successful in 24s
Implements PF2e as an alternative game system alongside D&D 5e/5.5e.
Settings modal "Game System" selector switches conditions, bestiary,
stat block layout, and initiative calculation between systems.

- Valued conditions with increment/decrement UX (Clumsy 2, Frightened 3)
- 2,502 PF2e creatures from bundled search index (77 sources)
- PF2e stat block: level, traits, Perception, Fort/Ref/Will, ability mods
- Perception-based initiative rolling
- System-scoped source cache (D&D and PF2e sources don't collide)
- Backwards-compatible condition rehydration (ConditionId[] → ConditionEntry[])
- Difficulty indicator hidden in PF2e mode (excluded from MVP)

Closes dostulata/initiative#19

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-07 01:26:22 +02:00
Lukas
8f6eebc43b Render structured list and table entries in stat block traits
All checks were successful
CI / check (push) Successful in 2m21s
CI / build-image (push) Successful in 17s
Stat block traits containing 5etools list (e.g. Confusing Burble d4
effects) or table entries were silently dropped. The adapter now
produces structured TraitSegment[] instead of flat text, preserving
lists and tables as first-class data. The stat block component renders
labeled list items inline (bold label + flowing text) matching the
5etools layout. Also fixes support for the singular "entry" field on
list items and bumps the bestiary cache version to force re-normalize.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-04 22:09:11 +02:00
101 changed files with 8629 additions and 743 deletions

View File

@@ -1,7 +1,6 @@
--- ---
name: commit name: commit
description: Create a git commit with pre-commit hooks (bypasses sandbox restrictions). description: Create a git commit with pre-commit hooks (bypasses sandbox restrictions).
disable-model-invocation: true
allowed-tools: Bash(git *), Bash(pnpm *) allowed-tools: Bash(git *), Bash(pnpm *)
--- ---

View File

@@ -0,0 +1,54 @@
---
name: ship
description: Commit, tag with the next version, and push to remote.
disable-model-invocation: true
allowed-tools: Bash(git *), Bash(pnpm *), Skill
---
## Instructions
Commit current changes, create the next version tag, and push everything to remote.
### Step 1 — Commit
Use the `/commit` skill to stage and commit changes. Pass along any user arguments as the commit message.
```
/commit $ARGUMENTS
```
### Step 2 — Tag
Get the latest tag and increment the patch number (e.g., `0.9.27``0.9.28`). Create the tag:
```bash
git tag --sort=-v:refname | head -1
```
```bash
git tag <next-version>
```
### Step 3 — Push
Push the commit and tag to remote:
```bash
git push && git push --tags
```
### Step 4 — Verify
Confirm the tag exists on the pushed commit:
```bash
git log --oneline -1 --decorate
```
## User arguments
```text
$ARGUMENTS
```
If the user provided arguments, treat them as the commit message or guidance for what to commit.

View File

@@ -29,6 +29,6 @@
"@vitejs/plugin-react": "^6.0.1", "@vitejs/plugin-react": "^6.0.1",
"jsdom": "^29.0.1", "jsdom": "^29.0.1",
"tailwindcss": "^4.2.2", "tailwindcss": "^4.2.2",
"vite": "^8.0.1" "vite": "^8.0.5"
} }
} }

View File

@@ -1,5 +1,5 @@
import { import {
type Creature, type AnyCreature,
type CreatureId, type CreatureId,
EMPTY_UNDO_REDO_STATE, EMPTY_UNDO_REDO_STATE,
type Encounter, type Encounter,
@@ -12,10 +12,10 @@ export function createTestAdapters(options?: {
encounter?: Encounter | null; encounter?: Encounter | null;
undoRedoState?: UndoRedoState; undoRedoState?: UndoRedoState;
playerCharacters?: PlayerCharacter[]; playerCharacters?: PlayerCharacter[];
creatures?: Map<CreatureId, Creature>; creatures?: Map<CreatureId, AnyCreature>;
sources?: Map< sources?: Map<
string, string,
{ displayName: string; creatures: Creature[]; cachedAt: number } { displayName: string; creatures: AnyCreature[]; cachedAt: number }
>; >;
}): Adapters { }): Adapters {
let storedEncounter = options?.encounter ?? null; let storedEncounter = options?.encounter ?? null;
@@ -25,7 +25,7 @@ export function createTestAdapters(options?: {
options?.sources ?? options?.sources ??
new Map< new Map<
string, string,
{ displayName: string; creatures: Creature[]; cachedAt: number } { displayName: string; creatures: AnyCreature[]; cachedAt: number }
>(); >();
// Pre-populate sourceStore from creatures map if provided // Pre-populate sourceStore from creatures map if provided
@@ -33,7 +33,7 @@ export function createTestAdapters(options?: {
// No-op: creatures are accessed directly from the map // No-op: creatures are accessed directly from the map
} }
const creatureMap = options?.creatures ?? new Map<CreatureId, Creature>(); const creatureMap = options?.creatures ?? new Map<CreatureId, AnyCreature>();
return { return {
encounterPersistence: { encounterPersistence: {
@@ -55,8 +55,9 @@ export function createTestAdapters(options?: {
}, },
}, },
bestiaryCache: { bestiaryCache: {
cacheSource(sourceCode, displayName, creatures) { cacheSource(system, sourceCode, displayName, creatures) {
sourceStore.set(sourceCode, { const key = `${system}:${sourceCode}`;
sourceStore.set(key, {
displayName, displayName,
creatures, creatures,
cachedAt: Date.now(), cachedAt: Date.now(),
@@ -66,21 +67,25 @@ export function createTestAdapters(options?: {
} }
return Promise.resolve(); return Promise.resolve();
}, },
isSourceCached(sourceCode) { isSourceCached(system, sourceCode) {
return Promise.resolve(sourceStore.has(sourceCode)); return Promise.resolve(sourceStore.has(`${system}:${sourceCode}`));
}, },
getCachedSources() { getCachedSources(system) {
return Promise.resolve( return Promise.resolve(
[...sourceStore.entries()].map(([sourceCode, info]) => ({ [...sourceStore.entries()]
sourceCode, .filter(([key]) => !system || key.startsWith(`${system}:`))
.map(([key, info]) => ({
sourceCode: key.includes(":")
? key.slice(key.indexOf(":") + 1)
: key,
displayName: info.displayName, displayName: info.displayName,
creatureCount: info.creatures.length, creatureCount: info.creatures.length,
cachedAt: info.cachedAt, cachedAt: info.cachedAt,
})), })),
); );
}, },
clearSource(sourceCode) { clearSource(system, sourceCode) {
sourceStore.delete(sourceCode); sourceStore.delete(`${system}:${sourceCode}`);
return Promise.resolve(); return Promise.resolve();
}, },
clearAll() { clearAll() {
@@ -104,5 +109,14 @@ export function createTestAdapters(options?: {
}, },
getSourceDisplayName: (sourceCode) => sourceCode, getSourceDisplayName: (sourceCode) => sourceCode,
}, },
pf2eBestiaryIndex: {
loadIndex: () => ({ sources: {}, creatures: [] }),
getAllSourceCodes: () => [],
getDefaultFetchUrl: (sourceCode) =>
`https://example.com/creatures-${sourceCode.toLowerCase()}.json`,
getSourceDisplayName: (sourceCode) => sourceCode,
getCreaturePathsForSource: () => [],
getCreatureNamesByPaths: () => new Map(),
},
}; };
} }

View File

@@ -33,8 +33,7 @@ async function addCombatant(
opts?: { maxHp?: string }, opts?: { maxHp?: string },
) { ) {
const inputs = screen.getAllByPlaceholderText("+ Add combatants"); const inputs = screen.getAllByPlaceholderText("+ Add combatants");
// biome-ignore lint/style/noNonNullAssertion: getAllBy always returns at least one const input = inputs.at(-1) ?? inputs[0];
const input = inputs.at(-1)!;
await user.type(input, name); await user.type(input, name);
if (opts?.maxHp) { if (opts?.maxHp) {

View File

@@ -198,21 +198,23 @@ describe("ConfirmButton", () => {
it("Enter/Space keydown stops propagation to prevent parent handlers", () => { it("Enter/Space keydown stops propagation to prevent parent handlers", () => {
const parentHandler = vi.fn(); const parentHandler = vi.fn();
render( function Wrapper() {
// biome-ignore lint/a11y/noStaticElementInteractions: test wrapper return (
// biome-ignore lint/a11y/noNoninteractiveElementInteractions: test wrapper <button type="button" onKeyDown={parentHandler}>
<div onKeyDown={parentHandler}>
<ConfirmButton <ConfirmButton
icon={<XIcon />} icon={<XIcon />}
label="Remove combatant" label="Remove combatant"
onConfirm={vi.fn()} onConfirm={vi.fn()}
/> />
</div>, </button>
); );
const button = screen.getByRole("button"); }
render(<Wrapper />);
const buttons = screen.getAllByRole("button");
const confirmButton = buttons.at(-1) ?? buttons[0];
fireEvent.keyDown(button, { key: "Enter" }); fireEvent.keyDown(confirmButton, { key: "Enter" });
fireEvent.keyDown(button, { key: " " }); fireEvent.keyDown(confirmButton, { key: " " });
expect(parentHandler).not.toHaveBeenCalled(); expect(parentHandler).not.toHaveBeenCalled();
}); });

View File

@@ -16,12 +16,18 @@ vi.mock("../contexts/bestiary-context.js", () => ({
useBestiaryContext: vi.fn(), useBestiaryContext: vi.fn(),
})); }));
vi.mock("../contexts/encounter-context.js", () => ({
useEncounterContext: vi.fn(),
}));
import { StatBlockPanel } from "../components/stat-block-panel.js"; import { StatBlockPanel } from "../components/stat-block-panel.js";
import { useBestiaryContext } from "../contexts/bestiary-context.js"; import { useBestiaryContext } from "../contexts/bestiary-context.js";
import { useEncounterContext } from "../contexts/encounter-context.js";
import { useSidePanelContext } from "../contexts/side-panel-context.js"; import { useSidePanelContext } from "../contexts/side-panel-context.js";
const mockUseSidePanelContext = vi.mocked(useSidePanelContext); const mockUseSidePanelContext = vi.mocked(useSidePanelContext);
const mockUseBestiaryContext = vi.mocked(useBestiaryContext); const mockUseBestiaryContext = vi.mocked(useBestiaryContext);
const mockUseEncounterContext = vi.mocked(useEncounterContext);
const CLOSE_REGEX = /close/i; const CLOSE_REGEX = /close/i;
const COLLAPSE_REGEX = /collapse/i; const COLLAPSE_REGEX = /collapse/i;
@@ -82,6 +88,7 @@ function setupMocks(overrides: PanelOverrides = {}) {
mockUseSidePanelContext.mockReturnValue({ mockUseSidePanelContext.mockReturnValue({
selectedCreatureId: panelRole === "browse" ? creatureId : null, selectedCreatureId: panelRole === "browse" ? creatureId : null,
selectedCombatantId: null,
pinnedCreatureId: panelRole === "pinned" ? creatureId : null, pinnedCreatureId: panelRole === "pinned" ? creatureId : null,
isRightPanelCollapsed: panelRole === "browse" ? isCollapsed : false, isRightPanelCollapsed: panelRole === "browse" ? isCollapsed : false,
isWideDesktop: false, isWideDesktop: false,
@@ -110,6 +117,11 @@ function setupMocks(overrides: PanelOverrides = {}) {
refreshCache: vi.fn(), refreshCache: vi.fn(),
} as ReturnType<typeof useBestiaryContext>); } as ReturnType<typeof useBestiaryContext>);
mockUseEncounterContext.mockReturnValue({
encounter: { combatants: [], activeIndex: 0, roundNumber: 1 },
setCreatureAdjustment: vi.fn(),
} as unknown as ReturnType<typeof useEncounterContext>);
return { onToggleCollapse, onPin, onUnpin, onDismiss }; return { onToggleCollapse, onPin, onUnpin, onDismiss };
} }

View File

@@ -1,9 +1,24 @@
import type { TraitBlock } from "@initiative/domain";
import { beforeAll, describe, expect, it } from "vitest"; import { beforeAll, describe, expect, it } from "vitest";
import { import {
normalizeBestiary, normalizeBestiary,
setSourceDisplayNames, setSourceDisplayNames,
} from "../bestiary-adapter.js"; } from "../bestiary-adapter.js";
/** Flatten segments to a single string for simple text assertions. */
function flatText(trait: TraitBlock | undefined): string {
if (!trait) return "";
return trait.segments
.map((s) =>
s.type === "text"
? s.value
: s.items
.map((i) => (i.label ? `${i.label}. ${i.text}` : i.text))
.join(" "),
)
.join(" ");
}
beforeAll(() => { beforeAll(() => {
setSourceDisplayNames({ XMM: "MM 2024" }); setSourceDisplayNames({ XMM: "MM 2024" });
}); });
@@ -74,11 +89,11 @@ describe("normalizeBestiary", () => {
expect(c.senses).toBe("Darkvision 60 ft."); expect(c.senses).toBe("Darkvision 60 ft.");
expect(c.languages).toBe("Common, Goblin"); expect(c.languages).toBe("Common, Goblin");
expect(c.actions).toHaveLength(1); expect(c.actions).toHaveLength(1);
expect(c.actions?.[0].text).toContain("Melee Attack Roll:"); expect(flatText(c.actions?.[0])).toContain("Melee Attack Roll:");
expect(c.actions?.[0].text).not.toContain("{@"); expect(flatText(c.actions?.[0])).not.toContain("{@");
expect(c.bonusActions).toHaveLength(1); expect(c.bonusActions).toHaveLength(1);
expect(c.bonusActions?.[0].text).toContain("Disengage"); expect(flatText(c.bonusActions?.[0])).toContain("Disengage");
expect(c.bonusActions?.[0].text).not.toContain("{@"); expect(flatText(c.bonusActions?.[0])).not.toContain("{@");
}); });
it("normalizes a creature with legendary actions", () => { it("normalizes a creature with legendary actions", () => {
@@ -166,17 +181,20 @@ describe("normalizeBestiary", () => {
expect(sc?.name).toBe("Spellcasting"); expect(sc?.name).toBe("Spellcasting");
expect(sc?.headerText).toContain("DC 15"); expect(sc?.headerText).toContain("DC 15");
expect(sc?.headerText).not.toContain("{@"); expect(sc?.headerText).not.toContain("{@");
expect(sc?.atWill).toEqual(["Detect Magic", "Mage Hand"]); expect(sc?.atWill).toEqual([
{ name: "Detect Magic" },
{ name: "Mage Hand" },
]);
expect(sc?.daily).toHaveLength(2); expect(sc?.daily).toHaveLength(2);
expect(sc?.daily).toContainEqual({ expect(sc?.daily).toContainEqual({
uses: 2, uses: 2,
each: true, each: true,
spells: ["Fireball"], spells: [{ name: "Fireball" }],
}); });
expect(sc?.daily).toContainEqual({ expect(sc?.daily).toContainEqual({
uses: 1, uses: 1,
each: false, each: false,
spells: ["Dimension Door"], spells: [{ name: "Dimension Door" }],
}); });
}); });
@@ -333,9 +351,9 @@ describe("normalizeBestiary", () => {
const creatures = normalizeBestiary(raw); const creatures = normalizeBestiary(raw);
const bite = creatures[0].actions?.[0]; const bite = creatures[0].actions?.[0];
expect(bite?.text).toContain("Melee Weapon Attack:"); expect(flatText(bite)).toContain("Melee Weapon Attack:");
expect(bite?.text).not.toContain("mw"); expect(flatText(bite)).not.toContain("mw");
expect(bite?.text).not.toContain("{@"); expect(flatText(bite)).not.toContain("{@");
}); });
it("handles fly speed with hover condition", () => { it("handles fly speed with hover condition", () => {
@@ -368,4 +386,131 @@ describe("normalizeBestiary", () => {
const creatures = normalizeBestiary(raw); const creatures = normalizeBestiary(raw);
expect(creatures[0].speed).toBe("10 ft., fly 90 ft. (hover)"); expect(creatures[0].speed).toBe("10 ft., fly 90 ft. (hover)");
}); });
it("renders list items with singular entry field (e.g. Confusing Burble d4 effects)", () => {
const raw = {
monster: [
{
name: "Jabberwock",
source: "WBtW",
size: ["H"],
type: "dragon",
ac: [18],
hp: { average: 115, formula: "10d12 + 50" },
speed: { walk: 30 },
str: 22,
dex: 15,
con: 20,
int: 8,
wis: 14,
cha: 16,
passive: 12,
cr: "13",
trait: [
{
name: "Confusing Burble",
entries: [
"The jabberwock burbles unless {@condition incapacitated}. Roll a {@dice d4}:",
{
type: "list",
style: "list-hang-notitle",
items: [
{
type: "item",
name: "1-2",
entry: "The creature does nothing.",
},
{
type: "item",
name: "3",
entry:
"The creature uses all its movement to move in a random direction.",
},
{
type: "item",
name: "4",
entry:
"The creature makes one melee attack against a random creature.",
},
],
},
],
},
],
},
],
};
const creatures = normalizeBestiary(raw);
const trait = creatures[0].traits?.[0];
expect(trait).toBeDefined();
expect(trait?.name).toBe("Confusing Burble");
expect(trait?.segments).toHaveLength(2);
expect(trait?.segments[0]).toEqual({
type: "text",
value: expect.stringContaining("d4"),
});
expect(trait?.segments[1]).toEqual({
type: "list",
items: [
{ label: "1-2", text: "The creature does nothing." },
{
label: "3",
text: expect.stringContaining("random direction"),
},
{ label: "4", text: expect.stringContaining("melee attack") },
],
});
});
it("renders table entries as structured list segments", () => {
const raw = {
monster: [
{
name: "Test Creature",
source: "XMM",
size: ["M"],
type: "humanoid",
ac: [12],
hp: { average: 40, formula: "9d8" },
speed: { walk: 30 },
str: 10,
dex: 10,
con: 10,
int: 10,
wis: 10,
cha: 10,
passive: 10,
cr: "1",
trait: [
{
name: "Random Effect",
entries: [
"Roll on the table:",
{
type: "table",
colLabels: ["d4", "Effect"],
rows: [
["1", "Nothing happens."],
["2", "Something happens."],
],
},
],
},
],
},
],
};
const creatures = normalizeBestiary(raw);
const trait = creatures[0].traits?.[0];
expect(trait).toBeDefined();
expect(trait?.segments[1]).toEqual({
type: "list",
items: [
{ label: "1", text: "Nothing happens." },
{ label: "2", text: "Something happens." },
],
});
});
}); });

View File

@@ -46,17 +46,17 @@ describe("bestiary-cache fallback (IndexedDB unavailable)", () => {
it("cacheSource falls back to in-memory store", async () => { it("cacheSource falls back to in-memory store", async () => {
const creatures = [makeCreature("mm:goblin", "Goblin")]; const creatures = [makeCreature("mm:goblin", "Goblin")];
await cacheSource("MM", "Monster Manual", creatures); await cacheSource("dnd", "MM", "Monster Manual", creatures);
expect(await isSourceCached("MM")).toBe(true); expect(await isSourceCached("dnd", "MM")).toBe(true);
}); });
it("isSourceCached returns false for uncached source", async () => { it("isSourceCached returns false for uncached source", async () => {
expect(await isSourceCached("XGE")).toBe(false); expect(await isSourceCached("dnd", "XGE")).toBe(false);
}); });
it("getCachedSources returns sources from in-memory store", async () => { it("getCachedSources returns sources from in-memory store", async () => {
await cacheSource("MM", "Monster Manual", [ await cacheSource("dnd", "MM", "Monster Manual", [
makeCreature("mm:goblin", "Goblin"), makeCreature("mm:goblin", "Goblin"),
]); ]);
@@ -68,7 +68,7 @@ describe("bestiary-cache fallback (IndexedDB unavailable)", () => {
it("loadAllCachedCreatures assembles creatures from in-memory store", async () => { it("loadAllCachedCreatures assembles creatures from in-memory store", async () => {
const goblin = makeCreature("mm:goblin", "Goblin"); const goblin = makeCreature("mm:goblin", "Goblin");
await cacheSource("MM", "Monster Manual", [goblin]); await cacheSource("dnd", "MM", "Monster Manual", [goblin]);
const map = await loadAllCachedCreatures(); const map = await loadAllCachedCreatures();
expect(map.size).toBe(1); expect(map.size).toBe(1);
@@ -76,17 +76,17 @@ describe("bestiary-cache fallback (IndexedDB unavailable)", () => {
}); });
it("clearSource removes a single source from in-memory store", async () => { it("clearSource removes a single source from in-memory store", async () => {
await cacheSource("MM", "Monster Manual", []); await cacheSource("dnd", "MM", "Monster Manual", []);
await cacheSource("VGM", "Volo's Guide", []); await cacheSource("dnd", "VGM", "Volo's Guide", []);
await clearSource("MM"); await clearSource("dnd", "MM");
expect(await isSourceCached("MM")).toBe(false); expect(await isSourceCached("dnd", "MM")).toBe(false);
expect(await isSourceCached("VGM")).toBe(true); expect(await isSourceCached("dnd", "VGM")).toBe(true);
}); });
it("clearAll removes all data from in-memory store", async () => { it("clearAll removes all data from in-memory store", async () => {
await cacheSource("MM", "Monster Manual", []); await cacheSource("dnd", "MM", "Monster Manual", []);
await clearAll(); await clearAll();
const sources = await getCachedSources(); const sources = await getCachedSources();

View File

@@ -69,17 +69,17 @@ describe("bestiary-cache", () => {
describe("cacheSource", () => { describe("cacheSource", () => {
it("stores creatures and metadata", async () => { it("stores creatures and metadata", async () => {
const creatures = [makeCreature("mm:goblin", "Goblin")]; const creatures = [makeCreature("mm:goblin", "Goblin")];
await cacheSource("MM", "Monster Manual", creatures); await cacheSource("dnd", "MM", "Monster Manual", creatures);
expect(fakeStore.has("MM")).toBe(true); expect(fakeStore.has("dnd:MM")).toBe(true);
const record = fakeStore.get("MM") as { const record = fakeStore.get("dnd:MM") as {
sourceCode: string; sourceCode: string;
displayName: string; displayName: string;
creatures: Creature[]; creatures: Creature[];
creatureCount: number; creatureCount: number;
cachedAt: number; cachedAt: number;
}; };
expect(record.sourceCode).toBe("MM"); expect(record.sourceCode).toBe("dnd:MM");
expect(record.displayName).toBe("Monster Manual"); expect(record.displayName).toBe("Monster Manual");
expect(record.creatures).toHaveLength(1); expect(record.creatures).toHaveLength(1);
expect(record.creatureCount).toBe(1); expect(record.creatureCount).toBe(1);
@@ -89,12 +89,12 @@ describe("bestiary-cache", () => {
describe("isSourceCached", () => { describe("isSourceCached", () => {
it("returns false for uncached source", async () => { it("returns false for uncached source", async () => {
expect(await isSourceCached("XGE")).toBe(false); expect(await isSourceCached("dnd", "XGE")).toBe(false);
}); });
it("returns true after caching", async () => { it("returns true after caching", async () => {
await cacheSource("MM", "Monster Manual", []); await cacheSource("dnd", "MM", "Monster Manual", []);
expect(await isSourceCached("MM")).toBe(true); expect(await isSourceCached("dnd", "MM")).toBe(true);
}); });
}); });
@@ -105,11 +105,11 @@ describe("bestiary-cache", () => {
}); });
it("returns source info with creature counts", async () => { it("returns source info with creature counts", async () => {
await cacheSource("MM", "Monster Manual", [ await cacheSource("dnd", "MM", "Monster Manual", [
makeCreature("mm:goblin", "Goblin"), makeCreature("mm:goblin", "Goblin"),
makeCreature("mm:orc", "Orc"), makeCreature("mm:orc", "Orc"),
]); ]);
await cacheSource("VGM", "Volo's Guide", [ await cacheSource("dnd", "VGM", "Volo's Guide", [
makeCreature("vgm:flind", "Flind"), makeCreature("vgm:flind", "Flind"),
]); ]);
@@ -137,8 +137,8 @@ describe("bestiary-cache", () => {
const orc = makeCreature("mm:orc", "Orc"); const orc = makeCreature("mm:orc", "Orc");
const flind = makeCreature("vgm:flind", "Flind"); const flind = makeCreature("vgm:flind", "Flind");
await cacheSource("MM", "Monster Manual", [goblin, orc]); await cacheSource("dnd", "MM", "Monster Manual", [goblin, orc]);
await cacheSource("VGM", "Volo's Guide", [flind]); await cacheSource("dnd", "VGM", "Volo's Guide", [flind]);
const map = await loadAllCachedCreatures(); const map = await loadAllCachedCreatures();
expect(map.size).toBe(3); expect(map.size).toBe(3);
@@ -150,20 +150,20 @@ describe("bestiary-cache", () => {
describe("clearSource", () => { describe("clearSource", () => {
it("removes a single source", async () => { it("removes a single source", async () => {
await cacheSource("MM", "Monster Manual", []); await cacheSource("dnd", "MM", "Monster Manual", []);
await cacheSource("VGM", "Volo's Guide", []); await cacheSource("dnd", "VGM", "Volo's Guide", []);
await clearSource("MM"); await clearSource("dnd", "MM");
expect(await isSourceCached("MM")).toBe(false); expect(await isSourceCached("dnd", "MM")).toBe(false);
expect(await isSourceCached("VGM")).toBe(true); expect(await isSourceCached("dnd", "VGM")).toBe(true);
}); });
}); });
describe("clearAll", () => { describe("clearAll", () => {
it("removes all cached data", async () => { it("removes all cached data", async () => {
await cacheSource("MM", "Monster Manual", []); await cacheSource("dnd", "MM", "Monster Manual", []);
await cacheSource("VGM", "Volo's Guide", []); await cacheSource("dnd", "VGM", "Volo's Guide", []);
await clearAll(); await clearAll();

File diff suppressed because it is too large Load Diff

View File

@@ -0,0 +1,103 @@
import { describe, expect, it } from "vitest";
const PACK_DIR_PREFIX = /^pathfinder-monster-core\//;
const JSON_EXTENSION = /\.json$/;
import {
getAllPf2eSourceCodes,
getCreaturePathsForSource,
getDefaultPf2eFetchUrl,
getPf2eSourceDisplayName,
loadPf2eBestiaryIndex,
} from "../pf2e-bestiary-index-adapter.js";
describe("loadPf2eBestiaryIndex", () => {
it("returns an object with sources and creatures", () => {
const index = loadPf2eBestiaryIndex();
expect(index.sources).toBeDefined();
expect(index.creatures).toBeDefined();
expect(Array.isArray(index.creatures)).toBe(true);
});
it("creatures have the expected PF2e shape", () => {
const index = loadPf2eBestiaryIndex();
expect(index.creatures.length).toBeGreaterThan(0);
const first = index.creatures[0];
expect(first).toHaveProperty("name");
expect(first).toHaveProperty("source");
expect(first).toHaveProperty("level");
expect(first).toHaveProperty("ac");
expect(first).toHaveProperty("hp");
expect(first).toHaveProperty("perception");
expect(first).toHaveProperty("size");
expect(first).toHaveProperty("type");
});
it("contains a substantial number of creatures", () => {
const index = loadPf2eBestiaryIndex();
expect(index.creatures.length).toBeGreaterThan(2500);
});
it("creatures have size and type populated", () => {
const index = loadPf2eBestiaryIndex();
const withSize = index.creatures.filter((c) => c.size !== "");
const withType = index.creatures.filter((c) => c.type !== "");
expect(withSize.length).toBeGreaterThan(index.creatures.length * 0.9);
expect(withType.length).toBeGreaterThan(index.creatures.length * 0.8);
});
it("returns the same cached instance on subsequent calls", () => {
const a = loadPf2eBestiaryIndex();
const b = loadPf2eBestiaryIndex();
expect(a).toBe(b);
});
});
describe("getAllPf2eSourceCodes", () => {
it("returns all keys from the index sources", () => {
const codes = getAllPf2eSourceCodes();
const index = loadPf2eBestiaryIndex();
expect(codes).toEqual(Object.keys(index.sources));
});
});
describe("getDefaultPf2eFetchUrl", () => {
it("returns Foundry VTT PF2e base URL", () => {
const url = getDefaultPf2eFetchUrl("pathfinder-monster-core");
expect(url).toBe(
"https://raw.githubusercontent.com/foundryvtt/pf2e/v13-dev/packs/pf2e/",
);
});
it("normalizes custom base URL with trailing slash", () => {
const url = getDefaultPf2eFetchUrl(
"pathfinder-monster-core",
"https://example.com/pf2e",
);
expect(url).toBe("https://example.com/pf2e/");
});
});
describe("getPf2eSourceDisplayName", () => {
it("returns display name for a known source", () => {
const name = getPf2eSourceDisplayName("pathfinder-monster-core");
expect(name).toBe("Monster Core");
});
it("falls back to source code for unknown source", () => {
expect(getPf2eSourceDisplayName("UNKNOWN")).toBe("UNKNOWN");
});
});
describe("getCreaturePathsForSource", () => {
it("returns file paths for a known source", () => {
const paths = getCreaturePathsForSource("pathfinder-monster-core");
expect(paths.length).toBeGreaterThan(100);
expect(paths[0]).toMatch(PACK_DIR_PREFIX);
expect(paths[0]).toMatch(JSON_EXTENSION);
});
it("returns empty array for unknown source", () => {
expect(getCreaturePathsForSource("nonexistent")).toEqual([]);
});
});

View File

@@ -0,0 +1,168 @@
import { describe, expect, it } from "vitest";
import { stripFoundryTags } from "../strip-foundry-tags.js";
describe("stripFoundryTags", () => {
describe("@Damage tags", () => {
it("formats damage with type bracket", () => {
expect(stripFoundryTags("@Damage[3d6+10[fire]]")).toBe("3d6+10 fire");
});
it("prefers display text when present", () => {
expect(
stripFoundryTags("@Damage[3d6+10[fire]]{3d6+10 fire damage}"),
).toBe("3d6+10 fire damage");
});
it("handles multiple damage types", () => {
expect(
stripFoundryTags("@Damage[2d8+5[slashing]] plus @Damage[1d6[fire]]"),
).toBe("2d8+5 slashing plus 1d6 fire");
});
});
describe("@Check tags", () => {
it("formats basic saving throw", () => {
expect(stripFoundryTags("@Check[reflex|dc:33|basic]")).toBe(
"DC 33 basic Reflex",
);
});
it("formats non-basic check", () => {
expect(stripFoundryTags("@Check[athletics|dc:25]")).toBe(
"DC 25 Athletics",
);
});
it("formats check without DC", () => {
expect(stripFoundryTags("@Check[fortitude]")).toBe("Fortitude");
});
});
describe("@UUID tags", () => {
it("extracts display text", () => {
expect(
stripFoundryTags(
"@UUID[Compendium.pf2e.conditionitems.Item.Grabbed]{Grabbed}",
),
).toBe("Grabbed");
});
it("extracts last segment when no display text", () => {
expect(
stripFoundryTags("@UUID[Compendium.pf2e.conditionitems.Item.Grabbed]"),
).toBe("Grabbed");
});
});
describe("@Template tags", () => {
it("formats cone template", () => {
expect(stripFoundryTags("@Template[cone|distance:40]")).toBe(
"40-foot cone",
);
});
it("formats emanation template", () => {
expect(stripFoundryTags("@Template[emanation|distance:10]")).toBe(
"10-foot emanation",
);
});
it("prefers display text", () => {
expect(
stripFoundryTags("@Template[cone|distance:40]{40-foot cone}"),
).toBe("40-foot cone");
});
});
describe("unknown @Tag patterns", () => {
it("uses display text for unknown tags", () => {
expect(stripFoundryTags("@Localize[some.key]{Some Text}")).toBe(
"Some Text",
);
});
it("strips unknown tags without display text", () => {
expect(stripFoundryTags("@Localize[some.key]")).toBe("");
});
});
describe("HTML stripping", () => {
it("strips paragraph tags", () => {
expect(stripFoundryTags("<p>text</p>")).toBe("text");
});
it("converts br to newline", () => {
expect(stripFoundryTags("line1<br />line2")).toBe("line1\nline2");
});
it("converts hr to newline", () => {
expect(stripFoundryTags("before<hr />after")).toBe("before\nafter");
});
it("preserves strong and em tags", () => {
expect(stripFoundryTags("<strong>bold</strong> <em>italic</em>")).toBe(
"<strong>bold</strong> <em>italic</em>",
);
});
it("preserves list tags", () => {
expect(stripFoundryTags("<ul><li>first</li><li>second</li></ul>")).toBe(
"<ul><li>first</li><li>second</li></ul>",
);
});
it("converts p-to-p transitions to newlines", () => {
expect(stripFoundryTags("<p>first</p><p>second</p>")).toBe(
"first\nsecond",
);
});
it("strips action-glyph spans", () => {
expect(
stripFoundryTags('<span class="action-glyph">1</span> Strike'),
).toBe("Strike");
});
});
describe("HTML entities", () => {
it("decodes &amp;", () => {
expect(stripFoundryTags("fire &amp; ice")).toBe("fire & ice");
});
it("decodes &lt; and &gt;", () => {
expect(stripFoundryTags("&lt;tag&gt;")).toBe("<tag>");
});
it("decodes &quot;", () => {
expect(stripFoundryTags("&quot;hello&quot;")).toBe('"hello"');
});
});
describe("whitespace handling", () => {
it("collapses multiple spaces", () => {
expect(stripFoundryTags("a b c")).toBe("a b c");
});
it("collapses multiple blank lines", () => {
expect(stripFoundryTags("a\n\n\nb")).toBe("a\nb");
});
it("trims leading and trailing whitespace", () => {
expect(stripFoundryTags(" hello ")).toBe("hello");
});
});
describe("combined/edge cases", () => {
it("handles enrichment tags inside HTML", () => {
expect(
stripFoundryTags(
"<p>Deal @Damage[2d6[fire]] damage, @Check[reflex|dc:20|basic] save.</p>",
),
).toBe("Deal 2d6 fire damage, DC 20 basic Reflex save.");
});
it("handles empty string", () => {
expect(stripFoundryTags("")).toBe("");
});
});
});

View File

@@ -138,12 +138,20 @@ describe("stripTags", () => {
); );
}); });
it("handles nested tags gracefully", () => { it("handles sibling tags in the same string", () => {
expect( expect(
stripTags("The spell {@spell Fireball|XPHB} deals {@damage 8d6}."), stripTags("The spell {@spell Fireball|XPHB} deals {@damage 8d6}."),
).toBe("The spell Fireball deals 8d6."); ).toBe("The spell Fireball deals 8d6.");
}); });
it("handles nested tags (outer wrapping inner)", () => {
expect(
stripTags(
"{@b Arcane Innate Spells DC 24; 3rd {@spell fireball}, {@spell slow}}",
),
).toBe("Arcane Innate Spells DC 24; 3rd fireball, slow");
});
it("handles text with no tags", () => { it("handles text with no tags", () => {
expect(stripTags("Just plain text.")).toBe("Just plain text."); expect(stripTags("Just plain text.")).toBe("Just plain text.");
}); });

View File

@@ -4,7 +4,10 @@ import type {
DailySpells, DailySpells,
LegendaryBlock, LegendaryBlock,
SpellcastingBlock, SpellcastingBlock,
SpellReference,
TraitBlock, TraitBlock,
TraitListItem,
TraitSegment,
} from "@initiative/domain"; } from "@initiative/domain";
import { creatureId, proficiencyBonus } from "@initiative/domain"; import { creatureId, proficiencyBonus } from "@initiative/domain";
import { stripTags } from "./strip-tags.js"; import { stripTags } from "./strip-tags.js";
@@ -63,11 +66,18 @@ interface RawEntryObject {
type: string; type: string;
items?: ( items?: (
| string | string
| { type: string; name?: string; entries?: (string | RawEntryObject)[] } | {
type: string;
name?: string;
entry?: string;
entries?: (string | RawEntryObject)[];
}
)[]; )[];
style?: string; style?: string;
name?: string; name?: string;
entries?: (string | RawEntryObject)[]; entries?: (string | RawEntryObject)[];
colLabels?: string[];
rows?: (string | RawEntryObject)[][];
} }
interface RawSpellcasting { interface RawSpellcasting {
@@ -257,23 +267,34 @@ function formatConditionImmunities(
.join(", "); .join(", ");
} }
function renderListItem(item: string | RawEntryObject): string | undefined { function toListItem(
item:
| string
| {
type: string;
name?: string;
entry?: string;
entries?: (string | RawEntryObject)[];
},
): TraitListItem | undefined {
if (typeof item === "string") { if (typeof item === "string") {
return `${stripTags(item)}`; return { text: stripTags(item) };
} }
if (item.name && item.entries) { if (item.name && item.entries) {
return `${stripTags(item.name)}: ${renderEntries(item.entries)}`; return { label: stripTags(item.name), text: renderEntries(item.entries) };
}
if (item.name && item.entry) {
return { label: stripTags(item.name), text: stripTags(item.entry) };
} }
return undefined; return undefined;
} }
function renderEntryObject(entry: RawEntryObject, parts: string[]): void { function renderEntryObject(entry: RawEntryObject, parts: string[]): void {
if (entry.type === "list") { if (entry.type === "list" || entry.type === "table") {
for (const item of entry.items ?? []) { // Handled structurally in segmentizeEntries
const rendered = renderListItem(item); return;
if (rendered) parts.push(rendered);
} }
} else if (entry.type === "item" && entry.name && entry.entries) { if (entry.type === "item" && entry.name && entry.entries) {
parts.push(`${stripTags(entry.name)}: ${renderEntries(entry.entries)}`); parts.push(`${stripTags(entry.name)}: ${renderEntries(entry.entries)}`);
} else if (entry.entries) { } else if (entry.entries) {
parts.push(renderEntries(entry.entries)); parts.push(renderEntries(entry.entries));
@@ -292,11 +313,67 @@ function renderEntries(entries: (string | RawEntryObject)[]): string {
return parts.join(" "); return parts.join(" ");
} }
function tableRowToListItem(row: (string | RawEntryObject)[]): TraitListItem {
return {
label: typeof row[0] === "string" ? stripTags(row[0]) : undefined,
text: row
.slice(1)
.map((cell) =>
typeof cell === "string" ? stripTags(cell) : renderEntries([cell]),
)
.join(" "),
};
}
function entryToListSegment(entry: RawEntryObject): TraitSegment | undefined {
if (entry.type === "list") {
const items = (entry.items ?? [])
.map(toListItem)
.filter((i): i is TraitListItem => i !== undefined);
return items.length > 0 ? { type: "list", items } : undefined;
}
if (entry.type === "table" && entry.rows) {
const items = entry.rows.map(tableRowToListItem);
return items.length > 0 ? { type: "list", items } : undefined;
}
return undefined;
}
function segmentizeEntries(
entries: (string | RawEntryObject)[],
): TraitSegment[] {
const segments: TraitSegment[] = [];
const textParts: string[] = [];
const flushText = () => {
if (textParts.length > 0) {
segments.push({ type: "text", value: textParts.join(" ") });
textParts.length = 0;
}
};
for (const entry of entries) {
if (typeof entry === "string") {
textParts.push(stripTags(entry));
continue;
}
const listSeg = entryToListSegment(entry);
if (listSeg) {
flushText();
segments.push(listSeg);
} else {
renderEntryObject(entry, textParts);
}
}
flushText();
return segments;
}
function normalizeTraits(raw?: RawEntry[]): TraitBlock[] | undefined { function normalizeTraits(raw?: RawEntry[]): TraitBlock[] | undefined {
if (!raw || raw.length === 0) return undefined; if (!raw || raw.length === 0) return undefined;
return raw.map((t) => ({ return raw.map((t) => ({
name: stripTags(t.name), name: stripTags(t.name),
text: renderEntries(t.entries), segments: segmentizeEntries(t.entries),
})); }));
} }
@@ -309,7 +386,7 @@ function normalizeSpellcasting(
const block: { const block: {
name: string; name: string;
headerText: string; headerText: string;
atWill?: string[]; atWill?: SpellReference[];
daily?: DailySpells[]; daily?: DailySpells[];
restLong?: DailySpells[]; restLong?: DailySpells[];
} = { } = {
@@ -320,7 +397,7 @@ function normalizeSpellcasting(
const hidden = new Set(sc.hidden ?? []); const hidden = new Set(sc.hidden ?? []);
if (sc.will && !hidden.has("will")) { if (sc.will && !hidden.has("will")) {
block.atWill = sc.will.map((s) => stripTags(s)); block.atWill = sc.will.map((s) => ({ name: stripTags(s) }));
} }
if (sc.daily) { if (sc.daily) {
@@ -342,7 +419,7 @@ function parseDailyMap(map: Record<string, string[]>): DailySpells[] {
return { return {
uses, uses,
each, each,
spells: spells.map((s) => stripTags(s)), spells: spells.map((s) => ({ name: stripTags(s) })),
}; };
}); });
} }
@@ -361,7 +438,7 @@ function normalizeLegendary(
preamble, preamble,
entries: raw.map((e) => ({ entries: raw.map((e) => ({
name: stripTags(e.name), name: stripTags(e.name),
text: renderEntries(e.entries), segments: segmentizeEntries(e.entries),
})), })),
}; };
} }

View File

@@ -1,23 +1,26 @@
import type { Creature, CreatureId } from "@initiative/domain"; import type { AnyCreature, CreatureId } from "@initiative/domain";
import { type IDBPDatabase, openDB } from "idb"; import { type IDBPDatabase, openDB } from "idb";
const DB_NAME = "initiative-bestiary"; const DB_NAME = "initiative-bestiary";
const STORE_NAME = "sources"; const STORE_NAME = "sources";
const DB_VERSION = 2; // v8 (2026-04-10): Attack effects, ability frequency, perception details added to PF2e creatures
const DB_VERSION = 8;
interface CachedSourceInfo { interface CachedSourceInfo {
readonly sourceCode: string; readonly sourceCode: string;
readonly displayName: string; readonly displayName: string;
readonly creatureCount: number; readonly creatureCount: number;
readonly cachedAt: number; readonly cachedAt: number;
readonly system?: string;
} }
interface CachedSourceRecord { interface CachedSourceRecord {
sourceCode: string; sourceCode: string;
displayName: string; displayName: string;
creatures: Creature[]; creatures: AnyCreature[];
cachedAt: number; cachedAt: number;
creatureCount: number; creatureCount: number;
system?: string;
} }
let db: IDBPDatabase | null = null; let db: IDBPDatabase | null = null;
@@ -26,6 +29,10 @@ let dbFailed = false;
// In-memory fallback when IndexedDB is unavailable // In-memory fallback when IndexedDB is unavailable
const memoryStore = new Map<string, CachedSourceRecord>(); const memoryStore = new Map<string, CachedSourceRecord>();
function scopedKey(system: string, sourceCode: string): string {
return `${system}:${sourceCode}`;
}
async function getDb(): Promise<IDBPDatabase | null> { async function getDb(): Promise<IDBPDatabase | null> {
if (db) return db; if (db) return db;
if (dbFailed) return null; if (dbFailed) return null;
@@ -38,8 +45,11 @@ async function getDb(): Promise<IDBPDatabase | null> {
keyPath: "sourceCode", keyPath: "sourceCode",
}); });
} }
if (oldVersion < 2 && database.objectStoreNames.contains(STORE_NAME)) { if (
// Clear cached creatures to pick up improved tag processing oldVersion < DB_VERSION &&
database.objectStoreNames.contains(STORE_NAME)
) {
// Clear cached creatures so they get re-normalized with latest rendering
void transaction.objectStore(STORE_NAME).clear(); void transaction.objectStore(STORE_NAME).clear();
} }
}, },
@@ -55,60 +65,77 @@ async function getDb(): Promise<IDBPDatabase | null> {
} }
export async function cacheSource( export async function cacheSource(
system: string,
sourceCode: string, sourceCode: string,
displayName: string, displayName: string,
creatures: Creature[], creatures: AnyCreature[],
): Promise<void> { ): Promise<void> {
const key = scopedKey(system, sourceCode);
const record: CachedSourceRecord = { const record: CachedSourceRecord = {
sourceCode, sourceCode: key,
displayName, displayName,
creatures, creatures,
cachedAt: Date.now(), cachedAt: Date.now(),
creatureCount: creatures.length, creatureCount: creatures.length,
system,
}; };
const database = await getDb(); const database = await getDb();
if (database) { if (database) {
await database.put(STORE_NAME, record); await database.put(STORE_NAME, record);
} else { } else {
memoryStore.set(sourceCode, record); memoryStore.set(key, record);
} }
} }
export async function isSourceCached(sourceCode: string): Promise<boolean> { export async function isSourceCached(
system: string,
sourceCode: string,
): Promise<boolean> {
const key = scopedKey(system, sourceCode);
const database = await getDb(); const database = await getDb();
if (database) { if (database) {
const record = await database.get(STORE_NAME, sourceCode); const record = await database.get(STORE_NAME, key);
return record !== undefined; return record !== undefined;
} }
return memoryStore.has(sourceCode); return memoryStore.has(key);
} }
export async function getCachedSources(): Promise<CachedSourceInfo[]> { export async function getCachedSources(
system?: string,
): Promise<CachedSourceInfo[]> {
const database = await getDb(); const database = await getDb();
let records: CachedSourceRecord[];
if (database) { if (database) {
const all: CachedSourceRecord[] = await database.getAll(STORE_NAME); records = await database.getAll(STORE_NAME);
return all.map((r) => ({
sourceCode: r.sourceCode,
displayName: r.displayName,
creatureCount: r.creatureCount,
cachedAt: r.cachedAt,
}));
}
return [...memoryStore.values()].map((r) => ({
sourceCode: r.sourceCode,
displayName: r.displayName,
creatureCount: r.creatureCount,
cachedAt: r.cachedAt,
}));
}
export async function clearSource(sourceCode: string): Promise<void> {
const database = await getDb();
if (database) {
await database.delete(STORE_NAME, sourceCode);
} else { } else {
memoryStore.delete(sourceCode); records = [...memoryStore.values()];
}
const filtered = system
? records.filter((r) => r.system === system)
: records;
return filtered.map((r) => ({
sourceCode: r.system
? r.sourceCode.slice(r.system.length + 1)
: r.sourceCode,
displayName: r.displayName,
creatureCount: r.creatureCount,
cachedAt: r.cachedAt,
system: r.system,
}));
}
export async function clearSource(
system: string,
sourceCode: string,
): Promise<void> {
const key = scopedKey(system, sourceCode);
const database = await getDb();
if (database) {
await database.delete(STORE_NAME, key);
} else {
memoryStore.delete(key);
} }
} }
@@ -122,9 +149,9 @@ export async function clearAll(): Promise<void> {
} }
export async function loadAllCachedCreatures(): Promise< export async function loadAllCachedCreatures(): Promise<
Map<CreatureId, Creature> Map<CreatureId, AnyCreature>
> { > {
const map = new Map<CreatureId, Creature>(); const map = new Map<CreatureId, AnyCreature>();
const database = await getDb(); const database = await getDb();
let records: CachedSourceRecord[]; let records: CachedSourceRecord[];

View File

@@ -0,0 +1,774 @@
import type {
CreatureId,
EquipmentItem,
Pf2eCreature,
SpellcastingBlock,
SpellReference,
TraitBlock,
} from "@initiative/domain";
import { creatureId } from "@initiative/domain";
import { stripFoundryTags } from "./strip-foundry-tags.js";
// -- Raw Foundry VTT types (minimal, for parsing) --
interface RawFoundryCreature {
_id: string;
name: string;
type: string;
system: {
abilities: Record<string, { mod: number }>;
attributes: {
ac: { value: number; details?: string };
hp: { max: number; details?: string };
speed: {
value: number;
otherSpeeds?: { type: string; value: number }[];
details?: string;
};
immunities?: { type: string; exceptions?: string[] }[];
resistances?: { type: string; value: number; exceptions?: string[] }[];
weaknesses?: { type: string; value: number }[];
allSaves?: { value: string };
};
details: {
level: { value: number };
languages: { value?: string[]; details?: string };
publication: { license: string; remaster: boolean; title: string };
};
perception: {
mod: number;
details?: string;
senses?: { type: string; acuity?: string; range?: number }[];
};
saves: {
fortitude: { value: number; saveDetail?: string };
reflex: { value: number; saveDetail?: string };
will: { value: number; saveDetail?: string };
};
skills: Record<string, { base: number; note?: string }>;
traits: { rarity: string; size: { value: string }; value: string[] };
};
items: RawFoundryItem[];
}
interface RawFoundryItem {
_id: string;
name: string;
type: string;
system: Record<string, unknown>;
sort?: number;
}
interface MeleeSystem {
bonus?: { value: number };
damageRolls?: Record<string, { damage: string; damageType: string }>;
traits?: { value: string[] };
attackEffects?: { value: string[] };
}
interface ActionSystem {
category?: string;
actionType?: { value: string };
actions?: { value: number | null };
traits?: { value: string[] };
description?: { value: string };
frequency?: { max: number; per: string };
}
interface SpellcastingEntrySystem {
tradition?: { value: string };
prepared?: { value: string };
spelldc?: { dc: number; value?: number };
}
interface SpellSystem {
slug?: string;
location?: {
value: string;
heightenedLevel?: number;
uses?: { max: number; value: number };
};
level?: { value: number };
traits?: { rarity?: string; value: string[]; traditions?: string[] };
description?: { value: string };
range?: { value: string };
target?: { value: string };
area?: { type?: string; value?: number; details?: string };
duration?: { value: string; sustained?: boolean };
time?: { value: string };
defense?: {
save?: { statistic: string; basic?: boolean };
passive?: { statistic: string };
};
heightening?:
| {
type: "fixed";
levels: Record<string, { text?: string }>;
}
| {
type: "interval";
interval: number;
damage?: { value: string };
}
| undefined;
overlays?: Record<
string,
{ name?: string; system?: { description?: { value: string } } }
>;
}
interface ConsumableSystem {
level?: { value: number };
traits?: { value: string[] };
description?: { value: string };
category?: string;
spell?: {
name: string;
system?: { level?: { value: number } };
} | null;
}
const EQUIPMENT_TYPES = new Set(["weapon", "consumable", "equipment", "armor"]);
/** Items shown in the Equipment section with popovers. */
function isDetailedEquipment(item: RawFoundryItem): boolean {
if (!EQUIPMENT_TYPES.has(item.type)) return false;
const sys = item.system;
const level = (sys.level as { value: number } | undefined)?.value ?? 0;
const traits = (sys.traits as { value: string[] } | undefined)?.value ?? [];
// All consumables are tactically relevant (potions, scrolls, poisons, etc.)
if (item.type === "consumable") return true;
// Magical/invested items
if (traits.includes("magical") || traits.includes("invested")) return true;
// Special material armor/equipment
const material = sys.material as { type: string | null } | undefined;
if (material?.type) return true;
// Higher-level items
if (level > 0) return true;
return false;
}
/** Items shown on the "Items" line as plain names. */
function isMundaneItem(item: RawFoundryItem): boolean {
return EQUIPMENT_TYPES.has(item.type) && !isDetailedEquipment(item);
}
function normalizeEquipmentItem(item: RawFoundryItem): EquipmentItem {
const sys = item.system;
const level = (sys.level as { value: number } | undefined)?.value ?? 0;
const traits = (sys.traits as { value: string[] } | undefined)?.value;
const rawDesc = (sys.description as { value: string } | undefined)?.value;
const description = rawDesc
? stripFoundryTags(rawDesc) || undefined
: undefined;
const category = sys.category as string | undefined;
let spellName: string | undefined;
let spellRank: number | undefined;
if (item.type === "consumable") {
const spell = (sys as unknown as ConsumableSystem).spell;
if (spell) {
spellName = spell.name;
spellRank = spell.system?.level?.value;
}
}
return {
name: item.name,
level,
category: category || undefined,
traits: traits && traits.length > 0 ? traits : undefined,
description,
spellName,
spellRank,
};
}
const SIZE_MAP: Record<string, string> = {
tiny: "tiny",
sm: "small",
med: "medium",
lg: "large",
huge: "huge",
grg: "gargantuan",
};
// -- Helpers --
function capitalize(s: string): string {
return s.charAt(0).toUpperCase() + s.slice(1);
}
function makeCreatureId(source: string, name: string): CreatureId {
const slug = name
.toLowerCase()
.replaceAll(/[^a-z0-9]+/g, "-")
.replaceAll(/(^-|-$)/g, "");
return creatureId(`${source}:${slug}`);
}
const NUMERIC_SLUG = /^(.+)-(\d+)$/;
const LETTER_SLUG = /^(.+)-([a-z])$/;
/** Format rules for traits with a numeric suffix: "reach-10" → "reach 10 feet" */
const NUMERIC_TRAIT_FORMATS: Record<string, (n: string) => string> = {
reach: (n) => `reach ${n} feet`,
range: (n) => `range ${n} feet`,
"range-increment": (n) => `range increment ${n} feet`,
versatile: (n) => `versatile ${n}`,
deadly: (n) => `deadly d${n}`,
fatal: (n) => `fatal d${n}`,
"fatal-aim": (n) => `fatal aim d${n}`,
reload: (n) => `reload ${n}`,
};
/** Format rules for traits with a letter suffix: "versatile-p" → "versatile P" */
const LETTER_TRAIT_FORMATS: Record<string, (l: string) => string> = {
versatile: (l) => `versatile ${l.toUpperCase()}`,
deadly: (l) => `deadly d${l}`,
};
/** Expand slugified trait names: "reach-10" → "reach 10 feet" */
function formatTrait(slug: string): string {
const numMatch = NUMERIC_SLUG.exec(slug);
if (numMatch) {
const [, base, num] = numMatch;
const fmt = NUMERIC_TRAIT_FORMATS[base];
return fmt ? fmt(num) : `${base} ${num}`;
}
const letterMatch = LETTER_SLUG.exec(slug);
if (letterMatch) {
const [, base, letter] = letterMatch;
const fmt = LETTER_TRAIT_FORMATS[base];
if (fmt) return fmt(letter);
}
return slug.replaceAll("-", " ");
}
// -- Formatting --
function formatSenses(
senses: { type: string; acuity?: string; range?: number }[] | undefined,
): string | undefined {
if (!senses || senses.length === 0) return undefined;
return senses
.map((s) => {
const parts = [capitalize(s.type.replaceAll("-", " "))];
if (s.acuity && s.acuity !== "precise") {
parts.push(`(${s.acuity})`);
}
if (s.range != null) parts.push(`${s.range} feet`);
return parts.join(" ");
})
.join(", ");
}
function formatLanguages(
languages: { value?: string[]; details?: string } | undefined,
): string | undefined {
if (!languages?.value || languages.value.length === 0) return undefined;
const list = languages.value.map(capitalize).join(", ");
return languages.details ? `${list} (${languages.details})` : list;
}
function formatSkills(
skills: Record<string, { base: number; note?: string }> | undefined,
): string | undefined {
if (!skills) return undefined;
const entries = Object.entries(skills);
if (entries.length === 0) return undefined;
return entries
.map(([name, val]) => {
const label = capitalize(name.replaceAll("-", " "));
return `${label} +${val.base}`;
})
.sort()
.join(", ");
}
function formatImmunities(
immunities: { type: string; exceptions?: string[] }[] | undefined,
): string | undefined {
if (!immunities || immunities.length === 0) return undefined;
return immunities
.map((i) => {
const base = capitalize(i.type.replaceAll("-", " "));
if (i.exceptions && i.exceptions.length > 0) {
return `${base} (except ${i.exceptions.map((e) => capitalize(e.replaceAll("-", " "))).join(", ")})`;
}
return base;
})
.join(", ");
}
function formatResistances(
resistances:
| { type: string; value: number; exceptions?: string[] }[]
| undefined,
): string | undefined {
if (!resistances || resistances.length === 0) return undefined;
return resistances
.map((r) => {
const base = `${capitalize(r.type.replaceAll("-", " "))} ${r.value}`;
if (r.exceptions && r.exceptions.length > 0) {
return `${base} (except ${r.exceptions.map((e) => capitalize(e.replaceAll("-", " "))).join(", ")})`;
}
return base;
})
.join(", ");
}
function formatWeaknesses(
weaknesses: { type: string; value: number }[] | undefined,
): string | undefined {
if (!weaknesses || weaknesses.length === 0) return undefined;
return weaknesses
.map((w) => `${capitalize(w.type.replaceAll("-", " "))} ${w.value}`)
.join(", ");
}
function formatSpeed(speed: {
value: number;
otherSpeeds?: { type: string; value: number }[];
details?: string;
}): string {
const parts = [`${speed.value} feet`];
if (speed.otherSpeeds) {
for (const s of speed.otherSpeeds) {
parts.push(`${capitalize(s.type)} ${s.value} feet`);
}
}
const base = parts.join(", ");
return speed.details ? `${base} (${speed.details})` : base;
}
// -- Attack normalization --
/** Format an attack effect slug to display text: "grab" → "Grab", "lich-siphon-life" → "Siphon Life". */
function formatAttackEffect(slug: string, creatureName: string): string {
const prefix = `${creatureName.toLowerCase().replaceAll(/[^a-z0-9]+/g, "-")}-`;
const stripped = slug.startsWith(prefix) ? slug.slice(prefix.length) : slug;
return stripped.split("-").map(capitalize).join(" ");
}
function normalizeAttack(
item: RawFoundryItem,
creatureName: string,
): TraitBlock {
const sys = item.system as unknown as MeleeSystem;
const bonus = sys.bonus?.value ?? 0;
const traits = sys.traits?.value ?? [];
const damageEntries = Object.values(sys.damageRolls ?? {});
const damage = damageEntries
.map((d) => `${d.damage} ${d.damageType}`)
.join(" plus ");
const traitStr =
traits.length > 0 ? ` (${traits.map(formatTrait).join(", ")})` : "";
const effects = sys.attackEffects?.value ?? [];
const effectStr =
effects.length > 0
? ` plus ${effects.map((e) => formatAttackEffect(e, creatureName)).join(" and ")}`
: "";
return {
name: capitalize(item.name),
activity: { number: 1, unit: "action" },
segments: [
{
type: "text",
value: `+${bonus}${traitStr}, ${damage}${effectStr}`,
},
],
};
}
function parseActivity(
actionType: string | undefined,
actionCount: number | null | undefined,
): { number: number; unit: "action" | "free" | "reaction" } | undefined {
if (actionType === "action") {
return { number: actionCount ?? 1, unit: "action" };
}
if (actionType === "reaction") {
return { number: 1, unit: "reaction" };
}
if (actionType === "free") {
return { number: 1, unit: "free" };
}
return undefined;
}
// -- Ability normalization --
const FREQUENCY_LINE = /(<strong>)?Frequency(<\/strong>)?\s+[^\n]+\n*/i;
/** Strip the "Frequency once per day" line from ability descriptions when structured frequency data exists. */
function stripFrequencyLine(text: string): string {
return text.replace(FREQUENCY_LINE, "").trimStart();
}
function normalizeAbility(item: RawFoundryItem): TraitBlock {
const sys = item.system as unknown as ActionSystem;
const actionType = sys.actionType?.value;
const actionCount = sys.actions?.value;
let description = stripFoundryTags(sys.description?.value ?? "");
const traits = sys.traits?.value ?? [];
const activity = parseActivity(actionType, actionCount);
const frequency =
sys.frequency?.max != null && sys.frequency.per
? `${sys.frequency.max}/${sys.frequency.per}`
: undefined;
if (frequency) {
description = stripFrequencyLine(description);
}
const traitStr =
traits.length > 0
? `(${traits.map((t) => capitalize(formatTrait(t))).join(", ")}) `
: "";
const text = traitStr ? `${traitStr}${description}` : description;
const segments: { type: "text"; value: string }[] = text
? [{ type: "text", value: text }]
: [];
return { name: item.name, activity, frequency, segments };
}
// -- Spellcasting normalization --
function formatRange(range: { value: string } | undefined): string | undefined {
if (!range?.value) return undefined;
return range.value;
}
function formatArea(
area: { type?: string; value?: number; details?: string } | undefined,
): string | undefined {
if (!area) return undefined;
if (area.value && area.type) return `${area.value}-foot ${area.type}`;
return area.details ?? undefined;
}
function formatDefense(defense: SpellSystem["defense"]): string | undefined {
if (!defense) return undefined;
if (defense.save) {
const stat = capitalize(defense.save.statistic);
return defense.save.basic ? `basic ${stat}` : stat;
}
if (defense.passive) return capitalize(defense.passive.statistic);
return undefined;
}
function formatHeightening(
heightening: SpellSystem["heightening"],
): string | undefined {
if (!heightening) return undefined;
if (heightening.type === "fixed") {
const parts = Object.entries(heightening.levels)
.filter(([, lvl]) => lvl.text)
.map(
([rank, lvl]) =>
`Heightened (${rank}) ${stripFoundryTags(lvl.text as string)}`,
);
return parts.length > 0 ? parts.join("\n") : undefined;
}
if (heightening.type === "interval") {
const dmg = heightening.damage?.value
? ` damage increases by ${heightening.damage.value}`
: "";
return `Heightened (+${heightening.interval})${dmg}`;
}
return undefined;
}
function formatOverlays(overlays: SpellSystem["overlays"]): string | undefined {
if (!overlays) return undefined;
const parts: string[] = [];
for (const overlay of Object.values(overlays)) {
const desc = overlay.system?.description?.value;
if (!desc) continue;
const label = overlay.name ? `${overlay.name}: ` : "";
parts.push(`${label}${stripFoundryTags(desc)}`);
}
return parts.length > 0 ? parts.join("\n") : undefined;
}
/**
* Foundry descriptions often include heightening rules inline at the end.
* When we extract heightening into a structured field, strip that trailing
* text to avoid duplication.
*/
const HEIGHTENED_SUFFIX = /\s*Heightened\s*\([^)]*\)[\s\S]*$/;
function normalizeSpell(
item: RawFoundryItem,
creatureLevel: number,
): SpellReference {
const sys = item.system as unknown as SpellSystem;
const usesMax = sys.location?.uses?.max;
const isCantrip = sys.traits?.value?.includes("cantrip") ?? false;
const rank =
sys.location?.heightenedLevel ??
(isCantrip ? Math.ceil(creatureLevel / 2) : (sys.level?.value ?? 0));
const heightening =
formatHeightening(sys.heightening) ?? formatOverlays(sys.overlays);
let description: string | undefined;
if (sys.description?.value) {
let text = stripFoundryTags(sys.description.value);
// Resolve Foundry Roll formula references to the spell's actual rank.
// The parenthesized form (e.g., "(@item.level)d4") is most common.
text = text.replaceAll(/\(?@item\.(?:rank|level)\)?/g, String(rank));
if (heightening) {
text = text.replace(HEIGHTENED_SUFFIX, "").trim();
}
description = text || undefined;
}
return {
name: item.name,
slug: sys.slug,
rank,
description,
traits: sys.traits?.value,
traditions: sys.traits?.traditions,
range: formatRange(sys.range),
target: sys.target?.value || undefined,
area: formatArea(sys.area),
duration: sys.duration?.value || undefined,
defense: formatDefense(sys.defense),
actionCost: sys.time?.value || undefined,
heightening,
usesPerDay: usesMax && usesMax > 1 ? usesMax : undefined,
};
}
function normalizeSpellcastingEntry(
entry: RawFoundryItem,
allSpells: readonly RawFoundryItem[],
creatureLevel: number,
): SpellcastingBlock {
const sys = entry.system as unknown as SpellcastingEntrySystem;
const tradition = capitalize(sys.tradition?.value ?? "");
const prepared = sys.prepared?.value ?? "";
const dc = sys.spelldc?.dc ?? 0;
const attack = sys.spelldc?.value ?? 0;
const name = entry.name || `${tradition} ${capitalize(prepared)} Spells`;
const headerText = `DC ${dc}${attack ? `, attack +${attack}` : ""}`;
const linkedSpells = allSpells.filter(
(s) => (s.system as unknown as SpellSystem).location?.value === entry._id,
);
const byRank = new Map<number, SpellReference[]>();
const cantrips: SpellReference[] = [];
for (const spell of linkedSpells) {
const ref = normalizeSpell(spell, creatureLevel);
const isCantrip =
(spell.system as unknown as SpellSystem).traits?.value?.includes(
"cantrip",
) ?? false;
if (isCantrip) {
cantrips.push(ref);
continue;
}
const rank = ref.rank ?? 0;
const existing = byRank.get(rank) ?? [];
existing.push(ref);
byRank.set(rank, existing);
}
const daily = [...byRank.entries()]
.sort(([a], [b]) => b - a)
.map(([rank, spells]) => ({
uses: rank,
each: true,
spells,
}));
return {
name,
headerText,
atWill: orUndefined(cantrips),
daily: orUndefined(daily),
};
}
function normalizeSpellcasting(
items: readonly RawFoundryItem[],
creatureLevel: number,
): SpellcastingBlock[] {
const entries = items.filter((i) => i.type === "spellcastingEntry");
const spells = items.filter((i) => i.type === "spell");
return entries.map((entry) =>
normalizeSpellcastingEntry(entry, spells, creatureLevel),
);
}
// -- Main normalization --
function orUndefined<T>(arr: T[]): T[] | undefined {
return arr.length > 0 ? arr : undefined;
}
/** Build display traits: [rarity (if not common), size, ...type traits] */
function buildTraits(traits: {
rarity: string;
size: { value: string };
value: string[];
}): string[] {
const result: string[] = [];
if (traits.rarity && traits.rarity !== "common") {
result.push(traits.rarity);
}
const size = SIZE_MAP[traits.size.value] ?? "medium";
result.push(size);
result.push(...traits.value);
return result;
}
const HEALING_GLOSSARY =
/^<p>@Localize\[PF2E\.NPC\.Abilities\.Glossary\.(FastHealing|Regeneration|NegativeHealing)\]/;
/** Glossary-only abilities that duplicate structured data shown elsewhere. */
const REDUNDANT_GLOSSARY =
/^<p>@Localize\[PF2E\.NPC\.Abilities\.Glossary\.(ConstantSpells|AtWillSpells)\]/;
const STRIP_GLOSSARY_AND_P = /<p>@Localize\[[^\]]+\]<\/p>|<\/?p>/g;
/** True when the description has no user-visible content beyond glossary tags. */
function isGlossaryOnly(desc: string | undefined): boolean {
if (!desc) return true;
return desc.replace(STRIP_GLOSSARY_AND_P, "").trim() === "";
}
function isRedundantAbility(
item: RawFoundryItem,
excludeName: string | undefined,
hpDetails: string | undefined,
): boolean {
const sys = item.system as unknown as ActionSystem;
const desc = sys.description?.value;
// Ability duplicates the allSaves line — suppress only if glossary-only
if (excludeName && item.name.toLowerCase() === excludeName.toLowerCase()) {
return isGlossaryOnly(desc);
}
if (!desc) return false;
// Healing/regen glossary when hp.details already shows the info
if (hpDetails && HEALING_GLOSSARY.test(desc)) return true;
// Spell mechanic glossary reminders shown in the spellcasting section
if (REDUNDANT_GLOSSARY.test(desc)) return true;
return false;
}
function actionsByCategory(
items: readonly RawFoundryItem[],
category: string,
excludeName?: string,
hpDetails?: string,
): TraitBlock[] {
return items
.filter(
(a) =>
a.type === "action" &&
(a.system as unknown as ActionSystem).category === category &&
!isRedundantAbility(a, excludeName, hpDetails),
)
.map(normalizeAbility);
}
function extractAbilityMods(
mods: Record<string, { mod: number }>,
): Pf2eCreature["abilityMods"] {
return {
str: mods.str?.mod ?? 0,
dex: mods.dex?.mod ?? 0,
con: mods.con?.mod ?? 0,
int: mods.int?.mod ?? 0,
wis: mods.wis?.mod ?? 0,
cha: mods.cha?.mod ?? 0,
};
}
export function normalizeFoundryCreature(
raw: unknown,
sourceCode?: string,
sourceDisplayName?: string,
): Pf2eCreature {
const r = raw as RawFoundryCreature;
const sys = r.system;
const publication = sys.details?.publication;
const source = sourceCode ?? publication?.title ?? "";
const items = r.items ?? [];
const allSavesText = sys.attributes.allSaves?.value ?? "";
return {
system: "pf2e",
id: makeCreatureId(source, r.name),
name: r.name,
source,
sourceDisplayName: sourceDisplayName ?? publication?.title ?? "",
level: sys.details?.level?.value ?? 0,
traits: buildTraits(sys.traits),
perception: sys.perception?.mod ?? 0,
perceptionDetails: sys.perception?.details || undefined,
senses: formatSenses(sys.perception?.senses),
languages: formatLanguages(sys.details?.languages),
skills: formatSkills(sys.skills),
abilityMods: extractAbilityMods(sys.abilities ?? {}),
ac: sys.attributes.ac.value,
acConditional: sys.attributes.ac.details || undefined,
saveFort: sys.saves.fortitude.value,
saveRef: sys.saves.reflex.value,
saveWill: sys.saves.will.value,
saveConditional: allSavesText || undefined,
hp: sys.attributes.hp.max,
hpDetails: sys.attributes.hp.details || undefined,
immunities: formatImmunities(sys.attributes.immunities),
resistances: formatResistances(sys.attributes.resistances),
weaknesses: formatWeaknesses(sys.attributes.weaknesses),
speed: formatSpeed(sys.attributes.speed),
attacks: orUndefined(
items
.filter((i) => i.type === "melee")
.map((i) => normalizeAttack(i, r.name)),
),
abilitiesTop: orUndefined(actionsByCategory(items, "interaction")),
abilitiesMid: orUndefined(
actionsByCategory(
items,
"defensive",
allSavesText || undefined,
sys.attributes.hp.details || undefined,
),
),
abilitiesBot: orUndefined(actionsByCategory(items, "offensive")),
spellcasting: orUndefined(
normalizeSpellcasting(items, sys.details?.level?.value ?? 0),
),
items:
items
.filter(isMundaneItem)
.map((i) => i.name)
.join(", ") || undefined,
equipment: orUndefined(
items.filter(isDetailedEquipment).map(normalizeEquipmentItem),
),
};
}
export function normalizeFoundryCreatures(
rawCreatures: unknown[],
sourceCode?: string,
sourceDisplayName?: string,
): Pf2eCreature[] {
return rawCreatures.map((raw) =>
normalizeFoundryCreature(raw, sourceCode, sourceDisplayName),
);
}

View File

@@ -0,0 +1,87 @@
import type {
Pf2eBestiaryIndex,
Pf2eBestiaryIndexEntry,
} from "@initiative/domain";
import rawIndex from "../../../../data/bestiary/pf2e-index.json";
interface CompactCreature {
readonly n: string;
readonly s: string;
readonly lv: number;
readonly ac: number;
readonly hp: number;
readonly pc: number;
readonly sz: string;
readonly tp: string;
readonly f: string;
readonly li: string;
}
interface CompactIndex {
readonly sources: Record<string, string>;
readonly creatures: readonly CompactCreature[];
}
function mapCreature(c: CompactCreature): Pf2eBestiaryIndexEntry {
return {
name: c.n,
source: c.s,
level: c.lv,
ac: c.ac,
hp: c.hp,
perception: c.pc,
size: c.sz,
type: c.tp,
};
}
let cachedIndex: Pf2eBestiaryIndex | undefined;
export function loadPf2eBestiaryIndex(): Pf2eBestiaryIndex {
if (cachedIndex) return cachedIndex;
const compact = rawIndex as unknown as CompactIndex;
cachedIndex = {
sources: compact.sources,
creatures: compact.creatures.map(mapCreature),
};
return cachedIndex;
}
export function getAllPf2eSourceCodes(): string[] {
const index = loadPf2eBestiaryIndex();
return Object.keys(index.sources);
}
export function getDefaultPf2eFetchUrl(
_sourceCode: string,
baseUrl?: string,
): string {
if (baseUrl !== undefined) {
return baseUrl.endsWith("/") ? baseUrl : `${baseUrl}/`;
}
return "https://raw.githubusercontent.com/foundryvtt/pf2e/v13-dev/packs/pf2e/";
}
export function getCreaturePathsForSource(sourceCode: string): string[] {
const compact = rawIndex as unknown as CompactIndex;
return compact.creatures.filter((c) => c.s === sourceCode).map((c) => c.f);
}
export function getCreatureNamesByPaths(paths: string[]): Map<string, string> {
const compact = rawIndex as unknown as CompactIndex;
const pathSet = new Set(paths);
const result = new Map<string, string>();
for (const c of compact.creatures) {
if (pathSet.has(c.f)) {
result.set(c.f, c.n);
}
}
return result;
}
export function getPf2eSourceDisplayName(sourceCode: string): string {
const index = loadPf2eBestiaryIndex();
return index.sources[sourceCode] ?? sourceCode;
}

View File

@@ -1,8 +1,9 @@
import type { import type {
AnyCreature,
BestiaryIndex, BestiaryIndex,
Creature,
CreatureId, CreatureId,
Encounter, Encounter,
Pf2eBestiaryIndex,
PlayerCharacter, PlayerCharacter,
UndoRedoState, UndoRedoState,
} from "@initiative/domain"; } from "@initiative/domain";
@@ -31,15 +32,16 @@ export interface CachedSourceInfo {
export interface BestiaryCachePort { export interface BestiaryCachePort {
cacheSource( cacheSource(
system: string,
sourceCode: string, sourceCode: string,
displayName: string, displayName: string,
creatures: Creature[], creatures: AnyCreature[],
): Promise<void>; ): Promise<void>;
isSourceCached(sourceCode: string): Promise<boolean>; isSourceCached(system: string, sourceCode: string): Promise<boolean>;
getCachedSources(): Promise<CachedSourceInfo[]>; getCachedSources(system?: string): Promise<CachedSourceInfo[]>;
clearSource(sourceCode: string): Promise<void>; clearSource(system: string, sourceCode: string): Promise<void>;
clearAll(): Promise<void>; clearAll(): Promise<void>;
loadAllCachedCreatures(): Promise<Map<CreatureId, Creature>>; loadAllCachedCreatures(): Promise<Map<CreatureId, AnyCreature>>;
} }
export interface BestiaryIndexPort { export interface BestiaryIndexPort {
@@ -48,3 +50,12 @@ export interface BestiaryIndexPort {
getDefaultFetchUrl(sourceCode: string, baseUrl?: string): string; getDefaultFetchUrl(sourceCode: string, baseUrl?: string): string;
getSourceDisplayName(sourceCode: string): string; getSourceDisplayName(sourceCode: string): string;
} }
export interface Pf2eBestiaryIndexPort {
loadIndex(): Pf2eBestiaryIndex;
getAllSourceCodes(): string[];
getDefaultFetchUrl(sourceCode: string, baseUrl?: string): string;
getSourceDisplayName(sourceCode: string): string;
getCreaturePathsForSource(sourceCode: string): string[];
getCreatureNamesByPaths(paths: string[]): Map<string, string>;
}

View File

@@ -13,6 +13,7 @@ import {
} from "../persistence/undo-redo-storage.js"; } from "../persistence/undo-redo-storage.js";
import * as bestiaryCache from "./bestiary-cache.js"; import * as bestiaryCache from "./bestiary-cache.js";
import * as bestiaryIndex from "./bestiary-index-adapter.js"; import * as bestiaryIndex from "./bestiary-index-adapter.js";
import * as pf2eBestiaryIndex from "./pf2e-bestiary-index-adapter.js";
export const productionAdapters: Adapters = { export const productionAdapters: Adapters = {
encounterPersistence: { encounterPersistence: {
@@ -41,4 +42,12 @@ export const productionAdapters: Adapters = {
getDefaultFetchUrl: bestiaryIndex.getDefaultFetchUrl, getDefaultFetchUrl: bestiaryIndex.getDefaultFetchUrl,
getSourceDisplayName: bestiaryIndex.getSourceDisplayName, getSourceDisplayName: bestiaryIndex.getSourceDisplayName,
}, },
pf2eBestiaryIndex: {
loadIndex: pf2eBestiaryIndex.loadPf2eBestiaryIndex,
getAllSourceCodes: pf2eBestiaryIndex.getAllPf2eSourceCodes,
getDefaultFetchUrl: pf2eBestiaryIndex.getDefaultPf2eFetchUrl,
getSourceDisplayName: pf2eBestiaryIndex.getPf2eSourceDisplayName,
getCreaturePathsForSource: pf2eBestiaryIndex.getCreaturePathsForSource,
getCreatureNamesByPaths: pf2eBestiaryIndex.getCreatureNamesByPaths,
},
}; };

View File

@@ -0,0 +1,110 @@
/**
* Strips Foundry VTT HTML descriptions with enrichment syntax to plain
* readable text. Handles @Damage, @Check, @UUID, @Template and generic
* @Tag patterns as well as common HTML elements.
*/
// -- Enrichment-param helpers --
function formatDamage(params: string): string {
// "3d6+10[fire]" → "3d6+10 fire"
// "d4[persistent,fire]" → "d4 persistent fire"
return params
.replaceAll(
/\[([^\]]*)\]/g,
(_, type: string) => ` ${type.replaceAll(",", " ")}`,
)
.trim();
}
function formatCheck(params: string): string {
// "reflex|dc:33|basic" → "DC 33 basic Reflex"
const parts = params.split("|");
const type = parts[0] ?? "";
let dc = "";
let basic = false;
for (const part of parts.slice(1)) {
if (part.startsWith("dc:")) {
dc = part.slice(3);
} else if (part === "basic") {
basic = true;
}
}
const label = type.charAt(0).toUpperCase() + type.slice(1);
const dcStr = dc ? `DC ${dc} ` : "";
const basicStr = basic ? "basic " : "";
return `${dcStr}${basicStr}${label}`;
}
function formatTemplate(params: string): string {
// "cone|distance:40" → "40-foot cone"
const parts = params.split("|");
const shape = parts[0] ?? "";
let distance = "";
for (const part of parts.slice(1)) {
if (part.startsWith("distance:")) {
distance = part.slice(9);
}
}
return distance ? `${distance}-foot ${shape}` : shape;
}
export function stripFoundryTags(html: string): string {
if (typeof html !== "string") return String(html);
let result = html;
// Strip Foundry enrichment tags (with optional display text)
// @Tag[params]{display} → display (prefer display text)
// @Tag[params] → extracted content
// @Damage has nested brackets: @Damage[3d6+10[fire]]
result = result.replaceAll(
/@Damage\[((?:[^[\]]|\[[^\]]*\])*)\](?:\{([^}]+)\})?/g,
(_, params: string, display: string | undefined) =>
display ?? formatDamage(params),
);
result = result.replaceAll(
/@Check\[([^\]]+)\](?:\{([^}]*)\})?/g,
(_, params: string) => formatCheck(params),
);
result = result.replaceAll(
/@UUID\[[^\]]+?([^./\]]+)\](?:\{([^}]+)\})?/g,
(_, lastSegment: string, display: string | undefined) =>
display ?? lastSegment,
);
result = result.replaceAll(
/@Template\[([^\]]+)\](?:\{([^}]+)\})?/g,
(_, params: string, display: string | undefined) =>
display ?? formatTemplate(params),
);
// Catch-all for unknown @Tag patterns
result = result.replaceAll(
/@\w+\[[^\]]*\](?:\{([^}]+)\})?/g,
(_, display: string | undefined) => display ?? "",
);
// Strip action-glyph spans (content is a number the renderer handles)
result = result.replaceAll(/<span class="action-glyph">[^<]*<\/span>/gi, "");
// Strip HTML tags (preserve <strong> for UI rendering)
result = result.replaceAll(/<br\s*\/?>/gi, "\n");
result = result.replaceAll(/<hr\s*\/?>/gi, "\n");
result = result.replaceAll(/<\/p>\s*<p[^>]*>/gi, "\n");
result = result.replaceAll(/<(?!\/?(?:strong|em|ul|ol|li)\b)[^>]+>/g, "");
// Decode common HTML entities
result = result.replaceAll("&amp;", "&");
result = result.replaceAll("&lt;", "<");
result = result.replaceAll("&gt;", ">");
result = result.replaceAll("&quot;", '"');
// Collapse whitespace around list tags so they don't create extra
// line breaks when rendered with whitespace-pre-line
result = result.replaceAll(/\s*(<\/?(?:ul|ol)>)\s*/g, "$1");
result = result.replaceAll(/\s*(<\/?li>)\s*/g, "$1");
// Collapse whitespace
result = result.replaceAll(/[ \t]+/g, " ");
result = result.replaceAll(/\n\s*\n/g, "\n");
return result.trim();
}

View File

@@ -98,20 +98,26 @@ export function stripTags(text: string): string {
// Generic tags: {@tag Display|Source|...} → Display (first segment before |) // Generic tags: {@tag Display|Source|...} → Display (first segment before |)
// Covers: spell, condition, damage, dice, variantrule, action, skill, // Covers: spell, condition, damage, dice, variantrule, action, skill,
// creature, hazard, status, plus any unknown tags // creature, hazard, status, plus any unknown tags
// Run in a loop to resolve nested tags (e.g. {@b ... {@spell fireball} ...})
// from innermost to outermost.
const tagPattern = /\{@(\w+)\s+([^}]+)\}/g;
while (tagPattern.test(result)) {
result = result.replaceAll( result = result.replaceAll(
/\{@(\w+)\s+([^}]+)\}/g, tagPattern,
(_, tag: string, content: string) => { (_, tag: string, content: string) => {
// For tags with Display|Source format, extract first segment
const segments = content.split("|"); const segments = content.split("|");
// Some tags have a third segment as display text: {@variantrule Name|Source|Display} if (
if ((tag === "variantrule" || tag === "action") && segments.length >= 3) { (tag === "variantrule" || tag === "action") &&
segments.length >= 3
) {
return segments[2]; return segments[2];
} }
return segments[0]; return segments[0];
}, },
); );
}
return result; return result;
} }

View File

@@ -6,6 +6,7 @@ import userEvent from "@testing-library/user-event";
import { afterEach, describe, expect, it, vi } from "vitest"; import { afterEach, describe, expect, it, vi } from "vitest";
import { createTestAdapters } from "../../__tests__/adapters/in-memory-adapters.js"; import { createTestAdapters } from "../../__tests__/adapters/in-memory-adapters.js";
import { AdapterProvider } from "../../contexts/adapter-context.js"; import { AdapterProvider } from "../../contexts/adapter-context.js";
import { RulesEditionProvider } from "../../contexts/rules-edition-context.js";
import { BulkImportPrompt } from "../bulk-import-prompt.js"; import { BulkImportPrompt } from "../bulk-import-prompt.js";
const THREE_SOURCES_REGEX = /3 sources/; const THREE_SOURCES_REGEX = /3 sources/;
@@ -68,9 +69,11 @@ function createAdaptersWithSources() {
function renderWithAdapters() { function renderWithAdapters() {
const adapters = createAdaptersWithSources(); const adapters = createAdaptersWithSources();
return render( return render(
<RulesEditionProvider>
<AdapterProvider adapters={adapters}> <AdapterProvider adapters={adapters}>
<BulkImportPrompt /> <BulkImportPrompt />
</AdapterProvider>, </AdapterProvider>
</RulesEditionProvider>,
); );
} }

View File

@@ -1,7 +1,11 @@
// @vitest-environment jsdom // @vitest-environment jsdom
import "@testing-library/jest-dom/vitest"; import "@testing-library/jest-dom/vitest";
import { CONDITION_DEFINITIONS, type ConditionId } from "@initiative/domain"; import {
type ConditionEntry,
type ConditionId,
getConditionsForEdition,
} from "@initiative/domain";
import { cleanup, render, screen } from "@testing-library/react"; import { cleanup, render, screen } from "@testing-library/react";
import userEvent from "@testing-library/user-event"; import userEvent from "@testing-library/user-event";
import { createRef, type RefObject } from "react"; import { createRef, type RefObject } from "react";
@@ -13,12 +17,14 @@ afterEach(cleanup);
function renderPicker( function renderPicker(
overrides: Partial<{ overrides: Partial<{
activeConditions: readonly ConditionId[]; activeConditions: readonly ConditionEntry[];
onToggle: (conditionId: ConditionId) => void; onToggle: (conditionId: ConditionId) => void;
onSetValue: (conditionId: ConditionId, value: number) => void;
onClose: () => void; onClose: () => void;
}> = {}, }> = {},
) { ) {
const onToggle = overrides.onToggle ?? vi.fn(); const onToggle = overrides.onToggle ?? vi.fn();
const onSetValue = overrides.onSetValue ?? vi.fn();
const onClose = overrides.onClose ?? vi.fn(); const onClose = overrides.onClose ?? vi.fn();
const anchorRef = createRef<HTMLElement>() as RefObject<HTMLElement>; const anchorRef = createRef<HTMLElement>() as RefObject<HTMLElement>;
const anchor = document.createElement("div"); const anchor = document.createElement("div");
@@ -30,25 +36,27 @@ function renderPicker(
anchorRef={anchorRef} anchorRef={anchorRef}
activeConditions={overrides.activeConditions ?? []} activeConditions={overrides.activeConditions ?? []}
onToggle={onToggle} onToggle={onToggle}
onSetValue={onSetValue}
onClose={onClose} onClose={onClose}
/> />
</RulesEditionProvider>, </RulesEditionProvider>,
); );
return { ...result, onToggle, onClose }; return { ...result, onToggle, onSetValue, onClose };
} }
describe("ConditionPicker", () => { describe("ConditionPicker", () => {
it("renders all condition definitions from domain", () => { it("renders edition-specific conditions from domain", () => {
renderPicker(); renderPicker();
for (const def of CONDITION_DEFINITIONS) { const editionConditions = getConditionsForEdition("5.5e");
for (const def of editionConditions) {
expect(screen.getByText(def.label)).toBeInTheDocument(); expect(screen.getByText(def.label)).toBeInTheDocument();
} }
}); });
it("active conditions are visually distinguished", () => { it("active conditions are visually distinguished", () => {
renderPicker({ activeConditions: ["blinded"] }); renderPicker({ activeConditions: [{ id: "blinded" }] });
const blindedButton = screen.getByText("Blinded").closest("button"); const row = screen.getByText("Blinded").closest("div[class]");
expect(blindedButton?.className).toContain("bg-card/50"); expect(row?.className).toContain("bg-card/50");
}); });
it("clicking a condition calls onToggle with that condition's ID", async () => { it("clicking a condition calls onToggle with that condition's ID", async () => {
@@ -65,7 +73,7 @@ describe("ConditionPicker", () => {
}); });
it("active condition labels use foreground color", () => { it("active condition labels use foreground color", () => {
renderPicker({ activeConditions: ["charmed"] }); renderPicker({ activeConditions: [{ id: "charmed" }] });
const label = screen.getByText("Charmed"); const label = screen.getByText("Charmed");
expect(label.className).toContain("text-foreground"); expect(label.className).toContain("text-foreground");
}); });

View File

@@ -1,5 +1,5 @@
// @vitest-environment jsdom // @vitest-environment jsdom
import type { ConditionId } from "@initiative/domain"; import type { ConditionEntry } from "@initiative/domain";
import { cleanup, render, screen } from "@testing-library/react"; import { cleanup, render, screen } from "@testing-library/react";
import { userEvent } from "@testing-library/user-event"; import { userEvent } from "@testing-library/user-event";
import { afterEach, describe, expect, it, vi } from "vitest"; import { afterEach, describe, expect, it, vi } from "vitest";
@@ -14,6 +14,7 @@ function renderTags(props: Partial<Parameters<typeof ConditionTags>[0]> = {}) {
<ConditionTags <ConditionTags
conditions={props.conditions} conditions={props.conditions}
onRemove={props.onRemove ?? (() => {})} onRemove={props.onRemove ?? (() => {})}
onDecrement={props.onDecrement ?? (() => {})}
onOpenPicker={props.onOpenPicker ?? (() => {})} onOpenPicker={props.onOpenPicker ?? (() => {})}
/> />
</RulesEditionProvider>, </RulesEditionProvider>,
@@ -28,7 +29,7 @@ describe("ConditionTags", () => {
}); });
it("renders a button per condition", () => { it("renders a button per condition", () => {
const conditions: ConditionId[] = ["blinded", "prone"]; const conditions: ConditionEntry[] = [{ id: "blinded" }, { id: "prone" }];
renderTags({ conditions }); renderTags({ conditions });
expect( expect(
screen.getByRole("button", { name: "Remove Blinded" }), screen.getByRole("button", { name: "Remove Blinded" }),
@@ -39,7 +40,7 @@ describe("ConditionTags", () => {
it("calls onRemove with condition id when clicked", async () => { it("calls onRemove with condition id when clicked", async () => {
const onRemove = vi.fn(); const onRemove = vi.fn();
renderTags({ renderTags({
conditions: ["blinded"] as ConditionId[], conditions: [{ id: "blinded" }] as ConditionEntry[],
onRemove, onRemove,
}); });
@@ -66,4 +67,37 @@ describe("ConditionTags", () => {
// Only add button // Only add button
expect(screen.getByRole("button", { name: "Add condition" })).toBeDefined(); expect(screen.getByRole("button", { name: "Add condition" })).toBeDefined();
}); });
it("displays value badge for valued conditions", () => {
renderTags({ conditions: [{ id: "frightened", value: 3 }] });
expect(screen.getByText("3")).toBeDefined();
});
it("calls onDecrement for valued condition click", async () => {
const onDecrement = vi.fn();
renderTags({
conditions: [{ id: "frightened", value: 2 }],
onDecrement,
});
await userEvent.click(
screen.getByRole("button", { name: "Remove Frightened" }),
);
expect(onDecrement).toHaveBeenCalledWith("frightened");
});
it("calls onRemove for non-valued condition click", async () => {
const onRemove = vi.fn();
renderTags({
conditions: [{ id: "blinded" }],
onRemove,
});
await userEvent.click(
screen.getByRole("button", { name: "Remove Blinded" }),
);
expect(onRemove).toHaveBeenCalledWith("blinded");
});
}); });

View File

@@ -0,0 +1,107 @@
// @vitest-environment jsdom
import "@testing-library/jest-dom/vitest";
import type { EquipmentItem } from "@initiative/domain";
import { cleanup, fireEvent, render, screen } from "@testing-library/react";
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
import { EquipmentDetailPopover } from "../equipment-detail-popover.js";
afterEach(cleanup);
const POISON: EquipmentItem = {
name: "Giant Wasp Venom",
level: 7,
category: "poison",
traits: ["consumable", "poison", "injury"],
description: "A deadly poison extracted from giant wasps.",
};
const SCROLL: EquipmentItem = {
name: "Scroll of Teleport",
level: 11,
category: "scroll",
traits: ["consumable", "magical", "scroll"],
description: "A scroll containing Teleport.",
spellName: "Teleport",
spellRank: 6,
};
const ANCHOR: DOMRect = new DOMRect(100, 100, 50, 20);
const SCROLL_SPELL_REGEX = /Teleport \(Rank 6\)/;
const DIALOG_LABEL_REGEX = /Equipment details: Giant Wasp Venom/;
beforeEach(() => {
Object.defineProperty(globalThis, "matchMedia", {
writable: true,
configurable: true,
value: vi.fn().mockImplementation(() => ({
matches: true,
media: "(min-width: 1024px)",
onchange: null,
addEventListener: vi.fn(),
removeEventListener: vi.fn(),
addListener: vi.fn(),
removeListener: vi.fn(),
dispatchEvent: vi.fn(),
})),
});
});
describe("EquipmentDetailPopover", () => {
it("renders item name, level, traits, and description", () => {
render(
<EquipmentDetailPopover
item={POISON}
anchorRect={ANCHOR}
onClose={() => {}}
/>,
);
expect(screen.getByText("Giant Wasp Venom")).toBeInTheDocument();
expect(screen.getByText("7")).toBeInTheDocument();
expect(screen.getByText("consumable")).toBeInTheDocument();
expect(screen.getByText("poison")).toBeInTheDocument();
expect(screen.getByText("injury")).toBeInTheDocument();
expect(
screen.getByText("A deadly poison extracted from giant wasps."),
).toBeInTheDocument();
});
it("renders scroll/wand spell info", () => {
render(
<EquipmentDetailPopover
item={SCROLL}
anchorRect={ANCHOR}
onClose={() => {}}
/>,
);
expect(screen.getByText(SCROLL_SPELL_REGEX)).toBeInTheDocument();
});
it("calls onClose when Escape is pressed", () => {
const onClose = vi.fn();
render(
<EquipmentDetailPopover
item={POISON}
anchorRect={ANCHOR}
onClose={onClose}
/>,
);
fireEvent.keyDown(document, { key: "Escape" });
expect(onClose).toHaveBeenCalledTimes(1);
});
it("uses the dialog role with the item name as label", () => {
render(
<EquipmentDetailPopover
item={POISON}
anchorRect={ANCHOR}
onClose={() => {}}
/>,
);
expect(
screen.getByRole("dialog", {
name: DIALOG_LABEL_REGEX,
}),
).toBeInTheDocument();
});
});

View File

@@ -0,0 +1,497 @@
// @vitest-environment jsdom
import "@testing-library/jest-dom/vitest";
import type { Pf2eCreature } from "@initiative/domain";
import { creatureId } from "@initiative/domain";
import { cleanup, render, screen } from "@testing-library/react";
import userEvent from "@testing-library/user-event";
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
import { Pf2eStatBlock } from "../pf2e-stat-block.js";
afterEach(cleanup);
const USES_PER_DAY_REGEX = /×3/;
const HEAL_DESCRIPTION_REGEX = /channel positive energy/;
const PERCEPTION_SENSES_REGEX = /\+2.*Darkvision/;
const SKILLS_REGEX = /Acrobatics \+5.*Stealth \+5/;
const SAVE_CONDITIONAL_REGEX = /\+12.*\+1 status to all saves vs\. magic/;
const SAVE_CONDITIONAL_ABSENT_REGEX = /status to all saves/;
const HP_DETAILS_REGEX = /115.*regeneration 20/;
const REGEN_REGEX = /regeneration/;
const ATTACK_NAME_REGEX = /Dogslicer/;
const ATTACK_DAMAGE_REGEX = /1d6 slashing/;
const SPELLCASTING_ENTRY_REGEX = /Divine Innate Spells\./;
const ABILITY_MID_NAME_REGEX = /Goblin Scuttle/;
const ABILITY_MID_DESC_REGEX = /The goblin Steps\./;
const CANTRIPS_REGEX = /Cantrips:/;
const AC_REGEX = /16/;
const RK_DC_13_REGEX = /DC 13/;
const RK_DC_15_REGEX = /DC 15/;
const RK_DC_25_REGEX = /DC 25/;
const RK_HUMANOID_SOCIETY_REGEX = /Humanoid \(Society\)/;
const RK_UNDEAD_RELIGION_REGEX = /Undead \(Religion\)/;
const RK_BEAST_SKILLS_REGEX = /Beast \(Arcana\/Nature\)/;
const SCROLL_NAME_REGEX = /Scroll of Teleport/;
const GOBLIN_WARRIOR: Pf2eCreature = {
system: "pf2e",
id: creatureId("pathfinder-monster-core:goblin-warrior"),
name: "Goblin Warrior",
source: "pathfinder-monster-core",
sourceDisplayName: "Monster Core",
level: -1,
traits: ["small", "goblin", "humanoid"],
perception: 2,
senses: "Darkvision",
languages: "Common, Goblin",
skills: "Acrobatics +5, Athletics +2, Nature +1, Stealth +5",
abilityMods: { str: 0, dex: 3, con: 1, int: 0, wis: -1, cha: 1 },
ac: 16,
saveFort: 5,
saveRef: 7,
saveWill: 3,
hp: 6,
speed: "25 feet",
attacks: [
{
name: "Dogslicer",
activity: { number: 1, unit: "action" },
segments: [
{
type: "text",
value: "+7 (agile, backstabber, finesse), 1d6 slashing",
},
],
},
],
abilitiesMid: [
{
name: "Goblin Scuttle",
activity: { number: 1, unit: "reaction" },
segments: [{ type: "text", value: "The goblin Steps." }],
},
],
};
const NAUNET: Pf2eCreature = {
system: "pf2e",
id: creatureId("pathfinder-monster-core-2:naunet"),
name: "Naunet",
source: "pathfinder-monster-core-2",
sourceDisplayName: "Monster Core 2",
level: 7,
traits: ["large", "monitor", "protean"],
perception: 14,
senses: "Darkvision",
languages: "Chthonian, Empyrean, Protean",
skills:
"Acrobatics +14, Athletics +16, Intimidation +16, Stealth +14, Survival +12",
abilityMods: { str: 5, dex: 3, con: 5, int: 0, wis: 3, cha: 3 },
ac: 24,
saveFort: 18,
saveRef: 14,
saveWill: 12,
saveConditional: "+1 status to all saves vs. magic",
hp: 120,
resistances: "Precision 5, Protean anatomy 10",
speed: "25 feet, Fly 30 feet, Swim 25 feet (unfettered movement)",
spellcasting: [
{
name: "Divine Innate Spells",
headerText: "DC 25, attack +17",
daily: [
{
uses: 4,
each: true,
spells: [{ name: "Unfettered Movement (Constant)" }],
},
],
atWill: [{ name: "Detect Magic" }],
},
],
};
const TROLL: Pf2eCreature = {
system: "pf2e",
id: creatureId("pathfinder-monster-core:forest-troll"),
name: "Forest Troll",
source: "pathfinder-monster-core",
sourceDisplayName: "Monster Core",
level: 5,
traits: ["large", "giant", "troll"],
perception: 11,
senses: "Darkvision",
languages: "Jotun",
skills: "Athletics +12, Intimidation +12",
abilityMods: { str: 5, dex: 2, con: 6, int: -2, wis: 0, cha: -2 },
ac: 20,
saveFort: 17,
saveRef: 11,
saveWill: 7,
hp: 115,
hpDetails: "regeneration 20 (deactivated by acid or fire)",
weaknesses: "Fire 10",
speed: "30 feet",
};
function renderStatBlock(creature: Pf2eCreature) {
return render(<Pf2eStatBlock creature={creature} />);
}
describe("Pf2eStatBlock", () => {
describe("header", () => {
it("renders creature name and level", () => {
renderStatBlock(GOBLIN_WARRIOR);
expect(
screen.getByRole("heading", { name: "Goblin Warrior" }),
).toBeInTheDocument();
expect(screen.getByText("Level -1")).toBeInTheDocument();
});
it("renders traits as tags", () => {
renderStatBlock(GOBLIN_WARRIOR);
expect(screen.getByText("Small")).toBeInTheDocument();
expect(screen.getByText("Goblin")).toBeInTheDocument();
expect(screen.getByText("Humanoid")).toBeInTheDocument();
});
it("renders source display name", () => {
renderStatBlock(GOBLIN_WARRIOR);
expect(screen.getByText("Monster Core")).toBeInTheDocument();
});
});
describe("recall knowledge", () => {
it("renders Recall Knowledge line for a creature with a recognized type trait", () => {
renderStatBlock(GOBLIN_WARRIOR);
expect(screen.getByText("Recall Knowledge")).toBeInTheDocument();
expect(screen.getByText(RK_DC_13_REGEX)).toBeInTheDocument();
expect(screen.getByText(RK_HUMANOID_SOCIETY_REGEX)).toBeInTheDocument();
});
it("adjusts DC for uncommon rarity", () => {
const uncommonCreature: Pf2eCreature = {
...GOBLIN_WARRIOR,
traits: ["uncommon", "small", "humanoid"],
};
renderStatBlock(uncommonCreature);
expect(screen.getByText(RK_DC_15_REGEX)).toBeInTheDocument();
});
it("adjusts DC for rare rarity", () => {
const rareCreature: Pf2eCreature = {
...GOBLIN_WARRIOR,
level: 5,
traits: ["rare", "medium", "undead"],
};
renderStatBlock(rareCreature);
expect(screen.getByText(RK_DC_25_REGEX)).toBeInTheDocument();
expect(screen.getByText(RK_UNDEAD_RELIGION_REGEX)).toBeInTheDocument();
});
it("shows multiple skills for types with dual skill mapping", () => {
const beastCreature: Pf2eCreature = {
...GOBLIN_WARRIOR,
traits: ["small", "beast"],
};
renderStatBlock(beastCreature);
expect(screen.getByText(RK_BEAST_SKILLS_REGEX)).toBeInTheDocument();
});
it("omits Recall Knowledge when no type trait is recognized", () => {
const noTypeCreature: Pf2eCreature = {
...GOBLIN_WARRIOR,
traits: ["small", "goblin"],
};
renderStatBlock(noTypeCreature);
expect(screen.queryByText("Recall Knowledge")).not.toBeInTheDocument();
});
});
describe("perception and senses", () => {
it("renders perception modifier and senses", () => {
renderStatBlock(GOBLIN_WARRIOR);
expect(screen.getByText("Perception")).toBeInTheDocument();
expect(screen.getByText(PERCEPTION_SENSES_REGEX)).toBeInTheDocument();
});
it("renders languages", () => {
renderStatBlock(GOBLIN_WARRIOR);
expect(screen.getByText("Languages")).toBeInTheDocument();
expect(screen.getByText("Common, Goblin")).toBeInTheDocument();
});
it("renders skills", () => {
renderStatBlock(GOBLIN_WARRIOR);
expect(screen.getByText("Skills")).toBeInTheDocument();
expect(screen.getByText(SKILLS_REGEX)).toBeInTheDocument();
});
});
describe("ability modifiers", () => {
it("renders all six ability labels", () => {
renderStatBlock(GOBLIN_WARRIOR);
for (const label of ["Str", "Dex", "Con", "Int", "Wis", "Cha"]) {
expect(screen.getByText(label)).toBeInTheDocument();
}
});
it("renders positive and negative modifiers", () => {
renderStatBlock(GOBLIN_WARRIOR);
expect(screen.getByText("+3")).toBeInTheDocument();
expect(screen.getByText("-1")).toBeInTheDocument();
});
});
describe("defenses", () => {
it("renders AC and saves", () => {
renderStatBlock(GOBLIN_WARRIOR);
expect(screen.getByText("AC")).toBeInTheDocument();
expect(screen.getByText(AC_REGEX)).toBeInTheDocument();
expect(screen.getByText("Fort")).toBeInTheDocument();
expect(screen.getByText("Ref")).toBeInTheDocument();
expect(screen.getByText("Will")).toBeInTheDocument();
});
it("renders HP", () => {
renderStatBlock(GOBLIN_WARRIOR);
expect(screen.getByText("HP")).toBeInTheDocument();
expect(screen.getByText("6")).toBeInTheDocument();
});
it("renders saveConditional inline with saves", () => {
renderStatBlock(NAUNET);
expect(screen.getByText(SAVE_CONDITIONAL_REGEX)).toBeInTheDocument();
});
it("omits saveConditional when absent", () => {
renderStatBlock(GOBLIN_WARRIOR);
expect(
screen.queryByText(SAVE_CONDITIONAL_ABSENT_REGEX),
).not.toBeInTheDocument();
});
it("renders hpDetails in parentheses after HP", () => {
renderStatBlock(TROLL);
expect(screen.getByText(HP_DETAILS_REGEX)).toBeInTheDocument();
});
it("omits hpDetails when absent", () => {
renderStatBlock(GOBLIN_WARRIOR);
expect(screen.queryByText(REGEN_REGEX)).not.toBeInTheDocument();
});
it("renders resistances and weaknesses", () => {
renderStatBlock(NAUNET);
expect(screen.getByText("Resistances")).toBeInTheDocument();
expect(
screen.getByText("Precision 5, Protean anatomy 10"),
).toBeInTheDocument();
});
});
describe("abilities", () => {
it("renders mid (defensive) abilities", () => {
renderStatBlock(GOBLIN_WARRIOR);
expect(screen.getByText(ABILITY_MID_NAME_REGEX)).toBeInTheDocument();
expect(screen.getByText(ABILITY_MID_DESC_REGEX)).toBeInTheDocument();
});
});
describe("speed and attacks", () => {
it("renders speed", () => {
renderStatBlock(GOBLIN_WARRIOR);
expect(screen.getByText("Speed")).toBeInTheDocument();
expect(screen.getByText("25 feet")).toBeInTheDocument();
});
it("renders attacks", () => {
renderStatBlock(GOBLIN_WARRIOR);
expect(screen.getByText(ATTACK_NAME_REGEX)).toBeInTheDocument();
expect(screen.getByText(ATTACK_DAMAGE_REGEX)).toBeInTheDocument();
});
});
describe("spellcasting", () => {
it("renders spellcasting entry with header", () => {
renderStatBlock(NAUNET);
expect(screen.getByText(SPELLCASTING_ENTRY_REGEX)).toBeInTheDocument();
expect(screen.getByText("DC 25, attack +17")).toBeInTheDocument();
});
it("renders ranked spells", () => {
renderStatBlock(NAUNET);
expect(screen.getByText("Rank 4:")).toBeInTheDocument();
expect(
screen.getByText("Unfettered Movement (Constant)"),
).toBeInTheDocument();
});
it("renders cantrips", () => {
renderStatBlock(NAUNET);
expect(screen.getByText("Cantrips:")).toBeInTheDocument();
expect(screen.getByText("Detect Magic")).toBeInTheDocument();
});
it("omits spellcasting when absent", () => {
renderStatBlock(GOBLIN_WARRIOR);
expect(screen.queryByText(CANTRIPS_REGEX)).not.toBeInTheDocument();
});
});
describe("equipment section", () => {
const CREATURE_WITH_EQUIPMENT: Pf2eCreature = {
...GOBLIN_WARRIOR,
id: creatureId("test:equipped"),
name: "Equipped NPC",
items: "longsword, leather armor",
equipment: [
{
name: "Giant Wasp Venom",
level: 7,
category: "poison",
traits: ["consumable", "poison"],
description: "A deadly poison extracted from giant wasps.",
},
{
name: "Scroll of Teleport",
level: 11,
category: "scroll",
traits: ["consumable", "magical", "scroll"],
description: "A scroll containing Teleport.",
spellName: "Teleport",
spellRank: 6,
},
{
name: "Plain Talisman",
level: 1,
traits: ["magical"],
},
],
};
it("renders Equipment section with item names", () => {
renderStatBlock(CREATURE_WITH_EQUIPMENT);
expect(
screen.getByRole("heading", { name: "Equipment" }),
).toBeInTheDocument();
expect(screen.getByText("Giant Wasp Venom")).toBeInTheDocument();
});
it("renders scroll name as-is from Foundry data", () => {
renderStatBlock(CREATURE_WITH_EQUIPMENT);
expect(screen.getByText(SCROLL_NAME_REGEX)).toBeInTheDocument();
});
it("does not render Equipment section when creature has no equipment", () => {
renderStatBlock(GOBLIN_WARRIOR);
expect(
screen.queryByRole("heading", { name: "Equipment" }),
).not.toBeInTheDocument();
});
it("renders equipment items with descriptions as clickable buttons", () => {
renderStatBlock(CREATURE_WITH_EQUIPMENT);
expect(
screen.getByRole("button", { name: "Giant Wasp Venom" }),
).toBeInTheDocument();
});
it("renders equipment items without descriptions as plain text", () => {
renderStatBlock(CREATURE_WITH_EQUIPMENT);
expect(
screen.queryByRole("button", { name: "Plain Talisman" }),
).not.toBeInTheDocument();
expect(screen.getByText("Plain Talisman")).toBeInTheDocument();
});
it("renders Items line with mundane item names", () => {
renderStatBlock(CREATURE_WITH_EQUIPMENT);
expect(screen.getByText("Items")).toBeInTheDocument();
expect(screen.getByText("longsword, leather armor")).toBeInTheDocument();
});
});
describe("clickable spells", () => {
const SPELLCASTER: Pf2eCreature = {
...NAUNET,
id: creatureId("test:spellcaster"),
name: "Spellcaster",
spellcasting: [
{
name: "Divine Innate Spells",
headerText: "DC 30, attack +20",
atWill: [{ name: "Detect Magic", rank: 1 }],
daily: [
{
uses: 4,
each: true,
spells: [
{
name: "Heal",
description: "You channel positive energy to heal.",
rank: 4,
usesPerDay: 3,
},
{ name: "Restoration", rank: 4 },
],
},
],
},
],
};
beforeEach(() => {
Object.defineProperty(globalThis, "matchMedia", {
writable: true,
configurable: true,
value: vi.fn().mockImplementation(() => ({
matches: true,
media: "(min-width: 1024px)",
onchange: null,
addEventListener: vi.fn(),
removeEventListener: vi.fn(),
addListener: vi.fn(),
removeListener: vi.fn(),
dispatchEvent: vi.fn(),
})),
});
});
it("renders a spell with a description as a clickable button", () => {
renderStatBlock(SPELLCASTER);
expect(screen.getByRole("button", { name: "Heal" })).toBeInTheDocument();
});
it("renders a spell without description as plain text (not a button)", () => {
renderStatBlock(SPELLCASTER);
expect(
screen.queryByRole("button", { name: "Restoration" }),
).not.toBeInTheDocument();
expect(screen.getByText("Restoration")).toBeInTheDocument();
});
it("renders usesPerDay as plain text alongside the spell button", () => {
renderStatBlock(SPELLCASTER);
expect(screen.getByText(USES_PER_DAY_REGEX)).toBeInTheDocument();
});
it("opens the spell popover when a spell button is clicked", async () => {
const user = userEvent.setup();
renderStatBlock(SPELLCASTER);
await user.click(screen.getByRole("button", { name: "Heal" }));
expect(screen.getByText(HEAL_DESCRIPTION_REGEX)).toBeInTheDocument();
});
it("closes the popover when Escape is pressed", async () => {
const user = userEvent.setup();
renderStatBlock(SPELLCASTER);
await user.click(screen.getByRole("button", { name: "Heal" }));
expect(screen.getByText(HEAL_DESCRIPTION_REGEX)).toBeInTheDocument();
await user.keyboard("{Escape}");
expect(
screen.queryByText(HEAL_DESCRIPTION_REGEX),
).not.toBeInTheDocument();
});
});
});

View File

@@ -37,15 +37,18 @@ function renderModal(open = true) {
} }
describe("SettingsModal", () => { describe("SettingsModal", () => {
it("renders edition section with 'Rules Edition' label", () => { it("renders game system section with all three options", () => {
renderModal(); renderModal();
expect(screen.getByText("Rules Edition")).toBeInTheDocument(); expect(screen.getByText("Game System")).toBeInTheDocument();
expect( expect(
screen.getByRole("button", { name: "5e (2014)" }), screen.getByRole("button", { name: "5e (2014)" }),
).toBeInTheDocument(); ).toBeInTheDocument();
expect( expect(
screen.getByRole("button", { name: "5.5e (2024)" }), screen.getByRole("button", { name: "5.5e (2024)" }),
).toBeInTheDocument(); ).toBeInTheDocument();
expect(
screen.getByRole("button", { name: "Pathfinder 2e" }),
).toBeInTheDocument();
}); });
it("renders theme toggle buttons", () => { it("renders theme toggle buttons", () => {

View File

@@ -6,6 +6,7 @@ import userEvent from "@testing-library/user-event";
import { afterEach, describe, expect, it, vi } from "vitest"; import { afterEach, describe, expect, it, vi } from "vitest";
import { createTestAdapters } from "../../__tests__/adapters/in-memory-adapters.js"; import { createTestAdapters } from "../../__tests__/adapters/in-memory-adapters.js";
import { AdapterProvider } from "../../contexts/adapter-context.js"; import { AdapterProvider } from "../../contexts/adapter-context.js";
import { RulesEditionProvider } from "../../contexts/rules-edition-context.js";
import { SourceFetchPrompt } from "../source-fetch-prompt.js"; import { SourceFetchPrompt } from "../source-fetch-prompt.js";
const MONSTER_MANUAL_REGEX = /Monster Manual/; const MONSTER_MANUAL_REGEX = /Monster Manual/;
@@ -36,12 +37,14 @@ function renderPrompt(sourceCode = "MM") {
code === "MM" ? "Monster Manual" : code, code === "MM" ? "Monster Manual" : code,
}; };
const result = render( const result = render(
<RulesEditionProvider>
<AdapterProvider adapters={adapters}> <AdapterProvider adapters={adapters}>
<SourceFetchPrompt <SourceFetchPrompt
sourceCode={sourceCode} sourceCode={sourceCode}
onSourceLoaded={onSourceLoaded} onSourceLoaded={onSourceLoaded}
/> />
</AdapterProvider>, </AdapterProvider>
</RulesEditionProvider>,
); );
return { ...result, onSourceLoaded }; return { ...result, onSourceLoaded };
} }
@@ -62,7 +65,7 @@ describe("SourceFetchPrompt", () => {
}); });
it("Load calls fetchAndCacheSource and onSourceLoaded on success", async () => { it("Load calls fetchAndCacheSource and onSourceLoaded on success", async () => {
mockFetchAndCacheSource.mockResolvedValueOnce(undefined); mockFetchAndCacheSource.mockResolvedValueOnce({ skippedNames: [] });
const user = userEvent.setup(); const user = userEvent.setup();
const { onSourceLoaded } = renderPrompt(); const { onSourceLoaded } = renderPrompt();

View File

@@ -28,7 +28,7 @@ beforeAll(() => {
afterEach(cleanup); afterEach(cleanup);
function renderWithSources(sources: CachedSourceInfo[] = []) { function renderWithSources(sources: CachedSourceInfo[] = []): void {
const adapters = createTestAdapters(); const adapters = createTestAdapters();
// Wire getCachedSources to return the provided sources initially, // Wire getCachedSources to return the provided sources initially,
// then empty after clear operations // then empty after clear operations
@@ -36,7 +36,7 @@ function renderWithSources(sources: CachedSourceInfo[] = []) {
adapters.bestiaryCache = { adapters.bestiaryCache = {
...adapters.bestiaryCache, ...adapters.bestiaryCache,
getCachedSources: () => Promise.resolve(currentSources), getCachedSources: () => Promise.resolve(currentSources),
clearSource(sourceCode) { clearSource(_system, sourceCode) {
currentSources = currentSources.filter( currentSources = currentSources.filter(
(s) => s.sourceCode !== sourceCode, (s) => s.sourceCode !== sourceCode,
); );
@@ -57,14 +57,14 @@ function renderWithSources(sources: CachedSourceInfo[] = []) {
describe("SourceManager", () => { describe("SourceManager", () => {
it("shows 'No cached sources' empty state when no sources", async () => { it("shows 'No cached sources' empty state when no sources", async () => {
void renderWithSources([]); renderWithSources([]);
await waitFor(() => { await waitFor(() => {
expect(screen.getByText("No cached sources")).toBeInTheDocument(); expect(screen.getByText("No cached sources")).toBeInTheDocument();
}); });
}); });
it("lists cached sources with display name and creature count", async () => { it("lists cached sources with display name and creature count", async () => {
void renderWithSources([ renderWithSources([
{ {
sourceCode: "mm", sourceCode: "mm",
displayName: "Monster Manual", displayName: "Monster Manual",
@@ -88,7 +88,7 @@ describe("SourceManager", () => {
it("Clear All button removes all sources", async () => { it("Clear All button removes all sources", async () => {
const user = userEvent.setup(); const user = userEvent.setup();
void renderWithSources([ renderWithSources([
{ {
sourceCode: "mm", sourceCode: "mm",
displayName: "Monster Manual", displayName: "Monster Manual",
@@ -110,7 +110,7 @@ describe("SourceManager", () => {
it("individual source delete button removes that source", async () => { it("individual source delete button removes that source", async () => {
const user = userEvent.setup(); const user = userEvent.setup();
void renderWithSources([ renderWithSources([
{ {
sourceCode: "mm", sourceCode: "mm",
displayName: "Monster Manual", displayName: "Monster Manual",

View File

@@ -0,0 +1,158 @@
// @vitest-environment jsdom
import "@testing-library/jest-dom/vitest";
import type { SpellReference } from "@initiative/domain";
import { cleanup, fireEvent, render, screen } from "@testing-library/react";
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
import { SpellDetailPopover } from "../spell-detail-popover.js";
afterEach(cleanup);
const FIREBALL: SpellReference = {
name: "Fireball",
slug: "fireball",
rank: 3,
description: "A spark leaps from your fingertip to the target.",
traits: ["fire", "manipulate"],
traditions: ["arcane", "primal"],
range: "500 feet",
area: "20-foot burst",
defense: "basic Reflex",
actionCost: "2",
heightening: "Heightened (+1) The damage increases by 2d6.",
};
const ANCHOR: DOMRect = new DOMRect(100, 100, 50, 20);
const SPARK_LEAPS_REGEX = /spark leaps/;
const HEIGHTENED_REGEX = /Heightened.*2d6/;
const RANGE_REGEX = /500 feet/;
const AREA_REGEX = /20-foot burst/;
const DEFENSE_REGEX = /basic Reflex/;
const NO_DESCRIPTION_REGEX = /No description available/;
const DIALOG_LABEL_REGEX = /Spell details: Fireball/;
beforeEach(() => {
// Force desktop variant in jsdom
Object.defineProperty(globalThis, "matchMedia", {
writable: true,
configurable: true,
value: vi.fn().mockImplementation(() => ({
matches: true,
media: "(min-width: 1024px)",
onchange: null,
addEventListener: vi.fn(),
removeEventListener: vi.fn(),
addListener: vi.fn(),
removeListener: vi.fn(),
dispatchEvent: vi.fn(),
})),
});
});
describe("SpellDetailPopover", () => {
it("renders spell name, rank, traits, and description", () => {
render(
<SpellDetailPopover
spell={FIREBALL}
anchorRect={ANCHOR}
onClose={() => {}}
/>,
);
expect(screen.getByText("Fireball")).toBeInTheDocument();
expect(screen.getByText("3rd")).toBeInTheDocument();
expect(screen.getByText("fire")).toBeInTheDocument();
expect(screen.getByText("manipulate")).toBeInTheDocument();
expect(screen.getByText(SPARK_LEAPS_REGEX)).toBeInTheDocument();
});
it("renders heightening rules when present", () => {
render(
<SpellDetailPopover
spell={FIREBALL}
anchorRect={ANCHOR}
onClose={() => {}}
/>,
);
expect(screen.getByText(HEIGHTENED_REGEX)).toBeInTheDocument();
});
it("renders range, area, and defense", () => {
render(
<SpellDetailPopover
spell={FIREBALL}
anchorRect={ANCHOR}
onClose={() => {}}
/>,
);
expect(screen.getByText(RANGE_REGEX)).toBeInTheDocument();
expect(screen.getByText(AREA_REGEX)).toBeInTheDocument();
expect(screen.getByText(DEFENSE_REGEX)).toBeInTheDocument();
});
it("calls onClose when Escape is pressed", () => {
const onClose = vi.fn();
render(
<SpellDetailPopover
spell={FIREBALL}
anchorRect={ANCHOR}
onClose={onClose}
/>,
);
fireEvent.keyDown(document, { key: "Escape" });
expect(onClose).toHaveBeenCalledTimes(1);
});
it("shows placeholder when description is missing", () => {
const spell: SpellReference = { name: "Mystery", rank: 1 };
render(
<SpellDetailPopover
spell={spell}
anchorRect={ANCHOR}
onClose={() => {}}
/>,
);
expect(screen.getByText(NO_DESCRIPTION_REGEX)).toBeInTheDocument();
});
it("renders the action cost as an icon when it is a numeric action count", () => {
render(
<SpellDetailPopover
spell={FIREBALL}
anchorRect={ANCHOR}
onClose={() => {}}
/>,
);
// Action cost "2" renders as an SVG ActivityIcon (portaled to body)
const dialog = screen.getByRole("dialog");
expect(dialog.querySelector("svg")).toBeInTheDocument();
});
it("renders non-numeric action cost as text", () => {
const spell: SpellReference = {
...FIREBALL,
actionCost: "1 minute",
};
render(
<SpellDetailPopover
spell={spell}
anchorRect={ANCHOR}
onClose={() => {}}
/>,
);
expect(screen.getByText("1 minute")).toBeInTheDocument();
});
it("uses the dialog role with the spell name as label", () => {
render(
<SpellDetailPopover
spell={FIREBALL}
anchorRect={ANCHOR}
onClose={() => {}}
/>,
);
expect(
screen.getByRole("dialog", { name: DIALOG_LABEL_REGEX }),
).toBeInTheDocument();
});
});

View File

@@ -5,7 +5,7 @@ import type { Creature } from "@initiative/domain";
import { creatureId } from "@initiative/domain"; import { creatureId } from "@initiative/domain";
import { cleanup, render, screen } from "@testing-library/react"; import { cleanup, render, screen } from "@testing-library/react";
import { afterEach, describe, expect, it } from "vitest"; import { afterEach, describe, expect, it } from "vitest";
import { StatBlock } from "../stat-block.js"; import { DndStatBlock as StatBlock } from "../dnd-stat-block.js";
afterEach(cleanup); afterEach(cleanup);
@@ -46,10 +46,30 @@ const GOBLIN: Creature = {
skills: "Stealth +6", skills: "Stealth +6",
senses: "darkvision 60 ft., passive Perception 9", senses: "darkvision 60 ft., passive Perception 9",
languages: "Common, Goblin", languages: "Common, Goblin",
traits: [{ name: "Nimble Escape", text: "Disengage or Hide as bonus." }], traits: [
actions: [{ name: "Scimitar", text: "Melee: +4 to hit, 5 slashing." }], {
bonusActions: [{ name: "Nimble", text: "Disengage or Hide." }], name: "Nimble Escape",
reactions: [{ name: "Redirect", text: "Redirect attack to ally." }], segments: [{ type: "text", value: "Disengage or Hide as bonus." }],
},
],
actions: [
{
name: "Scimitar",
segments: [{ type: "text", value: "Melee: +4 to hit, 5 slashing." }],
},
],
bonusActions: [
{
name: "Nimble",
segments: [{ type: "text", value: "Disengage or Hide." }],
},
],
reactions: [
{
name: "Redirect",
segments: [{ type: "text", value: "Redirect attack to ally." }],
},
],
}; };
const DRAGON: Creature = { const DRAGON: Creature = {
@@ -75,17 +95,31 @@ const DRAGON: Creature = {
legendaryActions: { legendaryActions: {
preamble: "The dragon can take 3 legendary actions.", preamble: "The dragon can take 3 legendary actions.",
entries: [ entries: [
{ name: "Detect", text: "Wisdom (Perception) check." }, {
{ name: "Tail Attack", text: "Tail attack." }, name: "Detect",
segments: [
{ type: "text" as const, value: "Wisdom (Perception) check." },
],
},
{
name: "Tail Attack",
segments: [{ type: "text" as const, value: "Tail attack." }],
},
], ],
}, },
spellcasting: [ spellcasting: [
{ {
name: "Innate Spellcasting", name: "Innate Spellcasting",
headerText: "The dragon's spellcasting ability is Charisma.", headerText: "The dragon's spellcasting ability is Charisma.",
atWill: ["detect magic", "suggestion"], atWill: [{ name: "detect magic" }, { name: "suggestion" }],
daily: [{ uses: 3, each: true, spells: ["fireball", "wall of fire"] }], daily: [
restLong: [{ uses: 1, each: false, spells: ["wish"] }], {
uses: 3,
each: true,
spells: [{ name: "fireball" }, { name: "wall of fire" }],
},
],
restLong: [{ uses: 1, each: false, spells: [{ name: "wish" }] }],
}, },
], ],
}; };

View File

@@ -3,23 +3,30 @@ import { useId, useState } from "react";
import { useAdapters } from "../contexts/adapter-context.js"; import { useAdapters } from "../contexts/adapter-context.js";
import { useBestiaryContext } from "../contexts/bestiary-context.js"; import { useBestiaryContext } from "../contexts/bestiary-context.js";
import { useBulkImportContext } from "../contexts/bulk-import-context.js"; import { useBulkImportContext } from "../contexts/bulk-import-context.js";
import { useRulesEditionContext } from "../contexts/rules-edition-context.js";
import { useSidePanelContext } from "../contexts/side-panel-context.js"; import { useSidePanelContext } from "../contexts/side-panel-context.js";
import { Button } from "./ui/button.js"; import { Button } from "./ui/button.js";
import { Input } from "./ui/input.js"; import { Input } from "./ui/input.js";
const DEFAULT_BASE_URL = const DND_BASE_URL =
"https://raw.githubusercontent.com/5etools-mirror-3/5etools-src/main/data/bestiary/"; "https://raw.githubusercontent.com/5etools-mirror-3/5etools-src/main/data/bestiary/";
const PF2E_BASE_URL =
"https://raw.githubusercontent.com/foundryvtt/pf2e/v13-dev/packs/pf2e/";
export function BulkImportPrompt() { export function BulkImportPrompt() {
const { bestiaryIndex } = useAdapters(); const { bestiaryIndex, pf2eBestiaryIndex } = useAdapters();
const { fetchAndCacheSource, isSourceCached, refreshCache } = const { fetchAndCacheSource, isSourceCached, refreshCache } =
useBestiaryContext(); useBestiaryContext();
const { state: importState, startImport, reset } = useBulkImportContext(); const { state: importState, startImport, reset } = useBulkImportContext();
const { dismissPanel } = useSidePanelContext(); const { dismissPanel } = useSidePanelContext();
const { edition } = useRulesEditionContext();
const [baseUrl, setBaseUrl] = useState(DEFAULT_BASE_URL); const indexPort = edition === "pf2e" ? pf2eBestiaryIndex : bestiaryIndex;
const defaultUrl = edition === "pf2e" ? PF2E_BASE_URL : DND_BASE_URL;
const [baseUrl, setBaseUrl] = useState(defaultUrl);
const baseUrlId = useId(); const baseUrlId = useId();
const totalSources = bestiaryIndex.getAllSourceCodes().length; const totalSources = indexPort.getAllSourceCodes().length;
const handleStart = (url: string) => { const handleStart = (url: string) => {
startImport(url, fetchAndCacheSource, isSourceCached, refreshCache); startImport(url, fetchAndCacheSource, isSourceCached, refreshCache);

View File

@@ -1,6 +1,6 @@
import { import {
type CombatantId, type CombatantId,
type ConditionId, type ConditionEntry,
type CreatureId, type CreatureId,
deriveHpStatus, deriveHpStatus,
type PlayerIcon, type PlayerIcon,
@@ -10,6 +10,7 @@ import { Brain, Pencil, X } from "lucide-react";
import { type Ref, useCallback, useEffect, useRef, useState } from "react"; import { type Ref, useCallback, useEffect, useRef, useState } from "react";
import { useEncounterContext } from "../contexts/encounter-context.js"; import { useEncounterContext } from "../contexts/encounter-context.js";
import { useInitiativeRollsContext } from "../contexts/initiative-rolls-context.js"; import { useInitiativeRollsContext } from "../contexts/initiative-rolls-context.js";
import { useRulesEditionContext } from "../contexts/rules-edition-context.js";
import { useSidePanelContext } from "../contexts/side-panel-context.js"; import { useSidePanelContext } from "../contexts/side-panel-context.js";
import { useLongPress } from "../hooks/use-long-press.js"; import { useLongPress } from "../hooks/use-long-press.js";
import { cn } from "../lib/utils.js"; import { cn } from "../lib/utils.js";
@@ -31,7 +32,7 @@ interface Combatant {
readonly currentHp?: number; readonly currentHp?: number;
readonly tempHp?: number; readonly tempHp?: number;
readonly ac?: number; readonly ac?: number;
readonly conditions?: readonly ConditionId[]; readonly conditions?: readonly ConditionEntry[];
readonly isConcentrating?: boolean; readonly isConcentrating?: boolean;
readonly color?: string; readonly color?: string;
readonly icon?: string; readonly icon?: string;
@@ -415,12 +416,14 @@ function InitiativeDisplay({
function rowBorderClass( function rowBorderClass(
isActive: boolean, isActive: boolean,
isConcentrating: boolean | undefined, isConcentrating: boolean | undefined,
isPf2e: boolean,
): string { ): string {
if (isActive && isConcentrating) const showConcentration = isConcentrating && !isPf2e;
if (isActive && showConcentration)
return "border border-l-2 border-active-row-border border-l-purple-400 bg-active-row-bg card-glow"; return "border border-l-2 border-active-row-border border-l-purple-400 bg-active-row-bg card-glow";
if (isActive) if (isActive)
return "border border-l-2 border-active-row-border bg-active-row-bg card-glow"; return "border border-l-2 border-active-row-border bg-active-row-bg card-glow";
if (isConcentrating) if (showConcentration)
return "border border-l-2 border-transparent border-l-purple-400"; return "border border-l-2 border-transparent border-l-purple-400";
return "border border-l-2 border-transparent"; return "border border-l-2 border-transparent";
} }
@@ -448,14 +451,24 @@ export function CombatantRow({
setTempHp, setTempHp,
setAc, setAc,
toggleCondition, toggleCondition,
setConditionValue,
decrementCondition,
toggleConcentration, toggleConcentration,
} = useEncounterContext(); } = useEncounterContext();
const { selectedCreatureId, showCreature, toggleCollapse } = const {
useSidePanelContext(); selectedCreatureId,
selectedCombatantId,
showCreature,
toggleCollapse,
} = useSidePanelContext();
const { handleRollInitiative } = useInitiativeRollsContext(); const { handleRollInitiative } = useInitiativeRollsContext();
const { edition } = useRulesEditionContext();
const isPf2e = edition === "pf2e";
// Derive what was previously conditional props // Derive what was previously conditional props
const isStatBlockOpen = combatant.creatureId === selectedCreatureId; const isStatBlockOpen =
combatant.creatureId === selectedCreatureId &&
combatant.id === selectedCombatantId;
const { creatureId } = combatant; const { creatureId } = combatant;
const hasStatBlock = !!creatureId; const hasStatBlock = !!creatureId;
const onToggleStatBlock = hasStatBlock const onToggleStatBlock = hasStatBlock
@@ -463,7 +476,7 @@ export function CombatantRow({
if (isStatBlockOpen) { if (isStatBlockOpen) {
toggleCollapse(); toggleCollapse();
} else { } else {
showCreature(creatureId); showCreature(creatureId, combatant.id);
} }
} }
: undefined; : undefined;
@@ -493,12 +506,16 @@ export function CombatantRow({
const tempHpDropped = const tempHpDropped =
prevTempHp !== undefined && (combatant.tempHp ?? 0) < prevTempHp; prevTempHp !== undefined && (combatant.tempHp ?? 0) < prevTempHp;
if ((realHpDropped || tempHpDropped) && combatant.isConcentrating) { if (
(realHpDropped || tempHpDropped) &&
combatant.isConcentrating &&
!isPf2e
) {
setIsPulsing(true); setIsPulsing(true);
clearTimeout(pulseTimerRef.current); clearTimeout(pulseTimerRef.current);
pulseTimerRef.current = setTimeout(() => setIsPulsing(false), 1200); pulseTimerRef.current = setTimeout(() => setIsPulsing(false), 1200);
} }
}, [currentHp, combatant.tempHp, combatant.isConcentrating]); }, [currentHp, combatant.tempHp, combatant.isConcentrating, isPf2e]);
useEffect(() => { useEffect(() => {
if (!combatant.isConcentrating) { if (!combatant.isConcentrating) {
@@ -516,12 +533,20 @@ export function CombatantRow({
ref={ref} ref={ref}
className={cn( className={cn(
"group rounded-lg pr-3 transition-colors", "group rounded-lg pr-3 transition-colors",
rowBorderClass(isActive, combatant.isConcentrating), rowBorderClass(isActive, combatant.isConcentrating, isPf2e),
isPulsing && "animate-concentration-pulse", isPulsing && "animate-concentration-pulse",
)} )}
> >
<div className="grid grid-cols-[2rem_3rem_auto_1fr_auto_2rem] items-center gap-1.5 py-3 sm:grid-cols-[2rem_3.5rem_auto_1fr_auto_2rem] sm:gap-3 sm:py-2"> <div
{/* Concentration */} className={cn(
"grid items-center gap-1.5 py-3 sm:gap-3 sm:py-2",
isPf2e
? "grid-cols-[3rem_auto_1fr_auto_2rem] pl-3 sm:grid-cols-[3.5rem_auto_1fr_auto_2rem]"
: "grid-cols-[2rem_3rem_auto_1fr_auto_2rem] sm:grid-cols-[2rem_3.5rem_auto_1fr_auto_2rem]",
)}
>
{/* Concentration — hidden in PF2e mode */}
{!isPf2e && (
<button <button
type="button" type="button"
onClick={() => toggleConcentration(id)} onClick={() => toggleConcentration(id)}
@@ -534,6 +559,7 @@ export function CombatantRow({
> >
<Brain size={16} /> <Brain size={16} />
</button> </button>
)}
{/* Initiative */} {/* Initiative */}
<div className="rounded-md bg-muted/30 px-1"> <div className="rounded-md bg-muted/30 px-1">
@@ -585,6 +611,7 @@ export function CombatantRow({
<ConditionTags <ConditionTags
conditions={combatant.conditions} conditions={combatant.conditions}
onRemove={(conditionId) => toggleCondition(id, conditionId)} onRemove={(conditionId) => toggleCondition(id, conditionId)}
onDecrement={(conditionId) => decrementCondition(id, conditionId)}
onOpenPicker={() => setPickerOpen((prev) => !prev)} onOpenPicker={() => setPickerOpen((prev) => !prev)}
/> />
</div> </div>
@@ -593,6 +620,9 @@ export function CombatantRow({
anchorRef={conditionAnchorRef} anchorRef={conditionAnchorRef}
activeConditions={combatant.conditions} activeConditions={combatant.conditions}
onToggle={(conditionId) => toggleCondition(id, conditionId)} onToggle={(conditionId) => toggleCondition(id, conditionId)}
onSetValue={(conditionId, value) =>
setConditionValue(id, conditionId, value)
}
onClose={() => setPickerOpen(false)} onClose={() => setPickerOpen(false)}
/> />
)} )}

View File

@@ -1,8 +1,10 @@
import { import {
type ConditionEntry,
type ConditionId, type ConditionId,
getConditionDescription, getConditionDescription,
getConditionsForEdition, getConditionsForEdition,
} from "@initiative/domain"; } from "@initiative/domain";
import { Check, Minus, Plus } from "lucide-react";
import { useLayoutEffect, useRef, useState } from "react"; import { useLayoutEffect, useRef, useState } from "react";
import { createPortal } from "react-dom"; import { createPortal } from "react-dom";
import { useRulesEditionContext } from "../contexts/rules-edition-context.js"; import { useRulesEditionContext } from "../contexts/rules-edition-context.js";
@@ -16,8 +18,9 @@ import { Tooltip } from "./ui/tooltip.js";
interface ConditionPickerProps { interface ConditionPickerProps {
anchorRef: React.RefObject<HTMLElement | null>; anchorRef: React.RefObject<HTMLElement | null>;
activeConditions: readonly ConditionId[] | undefined; activeConditions: readonly ConditionEntry[] | undefined;
onToggle: (conditionId: ConditionId) => void; onToggle: (conditionId: ConditionId) => void;
onSetValue: (conditionId: ConditionId, value: number) => void;
onClose: () => void; onClose: () => void;
} }
@@ -25,6 +28,7 @@ export function ConditionPicker({
anchorRef, anchorRef,
activeConditions, activeConditions,
onToggle, onToggle,
onSetValue,
onClose, onClose,
}: Readonly<ConditionPickerProps>) { }: Readonly<ConditionPickerProps>) {
const ref = useRef<HTMLDivElement>(null); const ref = useRef<HTMLDivElement>(null);
@@ -34,6 +38,11 @@ export function ConditionPicker({
maxHeight: number; maxHeight: number;
} | null>(null); } | null>(null);
const [editing, setEditing] = useState<{
id: ConditionId;
value: number;
} | null>(null);
useLayoutEffect(() => { useLayoutEffect(() => {
const anchor = anchorRef.current; const anchor = anchorRef.current;
const el = ref.current; const el = ref.current;
@@ -59,7 +68,9 @@ export function ConditionPicker({
const { edition } = useRulesEditionContext(); const { edition } = useRulesEditionContext();
const conditions = getConditionsForEdition(edition); const conditions = getConditionsForEdition(edition);
const active = new Set(activeConditions ?? []); const activeMap = new Map(
(activeConditions ?? []).map((e) => [e.id, e.value]),
);
return createPortal( return createPortal(
<div <div
@@ -74,35 +85,127 @@ export function ConditionPicker({
{conditions.map((def) => { {conditions.map((def) => {
const Icon = CONDITION_ICON_MAP[def.iconName]; const Icon = CONDITION_ICON_MAP[def.iconName];
if (!Icon) return null; if (!Icon) return null;
const isActive = active.has(def.id); const isActive = activeMap.has(def.id);
const activeValue = activeMap.get(def.id);
const isEditing = editing?.id === def.id;
const colorClass = const colorClass =
CONDITION_COLOR_CLASSES[def.color] ?? "text-muted-foreground"; CONDITION_COLOR_CLASSES[def.color] ?? "text-muted-foreground";
const handleClick = () => {
if (def.valued && edition === "pf2e") {
const current = activeMap.get(def.id);
setEditing({
id: def.id,
value: current ?? 1,
});
} else {
onToggle(def.id);
}
};
return ( return (
<Tooltip <Tooltip
key={def.id} key={def.id}
content={getConditionDescription(def, edition)} content={getConditionDescription(def, edition)}
className="block" className="block"
>
<div
className={cn(
"flex w-full items-center gap-2 rounded px-2 py-1 text-sm transition-colors",
(isActive || isEditing) && "bg-card/50",
)}
> >
<button <button
type="button" type="button"
className={cn( className="flex flex-1 items-center gap-2"
"flex w-full items-center gap-2 rounded px-2 py-1 text-sm transition-colors hover:bg-hover-neutral-bg", onClick={handleClick}
isActive && "bg-card/50",
)}
onClick={() => onToggle(def.id)}
> >
<Icon <Icon
size={14} size={14}
className={isActive ? colorClass : "text-muted-foreground"} className={
isActive || isEditing ? colorClass : "text-muted-foreground"
}
/> />
<span <span
className={ className={
isActive ? "text-foreground" : "text-muted-foreground" isActive || isEditing
? "text-foreground"
: "text-muted-foreground"
} }
> >
{def.label} {def.label}
</span> </span>
</button> </button>
{isActive && def.valued && edition === "pf2e" && !isEditing && (
<span className="min-w-5 rounded-full bg-accent px-1.5 py-0.5 text-center font-medium text-primary-foreground text-xs">
{activeValue}
</span>
)}
{isEditing && (
<div className="flex items-center gap-0.5">
<button
type="button"
className="rounded p-0.5 text-foreground hover:bg-accent/40"
onMouseDown={(e) => e.preventDefault()}
onClick={(e) => {
e.stopPropagation();
if (editing.value > 1) {
setEditing({
...editing,
value: editing.value - 1,
});
}
}}
>
<Minus className="h-3 w-3" />
</button>
<span className="min-w-5 rounded-full bg-accent px-1.5 py-0.5 text-center font-medium text-primary-foreground text-xs">
{editing.value}
</span>
{(() => {
const atMax =
def.maxValue !== undefined &&
editing.value >= def.maxValue;
return (
<button
type="button"
className={cn(
"rounded p-0.5",
atMax
? "cursor-not-allowed text-muted-foreground opacity-50"
: "text-foreground hover:bg-accent/40",
)}
disabled={atMax}
onMouseDown={(e) => e.preventDefault()}
onClick={(e) => {
e.stopPropagation();
if (!atMax) {
setEditing({
...editing,
value: editing.value + 1,
});
}
}}
>
<Plus className="h-3 w-3" />
</button>
);
})()}
<button
type="button"
className="ml-0.5 rounded p-0.5 text-foreground hover:bg-accent/40"
onMouseDown={(e) => e.preventDefault()}
onClick={(e) => {
e.stopPropagation();
onSetValue(editing.id, editing.value);
setEditing(null);
}}
>
<Check className="h-3.5 w-3.5" />
</button>
</div>
)}
</div>
</Tooltip> </Tooltip>
); );
})} })}

View File

@@ -1,42 +1,74 @@
import type { LucideIcon } from "lucide-react"; import type { LucideIcon } from "lucide-react";
import { import {
Anchor,
ArrowDown, ArrowDown,
Ban, Ban,
BatteryLow, BatteryLow,
BrainCog,
CircleHelp,
CloudFog,
Drama,
Droplet, Droplet,
Droplets,
EarOff, EarOff,
Eye,
EyeOff, EyeOff,
Footprints,
Gem, Gem,
Ghost, Ghost,
Hand, Hand,
Heart, Heart,
HeartCrack,
HeartPulse,
Link, Link,
Moon, Moon,
PersonStanding,
ShieldMinus, ShieldMinus,
ShieldOff,
Siren, Siren,
Skull,
Snail, Snail,
Sparkles, Sparkles,
Sun,
TrendingDown,
Zap,
ZapOff, ZapOff,
} from "lucide-react"; } from "lucide-react";
export const CONDITION_ICON_MAP: Record<string, LucideIcon> = { export const CONDITION_ICON_MAP: Record<string, LucideIcon> = {
EyeOff, Anchor,
Heart,
EarOff,
BatteryLow,
Siren,
Hand,
Ban,
Ghost,
ZapOff,
Gem,
Droplet,
ArrowDown, ArrowDown,
Ban,
BatteryLow,
BrainCog,
CircleHelp,
CloudFog,
Drama,
Droplet,
Droplets,
EarOff,
Eye,
EyeOff,
Footprints,
Gem,
Ghost,
Hand,
Heart,
HeartCrack,
HeartPulse,
Link, Link,
Moon,
PersonStanding,
ShieldMinus, ShieldMinus,
ShieldOff,
Siren,
Skull,
Snail, Snail,
Sparkles, Sparkles,
Moon, Sun,
TrendingDown,
Zap,
ZapOff,
}; };
export const CONDITION_COLOR_CLASSES: Record<string, string> = { export const CONDITION_COLOR_CLASSES: Record<string, string> = {
@@ -51,4 +83,5 @@ export const CONDITION_COLOR_CLASSES: Record<string, string> = {
green: "text-green-400", green: "text-green-400",
indigo: "text-indigo-400", indigo: "text-indigo-400",
sky: "text-sky-400", sky: "text-sky-400",
red: "text-red-400",
}; };

View File

@@ -1,5 +1,6 @@
import { import {
CONDITION_DEFINITIONS, CONDITION_DEFINITIONS,
type ConditionEntry,
type ConditionId, type ConditionId,
getConditionDescription, getConditionDescription,
} from "@initiative/domain"; } from "@initiative/domain";
@@ -13,44 +14,57 @@ import {
import { Tooltip } from "./ui/tooltip.js"; import { Tooltip } from "./ui/tooltip.js";
interface ConditionTagsProps { interface ConditionTagsProps {
conditions: readonly ConditionId[] | undefined; conditions: readonly ConditionEntry[] | undefined;
onRemove: (conditionId: ConditionId) => void; onRemove: (conditionId: ConditionId) => void;
onDecrement: (conditionId: ConditionId) => void;
onOpenPicker: () => void; onOpenPicker: () => void;
} }
export function ConditionTags({ export function ConditionTags({
conditions, conditions,
onRemove, onRemove,
onDecrement,
onOpenPicker, onOpenPicker,
}: Readonly<ConditionTagsProps>) { }: Readonly<ConditionTagsProps>) {
const { edition } = useRulesEditionContext(); const { edition } = useRulesEditionContext();
return ( return (
<div className="flex flex-wrap items-center gap-0.5"> <div className="flex flex-wrap items-center gap-0.5">
{conditions?.map((condId) => { {conditions?.map((entry) => {
const def = CONDITION_DEFINITIONS.find((d) => d.id === condId); const def = CONDITION_DEFINITIONS.find((d) => d.id === entry.id);
if (!def) return null; if (!def) return null;
const Icon = CONDITION_ICON_MAP[def.iconName]; const Icon = CONDITION_ICON_MAP[def.iconName];
if (!Icon) return null; if (!Icon) return null;
const colorClass = const colorClass =
CONDITION_COLOR_CLASSES[def.color] ?? "text-muted-foreground"; CONDITION_COLOR_CLASSES[def.color] ?? "text-muted-foreground";
const tooltipLabel =
entry.value === undefined ? def.label : `${def.label} ${entry.value}`;
return ( return (
<Tooltip <Tooltip
key={condId} key={entry.id}
content={`${def.label}:\n${getConditionDescription(def, edition)}`} content={`${tooltipLabel}:\n${getConditionDescription(def, edition)}`}
> >
<button <button
type="button" type="button"
aria-label={`Remove ${def.label}`} aria-label={`Remove ${def.label}`}
className={cn( className={cn(
"inline-flex items-center rounded p-0.5 transition-colors hover:bg-hover-neutral-bg", "inline-flex items-center gap-0.5 rounded p-0.5 transition-colors hover:bg-hover-neutral-bg",
colorClass, colorClass,
)} )}
onClick={(e) => { onClick={(e) => {
e.stopPropagation(); e.stopPropagation();
onRemove(condId); if (entry.value === undefined) {
onRemove(entry.id);
} else {
onDecrement(entry.id);
}
}} }}
> >
<Icon size={14} /> <Icon size={14} />
{entry.value !== undefined && (
<span className="font-medium text-xs leading-none">
{entry.value}
</span>
)}
</button> </button>
</Tooltip> </Tooltip>
); );

View File

@@ -0,0 +1,141 @@
import type { ReactNode } from "react";
import { useEffect, useLayoutEffect, useRef, useState } from "react";
import { createPortal } from "react-dom";
import { useClickOutside } from "../hooks/use-click-outside.js";
import { useSwipeToDismissDown } from "../hooks/use-swipe-to-dismiss.js";
import { cn } from "../lib/utils.js";
interface DetailPopoverProps {
readonly anchorRect: DOMRect;
readonly onClose: () => void;
readonly ariaLabel: string;
readonly children: ReactNode;
}
function DesktopPanel({
anchorRect,
onClose,
ariaLabel,
children,
}: Readonly<DetailPopoverProps>) {
const ref = useRef<HTMLDivElement>(null);
const [pos, setPos] = useState<{ top: number; left: number } | null>(null);
useLayoutEffect(() => {
const el = ref.current;
if (!el) return;
const popover = el.getBoundingClientRect();
const vw = document.documentElement.clientWidth;
const vh = document.documentElement.clientHeight;
// Prefer placement to the LEFT of the anchor (panel is on the right edge)
let left = anchorRect.left - popover.width - 8;
if (left < 8) {
left = anchorRect.right + 8;
}
if (left + popover.width > vw - 8) {
left = vw - popover.width - 8;
}
let top = anchorRect.top;
if (top + popover.height > vh - 8) {
top = vh - popover.height - 8;
}
if (top < 8) top = 8;
setPos({ top, left });
}, [anchorRect]);
useClickOutside(ref, onClose);
return (
<div
ref={ref}
className="card-glow fixed z-50 max-h-[calc(100vh-16px)] w-80 max-w-[calc(100vw-16px)] overflow-y-auto rounded-lg border border-border bg-card p-4 shadow-lg"
style={pos ? { top: pos.top, left: pos.left } : { visibility: "hidden" }}
role="dialog"
aria-label={ariaLabel}
>
{children}
</div>
);
}
function MobileSheet({
onClose,
ariaLabel,
children,
}: Readonly<Omit<DetailPopoverProps, "anchorRect">>) {
const { offsetY, isSwiping, handlers } = useSwipeToDismissDown(onClose);
useEffect(() => {
const handler = (e: KeyboardEvent) => {
if (e.key === "Escape") onClose();
};
document.addEventListener("keydown", handler);
return () => document.removeEventListener("keydown", handler);
}, [onClose]);
return (
<div className="fixed inset-0 z-50">
<button
type="button"
className="fade-in absolute inset-0 animate-in bg-black/50"
onClick={onClose}
aria-label="Close details"
/>
<div
className={cn(
"panel-glow absolute right-0 bottom-0 left-0 max-h-[80vh] rounded-t-2xl border-border border-t bg-card",
!isSwiping && "animate-slide-in-bottom",
)}
style={
isSwiping ? { transform: `translateY(${offsetY}px)` } : undefined
}
{...handlers}
role="dialog"
aria-label={ariaLabel}
>
<div className="flex justify-center pt-2 pb-1">
<div className="h-1 w-10 rounded-full bg-muted-foreground/40" />
</div>
<div className="max-h-[calc(80vh-24px)] overflow-y-auto p-4">
{children}
</div>
</div>
</div>
);
}
export function DetailPopover({
anchorRect,
onClose,
ariaLabel,
children,
}: Readonly<DetailPopoverProps>) {
const [isDesktop, setIsDesktop] = useState(
() => globalThis.matchMedia("(min-width: 1024px)").matches,
);
useEffect(() => {
const mq = globalThis.matchMedia("(min-width: 1024px)");
const handler = (e: MediaQueryListEvent) => setIsDesktop(e.matches);
mq.addEventListener("change", handler);
return () => mq.removeEventListener("change", handler);
}, []);
// Portal to document.body to escape any CSS transforms on ancestors
// (the side panel uses translate-x for collapse animation, which would
// otherwise become the containing block for fixed-positioned children).
const content = isDesktop ? (
<DesktopPanel
anchorRect={anchorRect}
onClose={onClose}
ariaLabel={ariaLabel}
>
{children}
</DesktopPanel>
) : (
<MobileSheet onClose={onClose} ariaLabel={ariaLabel}>
{children}
</MobileSheet>
);
return createPortal(content, document.body);
}

View File

@@ -11,9 +11,8 @@ import {
import { CrPicker } from "./cr-picker.js"; import { CrPicker } from "./cr-picker.js";
import { Button } from "./ui/button.js"; import { Button } from "./ui/button.js";
const TIER_LABEL_MAP: Record< const TIER_LABEL_MAP: Partial<
RulesEdition, Record<RulesEdition, Record<DifficultyTier, { label: string; color: string }>>
Record<DifficultyTier, { label: string; color: string }>
> = { > = {
"5.5e": { "5.5e": {
0: { label: "Trivial", color: "text-muted-foreground" }, 0: { label: "Trivial", color: "text-muted-foreground" },
@@ -117,7 +116,9 @@ export function DifficultyBreakdownPanel({ onClose }: { onClose: () => void }) {
const breakdown = useDifficultyBreakdown(); const breakdown = useDifficultyBreakdown();
if (!breakdown) return null; if (!breakdown) return null;
const tierConfig = TIER_LABEL_MAP[edition][breakdown.tier]; const tierLabels = TIER_LABEL_MAP[edition];
if (!tierLabels) return null;
const tierConfig = tierLabels[breakdown.tier];
const handleToggle = (entry: BreakdownCombatant) => { const handleToggle = (entry: BreakdownCombatant) => {
const newSide = entry.side === "party" ? "enemy" : "party"; const newSide = entry.side === "party" ? "enemy" : "party";

View File

@@ -1,10 +1,16 @@
import type { Creature } from "@initiative/domain";
import { import {
type Creature,
calculateInitiative, calculateInitiative,
formatInitiativeModifier, formatInitiativeModifier,
} from "@initiative/domain"; } from "@initiative/domain";
import {
PropertyLine,
SectionDivider,
TraitEntry,
TraitSection,
} from "./stat-block-parts.js";
interface StatBlockProps { interface DndStatBlockProps {
creature: Creature; creature: Creature;
} }
@@ -13,53 +19,7 @@ function abilityMod(score: number): string {
return mod >= 0 ? `+${mod}` : `${mod}`; return mod >= 0 ? `+${mod}` : `${mod}`;
} }
function PropertyLine({ export function DndStatBlock({ creature }: Readonly<DndStatBlockProps>) {
label,
value,
}: Readonly<{
label: string;
value: string | undefined;
}>) {
if (!value) return null;
return (
<div className="text-sm">
<span className="font-semibold">{label}</span> {value}
</div>
);
}
function SectionDivider() {
return (
<div className="my-2 h-px bg-gradient-to-r from-stat-divider-from via-stat-divider-via to-transparent" />
);
}
function TraitSection({
entries,
heading,
}: Readonly<{
entries: readonly { name: string; text: string }[] | undefined;
heading?: string;
}>) {
if (!entries || entries.length === 0) return null;
return (
<>
<SectionDivider />
{heading ? (
<h3 className="font-bold text-base text-stat-heading">{heading}</h3>
) : null}
<div className="space-y-2">
{entries.map((e) => (
<div key={e.name} className="text-sm">
<span className="font-semibold italic">{e.name}.</span> {e.text}
</div>
))}
</div>
</>
);
}
export function StatBlock({ creature }: Readonly<StatBlockProps>) {
const abilities = [ const abilities = [
{ label: "STR", score: creature.abilities.str }, { label: "STR", score: creature.abilities.str },
{ label: "DEX", score: creature.abilities.dex }, { label: "DEX", score: creature.abilities.dex },
@@ -174,7 +134,7 @@ export function StatBlock({ creature }: Readonly<StatBlockProps>) {
{sc.atWill && sc.atWill.length > 0 && ( {sc.atWill && sc.atWill.length > 0 && (
<div className="pl-2"> <div className="pl-2">
<span className="font-semibold">At Will:</span>{" "} <span className="font-semibold">At Will:</span>{" "}
{sc.atWill.join(", ")} {sc.atWill.map((s) => s.name).join(", ")}
</div> </div>
)} )}
{sc.daily?.map((d) => ( {sc.daily?.map((d) => (
@@ -183,7 +143,7 @@ export function StatBlock({ creature }: Readonly<StatBlockProps>) {
{d.uses}/day {d.uses}/day
{d.each ? " each" : ""}: {d.each ? " each" : ""}:
</span>{" "} </span>{" "}
{d.spells.join(", ")} {d.spells.map((s) => s.name).join(", ")}
</div> </div>
))} ))}
{sc.restLong?.map((d) => ( {sc.restLong?.map((d) => (
@@ -195,7 +155,7 @@ export function StatBlock({ creature }: Readonly<StatBlockProps>) {
{d.uses}/long rest {d.uses}/long rest
{d.each ? " each" : ""}: {d.each ? " each" : ""}:
</span>{" "} </span>{" "}
{d.spells.join(", ")} {d.spells.map((s) => s.name).join(", ")}
</div> </div>
))} ))}
</div> </div>
@@ -219,9 +179,7 @@ export function StatBlock({ creature }: Readonly<StatBlockProps>) {
</p> </p>
<div className="space-y-2"> <div className="space-y-2">
{creature.legendaryActions.entries.map((a) => ( {creature.legendaryActions.entries.map((a) => (
<div key={a.name} className="text-sm"> <TraitEntry key={a.name} trait={a} />
<span className="font-semibold italic">{a.name}.</span> {a.text}
</div>
))} ))}
</div> </div>
</> </>

View File

@@ -0,0 +1,72 @@
import type { EquipmentItem } from "@initiative/domain";
import { DetailPopover } from "./detail-popover.js";
import { RichDescription } from "./rich-description.js";
interface EquipmentDetailPopoverProps {
readonly item: EquipmentItem;
readonly anchorRect: DOMRect;
readonly onClose: () => void;
}
function EquipmentDetailContent({ item }: Readonly<{ item: EquipmentItem }>) {
return (
<div className="space-y-2 text-sm">
<h3 className="font-bold text-lg text-stat-heading">{item.name}</h3>
{item.traits && item.traits.length > 0 && (
<div className="flex flex-wrap gap-1">
{item.traits.map((t) => (
<span
key={t}
className="rounded border border-border bg-card px-1.5 py-0.5 text-foreground text-xs"
>
{t}
</span>
))}
</div>
)}
<div className="space-y-0.5 text-xs">
<div>
<span className="font-semibold">Level</span> {item.level}
</div>
{item.category ? (
<div>
<span className="font-semibold">Category</span>{" "}
{item.category.charAt(0).toUpperCase() + item.category.slice(1)}
</div>
) : null}
{item.spellName ? (
<div>
<span className="font-semibold">Spell</span> {item.spellName}
{item.spellRank === undefined ? "" : ` (Rank ${item.spellRank})`}
</div>
) : null}
</div>
{item.description ? (
<RichDescription
text={item.description}
className="whitespace-pre-line text-foreground"
/>
) : (
<p className="text-muted-foreground italic">
No description available.
</p>
)}
</div>
);
}
export function EquipmentDetailPopover({
item,
anchorRect,
onClose,
}: Readonly<EquipmentDetailPopoverProps>) {
return (
<DetailPopover
anchorRect={anchorRect}
onClose={onClose}
ariaLabel={`Equipment details: ${item.name}`}
>
<EquipmentDetailContent item={item} />
</DetailPopover>
);
}

View File

@@ -0,0 +1,391 @@
import type {
CombatantId,
EquipmentItem,
Pf2eCreature,
SpellReference,
} from "@initiative/domain";
import { formatInitiativeModifier, recallKnowledge } from "@initiative/domain";
import { ChevronDown, ChevronUp } from "lucide-react";
import { useCallback, useRef, useState } from "react";
import { cn } from "../lib/utils.js";
import { EquipmentDetailPopover } from "./equipment-detail-popover.js";
import { SpellDetailPopover } from "./spell-detail-popover.js";
import {
PropertyLine,
SectionDivider,
TraitSection,
} from "./stat-block-parts.js";
interface Pf2eStatBlockProps {
creature: Pf2eCreature;
adjustment?: "weak" | "elite";
combatantId?: CombatantId;
baseCreature?: Pf2eCreature;
onSetAdjustment?: (
id: CombatantId,
adj: "weak" | "elite" | undefined,
base: Pf2eCreature,
) => void;
}
const ALIGNMENTS = new Set([
"lg",
"ng",
"cg",
"ln",
"n",
"cn",
"le",
"ne",
"ce",
]);
function capitalize(s: string): string {
return s.charAt(0).toUpperCase() + s.slice(1);
}
function displayTraits(traits: readonly string[]): string[] {
return traits.filter((t) => !ALIGNMENTS.has(t)).map(capitalize);
}
function formatMod(mod: number): string {
return mod >= 0 ? `+${mod}` : `${mod}`;
}
/** Returns the text color class for stats affected by weak/elite adjustment. */
function adjustmentColor(adjustment: "weak" | "elite" | undefined): string {
if (adjustment === "elite") return "text-blue-400";
if (adjustment === "weak") return "text-red-400";
return "";
}
interface SpellLinkProps {
readonly spell: SpellReference;
readonly onOpen: (spell: SpellReference, rect: DOMRect) => void;
}
function UsesPerDay({ count }: Readonly<{ count: number | undefined }>) {
if (count === undefined || count <= 1) return null;
return <span> (×{count})</span>;
}
function SpellLink({ spell, onOpen }: Readonly<SpellLinkProps>) {
const ref = useRef<HTMLButtonElement>(null);
const handleClick = useCallback(() => {
if (!spell.description) return;
const rect = ref.current?.getBoundingClientRect();
if (rect) onOpen(spell, rect);
}, [spell, onOpen]);
if (!spell.description) {
return (
<span>
{spell.name}
<UsesPerDay count={spell.usesPerDay} />
</span>
);
}
return (
<>
<button
ref={ref}
type="button"
onClick={handleClick}
className="cursor-pointer text-foreground underline decoration-dotted underline-offset-2 hover:text-hover-neutral"
>
{spell.name}
</button>
<UsesPerDay count={spell.usesPerDay} />
</>
);
}
interface SpellListLineProps {
readonly label: string;
readonly spells: readonly SpellReference[];
readonly onOpen: (spell: SpellReference, rect: DOMRect) => void;
}
function SpellListLine({
label,
spells,
onOpen,
}: Readonly<SpellListLineProps>) {
return (
<div className="pl-2">
<span className="font-semibold">{label}:</span>{" "}
{spells.map((spell, i) => (
<span key={spell.slug ?? spell.name}>
{i > 0 ? ", " : ""}
<SpellLink spell={spell} onOpen={onOpen} />
</span>
))}
</div>
);
}
interface EquipmentLinkProps {
readonly item: EquipmentItem;
readonly onOpen: (item: EquipmentItem, rect: DOMRect) => void;
}
function EquipmentLink({ item, onOpen }: Readonly<EquipmentLinkProps>) {
const ref = useRef<HTMLButtonElement>(null);
const handleClick = useCallback(() => {
if (!item.description) return;
const rect = ref.current?.getBoundingClientRect();
if (rect) onOpen(item, rect);
}, [item, onOpen]);
if (!item.description) {
return <span>{item.name}</span>;
}
return (
<button
ref={ref}
type="button"
onClick={handleClick}
className="cursor-pointer text-foreground underline decoration-dotted underline-offset-2 hover:text-hover-neutral"
>
{item.name}
</button>
);
}
export function Pf2eStatBlock({
creature,
adjustment,
combatantId,
baseCreature,
onSetAdjustment,
}: Readonly<Pf2eStatBlockProps>) {
const [openSpell, setOpenSpell] = useState<{
spell: SpellReference;
rect: DOMRect;
} | null>(null);
const handleOpenSpell = useCallback(
(spell: SpellReference, rect: DOMRect) => setOpenSpell({ spell, rect }),
[],
);
const handleCloseSpell = useCallback(() => setOpenSpell(null), []);
const [openEquipment, setOpenEquipment] = useState<{
item: EquipmentItem;
rect: DOMRect;
} | null>(null);
const handleOpenEquipment = useCallback(
(item: EquipmentItem, rect: DOMRect) => setOpenEquipment({ item, rect }),
[],
);
const handleCloseEquipment = useCallback(() => setOpenEquipment(null), []);
const rk = recallKnowledge(creature.level, creature.traits);
const adjColor = adjustmentColor(adjustment);
const abilityEntries = [
{ label: "Str", mod: creature.abilityMods.str },
{ label: "Dex", mod: creature.abilityMods.dex },
{ label: "Con", mod: creature.abilityMods.con },
{ label: "Int", mod: creature.abilityMods.int },
{ label: "Wis", mod: creature.abilityMods.wis },
{ label: "Cha", mod: creature.abilityMods.cha },
];
return (
<div className="space-y-1 text-foreground">
{/* Header */}
<div>
<div className="flex items-baseline justify-between gap-2">
<h2 className="flex items-center gap-1.5 font-bold text-stat-heading text-xl">
{adjustment === "elite" && (
<ChevronUp className="h-5 w-5 shrink-0 text-blue-400" />
)}
{adjustment === "weak" && (
<ChevronDown className="h-5 w-5 shrink-0 text-red-400" />
)}
{creature.name}
</h2>
<span className={cn("shrink-0 font-semibold text-sm", adjColor)}>
Level {creature.level}
</span>
</div>
{combatantId != null &&
onSetAdjustment != null &&
baseCreature != null && (
<div className="mt-1 flex gap-1">
{(["weak", "normal", "elite"] as const).map((opt) => {
const value = opt === "normal" ? undefined : opt;
const isActive = adjustment === value;
return (
<button
key={opt}
type="button"
className={cn(
"rounded px-2 py-0.5 font-medium text-xs capitalize",
isActive
? "bg-accent text-primary-foreground"
: "bg-card text-muted-foreground hover:bg-accent/30",
)}
onClick={() =>
onSetAdjustment(combatantId, value, baseCreature)
}
>
{opt}
</button>
);
})}
</div>
)}
<div className="mt-1 flex flex-wrap gap-1">
{displayTraits(creature.traits).map((trait) => (
<span
key={trait}
className="rounded border border-border bg-card px-1.5 py-0.5 text-foreground text-xs"
>
{trait}
</span>
))}
</div>
<p className="mt-1 text-muted-foreground text-xs">
{creature.sourceDisplayName}
</p>
{rk && (
<p className="mt-1 text-sm">
<span className="font-semibold">Recall Knowledge</span> DC {rk.dc}{" "}
&bull; {capitalize(rk.type)} ({rk.skills.join("/")})
</p>
)}
</div>
<SectionDivider />
{/* Perception, Languages, Skills */}
<div className="space-y-0.5 text-sm">
<div className={adjColor}>
<span className="font-semibold">Perception</span>{" "}
{formatInitiativeModifier(creature.perception)}
{creature.senses || creature.perceptionDetails
? `; ${[creature.senses, creature.perceptionDetails].filter(Boolean).join(", ")}`
: ""}
</div>
<PropertyLine label="Languages" value={creature.languages} />
<PropertyLine label="Skills" value={creature.skills} />
</div>
{/* Ability Modifiers */}
<div className="grid grid-cols-6 gap-1 text-center text-sm">
{abilityEntries.map((a) => (
<div key={a.label}>
<div className="font-semibold text-muted-foreground text-xs">
{a.label}
</div>
<div>{formatMod(a.mod)}</div>
</div>
))}
</div>
<PropertyLine label="Items" value={creature.items} />
{/* Top abilities (before defenses) */}
<TraitSection entries={creature.abilitiesTop} />
<SectionDivider />
{/* Defenses */}
<div className="space-y-0.5 text-sm">
<div className={adjColor}>
<span className="font-semibold">AC</span> {creature.ac}
{creature.acConditional ? ` (${creature.acConditional})` : ""};{" "}
<span className="font-semibold">Fort</span>{" "}
{formatMod(creature.saveFort)},{" "}
<span className="font-semibold">Ref</span>{" "}
{formatMod(creature.saveRef)},{" "}
<span className="font-semibold">Will</span>{" "}
{formatMod(creature.saveWill)}
{creature.saveConditional ? `; ${creature.saveConditional}` : ""}
</div>
<div className={adjColor}>
<span className="font-semibold">HP</span> {creature.hp}
{creature.hpDetails ? ` (${creature.hpDetails})` : ""}
</div>
<PropertyLine label="Immunities" value={creature.immunities} />
<PropertyLine label="Resistances" value={creature.resistances} />
<PropertyLine label="Weaknesses" value={creature.weaknesses} />
</div>
{/* Mid abilities (reactions, auras) */}
<TraitSection entries={creature.abilitiesMid} />
<SectionDivider />
{/* Speed */}
<div className="text-sm">
<span className="font-semibold">Speed</span> {creature.speed}
</div>
{/* Attacks */}
<TraitSection entries={creature.attacks} />
{/* Bottom abilities (active abilities) */}
<TraitSection entries={creature.abilitiesBot} />
{/* Spellcasting */}
{creature.spellcasting && creature.spellcasting.length > 0 && (
<>
<SectionDivider />
{creature.spellcasting.map((sc) => (
<div key={sc.name} className="space-y-1 text-sm">
<div>
<span className="font-semibold italic">{sc.name}.</span>{" "}
{sc.headerText}
</div>
{sc.daily?.map((d) => (
<SpellListLine
key={d.uses}
label={d.uses === 0 ? "Cantrips" : `Rank ${d.uses}`}
spells={d.spells}
onOpen={handleOpenSpell}
/>
))}
{sc.atWill && sc.atWill.length > 0 && (
<SpellListLine
label="Cantrips"
spells={sc.atWill}
onOpen={handleOpenSpell}
/>
)}
</div>
))}
</>
)}
{creature.equipment && creature.equipment.length > 0 && (
<>
<SectionDivider />
<h3 className="font-bold text-base text-stat-heading">Equipment</h3>
<div className="space-y-1 text-sm">
{creature.equipment.map((item) => (
<div key={item.name}>
<EquipmentLink item={item} onOpen={handleOpenEquipment} />
</div>
))}
</div>
</>
)}
{openSpell ? (
<SpellDetailPopover
spell={openSpell.spell}
anchorRect={openSpell.rect}
onClose={handleCloseSpell}
/>
) : null}
{openEquipment ? (
<EquipmentDetailPopover
item={openEquipment.item}
anchorRect={openEquipment.rect}
onClose={handleCloseEquipment}
/>
) : null}
</div>
);
}

View File

@@ -0,0 +1,20 @@
import { cn } from "../lib/utils.js";
/**
* Renders text containing safe HTML formatting tags (strong, em, ul, ol, li)
* preserved by the stripFoundryTags pipeline. All other HTML is already
* stripped before reaching this component.
*/
export function RichDescription({
text,
className,
}: Readonly<{ text: string; className?: string }>) {
const props = {
className: cn(
"[&_ol]:list-decimal [&_ol]:pl-4 [&_ul]:list-disc [&_ul]:pl-4",
className,
),
dangerouslySetInnerHTML: { __html: text },
};
return <div {...props} />;
}

View File

@@ -13,6 +13,7 @@ interface SettingsModalProps {
const EDITION_OPTIONS: { value: RulesEdition; label: string }[] = [ const EDITION_OPTIONS: { value: RulesEdition; label: string }[] = [
{ value: "5e", label: "5e (2014)" }, { value: "5e", label: "5e (2014)" },
{ value: "5.5e", label: "5.5e (2024)" }, { value: "5.5e", label: "5.5e (2024)" },
{ value: "pf2e", label: "Pathfinder 2e" },
]; ];
const THEME_OPTIONS: { const THEME_OPTIONS: {
@@ -36,7 +37,7 @@ export function SettingsModal({ open, onClose }: Readonly<SettingsModalProps>) {
<div className="flex flex-col gap-5"> <div className="flex flex-col gap-5">
<div> <div>
<span className="mb-2 block font-medium text-muted-foreground text-sm"> <span className="mb-2 block font-medium text-muted-foreground text-sm">
Rules Edition Game System
</span> </span>
<div className="flex gap-1"> <div className="flex gap-1">
{EDITION_OPTIONS.map((opt) => ( {EDITION_OPTIONS.map((opt) => (

View File

@@ -2,23 +2,26 @@ import { Download, Loader2, Upload } from "lucide-react";
import { useId, useRef, useState } from "react"; import { useId, useRef, useState } from "react";
import { useAdapters } from "../contexts/adapter-context.js"; import { useAdapters } from "../contexts/adapter-context.js";
import { useBestiaryContext } from "../contexts/bestiary-context.js"; import { useBestiaryContext } from "../contexts/bestiary-context.js";
import { useRulesEditionContext } from "../contexts/rules-edition-context.js";
import { Button } from "./ui/button.js"; import { Button } from "./ui/button.js";
import { Input } from "./ui/input.js"; import { Input } from "./ui/input.js";
interface SourceFetchPromptProps { interface SourceFetchPromptProps {
sourceCode: string; sourceCode: string;
onSourceLoaded: () => void; onSourceLoaded: (skippedNames: string[]) => void;
} }
export function SourceFetchPrompt({ export function SourceFetchPrompt({
sourceCode, sourceCode,
onSourceLoaded, onSourceLoaded,
}: Readonly<SourceFetchPromptProps>) { }: Readonly<SourceFetchPromptProps>) {
const { bestiaryIndex } = useAdapters(); const { bestiaryIndex, pf2eBestiaryIndex } = useAdapters();
const { fetchAndCacheSource, uploadAndCacheSource } = useBestiaryContext(); const { fetchAndCacheSource, uploadAndCacheSource } = useBestiaryContext();
const sourceDisplayName = bestiaryIndex.getSourceDisplayName(sourceCode); const { edition } = useRulesEditionContext();
const indexPort = edition === "pf2e" ? pf2eBestiaryIndex : bestiaryIndex;
const sourceDisplayName = indexPort.getSourceDisplayName(sourceCode);
const [url, setUrl] = useState(() => const [url, setUrl] = useState(() =>
bestiaryIndex.getDefaultFetchUrl(sourceCode), indexPort.getDefaultFetchUrl(sourceCode),
); );
const [status, setStatus] = useState<"idle" | "fetching" | "error">("idle"); const [status, setStatus] = useState<"idle" | "fetching" | "error">("idle");
const [error, setError] = useState<string>(""); const [error, setError] = useState<string>("");
@@ -29,8 +32,9 @@ export function SourceFetchPrompt({
setStatus("fetching"); setStatus("fetching");
setError(""); setError("");
try { try {
await fetchAndCacheSource(sourceCode, url); const { skippedNames } = await fetchAndCacheSource(sourceCode, url);
onSourceLoaded(); setStatus("idle");
onSourceLoaded(skippedNames);
} catch (e) { } catch (e) {
setStatus("error"); setStatus("error");
setError(e instanceof Error ? e.message : "Failed to fetch source data"); setError(e instanceof Error ? e.message : "Failed to fetch source data");
@@ -48,7 +52,7 @@ export function SourceFetchPrompt({
const text = await file.text(); const text = await file.text();
const json = JSON.parse(text); const json = JSON.parse(text);
await uploadAndCacheSource(sourceCode, json); await uploadAndCacheSource(sourceCode, json);
onSourceLoaded(); onSourceLoaded([]);
} catch (err) { } catch (err) {
setStatus("error"); setStatus("error");
setError( setError(

View File

@@ -9,12 +9,15 @@ import {
import type { CachedSourceInfo } from "../adapters/ports.js"; import type { CachedSourceInfo } from "../adapters/ports.js";
import { useAdapters } from "../contexts/adapter-context.js"; import { useAdapters } from "../contexts/adapter-context.js";
import { useBestiaryContext } from "../contexts/bestiary-context.js"; import { useBestiaryContext } from "../contexts/bestiary-context.js";
import { useRulesEditionContext } from "../contexts/rules-edition-context.js";
import { Button } from "./ui/button.js"; import { Button } from "./ui/button.js";
import { Input } from "./ui/input.js"; import { Input } from "./ui/input.js";
export function SourceManager() { export function SourceManager() {
const { bestiaryCache } = useAdapters(); const { bestiaryCache } = useAdapters();
const { refreshCache } = useBestiaryContext(); const { refreshCache } = useBestiaryContext();
const { edition } = useRulesEditionContext();
const system = edition === "pf2e" ? "pf2e" : "dnd";
const [sources, setSources] = useState<CachedSourceInfo[]>([]); const [sources, setSources] = useState<CachedSourceInfo[]>([]);
const [filter, setFilter] = useState(""); const [filter, setFilter] = useState("");
const [optimisticSources, applyOptimistic] = useOptimistic( const [optimisticSources, applyOptimistic] = useOptimistic(
@@ -29,9 +32,9 @@ export function SourceManager() {
); );
const loadSources = useCallback(async () => { const loadSources = useCallback(async () => {
const cached = await bestiaryCache.getCachedSources(); const cached = await bestiaryCache.getCachedSources(system);
setSources(cached); setSources(cached);
}, [bestiaryCache]); }, [bestiaryCache, system]);
useEffect(() => { useEffect(() => {
void loadSources(); void loadSources();
@@ -39,7 +42,7 @@ export function SourceManager() {
const handleClearSource = async (sourceCode: string) => { const handleClearSource = async (sourceCode: string) => {
applyOptimistic({ type: "remove", sourceCode }); applyOptimistic({ type: "remove", sourceCode });
await bestiaryCache.clearSource(sourceCode); await bestiaryCache.clearSource(system, sourceCode);
await loadSources(); await loadSources();
void refreshCache(); void refreshCache();
}; };

View File

@@ -0,0 +1,178 @@
import type { ActivityCost, SpellReference } from "@initiative/domain";
import { DetailPopover } from "./detail-popover.js";
import { RichDescription } from "./rich-description.js";
import { ActivityIcon } from "./stat-block-parts.js";
interface SpellDetailPopoverProps {
readonly spell: SpellReference;
readonly anchorRect: DOMRect;
readonly onClose: () => void;
}
const RANK_LABELS = [
"Cantrip",
"1st",
"2nd",
"3rd",
"4th",
"5th",
"6th",
"7th",
"8th",
"9th",
"10th",
];
function formatRank(rank: number | undefined): string {
if (rank === undefined) return "";
return RANK_LABELS[rank] ?? `Rank ${rank}`;
}
function parseActionCost(cost: string): ActivityCost | null {
if (cost === "free") return { number: 1, unit: "free" };
if (cost === "reaction") return { number: 1, unit: "reaction" };
const n = Number(cost);
if (n >= 1 && n <= 3) return { number: n, unit: "action" };
return null;
}
function SpellActionCost({ cost }: Readonly<{ cost: string | undefined }>) {
if (!cost) return null;
const activity = parseActionCost(cost);
if (activity) {
return (
<span className="shrink-0 text-lg">
<ActivityIcon activity={activity} />
</span>
);
}
return <span className="shrink-0 text-muted-foreground text-xs">{cost}</span>;
}
function SpellHeader({ spell }: Readonly<{ spell: SpellReference }>) {
return (
<div className="flex items-center justify-between gap-2">
<h3 className="font-bold text-lg text-stat-heading">{spell.name}</h3>
<SpellActionCost cost={spell.actionCost} />
</div>
);
}
function SpellTraits({ traits }: Readonly<{ traits: readonly string[] }>) {
if (traits.length === 0) return null;
return (
<div className="flex flex-wrap gap-1">
{traits.map((t) => (
<span
key={t}
className="rounded border border-border bg-card px-1.5 py-0.5 text-foreground text-xs"
>
{t}
</span>
))}
</div>
);
}
function LabeledValue({
label,
value,
}: Readonly<{ label: string; value: string }>) {
return (
<>
<span className="font-semibold">{label}</span> {value}
</>
);
}
function SpellRangeLine({ spell }: Readonly<{ spell: SpellReference }>) {
const items: { label: string; value: string }[] = [];
if (spell.range) items.push({ label: "Range", value: spell.range });
if (spell.target) items.push({ label: "Target", value: spell.target });
if (spell.area) items.push({ label: "Area", value: spell.area });
if (items.length === 0) return null;
return (
<div>
{items.map((item, i) => (
<span key={item.label}>
{i > 0 ? "; " : ""}
<LabeledValue label={item.label} value={item.value} />
</span>
))}
</div>
);
}
function SpellMeta({ spell }: Readonly<{ spell: SpellReference }>) {
const hasTraditions =
spell.traditions !== undefined && spell.traditions.length > 0;
return (
<div className="space-y-0.5 text-xs">
{spell.rank === undefined ? null : (
<div>
<span className="font-semibold">{formatRank(spell.rank)}</span>
{hasTraditions ? (
<span className="text-muted-foreground">
{" "}
({spell.traditions?.join(", ")})
</span>
) : null}
</div>
)}
<SpellRangeLine spell={spell} />
{spell.duration ? (
<div>
<LabeledValue label="Duration" value={spell.duration} />
</div>
) : null}
{spell.defense ? (
<div>
<LabeledValue label="Defense" value={spell.defense} />
</div>
) : null}
</div>
);
}
function SpellDetailContent({ spell }: Readonly<{ spell: SpellReference }>) {
return (
<div className="space-y-2 text-sm">
<SpellHeader spell={spell} />
<SpellTraits traits={spell.traits ?? []} />
<SpellMeta spell={spell} />
{spell.description ? (
<RichDescription
text={spell.description}
className="whitespace-pre-line text-foreground"
/>
) : (
<p className="text-muted-foreground italic">
No description available.
</p>
)}
{spell.heightening ? (
<RichDescription
text={spell.heightening}
className="whitespace-pre-line text-foreground text-xs"
/>
) : null}
</div>
);
}
export function SpellDetailPopover({
spell,
anchorRect,
onClose,
}: Readonly<SpellDetailPopoverProps>) {
return (
<DetailPopover
anchorRect={anchorRect}
onClose={onClose}
ariaLabel={`Spell details: ${spell.name}`}
>
<SpellDetailContent spell={spell} />
</DetailPopover>
);
}

View File

@@ -1,15 +1,26 @@
import type { CreatureId } from "@initiative/domain"; import type {
AnyCreature,
Combatant,
CombatantId,
Creature,
CreatureId,
Pf2eCreature,
} from "@initiative/domain";
import { applyPf2eAdjustment } from "@initiative/domain";
import { PanelRightClose, Pin, PinOff } from "lucide-react"; import { PanelRightClose, Pin, PinOff } from "lucide-react";
import type { ReactNode } from "react"; import type { ReactNode } from "react";
import { useEffect, useState } from "react"; import { useEffect, useState } from "react";
import { useBestiaryContext } from "../contexts/bestiary-context.js"; import { useBestiaryContext } from "../contexts/bestiary-context.js";
import { useEncounterContext } from "../contexts/encounter-context.js";
import { useSidePanelContext } from "../contexts/side-panel-context.js"; import { useSidePanelContext } from "../contexts/side-panel-context.js";
import { useSwipeToDismiss } from "../hooks/use-swipe-to-dismiss.js"; import { useSwipeToDismiss } from "../hooks/use-swipe-to-dismiss.js";
import { cn } from "../lib/utils.js"; import { cn } from "../lib/utils.js";
import { BulkImportPrompt } from "./bulk-import-prompt.js"; import { BulkImportPrompt } from "./bulk-import-prompt.js";
import { DndStatBlock } from "./dnd-stat-block.js";
import { Pf2eStatBlock } from "./pf2e-stat-block.js";
import { SourceFetchPrompt } from "./source-fetch-prompt.js"; import { SourceFetchPrompt } from "./source-fetch-prompt.js";
import { SourceManager } from "./source-manager.js"; import { SourceManager } from "./source-manager.js";
import { StatBlock } from "./stat-block.js"; import { Toast } from "./toast.js";
import { Button } from "./ui/button.js"; import { Button } from "./ui/button.js";
interface StatBlockPanelProps { interface StatBlockPanelProps {
@@ -20,7 +31,10 @@ interface StatBlockPanelProps {
function extractSourceCode(cId: CreatureId): string { function extractSourceCode(cId: CreatureId): string {
const colonIndex = cId.indexOf(":"); const colonIndex = cId.indexOf(":");
if (colonIndex === -1) return ""; if (colonIndex === -1) return "";
return cId.slice(0, colonIndex).toUpperCase(); const prefix = cId.slice(0, colonIndex);
// D&D source codes are short uppercase (e.g. "mm" from "MM").
// PF2e source codes use hyphens (e.g. "pathfinder-monster-core").
return prefix.includes("-") ? prefix : prefix.toUpperCase();
} }
function CollapsedTab({ function CollapsedTab({
@@ -211,6 +225,7 @@ function MobileDrawer({
function usePanelRole(panelRole: "browse" | "pinned") { function usePanelRole(panelRole: "browse" | "pinned") {
const sidePanel = useSidePanelContext(); const sidePanel = useSidePanelContext();
const { getCreature } = useBestiaryContext(); const { getCreature } = useBestiaryContext();
const { encounter, setCreatureAdjustment } = useEncounterContext();
const creatureId = const creatureId =
panelRole === "browse" panelRole === "browse"
@@ -218,10 +233,18 @@ function usePanelRole(panelRole: "browse" | "pinned") {
: sidePanel.pinnedCreatureId; : sidePanel.pinnedCreatureId;
const creature = creatureId ? (getCreature(creatureId) ?? null) : null; const creature = creatureId ? (getCreature(creatureId) ?? null) : null;
const combatantId =
panelRole === "browse" ? sidePanel.selectedCombatantId : null;
const combatant = combatantId
? (encounter.combatants.find((c) => c.id === combatantId) ?? null)
: null;
const isBrowse = panelRole === "browse"; const isBrowse = panelRole === "browse";
return { return {
creatureId, creatureId,
creature, creature,
combatant,
setCreatureAdjustment,
isCollapsed: isBrowse ? sidePanel.isRightPanelCollapsed : false, isCollapsed: isBrowse ? sidePanel.isRightPanelCollapsed : false,
onToggleCollapse: isBrowse ? sidePanel.toggleCollapse : () => {}, onToggleCollapse: isBrowse ? sidePanel.toggleCollapse : () => {},
onDismiss: isBrowse ? sidePanel.dismissPanel : () => {}, onDismiss: isBrowse ? sidePanel.dismissPanel : () => {},
@@ -233,14 +256,42 @@ function usePanelRole(panelRole: "browse" | "pinned") {
}; };
} }
function renderStatBlock(
creature: AnyCreature,
combatant: Combatant | null,
setCreatureAdjustment: (
id: CombatantId,
adj: "weak" | "elite" | undefined,
base: Pf2eCreature,
) => void,
) {
if ("system" in creature && creature.system === "pf2e") {
const baseCreature = creature;
const adjusted = combatant?.creatureAdjustment
? applyPf2eAdjustment(baseCreature, combatant.creatureAdjustment)
: baseCreature;
return (
<Pf2eStatBlock
creature={adjusted}
adjustment={combatant?.creatureAdjustment}
combatantId={combatant?.id}
baseCreature={baseCreature}
onSetAdjustment={setCreatureAdjustment}
/>
);
}
return <DndStatBlock creature={creature as Creature} />;
}
export function StatBlockPanel({ export function StatBlockPanel({
panelRole, panelRole,
side, side,
}: Readonly<StatBlockPanelProps>) { }: Readonly<StatBlockPanelProps>) {
const { isSourceCached } = useBestiaryContext();
const { const {
creatureId, creatureId,
creature, creature,
combatant,
setCreatureAdjustment,
isCollapsed, isCollapsed,
onToggleCollapse, onToggleCollapse,
onDismiss, onDismiss,
@@ -256,6 +307,7 @@ export function StatBlockPanel({
); );
const [needsFetch, setNeedsFetch] = useState(false); const [needsFetch, setNeedsFetch] = useState(false);
const [checkingCache, setCheckingCache] = useState(false); const [checkingCache, setCheckingCache] = useState(false);
const [skippedToast, setSkippedToast] = useState<string | null>(null);
useEffect(() => { useEffect(() => {
const mq = globalThis.matchMedia("(min-width: 1024px)"); const mq = globalThis.matchMedia("(min-width: 1024px)");
@@ -276,19 +328,23 @@ export function StatBlockPanel({
return; return;
} }
setCheckingCache(true); // Show fetch prompt both when source is uncached AND when the source is
void isSourceCached(sourceCode).then((cached) => { // cached but this specific creature is missing (e.g. skipped by ad blocker).
setNeedsFetch(!cached); setNeedsFetch(true);
setCheckingCache(false); setCheckingCache(false);
}); }, [creatureId, creature]);
}, [creatureId, creature, isSourceCached]);
if (!creatureId && !bulkImportMode && !sourceManagerMode) return null; if (!creatureId && !bulkImportMode && !sourceManagerMode) return null;
const sourceCode = creatureId ? extractSourceCode(creatureId) : ""; const sourceCode = creatureId ? extractSourceCode(creatureId) : "";
const handleSourceLoaded = () => { const handleSourceLoaded = (skippedNames: string[]) => {
setNeedsFetch(false); if (skippedNames.length > 0) {
const names = skippedNames.join(", ");
setSkippedToast(
`${skippedNames.length} creature(s) skipped (ad blocker?): ${names}`,
);
}
}; };
const renderContent = () => { const renderContent = () => {
@@ -307,7 +363,7 @@ export function StatBlockPanel({
} }
if (creature) { if (creature) {
return <StatBlock creature={creature} />; return renderStatBlock(creature, combatant, setCreatureAdjustment);
} }
if (needsFetch && sourceCode) { if (needsFetch && sourceCode) {
@@ -331,8 +387,13 @@ export function StatBlockPanel({
else if (bulkImportMode) fallbackName = "Import All Sources"; else if (bulkImportMode) fallbackName = "Import All Sources";
const creatureName = creature?.name ?? fallbackName; const creatureName = creature?.name ?? fallbackName;
const toast = skippedToast ? (
<Toast message={skippedToast} onDismiss={() => setSkippedToast(null)} />
) : null;
if (isDesktop) { if (isDesktop) {
return ( return (
<>
<DesktopPanel <DesktopPanel
isCollapsed={isCollapsed} isCollapsed={isCollapsed}
side={side} side={side}
@@ -345,10 +406,17 @@ export function StatBlockPanel({
> >
{renderContent()} {renderContent()}
</DesktopPanel> </DesktopPanel>
{toast}
</>
); );
} }
if (panelRole === "pinned" || isCollapsed) return null; if (panelRole === "pinned" || isCollapsed) return null;
return <MobileDrawer onDismiss={onDismiss}>{renderContent()}</MobileDrawer>; return (
<>
<MobileDrawer onDismiss={onDismiss}>{renderContent()}</MobileDrawer>
{toast}
</>
);
} }

View File

@@ -0,0 +1,183 @@
import type {
ActivityCost,
TraitBlock,
TraitSegment,
} from "@initiative/domain";
import { RichDescription } from "./rich-description.js";
export function PropertyLine({
label,
value,
}: Readonly<{
label: string;
value: string | undefined;
}>) {
if (!value) return null;
return (
<div className="text-sm">
<span className="font-semibold">{label}</span> {value}
</div>
);
}
export function SectionDivider() {
return (
<div className="my-2 h-px bg-gradient-to-r from-stat-divider-from via-stat-divider-via to-transparent" />
);
}
function segmentKey(seg: TraitSegment): string {
return seg.type === "text"
? seg.value.slice(0, 40)
: seg.items.map((i) => i.label ?? i.text.slice(0, 20)).join(",");
}
function TraitSegments({
segments,
}: Readonly<{ segments: readonly TraitSegment[] }>) {
return (
<>
{segments.map((seg, i) => {
if (seg.type === "text") {
return (
<RichDescription
key={segmentKey(seg)}
text={i === 0 ? ` ${seg.value}` : seg.value}
className="inline whitespace-pre-line"
/>
);
}
return (
<div key={segmentKey(seg)} className="mt-1 space-y-0.5">
{seg.items.map((item) => (
<div key={item.label ?? item.text}>
{item.label != null && (
<span className="font-semibold">{item.label}. </span>
)}
<RichDescription text={item.text} className="inline" />
</div>
))}
</div>
);
})}
</>
);
}
const ACTION_DIAMOND = "M50 2 L96 50 L50 98 L4 50 Z M48 27 L71 50 L48 73 Z";
const ACTION_DIAMOND_SOLID = "M50 2 L96 50 L50 98 L4 50 Z";
const ACTION_DIAMOND_OUTLINE =
"M90 2 L136 50 L90 98 L44 50 Z M90 29 L111 50 L90 71 L69 50 Z";
const FREE_ACTION_DIAMOND =
"M50 2 L96 50 L50 98 L4 50 Z M50 12 L12 50 L50 88 L88 50 Z";
const FREE_ACTION_CHEVRON = "M48 27 L71 50 L48 73 Z";
const REACTION_ARROW =
"M75 15 A42 42 0 1 0 85 55 L72 55 A30 30 0 1 1 65 25 L65 40 L92 20 L65 0 L65 15 Z";
export function ActivityIcon({
activity,
}: Readonly<{ activity: ActivityCost }>) {
const cls = "inline-block h-[1em] align-[-0.1em]";
if (activity.unit === "free") {
return (
<svg aria-hidden="true" className={cls} viewBox="0 0 100 100">
<path d={FREE_ACTION_DIAMOND} fill="currentColor" fillRule="evenodd" />
<path d={FREE_ACTION_CHEVRON} fill="currentColor" />
</svg>
);
}
if (activity.unit === "reaction") {
return (
<svg aria-hidden="true" className={cls} viewBox="0 0 100 100">
<g transform="translate(100,100) rotate(180)">
<path d={REACTION_ARROW} fill="currentColor" />
</g>
</svg>
);
}
const count = activity.number;
if (count === 1) {
return (
<svg aria-hidden="true" className={cls} viewBox="0 0 100 100">
<path d={ACTION_DIAMOND} fill="currentColor" fillRule="evenodd" />
</svg>
);
}
if (count === 2) {
return (
<svg aria-hidden="true" className={cls} viewBox="0 0 140 100">
<path d={ACTION_DIAMOND_SOLID} fill="currentColor" />
<path
d={ACTION_DIAMOND_OUTLINE}
fill="currentColor"
fillRule="evenodd"
/>
</svg>
);
}
return (
<svg aria-hidden="true" className={cls} viewBox="0 0 180 100">
<path d={ACTION_DIAMOND_SOLID} fill="currentColor" />
<path d="M90 2 L136 50 L90 98 L44 50 Z" fill="currentColor" />
<path
d="M130 2 L176 50 L130 98 L84 50 Z M130 29 L151 50 L130 71 L109 50 Z"
fill="currentColor"
fillRule="evenodd"
/>
</svg>
);
}
export function TraitEntry({ trait }: Readonly<{ trait: TraitBlock }>) {
return (
<div className="text-sm">
<span className="font-semibold italic">
{trait.name}
{trait.activity ? null : "."}
{trait.activity ? (
<>
{" "}
<ActivityIcon activity={trait.activity} />
</>
) : null}
</span>
{trait.frequency ? ` (${trait.frequency})` : null}
{trait.trigger ? (
<>
{" "}
<span className="font-semibold">Trigger</span> {trait.trigger}
{trait.segments.length > 0 ? (
<>
{" "}
<span className="font-semibold">Effect</span>
</>
) : null}
</>
) : null}
<TraitSegments segments={trait.segments} />
</div>
);
}
export function TraitSection({
entries,
heading,
}: Readonly<{
entries: readonly TraitBlock[] | undefined;
heading?: string;
}>) {
if (!entries || entries.length === 0) return null;
return (
<>
<SectionDivider />
{heading ? (
<h3 className="font-bold text-base text-stat-heading">{heading}</h3>
) : null}
<div className="space-y-2">
{entries.map((e) => (
<TraitEntry key={e.name} trait={e} />
))}
</div>
</>
);
}

View File

@@ -3,6 +3,7 @@ import type {
BestiaryCachePort, BestiaryCachePort,
BestiaryIndexPort, BestiaryIndexPort,
EncounterPersistence, EncounterPersistence,
Pf2eBestiaryIndexPort,
PlayerCharacterPersistence, PlayerCharacterPersistence,
UndoRedoPersistence, UndoRedoPersistence,
} from "../adapters/ports.js"; } from "../adapters/ports.js";
@@ -13,6 +14,7 @@ export interface Adapters {
playerCharacterPersistence: PlayerCharacterPersistence; playerCharacterPersistence: PlayerCharacterPersistence;
bestiaryCache: BestiaryCachePort; bestiaryCache: BestiaryCachePort;
bestiaryIndex: BestiaryIndexPort; bestiaryIndex: BestiaryIndexPort;
pf2eBestiaryIndex: Pf2eBestiaryIndexPort;
} }
const AdapterContext = createContext<Adapters | null>(null); const AdapterContext = createContext<Adapters | null>(null);

View File

@@ -1,8 +1,4 @@
import type { import type { ConditionId, PlayerCharacter } from "@initiative/domain";
BestiaryIndexEntry,
ConditionId,
PlayerCharacter,
} from "@initiative/domain";
import { import {
combatantId, combatantId,
createEncounter, createEncounter,
@@ -11,6 +7,7 @@ import {
playerCharacterId, playerCharacterId,
} from "@initiative/domain"; } from "@initiative/domain";
import { describe, expect, it } from "vitest"; import { describe, expect, it } from "vitest";
import type { SearchResult } from "../use-bestiary.js";
import { type EncounterState, encounterReducer } from "../use-encounter.js"; import { type EncounterState, encounterReducer } from "../use-encounter.js";
function emptyState(): EncounterState { function emptyState(): EncounterState {
@@ -45,9 +42,11 @@ function stateWithHp(name: string, maxHp: number): EncounterState {
}); });
} }
const BESTIARY_ENTRY: BestiaryIndexEntry = { const BESTIARY_ENTRY: SearchResult = {
system: "dnd",
name: "Goblin", name: "Goblin",
source: "MM", source: "MM",
sourceDisplayName: "Monster Manual",
ac: 15, ac: 15,
hp: 7, hp: 7,
dex: 14, dex: 14,
@@ -57,6 +56,19 @@ const BESTIARY_ENTRY: BestiaryIndexEntry = {
type: "humanoid", type: "humanoid",
}; };
const PF2E_BESTIARY_ENTRY: SearchResult = {
system: "pf2e",
name: "Goblin Warrior",
source: "B1",
sourceDisplayName: "Bestiary",
level: -1,
ac: 16,
hp: 6,
perception: 5,
size: "small",
type: "humanoid",
};
describe("encounterReducer", () => { describe("encounterReducer", () => {
describe("add-combatant", () => { describe("add-combatant", () => {
it("adds a combatant and pushes undo", () => { it("adds a combatant and pushes undo", () => {
@@ -236,7 +248,9 @@ describe("encounterReducer", () => {
conditionId: "blinded" as ConditionId, conditionId: "blinded" as ConditionId,
}); });
expect(next.encounter.combatants[0].conditions).toContain("blinded"); expect(next.encounter.combatants[0].conditions).toContainEqual({
id: "blinded",
});
}); });
it("toggles concentration", () => { it("toggles concentration", () => {
@@ -327,6 +341,19 @@ describe("encounterReducer", () => {
expect(names).toContain("Goblin 1"); expect(names).toContain("Goblin 1");
expect(names).toContain("Goblin 2"); expect(names).toContain("Goblin 2");
}); });
it("adds PF2e creature with HP, AC, and creatureId", () => {
const next = encounterReducer(emptyState(), {
type: "add-from-bestiary",
entry: PF2E_BESTIARY_ENTRY,
});
const c = next.encounter.combatants[0];
expect(c.name).toBe("Goblin Warrior");
expect(c.maxHp).toBe(6);
expect(c.ac).toBe(16);
expect(c.creatureId).toBe("b1:goblin-warrior");
});
}); });
describe("add-multiple-from-bestiary", () => { describe("add-multiple-from-bestiary", () => {

View File

@@ -0,0 +1,238 @@
import type { Pf2eCreature } from "@initiative/domain";
import {
combatantId,
creatureId,
EMPTY_UNDO_REDO_STATE,
} from "@initiative/domain";
import { describe, expect, it } from "vitest";
import { type EncounterState, encounterReducer } from "../use-encounter.js";
const BASE_CREATURE: Pf2eCreature = {
system: "pf2e",
id: creatureId("b1:goblin-warrior"),
name: "Goblin Warrior",
source: "B1",
sourceDisplayName: "Bestiary",
level: 5,
traits: ["humanoid"],
perception: 12,
abilityMods: { str: 4, dex: 2, con: 3, int: 0, wis: 1, cha: -1 },
ac: 22,
saveFort: 14,
saveRef: 11,
saveWill: 9,
hp: 75,
speed: "25 feet",
};
function stateWithCreature(
name: string,
hp: number,
ac: number,
adj?: "weak" | "elite",
): EncounterState {
return {
encounter: {
combatants: [
{
id: combatantId("c-1"),
name,
maxHp: hp,
currentHp: hp,
ac,
creatureId: creatureId("b1:goblin-warrior"),
...(adj !== undefined && { creatureAdjustment: adj }),
},
],
activeIndex: 0,
roundNumber: 1,
},
undoRedoState: EMPTY_UNDO_REDO_STATE,
events: [],
nextId: 1,
lastCreatureId: null,
};
}
describe("set-creature-adjustment", () => {
it("Normal → Elite: HP increases, AC +2, name prefixed, adjustment stored", () => {
const state = stateWithCreature("Goblin Warrior", 75, 22);
const next = encounterReducer(state, {
type: "set-creature-adjustment",
id: combatantId("c-1"),
adjustment: "elite",
baseCreature: BASE_CREATURE,
});
const c = next.encounter.combatants[0];
expect(c.maxHp).toBe(95); // 75 + 20 (level 5 bracket)
expect(c.currentHp).toBe(95);
expect(c.ac).toBe(24);
expect(c.name).toBe("Elite Goblin Warrior");
expect(c.creatureAdjustment).toBe("elite");
});
it("Normal → Weak: HP decreases, AC 2, name prefixed", () => {
const state = stateWithCreature("Goblin Warrior", 75, 22);
const next = encounterReducer(state, {
type: "set-creature-adjustment",
id: combatantId("c-1"),
adjustment: "weak",
baseCreature: BASE_CREATURE,
});
const c = next.encounter.combatants[0];
expect(c.maxHp).toBe(55); // 75 - 20
expect(c.currentHp).toBe(55);
expect(c.ac).toBe(20);
expect(c.name).toBe("Weak Goblin Warrior");
expect(c.creatureAdjustment).toBe("weak");
});
it("Elite → Normal: HP/AC/name revert", () => {
const state = stateWithCreature("Elite Goblin Warrior", 95, 24, "elite");
const next = encounterReducer(state, {
type: "set-creature-adjustment",
id: combatantId("c-1"),
adjustment: undefined,
baseCreature: BASE_CREATURE,
});
const c = next.encounter.combatants[0];
expect(c.maxHp).toBe(75);
expect(c.currentHp).toBe(75);
expect(c.ac).toBe(22);
expect(c.name).toBe("Goblin Warrior");
expect(c.creatureAdjustment).toBeUndefined();
});
it("Elite → Weak: full swing applied in one step", () => {
const state = stateWithCreature("Elite Goblin Warrior", 95, 24, "elite");
const next = encounterReducer(state, {
type: "set-creature-adjustment",
id: combatantId("c-1"),
adjustment: "weak",
baseCreature: BASE_CREATURE,
});
const c = next.encounter.combatants[0];
expect(c.maxHp).toBe(55); // 95 - 40 (revert +20, apply -20)
expect(c.currentHp).toBe(55);
expect(c.ac).toBe(20); // 24 - 4
expect(c.name).toBe("Weak Goblin Warrior");
expect(c.creatureAdjustment).toBe("weak");
});
it("toggle with damage taken: currentHp shifted by delta, clamped to 0", () => {
const state: EncounterState = {
...stateWithCreature("Goblin Warrior", 75, 22),
};
// Simulate damage: currentHp = 10
const damaged: EncounterState = {
...state,
encounter: {
...state.encounter,
combatants: [{ ...state.encounter.combatants[0], currentHp: 10 }],
},
};
const next = encounterReducer(damaged, {
type: "set-creature-adjustment",
id: combatantId("c-1"),
adjustment: "weak",
baseCreature: BASE_CREATURE,
});
const c = next.encounter.combatants[0];
expect(c.maxHp).toBe(55);
// currentHp = 10 - 20 = -10, clamped to 0
expect(c.currentHp).toBe(0);
});
it("toggle with temp HP: temp HP unchanged", () => {
const state = stateWithCreature("Goblin Warrior", 75, 22);
const withTemp: EncounterState = {
...state,
encounter: {
...state.encounter,
combatants: [{ ...state.encounter.combatants[0], tempHp: 10 }],
},
};
const next = encounterReducer(withTemp, {
type: "set-creature-adjustment",
id: combatantId("c-1"),
adjustment: "elite",
baseCreature: BASE_CREATURE,
});
expect(next.encounter.combatants[0].tempHp).toBe(10);
});
it("name with auto-number suffix: 'Goblin 2' → 'Elite Goblin 2'", () => {
const state = stateWithCreature("Goblin 2", 75, 22);
const next = encounterReducer(state, {
type: "set-creature-adjustment",
id: combatantId("c-1"),
adjustment: "elite",
baseCreature: BASE_CREATURE,
});
expect(next.encounter.combatants[0].name).toBe("Elite Goblin 2");
});
it("manually renamed combatant: prefix not found, name unchanged", () => {
// Combatant was elite but manually renamed to "Big Boss"
const state = stateWithCreature("Big Boss", 95, 24, "elite");
const next = encounterReducer(state, {
type: "set-creature-adjustment",
id: combatantId("c-1"),
adjustment: undefined,
baseCreature: BASE_CREATURE,
});
// No "Elite " prefix found, so name stays as is
expect(next.encounter.combatants[0].name).toBe("Big Boss");
});
it("emits CreatureAdjustmentSet event", () => {
const state = stateWithCreature("Goblin Warrior", 75, 22);
const next = encounterReducer(state, {
type: "set-creature-adjustment",
id: combatantId("c-1"),
adjustment: "elite",
baseCreature: BASE_CREATURE,
});
const event = next.events.find((e) => e.type === "CreatureAdjustmentSet");
expect(event).toEqual({
type: "CreatureAdjustmentSet",
combatantId: "c-1",
adjustment: "elite",
});
});
it("returns unchanged state when adjustment is the same", () => {
const state = stateWithCreature("Elite Goblin Warrior", 95, 24, "elite");
const next = encounterReducer(state, {
type: "set-creature-adjustment",
id: combatantId("c-1"),
adjustment: "elite",
baseCreature: BASE_CREATURE,
});
expect(next).toBe(state);
});
it("returns unchanged state for unknown combatant", () => {
const state = stateWithCreature("Goblin Warrior", 75, 22);
const next = encounterReducer(state, {
type: "set-creature-adjustment",
id: combatantId("c-99"),
adjustment: "elite",
baseCreature: BASE_CREATURE,
});
expect(next).toBe(state);
});
});

View File

@@ -1,11 +1,12 @@
// @vitest-environment jsdom // @vitest-environment jsdom
import type { BestiaryIndexEntry, PlayerCharacter } from "@initiative/domain"; import type { PlayerCharacter } from "@initiative/domain";
import { combatantId, creatureId, playerCharacterId } from "@initiative/domain"; import { combatantId, creatureId, playerCharacterId } from "@initiative/domain";
import { act, renderHook } from "@testing-library/react"; import { act, renderHook } from "@testing-library/react";
import type { ReactNode } from "react"; import type { ReactNode } from "react";
import { beforeAll, describe, expect, it, vi } from "vitest"; import { beforeAll, describe, expect, it, vi } from "vitest";
import { createTestAdapters } from "../../__tests__/adapters/in-memory-adapters.js"; import { createTestAdapters } from "../../__tests__/adapters/in-memory-adapters.js";
import { AllProviders } from "../../__tests__/test-providers.js"; import { AllProviders } from "../../__tests__/test-providers.js";
import type { SearchResult } from "../use-bestiary.js";
import { useEncounter } from "../use-encounter.js"; import { useEncounter } from "../use-encounter.js";
beforeAll(() => { beforeAll(() => {
@@ -152,9 +153,11 @@ describe("useEncounter", () => {
expect(result.current.canRollAllInitiative).toBe(false); expect(result.current.canRollAllInitiative).toBe(false);
// Add from bestiary to get a creature combatant // Add from bestiary to get a creature combatant
const entry: BestiaryIndexEntry = { const entry: SearchResult = {
system: "dnd",
name: "Goblin", name: "Goblin",
source: "MM", source: "MM",
sourceDisplayName: "Monster Manual",
ac: 15, ac: 15,
hp: 7, hp: 7,
dex: 14, dex: 14,
@@ -175,9 +178,11 @@ describe("useEncounter", () => {
it("addFromBestiary adds combatant with HP, AC, creatureId", () => { it("addFromBestiary adds combatant with HP, AC, creatureId", () => {
const { result } = renderHook(() => useEncounter(), { wrapper }); const { result } = renderHook(() => useEncounter(), { wrapper });
const entry: BestiaryIndexEntry = { const entry: SearchResult = {
system: "dnd",
name: "Goblin", name: "Goblin",
source: "MM", source: "MM",
sourceDisplayName: "Monster Manual",
ac: 15, ac: 15,
hp: 7, hp: 7,
dex: 14, dex: 14,
@@ -202,9 +207,11 @@ describe("useEncounter", () => {
it("addFromBestiary auto-numbers duplicate names", () => { it("addFromBestiary auto-numbers duplicate names", () => {
const { result } = renderHook(() => useEncounter(), { wrapper }); const { result } = renderHook(() => useEncounter(), { wrapper });
const entry: BestiaryIndexEntry = { const entry: SearchResult = {
system: "dnd",
name: "Goblin", name: "Goblin",
source: "MM", source: "MM",
sourceDisplayName: "Monster Manual",
ac: 15, ac: 15,
hp: 7, hp: 7,
dex: 14, dex: 14,

View File

@@ -1,9 +1,10 @@
// @vitest-environment jsdom // @vitest-environment jsdom
import { act, renderHook } from "@testing-library/react"; import { act, renderHook } from "@testing-library/react";
import { afterEach, describe, expect, it } from "vitest"; import { afterEach, describe, expect, it, vi } from "vitest";
import { useRulesEdition } from "../use-rules-edition.js"; import { useRulesEdition } from "../use-rules-edition.js";
const STORAGE_KEY = "initiative:rules-edition"; const STORAGE_KEY = "initiative:game-system";
const OLD_STORAGE_KEY = "initiative:rules-edition";
describe("useRulesEdition", () => { describe("useRulesEdition", () => {
afterEach(() => { afterEach(() => {
@@ -11,6 +12,7 @@ describe("useRulesEdition", () => {
const { result } = renderHook(() => useRulesEdition()); const { result } = renderHook(() => useRulesEdition());
act(() => result.current.setEdition("5.5e")); act(() => result.current.setEdition("5.5e"));
localStorage.removeItem(STORAGE_KEY); localStorage.removeItem(STORAGE_KEY);
localStorage.removeItem(OLD_STORAGE_KEY);
}); });
it("defaults to 5.5e", () => { it("defaults to 5.5e", () => {
@@ -42,4 +44,31 @@ describe("useRulesEdition", () => {
expect(r2.current.edition).toBe("5e"); expect(r2.current.edition).toBe("5e");
}); });
it("accepts pf2e as a valid game system", () => {
const { result } = renderHook(() => useRulesEdition());
act(() => result.current.setEdition("pf2e"));
expect(result.current.edition).toBe("pf2e");
expect(localStorage.getItem(STORAGE_KEY)).toBe("pf2e");
});
it("migrates from old storage key on fresh module load", async () => {
// Set up old key before re-importing the module
localStorage.setItem(OLD_STORAGE_KEY, "5e");
localStorage.removeItem(STORAGE_KEY);
// Force a fresh module so loadEdition() re-runs at init time
vi.resetModules();
const { useRulesEdition: freshHook } = await import(
"../use-rules-edition.js"
);
const { result } = renderHook(() => freshHook());
expect(result.current.edition).toBe("5e");
expect(localStorage.getItem(STORAGE_KEY)).toBe("5e");
expect(localStorage.getItem(OLD_STORAGE_KEY)).toBeNull();
});
}); });

View File

@@ -6,8 +6,8 @@ export function useAutoStatBlock(): void {
const { encounter } = useEncounterContext(); const { encounter } = useEncounterContext();
const { panelView, updateCreature } = useSidePanelContext(); const { panelView, updateCreature } = useSidePanelContext();
const activeCreatureId = const activeCombatant = encounter.combatants[encounter.activeIndex];
encounter.combatants[encounter.activeIndex]?.creatureId; const activeCreatureId = activeCombatant?.creatureId;
const prevActiveIndexRef = useRef(encounter.activeIndex); const prevActiveIndexRef = useRef(encounter.activeIndex);
useEffect(() => { useEffect(() => {
@@ -21,7 +21,13 @@ export function useAutoStatBlock(): void {
activeCreatureId && activeCreatureId &&
panelView.mode === "creature" panelView.mode === "creature"
) { ) {
updateCreature(activeCreatureId); updateCreature(activeCreatureId, activeCombatant.id);
} }
}, [encounter.activeIndex, activeCreatureId, panelView.mode, updateCreature]); }, [
encounter.activeIndex,
activeCreatureId,
activeCombatant?.id,
panelView.mode,
updateCreature,
]);
} }

View File

@@ -1,25 +1,37 @@
import type { import type {
AnyCreature,
BestiaryIndexEntry, BestiaryIndexEntry,
Creature,
CreatureId, CreatureId,
Pf2eBestiaryIndexEntry,
} from "@initiative/domain"; } from "@initiative/domain";
import { useCallback, useEffect, useState } from "react"; import { useCallback, useEffect, useState } from "react";
import { import {
normalizeBestiary, normalizeBestiary,
setSourceDisplayNames, setSourceDisplayNames,
} from "../adapters/bestiary-adapter.js"; } from "../adapters/bestiary-adapter.js";
import { normalizeFoundryCreatures } from "../adapters/pf2e-bestiary-adapter.js";
import { useAdapters } from "../contexts/adapter-context.js"; import { useAdapters } from "../contexts/adapter-context.js";
import { useRulesEditionContext } from "../contexts/rules-edition-context.js";
export interface SearchResult extends BestiaryIndexEntry { export type SearchResult =
| (BestiaryIndexEntry & {
readonly system: "dnd";
readonly sourceDisplayName: string; readonly sourceDisplayName: string;
} })
| (Pf2eBestiaryIndexEntry & {
readonly system: "pf2e";
readonly sourceDisplayName: string;
});
interface BestiaryHook { interface BestiaryHook {
search: (query: string) => SearchResult[]; search: (query: string) => SearchResult[];
getCreature: (id: CreatureId) => Creature | undefined; getCreature: (id: CreatureId) => AnyCreature | undefined;
isLoaded: boolean; isLoaded: boolean;
isSourceCached: (sourceCode: string) => Promise<boolean>; isSourceCached: (sourceCode: string) => Promise<boolean>;
fetchAndCacheSource: (sourceCode: string, url: string) => Promise<void>; fetchAndCacheSource: (
sourceCode: string,
url: string,
) => Promise<{ skippedNames: string[] }>;
uploadAndCacheSource: ( uploadAndCacheSource: (
sourceCode: string, sourceCode: string,
jsonData: unknown, jsonData: unknown,
@@ -27,29 +39,149 @@ interface BestiaryHook {
refreshCache: () => Promise<void>; refreshCache: () => Promise<void>;
} }
interface BatchResult {
readonly responses: unknown[];
readonly failed: string[];
}
async function fetchJson(url: string, path: string): Promise<unknown> {
const response = await fetch(url);
if (!response.ok) {
throw new Error(
`Failed to fetch ${path}: ${response.status} ${response.statusText}`,
);
}
return response.json();
}
async function fetchWithRetry(
url: string,
path: string,
retries = 2,
): Promise<unknown> {
try {
return await fetchJson(url, path);
} catch (error) {
if (retries <= 0) throw error;
await new Promise<void>((r) => setTimeout(r, 500));
return fetchWithRetry(url, path, retries - 1);
}
}
async function fetchBatch(
baseUrl: string,
paths: string[],
): Promise<BatchResult> {
const settled = await Promise.allSettled(
paths.map((path) => fetchWithRetry(`${baseUrl}${path}`, path)),
);
const responses: unknown[] = [];
const failed: string[] = [];
for (let i = 0; i < settled.length; i++) {
const result = settled[i];
if (result.status === "fulfilled") {
responses.push(result.value);
} else {
failed.push(paths[i]);
}
}
return { responses, failed };
}
async function fetchInBatches(
paths: string[],
baseUrl: string,
concurrency: number,
): Promise<BatchResult> {
const batches: string[][] = [];
for (let i = 0; i < paths.length; i += concurrency) {
batches.push(paths.slice(i, i + concurrency));
}
const accumulated = await batches.reduce<Promise<BatchResult>>(
async (prev, batch) => {
const acc = await prev;
const result = await fetchBatch(baseUrl, batch);
return {
responses: [...acc.responses, ...result.responses],
failed: [...acc.failed, ...result.failed],
};
},
Promise.resolve({ responses: [], failed: [] }),
);
return accumulated;
}
interface Pf2eFetchResult {
creatures: AnyCreature[];
skippedNames: string[];
}
async function fetchPf2eSource(
paths: string[],
url: string,
sourceCode: string,
displayName: string,
resolveNames: (failedPaths: string[]) => Map<string, string>,
): Promise<Pf2eFetchResult> {
const baseUrl = url.endsWith("/") ? url : `${url}/`;
const { responses, failed } = await fetchInBatches(paths, baseUrl, 6);
if (responses.length === 0) {
throw new Error(
`Failed to fetch any creatures (${failed.length} failed). This may be caused by an ad blocker — try disabling it for this site or use file upload instead.`,
);
}
const nameMap = failed.length > 0 ? resolveNames(failed) : new Map();
const skippedNames = failed.map((p) => nameMap.get(p) ?? p);
if (skippedNames.length > 0) {
console.warn("Skipped creatures (ad blocker?):", skippedNames);
}
return {
creatures: normalizeFoundryCreatures(responses, sourceCode, displayName),
skippedNames,
};
}
export function useBestiary(): BestiaryHook { export function useBestiary(): BestiaryHook {
const { bestiaryCache, bestiaryIndex } = useAdapters(); const { bestiaryCache, bestiaryIndex, pf2eBestiaryIndex } = useAdapters();
const { edition } = useRulesEditionContext();
const [isLoaded, setIsLoaded] = useState(false); const [isLoaded, setIsLoaded] = useState(false);
const [creatureMap, setCreatureMap] = useState( const [creatureMap, setCreatureMap] = useState(
() => new Map<CreatureId, Creature>(), () => new Map<CreatureId, AnyCreature>(),
); );
useEffect(() => { useEffect(() => {
const index = bestiaryIndex.loadIndex(); const index = bestiaryIndex.loadIndex();
setSourceDisplayNames(index.sources as Record<string, string>); setSourceDisplayNames(index.sources as Record<string, string>);
if (index.creatures.length > 0) {
const pf2eIndex = pf2eBestiaryIndex.loadIndex();
if (index.creatures.length > 0 || pf2eIndex.creatures.length > 0) {
setIsLoaded(true); setIsLoaded(true);
} }
void bestiaryCache.loadAllCachedCreatures().then((map) => { void bestiaryCache.loadAllCachedCreatures().then((map) => {
setCreatureMap(map); setCreatureMap(map);
}); });
}, [bestiaryCache, bestiaryIndex]); }, [bestiaryCache, bestiaryIndex, pf2eBestiaryIndex]);
const search = useCallback( const search = useCallback(
(query: string): SearchResult[] => { (query: string): SearchResult[] => {
if (query.length < 2) return []; if (query.length < 2) return [];
const lower = query.toLowerCase(); const lower = query.toLowerCase();
if (edition === "pf2e") {
const index = pf2eBestiaryIndex.loadIndex();
return index.creatures
.filter((c) => c.name.toLowerCase().includes(lower))
.sort((a, b) => a.name.localeCompare(b.name))
.slice(0, 10)
.map((c) => ({
...c,
system: "pf2e" as const,
sourceDisplayName: pf2eBestiaryIndex.getSourceDisplayName(c.source),
}));
}
const index = bestiaryIndex.loadIndex(); const index = bestiaryIndex.loadIndex();
return index.creatures return index.creatures
.filter((c) => c.name.toLowerCase().includes(lower)) .filter((c) => c.name.toLowerCase().includes(lower))
@@ -57,28 +189,50 @@ export function useBestiary(): BestiaryHook {
.slice(0, 10) .slice(0, 10)
.map((c) => ({ .map((c) => ({
...c, ...c,
system: "dnd" as const,
sourceDisplayName: bestiaryIndex.getSourceDisplayName(c.source), sourceDisplayName: bestiaryIndex.getSourceDisplayName(c.source),
})); }));
}, },
[bestiaryIndex], [bestiaryIndex, pf2eBestiaryIndex, edition],
); );
const getCreature = useCallback( const getCreature = useCallback(
(id: CreatureId): Creature | undefined => { (id: CreatureId): AnyCreature | undefined => {
return creatureMap.get(id); return creatureMap.get(id);
}, },
[creatureMap], [creatureMap],
); );
const system = edition === "pf2e" ? "pf2e" : "dnd";
const isSourceCachedFn = useCallback( const isSourceCachedFn = useCallback(
(sourceCode: string): Promise<boolean> => { (sourceCode: string): Promise<boolean> => {
return bestiaryCache.isSourceCached(sourceCode); return bestiaryCache.isSourceCached(system, sourceCode);
}, },
[bestiaryCache], [bestiaryCache, system],
); );
const fetchAndCacheSource = useCallback( const fetchAndCacheSource = useCallback(
async (sourceCode: string, url: string): Promise<void> => { async (
sourceCode: string,
url: string,
): Promise<{ skippedNames: string[] }> => {
let creatures: AnyCreature[];
let skippedNames: string[] = [];
if (edition === "pf2e") {
const paths = pf2eBestiaryIndex.getCreaturePathsForSource(sourceCode);
const displayName = pf2eBestiaryIndex.getSourceDisplayName(sourceCode);
const result = await fetchPf2eSource(
paths,
url,
sourceCode,
displayName,
pf2eBestiaryIndex.getCreatureNamesByPaths,
);
creatures = result.creatures;
skippedNames = result.skippedNames;
} else {
const response = await fetch(url); const response = await fetch(url);
if (!response.ok) { if (!response.ok) {
throw new Error( throw new Error(
@@ -86,9 +240,19 @@ export function useBestiary(): BestiaryHook {
); );
} }
const json = await response.json(); const json = await response.json();
const creatures = normalizeBestiary(json); creatures = normalizeBestiary(json);
const displayName = bestiaryIndex.getSourceDisplayName(sourceCode); }
await bestiaryCache.cacheSource(sourceCode, displayName, creatures);
const displayName =
edition === "pf2e"
? pf2eBestiaryIndex.getSourceDisplayName(sourceCode)
: bestiaryIndex.getSourceDisplayName(sourceCode);
await bestiaryCache.cacheSource(
system,
sourceCode,
displayName,
creatures,
);
setCreatureMap((prev) => { setCreatureMap((prev) => {
const next = new Map(prev); const next = new Map(prev);
for (const c of creatures) { for (const c of creatures) {
@@ -96,16 +260,33 @@ export function useBestiary(): BestiaryHook {
} }
return next; return next;
}); });
return { skippedNames };
}, },
[bestiaryCache, bestiaryIndex], [bestiaryCache, bestiaryIndex, pf2eBestiaryIndex, edition, system],
); );
const uploadAndCacheSource = useCallback( const uploadAndCacheSource = useCallback(
async (sourceCode: string, jsonData: unknown): Promise<void> => { async (sourceCode: string, jsonData: unknown): Promise<void> => {
// biome-ignore lint/suspicious/noExplicitAny: raw JSON shape varies const creatures =
const creatures = normalizeBestiary(jsonData as any); edition === "pf2e"
const displayName = bestiaryIndex.getSourceDisplayName(sourceCode); ? normalizeFoundryCreatures(
await bestiaryCache.cacheSource(sourceCode, displayName, creatures); Array.isArray(jsonData) ? jsonData : [jsonData],
sourceCode,
pf2eBestiaryIndex.getSourceDisplayName(sourceCode),
)
: normalizeBestiary(
jsonData as Parameters<typeof normalizeBestiary>[0],
);
const displayName =
edition === "pf2e"
? pf2eBestiaryIndex.getSourceDisplayName(sourceCode)
: bestiaryIndex.getSourceDisplayName(sourceCode);
await bestiaryCache.cacheSource(
system,
sourceCode,
displayName,
creatures,
);
setCreatureMap((prev) => { setCreatureMap((prev) => {
const next = new Map(prev); const next = new Map(prev);
for (const c of creatures) { for (const c of creatures) {
@@ -114,7 +295,7 @@ export function useBestiary(): BestiaryHook {
return next; return next;
}); });
}, },
[bestiaryCache, bestiaryIndex], [bestiaryCache, bestiaryIndex, pf2eBestiaryIndex, edition, system],
); );
const refreshCache = useCallback(async (): Promise<void> => { const refreshCache = useCallback(async (): Promise<void> => {

View File

@@ -1,5 +1,6 @@
import { useCallback, useRef, useState } from "react"; import { useCallback, useRef, useState } from "react";
import { useAdapters } from "../contexts/adapter-context.js"; import { useAdapters } from "../contexts/adapter-context.js";
import { useRulesEditionContext } from "../contexts/rules-edition-context.js";
const BATCH_SIZE = 6; const BATCH_SIZE = 6;
@@ -21,7 +22,10 @@ interface BulkImportHook {
state: BulkImportState; state: BulkImportState;
startImport: ( startImport: (
baseUrl: string, baseUrl: string,
fetchAndCacheSource: (sourceCode: string, url: string) => Promise<void>, fetchAndCacheSource: (
sourceCode: string,
url: string,
) => Promise<{ skippedNames: string[] }>,
isSourceCached: (sourceCode: string) => Promise<boolean>, isSourceCached: (sourceCode: string) => Promise<boolean>,
refreshCache: () => Promise<void>, refreshCache: () => Promise<void>,
) => void; ) => void;
@@ -29,18 +33,23 @@ interface BulkImportHook {
} }
export function useBulkImport(): BulkImportHook { export function useBulkImport(): BulkImportHook {
const { bestiaryIndex } = useAdapters(); const { bestiaryIndex, pf2eBestiaryIndex } = useAdapters();
const { edition } = useRulesEditionContext();
const indexPort = edition === "pf2e" ? pf2eBestiaryIndex : bestiaryIndex;
const [state, setState] = useState<BulkImportState>(IDLE_STATE); const [state, setState] = useState<BulkImportState>(IDLE_STATE);
const countersRef = useRef({ completed: 0, failed: 0 }); const countersRef = useRef({ completed: 0, failed: 0 });
const startImport = useCallback( const startImport = useCallback(
( (
baseUrl: string, baseUrl: string,
fetchAndCacheSource: (sourceCode: string, url: string) => Promise<void>, fetchAndCacheSource: (
sourceCode: string,
url: string,
) => Promise<{ skippedNames: string[] }>,
isSourceCached: (sourceCode: string) => Promise<boolean>, isSourceCached: (sourceCode: string) => Promise<boolean>,
refreshCache: () => Promise<void>, refreshCache: () => Promise<void>,
) => { ) => {
const allCodes = bestiaryIndex.getAllSourceCodes(); const allCodes = indexPort.getAllSourceCodes();
const total = allCodes.length; const total = allCodes.length;
countersRef.current = { completed: 0, failed: 0 }; countersRef.current = { completed: 0, failed: 0 };
@@ -81,7 +90,7 @@ export function useBulkImport(): BulkImportHook {
chain.then(() => chain.then(() =>
Promise.allSettled( Promise.allSettled(
batch.map(async ({ code }) => { batch.map(async ({ code }) => {
const url = bestiaryIndex.getDefaultFetchUrl(code, baseUrl); const url = indexPort.getDefaultFetchUrl(code, baseUrl);
try { try {
await fetchAndCacheSource(code, url); await fetchAndCacheSource(code, url);
countersRef.current.completed++; countersRef.current.completed++;
@@ -115,7 +124,7 @@ export function useBulkImport(): BulkImportHook {
}); });
})(); })();
}, },
[bestiaryIndex], [indexPort],
); );
const reset = useCallback(() => { const reset = useCallback(() => {

View File

@@ -64,7 +64,7 @@ export function useDifficultyBreakdown(): DifficultyBreakdown | null {
} }
type CreatureInfo = { type CreatureInfo = {
cr: string; cr?: string;
source: string; source: string;
sourceDisplayName: string; sourceDisplayName: string;
}; };
@@ -87,10 +87,11 @@ function buildBreakdownEntry(
}; };
} }
if (creature) { if (creature) {
const cr = creature.cr ?? null;
return { return {
combatant: c, combatant: c,
cr: creature.cr, cr,
xp: crToXp(creature.cr), xp: cr ? crToXp(cr) : null,
source: creature.sourceDisplayName ?? creature.source, source: creature.sourceDisplayName ?? creature.source,
editable: false, editable: false,
side, side,
@@ -132,7 +133,7 @@ function resolveCr(
getCreature: (id: CreatureId) => CreatureInfo | undefined, getCreature: (id: CreatureId) => CreatureInfo | undefined,
): { cr: string | null; creature: CreatureInfo | undefined } { ): { cr: string | null; creature: CreatureInfo | undefined } {
const creature = c.creatureId ? getCreature(c.creatureId) : undefined; const creature = c.creatureId ? getCreature(c.creatureId) : undefined;
const cr = creature ? creature.cr : (c.cr ?? null); const cr = creature?.cr ?? c.cr ?? null;
return { cr, creature }; return { cr, creature };
} }

View File

@@ -1,4 +1,5 @@
import type { import type {
AnyCreature,
Combatant, Combatant,
CombatantDescriptor, CombatantDescriptor,
CreatureId, CreatureId,
@@ -20,7 +21,7 @@ export function resolveSide(c: Combatant): "party" | "enemy" {
function buildDescriptors( function buildDescriptors(
combatants: readonly Combatant[], combatants: readonly Combatant[],
characters: readonly PlayerCharacter[], characters: readonly PlayerCharacter[],
getCreature: (id: CreatureId) => { cr: string } | undefined, getCreature: (id: CreatureId) => AnyCreature | undefined,
): CombatantDescriptor[] { ): CombatantDescriptor[] {
const descriptors: CombatantDescriptor[] = []; const descriptors: CombatantDescriptor[] = [];
for (const c of combatants) { for (const c of combatants) {
@@ -28,9 +29,10 @@ function buildDescriptors(
const level = c.playerCharacterId const level = c.playerCharacterId
? characters.find((p) => p.id === c.playerCharacterId)?.level ? characters.find((p) => p.id === c.playerCharacterId)?.level
: undefined; : undefined;
const cr = c.creatureId const creature = c.creatureId ? getCreature(c.creatureId) : undefined;
? getCreature(c.creatureId)?.cr const creatureCr =
: (c.cr ?? undefined); creature && !("system" in creature) ? creature.cr : undefined;
const cr = creatureCr ?? c.cr ?? undefined;
if (level !== undefined || cr !== undefined) { if (level !== undefined || cr !== undefined) {
descriptors.push({ level, cr, side }); descriptors.push({ level, cr, side });
@@ -46,6 +48,8 @@ export function useDifficulty(): DifficultyResult | null {
const { edition } = useRulesEditionContext(); const { edition } = useRulesEditionContext();
return useMemo(() => { return useMemo(() => {
if (edition === "pf2e") return null;
const descriptors = buildDescriptors( const descriptors = buildDescriptors(
encounter.combatants, encounter.combatants,
characters, characters,

View File

@@ -4,11 +4,13 @@ import {
adjustHpUseCase, adjustHpUseCase,
advanceTurnUseCase, advanceTurnUseCase,
clearEncounterUseCase, clearEncounterUseCase,
decrementConditionUseCase,
editCombatantUseCase, editCombatantUseCase,
redoUseCase, redoUseCase,
removeCombatantUseCase, removeCombatantUseCase,
retreatTurnUseCase, retreatTurnUseCase,
setAcUseCase, setAcUseCase,
setConditionValueUseCase,
setCrUseCase, setCrUseCase,
setHpUseCase, setHpUseCase,
setInitiativeUseCase, setInitiativeUseCase,
@@ -19,7 +21,6 @@ import {
undoUseCase, undoUseCase,
} from "@initiative/application"; } from "@initiative/application";
import type { import type {
BestiaryIndexEntry,
CombatantId, CombatantId,
CombatantInit, CombatantInit,
ConditionId, ConditionId,
@@ -27,12 +28,15 @@ import type {
DomainError, DomainError,
DomainEvent, DomainEvent,
Encounter, Encounter,
Pf2eCreature,
PlayerCharacter, PlayerCharacter,
UndoRedoState, UndoRedoState,
} from "@initiative/domain"; } from "@initiative/domain";
import { import {
acDelta,
clearHistory, clearHistory,
combatantId, combatantId,
hpDelta,
isDomainError, isDomainError,
creatureId as makeCreatureId, creatureId as makeCreatureId,
pushUndo, pushUndo,
@@ -40,6 +44,7 @@ import {
} from "@initiative/domain"; } from "@initiative/domain";
import { useCallback, useEffect, useReducer, useRef } from "react"; import { useCallback, useEffect, useReducer, useRef } from "react";
import { useAdapters } from "../contexts/adapter-context.js"; import { useAdapters } from "../contexts/adapter-context.js";
import type { SearchResult } from "./use-bestiary.js";
// -- Types -- // -- Types --
@@ -61,16 +66,33 @@ type EncounterAction =
id: CombatantId; id: CombatantId;
conditionId: ConditionId; conditionId: ConditionId;
} }
| {
type: "set-condition-value";
id: CombatantId;
conditionId: ConditionId;
value: number;
}
| {
type: "decrement-condition";
id: CombatantId;
conditionId: ConditionId;
}
| { type: "toggle-concentration"; id: CombatantId } | { type: "toggle-concentration"; id: CombatantId }
| { type: "clear-encounter" } | { type: "clear-encounter" }
| { type: "undo" } | { type: "undo" }
| { type: "redo" } | { type: "redo" }
| { type: "add-from-bestiary"; entry: BestiaryIndexEntry } | { type: "add-from-bestiary"; entry: SearchResult }
| { | {
type: "add-multiple-from-bestiary"; type: "add-multiple-from-bestiary";
entry: BestiaryIndexEntry; entry: SearchResult;
count: number; count: number;
} }
| {
type: "set-creature-adjustment";
id: CombatantId;
adjustment: "weak" | "elite" | undefined;
baseCreature: Pf2eCreature;
}
| { type: "add-from-player-character"; pc: PlayerCharacter } | { type: "add-from-player-character"; pc: PlayerCharacter }
| { | {
type: "import"; type: "import";
@@ -156,7 +178,7 @@ function resolveAndRename(store: EncounterStore, name: string): string {
function addOneFromBestiary( function addOneFromBestiary(
store: EncounterStore, store: EncounterStore,
entry: BestiaryIndexEntry, entry: SearchResult,
nextId: number, nextId: number,
): { ): {
cId: CreatureId; cId: CreatureId;
@@ -215,7 +237,7 @@ function handleUndoRedo(
function handleAddFromBestiary( function handleAddFromBestiary(
state: EncounterState, state: EncounterState,
entry: BestiaryIndexEntry, entry: SearchResult,
count: number, count: number,
): EncounterState { ): EncounterState {
const { store, getEncounter } = makeStoreFromState(state); const { store, getEncounter } = makeStoreFromState(state);
@@ -266,6 +288,76 @@ function handleAddFromPlayerCharacter(
}; };
} }
function applyNamePrefix(
name: string,
oldAdj: "weak" | "elite" | undefined,
newAdj: "weak" | "elite" | undefined,
): string {
let base = name;
if (oldAdj === "weak" && name.startsWith("Weak ")) base = name.slice(5);
else if (oldAdj === "elite" && name.startsWith("Elite "))
base = name.slice(6);
if (newAdj === "weak") return `Weak ${base}`;
if (newAdj === "elite") return `Elite ${base}`;
return base;
}
function handleSetCreatureAdjustment(
state: EncounterState,
id: CombatantId,
adjustment: "weak" | "elite" | undefined,
baseCreature: Pf2eCreature,
): EncounterState {
const combatant = state.encounter.combatants.find((c) => c.id === id);
if (!combatant) return state;
const oldAdj = combatant.creatureAdjustment;
if (oldAdj === adjustment) return state;
const baseLevel = baseCreature.level;
const oldHpDelta = oldAdj ? hpDelta(baseLevel, oldAdj) : 0;
const newHpDelta = adjustment ? hpDelta(baseLevel, adjustment) : 0;
const netHpDelta = newHpDelta - oldHpDelta;
const oldAcDelta = oldAdj ? acDelta(oldAdj) : 0;
const newAcDelta = adjustment ? acDelta(adjustment) : 0;
const netAcDelta = newAcDelta - oldAcDelta;
const newMaxHp =
combatant.maxHp === undefined ? undefined : combatant.maxHp + netHpDelta;
const newCurrentHp =
combatant.currentHp === undefined || newMaxHp === undefined
? undefined
: Math.max(0, Math.min(combatant.currentHp + netHpDelta, newMaxHp));
const newAc =
combatant.ac === undefined ? undefined : combatant.ac + netAcDelta;
const newName = applyNamePrefix(combatant.name, oldAdj, adjustment);
const updatedCombatant: typeof combatant = {
...combatant,
name: newName,
...(newMaxHp !== undefined && { maxHp: newMaxHp }),
...(newCurrentHp !== undefined && { currentHp: newCurrentHp }),
...(newAc !== undefined && { ac: newAc }),
...(adjustment === undefined
? { creatureAdjustment: undefined }
: { creatureAdjustment: adjustment }),
};
const combatants = state.encounter.combatants.map((c) =>
c.id === id ? updatedCombatant : c,
);
return {
...state,
encounter: { ...state.encounter, combatants },
events: [
...state.events,
{ type: "CreatureAdjustmentSet", combatantId: id, adjustment },
],
};
}
// -- Reducer -- // -- Reducer --
export function encounterReducer( export function encounterReducer(
@@ -297,6 +389,13 @@ export function encounterReducer(
lastCreatureId: null, lastCreatureId: null,
}; };
} }
case "set-creature-adjustment":
return handleSetCreatureAdjustment(
state,
action.id,
action.adjustment,
action.baseCreature,
);
case "add-from-bestiary": case "add-from-bestiary":
return handleAddFromBestiary(state, action.entry, 1); return handleAddFromBestiary(state, action.entry, 1);
case "add-multiple-from-bestiary": case "add-multiple-from-bestiary":
@@ -325,6 +424,8 @@ function dispatchEncounterAction(
| { type: "set-cr" } | { type: "set-cr" }
| { type: "set-side" } | { type: "set-side" }
| { type: "toggle-condition" } | { type: "toggle-condition" }
| { type: "set-condition-value" }
| { type: "decrement-condition" }
| { type: "toggle-concentration" } | { type: "toggle-concentration" }
>, >,
): EncounterState { ): EncounterState {
@@ -373,6 +474,17 @@ function dispatchEncounterAction(
case "toggle-condition": case "toggle-condition":
result = toggleConditionUseCase(store, action.id, action.conditionId); result = toggleConditionUseCase(store, action.id, action.conditionId);
break; break;
case "set-condition-value":
result = setConditionValueUseCase(
store,
action.id,
action.conditionId,
action.value,
);
break;
case "decrement-condition":
result = decrementConditionUseCase(store, action.id, action.conditionId);
break;
case "toggle-concentration": case "toggle-concentration":
result = toggleConcentrationUseCase(store, action.id); result = toggleConcentrationUseCase(store, action.id);
break; break;
@@ -395,7 +507,10 @@ function dispatchEncounterAction(
export function useEncounter() { export function useEncounter() {
const { encounterPersistence, undoRedoPersistence } = useAdapters(); const { encounterPersistence, undoRedoPersistence } = useAdapters();
const [state, dispatch] = useReducer(encounterReducer, null, () => const [state, dispatch] = useReducer(encounterReducer, null, () =>
initializeState(encounterPersistence.load, undoRedoPersistence.load), initializeState(
() => encounterPersistence.load(),
() => undoRedoPersistence.load(),
),
); );
const { encounter, undoRedoState, events } = state; const { encounter, undoRedoState, events } = state;
@@ -522,23 +637,44 @@ export function useEncounter() {
dispatch({ type: "toggle-condition", id, conditionId }), dispatch({ type: "toggle-condition", id, conditionId }),
[], [],
), ),
setConditionValue: useCallback(
(id: CombatantId, conditionId: ConditionId, value: number) =>
dispatch({ type: "set-condition-value", id, conditionId, value }),
[],
),
decrementCondition: useCallback(
(id: CombatantId, conditionId: ConditionId) =>
dispatch({ type: "decrement-condition", id, conditionId }),
[],
),
toggleConcentration: useCallback( toggleConcentration: useCallback(
(id: CombatantId) => dispatch({ type: "toggle-concentration", id }), (id: CombatantId) => dispatch({ type: "toggle-concentration", id }),
[], [],
), ),
setCreatureAdjustment: useCallback(
(
id: CombatantId,
adjustment: "weak" | "elite" | undefined,
baseCreature: Pf2eCreature,
) =>
dispatch({
type: "set-creature-adjustment",
id,
adjustment,
baseCreature,
}),
[],
),
clearEncounter: useCallback( clearEncounter: useCallback(
() => dispatch({ type: "clear-encounter" }), () => dispatch({ type: "clear-encounter" }),
[], [],
), ),
addFromBestiary: useCallback( addFromBestiary: useCallback((entry: SearchResult): CreatureId | null => {
(entry: BestiaryIndexEntry): CreatureId | null => {
dispatch({ type: "add-from-bestiary", entry }); dispatch({ type: "add-from-bestiary", entry });
return null; return null;
}, }, []),
[],
),
addMultipleFromBestiary: useCallback( addMultipleFromBestiary: useCallback(
(entry: BestiaryIndexEntry, count: number): CreatureId | null => { (entry: SearchResult, count: number): CreatureId | null => {
dispatch({ dispatch({
type: "add-multiple-from-bestiary", type: "add-multiple-from-bestiary",
entry, entry,

View File

@@ -1,7 +1,8 @@
import type { RulesEdition } from "@initiative/domain"; import type { RulesEdition } from "@initiative/domain";
import { useCallback, useSyncExternalStore } from "react"; import { useCallback, useSyncExternalStore } from "react";
const STORAGE_KEY = "initiative:rules-edition"; const STORAGE_KEY = "initiative:game-system";
const OLD_STORAGE_KEY = "initiative:rules-edition";
const listeners = new Set<() => void>(); const listeners = new Set<() => void>();
let currentEdition: RulesEdition = loadEdition(); let currentEdition: RulesEdition = loadEdition();
@@ -9,7 +10,14 @@ let currentEdition: RulesEdition = loadEdition();
function loadEdition(): RulesEdition { function loadEdition(): RulesEdition {
try { try {
const raw = localStorage.getItem(STORAGE_KEY); const raw = localStorage.getItem(STORAGE_KEY);
if (raw === "5e" || raw === "5.5e") return raw; if (raw === "5e" || raw === "5.5e" || raw === "pf2e") return raw;
// Migrate from old key
const old = localStorage.getItem(OLD_STORAGE_KEY);
if (old === "5e" || old === "5.5e") {
localStorage.setItem(STORAGE_KEY, old);
localStorage.removeItem(OLD_STORAGE_KEY);
return old;
}
} catch { } catch {
// storage unavailable // storage unavailable
} }

View File

@@ -1,15 +1,16 @@
import type { CreatureId } from "@initiative/domain"; import type { CombatantId, CreatureId } from "@initiative/domain";
import { useCallback, useEffect, useState } from "react"; import { useCallback, useEffect, useState } from "react";
type PanelView = type PanelView =
| { mode: "closed" } | { mode: "closed" }
| { mode: "creature"; creatureId: CreatureId } | { mode: "creature"; creatureId: CreatureId; combatantId?: CombatantId }
| { mode: "bulk-import" } | { mode: "bulk-import" }
| { mode: "source-manager" }; | { mode: "source-manager" };
interface SidePanelState { interface SidePanelState {
panelView: PanelView; panelView: PanelView;
selectedCreatureId: CreatureId | null; selectedCreatureId: CreatureId | null;
selectedCombatantId: CombatantId | null;
bulkImportMode: boolean; bulkImportMode: boolean;
sourceManagerMode: boolean; sourceManagerMode: boolean;
isRightPanelCollapsed: boolean; isRightPanelCollapsed: boolean;
@@ -18,8 +19,8 @@ interface SidePanelState {
} }
interface SidePanelActions { interface SidePanelActions {
showCreature: (creatureId: CreatureId) => void; showCreature: (creatureId: CreatureId, combatantId?: CombatantId) => void;
updateCreature: (creatureId: CreatureId) => void; updateCreature: (creatureId: CreatureId, combatantId?: CombatantId) => void;
showBulkImport: () => void; showBulkImport: () => void;
showSourceManager: () => void; showSourceManager: () => void;
dismissPanel: () => void; dismissPanel: () => void;
@@ -48,14 +49,23 @@ export function useSidePanelState(): SidePanelState & SidePanelActions {
const selectedCreatureId = const selectedCreatureId =
panelView.mode === "creature" ? panelView.creatureId : null; panelView.mode === "creature" ? panelView.creatureId : null;
const showCreature = useCallback((creatureId: CreatureId) => { const selectedCombatantId =
setPanelView({ mode: "creature", creatureId }); panelView.mode === "creature" ? (panelView.combatantId ?? null) : null;
setIsRightPanelCollapsed(false);
}, []);
const updateCreature = useCallback((creatureId: CreatureId) => { const showCreature = useCallback(
setPanelView({ mode: "creature", creatureId }); (creatureId: CreatureId, combatantId?: CombatantId) => {
}, []); setPanelView({ mode: "creature", creatureId, combatantId });
setIsRightPanelCollapsed(false);
},
[],
);
const updateCreature = useCallback(
(creatureId: CreatureId, combatantId?: CombatantId) => {
setPanelView({ mode: "creature", creatureId, combatantId });
},
[],
);
const showBulkImport = useCallback(() => { const showBulkImport = useCallback(() => {
setPanelView({ mode: "bulk-import" }); setPanelView({ mode: "bulk-import" });
@@ -90,6 +100,7 @@ export function useSidePanelState(): SidePanelState & SidePanelActions {
return { return {
panelView, panelView,
selectedCreatureId, selectedCreatureId,
selectedCombatantId,
bulkImportMode: panelView.mode === "bulk-import", bulkImportMode: panelView.mode === "bulk-import",
sourceManagerMode: panelView.mode === "source-manager", sourceManagerMode: panelView.mode === "source-manager",
isRightPanelCollapsed, isRightPanelCollapsed,

View File

@@ -70,3 +70,72 @@ export function useSwipeToDismiss(onDismiss: () => void) {
handlers: { onTouchStart, onTouchMove, onTouchEnd }, handlers: { onTouchStart, onTouchMove, onTouchEnd },
}; };
} }
/**
* Vertical (down-only) variant for dismissing bottom sheets via swipe-down.
* Mirrors `useSwipeToDismiss` but locks to vertical direction and tracks
* the sheet height instead of width.
*/
export function useSwipeToDismissDown(onDismiss: () => void) {
const [swipe, setSwipe] = useState<SwipeState>({
offsetX: 0,
isSwiping: false,
});
const startX = useRef(0);
const startY = useRef(0);
const startTime = useRef(0);
const sheetHeight = useRef(0);
const directionLocked = useRef<"horizontal" | "vertical" | null>(null);
const onTouchStart = useCallback((e: React.TouchEvent) => {
const touch = e.touches[0];
startX.current = touch.clientX;
startY.current = touch.clientY;
startTime.current = Date.now();
directionLocked.current = null;
const el = e.currentTarget as HTMLElement;
sheetHeight.current = el.getBoundingClientRect().height;
}, []);
const onTouchMove = useCallback((e: React.TouchEvent) => {
const touch = e.touches[0];
const dx = touch.clientX - startX.current;
const dy = touch.clientY - startY.current;
if (!directionLocked.current) {
if (Math.abs(dx) < 10 && Math.abs(dy) < 10) return;
directionLocked.current =
Math.abs(dy) > Math.abs(dx) ? "vertical" : "horizontal";
}
if (directionLocked.current === "horizontal") return;
const clampedY = Math.max(0, dy);
// `offsetX` is reused as the vertical offset to keep SwipeState shared.
setSwipe({ offsetX: clampedY, isSwiping: true });
}, []);
const onTouchEnd = useCallback(() => {
if (directionLocked.current !== "vertical") {
setSwipe({ offsetX: 0, isSwiping: false });
return;
}
const elapsed = (Date.now() - startTime.current) / 1000;
const velocity = swipe.offsetX / elapsed / sheetHeight.current;
const ratio =
sheetHeight.current > 0 ? swipe.offsetX / sheetHeight.current : 0;
if (ratio > DISMISS_THRESHOLD || velocity > VELOCITY_THRESHOLD) {
onDismiss();
}
setSwipe({ offsetX: 0, isSwiping: false });
}, [swipe.offsetX, onDismiss]);
return {
offsetY: swipe.offsetX,
isSwiping: swipe.isSwiping,
handlers: { onTouchStart, onTouchMove, onTouchEnd },
};
}

View File

@@ -103,6 +103,19 @@
animation: slide-in-right 200ms ease-out; animation: slide-in-right 200ms ease-out;
} }
@keyframes slide-in-bottom {
from {
transform: translateY(100%);
}
to {
transform: translateY(0);
}
}
@utility animate-slide-in-bottom {
animation: slide-in-bottom 200ms ease-out;
}
@keyframes confirm-pulse { @keyframes confirm-pulse {
0% { 0% {
scale: 1; scale: 1;

View File

@@ -10,7 +10,8 @@
"!coverage", "!coverage",
"!.pnpm-store", "!.pnpm-store",
"!.rodney", "!.rodney",
"!.agent-tests" "!.agent-tests",
"!data"
] ]
}, },
"assist": { "assist": {

File diff suppressed because one or more lines are too long

View File

@@ -31,7 +31,7 @@
"knip": "knip", "knip": "knip",
"jscpd": "jscpd", "jscpd": "jscpd",
"jsinspect": "jsinspect -c .jsinspectrc apps/web/src packages/domain/src packages/application/src", "jsinspect": "jsinspect -c .jsinspectrc apps/web/src packages/domain/src packages/application/src",
"oxlint": "oxlint --tsconfig apps/web/tsconfig.json --type-aware --deny warnings", "oxlint": "oxlint --tsconfig apps/web/tsconfig.json --type-aware --deny-warnings",
"check:ignores": "node scripts/check-lint-ignores.mjs", "check:ignores": "node scripts/check-lint-ignores.mjs",
"check:classnames": "node scripts/check-cn-classnames.mjs", "check:classnames": "node scripts/check-cn-classnames.mjs",
"check:props": "node scripts/check-component-props.mjs", "check:props": "node scripts/check-component-props.mjs",

View File

@@ -292,9 +292,9 @@ describe("toggleConditionUseCase", () => {
); );
expect(isDomainError(result)).toBe(false); expect(isDomainError(result)).toBe(false);
expect(requireSaved(store.saved).combatants[0].conditions).toContain( expect(requireSaved(store.saved).combatants[0].conditions).toContainEqual({
"blinded", id: "blinded",
); });
}); });
it("returns domain error for unknown combatant", () => { it("returns domain error for unknown combatant", () => {

View File

@@ -0,0 +1,21 @@
import {
type AnyCreature,
calculateInitiative,
calculatePf2eInitiative,
} from "@initiative/domain";
export function creatureInitiativeModifier(creature: AnyCreature): number {
if ("system" in creature && creature.system === "pf2e") {
return calculatePf2eInitiative(creature.perception).modifier;
}
const c = creature as {
abilities: { dex: number };
cr: string;
initiativeProficiency: number;
};
return calculateInitiative({
dexScore: c.abilities.dex,
cr: c.cr,
initiativeProficiency: c.initiativeProficiency,
}).modifier;
}

View File

@@ -0,0 +1,19 @@
import {
type CombatantId,
type ConditionId,
type DomainError,
type DomainEvent,
decrementCondition,
} from "@initiative/domain";
import type { EncounterStore } from "./ports.js";
import { runEncounterAction } from "./run-encounter-action.js";
export function decrementConditionUseCase(
store: EncounterStore,
combatantId: CombatantId,
conditionId: ConditionId,
): DomainEvent[] | DomainError {
return runEncounterAction(store, (encounter) =>
decrementCondition(encounter, combatantId, conditionId),
);
}

View File

@@ -3,6 +3,7 @@ export { adjustHpUseCase } from "./adjust-hp-use-case.js";
export { advanceTurnUseCase } from "./advance-turn-use-case.js"; export { advanceTurnUseCase } from "./advance-turn-use-case.js";
export { clearEncounterUseCase } from "./clear-encounter-use-case.js"; export { clearEncounterUseCase } from "./clear-encounter-use-case.js";
export { createPlayerCharacterUseCase } from "./create-player-character-use-case.js"; export { createPlayerCharacterUseCase } from "./create-player-character-use-case.js";
export { decrementConditionUseCase } from "./decrement-condition-use-case.js";
export { deletePlayerCharacterUseCase } from "./delete-player-character-use-case.js"; export { deletePlayerCharacterUseCase } from "./delete-player-character-use-case.js";
export { editCombatantUseCase } from "./edit-combatant-use-case.js"; export { editCombatantUseCase } from "./edit-combatant-use-case.js";
export { editPlayerCharacterUseCase } from "./edit-player-character-use-case.js"; export { editPlayerCharacterUseCase } from "./edit-player-character-use-case.js";
@@ -21,6 +22,7 @@ export {
} from "./roll-all-initiative-use-case.js"; } from "./roll-all-initiative-use-case.js";
export { rollInitiativeUseCase } from "./roll-initiative-use-case.js"; export { rollInitiativeUseCase } from "./roll-initiative-use-case.js";
export { setAcUseCase } from "./set-ac-use-case.js"; export { setAcUseCase } from "./set-ac-use-case.js";
export { setConditionValueUseCase } from "./set-condition-value-use-case.js";
export { setCrUseCase } from "./set-cr-use-case.js"; export { setCrUseCase } from "./set-cr-use-case.js";
export { setHpUseCase } from "./set-hp-use-case.js"; export { setHpUseCase } from "./set-hp-use-case.js";
export { setInitiativeUseCase } from "./set-initiative-use-case.js"; export { setInitiativeUseCase } from "./set-initiative-use-case.js";

View File

@@ -1,5 +1,5 @@
import type { import type {
Creature, AnyCreature,
CreatureId, CreatureId,
Encounter, Encounter,
PlayerCharacter, PlayerCharacter,
@@ -12,7 +12,7 @@ export interface EncounterStore {
} }
export interface BestiarySourceCache { export interface BestiarySourceCache {
getCreature(creatureId: CreatureId): Creature | undefined; getCreature(creatureId: CreatureId): AnyCreature | undefined;
isSourceCached(sourceCode: string): boolean; isSourceCached(sourceCode: string): boolean;
} }

View File

@@ -1,7 +1,6 @@
import { import {
type Creature, type AnyCreature,
type CreatureId, type CreatureId,
calculateInitiative,
type DomainError, type DomainError,
type DomainEvent, type DomainEvent,
isDomainError, isDomainError,
@@ -10,6 +9,7 @@ import {
selectRoll, selectRoll,
setInitiative, setInitiative,
} from "@initiative/domain"; } from "@initiative/domain";
import { creatureInitiativeModifier } from "./creature-initiative-modifier.js";
import type { EncounterStore } from "./ports.js"; import type { EncounterStore } from "./ports.js";
export interface RollAllResult { export interface RollAllResult {
@@ -20,7 +20,7 @@ export interface RollAllResult {
export function rollAllInitiativeUseCase( export function rollAllInitiativeUseCase(
store: EncounterStore, store: EncounterStore,
rollDice: () => number, rollDice: () => number,
getCreature: (id: CreatureId) => Creature | undefined, getCreature: (id: CreatureId) => AnyCreature | undefined,
mode: RollMode = "normal", mode: RollMode = "normal",
): RollAllResult | DomainError { ): RollAllResult | DomainError {
let encounter = store.get(); let encounter = store.get();
@@ -37,11 +37,7 @@ export function rollAllInitiativeUseCase(
continue; continue;
} }
const { modifier } = calculateInitiative({ const modifier = creatureInitiativeModifier(creature);
dexScore: creature.abilities.dex,
cr: creature.cr,
initiativeProficiency: creature.initiativeProficiency,
});
const roll1 = rollDice(); const roll1 = rollDice();
const effectiveRoll = const effectiveRoll =
mode === "normal" ? roll1 : selectRoll(roll1, rollDice(), mode); mode === "normal" ? roll1 : selectRoll(roll1, rollDice(), mode);

View File

@@ -1,8 +1,7 @@
import { import {
type AnyCreature,
type CombatantId, type CombatantId,
type Creature,
type CreatureId, type CreatureId,
calculateInitiative,
type DomainError, type DomainError,
type DomainEvent, type DomainEvent,
isDomainError, isDomainError,
@@ -11,13 +10,14 @@ import {
selectRoll, selectRoll,
setInitiative, setInitiative,
} from "@initiative/domain"; } from "@initiative/domain";
import { creatureInitiativeModifier } from "./creature-initiative-modifier.js";
import type { EncounterStore } from "./ports.js"; import type { EncounterStore } from "./ports.js";
export function rollInitiativeUseCase( export function rollInitiativeUseCase(
store: EncounterStore, store: EncounterStore,
combatantId: CombatantId, combatantId: CombatantId,
diceRolls: readonly [number, ...number[]], diceRolls: readonly [number, ...number[]],
getCreature: (id: CreatureId) => Creature | undefined, getCreature: (id: CreatureId) => AnyCreature | undefined,
mode: RollMode = "normal", mode: RollMode = "normal",
): DomainEvent[] | DomainError { ): DomainEvent[] | DomainError {
const encounter = store.get(); const encounter = store.get();
@@ -48,11 +48,7 @@ export function rollInitiativeUseCase(
}; };
} }
const { modifier } = calculateInitiative({ const modifier = creatureInitiativeModifier(creature);
dexScore: creature.abilities.dex,
cr: creature.cr,
initiativeProficiency: creature.initiativeProficiency,
});
const effectiveRoll = const effectiveRoll =
mode === "normal" mode === "normal"
? diceRolls[0] ? diceRolls[0]

View File

@@ -0,0 +1,20 @@
import {
type CombatantId,
type ConditionId,
type DomainError,
type DomainEvent,
setConditionValue,
} from "@initiative/domain";
import type { EncounterStore } from "./ports.js";
import { runEncounterAction } from "./run-encounter-action.js";
export function setConditionValueUseCase(
store: EncounterStore,
combatantId: CombatantId,
conditionId: ConditionId,
value: number,
): DomainEvent[] | DomainError {
return runEncounterAction(store, (encounter) =>
setConditionValue(encounter, combatantId, conditionId, value),
);
}

View File

@@ -54,7 +54,7 @@ describe("clearEncounter", () => {
maxHp: 50, maxHp: 50,
currentHp: 30, currentHp: 30,
ac: 18, ac: 18,
conditions: ["blinded", "poisoned"], conditions: [{ id: "blinded" }, { id: "poisoned" }],
isConcentrating: true, isConcentrating: true,
}, },
{ {
@@ -63,7 +63,7 @@ describe("clearEncounter", () => {
maxHp: 25, maxHp: 25,
currentHp: 0, currentHp: 0,
ac: 12, ac: 12,
conditions: ["unconscious"], conditions: [{ id: "unconscious" }],
}, },
], ],
activeIndex: 0, activeIndex: 0,

View File

@@ -26,25 +26,40 @@ describe("getConditionDescription", () => {
); );
}); });
it("universal conditions have both descriptions", () => { it("returns pf2e description when edition is pf2e", () => {
const universal = CONDITION_DEFINITIONS.filter( const blinded = findCondition("blinded");
(d) => d.edition === undefined, expect(getConditionDescription(blinded, "pf2e")).toBe(
blinded.descriptionPf2e,
); );
expect(universal.length).toBeGreaterThan(0); });
for (const def of universal) {
it("falls back to default description for pf2e when no pf2e text", () => {
const paralyzed = findCondition("paralyzed");
expect(getConditionDescription(paralyzed, "pf2e")).toBe(
paralyzed.descriptionPf2e,
);
});
it("shared D&D conditions have both description and description5e", () => {
const sharedDndConditions = CONDITION_DEFINITIONS.filter(
(d) =>
d.systems === undefined ||
(d.systems.includes("5e") && d.systems.includes("5.5e")),
);
for (const def of sharedDndConditions) {
expect(def.description).toBeTruthy(); expect(def.description).toBeTruthy();
expect(def.description5e).toBeTruthy(); expect(def.description5e).toBeTruthy();
} }
}); });
it("edition-specific conditions have their edition description", () => { it("system-specific conditions use the systems field", () => {
const sapped = findCondition("sapped"); const sapped = findCondition("sapped");
expect(sapped.description).toBeTruthy(); expect(sapped.description).toBeTruthy();
expect(sapped.edition).toBe("5.5e"); expect(sapped.systems).toContain("5.5e");
const slowed = findCondition("slowed"); const slowed = findCondition("slowed");
expect(slowed.description).toBeTruthy(); expect(slowed.description).toBeTruthy();
expect(slowed.edition).toBe("5.5e"); expect(slowed.systems).toContain("5.5e");
}); });
it("conditions with identical rules share the same text", () => { it("conditions with identical rules share the same text", () => {
@@ -79,4 +94,34 @@ describe("getConditionsForEdition", () => {
expect(ids5e).toContain("blinded"); expect(ids5e).toContain("blinded");
expect(ids55e).toContain("blinded"); expect(ids55e).toContain("blinded");
}); });
it("returns PF2e conditions for pf2e edition", () => {
const conditions = getConditionsForEdition("pf2e");
const ids = conditions.map((d) => d.id);
expect(ids).toContain("clumsy");
expect(ids).toContain("drained");
expect(ids).toContain("off-guard");
expect(ids).toContain("sickened");
expect(ids).not.toContain("charmed");
expect(ids).not.toContain("exhaustion");
expect(ids).not.toContain("grappled");
});
it("returns D&D conditions for 5.5e", () => {
const conditions = getConditionsForEdition("5.5e");
const ids = conditions.map((d) => d.id);
expect(ids).toContain("charmed");
expect(ids).toContain("exhaustion");
expect(ids).not.toContain("clumsy");
expect(ids).not.toContain("off-guard");
});
it("shared conditions appear in both D&D and PF2e", () => {
const dndIds = getConditionsForEdition("5.5e").map((d) => d.id);
const pf2eIds = getConditionsForEdition("pf2e").map((d) => d.id);
expect(dndIds).toContain("blinded");
expect(pf2eIds).toContain("blinded");
expect(dndIds).toContain("prone");
expect(pf2eIds).toContain("prone");
});
}); });

View File

@@ -1,6 +1,7 @@
import { describe, expect, it } from "vitest"; import { describe, expect, it } from "vitest";
import { import {
calculateInitiative, calculateInitiative,
calculatePf2eInitiative,
formatInitiativeModifier, formatInitiativeModifier,
} from "../initiative.js"; } from "../initiative.js";
@@ -93,6 +94,26 @@ describe("calculateInitiative", () => {
}); });
}); });
describe("calculatePf2eInitiative", () => {
it("returns perception as both modifier and passive", () => {
const result = calculatePf2eInitiative(11);
expect(result.modifier).toBe(11);
expect(result.passive).toBe(11);
});
it("handles zero perception", () => {
const result = calculatePf2eInitiative(0);
expect(result.modifier).toBe(0);
expect(result.passive).toBe(0);
});
it("handles negative perception", () => {
const result = calculatePf2eInitiative(-2);
expect(result.modifier).toBe(-2);
expect(result.passive).toBe(-2);
});
});
describe("formatInitiativeModifier", () => { describe("formatInitiativeModifier", () => {
it("formats positive modifier with plus sign", () => { it("formats positive modifier with plus sign", () => {
expect(formatInitiativeModifier(7)).toBe("+7"); expect(formatInitiativeModifier(7)).toBe("+7");

View File

@@ -0,0 +1,270 @@
import { describe, expect, it } from "vitest";
import type { Pf2eCreature } from "../creature-types.js";
import { creatureId } from "../creature-types.js";
import {
acDelta,
adjustedLevel,
applyPf2eAdjustment,
hpDelta,
modDelta,
} from "../pf2e-adjustments.js";
describe("adjustedLevel", () => {
it("elite on level 5 → 6", () => {
expect(adjustedLevel(5, "elite")).toBe(6);
});
it("elite on level 0 → 2 (double bump)", () => {
expect(adjustedLevel(0, "elite")).toBe(2);
});
it("elite on level 1 → 1 (double bump)", () => {
expect(adjustedLevel(-1, "elite")).toBe(1);
});
it("weak on level 5 → 4", () => {
expect(adjustedLevel(5, "weak")).toBe(4);
});
it("weak on level 1 → 1 (double drop)", () => {
expect(adjustedLevel(1, "weak")).toBe(-1);
});
it("weak on level 0 → 1", () => {
expect(adjustedLevel(0, "weak")).toBe(-1);
});
});
describe("hpDelta", () => {
it("level 1 elite → +10", () => {
expect(hpDelta(1, "elite")).toBe(10);
});
it("level 1 weak → 10", () => {
expect(hpDelta(1, "weak")).toBe(-10);
});
it("level 3 elite → +15", () => {
expect(hpDelta(3, "elite")).toBe(15);
});
it("level 3 weak → 15", () => {
expect(hpDelta(3, "weak")).toBe(-15);
});
it("level 10 elite → +20", () => {
expect(hpDelta(10, "elite")).toBe(20);
});
it("level 10 weak → 20", () => {
expect(hpDelta(10, "weak")).toBe(-20);
});
it("level 25 elite → +30", () => {
expect(hpDelta(25, "elite")).toBe(30);
});
it("level 25 weak → 30", () => {
expect(hpDelta(25, "weak")).toBe(-30);
});
});
describe("acDelta", () => {
it("elite → +2", () => {
expect(acDelta("elite")).toBe(2);
});
it("weak → 2", () => {
expect(acDelta("weak")).toBe(-2);
});
});
describe("modDelta", () => {
it("elite → +2", () => {
expect(modDelta("elite")).toBe(2);
});
it("weak → 2", () => {
expect(modDelta("weak")).toBe(-2);
});
});
function baseCreature(overrides?: Partial<Pf2eCreature>): Pf2eCreature {
return {
system: "pf2e",
id: creatureId("test-creature"),
name: "Test Creature",
source: "test-source",
sourceDisplayName: "Test Source",
level: 5,
traits: ["humanoid"],
perception: 12,
skills: "Athletics +14",
abilityMods: {
str: 4,
dex: 2,
con: 3,
int: 0,
wis: 1,
cha: -1,
},
ac: 22,
saveFort: 14,
saveRef: 11,
saveWill: 9,
hp: 75,
speed: "25 feet",
...overrides,
};
}
describe("applyPf2eAdjustment", () => {
it("adjusts all numeric stats for elite", () => {
const creature = baseCreature();
const result = applyPf2eAdjustment(creature, "elite");
expect(result.level).toBe(6);
expect(result.ac).toBe(24);
expect(result.hp).toBe(95); // 75 + 20 (level 5 bracket)
expect(result.perception).toBe(14);
expect(result.saveFort).toBe(16);
expect(result.saveRef).toBe(13);
expect(result.saveWill).toBe(11);
});
it("adjusts all numeric stats for weak", () => {
const creature = baseCreature();
const result = applyPf2eAdjustment(creature, "weak");
expect(result.level).toBe(4);
expect(result.ac).toBe(20);
expect(result.hp).toBe(55); // 75 - 20 (level 5 bracket)
expect(result.perception).toBe(10);
expect(result.saveFort).toBe(12);
expect(result.saveRef).toBe(9);
expect(result.saveWill).toBe(7);
});
it("adjusts attack bonuses and damage", () => {
const creature = baseCreature({
attacks: [
{
name: "Melee",
activity: { number: 1, unit: "action" },
segments: [
{
type: "text",
value: "+15 [+10/+5] (agile), 2d12+7 piercing plus Grab",
},
],
},
],
});
const result = applyPf2eAdjustment(creature, "elite");
const text = result.attacks?.[0].segments[0];
expect(text).toEqual({
type: "text",
value: "+17 [+12/+7] (agile), 2d12+9 piercing plus Grab",
});
});
it("adjusts attack damage for weak", () => {
const creature = baseCreature({
attacks: [
{
name: "Melee",
activity: { number: 1, unit: "action" },
segments: [
{
type: "text",
value: "+15 (agile), 2d12+7 piercing plus Grab",
},
],
},
],
});
const result = applyPf2eAdjustment(creature, "weak");
const text = result.attacks?.[0].segments[0];
expect(text).toEqual({
type: "text",
value: "+13 (agile), 2d12+5 piercing plus Grab",
});
});
it("handles damage bonus becoming zero", () => {
const creature = baseCreature({
attacks: [
{
name: "Melee",
activity: { number: 1, unit: "action" },
segments: [{ type: "text", value: "+10, 1d4+2 slashing" }],
},
],
});
const result = applyPf2eAdjustment(creature, "weak");
const text = result.attacks?.[0].segments[0];
expect(text).toEqual({
type: "text",
value: "+8, 1d4 slashing",
});
});
it("handles damage bonus becoming negative", () => {
const creature = baseCreature({
attacks: [
{
name: "Melee",
activity: { number: 1, unit: "action" },
segments: [{ type: "text", value: "+10, 1d4+1 slashing" }],
},
],
});
const result = applyPf2eAdjustment(creature, "weak");
const text = result.attacks?.[0].segments[0];
expect(text).toEqual({
type: "text",
value: "+8, 1d4-1 slashing",
});
});
it("does not modify non-attack abilities", () => {
const creature = baseCreature({
abilitiesTop: [
{
name: "Darkvision",
segments: [{ type: "text", value: "Can see in darkness." }],
},
],
});
const result = applyPf2eAdjustment(creature, "elite");
expect(result.abilitiesTop).toEqual(creature.abilitiesTop);
});
it("preserves non-text segments in attacks", () => {
const creature = baseCreature({
attacks: [
{
name: "Melee",
activity: { number: 1, unit: "action" },
segments: [
{
type: "list",
items: [{ text: "some list item" }],
},
],
},
],
});
const result = applyPf2eAdjustment(creature, "elite");
expect(result.attacks?.[0].segments[0]).toEqual({
type: "list",
items: [{ text: "some list item" }],
});
});
});

View File

@@ -0,0 +1,99 @@
import { describe, expect, it } from "vitest";
import { recallKnowledge } from "../recall-knowledge.js";
describe("recallKnowledge", () => {
it("returns null when no type trait is recognized", () => {
expect(recallKnowledge(5, ["small", "goblin"])).toBeNull();
});
it("calculates DC for a common creature from the DC-by-level table", () => {
const result = recallKnowledge(5, ["humanoid"]);
expect(result).toEqual({ dc: 20, type: "humanoid", skills: ["Society"] });
});
it("calculates DC for level -1", () => {
const result = recallKnowledge(-1, ["humanoid"]);
expect(result).toEqual({ dc: 13, type: "humanoid", skills: ["Society"] });
});
it("calculates DC for level 0", () => {
const result = recallKnowledge(0, ["animal"]);
expect(result).toEqual({ dc: 14, type: "animal", skills: ["Nature"] });
});
it("calculates DC for level 25 (max table entry)", () => {
const result = recallKnowledge(25, ["dragon"]);
expect(result).toEqual({ dc: 50, type: "dragon", skills: ["Arcana"] });
});
it("clamps DC for levels beyond the table", () => {
const result = recallKnowledge(30, ["dragon"]);
expect(result).toEqual({ dc: 50, type: "dragon", skills: ["Arcana"] });
});
it("adjusts DC for uncommon rarity (+2)", () => {
const result = recallKnowledge(5, ["uncommon", "medium", "undead"]);
expect(result).toEqual({
dc: 22,
type: "undead",
skills: ["Religion"],
});
});
it("adjusts DC for rare rarity (+5)", () => {
const result = recallKnowledge(5, ["rare", "large", "dragon"]);
expect(result).toEqual({ dc: 25, type: "dragon", skills: ["Arcana"] });
});
it("adjusts DC for unique rarity (+10)", () => {
const result = recallKnowledge(5, ["unique", "medium", "humanoid"]);
expect(result).toEqual({
dc: 30,
type: "humanoid",
skills: ["Society"],
});
});
it("returns multiple skills for beast type", () => {
const result = recallKnowledge(3, ["beast"]);
expect(result).toEqual({
dc: 18,
type: "beast",
skills: ["Arcana", "Nature"],
});
});
it("returns multiple skills for construct type", () => {
const result = recallKnowledge(1, ["construct"]);
expect(result).toEqual({
dc: 15,
type: "construct",
skills: ["Arcana", "Crafting"],
});
});
it("matches type traits case-insensitively", () => {
const result = recallKnowledge(5, ["Humanoid"]);
expect(result).toEqual({ dc: 20, type: "Humanoid", skills: ["Society"] });
});
it("uses the first matching type trait when multiple are present", () => {
const result = recallKnowledge(7, ["large", "monitor", "protean"]);
expect(result).toEqual({
dc: 23,
type: "monitor",
skills: ["Religion"],
});
});
it("preserves original trait casing in the returned type", () => {
const result = recallKnowledge(1, ["Fey"]);
expect(result?.type).toBe("Fey");
});
it("ignores common rarity (no adjustment)", () => {
// "common" is not included in traits by the normalization pipeline
const result = recallKnowledge(5, ["medium", "humanoid"]);
expect(result?.dc).toBe(20);
});
});

View File

@@ -35,7 +35,7 @@ describe("rehydrateCombatant", () => {
expect(result?.maxHp).toBe(7); expect(result?.maxHp).toBe(7);
expect(result?.currentHp).toBe(5); expect(result?.currentHp).toBe(5);
expect(result?.tempHp).toBe(3); expect(result?.tempHp).toBe(3);
expect(result?.conditions).toEqual(["poisoned"]); expect(result?.conditions).toEqual([{ id: "poisoned" }]);
expect(result?.isConcentrating).toBe(true); expect(result?.isConcentrating).toBe(true);
expect(result?.creatureId).toBe("creature-goblin"); expect(result?.creatureId).toBe("creature-goblin");
expect(result?.color).toBe("red"); expect(result?.color).toBe("red");
@@ -165,7 +165,45 @@ describe("rehydrateCombatant", () => {
...minimalCombatant(), ...minimalCombatant(),
conditions: ["poisoned", "fake", "blinded"], conditions: ["poisoned", "fake", "blinded"],
}); });
expect(result?.conditions).toEqual(["poisoned", "blinded"]); expect(result?.conditions).toEqual([
{ id: "poisoned" },
{ id: "blinded" },
]);
});
it("converts old bare string format to ConditionEntry", () => {
const result = rehydrateCombatant({
...minimalCombatant(),
conditions: ["blinded", "prone"],
});
expect(result?.conditions).toEqual([{ id: "blinded" }, { id: "prone" }]);
});
it("passes through new ConditionEntry format with values", () => {
const result = rehydrateCombatant({
...minimalCombatant(),
conditions: [{ id: "blinded" }, { id: "frightened", value: 2 }],
});
expect(result?.conditions).toEqual([
{ id: "blinded" },
{ id: "frightened", value: 2 },
]);
});
it("handles mixed old and new format entries", () => {
const result = rehydrateCombatant({
...minimalCombatant(),
conditions: ["blinded", { id: "prone" }],
});
expect(result?.conditions).toEqual([{ id: "blinded" }, { id: "prone" }]);
});
it("drops ConditionEntry with invalid value", () => {
const result = rehydrateCombatant({
...minimalCombatant(),
conditions: [{ id: "blinded", value: -1 }],
});
expect(result?.conditions).toEqual([{ id: "blinded" }]);
}); });
it("drops invalid color — keeps combatant", () => { it("drops invalid color — keeps combatant", () => {

View File

@@ -1,14 +1,18 @@
import { describe, expect, it } from "vitest"; import { describe, expect, it } from "vitest";
import type { ConditionId } from "../conditions.js"; import type { ConditionEntry, ConditionId } from "../conditions.js";
import { CONDITION_DEFINITIONS } from "../conditions.js"; import { CONDITION_DEFINITIONS } from "../conditions.js";
import { toggleCondition } from "../toggle-condition.js"; import {
decrementCondition,
setConditionValue,
toggleCondition,
} from "../toggle-condition.js";
import type { Combatant, Encounter } from "../types.js"; import type { Combatant, Encounter } from "../types.js";
import { combatantId, isDomainError } from "../types.js"; import { combatantId, isDomainError } from "../types.js";
import { expectDomainError } from "./test-helpers.js"; import { expectDomainError } from "./test-helpers.js";
function makeCombatant( function makeCombatant(
name: string, name: string,
conditions?: readonly ConditionId[], conditions?: readonly ConditionEntry[],
): Combatant { ): Combatant {
return conditions return conditions
? { id: combatantId(name), name, conditions } ? { id: combatantId(name), name, conditions }
@@ -32,7 +36,7 @@ describe("toggleCondition", () => {
const e = enc([makeCombatant("A")]); const e = enc([makeCombatant("A")]);
const { encounter, events } = success(e, "A", "blinded"); const { encounter, events } = success(e, "A", "blinded");
expect(encounter.combatants[0].conditions).toEqual(["blinded"]); expect(encounter.combatants[0].conditions).toEqual([{ id: "blinded" }]);
expect(events).toEqual([ expect(events).toEqual([
{ {
type: "ConditionAdded", type: "ConditionAdded",
@@ -43,7 +47,7 @@ describe("toggleCondition", () => {
}); });
it("removes a condition when already present", () => { it("removes a condition when already present", () => {
const e = enc([makeCombatant("A", ["blinded"])]); const e = enc([makeCombatant("A", [{ id: "blinded" }])]);
const { encounter, events } = success(e, "A", "blinded"); const { encounter, events } = success(e, "A", "blinded");
expect(encounter.combatants[0].conditions).toBeUndefined(); expect(encounter.combatants[0].conditions).toBeUndefined();
@@ -57,14 +61,17 @@ describe("toggleCondition", () => {
}); });
it("maintains definition order when adding conditions", () => { it("maintains definition order when adding conditions", () => {
const e = enc([makeCombatant("A", ["poisoned"])]); const e = enc([makeCombatant("A", [{ id: "poisoned" }])]);
const { encounter } = success(e, "A", "blinded"); const { encounter } = success(e, "A", "blinded");
expect(encounter.combatants[0].conditions).toEqual(["blinded", "poisoned"]); expect(encounter.combatants[0].conditions).toEqual([
{ id: "blinded" },
{ id: "poisoned" },
]);
}); });
it("prevents duplicate conditions", () => { it("prevents duplicate conditions", () => {
const e = enc([makeCombatant("A", ["blinded"])]); const e = enc([makeCombatant("A", [{ id: "blinded" }])]);
// Toggling blinded again removes it, not duplicates // Toggling blinded again removes it, not duplicates
const { encounter } = success(e, "A", "blinded"); const { encounter } = success(e, "A", "blinded");
expect(encounter.combatants[0].conditions).toBeUndefined(); expect(encounter.combatants[0].conditions).toBeUndefined();
@@ -96,7 +103,7 @@ describe("toggleCondition", () => {
}); });
it("normalizes empty array to undefined on removal", () => { it("normalizes empty array to undefined on removal", () => {
const e = enc([makeCombatant("A", ["charmed"])]); const e = enc([makeCombatant("A", [{ id: "charmed" }])]);
const { encounter } = success(e, "A", "charmed"); const { encounter } = success(e, "A", "charmed");
expect(encounter.combatants[0].conditions).toBeUndefined(); expect(encounter.combatants[0].conditions).toBeUndefined();
@@ -110,6 +117,145 @@ describe("toggleCondition", () => {
const result = success(e, "A", cond); const result = success(e, "A", cond);
e = result.encounter; e = result.encounter;
} }
expect(e.combatants[0].conditions).toEqual(order); expect(e.combatants[0].conditions).toEqual(order.map((id) => ({ id })));
});
});
describe("setConditionValue", () => {
it("adds a valued condition at the specified value", () => {
const e = enc([makeCombatant("A")]);
const result = setConditionValue(e, combatantId("A"), "frightened", 2);
if (isDomainError(result)) throw new Error(result.message);
expect(result.encounter.combatants[0].conditions).toEqual([
{ id: "frightened", value: 2 },
]);
expect(result.events).toEqual([
{
type: "ConditionAdded",
combatantId: combatantId("A"),
condition: "frightened",
value: 2,
},
]);
});
it("updates the value of an existing condition", () => {
const e = enc([makeCombatant("A", [{ id: "frightened", value: 1 }])]);
const result = setConditionValue(e, combatantId("A"), "frightened", 3);
if (isDomainError(result)) throw new Error(result.message);
expect(result.encounter.combatants[0].conditions).toEqual([
{ id: "frightened", value: 3 },
]);
});
it("removes condition when value is 0", () => {
const e = enc([makeCombatant("A", [{ id: "frightened", value: 2 }])]);
const result = setConditionValue(e, combatantId("A"), "frightened", 0);
if (isDomainError(result)) throw new Error(result.message);
expect(result.encounter.combatants[0].conditions).toBeUndefined();
expect(result.events[0].type).toBe("ConditionRemoved");
});
it("rejects unknown condition", () => {
const e = enc([makeCombatant("A")]);
const result = setConditionValue(
e,
combatantId("A"),
"flying" as ConditionId,
1,
);
expectDomainError(result, "unknown-condition");
});
it("clamps value to maxValue for capped conditions", () => {
const e = enc([makeCombatant("A")]);
const result = setConditionValue(e, combatantId("A"), "dying", 6);
if (isDomainError(result)) throw new Error(result.message);
expect(result.encounter.combatants[0].conditions).toEqual([
{ id: "dying", value: 4 },
]);
expect(result.events[0]).toMatchObject({
type: "ConditionAdded",
value: 4,
});
});
it("allows value at exactly the max", () => {
const e = enc([makeCombatant("A")]);
const result = setConditionValue(e, combatantId("A"), "doomed", 3);
if (isDomainError(result)) throw new Error(result.message);
expect(result.encounter.combatants[0].conditions).toEqual([
{ id: "doomed", value: 3 },
]);
});
it("allows value below the max", () => {
const e = enc([makeCombatant("A")]);
const result = setConditionValue(e, combatantId("A"), "wounded", 2);
if (isDomainError(result)) throw new Error(result.message);
expect(result.encounter.combatants[0].conditions).toEqual([
{ id: "wounded", value: 2 },
]);
});
it("does not cap conditions without a maxValue", () => {
const e = enc([makeCombatant("A")]);
const result = setConditionValue(e, combatantId("A"), "frightened", 10);
if (isDomainError(result)) throw new Error(result.message);
expect(result.encounter.combatants[0].conditions).toEqual([
{ id: "frightened", value: 10 },
]);
});
it("clamps when updating an existing capped condition", () => {
const e = enc([makeCombatant("A", [{ id: "slowed-pf2e", value: 2 }])]);
const result = setConditionValue(e, combatantId("A"), "slowed-pf2e", 5);
if (isDomainError(result)) throw new Error(result.message);
expect(result.encounter.combatants[0].conditions).toEqual([
{ id: "slowed-pf2e", value: 3 },
]);
});
});
describe("decrementCondition", () => {
it("decrements value by 1", () => {
const e = enc([makeCombatant("A", [{ id: "frightened", value: 3 }])]);
const result = decrementCondition(e, combatantId("A"), "frightened");
if (isDomainError(result)) throw new Error(result.message);
expect(result.encounter.combatants[0].conditions).toEqual([
{ id: "frightened", value: 2 },
]);
});
it("removes condition when value reaches 0", () => {
const e = enc([makeCombatant("A", [{ id: "frightened", value: 1 }])]);
const result = decrementCondition(e, combatantId("A"), "frightened");
if (isDomainError(result)) throw new Error(result.message);
expect(result.encounter.combatants[0].conditions).toBeUndefined();
expect(result.events[0].type).toBe("ConditionRemoved");
});
it("removes non-valued condition (value undefined treated as 1)", () => {
const e = enc([makeCombatant("A", [{ id: "blinded" }])]);
const result = decrementCondition(e, combatantId("A"), "blinded");
if (isDomainError(result)) throw new Error(result.message);
expect(result.encounter.combatants[0].conditions).toBeUndefined();
});
it("returns error for inactive condition", () => {
const e = enc([makeCombatant("A")]);
const result = decrementCondition(e, combatantId("A"), "frightened");
expectDomainError(result, "condition-not-active");
}); });
}); });

View File

@@ -14,6 +14,7 @@ export interface CombatantInit {
readonly ac?: number; readonly ac?: number;
readonly initiative?: number; readonly initiative?: number;
readonly creatureId?: CreatureId; readonly creatureId?: CreatureId;
readonly creatureAdjustment?: "weak" | "elite";
readonly color?: string; readonly color?: string;
readonly icon?: string; readonly icon?: string;
readonly playerCharacterId?: PlayerCharacterId; readonly playerCharacterId?: PlayerCharacterId;
@@ -67,6 +68,9 @@ function buildCombatant(
...(init?.ac !== undefined && { ac: init.ac }), ...(init?.ac !== undefined && { ac: init.ac }),
...(init?.initiative !== undefined && { initiative: init.initiative }), ...(init?.initiative !== undefined && { initiative: init.initiative }),
...(init?.creatureId !== undefined && { creatureId: init.creatureId }), ...(init?.creatureId !== undefined && { creatureId: init.creatureId }),
...(init?.creatureAdjustment !== undefined && {
creatureAdjustment: init.creatureAdjustment,
}),
...(init?.color !== undefined && { color: init.color }), ...(init?.color !== undefined && { color: init.color }),
...(init?.icon !== undefined && { icon: init.icon }), ...(init?.icon !== undefined && { icon: init.icon }),
...(init?.playerCharacterId !== undefined && { ...(init?.playerCharacterId !== undefined && {

View File

@@ -1,3 +1,28 @@
const DIGITS_ONLY = /^\d+$/;
function scanExisting(
baseName: string,
existingNames: readonly string[],
): { exactMatches: number[]; maxNumber: number } {
const exactMatches: number[] = [];
let maxNumber = 0;
const prefix = `${baseName} `;
for (let i = 0; i < existingNames.length; i++) {
const name = existingNames[i];
if (name === baseName) {
exactMatches.push(i);
} else if (name.startsWith(prefix)) {
const suffix = name.slice(prefix.length);
if (DIGITS_ONLY.test(suffix)) {
const num = Number.parseInt(suffix, 10);
if (num > maxNumber) maxNumber = num;
}
}
}
return { exactMatches, maxNumber };
}
/** /**
* Resolves a creature name against existing combatant names, * Resolves a creature name against existing combatant names,
* handling auto-numbering for duplicates. * handling auto-numbering for duplicates.
@@ -14,25 +39,7 @@ export function resolveCreatureName(
newName: string; newName: string;
renames: ReadonlyArray<{ from: string; to: string }>; renames: ReadonlyArray<{ from: string; to: string }>;
} { } {
// Find exact matches and numbered matches (e.g., "Goblin 1", "Goblin 2") const { exactMatches, maxNumber } = scanExisting(baseName, existingNames);
const exactMatches: number[] = [];
let maxNumber = 0;
for (let i = 0; i < existingNames.length; i++) {
const name = existingNames[i];
if (name === baseName) {
exactMatches.push(i);
} else {
const match = new RegExp(
String.raw`^${escapeRegExp(baseName)} (\d+)$`,
).exec(name);
// biome-ignore lint/nursery/noUnnecessaryConditions: RegExp.exec() returns null on no match — false positive
if (match) {
const num = Number.parseInt(match[1], 10);
if (num > maxNumber) maxNumber = num;
}
}
}
// No conflict at all // No conflict at all
if (exactMatches.length === 0 && maxNumber === 0) { if (exactMatches.length === 0 && maxNumber === 0) {
@@ -51,7 +58,3 @@ export function resolveCreatureName(
const nextNumber = Math.max(maxNumber, exactMatches.length) + 1; const nextNumber = Math.max(maxNumber, exactMatches.length) + 1;
return { newName: `${baseName} ${nextNumber}`, renames: [] }; return { newName: `${baseName} ${nextNumber}`, renames: [] };
} }
function escapeRegExp(s: string): string {
return s.replaceAll(/[.*+?^${}()|[\]\\]/g, String.raw`\$&`);
}

View File

@@ -1,21 +1,48 @@
export type ConditionId = export type ConditionId =
| "blinded" | "blinded"
| "charmed" | "charmed"
| "clumsy"
| "concealed"
| "confused"
| "controlled"
| "dazzled"
| "deafened" | "deafened"
| "doomed"
| "drained"
| "dying"
| "enfeebled"
| "exhaustion" | "exhaustion"
| "fascinated"
| "fatigued"
| "fleeing"
| "frightened" | "frightened"
| "grabbed"
| "grappled" | "grappled"
| "hidden"
| "immobilized"
| "incapacitated" | "incapacitated"
| "invisible" | "invisible"
| "off-guard"
| "paralyzed" | "paralyzed"
| "petrified" | "petrified"
| "poisoned" | "poisoned"
| "prone" | "prone"
| "quickened"
| "restrained" | "restrained"
| "sapped" | "sapped"
| "sickened"
| "slowed" | "slowed"
| "slowed-pf2e"
| "stunned" | "stunned"
| "unconscious"; | "stupefied"
| "unconscious"
| "undetected"
| "wounded";
export interface ConditionEntry {
readonly id: ConditionId;
readonly value?: number;
}
import type { RulesEdition } from "./rules-edition.js"; import type { RulesEdition } from "./rules-edition.js";
@@ -24,20 +51,26 @@ export interface ConditionDefinition {
readonly label: string; readonly label: string;
readonly description: string; readonly description: string;
readonly description5e: string; readonly description5e: string;
readonly descriptionPf2e?: string;
readonly iconName: string; readonly iconName: string;
readonly color: string; readonly color: string;
/** When set, the condition only appears in this edition's picker. */ /** When set, the condition only appears in these systems' pickers. */
readonly edition?: RulesEdition; readonly systems?: readonly RulesEdition[];
readonly valued?: boolean;
/** Rule-defined maximum value for PF2e valued conditions. */
readonly maxValue?: number;
} }
export function getConditionDescription( export function getConditionDescription(
def: ConditionDefinition, def: ConditionDefinition,
edition: RulesEdition, edition: RulesEdition,
): string { ): string {
if (edition === "pf2e" && def.descriptionPf2e) return def.descriptionPf2e;
return edition === "5e" ? def.description5e : def.description; return edition === "5e" ? def.description5e : def.description;
} }
export const CONDITION_DEFINITIONS: readonly ConditionDefinition[] = [ export const CONDITION_DEFINITIONS: readonly ConditionDefinition[] = [
// ── Shared conditions (D&D + PF2e) ──
{ {
id: "blinded", id: "blinded",
label: "Blinded", label: "Blinded",
@@ -45,6 +78,8 @@ export const CONDITION_DEFINITIONS: readonly ConditionDefinition[] = [
"Can't see. Auto-fail sight checks. Attacks have Disadvantage; attacks against have Advantage.", "Can't see. Auto-fail sight checks. Attacks have Disadvantage; attacks against have Advantage.",
description5e: description5e:
"Can't see. Auto-fail sight checks. Attacks have Disadvantage; attacks against have Advantage.", "Can't see. Auto-fail sight checks. Attacks have Disadvantage; attacks against have Advantage.",
descriptionPf2e:
"Can't see. All terrain is difficult terrain. Auto-fail checks requiring sight. Immune to visual effects. Overrides dazzled.",
iconName: "EyeOff", iconName: "EyeOff",
color: "neutral", color: "neutral",
}, },
@@ -57,12 +92,15 @@ export const CONDITION_DEFINITIONS: readonly ConditionDefinition[] = [
"Can't attack or target the charmer with harmful abilities. Charmer has Advantage on social checks.", "Can't attack or target the charmer with harmful abilities. Charmer has Advantage on social checks.",
iconName: "Heart", iconName: "Heart",
color: "pink", color: "pink",
systems: ["5e", "5.5e"],
}, },
{ {
id: "deafened", id: "deafened",
label: "Deafened", label: "Deafened",
description: "Can't hear. Auto-fail hearing checks.", description: "Can't hear. Auto-fail hearing checks.",
description5e: "Can't hear. Auto-fail hearing checks.", description5e: "Can't hear. Auto-fail hearing checks.",
descriptionPf2e:
"Can't hear. Auto-critically-fail hearing checks. 2 status penalty to Perception. Auditory actions require DC 5 flat check. Immune to auditory effects.",
iconName: "EarOff", iconName: "EarOff",
color: "neutral", color: "neutral",
}, },
@@ -75,6 +113,7 @@ export const CONDITION_DEFINITIONS: readonly ConditionDefinition[] = [
"L1: Disadvantage on ability checks\nL2: Speed halved\nL3: Disadvantage on attacks and saves\nL4: HP max halved\nL5: Speed 0\nL6: Death\nLong rest removes 1 level.", "L1: Disadvantage on ability checks\nL2: Speed halved\nL3: Disadvantage on attacks and saves\nL4: HP max halved\nL5: Speed 0\nL6: Death\nLong rest removes 1 level.",
iconName: "BatteryLow", iconName: "BatteryLow",
color: "amber", color: "amber",
systems: ["5e", "5.5e"],
}, },
{ {
id: "frightened", id: "frightened",
@@ -83,8 +122,11 @@ export const CONDITION_DEFINITIONS: readonly ConditionDefinition[] = [
"Disadvantage on ability checks and attacks while source of fear is in line of sight. Can't willingly move closer to the source.", "Disadvantage on ability checks and attacks while source of fear is in line of sight. Can't willingly move closer to the source.",
description5e: description5e:
"Disadvantage on ability checks and attacks while source of fear is in line of sight. Can't willingly move closer to the source.", "Disadvantage on ability checks and attacks while source of fear is in line of sight. Can't willingly move closer to the source.",
descriptionPf2e:
"X status penalty to all checks and DCs (X = value). Can't willingly approach the source.",
iconName: "Siren", iconName: "Siren",
color: "orange", color: "orange",
valued: true,
}, },
{ {
id: "grappled", id: "grappled",
@@ -95,6 +137,7 @@ export const CONDITION_DEFINITIONS: readonly ConditionDefinition[] = [
"Speed 0. Ends if grappler is Incapacitated or moved out of reach.", "Speed 0. Ends if grappler is Incapacitated or moved out of reach.",
iconName: "Hand", iconName: "Hand",
color: "neutral", color: "neutral",
systems: ["5e", "5.5e"],
}, },
{ {
id: "incapacitated", id: "incapacitated",
@@ -104,6 +147,7 @@ export const CONDITION_DEFINITIONS: readonly ConditionDefinition[] = [
description5e: "Can't take Actions or Reactions.", description5e: "Can't take Actions or Reactions.",
iconName: "Ban", iconName: "Ban",
color: "gray", color: "gray",
systems: ["5e", "5.5e"],
}, },
{ {
id: "invisible", id: "invisible",
@@ -112,6 +156,8 @@ export const CONDITION_DEFINITIONS: readonly ConditionDefinition[] = [
"Can't be seen. Advantage on Initiative. Not affected by effects requiring sight (unless caster sees you). Attacks have Advantage; attacks against have Disadvantage.", "Can't be seen. Advantage on Initiative. Not affected by effects requiring sight (unless caster sees you). Attacks have Advantage; attacks against have Disadvantage.",
description5e: description5e:
"Impossible to see without magic or special sense. Heavily Obscured. Attacks have Advantage; attacks against have Disadvantage.", "Impossible to see without magic or special sense. Heavily Obscured. Attacks have Advantage; attacks against have Disadvantage.",
descriptionPf2e:
"Can't be seen except by special senses. Undetected to everyone. Can't be targeted except by effects that don't require sight.",
iconName: "Ghost", iconName: "Ghost",
color: "violet", color: "violet",
}, },
@@ -122,6 +168,8 @@ export const CONDITION_DEFINITIONS: readonly ConditionDefinition[] = [
"Incapacitated. Can't move or speak. Auto-fail Str/Dex saves. Attacks against have Advantage. Hits within 5 ft. are critical.", "Incapacitated. Can't move or speak. Auto-fail Str/Dex saves. Attacks against have Advantage. Hits within 5 ft. are critical.",
description5e: description5e:
"Incapacitated. Can't move or speak. Auto-fail Str/Dex saves. Attacks against have Advantage. Hits within 5 ft. are critical.", "Incapacitated. Can't move or speak. Auto-fail Str/Dex saves. Attacks against have Advantage. Hits within 5 ft. are critical.",
descriptionPf2e:
"Can't act. Off-guard. Can only Recall Knowledge or use mental actions.",
iconName: "ZapOff", iconName: "ZapOff",
color: "yellow", color: "yellow",
}, },
@@ -132,6 +180,8 @@ export const CONDITION_DEFINITIONS: readonly ConditionDefinition[] = [
"Turned to stone. Weight \u00D710. Incapacitated. Can't move or speak. Attacks against have Advantage. Auto-fail Str/Dex saves. Resistant to all damage. Immune to poison and disease.", "Turned to stone. Weight \u00D710. Incapacitated. Can't move or speak. Attacks against have Advantage. Auto-fail Str/Dex saves. Resistant to all damage. Immune to poison and disease.",
description5e: description5e:
"Turned to stone. Weight \u00D710. Incapacitated. Can't move or speak. Attacks against have Advantage. Auto-fail Str/Dex saves. Resistant to all damage. Immune to poison and disease.", "Turned to stone. Weight \u00D710. Incapacitated. Can't move or speak. Attacks against have Advantage. Auto-fail Str/Dex saves. Resistant to all damage. Immune to poison and disease.",
descriptionPf2e:
"Can't act. Can't sense anything. AC = 9. Hardness 8. Immune to most effects.",
iconName: "Gem", iconName: "Gem",
color: "slate", color: "slate",
}, },
@@ -142,6 +192,7 @@ export const CONDITION_DEFINITIONS: readonly ConditionDefinition[] = [
description5e: "Disadvantage on attack rolls and ability checks.", description5e: "Disadvantage on attack rolls and ability checks.",
iconName: "Droplet", iconName: "Droplet",
color: "green", color: "green",
systems: ["5e", "5.5e"],
}, },
{ {
id: "prone", id: "prone",
@@ -150,6 +201,8 @@ export const CONDITION_DEFINITIONS: readonly ConditionDefinition[] = [
"Can only crawl (costs extra movement). Disadvantage on attacks. Attacks within 5 ft. have Advantage; ranged attacks have Disadvantage. Standing up costs half movement.", "Can only crawl (costs extra movement). Disadvantage on attacks. Attacks within 5 ft. have Advantage; ranged attacks have Disadvantage. Standing up costs half movement.",
description5e: description5e:
"Can only crawl (costs extra movement). Disadvantage on attacks. Attacks within 5 ft. have Advantage; ranged attacks have Disadvantage. Standing up costs half movement.", "Can only crawl (costs extra movement). Disadvantage on attacks. Attacks within 5 ft. have Advantage; ranged attacks have Disadvantage. Standing up costs half movement.",
descriptionPf2e:
"Off-guard. 2 circumstance penalty to attack rolls. Only movement is Crawl and Stand. +1 circumstance bonus to AC vs. ranged attacks, 2 vs. melee.",
iconName: "ArrowDown", iconName: "ArrowDown",
color: "neutral", color: "neutral",
}, },
@@ -160,6 +213,8 @@ export const CONDITION_DEFINITIONS: readonly ConditionDefinition[] = [
"Speed is 0. Attacks have Disadvantage. Attacks against have Advantage. Disadvantage on Dex saves.", "Speed is 0. Attacks have Disadvantage. Attacks against have Advantage. Disadvantage on Dex saves.",
description5e: description5e:
"Speed is 0. Attacks have Disadvantage. Attacks against have Advantage. Disadvantage on Dex saves.", "Speed is 0. Attacks have Disadvantage. Attacks against have Advantage. Disadvantage on Dex saves.",
descriptionPf2e:
"Off-guard. Immobilized. Can't use any actions with the attack trait except to attempt to Escape.",
iconName: "Link", iconName: "Link",
color: "neutral", color: "neutral",
}, },
@@ -171,7 +226,7 @@ export const CONDITION_DEFINITIONS: readonly ConditionDefinition[] = [
description5e: "", description5e: "",
iconName: "ShieldMinus", iconName: "ShieldMinus",
color: "amber", color: "amber",
edition: "5.5e", systems: ["5.5e"],
}, },
{ {
id: "slowed", id: "slowed",
@@ -181,7 +236,7 @@ export const CONDITION_DEFINITIONS: readonly ConditionDefinition[] = [
description5e: "", description5e: "",
iconName: "Snail", iconName: "Snail",
color: "sky", color: "sky",
edition: "5.5e", systems: ["5.5e"],
}, },
{ {
id: "stunned", id: "stunned",
@@ -190,8 +245,11 @@ export const CONDITION_DEFINITIONS: readonly ConditionDefinition[] = [
"Incapacitated (can't act or speak). Auto-fail Str/Dex saves. Attacks against have Advantage.", "Incapacitated (can't act or speak). Auto-fail Str/Dex saves. Attacks against have Advantage.",
description5e: description5e:
"Incapacitated. Can't move. Can speak only falteringly. Auto-fail Str/Dex saves. Attacks against have Advantage.", "Incapacitated. Can't move. Can speak only falteringly. Auto-fail Str/Dex saves. Attacks against have Advantage.",
descriptionPf2e:
"Can't act. Lose X total actions across turns, then the condition ends. Overrides slowed.",
iconName: "Sparkles", iconName: "Sparkles",
color: "yellow", color: "yellow",
valued: true,
}, },
{ {
id: "unconscious", id: "unconscious",
@@ -200,9 +258,265 @@ export const CONDITION_DEFINITIONS: readonly ConditionDefinition[] = [
"Incapacitated. Speed 0. Can't move or speak. Unaware of surroundings. Drops held items, falls Prone. Auto-fail Str/Dex saves. Attacks against have Advantage. Hits within 5 ft. are critical.", "Incapacitated. Speed 0. Can't move or speak. Unaware of surroundings. Drops held items, falls Prone. Auto-fail Str/Dex saves. Attacks against have Advantage. Hits within 5 ft. are critical.",
description5e: description5e:
"Incapacitated. Speed 0. Can't move or speak. Unaware of surroundings. Drops held items, falls Prone. Auto-fail Str/Dex saves. Attacks against have Advantage. Hits within 5 ft. are critical.", "Incapacitated. Speed 0. Can't move or speak. Unaware of surroundings. Drops held items, falls Prone. Auto-fail Str/Dex saves. Attacks against have Advantage. Hits within 5 ft. are critical.",
descriptionPf2e:
"Can't act. Off-guard. Blinded. 4 status penalty to AC, Perception, and Reflex saves. Fall prone, drop items.",
iconName: "Moon", iconName: "Moon",
color: "indigo", color: "indigo",
}, },
// ── PF2e-only conditions ──
{
id: "clumsy",
label: "Clumsy",
description: "",
description5e: "",
descriptionPf2e:
"X status penalty to Dex-based checks and DCs, including AC, Reflex saves, and ranged attack rolls.",
iconName: "Footprints",
color: "amber",
systems: ["pf2e"],
valued: true,
},
{
id: "concealed",
label: "Concealed",
description: "",
description5e: "",
descriptionPf2e:
"DC 5 flat check for targeted attacks. Doesn't change which creatures can see you.",
iconName: "CloudFog",
color: "slate",
systems: ["pf2e"],
},
{
id: "confused",
label: "Confused",
description: "",
description5e: "",
descriptionPf2e:
"Off-guard. Can't Delay, Ready, or use reactions. Must Strike or cast offensive cantrips at random targets. DC 11 flat check when damaged to end.",
iconName: "CircleHelp",
color: "pink",
systems: ["pf2e"],
},
{
id: "controlled",
label: "Controlled",
description: "",
description5e: "",
descriptionPf2e:
"Another creature determines your actions. You gain no actions of your own.",
iconName: "Drama",
color: "pink",
systems: ["pf2e"],
},
{
id: "dazzled",
label: "Dazzled",
description: "",
description5e: "",
descriptionPf2e:
"All creatures and objects are concealed to you. DC 5 flat check for targeted attacks requiring sight.",
iconName: "Sun",
color: "yellow",
systems: ["pf2e"],
},
{
id: "doomed",
label: "Doomed",
description: "",
description5e: "",
descriptionPf2e:
"Die at dying X (where X = 4 doomed value instead of dying 4). Decreases by 1 on full night's rest.",
iconName: "Skull",
color: "red",
systems: ["pf2e"],
valued: true,
maxValue: 3,
},
{
id: "drained",
label: "Drained",
description: "",
description5e: "",
descriptionPf2e:
"X status penalty to Con-based checks and DCs. Lose X × level in max HP. Decreases by 1 on full night's rest.",
iconName: "Droplets",
color: "red",
systems: ["pf2e"],
valued: true,
},
{
id: "dying",
label: "Dying",
description: "",
description5e: "",
descriptionPf2e:
"Unconscious. Make recovery checks at start of turn. At dying 4 (or 4 doomed), you die.",
iconName: "HeartPulse",
color: "red",
systems: ["pf2e"],
valued: true,
maxValue: 4,
},
{
id: "enfeebled",
label: "Enfeebled",
description: "",
description5e: "",
descriptionPf2e:
"X status penalty to Str-based rolls and DCs, including melee attack and damage rolls and Athletics checks.",
iconName: "TrendingDown",
color: "amber",
systems: ["pf2e"],
valued: true,
},
{
id: "fascinated",
label: "Fascinated",
description: "",
description5e: "",
descriptionPf2e:
"2 status penalty to Perception and skill checks. Can't use concentrate actions unless related to the fascination. Ends if hostile action is used against you or allies.",
iconName: "Eye",
color: "violet",
systems: ["pf2e"],
},
{
id: "fatigued",
label: "Fatigued",
description: "",
description5e: "",
descriptionPf2e:
"1 status penalty to AC and saves. Can't use exploration activities while traveling. Recover after a full night's rest.",
iconName: "BatteryLow",
color: "amber",
systems: ["pf2e"],
},
{
id: "fleeing",
label: "Fleeing",
description: "",
description5e: "",
descriptionPf2e:
"Must spend actions to move away from the source. Can't Delay or Ready.",
iconName: "PersonStanding",
color: "orange",
systems: ["pf2e"],
},
{
id: "grabbed",
label: "Grabbed",
description: "",
description5e: "",
descriptionPf2e:
"Off-guard. Immobilized. Manipulate actions require DC 5 flat check or are wasted.",
iconName: "Hand",
color: "neutral",
systems: ["pf2e"],
},
{
id: "hidden",
label: "Hidden",
description: "",
description5e: "",
descriptionPf2e:
"Known location but can't be seen. Off-guard to that creature. DC 11 flat check to target or miss.",
iconName: "EyeOff",
color: "slate",
systems: ["pf2e"],
},
{
id: "immobilized",
label: "Immobilized",
description: "",
description5e: "",
descriptionPf2e:
"Can't use any action with the move trait to change position.",
iconName: "Anchor",
color: "neutral",
systems: ["pf2e"],
},
{
id: "off-guard",
label: "Off-Guard",
description: "",
description5e: "",
descriptionPf2e: "2 circumstance penalty to AC. (Formerly flat-footed.)",
iconName: "ShieldOff",
color: "amber",
systems: ["pf2e"],
},
{
id: "quickened",
label: "Quickened",
description: "",
description5e: "",
descriptionPf2e:
"Gain 1 extra action at the start of your turn each round (limited uses specified by the effect).",
iconName: "Zap",
color: "green",
systems: ["pf2e"],
},
{
id: "sickened",
label: "Sickened",
description: "",
description5e: "",
descriptionPf2e:
"X status penalty to all checks and DCs. Can't willingly ingest anything. Reduce by retching (Fortitude save).",
iconName: "Droplet",
color: "green",
systems: ["pf2e"],
valued: true,
},
{
id: "slowed-pf2e",
label: "Slowed",
description: "",
description5e: "",
descriptionPf2e: "Lose X actions at the start of your turn each round.",
iconName: "Snail",
color: "sky",
systems: ["pf2e"],
valued: true,
maxValue: 3,
},
{
id: "stupefied",
label: "Stupefied",
description: "",
description5e: "",
descriptionPf2e:
"X status penalty to Int/Wis/Cha-based checks and DCs, including spell attack rolls and spell DCs. DC 5 + X flat check to cast spells or lose the spell.",
iconName: "BrainCog",
color: "violet",
systems: ["pf2e"],
valued: true,
},
{
id: "undetected",
label: "Undetected",
description: "",
description5e: "",
descriptionPf2e:
"Location unknown. Must pick a square to target; DC 11 flat check. Attacker is off-guard against your attacks.",
iconName: "Ghost",
color: "violet",
systems: ["pf2e"],
},
{
id: "wounded",
label: "Wounded",
description: "",
description5e: "",
descriptionPf2e:
"Next time you gain dying, add wounded value to dying value. Wounded 1 when you recover from dying; increases if already wounded.",
iconName: "HeartCrack",
color: "red",
systems: ["pf2e"],
valued: true,
maxValue: 3,
},
] as const; ] as const;
export const VALID_CONDITION_IDS: ReadonlySet<string> = new Set( export const VALID_CONDITION_IDS: ReadonlySet<string> = new Set(
@@ -213,6 +527,8 @@ export function getConditionsForEdition(
edition: RulesEdition, edition: RulesEdition,
): readonly ConditionDefinition[] { ): readonly ConditionDefinition[] {
return CONDITION_DEFINITIONS.filter( return CONDITION_DEFINITIONS.filter(
(d) => d.edition === undefined || d.edition === edition, (d) => d.systems === undefined || d.systems.includes(edition),
); )
.slice()
.sort((a, b) => a.label.localeCompare(b.label));
} }

View File

@@ -5,9 +5,26 @@ export function creatureId(id: string): CreatureId {
return id as CreatureId; return id as CreatureId;
} }
export type TraitSegment =
| { readonly type: "text"; readonly value: string }
| { readonly type: "list"; readonly items: readonly TraitListItem[] };
export interface TraitListItem {
readonly label?: string;
readonly text: string;
}
export interface ActivityCost {
readonly number: number;
readonly unit: "action" | "free" | "reaction";
}
export interface TraitBlock { export interface TraitBlock {
readonly name: string; readonly name: string;
readonly text: string; readonly activity?: ActivityCost;
readonly trigger?: string;
readonly frequency?: string;
readonly segments: readonly TraitSegment[];
} }
export interface LegendaryBlock { export interface LegendaryBlock {
@@ -15,16 +32,84 @@ export interface LegendaryBlock {
readonly entries: readonly TraitBlock[]; readonly entries: readonly TraitBlock[];
} }
/**
* A single spell entry within a creature's spellcasting block.
*
* `name` is always populated. All other fields are optional and are only
* populated for PF2e creatures (sourced from embedded Foundry VTT spell items).
* D&D 5e creatures populate only `name`.
*/
export interface SpellReference {
readonly name: string;
/** Stable slug from Foundry VTT (e.g. "magic-missile"). PF2e only. */
readonly slug?: string;
/** Plain-text description with Foundry enrichment tags stripped. */
readonly description?: string;
/** Spell rank/level (0 = cantrip). */
readonly rank?: number;
/** Trait slugs (e.g. ["concentrate", "manipulate", "force"]). */
readonly traits?: readonly string[];
/** Tradition labels (e.g. ["arcane", "occult"]). */
readonly traditions?: readonly string[];
/** Range (e.g. "30 feet", "touch"). */
readonly range?: string;
/** Target (e.g. "1 creature"). */
readonly target?: string;
/** Area (e.g. "20-foot burst"). */
readonly area?: string;
/** Duration (e.g. "1 minute", "sustained up to 1 minute"). */
readonly duration?: string;
/** Defense / save (e.g. "basic Reflex", "Will"). */
readonly defense?: string;
/** Action cost. PF2e: number = action count, "reaction", "free", or
* "1 minute" / "10 minutes" for cast time. */
readonly actionCost?: string;
/**
* Heightening rules text. May come from `system.heightening` (fixed
* intervals) or `system.overlays` (variant casts). Plain text after
* tag stripping.
*/
readonly heightening?: string;
/** Uses per day for "(×N)" rendering, when > 1. PF2e only. */
readonly usesPerDay?: number;
}
/** A carried equipment item on a PF2e creature (weapon, consumable, magic item, etc.). */
export interface EquipmentItem {
readonly name: string;
readonly level: number;
readonly category?: string;
readonly traits?: readonly string[];
readonly description?: string;
/** For scrolls/wands: the embedded spell name. */
readonly spellName?: string;
/** For scrolls/wands: the embedded spell rank. */
readonly spellRank?: number;
}
export interface DailySpells { export interface DailySpells {
readonly uses: number; readonly uses: number;
readonly each: boolean; readonly each: boolean;
readonly spells: readonly string[]; readonly spells: readonly SpellReference[];
} }
export interface SpellcastingBlock { export interface SpellcastingBlock {
readonly name: string; readonly name: string;
readonly headerText: string; readonly headerText: string;
readonly atWill?: readonly string[]; readonly atWill?: readonly SpellReference[];
readonly daily?: readonly DailySpells[]; readonly daily?: readonly DailySpells[];
readonly restLong?: readonly DailySpells[]; readonly restLong?: readonly DailySpells[];
} }
@@ -92,6 +177,66 @@ export interface BestiaryIndex {
readonly creatures: readonly BestiaryIndexEntry[]; readonly creatures: readonly BestiaryIndexEntry[];
} }
export interface Pf2eCreature {
readonly system: "pf2e";
readonly id: CreatureId;
readonly name: string;
readonly source: string;
readonly sourceDisplayName: string;
readonly level: number;
readonly traits: readonly string[];
readonly perception: number;
readonly perceptionDetails?: string;
readonly senses?: string;
readonly languages?: string;
readonly skills?: string;
readonly abilityMods: {
readonly str: number;
readonly dex: number;
readonly con: number;
readonly int: number;
readonly wis: number;
readonly cha: number;
};
readonly items?: string;
readonly ac: number;
readonly acConditional?: string;
readonly saveFort: number;
readonly saveRef: number;
readonly saveWill: number;
readonly saveConditional?: string;
readonly hp: number;
readonly hpDetails?: string;
readonly immunities?: string;
readonly resistances?: string;
readonly weaknesses?: string;
readonly speed: string;
readonly attacks?: readonly TraitBlock[];
readonly abilitiesTop?: readonly TraitBlock[];
readonly abilitiesMid?: readonly TraitBlock[];
readonly abilitiesBot?: readonly TraitBlock[];
readonly spellcasting?: readonly SpellcastingBlock[];
readonly equipment?: readonly EquipmentItem[];
}
export type AnyCreature = Creature | Pf2eCreature;
export interface Pf2eBestiaryIndexEntry {
readonly name: string;
readonly source: string;
readonly level: number;
readonly ac: number;
readonly hp: number;
readonly perception: number;
readonly size: string;
readonly type: string;
}
export interface Pf2eBestiaryIndex {
readonly sources: Readonly<Record<string, string>>;
readonly creatures: readonly Pf2eBestiaryIndexEntry[];
}
/** Maps a CR string to the corresponding proficiency bonus. */ /** Maps a CR string to the corresponding proficiency bonus. */
export function proficiencyBonus(cr: string): number { export function proficiencyBonus(cr: string): number {
const numericCr = cr.includes("/") const numericCr = cr.includes("/")

View File

@@ -112,12 +112,14 @@ export interface ConditionAdded {
readonly type: "ConditionAdded"; readonly type: "ConditionAdded";
readonly combatantId: CombatantId; readonly combatantId: CombatantId;
readonly condition: ConditionId; readonly condition: ConditionId;
readonly value?: number;
} }
export interface ConditionRemoved { export interface ConditionRemoved {
readonly type: "ConditionRemoved"; readonly type: "ConditionRemoved";
readonly combatantId: CombatantId; readonly combatantId: CombatantId;
readonly condition: ConditionId; readonly condition: ConditionId;
readonly value?: number;
} }
export interface ConcentrationStarted { export interface ConcentrationStarted {
@@ -130,6 +132,12 @@ export interface ConcentrationEnded {
readonly combatantId: CombatantId; readonly combatantId: CombatantId;
} }
export interface CreatureAdjustmentSet {
readonly type: "CreatureAdjustmentSet";
readonly combatantId: CombatantId;
readonly adjustment: "weak" | "elite" | undefined;
}
export interface EncounterCleared { export interface EncounterCleared {
readonly type: "EncounterCleared"; readonly type: "EncounterCleared";
readonly combatantCount: number; readonly combatantCount: number;
@@ -173,6 +181,7 @@ export type DomainEvent =
| ConditionRemoved | ConditionRemoved
| ConcentrationStarted | ConcentrationStarted
| ConcentrationEnded | ConcentrationEnded
| CreatureAdjustmentSet
| EncounterCleared | EncounterCleared
| PlayerCharacterCreated | PlayerCharacterCreated
| PlayerCharacterUpdated | PlayerCharacterUpdated

View File

@@ -13,6 +13,7 @@ export {
export { export {
CONDITION_DEFINITIONS, CONDITION_DEFINITIONS,
type ConditionDefinition, type ConditionDefinition,
type ConditionEntry,
type ConditionId, type ConditionId,
getConditionDescription, getConditionDescription,
getConditionsForEdition, getConditionsForEdition,
@@ -23,6 +24,8 @@ export {
createPlayerCharacter, createPlayerCharacter,
} from "./create-player-character.js"; } from "./create-player-character.js";
export { export {
type ActivityCost,
type AnyCreature,
type BestiaryIndex, type BestiaryIndex,
type BestiaryIndexEntry, type BestiaryIndexEntry,
type BestiarySource, type BestiarySource,
@@ -30,10 +33,17 @@ export {
type CreatureId, type CreatureId,
creatureId, creatureId,
type DailySpells, type DailySpells,
type EquipmentItem,
type LegendaryBlock, type LegendaryBlock,
type Pf2eBestiaryIndex,
type Pf2eBestiaryIndexEntry,
type Pf2eCreature,
proficiencyBonus, proficiencyBonus,
type SpellcastingBlock, type SpellcastingBlock,
type SpellReference,
type TraitBlock, type TraitBlock,
type TraitListItem,
type TraitSegment,
} from "./creature-types.js"; } from "./creature-types.js";
export { export {
type DeletePlayerCharacterSuccess, type DeletePlayerCharacterSuccess,
@@ -65,6 +75,7 @@ export type {
ConcentrationStarted, ConcentrationStarted,
ConditionAdded, ConditionAdded,
ConditionRemoved, ConditionRemoved,
CreatureAdjustmentSet,
CrSet, CrSet,
CurrentHpAdjusted, CurrentHpAdjusted,
DomainEvent, DomainEvent,
@@ -85,9 +96,18 @@ export type { ExportBundle } from "./export-bundle.js";
export { deriveHpStatus, type HpStatus } from "./hp-status.js"; export { deriveHpStatus, type HpStatus } from "./hp-status.js";
export { export {
calculateInitiative, calculateInitiative,
calculatePf2eInitiative,
formatInitiativeModifier, formatInitiativeModifier,
type InitiativeResult, type InitiativeResult,
} from "./initiative.js"; } from "./initiative.js";
export {
acDelta,
adjustedLevel,
applyPf2eAdjustment,
type CreatureAdjustment,
hpDelta,
modDelta,
} from "./pf2e-adjustments.js";
export { export {
type PlayerCharacter, type PlayerCharacter,
type PlayerCharacterId, type PlayerCharacterId,
@@ -98,6 +118,10 @@ export {
VALID_PLAYER_COLORS, VALID_PLAYER_COLORS,
VALID_PLAYER_ICONS, VALID_PLAYER_ICONS,
} from "./player-character-types.js"; } from "./player-character-types.js";
export {
type RecallKnowledge,
recallKnowledge,
} from "./recall-knowledge.js";
export { rehydrateCombatant } from "./rehydrate-combatant.js"; export { rehydrateCombatant } from "./rehydrate-combatant.js";
export { rehydratePlayerCharacter } from "./rehydrate-player-character.js"; export { rehydratePlayerCharacter } from "./rehydrate-player-character.js";
export { export {
@@ -125,6 +149,8 @@ export {
toggleConcentration, toggleConcentration,
} from "./toggle-concentration.js"; } from "./toggle-concentration.js";
export { export {
decrementCondition,
setConditionValue,
type ToggleConditionSuccess, type ToggleConditionSuccess,
toggleCondition, toggleCondition,
} from "./toggle-condition.js"; } from "./toggle-condition.js";

View File

@@ -20,6 +20,14 @@ export function calculateInitiative(creature: {
return { modifier, passive: 10 + modifier }; return { modifier, passive: 10 + modifier };
} }
/**
* Returns the PF2e initiative result directly from the Perception modifier.
* No proficiency bonus calculation — PF2e uses Perception as-is.
*/
export function calculatePf2eInitiative(perception: number): InitiativeResult {
return { modifier: perception, passive: perception };
}
/** /**
* Formats an initiative modifier with explicit sign. * Formats an initiative modifier with explicit sign.
* Uses U+2212 () for negative values. * Uses U+2212 () for negative values.

View File

@@ -0,0 +1,110 @@
import type {
Pf2eCreature,
TraitBlock,
TraitSegment,
} from "./creature-types.js";
export type CreatureAdjustment = "weak" | "elite";
/** HP bracket delta by creature level (standard PF2e table). */
function hpBracketDelta(level: number): number {
if (level <= 1) return 10;
if (level <= 4) return 15;
if (level <= 19) return 20;
return 30;
}
/** Level shift: elite +1 (or +2 if level ≤ 0), weak 1 (or 2 if level is 1). */
export function adjustedLevel(
baseLevel: number,
adjustment: CreatureAdjustment,
): number {
if (adjustment === "elite") {
return baseLevel <= 0 ? baseLevel + 2 : baseLevel + 1;
}
return baseLevel === 1 ? baseLevel - 2 : baseLevel - 1;
}
/** Signed HP delta for a given base level and adjustment. */
export function hpDelta(
baseLevel: number,
adjustment: CreatureAdjustment,
): number {
const delta = hpBracketDelta(baseLevel);
return adjustment === "elite" ? delta : -delta;
}
/** AC delta: +2 for elite, 2 for weak. */
export function acDelta(adjustment: CreatureAdjustment): number {
return adjustment === "elite" ? 2 : -2;
}
/** Generic ±2 modifier delta. Used for saves, Perception, attacks, damage. */
export function modDelta(adjustment: CreatureAdjustment): number {
return adjustment === "elite" ? 2 : -2;
}
const ATTACK_BONUS_RE = /^([+-])(\d+)/;
const MAP_RE = /\[([+-]\d+)\/([+-]\d+)\]/g;
const DAMAGE_BONUS_RE = /(\d+d\d+)([+-])(\d+)/g;
/**
* Adjust attack bonus in a formatted attack string.
* "+15 (agile), 2d12+7 piercing plus Grab" → "+17 (agile), 2d12+9 piercing plus Grab"
*/
function adjustAttackText(text: string, delta: number): string {
// Adjust leading attack bonus: "+15" → "+17"
let result = text.replace(ATTACK_BONUS_RE, (_, sign, num) => {
const adjusted = (sign === "+" ? 1 : -1) * Number(num) + delta;
return adjusted >= 0 ? `+${adjusted}` : `${adjusted}`;
});
// Adjust MAP values in brackets: "[+10/+5]" → "[+12/+7]"
result = result.replace(MAP_RE, (_, m1, m2) => {
const a1 = Number(m1) + delta;
const a2 = Number(m2) + delta;
const f = (n: number) => (n >= 0 ? `+${n}` : `${n}`);
return `[${f(a1)}/${f(a2)}]`;
});
// Adjust damage bonus in "NdN+N type" patterns
result = result.replace(DAMAGE_BONUS_RE, (_, dice, sign, num) => {
const current = (sign === "+" ? 1 : -1) * Number(num);
const adjusted = current + delta;
if (adjusted === 0) return dice as string;
return adjusted > 0 ? `${dice}+${adjusted}` : `${dice}${adjusted}`;
});
return result;
}
function adjustTraitBlock(block: TraitBlock, delta: number): TraitBlock {
return {
...block,
segments: block.segments.map(
(seg): TraitSegment =>
seg.type === "text"
? { type: "text", value: adjustAttackText(seg.value, delta) }
: seg,
),
};
}
/**
* Apply a weak or elite adjustment to a full PF2e creature.
* Returns a new Pf2eCreature with all numeric stats adjusted.
*/
export function applyPf2eAdjustment(
creature: Pf2eCreature,
adjustment: CreatureAdjustment,
): Pf2eCreature {
const d = modDelta(adjustment);
return {
...creature,
level: adjustedLevel(creature.level, adjustment),
ac: creature.ac + d,
hp: creature.hp + hpDelta(creature.level, adjustment),
perception: creature.perception + d,
saveFort: creature.saveFort + d,
saveRef: creature.saveRef + d,
saveWill: creature.saveWill + d,
attacks: creature.attacks?.map((a) => adjustTraitBlock(a, d)),
};
}

View File

@@ -0,0 +1,118 @@
/**
* PF2e Recall Knowledge DC calculation and type-to-skill mapping.
*
* DC is derived from creature level using the standard DC-by-level table
* (Player Core / GM Core), adjusted for rarity.
*/
/** Standard DC-by-level table from PF2e GM Core. Index = level + 1 (level -1 → index 0). */
const DC_BY_LEVEL: readonly number[] = [
13, // level -1
14, // level 0
15, // level 1
16, // level 2
18, // level 3
19, // level 4
20, // level 5
22, // level 6
23, // level 7
24, // level 8
26, // level 9
27, // level 10
28, // level 11
30, // level 12
31, // level 13
32, // level 14
34, // level 15
35, // level 16
36, // level 17
38, // level 18
39, // level 19
40, // level 20
42, // level 21
44, // level 22
46, // level 23
48, // level 24
50, // level 25
];
const RARITY_ADJUSTMENT: Readonly<Record<string, number>> = {
uncommon: 2,
rare: 5,
unique: 10,
};
/**
* Mapping from PF2e creature type traits to the skill(s) used for
* Recall Knowledge. Types that map to multiple skills list all of them.
*/
const TYPE_TO_SKILLS: Readonly<Record<string, readonly string[]>> = {
aberration: ["Occultism"],
animal: ["Nature"],
astral: ["Occultism"],
beast: ["Arcana", "Nature"],
celestial: ["Religion"],
construct: ["Arcana", "Crafting"],
dragon: ["Arcana"],
dream: ["Occultism"],
elemental: ["Arcana", "Nature"],
ethereal: ["Occultism"],
fey: ["Nature"],
fiend: ["Religion"],
fungus: ["Nature"],
giant: ["Society"],
humanoid: ["Society"],
monitor: ["Religion"],
ooze: ["Occultism"],
plant: ["Nature"],
undead: ["Religion"],
};
export interface RecallKnowledge {
readonly dc: number;
readonly type: string;
readonly skills: readonly string[];
}
/**
* Calculate Recall Knowledge DC, type, and skill(s) for a PF2e creature.
*
* Returns `null` when no recognized type trait is found in the creature's
* traits array, indicating the Recall Knowledge line should be omitted.
*/
export function recallKnowledge(
level: number,
traits: readonly string[],
): RecallKnowledge | null {
// Find the first type trait that maps to a skill
let matchedType: string | undefined;
let skills: readonly string[] | undefined;
for (const trait of traits) {
const lower = trait.toLowerCase();
const mapped = TYPE_TO_SKILLS[lower];
if (mapped) {
matchedType = trait;
skills = mapped;
break;
}
}
if (!matchedType || !skills) return null;
// Calculate DC from level
const clampedIndex = Math.max(0, Math.min(level + 1, DC_BY_LEVEL.length - 1));
let dc = DC_BY_LEVEL[clampedIndex];
// Apply rarity adjustment (rarity traits are included in the traits array
// for non-common creatures by the normalization pipeline)
for (const trait of traits) {
const adjustment = RARITY_ADJUSTMENT[trait.toLowerCase()];
if (adjustment) {
dc += adjustment;
break;
}
}
return { dc, type: matchedType, skills };
}

View File

@@ -1,4 +1,4 @@
import type { ConditionId } from "./conditions.js"; import type { ConditionEntry, ConditionId } from "./conditions.js";
import { VALID_CONDITION_IDS } from "./conditions.js"; import { VALID_CONDITION_IDS } from "./conditions.js";
import { creatureId } from "./creature-types.js"; import { creatureId } from "./creature-types.js";
import { VALID_CR_VALUES } from "./encounter-difficulty.js"; import { VALID_CR_VALUES } from "./encounter-difficulty.js";
@@ -16,13 +16,30 @@ function validateAc(value: unknown): number | undefined {
: undefined; : undefined;
} }
function validateConditions(value: unknown): ConditionId[] | undefined { function validateConditions(value: unknown): ConditionEntry[] | undefined {
if (!Array.isArray(value)) return undefined; if (!Array.isArray(value)) return undefined;
const valid = value.filter( const entries: ConditionEntry[] = [];
(v): v is ConditionId => for (const item of value) {
typeof v === "string" && VALID_CONDITION_IDS.has(v), if (typeof item === "string" && VALID_CONDITION_IDS.has(item)) {
); entries.push({ id: item as ConditionId });
return valid.length > 0 ? valid : undefined; } else if (
typeof item === "object" &&
item !== null &&
typeof (item as Record<string, unknown>).id === "string" &&
VALID_CONDITION_IDS.has((item as Record<string, unknown>).id as string)
) {
const id = (item as Record<string, unknown>).id as ConditionId;
const rawValue = (item as Record<string, unknown>).value;
const entry: ConditionEntry =
typeof rawValue === "number" &&
Number.isInteger(rawValue) &&
rawValue > 0
? { id, value: rawValue }
: { id };
entries.push(entry);
}
}
return entries.length > 0 ? entries : undefined;
} }
function validateHp( function validateHp(
@@ -76,6 +93,7 @@ function validateCr(value: unknown): string | undefined {
: undefined; : undefined;
} }
const VALID_ADJUSTMENTS = new Set(["weak", "elite"]);
const VALID_SIDES = new Set(["party", "enemy"]); const VALID_SIDES = new Set(["party", "enemy"]);
function validateSide(value: unknown): "party" | "enemy" | undefined { function validateSide(value: unknown): "party" | "enemy" | undefined {
@@ -93,6 +111,10 @@ function parseOptionalFields(entry: Record<string, unknown>) {
creatureId: validateNonEmptyString(entry.creatureId) creatureId: validateNonEmptyString(entry.creatureId)
? creatureId(entry.creatureId as string) ? creatureId(entry.creatureId as string)
: undefined, : undefined,
creatureAdjustment: validateSetMember(
entry.creatureAdjustment,
VALID_ADJUSTMENTS,
) as "weak" | "elite" | undefined,
cr: validateCr(entry.cr), cr: validateCr(entry.cr),
side: validateSide(entry.side), side: validateSide(entry.side),
color: validateSetMember(entry.color, VALID_PLAYER_COLORS), color: validateSetMember(entry.color, VALID_PLAYER_COLORS),

View File

@@ -1 +1 @@
export type RulesEdition = "5e" | "5.5e"; export type RulesEdition = "5e" | "5.5e" | "pf2e";

View File

@@ -1,4 +1,4 @@
import type { ConditionId } from "./conditions.js"; import type { ConditionEntry, ConditionId } from "./conditions.js";
import { CONDITION_DEFINITIONS, VALID_CONDITION_IDS } from "./conditions.js"; import { CONDITION_DEFINITIONS, VALID_CONDITION_IDS } from "./conditions.js";
import type { DomainEvent } from "./events.js"; import type { DomainEvent } from "./events.js";
import { import {
@@ -14,11 +14,13 @@ export interface ToggleConditionSuccess {
readonly events: DomainEvent[]; readonly events: DomainEvent[];
} }
export function toggleCondition( function sortByDefinitionOrder(entries: ConditionEntry[]): ConditionEntry[] {
encounter: Encounter, const order = CONDITION_DEFINITIONS.map((d) => d.id);
combatantId: CombatantId, entries.sort((a, b) => order.indexOf(a.id) - order.indexOf(b.id));
conditionId: ConditionId, return entries;
): ToggleConditionSuccess | DomainError { }
function validateConditionId(conditionId: ConditionId): DomainError | null {
if (!VALID_CONDITION_IDS.has(conditionId)) { if (!VALID_CONDITION_IDS.has(conditionId)) {
return { return {
kind: "domain-error", kind: "domain-error",
@@ -26,38 +28,169 @@ export function toggleCondition(
message: `Unknown condition "${conditionId}"`, message: `Unknown condition "${conditionId}"`,
}; };
} }
return null;
}
function applyConditions(
encounter: Encounter,
combatantId: CombatantId,
newConditions: readonly ConditionEntry[] | undefined,
): Encounter {
return {
combatants: encounter.combatants.map((c) =>
c.id === combatantId ? { ...c, conditions: newConditions } : c,
),
activeIndex: encounter.activeIndex,
roundNumber: encounter.roundNumber,
};
}
export function toggleCondition(
encounter: Encounter,
combatantId: CombatantId,
conditionId: ConditionId,
): ToggleConditionSuccess | DomainError {
const err = validateConditionId(conditionId);
if (err) return err;
const found = findCombatant(encounter, combatantId); const found = findCombatant(encounter, combatantId);
if (isDomainError(found)) return found; if (isDomainError(found)) return found;
const { combatant: target } = found; const { combatant: target } = found;
const current = target.conditions ?? []; const current = target.conditions ?? [];
const isActive = current.includes(conditionId); const isActive = current.some((c) => c.id === conditionId);
let newConditions: readonly ConditionId[] | undefined; let newConditions: readonly ConditionEntry[] | undefined;
let event: DomainEvent; let event: DomainEvent;
if (isActive) { if (isActive) {
const filtered = current.filter((c) => c !== conditionId); const filtered = current.filter((c) => c.id !== conditionId);
newConditions = filtered.length > 0 ? filtered : undefined; newConditions = filtered.length > 0 ? filtered : undefined;
event = { type: "ConditionRemoved", combatantId, condition: conditionId }; event = { type: "ConditionRemoved", combatantId, condition: conditionId };
} else { } else {
const added = [...current, conditionId]; const added = sortByDefinitionOrder([...current, { id: conditionId }]);
const order = CONDITION_DEFINITIONS.map((d) => d.id);
added.sort((a, b) => order.indexOf(a) - order.indexOf(b));
newConditions = added; newConditions = added;
event = { type: "ConditionAdded", combatantId, condition: conditionId }; event = { type: "ConditionAdded", combatantId, condition: conditionId };
} }
const updatedCombatants = encounter.combatants.map((c) =>
c.id === combatantId ? { ...c, conditions: newConditions } : c,
);
return { return {
encounter: { encounter: applyConditions(encounter, combatantId, newConditions),
combatants: updatedCombatants,
activeIndex: encounter.activeIndex,
roundNumber: encounter.roundNumber,
},
events: [event], events: [event],
}; };
} }
export function setConditionValue(
encounter: Encounter,
combatantId: CombatantId,
conditionId: ConditionId,
value: number,
): ToggleConditionSuccess | DomainError {
const err = validateConditionId(conditionId);
if (err) return err;
const found = findCombatant(encounter, combatantId);
if (isDomainError(found)) return found;
const { combatant: target } = found;
const current = target.conditions ?? [];
const def = CONDITION_DEFINITIONS.find((d) => d.id === conditionId);
const clampedValue =
def?.maxValue === undefined ? value : Math.min(value, def.maxValue);
if (clampedValue <= 0) {
const filtered = current.filter((c) => c.id !== conditionId);
const newConditions = filtered.length > 0 ? filtered : undefined;
return {
encounter: applyConditions(encounter, combatantId, newConditions),
events: [
{ type: "ConditionRemoved", combatantId, condition: conditionId },
],
};
}
const existing = current.find((c) => c.id === conditionId);
if (existing) {
const updated = current.map((c) =>
c.id === conditionId ? { ...c, value: clampedValue } : c,
);
return {
encounter: applyConditions(encounter, combatantId, updated),
events: [
{
type: "ConditionAdded",
combatantId,
condition: conditionId,
value: clampedValue,
},
],
};
}
const added = sortByDefinitionOrder([
...current,
{ id: conditionId, value: clampedValue },
]);
return {
encounter: applyConditions(encounter, combatantId, added),
events: [
{
type: "ConditionAdded",
combatantId,
condition: conditionId,
value: clampedValue,
},
],
};
}
export function decrementCondition(
encounter: Encounter,
combatantId: CombatantId,
conditionId: ConditionId,
): ToggleConditionSuccess | DomainError {
const err = validateConditionId(conditionId);
if (err) return err;
const found = findCombatant(encounter, combatantId);
if (isDomainError(found)) return found;
const { combatant: target } = found;
const current = target.conditions ?? [];
const existing = current.find((c) => c.id === conditionId);
if (!existing) {
return {
kind: "domain-error",
code: "condition-not-active",
message: `Condition "${conditionId}" is not active`,
};
}
const newValue = (existing.value ?? 1) - 1;
if (newValue <= 0) {
const filtered = current.filter((c) => c.id !== conditionId);
return {
encounter: applyConditions(
encounter,
combatantId,
filtered.length > 0 ? filtered : undefined,
),
events: [
{ type: "ConditionRemoved", combatantId, condition: conditionId },
],
};
}
const updated = current.map((c) =>
c.id === conditionId ? { ...c, value: newValue } : c,
);
return {
encounter: applyConditions(encounter, combatantId, updated),
events: [
{
type: "ConditionAdded",
combatantId,
condition: conditionId,
value: newValue,
},
],
};
}

View File

@@ -5,7 +5,7 @@ export function combatantId(id: string): CombatantId {
return id as CombatantId; return id as CombatantId;
} }
import type { ConditionId } from "./conditions.js"; import type { ConditionEntry } from "./conditions.js";
import type { CreatureId } from "./creature-types.js"; import type { CreatureId } from "./creature-types.js";
import type { PlayerCharacterId } from "./player-character-types.js"; import type { PlayerCharacterId } from "./player-character-types.js";
@@ -17,9 +17,10 @@ export interface Combatant {
readonly currentHp?: number; readonly currentHp?: number;
readonly tempHp?: number; readonly tempHp?: number;
readonly ac?: number; readonly ac?: number;
readonly conditions?: readonly ConditionId[]; readonly conditions?: readonly ConditionEntry[];
readonly isConcentrating?: boolean; readonly isConcentrating?: boolean;
readonly creatureId?: CreatureId; readonly creatureId?: CreatureId;
readonly creatureAdjustment?: "weak" | "elite";
readonly cr?: string; readonly cr?: string;
readonly side?: "party" | "enemy"; readonly side?: "party" | "enemy";
readonly color?: string; readonly color?: string;

218
pnpm-lock.yaml generated
View File

@@ -17,7 +17,7 @@ importers:
version: 2.4.8 version: 2.4.8
'@vitest/coverage-v8': '@vitest/coverage-v8':
specifier: ^4.1.0 specifier: ^4.1.0
version: 4.1.0(vitest@4.1.0(@types/node@25.3.3)(jsdom@29.0.1)(vite@8.0.1(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3))) version: 4.1.0(vitest@4.1.0(@types/node@25.3.3)(jsdom@29.0.1)(vite@8.0.5(@emnapi/core@1.8.1)(@emnapi/runtime@1.8.1)(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3)))
jscpd: jscpd:
specifier: ^4.0.8 specifier: ^4.0.8
version: 4.0.8 version: 4.0.8
@@ -41,7 +41,7 @@ importers:
version: 5.9.3 version: 5.9.3
vitest: vitest:
specifier: ^4.1.0 specifier: ^4.1.0
version: 4.1.0(@types/node@25.3.3)(jsdom@29.0.1)(vite@8.0.1(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3)) version: 4.1.0(@types/node@25.3.3)(jsdom@29.0.1)(vite@8.0.5(@emnapi/core@1.8.1)(@emnapi/runtime@1.8.1)(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3))
apps/web: apps/web:
dependencies: dependencies:
@@ -75,7 +75,7 @@ importers:
devDependencies: devDependencies:
'@tailwindcss/vite': '@tailwindcss/vite':
specifier: ^4.2.2 specifier: ^4.2.2
version: 4.2.2(vite@8.0.1(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3)) version: 4.2.2(vite@8.0.5(@emnapi/core@1.8.1)(@emnapi/runtime@1.8.1)(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3))
'@testing-library/jest-dom': '@testing-library/jest-dom':
specifier: ^6.9.1 specifier: ^6.9.1
version: 6.9.1 version: 6.9.1
@@ -93,7 +93,7 @@ importers:
version: 19.2.3(@types/react@19.2.14) version: 19.2.3(@types/react@19.2.14)
'@vitejs/plugin-react': '@vitejs/plugin-react':
specifier: ^6.0.1 specifier: ^6.0.1
version: 6.0.1(vite@8.0.1(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3)) version: 6.0.1(vite@8.0.5(@emnapi/core@1.8.1)(@emnapi/runtime@1.8.1)(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3))
jsdom: jsdom:
specifier: ^29.0.1 specifier: ^29.0.1
version: 29.0.1 version: 29.0.1
@@ -101,8 +101,8 @@ importers:
specifier: ^4.2.2 specifier: ^4.2.2
version: 4.2.2 version: 4.2.2
vite: vite:
specifier: ^8.0.1 specifier: ^8.0.5
version: 8.0.1(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3) version: 8.0.5(@emnapi/core@1.8.1)(@emnapi/runtime@1.8.1)(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3)
packages/application: packages/application:
dependencies: dependencies:
@@ -162,6 +162,10 @@ packages:
resolution: {integrity: sha512-05WQkdpL9COIMz4LjTxGpPNCdlpyimKppYNoJ5Di5EUObifl8t4tuLuUBBZEpoLYOmfvIWrsp9fCl0HoPRVTdA==} resolution: {integrity: sha512-05WQkdpL9COIMz4LjTxGpPNCdlpyimKppYNoJ5Di5EUObifl8t4tuLuUBBZEpoLYOmfvIWrsp9fCl0HoPRVTdA==}
engines: {node: '>=6.9.0'} engines: {node: '>=6.9.0'}
'@babel/runtime@7.29.2':
resolution: {integrity: sha512-JiDShH45zKHWyGe4ZNVRrCjBz8Nh9TMmZG1kh4QTK8hCBTWBi8Da+i7s1fJw7/lYpM4ccepSNfqzZ/QvABBi5g==}
engines: {node: '>=6.9.0'}
'@babel/types@7.29.0': '@babel/types@7.29.0':
resolution: {integrity: sha512-LwdZHpScM4Qz8Xw2iKSzS+cfglZzJGvofQICy7W7v4caru4EaAmyUuO6BGrbyQ2mYV11W0U8j5mBhd14dd3B0A==} resolution: {integrity: sha512-LwdZHpScM4Qz8Xw2iKSzS+cfglZzJGvofQICy7W7v4caru4EaAmyUuO6BGrbyQ2mYV11W0U8j5mBhd14dd3B0A==}
engines: {node: '>=6.9.0'} engines: {node: '>=6.9.0'}
@@ -327,6 +331,12 @@ packages:
'@napi-rs/wasm-runtime@1.1.1': '@napi-rs/wasm-runtime@1.1.1':
resolution: {integrity: sha512-p64ah1M1ld8xjWv3qbvFwHiFVWrq1yFvV4f7w+mzaqiR4IlSgkqhcRdHwsGgomwzBH51sRY4NEowLxnaBjcW/A==} resolution: {integrity: sha512-p64ah1M1ld8xjWv3qbvFwHiFVWrq1yFvV4f7w+mzaqiR4IlSgkqhcRdHwsGgomwzBH51sRY4NEowLxnaBjcW/A==}
'@napi-rs/wasm-runtime@1.1.2':
resolution: {integrity: sha512-sNXv5oLJ7ob93xkZ1XnxisYhGYXfaG9f65/ZgYuAu3qt7b3NadcOEhLvx28hv31PgX8SZJRYrAIPQilQmFpLVw==}
peerDependencies:
'@emnapi/core': ^1.7.1
'@emnapi/runtime': ^1.7.1
'@nodelib/fs.scandir@2.1.5': '@nodelib/fs.scandir@2.1.5':
resolution: {integrity: sha512-vq24Bq3ym5HEQm2NKCr3yXDwjc7vTsEThRDnkp2DK9p1uqLR+DHurm/NOTo0KG7HYHU7eppKZj3MyqYuMBf62g==} resolution: {integrity: sha512-vq24Bq3ym5HEQm2NKCr3yXDwjc7vTsEThRDnkp2DK9p1uqLR+DHurm/NOTo0KG7HYHU7eppKZj3MyqYuMBf62g==}
engines: {node: '>= 8'} engines: {node: '>= 8'}
@@ -339,8 +349,8 @@ packages:
resolution: {integrity: sha512-oGB+UxlgWcgQkgwo8GcEGwemoTFt3FIO9ababBmaGwXIoBKZ+GTy0pP185beGg7Llih/NSHSV2XAs1lnznocSg==} resolution: {integrity: sha512-oGB+UxlgWcgQkgwo8GcEGwemoTFt3FIO9ababBmaGwXIoBKZ+GTy0pP185beGg7Llih/NSHSV2XAs1lnznocSg==}
engines: {node: '>= 8'} engines: {node: '>= 8'}
'@oxc-project/types@0.120.0': '@oxc-project/types@0.122.0':
resolution: {integrity: sha512-k1YNu55DuvAip/MGE1FTsIuU3FUCn6v/ujG9V7Nq5Df/kX2CWb13hhwD0lmJGMGqE+bE1MXvv9SZVnMzEXlWcg==} resolution: {integrity: sha512-oLAl5kBpV4w69UtFZ9xqcmTi+GENWOcPF7FCrczTiBbmC0ibXxCwyvZGbO39rCVEuLGAZM84DH0pUIyyv/YJzA==}
'@oxc-resolver/binding-android-arm-eabi@11.19.1': '@oxc-resolver/binding-android-arm-eabi@11.19.1':
resolution: {integrity: sha512-aUs47y+xyXHUKlbhqHUjBABjvycq6YSD7bpxSW7vplUmdzAlJ93yXY6ZR0c1o1x5A/QKbENCvs3+NlY8IpIVzg==} resolution: {integrity: sha512-aUs47y+xyXHUKlbhqHUjBABjvycq6YSD7bpxSW7vplUmdzAlJ93yXY6ZR0c1o1x5A/QKbENCvs3+NlY8IpIVzg==}
@@ -602,103 +612,103 @@ packages:
cpu: [x64] cpu: [x64]
os: [win32] os: [win32]
'@rolldown/binding-android-arm64@1.0.0-rc.10': '@rolldown/binding-android-arm64@1.0.0-rc.12':
resolution: {integrity: sha512-jOHxwXhxmFKuXztiu1ORieJeTbx5vrTkcOkkkn2d35726+iwhrY1w/+nYY/AGgF12thg33qC3R1LMBF5tHTZHg==} resolution: {integrity: sha512-pv1y2Fv0JybcykuiiD3qBOBdz6RteYojRFY1d+b95WVuzx211CRh+ytI/+9iVyWQ6koTh5dawe4S/yRfOFjgaA==}
engines: {node: ^20.19.0 || >=22.12.0} engines: {node: ^20.19.0 || >=22.12.0}
cpu: [arm64] cpu: [arm64]
os: [android] os: [android]
'@rolldown/binding-darwin-arm64@1.0.0-rc.10': '@rolldown/binding-darwin-arm64@1.0.0-rc.12':
resolution: {integrity: sha512-gED05Teg/vtTZbIJBc4VNMAxAFDUPkuO/rAIyyxZjTj1a1/s6z5TII/5yMGZ0uLRCifEtwUQn8OlYzuYc0m70w==} resolution: {integrity: sha512-cFYr6zTG/3PXXF3pUO+umXxt1wkRK/0AYT8lDwuqvRC+LuKYWSAQAQZjCWDQpAH172ZV6ieYrNnFzVVcnSflAg==}
engines: {node: ^20.19.0 || >=22.12.0} engines: {node: ^20.19.0 || >=22.12.0}
cpu: [arm64] cpu: [arm64]
os: [darwin] os: [darwin]
'@rolldown/binding-darwin-x64@1.0.0-rc.10': '@rolldown/binding-darwin-x64@1.0.0-rc.12':
resolution: {integrity: sha512-rI15NcM1mA48lqrIxVkHfAqcyFLcQwyXWThy+BQ5+mkKKPvSO26ir+ZDp36AgYoYVkqvMcdS8zOE6SeBsR9e8A==} resolution: {integrity: sha512-ZCsYknnHzeXYps0lGBz8JrF37GpE9bFVefrlmDrAQhOEi4IOIlcoU1+FwHEtyXGx2VkYAvhu7dyBf75EJQffBw==}
engines: {node: ^20.19.0 || >=22.12.0} engines: {node: ^20.19.0 || >=22.12.0}
cpu: [x64] cpu: [x64]
os: [darwin] os: [darwin]
'@rolldown/binding-freebsd-x64@1.0.0-rc.10': '@rolldown/binding-freebsd-x64@1.0.0-rc.12':
resolution: {integrity: sha512-XZRXHdTa+4ME1MuDVp021+doQ+z6Ei4CCFmNc5/sKbqb8YmkiJdj8QKlV3rCI0AJtAeSB5n0WGPuJWNL9p/L2w==} resolution: {integrity: sha512-dMLeprcVsyJsKolRXyoTH3NL6qtsT0Y2xeuEA8WQJquWFXkEC4bcu1rLZZSnZRMtAqwtrF/Ib9Ddtpa/Gkge9Q==}
engines: {node: ^20.19.0 || >=22.12.0} engines: {node: ^20.19.0 || >=22.12.0}
cpu: [x64] cpu: [x64]
os: [freebsd] os: [freebsd]
'@rolldown/binding-linux-arm-gnueabihf@1.0.0-rc.10': '@rolldown/binding-linux-arm-gnueabihf@1.0.0-rc.12':
resolution: {integrity: sha512-R0SQMRluISSLzFE20sPWYHVmJdDQnRyc/FzSCN72BqQmh2SOZUFG+N3/vBZpR4C6WpEUVYJLrYUXaj43sJsNLA==} resolution: {integrity: sha512-YqWjAgGC/9M1lz3GR1r1rP79nMgo3mQiiA+Hfo+pvKFK1fAJ1bCi0ZQVh8noOqNacuY1qIcfyVfP6HoyBRZ85Q==}
engines: {node: ^20.19.0 || >=22.12.0} engines: {node: ^20.19.0 || >=22.12.0}
cpu: [arm] cpu: [arm]
os: [linux] os: [linux]
'@rolldown/binding-linux-arm64-gnu@1.0.0-rc.10': '@rolldown/binding-linux-arm64-gnu@1.0.0-rc.12':
resolution: {integrity: sha512-Y1reMrV/o+cwpduYhJuOE3OMKx32RMYCidf14y+HssARRmhDuWXJ4yVguDg2R/8SyyGNo+auzz64LnPK9Hq6jg==} resolution: {integrity: sha512-/I5AS4cIroLpslsmzXfwbe5OmWvSsrFuEw3mwvbQ1kDxJ822hFHIx+vsN/TAzNVyepI/j/GSzrtCIwQPeKCLIg==}
engines: {node: ^20.19.0 || >=22.12.0} engines: {node: ^20.19.0 || >=22.12.0}
cpu: [arm64] cpu: [arm64]
os: [linux] os: [linux]
libc: [glibc] libc: [glibc]
'@rolldown/binding-linux-arm64-musl@1.0.0-rc.10': '@rolldown/binding-linux-arm64-musl@1.0.0-rc.12':
resolution: {integrity: sha512-vELN+HNb2IzuzSBUOD4NHmP9yrGwl1DVM29wlQvx1OLSclL0NgVWnVDKl/8tEks79EFek/kebQKnNJkIAA4W2g==} resolution: {integrity: sha512-V6/wZztnBqlx5hJQqNWwFdxIKN0m38p8Jas+VoSfgH54HSj9tKTt1dZvG6JRHcjh6D7TvrJPWFGaY9UBVOaWPw==}
engines: {node: ^20.19.0 || >=22.12.0} engines: {node: ^20.19.0 || >=22.12.0}
cpu: [arm64] cpu: [arm64]
os: [linux] os: [linux]
libc: [musl] libc: [musl]
'@rolldown/binding-linux-ppc64-gnu@1.0.0-rc.10': '@rolldown/binding-linux-ppc64-gnu@1.0.0-rc.12':
resolution: {integrity: sha512-ZqrufYTgzxbHwpqOjzSsb0UV/aV2TFIY5rP8HdsiPTv/CuAgCRjM6s9cYFwQ4CNH+hf9Y4erHW1GjZuZ7WoI7w==} resolution: {integrity: sha512-AP3E9BpcUYliZCxa3w5Kwj9OtEVDYK6sVoUzy4vTOJsjPOgdaJZKFmN4oOlX0Wp0RPV2ETfmIra9x1xuayFB7g==}
engines: {node: ^20.19.0 || >=22.12.0} engines: {node: ^20.19.0 || >=22.12.0}
cpu: [ppc64] cpu: [ppc64]
os: [linux] os: [linux]
libc: [glibc] libc: [glibc]
'@rolldown/binding-linux-s390x-gnu@1.0.0-rc.10': '@rolldown/binding-linux-s390x-gnu@1.0.0-rc.12':
resolution: {integrity: sha512-gSlmVS1FZJSRicA6IyjoRoKAFK7IIHBs7xJuHRSmjImqk3mPPWbR7RhbnfH2G6bcmMEllCt2vQ/7u9e6bBnByg==} resolution: {integrity: sha512-nWwpvUSPkoFmZo0kQazZYOrT7J5DGOJ/+QHHzjvNlooDZED8oH82Yg67HvehPPLAg5fUff7TfWFHQS8IV1n3og==}
engines: {node: ^20.19.0 || >=22.12.0} engines: {node: ^20.19.0 || >=22.12.0}
cpu: [s390x] cpu: [s390x]
os: [linux] os: [linux]
libc: [glibc] libc: [glibc]
'@rolldown/binding-linux-x64-gnu@1.0.0-rc.10': '@rolldown/binding-linux-x64-gnu@1.0.0-rc.12':
resolution: {integrity: sha512-eOCKUpluKgfObT2pHjztnaWEIbUabWzk3qPZ5PuacuPmr4+JtQG4k2vGTY0H15edaTnicgU428XW/IH6AimcQw==} resolution: {integrity: sha512-RNrafz5bcwRy+O9e6P8Z/OCAJW/A+qtBczIqVYwTs14pf4iV1/+eKEjdOUta93q2TsT/FI0XYDP3TCky38LMAg==}
engines: {node: ^20.19.0 || >=22.12.0} engines: {node: ^20.19.0 || >=22.12.0}
cpu: [x64] cpu: [x64]
os: [linux] os: [linux]
libc: [glibc] libc: [glibc]
'@rolldown/binding-linux-x64-musl@1.0.0-rc.10': '@rolldown/binding-linux-x64-musl@1.0.0-rc.12':
resolution: {integrity: sha512-Xdf2jQbfQowJnLcgYfD/m0Uu0Qj5OdxKallD78/IPPfzaiaI4KRAwZzHcKQ4ig1gtg1SuzC7jovNiM2TzQsBXA==} resolution: {integrity: sha512-Jpw/0iwoKWx3LJ2rc1yjFrj+T7iHZn2JDg1Yny1ma0luviFS4mhAIcd1LFNxK3EYu3DHWCps0ydXQ5i/rrJ2ig==}
engines: {node: ^20.19.0 || >=22.12.0} engines: {node: ^20.19.0 || >=22.12.0}
cpu: [x64] cpu: [x64]
os: [linux] os: [linux]
libc: [musl] libc: [musl]
'@rolldown/binding-openharmony-arm64@1.0.0-rc.10': '@rolldown/binding-openharmony-arm64@1.0.0-rc.12':
resolution: {integrity: sha512-o1hYe8hLi1EY6jgPFyxQgQ1wcycX+qz8eEbVmot2hFkgUzPxy9+kF0u0NIQBeDq+Mko47AkaFFaChcvZa9UX9Q==} resolution: {integrity: sha512-vRugONE4yMfVn0+7lUKdKvN4D5YusEiPilaoO2sgUWpCvrncvWgPMzK00ZFFJuiPgLwgFNP5eSiUlv2tfc+lpA==}
engines: {node: ^20.19.0 || >=22.12.0} engines: {node: ^20.19.0 || >=22.12.0}
cpu: [arm64] cpu: [arm64]
os: [openharmony] os: [openharmony]
'@rolldown/binding-wasm32-wasi@1.0.0-rc.10': '@rolldown/binding-wasm32-wasi@1.0.0-rc.12':
resolution: {integrity: sha512-Ugv9o7qYJudqQO5Y5y2N2SOo6S4WiqiNOpuQyoPInnhVzCY+wi/GHltcLHypG9DEUYMB0iTB/huJrpadiAcNcA==} resolution: {integrity: sha512-ykGiLr/6kkiHc0XnBfmFJuCjr5ZYKKofkx+chJWDjitX+KsJuAmrzWhwyOMSHzPhzOHOy7u9HlFoa5MoAOJ/Zg==}
engines: {node: '>=14.0.0'} engines: {node: '>=14.0.0'}
cpu: [wasm32] cpu: [wasm32]
'@rolldown/binding-win32-arm64-msvc@1.0.0-rc.10': '@rolldown/binding-win32-arm64-msvc@1.0.0-rc.12':
resolution: {integrity: sha512-7UODQb4fQUNT/vmgDZBl3XOBAIOutP5R3O/rkxg0aLfEGQ4opbCgU5vOw/scPe4xOqBwL9fw7/RP1vAMZ6QlAQ==} resolution: {integrity: sha512-5eOND4duWkwx1AzCxadcOrNeighiLwMInEADT0YM7xeEOOFcovWZCq8dadXgcRHSf3Ulh1kFo/qvzoFiCLOL1Q==}
engines: {node: ^20.19.0 || >=22.12.0} engines: {node: ^20.19.0 || >=22.12.0}
cpu: [arm64] cpu: [arm64]
os: [win32] os: [win32]
'@rolldown/binding-win32-x64-msvc@1.0.0-rc.10': '@rolldown/binding-win32-x64-msvc@1.0.0-rc.12':
resolution: {integrity: sha512-PYxKHMVHOb5NJuDL53vBUl1VwUjymDcYI6rzpIni0C9+9mTiJedvUxSk7/RPp7OOAm3v+EjgMu9bIy3N6b408w==} resolution: {integrity: sha512-PyqoipaswDLAZtot351MLhrlrh6lcZPo2LSYE+VDxbVk24LVKAGOuE4hb8xZQmrPAuEtTZW8E6D2zc5EUZX4Lw==}
engines: {node: ^20.19.0 || >=22.12.0} engines: {node: ^20.19.0 || >=22.12.0}
cpu: [x64] cpu: [x64]
os: [win32] os: [win32]
'@rolldown/pluginutils@1.0.0-rc.10': '@rolldown/pluginutils@1.0.0-rc.12':
resolution: {integrity: sha512-UkVDEFk1w3mveXeKgaTuYfKWtPbvgck1dT8TUG3bnccrH0XtLTuAyfCoks4Q/M5ZGToSVJTIQYCzy2g/atAOeg==} resolution: {integrity: sha512-HHMwmarRKvoFsJorqYlFeFRzXZqCt2ETQlEDOb9aqssrnVBB1/+xgTGtuTrIk5vzLNX1MjMtTf7W9z3tsSbrxw==}
'@rolldown/pluginutils@1.0.0-rc.7': '@rolldown/pluginutils@1.0.0-rc.7':
resolution: {integrity: sha512-qujRfC8sFVInYSPPMLQByRh7zhwkGFS4+tyMQ83srV1qrxL4g8E2tyxVVyxd0+8QeBM1mIk9KbWxkegRr76XzA==} resolution: {integrity: sha512-qujRfC8sFVInYSPPMLQByRh7zhwkGFS4+tyMQ83srV1qrxL4g8E2tyxVVyxd0+8QeBM1mIk9KbWxkegRr76XzA==}
@@ -1657,8 +1667,8 @@ packages:
resolution: {integrity: sha512-g6QUff04oZpHs0eG5p83rFLhHeV00ug/Yf9nZM6fLeUrPguBTkTQOdpAWWspMh55TZfVQDPaN3NQJfbVRAxdIw==} resolution: {integrity: sha512-g6QUff04oZpHs0eG5p83rFLhHeV00ug/Yf9nZM6fLeUrPguBTkTQOdpAWWspMh55TZfVQDPaN3NQJfbVRAxdIw==}
engines: {iojs: '>=1.0.0', node: '>=0.10.0'} engines: {iojs: '>=1.0.0', node: '>=0.10.0'}
rolldown@1.0.0-rc.10: rolldown@1.0.0-rc.12:
resolution: {integrity: sha512-q7j6vvarRFmKpgJUT8HCAUljkgzEp4LAhPlJUvQhA5LA1SUL36s5QCysMutErzL3EbNOZOkoziSx9iZC4FddKA==} resolution: {integrity: sha512-yP4USLIMYrwpPHEFB5JGH1uxhcslv6/hL0OyvTuY+3qlOSJvZ7ntYnoWpehBxufkgN0cvXxppuTu5hHa/zPh+A==}
engines: {node: ^20.19.0 || >=22.12.0} engines: {node: ^20.19.0 || >=22.12.0}
hasBin: true hasBin: true
@@ -1821,14 +1831,14 @@ packages:
resolution: {integrity: sha512-gptHNQghINnc/vTGIk0SOFGFNXw7JVrlRUtConJRlvaw6DuX0wO5Jeko9sWrMBhh+PsYAZ7oXAiOnf/UKogyiw==} resolution: {integrity: sha512-gptHNQghINnc/vTGIk0SOFGFNXw7JVrlRUtConJRlvaw6DuX0wO5Jeko9sWrMBhh+PsYAZ7oXAiOnf/UKogyiw==}
engines: {node: '>= 10.0.0'} engines: {node: '>= 10.0.0'}
vite@8.0.1: vite@8.0.5:
resolution: {integrity: sha512-wt+Z2qIhfFt85uiyRt5LPU4oVEJBXj8hZNWKeqFG4gRG/0RaRGJ7njQCwzFVjO+v4+Ipmf5CY7VdmZRAYYBPHw==} resolution: {integrity: sha512-nmu43Qvq9UopTRfMx2jOYW5l16pb3iDC1JH6yMuPkpVbzK0k+L7dfsEDH4jRgYFmsg0sTAqkojoZgzLMlwHsCQ==}
engines: {node: ^20.19.0 || >=22.12.0} engines: {node: ^20.19.0 || >=22.12.0}
hasBin: true hasBin: true
peerDependencies: peerDependencies:
'@types/node': ^20.19.0 || >=22.12.0 '@types/node': ^20.19.0 || >=22.12.0
'@vitejs/devtools': ^0.1.0 '@vitejs/devtools': ^0.1.0
esbuild: ^0.27.0 esbuild: ^0.27.0 || ^0.28.0
jiti: '>=1.21.0' jiti: '>=1.21.0'
less: ^4.0.0 less: ^4.0.0
sass: ^1.70.0 sass: ^1.70.0
@@ -2001,6 +2011,8 @@ snapshots:
'@babel/runtime@7.28.6': {} '@babel/runtime@7.28.6': {}
'@babel/runtime@7.29.2': {}
'@babel/types@7.29.0': '@babel/types@7.29.0':
dependencies: dependencies:
'@babel/helper-string-parser': 7.27.1 '@babel/helper-string-parser': 7.27.1
@@ -2158,6 +2170,13 @@ snapshots:
'@tybys/wasm-util': 0.10.1 '@tybys/wasm-util': 0.10.1
optional: true optional: true
'@napi-rs/wasm-runtime@1.1.2(@emnapi/core@1.8.1)(@emnapi/runtime@1.8.1)':
dependencies:
'@emnapi/core': 1.8.1
'@emnapi/runtime': 1.8.1
'@tybys/wasm-util': 0.10.1
optional: true
'@nodelib/fs.scandir@2.1.5': '@nodelib/fs.scandir@2.1.5':
dependencies: dependencies:
'@nodelib/fs.stat': 2.0.5 '@nodelib/fs.stat': 2.0.5
@@ -2170,7 +2189,7 @@ snapshots:
'@nodelib/fs.scandir': 2.1.5 '@nodelib/fs.scandir': 2.1.5
fastq: 1.20.1 fastq: 1.20.1
'@oxc-project/types@0.120.0': {} '@oxc-project/types@0.122.0': {}
'@oxc-resolver/binding-android-arm-eabi@11.19.1': '@oxc-resolver/binding-android-arm-eabi@11.19.1':
optional: true optional: true
@@ -2309,54 +2328,57 @@ snapshots:
'@oxlint/binding-win32-x64-msvc@1.56.0': '@oxlint/binding-win32-x64-msvc@1.56.0':
optional: true optional: true
'@rolldown/binding-android-arm64@1.0.0-rc.10': '@rolldown/binding-android-arm64@1.0.0-rc.12':
optional: true optional: true
'@rolldown/binding-darwin-arm64@1.0.0-rc.10': '@rolldown/binding-darwin-arm64@1.0.0-rc.12':
optional: true optional: true
'@rolldown/binding-darwin-x64@1.0.0-rc.10': '@rolldown/binding-darwin-x64@1.0.0-rc.12':
optional: true optional: true
'@rolldown/binding-freebsd-x64@1.0.0-rc.10': '@rolldown/binding-freebsd-x64@1.0.0-rc.12':
optional: true optional: true
'@rolldown/binding-linux-arm-gnueabihf@1.0.0-rc.10': '@rolldown/binding-linux-arm-gnueabihf@1.0.0-rc.12':
optional: true optional: true
'@rolldown/binding-linux-arm64-gnu@1.0.0-rc.10': '@rolldown/binding-linux-arm64-gnu@1.0.0-rc.12':
optional: true optional: true
'@rolldown/binding-linux-arm64-musl@1.0.0-rc.10': '@rolldown/binding-linux-arm64-musl@1.0.0-rc.12':
optional: true optional: true
'@rolldown/binding-linux-ppc64-gnu@1.0.0-rc.10': '@rolldown/binding-linux-ppc64-gnu@1.0.0-rc.12':
optional: true optional: true
'@rolldown/binding-linux-s390x-gnu@1.0.0-rc.10': '@rolldown/binding-linux-s390x-gnu@1.0.0-rc.12':
optional: true optional: true
'@rolldown/binding-linux-x64-gnu@1.0.0-rc.10': '@rolldown/binding-linux-x64-gnu@1.0.0-rc.12':
optional: true optional: true
'@rolldown/binding-linux-x64-musl@1.0.0-rc.10': '@rolldown/binding-linux-x64-musl@1.0.0-rc.12':
optional: true optional: true
'@rolldown/binding-openharmony-arm64@1.0.0-rc.10': '@rolldown/binding-openharmony-arm64@1.0.0-rc.12':
optional: true optional: true
'@rolldown/binding-wasm32-wasi@1.0.0-rc.10': '@rolldown/binding-wasm32-wasi@1.0.0-rc.12(@emnapi/core@1.8.1)(@emnapi/runtime@1.8.1)':
dependencies: dependencies:
'@napi-rs/wasm-runtime': 1.1.1 '@napi-rs/wasm-runtime': 1.1.2(@emnapi/core@1.8.1)(@emnapi/runtime@1.8.1)
transitivePeerDependencies:
- '@emnapi/core'
- '@emnapi/runtime'
optional: true optional: true
'@rolldown/binding-win32-arm64-msvc@1.0.0-rc.10': '@rolldown/binding-win32-arm64-msvc@1.0.0-rc.12':
optional: true optional: true
'@rolldown/binding-win32-x64-msvc@1.0.0-rc.10': '@rolldown/binding-win32-x64-msvc@1.0.0-rc.12':
optional: true optional: true
'@rolldown/pluginutils@1.0.0-rc.10': {} '@rolldown/pluginutils@1.0.0-rc.12': {}
'@rolldown/pluginutils@1.0.0-rc.7': {} '@rolldown/pluginutils@1.0.0-rc.7': {}
@@ -2423,17 +2445,17 @@ snapshots:
'@tailwindcss/oxide-win32-arm64-msvc': 4.2.2 '@tailwindcss/oxide-win32-arm64-msvc': 4.2.2
'@tailwindcss/oxide-win32-x64-msvc': 4.2.2 '@tailwindcss/oxide-win32-x64-msvc': 4.2.2
'@tailwindcss/vite@4.2.2(vite@8.0.1(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3))': '@tailwindcss/vite@4.2.2(vite@8.0.5(@emnapi/core@1.8.1)(@emnapi/runtime@1.8.1)(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3))':
dependencies: dependencies:
'@tailwindcss/node': 4.2.2 '@tailwindcss/node': 4.2.2
'@tailwindcss/oxide': 4.2.2 '@tailwindcss/oxide': 4.2.2
tailwindcss: 4.2.2 tailwindcss: 4.2.2
vite: 8.0.1(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3) vite: 8.0.5(@emnapi/core@1.8.1)(@emnapi/runtime@1.8.1)(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3)
'@testing-library/dom@10.4.1': '@testing-library/dom@10.4.1':
dependencies: dependencies:
'@babel/code-frame': 7.29.0 '@babel/code-frame': 7.29.0
'@babel/runtime': 7.28.6 '@babel/runtime': 7.29.2
'@types/aria-query': 5.0.4 '@types/aria-query': 5.0.4
aria-query: 5.3.0 aria-query: 5.3.0
dom-accessibility-api: 0.5.16 dom-accessibility-api: 0.5.16
@@ -2494,12 +2516,12 @@ snapshots:
'@types/sarif@2.1.7': {} '@types/sarif@2.1.7': {}
'@vitejs/plugin-react@6.0.1(vite@8.0.1(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3))': '@vitejs/plugin-react@6.0.1(vite@8.0.5(@emnapi/core@1.8.1)(@emnapi/runtime@1.8.1)(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3))':
dependencies: dependencies:
'@rolldown/pluginutils': 1.0.0-rc.7 '@rolldown/pluginutils': 1.0.0-rc.7
vite: 8.0.1(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3) vite: 8.0.5(@emnapi/core@1.8.1)(@emnapi/runtime@1.8.1)(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3)
'@vitest/coverage-v8@4.1.0(vitest@4.1.0(@types/node@25.3.3)(jsdom@29.0.1)(vite@8.0.1(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3)))': '@vitest/coverage-v8@4.1.0(vitest@4.1.0(@types/node@25.3.3)(jsdom@29.0.1)(vite@8.0.5(@emnapi/core@1.8.1)(@emnapi/runtime@1.8.1)(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3)))':
dependencies: dependencies:
'@bcoe/v8-coverage': 1.0.2 '@bcoe/v8-coverage': 1.0.2
'@vitest/utils': 4.1.0 '@vitest/utils': 4.1.0
@@ -2511,7 +2533,7 @@ snapshots:
obug: 2.1.1 obug: 2.1.1
std-env: 4.0.0 std-env: 4.0.0
tinyrainbow: 3.1.0 tinyrainbow: 3.1.0
vitest: 4.1.0(@types/node@25.3.3)(jsdom@29.0.1)(vite@8.0.1(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3)) vitest: 4.1.0(@types/node@25.3.3)(jsdom@29.0.1)(vite@8.0.5(@emnapi/core@1.8.1)(@emnapi/runtime@1.8.1)(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3))
'@vitest/expect@4.1.0': '@vitest/expect@4.1.0':
dependencies: dependencies:
@@ -2522,13 +2544,13 @@ snapshots:
chai: 6.2.2 chai: 6.2.2
tinyrainbow: 3.1.0 tinyrainbow: 3.1.0
'@vitest/mocker@4.1.0(vite@8.0.1(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3))': '@vitest/mocker@4.1.0(vite@8.0.5(@emnapi/core@1.8.1)(@emnapi/runtime@1.8.1)(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3))':
dependencies: dependencies:
'@vitest/spy': 4.1.0 '@vitest/spy': 4.1.0
estree-walker: 3.0.3 estree-walker: 3.0.3
magic-string: 0.30.21 magic-string: 0.30.21
optionalDependencies: optionalDependencies:
vite: 8.0.1(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3) vite: 8.0.5(@emnapi/core@1.8.1)(@emnapi/runtime@1.8.1)(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3)
'@vitest/pretty-format@4.1.0': '@vitest/pretty-format@4.1.0':
dependencies: dependencies:
@@ -3330,26 +3352,29 @@ snapshots:
reusify@1.1.0: {} reusify@1.1.0: {}
rolldown@1.0.0-rc.10: rolldown@1.0.0-rc.12(@emnapi/core@1.8.1)(@emnapi/runtime@1.8.1):
dependencies: dependencies:
'@oxc-project/types': 0.120.0 '@oxc-project/types': 0.122.0
'@rolldown/pluginutils': 1.0.0-rc.10 '@rolldown/pluginutils': 1.0.0-rc.12
optionalDependencies: optionalDependencies:
'@rolldown/binding-android-arm64': 1.0.0-rc.10 '@rolldown/binding-android-arm64': 1.0.0-rc.12
'@rolldown/binding-darwin-arm64': 1.0.0-rc.10 '@rolldown/binding-darwin-arm64': 1.0.0-rc.12
'@rolldown/binding-darwin-x64': 1.0.0-rc.10 '@rolldown/binding-darwin-x64': 1.0.0-rc.12
'@rolldown/binding-freebsd-x64': 1.0.0-rc.10 '@rolldown/binding-freebsd-x64': 1.0.0-rc.12
'@rolldown/binding-linux-arm-gnueabihf': 1.0.0-rc.10 '@rolldown/binding-linux-arm-gnueabihf': 1.0.0-rc.12
'@rolldown/binding-linux-arm64-gnu': 1.0.0-rc.10 '@rolldown/binding-linux-arm64-gnu': 1.0.0-rc.12
'@rolldown/binding-linux-arm64-musl': 1.0.0-rc.10 '@rolldown/binding-linux-arm64-musl': 1.0.0-rc.12
'@rolldown/binding-linux-ppc64-gnu': 1.0.0-rc.10 '@rolldown/binding-linux-ppc64-gnu': 1.0.0-rc.12
'@rolldown/binding-linux-s390x-gnu': 1.0.0-rc.10 '@rolldown/binding-linux-s390x-gnu': 1.0.0-rc.12
'@rolldown/binding-linux-x64-gnu': 1.0.0-rc.10 '@rolldown/binding-linux-x64-gnu': 1.0.0-rc.12
'@rolldown/binding-linux-x64-musl': 1.0.0-rc.10 '@rolldown/binding-linux-x64-musl': 1.0.0-rc.12
'@rolldown/binding-openharmony-arm64': 1.0.0-rc.10 '@rolldown/binding-openharmony-arm64': 1.0.0-rc.12
'@rolldown/binding-wasm32-wasi': 1.0.0-rc.10 '@rolldown/binding-wasm32-wasi': 1.0.0-rc.12(@emnapi/core@1.8.1)(@emnapi/runtime@1.8.1)
'@rolldown/binding-win32-arm64-msvc': 1.0.0-rc.10 '@rolldown/binding-win32-arm64-msvc': 1.0.0-rc.12
'@rolldown/binding-win32-x64-msvc': 1.0.0-rc.10 '@rolldown/binding-win32-x64-msvc': 1.0.0-rc.12
transitivePeerDependencies:
- '@emnapi/core'
- '@emnapi/runtime'
run-parallel@1.2.0: run-parallel@1.2.0:
dependencies: dependencies:
@@ -3467,23 +3492,26 @@ snapshots:
universalify@2.0.1: {} universalify@2.0.1: {}
vite@8.0.1(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3): vite@8.0.5(@emnapi/core@1.8.1)(@emnapi/runtime@1.8.1)(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3):
dependencies: dependencies:
lightningcss: 1.32.0 lightningcss: 1.32.0
picomatch: 4.0.4 picomatch: 4.0.4
postcss: 8.5.8 postcss: 8.5.8
rolldown: 1.0.0-rc.10 rolldown: 1.0.0-rc.12(@emnapi/core@1.8.1)(@emnapi/runtime@1.8.1)
tinyglobby: 0.2.15 tinyglobby: 0.2.15
optionalDependencies: optionalDependencies:
'@types/node': 25.3.3 '@types/node': 25.3.3
fsevents: 2.3.3 fsevents: 2.3.3
jiti: 2.6.1 jiti: 2.6.1
yaml: 2.8.3 yaml: 2.8.3
transitivePeerDependencies:
- '@emnapi/core'
- '@emnapi/runtime'
vitest@4.1.0(@types/node@25.3.3)(jsdom@29.0.1)(vite@8.0.1(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3)): vitest@4.1.0(@types/node@25.3.3)(jsdom@29.0.1)(vite@8.0.5(@emnapi/core@1.8.1)(@emnapi/runtime@1.8.1)(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3)):
dependencies: dependencies:
'@vitest/expect': 4.1.0 '@vitest/expect': 4.1.0
'@vitest/mocker': 4.1.0(vite@8.0.1(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3)) '@vitest/mocker': 4.1.0(vite@8.0.5(@emnapi/core@1.8.1)(@emnapi/runtime@1.8.1)(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3))
'@vitest/pretty-format': 4.1.0 '@vitest/pretty-format': 4.1.0
'@vitest/runner': 4.1.0 '@vitest/runner': 4.1.0
'@vitest/snapshot': 4.1.0 '@vitest/snapshot': 4.1.0
@@ -3500,7 +3528,7 @@ snapshots:
tinyexec: 1.0.4 tinyexec: 1.0.4
tinyglobby: 0.2.15 tinyglobby: 0.2.15
tinyrainbow: 3.1.0 tinyrainbow: 3.1.0
vite: 8.0.1(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3) vite: 8.0.5(@emnapi/core@1.8.1)(@emnapi/runtime@1.8.1)(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3)
why-is-node-running: 2.3.0 why-is-node-running: 2.3.0
optionalDependencies: optionalDependencies:
'@types/node': 25.3.3 '@types/node': 25.3.3

View File

@@ -1,29 +1,14 @@
/** /**
* Backpressure check for biome-ignore comments. * Zero-tolerance check for biome-ignore comments.
* *
* 1. Ratcheting cap — source and test files have separate max counts. * Any `biome-ignore` in tracked .ts/.tsx files fails the build.
* Lower these numbers as you fix ignores; they can never go up silently. * Fix the underlying issue instead of suppressing the rule.
* 2. Banned rules — ignoring certain rule categories is never allowed.
* 3. Justification — every ignore must have a non-empty explanation after
* the rule name.
*/ */
import { execSync } from "node:child_process"; import { execSync } from "node:child_process";
import { readFileSync } from "node:fs"; import { readFileSync } from "node:fs";
// ── Configuration ────────────────────────────────────────────────────── const IGNORE_PATTERN = /biome-ignore\s+([\w/]+)/;
const MAX_SOURCE_IGNORES = 2;
const MAX_TEST_IGNORES = 3;
/** Rule prefixes that must never be suppressed. */
const BANNED_PREFIXES = [
"lint/security/",
"lint/correctness/noGlobalObjectCalls",
"lint/correctness/noUnsafeFinally",
];
// ───────────────────────────────────────────────────────────────────────
const IGNORE_PATTERN = /biome-ignore\s+([\w/]+)(?::\s*(.*))?/;
function findFiles() { function findFiles() {
return execSync("git ls-files -- '*.ts' '*.tsx'", { encoding: "utf-8" }) return execSync("git ls-files -- '*.ts' '*.tsx'", { encoding: "utf-8" })
@@ -32,17 +17,7 @@ function findFiles() {
.filter(Boolean); .filter(Boolean);
} }
function isTestFile(path) { let count = 0;
return (
path.includes("__tests__/") ||
path.endsWith(".test.ts") ||
path.endsWith(".test.tsx")
);
}
let errors = 0;
let sourceCount = 0;
let testCount = 0;
for (const file of findFiles()) { for (const file of findFiles()) {
const lines = readFileSync(file, "utf-8").split("\n"); const lines = readFileSync(file, "utf-8").split("\n");
@@ -51,58 +26,16 @@ for (const file of findFiles()) {
const match = lines[i].match(IGNORE_PATTERN); const match = lines[i].match(IGNORE_PATTERN);
if (!match) continue; if (!match) continue;
const rule = match[1]; count++;
const justification = (match[2] ?? "").trim(); console.error(`FORBIDDEN: ${file}:${i + 1} — biome-ignore ${match[1]}`);
const loc = `${file}:${i + 1}`;
// Count by category
if (isTestFile(file)) {
testCount++;
} else {
sourceCount++;
}
// Banned rules
for (const prefix of BANNED_PREFIXES) {
if (rule.startsWith(prefix)) {
console.error(`BANNED: ${loc}${rule} must not be suppressed`);
errors++;
} }
} }
// Justification required if (count > 0) {
if (!justification) {
console.error( console.error(
`MISSING JUSTIFICATION: ${loc} biome-ignore ${rule} needs an explanation after the colon`, `\n${count} biome-ignore comment(s) found. Fix the issue or restructure the code.`,
); );
errors++;
}
}
}
// Ratcheting caps
if (sourceCount > MAX_SOURCE_IGNORES) {
console.error(
`SOURCE CAP EXCEEDED: ${sourceCount} biome-ignore comments in source (max ${MAX_SOURCE_IGNORES}). Fix issues and lower the cap.`,
);
errors++;
}
if (testCount > MAX_TEST_IGNORES) {
console.error(
`TEST CAP EXCEEDED: ${testCount} biome-ignore comments in tests (max ${MAX_TEST_IGNORES}). Fix issues and lower the cap.`,
);
errors++;
}
// Summary
console.log(
`biome-ignore: ${sourceCount} source (max ${MAX_SOURCE_IGNORES}), ${testCount} test (max ${MAX_TEST_IGNORES})`,
);
if (errors > 0) {
console.error(`\n${errors} problem(s) found.`);
process.exit(1); process.exit(1);
} else { } else {
console.log("All checks passed."); console.log("biome-ignore: 0 — all clear.");
} }

View File

@@ -0,0 +1,242 @@
import { readdirSync, readFileSync, writeFileSync } from "node:fs";
import { join, relative } from "node:path";
// Usage: node scripts/generate-pf2e-bestiary-index.mjs <path-to-foundry-pf2e>
//
// Requires a local clone of https://github.com/foundryvtt/pf2e (v13-dev branch).
//
// Example:
// git clone --depth 1 --branch v13-dev https://github.com/foundryvtt/pf2e.git /tmp/foundry-pf2e
// node scripts/generate-pf2e-bestiary-index.mjs /tmp/foundry-pf2e
const FOUNDRY_ROOT = process.argv[2];
if (!FOUNDRY_ROOT) {
console.error(
"Usage: node scripts/generate-pf2e-bestiary-index.mjs <foundry-pf2e-path>",
);
process.exit(1);
}
const PROJECT_ROOT = join(import.meta.dirname, "..");
const PACKS_DIR = join(FOUNDRY_ROOT, "packs/pf2e");
const OUTPUT_PATH = join(PROJECT_ROOT, "data/bestiary/pf2e-index.json");
// Legacy bestiaries superseded by Monster Core / Monster Core 2
const EXCLUDED_PACKS = new Set([
"pathfinder-bestiary",
"pathfinder-bestiary-2",
"pathfinder-bestiary-3",
]);
// PFS (Pathfinder Society) scenario packs — organized play content not on
// Archives of Nethys, mostly reskinned variants for specific scenarios.
const isPfsPack = (name) => name.startsWith("pfs-");
// Pack directory → display name mapping. Foundry pack directories are stable
// identifiers; new ones are added ~2-3 times per year with new AP volumes.
// Run the script with an unknown pack to see unmapped entries in the output.
const SOURCE_NAMES = {
"abomination-vaults-bestiary": "Abomination Vaults",
"age-of-ashes-bestiary": "Age of Ashes",
"agents-of-edgewatch-bestiary": "Agents of Edgewatch",
"battlecry-bestiary": "Battlecry!",
"blog-bestiary": "Pathfinder Blog",
"blood-lords-bestiary": "Blood Lords",
"book-of-the-dead-bestiary": "Book of the Dead",
"claws-of-the-tyrant-bestiary": "Claws of the Tyrant",
"crown-of-the-kobold-king-bestiary": "Crown of the Kobold King",
"curtain-call-bestiary": "Curtain Call",
"extinction-curse-bestiary": "Extinction Curse",
"fall-of-plaguestone": "The Fall of Plaguestone",
"fists-of-the-ruby-phoenix-bestiary": "Fists of the Ruby Phoenix",
"gatewalkers-bestiary": "Gatewalkers",
"hellbreakers-bestiary": "Hellbreakers",
"howl-of-the-wild-bestiary": "Howl of the Wild",
"kingmaker-bestiary": "Kingmaker",
"lost-omens-bestiary": "Lost Omens",
"malevolence-bestiary": "Malevolence",
"menace-under-otari-bestiary": "Beginner Box",
"myth-speaker-bestiary": "Myth Speaker",
"night-of-the-gray-death-bestiary": "Night of the Gray Death",
"npc-gallery": "NPC Gallery",
"one-shot-bestiary": "One-Shots",
"outlaws-of-alkenstar-bestiary": "Outlaws of Alkenstar",
"pathfinder-dark-archive": "Dark Archive",
"pathfinder-monster-core": "Monster Core",
"pathfinder-monster-core-2": "Monster Core 2",
"pathfinder-npc-core": "NPC Core",
"prey-for-death-bestiary": "Prey for Death",
"quest-for-the-frozen-flame-bestiary": "Quest for the Frozen Flame",
"rage-of-elements-bestiary": "Rage of Elements",
"revenge-of-the-runelords-bestiary": "Revenge of the Runelords",
"rusthenge-bestiary": "Rusthenge",
"season-of-ghosts-bestiary": "Season of Ghosts",
"seven-dooms-for-sandpoint-bestiary": "Seven Dooms for Sandpoint",
"shades-of-blood-bestiary": "Shades of Blood",
"shadows-at-sundown-bestiary": "Shadows at Sundown",
"sky-kings-tomb-bestiary": "Sky King's Tomb",
"spore-war-bestiary": "Spore War",
"standalone-adventures": "Standalone Adventures",
"stolen-fate-bestiary": "Stolen Fate",
"strength-of-thousands-bestiary": "Strength of Thousands",
"the-enmity-cycle-bestiary": "The Enmity Cycle",
"the-slithering-bestiary": "The Slithering",
"triumph-of-the-tusk-bestiary": "Triumph of the Tusk",
"troubles-in-otari-bestiary": "Troubles in Otari",
"war-of-immortals-bestiary": "War of Immortals",
"wardens-of-wildwood-bestiary": "Wardens of Wildwood",
};
// Size code mapping from Foundry abbreviations to full names
const SIZE_MAP = {
tiny: "tiny",
sm: "small",
med: "medium",
lg: "large",
huge: "huge",
grg: "gargantuan",
};
// Creature type traits
const CREATURE_TYPES = new Set([
"aberration",
"animal",
"astral",
"beast",
"celestial",
"construct",
"dragon",
"dream",
"elemental",
"ethereal",
"fey",
"fiend",
"fungus",
"giant",
"humanoid",
"monitor",
"ooze",
"petitioner",
"plant",
"spirit",
"time",
"undead",
]);
// --- Helpers ---
/** Recursively collect all .json files (excluding _*.json metadata files). */
function collectJsonFiles(dir) {
const results = [];
for (const entry of readdirSync(dir, { withFileTypes: true })) {
if (entry.name.startsWith("_")) continue;
const full = join(dir, entry.name);
if (entry.isDirectory()) {
results.push(...collectJsonFiles(full));
} else if (entry.name.endsWith(".json")) {
results.push(full);
}
}
return results;
}
// --- Main ---
const packDirs = readdirSync(PACKS_DIR, { withFileTypes: true })
.filter(
(d) => d.isDirectory() && !EXCLUDED_PACKS.has(d.name) && !isPfsPack(d.name),
)
.map((d) => d.name)
.sort();
const creatures = [];
const sources = {};
const missingData = [];
for (const packDir of packDirs) {
const packPath = join(PACKS_DIR, packDir);
let files;
try {
files = collectJsonFiles(packPath).sort();
} catch {
continue;
}
for (const filePath of files) {
let raw;
try {
raw = JSON.parse(readFileSync(filePath, "utf-8"));
} catch {
continue;
}
// Only include NPC-type creatures
if (raw.type !== "npc") continue;
const system = raw.system;
if (!system) continue;
const name = raw.name;
const level = system.details?.level?.value ?? 0;
const ac = system.attributes?.ac?.value ?? 0;
const hp = system.attributes?.hp?.max ?? 0;
const perception = system.perception?.mod ?? 0;
const sizeCode = system.traits?.size?.value ?? "med";
const size = SIZE_MAP[sizeCode] ?? "medium";
const traits = system.traits?.value ?? [];
const type =
traits.find((t) => CREATURE_TYPES.has(t.toLowerCase()))?.toLowerCase() ??
"";
const relativePath = relative(PACKS_DIR, filePath);
const license = system.details?.publication?.license ?? "";
if (!name || ac === 0 || hp === 0) {
missingData.push(`${relativePath}: name=${name} ac=${ac} hp=${hp}`);
}
creatures.push({
n: name,
s: packDir,
lv: level,
ac,
hp,
pc: perception,
sz: size,
tp: type,
f: relativePath,
li: license,
});
}
if (creatures.some((c) => c.s === packDir)) {
sources[packDir] = SOURCE_NAMES[packDir] ?? packDir;
}
}
// Sort by name then source for stable output
creatures.sort((a, b) => a.n.localeCompare(b.n) || a.s.localeCompare(b.s));
const output = { sources, creatures };
writeFileSync(OUTPUT_PATH, JSON.stringify(output));
const rawSize = Buffer.byteLength(JSON.stringify(output));
console.log(`Sources: ${Object.keys(sources).length}`);
console.log(`Creatures: ${creatures.length}`);
console.log(`Output size: ${(rawSize / 1024).toFixed(1)} KB`);
const unmapped = Object.keys(sources).filter((s) => !SOURCE_NAMES[s]);
if (unmapped.length > 0) {
console.log(
`\nUnmapped packs (using directory name as-is): ${unmapped.join(", ")}`,
);
}
if (missingData.length > 0) {
console.log(`\nCreatures with missing data (${missingData.length}):`);
for (const msg of missingData.slice(0, 20)) {
console.log(` ${msg}`);
}
if (missingData.length > 20) {
console.log(` ... and ${missingData.length - 20} more`);
}
}

View File

@@ -128,6 +128,22 @@ A user wants to rename a combatant. Clicking the combatant's name immediately en
4. **Given** a bestiary combatant row and a custom combatant row, **When** the user clicks either combatant's name, **Then** the behavior is identical — inline edit mode is entered immediately in both cases. 4. **Given** a bestiary combatant row and a custom combatant row, **When** the user clicks either combatant's name, **Then** the behavior is identical — inline edit mode is entered immediately in both cases.
**Story C4 — Name Updates on Weak/Elite Toggle (Priority: P2)**
When a PF2e weak/elite adjustment is toggled on a bestiary-linked combatant, the name automatically gains or loses a "Weak" or "Elite" prefix. Auto-numbered suffixes are preserved (e.g., "Goblin 2" → "Elite Goblin 2"). Toggling back to Normal removes the prefix. Existing auto-numbering of other combatants is not affected.
**Acceptance Scenarios**:
1. **Given** a combatant named "Iron Hag", **When** the DM toggles to "Elite", **Then** the name becomes "Elite Iron Hag".
2. **Given** a combatant named "Goblin 2", **When** the DM toggles to "Weak", **Then** the name becomes "Weak Goblin 2".
3. **Given** a combatant named "Elite Iron Hag", **When** the DM toggles back to "Normal", **Then** the name becomes "Iron Hag".
4. **Given** "Goblin 1" and "Goblin 2" exist, **When** the DM toggles "Goblin 1" to "Elite", **Then** it becomes "Elite Goblin 1" and "Goblin 2" is not renamed.
5. **Given** a combatant named "Elite Goblin 1", **When** the DM manually renames it to "Big Boss", **Then** the rename proceeds normally (manual names override the prefix convention).
--- ---
### Clearing the Encounter ### Clearing the Encounter
@@ -291,6 +307,12 @@ EditCombatant MUST preserve the combatant's position in the list, `activeIndex`,
#### FR-024 — Edit: UI #### FR-024 — Edit: UI
The UI MUST provide an inline name-edit mechanism for each combatant, activated by a single click on the name. Clicking the name MUST enter inline edit mode immediately — no delay, no timer, consistent for all combatant types. The name MUST display a `cursor-text` cursor on hover to signal editability. The updated name MUST be immediately visible after submission. The 250ms click timer and double-click detection logic MUST be removed entirely. The UI MUST provide an inline name-edit mechanism for each combatant, activated by a single click on the name. Clicking the name MUST enter inline edit mode immediately — no delay, no timer, consistent for all combatant types. The name MUST display a `cursor-text` cursor on hover to signal editability. The updated name MUST be immediately visible after submission. The 250ms click timer and double-click detection logic MUST be removed entirely.
#### FR-041 — Edit: Weak/Elite name prefix
When a PF2e weak/elite adjustment is toggled on a bestiary-linked combatant (see `specs/004-bestiary/spec.md`, FR-101), the system MUST prepend "Weak " or "Elite " to the combatant's name, preserving any auto-numbered suffix. Toggling to "Normal" MUST remove the prefix. Switching directly between "Weak" and "Elite" MUST swap the prefix.
#### FR-042 — Edit: Prefix does not trigger re-numbering
Adding or removing a weak/elite prefix MUST NOT trigger auto-numbering recalculation for other combatants. "Goblin 1" becoming "Elite Goblin 1" does not cause "Goblin 2" to be renumbered.
#### FR-025 — ConfirmButton: Reusable component #### FR-025 — ConfirmButton: Reusable component
The system MUST provide a reusable `ConfirmButton` component that wraps any icon button to add a two-step confirmation flow. The system MUST provide a reusable `ConfirmButton` component that wraps any icon button to add a two-step confirmation flow.
@@ -363,6 +385,7 @@ All domain events MUST be returned as plain data values from operations, not dis
- **ConfirmButton: two instances in confirm state simultaneously**: Each manages its own state independently. - **ConfirmButton: two instances in confirm state simultaneously**: Each manages its own state independently.
- **ConfirmButton: combatant row re-renders while in confirm state**: Confirm state persists through re-renders as long as combatant identity is stable. - **ConfirmButton: combatant row re-renders while in confirm state**: Confirm state persists through re-renders as long as combatant identity is stable.
- **Name click behavior is uniform**: A single click on any combatant's name enters inline edit mode immediately. There is no gesture disambiguation (no timer, no double-click detection). Stat block access is handled via the dedicated book icon on bestiary rows (see `specs/004-bestiary/spec.md`, FR-062). - **Name click behavior is uniform**: A single click on any combatant's name enters inline edit mode immediately. There is no gesture disambiguation (no timer, no double-click detection). Stat block access is handled via the dedicated book icon on bestiary rows (see `specs/004-bestiary/spec.md`, FR-062).
- **Weak/elite prefix on a manually renamed combatant**: If the user manually renames "Elite Goblin" to "Big Boss" and then toggles to Normal, the prefix "Elite " is not present to remove — the name "Big Boss" remains unchanged.
--- ---

View File

@@ -23,10 +23,15 @@ interface Combatant {
readonly currentHp?: number; // 0..maxHp readonly currentHp?: number; // 0..maxHp
readonly tempHp?: number; // positive integer, damage buffer readonly tempHp?: number; // positive integer, damage buffer
readonly ac?: number; // non-negative integer readonly ac?: number; // non-negative integer
readonly conditions?: readonly ConditionId[]; readonly conditions?: readonly ConditionEntry[];
readonly isConcentrating?: boolean; readonly isConcentrating?: boolean;
readonly creatureId?: CreatureId; // link to bestiary entry readonly creatureId?: CreatureId; // link to bestiary entry
} }
interface ConditionEntry {
readonly id: ConditionId;
readonly value?: number; // PF2e valued conditions (e.g., Clumsy 2); undefined for D&D
}
``` ```
--- ---
@@ -110,6 +115,15 @@ Acceptance scenarios:
7. **Given** no combatant has temp HP, **When** viewing the encounter, **Then** no extra space is reserved for temp HP display. 7. **Given** no combatant has temp HP, **When** viewing the encounter, **Then** no extra space is reserved for temp HP display.
8. **Given** one combatant has temp HP, **When** viewing the encounter, **Then** all rows reserve space for the temp HP display to maintain column alignment. 8. **Given** one combatant has temp HP, **When** viewing the encounter, **Then** all rows reserve space for the temp HP display to maintain column alignment.
**Story HP-8 — HP Adjusts on Weak/Elite Toggle (P2)**
As a game master toggling a PF2e creature between weak, normal, and elite, I want the combatant's max HP and current HP to update automatically so that the tracker reflects the adjusted creature's durability.
Acceptance scenarios:
1. **Given** a combatant with 75/75 HP (Normal), **When** the DM toggles to "Elite" (HP bracket +20), **Then** maxHp becomes 95 and currentHp becomes 95.
2. **Given** a combatant with 65/75 HP (Normal, 10 damage taken), **When** the DM toggles to "Elite" (HP bracket +20), **Then** maxHp becomes 95 and currentHp becomes 85 (shifted by +20, preserving the 10-damage deficit).
3. **Given** a combatant with 5/75 HP (Normal), **When** the DM toggles to "Weak" (HP bracket 20), **Then** maxHp becomes 55 and currentHp becomes 0 (clamped, since 520 < 0).
4. **Given** a combatant with 95/95 HP (Elite), **When** the DM toggles back to "Normal" (HP bracket 20), **Then** maxHp becomes 75 and currentHp becomes 75.
### Requirements ### Requirements
- **FR-001**: Each combatant MAY have an optional `maxHp` value (positive integer >= 1). HP tracking is optional per combatant. - **FR-001**: Each combatant MAY have an optional `maxHp` value (positive integer >= 1). HP tracking is optional per combatant.
@@ -143,6 +157,8 @@ Acceptance scenarios:
- **FR-029**: When any combatant in the encounter has temp HP > 0, all rows MUST reserve space for the temp HP display to maintain column alignment. When no combatant has temp HP, no space is reserved. - **FR-029**: When any combatant in the encounter has temp HP > 0, all rows MUST reserve space for the temp HP display to maintain column alignment. When no combatant has temp HP, no space is reserved.
- **FR-030**: The HP adjustment popover MUST include a third button (Shield icon) for setting temp HP. - **FR-030**: The HP adjustment popover MUST include a third button (Shield icon) for setting temp HP.
- **FR-031**: Temp HP MUST persist across page reloads via the existing persistence mechanism. - **FR-031**: Temp HP MUST persist across page reloads via the existing persistence mechanism.
- **FR-113**: When a PF2e weak/elite adjustment is toggled (see `specs/004-bestiary/spec.md`, FR-101), `maxHp` MUST be updated by the HP bracket delta for the creature's base level: ±10 (level ≤ 1), ±15 (level 24), ±20 (level 519), ±30 (level 20+). When switching directly between weak and elite, the full swing (reverse + apply) MUST be computed as a single delta.
- **FR-114**: When `maxHp` changes due to a weak/elite toggle, `currentHp` MUST shift by the same delta as `maxHp`, clamped to [0, new `maxHp`]. Temp HP is unaffected.
### Edge Cases ### Edge Cases
@@ -161,6 +177,7 @@ Acceptance scenarios:
- There is no death/unconscious game mechanic triggered at 0 HP; the system displays the state only. - There is no death/unconscious game mechanic triggered at 0 HP; the system displays the state only.
- There is no damage type tracking, resistance/vulnerability calculation, or hit log in the MVP baseline. - There is no damage type tracking, resistance/vulnerability calculation, or hit log in the MVP baseline.
- There is no undo/redo for HP changes in the MVP baseline. - There is no undo/redo for HP changes in the MVP baseline.
- Weak/elite toggle when combatant has temp HP: temp HP is unaffected; only maxHp and currentHp change. A combatant at 10+5/75 toggled to Elite becomes 30+5/95.
--- ---
@@ -187,6 +204,14 @@ Acceptance scenarios:
4. **Given** the inline AC edit is active, **When** the user presses Escape, **Then** the edit is cancelled and the original value is preserved. 4. **Given** the inline AC edit is active, **When** the user presses Escape, **Then** the edit is cancelled and the original value is preserved.
5. **Given** the inline AC edit is active, **When** the user clears the field and presses Enter, **Then** AC is unset and the shield shows an empty state. 5. **Given** the inline AC edit is active, **When** the user clears the field and presses Enter, **Then** AC is unset and the shield shows an empty state.
**Story AC-3 — AC Adjusts on Weak/Elite Toggle (P2)**
As a game master toggling a PF2e creature between weak, normal, and elite, I want the combatant's AC to update automatically so that the tracker reflects the adjusted creature's defenses.
Acceptance scenarios:
1. **Given** a combatant with AC 22 (Normal), **When** the DM toggles to "Elite", **Then** AC becomes 24.
2. **Given** a combatant with AC 24 (Elite), **When** the DM toggles to "Weak", **Then** AC becomes 20 (base 22, 2 for weak).
3. **Given** a combatant with AC 20 (Weak), **When** the DM toggles to "Normal", **Then** AC becomes 22.
### Requirements ### Requirements
- **FR-023**: Each combatant MAY have an optional `ac` value, a non-negative integer (>= 0). - **FR-023**: Each combatant MAY have an optional `ac` value, a non-negative integer (>= 0).
@@ -198,6 +223,8 @@ Acceptance scenarios:
- **FR-029**: AC MUST reject negative values. Zero is a valid AC. - **FR-029**: AC MUST reject negative values. Zero is a valid AC.
- **FR-030**: AC values MUST persist via the existing persistence mechanism. - **FR-030**: AC values MUST persist via the existing persistence mechanism.
- **FR-031**: The AC shield MUST scale appropriately for single-digit, double-digit, and any valid AC values. - **FR-031**: The AC shield MUST scale appropriately for single-digit, double-digit, and any valid AC values.
- **FR-115**: When a PF2e weak/elite adjustment is toggled (see `specs/004-bestiary/spec.md`, FR-101), `ac` MUST be updated by ±2. When switching directly between weak and elite, the full swing (±4) MUST be applied as a single update.
- **FR-116**: AC changes from weak/elite toggles MUST persist via the existing persistence mechanism, consistent with FR-030.
### Edge Cases ### Edge Cases
@@ -255,6 +282,8 @@ Acceptance scenarios:
4. **Given** concentration is active and the row is not hovered, **Then** the Brain icon remains visible. 4. **Given** concentration is active and the row is not hovered, **Then** the Brain icon remains visible.
5. **Given** concentration is active, **When** the user clicks the Brain icon again, **Then** concentration deactivates and the icon hides (unless the row is still hovered). 5. **Given** concentration is active, **When** the user clicks the Brain icon again, **Then** concentration deactivates and the icon hides (unless the row is still hovered).
6. **Given** the Brain icon is visible, **When** the user hovers over it, **Then** a tooltip reading "Concentrating" appears. 6. **Given** the Brain icon is visible, **When** the user hovers over it, **Then** a tooltip reading "Concentrating" appears.
7. **Given** the game system is Pathfinder 2e, **When** viewing any combatant row (hovered or not), **Then** the Brain icon is not shown — even if `isConcentrating` is true.
8. **Given** a combatant has `isConcentrating` true and the game system is PF2e, **When** the user switches to a D&D system, **Then** the Brain icon appears with active styling (concentration state was preserved).
**Story CC-6 — Visual Feedback for Concentration (P2)** **Story CC-6 — Visual Feedback for Concentration (P2)**
As a DM, I want concentrating combatants to have a visible row accent so I can identify them at a glance without interacting. As a DM, I want concentrating combatants to have a visible row accent so I can identify them at a glance without interacting.
@@ -263,6 +292,7 @@ Acceptance scenarios:
1. **Given** concentration is active, **When** viewing the encounter tracker, **Then** the combatant row shows a colored left border accent (`border-l-purple-400`). 1. **Given** concentration is active, **When** viewing the encounter tracker, **Then** the combatant row shows a colored left border accent (`border-l-purple-400`).
2. **Given** concentration is inactive, **Then** no concentration accent is shown. 2. **Given** concentration is inactive, **Then** no concentration accent is shown.
3. **Given** concentration is toggled off, **Then** the left border accent disappears immediately. 3. **Given** concentration is toggled off, **Then** the left border accent disappears immediately.
4. **Given** the game system is Pathfinder 2e and a combatant has `isConcentrating` true, **When** viewing the encounter tracker, **Then** no purple left border accent is shown on that row.
**Story CC-7 — Damage Pulse Alert (P3)** **Story CC-7 — Damage Pulse Alert (P3)**
As a DM, I want a visual alert when a concentrating combatant takes damage so I remember to call for a concentration check. As a DM, I want a visual alert when a concentrating combatant takes damage so I remember to call for a concentration check.
@@ -272,22 +302,53 @@ Acceptance scenarios:
2. **Given** a combatant is concentrating, **When** the combatant is healed, **Then** no pulse/flash occurs. 2. **Given** a combatant is concentrating, **When** the combatant is healed, **Then** no pulse/flash occurs.
3. **Given** a combatant is NOT concentrating, **When** damage is taken, **Then** no pulse/flash occurs. 3. **Given** a combatant is NOT concentrating, **When** damage is taken, **Then** no pulse/flash occurs.
4. **Given** a concentrating combatant takes damage, **When** the animation completes, **Then** the row returns to its normal concentration-active appearance. 4. **Given** a concentrating combatant takes damage, **When** the animation completes, **Then** the row returns to its normal concentration-active appearance.
5. **Given** the game system is Pathfinder 2e and a combatant has `isConcentrating` true, **When** the combatant takes damage, **Then** no pulse/flash animation occurs.
**Story CC-8 — Rules Edition Setting (P2)** **Story CC-8 — Game System Setting (P2)**
As a DM who plays in both 5e (2014) and 5.5e (2024) groups, I want to choose which edition's condition descriptions appear in tooltips so I reference the correct rules for the game I am running. As a DM who runs games across D&D 5e, 5.5e, and Pathfinder 2e, I want to choose which game system the tracker uses so that conditions, bestiary search, stat block layout, and initiative calculation all match the game I am running.
Acceptance scenarios: Acceptance scenarios:
1. **Given** the user opens the kebab menu, **When** they click "Settings", **Then** a settings modal opens. 1. **Given** the user opens the kebab menu, **When** they click "Settings", **Then** a settings modal opens.
2. **Given** the settings modal is open, **When** viewing the Conditions section, **Then** a rules edition selector shows 5e (2014) and 5.5e (2024) with 5.5e selected by default. 2. **Given** the settings modal is open, **When** viewing the Game System section, **Then** a selector shows three options: D&D 5e (2014), D&D 5.5e (2024), and Pathfinder 2e, with D&D 5.5e selected by default.
3. **Given** the user selects 5e (2014), **When** hovering a condition icon (e.g., Exhaustion), **Then** the tooltip shows the 2014 description. 3. **Given** the user selects Pathfinder 2e, **When** viewing condition icons/tooltips, **Then** the PF2e condition set is used (Clumsy, Drained, Enfeebled, etc.) instead of D&D conditions.
4. **Given** the user selects 5.5e (2024), **When** hovering the same condition, **Then** the tooltip shows the 2024 description. 4. **Given** the user selects Pathfinder 2e, **When** searching creatures in the bestiary, **Then** results come from the PF2e index (~2,700+ creatures) instead of the D&D index.
5. **Given** the user changes the edition and reloads the page, **Then** the selected edition is preserved. 5. **Given** the user selects Pathfinder 2e, **When** viewing a creature stat block, **Then** the PF2e layout is shown (level, Fort/Ref/Will, ability modifiers, top/mid/bot ability sections).
6. **Given** a condition with identical rules across editions (e.g., Deafened), **Then** the tooltip text is the same regardless of setting. 6. **Given** the user selects Pathfinder 2e, **When** rolling initiative for a bestiary creature, **Then** Perception is used as the initiative modifier instead of DEX + proficiency.
7. **Given** the settings modal is open, **When** viewing the Theme section, **Then** a System / Light / Dark selector is available, replacing the inline cycle button in the kebab menu. 7. **Given** the user selects D&D 5e (2014), **When** hovering a condition icon (e.g., Exhaustion), **Then** the tooltip shows the 2014 description. **When** 5.5e (2024) is selected, **Then** the tooltip shows the 2024 description.
8. **Given** the user changes the game system and reloads the page, **Then** the selected game system is preserved.
9. **Given** a condition with identical rules across D&D editions (e.g., Deafened), **Then** the tooltip text is the same regardless of D&D edition.
10. **Given** the settings modal is open, **When** viewing the Theme section, **Then** a System / Light / Dark selector is available, replacing the inline cycle button in the kebab menu.
**Story CC-9 — Value-Based Conditions (P2)**
As a DM running a PF2e encounter, I want conditions like Clumsy, Frightened, and Drained to carry an integer value so I can track escalating severity levels as defined by the PF2e rules.
The condition picker uses the same counter pattern as the bestiary batch-add (see `specs/004-bestiary/spec.md`, US-S2): clicking a valued condition shows `[-] N [+] [✓]` controls inline; the user adjusts the value and confirms. Clicking a condition tag on the combatant row decrements the value by 1.
Acceptance scenarios:
1. **Given** the game system is Pathfinder 2e and the condition picker is open, **When** the user clicks an inactive valued condition (e.g., Frightened), **Then** the row shows a counter at value 1 with `[-]`, `[+]`, and `[✓]` (confirm) buttons — the condition is not yet applied.
2. **Given** the counter is showing value 1, **When** the user clicks `[+]` twice, **Then** the counter shows value 3.
3. **Given** the counter is showing a value, **When** the user clicks `[✓]` (confirm), **Then** the condition is applied at that value and its icon appears inline with the value as a badge.
4. **Given** a combatant already has Frightened 2 and the picker is open, **When** the user clicks Frightened in the picker, **Then** the counter shows pre-filled at value 2 for adjustment.
5. **Given** a combatant has Frightened 2, **When** the user clicks the Frightened icon tag on the row, **Then** the value decrements to 1.
6. **Given** a combatant has Frightened 1, **When** the user clicks the Frightened icon tag on the row, **Then** the condition is removed entirely.
7. **Given** a PF2e condition that is not valued (e.g., Prone, Off-Guard), **When** the user clicks it in the picker, **Then** it toggles on/off with no counter or value badge — identical to D&D condition behavior.
8. **Given** the game system is D&D (5e or 5.5e), **When** interacting with conditions, **Then** no value counters or badges are shown and conditions toggle on/off as before.
9. **Given** a combatant has Clumsy 3, **When** the user hovers over the condition icon, **Then** the tooltip shows the condition name, the current value, and the PF2e rules description.
10. **Given** a valued condition counter is showing, **When** the user clicks a different valued condition, **Then** the previous counter is replaced (only one counter at a time).
**Story CC-10 — Condition Value Maximums (P2)**
As a DM running a PF2e encounter, I want valued conditions to be capped at their rule-defined maximum so I cannot accidentally increment them beyond their meaningful range.
Acceptance scenarios:
1. **Given** the game system is Pathfinder 2e, **When** a valued condition reaches its maximum (dying 4, doomed 3, wounded 3, slowed 3), **Then** the `[+]` button in the condition picker counter is disabled.
2. **Given** a combatant has Dying 4, **When** the user opens the condition picker, **Then** the counter shows 4 and `[+]` is disabled; `[-]` and `[✓]` remain active.
3. **Given** a combatant has Slowed 3, **When** the user clicks the Slowed icon tag on the row, **Then** the value decrements to 2 (decrement is unaffected by the cap).
4. **Given** the game system is D&D (5e or 5.5e), **When** interacting with conditions, **Then** no maximum enforcement is applied.
5. **Given** a PF2e valued condition without a defined maximum (e.g., Frightened, Clumsy), **When** incrementing, **Then** no cap is enforced — the value can increase without limit.
### Requirements ### Requirements
- **FR-032**: The MVP MUST support the following 15 standard D&D 5e/5.5e conditions: blinded, charmed, deafened, exhaustion, frightened, grappled, incapacitated, invisible, paralyzed, petrified, poisoned, prone, restrained, stunned, unconscious. - **FR-032**: When a D&D game system is active, the system MUST support the following 15 standard D&D 5e/5.5e conditions: blinded, charmed, deafened, exhaustion, frightened, grappled, incapacitated, invisible, paralyzed, petrified, poisoned, prone, restrained, stunned, unconscious. When Pathfinder 2e is active, the system MUST support the PF2e condition set (see FR-103).
- **FR-033**: Each condition MUST have a fixed icon and color mapping (Lucide icons; no emoji): - **FR-033**: Each condition MUST have a fixed icon and color mapping (Lucide icons; no emoji):
| Condition | Icon | Color | | Condition | Icon | Color |
@@ -312,9 +373,9 @@ Acceptance scenarios:
- **FR-035**: Conditions MUST be displayed in the fixed definition order (blinded -> unconscious), regardless of application order. - **FR-035**: Conditions MUST be displayed in the fixed definition order (blinded -> unconscious), regardless of application order.
- **FR-036**: The "+" condition button MUST be hidden by default and appear only on row hover (or touch/focus on touch devices). - **FR-036**: The "+" condition button MUST be hidden by default and appear only on row hover (or touch/focus on touch devices).
- **FR-037**: Clicking "+" MUST open the compact condition picker showing all conditions as icon + label pairs. - **FR-037**: Clicking "+" MUST open the compact condition picker showing all conditions as icon + label pairs.
- **FR-038**: Clicking a condition in the picker MUST toggle it on or off. - **FR-038**: Clicking a condition in the picker MUST toggle it on or off. For PF2e valued conditions, clicking MUST open an inline counter (same pattern as the bestiary batch-add count badge: `[-] N [+] [✓]`) instead of toggling immediately. The user adjusts the value and confirms with the `[✓]` button. Only one valued condition counter may be open at a time.
- **FR-039**: Clicking an active condition icon tag in the row MUST remove that condition. - **FR-039**: For D&D conditions, clicking an active condition icon tag in the row MUST remove that condition. For PF2e valued conditions, clicking MUST decrement the value by 1; the condition is removed when the value reaches 0. For PF2e non-valued conditions, clicking removes the condition.
- **FR-040**: Hovering an active condition icon MUST show a tooltip with the condition name and its rules description for the selected edition. - **FR-040**: Hovering an active condition icon MUST show a tooltip with the condition name and its rules description for the active game system. For PF2e valued conditions, the tooltip MUST also display the current value (e.g., "Frightened 2").
- **FR-041**: Condition icons MUST NOT increase the row's width; row height MAY increase to accommodate wrapping. - **FR-041**: Condition icons MUST NOT increase the row's width; row height MAY increase to accommodate wrapping.
- **FR-042**: The condition picker MUST close when the user clicks outside of it. - **FR-042**: The condition picker MUST close when the user clicks outside of it.
- **FR-043**: Conditions MUST persist as part of combatant state (surviving page reload). - **FR-043**: Conditions MUST persist as part of combatant state (surviving page reload).
@@ -330,6 +391,16 @@ Acceptance scenarios:
- **FR-053**: When a concentrating combatant takes damage, the Brain icon and row accent MUST briefly pulse/flash for 700 ms. - **FR-053**: When a concentrating combatant takes damage, the Brain icon and row accent MUST briefly pulse/flash for 700 ms.
- **FR-054**: The pulse animation MUST NOT trigger on healing or when concentration is inactive. - **FR-054**: The pulse animation MUST NOT trigger on healing or when concentration is inactive.
- **FR-055**: Concentration MUST persist across page reloads via existing storage. - **FR-055**: Concentration MUST persist across page reloads via existing storage.
- **FR-103**: When Pathfinder 2e is active, the system MUST support the following PF2e conditions: blinded, clumsy (valued), concealed, confused, controlled, dazzled, deafened, doomed (valued), drained (valued), dying (valued), enfeebled (valued), fascinated, fatigued, fleeing, frightened (valued), grabbed, hidden, immobilized, off-guard, paralyzed, petrified, prone, quickened, restrained, sickened (valued), slowed (valued), stunned (valued), stupefied (valued), unconscious, undetected, wounded (valued).
- **FR-104**: Each PF2e condition MUST have a fixed icon and color mapping (Lucide icons; no emoji). The icon/color table for PF2e conditions is defined separately from the D&D table (FR-033).
- **FR-105**: For PF2e valued conditions, the condition icon tag MUST display the current value as a small numeric badge (e.g., "2" next to the Frightened icon). Non-valued PF2e conditions display without a badge.
- **FR-106**: The condition data model MUST use `ConditionEntry` objects (`{ id: ConditionId, value?: number }`) instead of bare `ConditionId` values. D&D conditions MUST be stored without a `value` field (backwards-compatible).
- **FR-107**: Switching the game system MUST NOT clear existing combatant conditions. Conditions from the previous game system that are not valid in the new system remain stored but are hidden from display until the user switches back.
- **FR-108**: The following PF2e valued conditions MUST have maximum values enforced: dying (max 4), doomed (max 3), wounded (max 3), slowed (max 3). All other valued conditions have no enforced maximum.
- **FR-109**: When a PF2e valued condition is at its maximum value, the `[+]` increment button in the condition picker counter MUST be disabled (visually dimmed and non-interactive).
- **FR-110**: Maximum value enforcement MUST only apply when the Pathfinder 2e game system is active. D&D conditions are unaffected.
- **FR-111**: When Pathfinder 2e is the active game system, the concentration UI (Brain icon toggle, purple left border accent, damage pulse animation) MUST be hidden entirely. The Brain icon MUST NOT be shown on hover or at rest, and the concentration toggle MUST NOT be interactive.
- **FR-112**: Switching the game system MUST NOT clear or modify `isConcentrating` state on any combatant. The state MUST be preserved in storage and restored to the UI when switching back to a D&D game system.
### Edge Cases ### Edge Cases
@@ -340,9 +411,14 @@ Acceptance scenarios:
- When concentration is toggled during an active pulse animation, the animation cancels and the new state applies immediately. - When concentration is toggled during an active pulse animation, the animation cancels and the new state applies immediately.
- Multiple combatants may concentrate simultaneously; concentration is independent per combatant. - Multiple combatants may concentrate simultaneously; concentration is independent per combatant.
- Conditions have no mechanical effects in the MVP baseline (no auto-disadvantage, no automation). - Conditions have no mechanical effects in the MVP baseline (no auto-disadvantage, no automation).
- When the rules edition preference is missing from localStorage, the system defaults to 5.5e (2024). - When the game system preference is missing from localStorage, the system defaults to D&D 5.5e (2024).
- Changing the edition while a condition tooltip is visible updates the tooltip on next hover (no live update required). - Changing the game system while a condition tooltip is visible updates the tooltip on next hover (no live update required).
- The settings modal is app-level UI; it does not interact with encounter state. - The settings modal is app-level UI; it does not interact with encounter state.
- When the game system is switched from D&D to PF2e, existing D&D conditions on combatants are hidden (not deleted). Switching back to D&D restores them.
- PF2e valued condition at value 0 is treated as removed — it MUST NOT appear on the row.
- Dying, doomed, wounded, and slowed have enforced maximum values in PF2e (4, 3, 3, 3 respectively). The `[+]` button is disabled at the cap. The dynamic dying cap based on doomed value (dying max = 4 doomed) is not enforced — only the static maximum applies.
- Persistent damage is excluded from the PF2e MVP condition set. It can be added as a follow-up feature.
- When PF2e is active, concentration state (`isConcentrating`) is preserved in storage but the entire concentration UI is hidden. Switching back to D&D restores Brain icons, purple borders, and pulse behavior without data loss.
--- ---
@@ -410,12 +486,12 @@ Acceptance scenarios:
- **FR-066**: System MUST display a d20 icon button in the initiative slot for every combatant that has a linked bestiary creature and does not yet have an initiative value. - **FR-066**: System MUST display a d20 icon button in the initiative slot for every combatant that has a linked bestiary creature and does not yet have an initiative value.
- **FR-067**: System MUST NOT display the d20 button for combatants without a linked bestiary creature; they see a "--" placeholder that is clickable to type a value. - **FR-067**: System MUST NOT display the d20 button for combatants without a linked bestiary creature; they see a "--" placeholder that is clickable to type a value.
- **FR-068**: When the d20 button is clicked, the system MUST generate a uniform random integer in [1, 20], add the creature's initiative modifier, and set the result as the initiative value. - **FR-068**: When the d20 button is clicked, the system MUST generate a uniform random integer in [1, 20], add the creature's initiative modifier, and set the result as the initiative value.
- **FR-069**: The initiative modifier MUST be calculated as: DEX modifier + (proficiency multiplier x proficiency bonus), where DEX modifier = floor((DEX - 10) / 2) and proficiency bonus is derived from challenge rating. - **FR-069**: For D&D creatures, the initiative modifier MUST be calculated as: DEX modifier + (proficiency multiplier x proficiency bonus), where DEX modifier = floor((DEX - 10) / 2) and proficiency bonus is derived from challenge rating. For PF2e creatures, the initiative modifier MUST be the creature's Perception value from the index.
- **FR-070**: The initiative proficiency multiplier MUST be read from `initiative.proficiency` in bestiary data (0 if absent, 1 for proficiency, 2 for expertise). - **FR-070**: The initiative proficiency multiplier MUST be read from `initiative.proficiency` in bestiary data (0 if absent, 1 for proficiency, 2 for expertise).
- **FR-071**: System MUST provide a "Roll All Initiative" button in the top bar. Clicking it MUST roll for every bestiary-linked combatant that does not already have an initiative value; all others MUST be left unchanged. - **FR-071**: System MUST provide a "Roll All Initiative" button in the top bar. Clicking it MUST roll for every bestiary-linked combatant that does not already have an initiative value; all others MUST be left unchanged.
- **FR-072**: After any initiative roll (single or batch), the encounter list MUST re-sort descending per existing behavior. - **FR-072**: After any initiative roll (single or batch), the encounter list MUST re-sort descending per existing behavior.
- **FR-073**: Once a combatant has an initiative value, the d20 button is replaced by the value as plain text using a click-to-edit pattern (consistent with AC and name editing). - **FR-073**: Once a combatant has an initiative value, the d20 button is replaced by the value as plain text using a click-to-edit pattern (consistent with AC and name editing).
- **FR-074**: The stat block header MUST display initiative in the format "Initiative +X (Y)" where X is the modifier (with + or - sign) and Y = 10 + X. - **FR-074**: For D&D creatures, the stat block header MUST display initiative in the format "Initiative +X (Y)" where X is the modifier (with + or - sign) and Y = 10 + X. For PF2e creatures, the stat block MUST display "Perception +X" where X is the Perception modifier.
- **FR-075**: The initiative display in the stat block MUST be positioned adjacent to the AC value, matching Monster Manual 2024 layout. - **FR-075**: The initiative display in the stat block MUST be positioned adjacent to the AC value, matching Monster Manual 2024 layout.
- **FR-076**: No initiative line MUST be shown in the stat block for combatants without bestiary data. - **FR-076**: No initiative line MUST be shown in the stat block for combatants without bestiary data.
- **FR-077**: The initiative display in the stat block is display-only. It MUST NOT modify encounter turn order or trigger rolling automatically. - **FR-077**: The initiative display in the stat block is display-only. It MUST NOT modify encounter turn order or trigger rolling automatically.
@@ -489,11 +565,11 @@ Acceptance scenarios:
- **FR-093**: All interactive elements in the row MUST remain keyboard-accessible (focusable and operable via keyboard). - **FR-093**: All interactive elements in the row MUST remain keyboard-accessible (focusable and operable via keyboard).
- **FR-094**: On touch devices, hover-only controls ("+" button, "x" button) MUST remain accessible via tap or focus. - **FR-094**: On touch devices, hover-only controls ("+" button, "x" button) MUST remain accessible via tap or focus.
- **FR-095**: The system MUST provide a settings modal accessible via a "Settings" item in the kebab overflow menu. - **FR-095**: The system MUST provide a settings modal accessible via a "Settings" item in the kebab overflow menu.
- **FR-096**: The settings modal MUST include a Conditions section with a rules edition selector offering two options: 5e (2014) and 5.5e (2024). - **FR-096**: The settings modal MUST include a Game System section with a selector offering three options: D&D 5e (2014), D&D 5.5e (2024), and Pathfinder 2e. The label MUST read "Game System" (not "Conditions" or "Rules Edition").
- **FR-097**: The default rules edition MUST be 5.5e (2024). - **FR-097**: The default game system MUST be D&D 5.5e (2024).
- **FR-098**: Each condition definition MUST carry a description for both editions. Conditions with identical rules across editions MAY share a single description value. - **FR-098**: Each D&D condition definition MUST carry a description for both D&D editions. Each PF2e condition definition MUST carry a PF2e rules description. Conditions with identical rules across D&D editions MAY share a single description value.
- **FR-099**: Condition tooltips MUST display the description corresponding to the active rules edition preference. - **FR-099**: Condition tooltips MUST display the description corresponding to the active game system. For D&D game systems, the tooltip uses the edition-specific description. For PF2e, the tooltip uses the PF2e description.
- **FR-100**: The rules edition preference MUST persist across sessions via localStorage (key `"initiative:rules-edition"`). - **FR-100**: The game system preference MUST persist across sessions via localStorage (key `"initiative:game-system"`).
- **FR-101**: The settings modal MUST include a Theme section with System / Light / Dark options, replacing the inline theme cycle button in the kebab menu. - **FR-101**: The settings modal MUST include a Theme section with System / Light / Dark options, replacing the inline theme cycle button in the kebab menu.
- **FR-102**: The settings modal MUST close on Escape, click-outside, or the close button. - **FR-102**: The settings modal MUST close on Escape, click-outside, or the close button.
@@ -539,6 +615,10 @@ Acceptance scenarios:
- **SC-028**: The AC number is visually identifiable as armor class through the shield shape alone. - **SC-028**: The AC number is visually identifiable as armor class through the shield shape alone.
- **SC-029**: No layout shift occurs when hovering/unhovering rows. - **SC-029**: No layout shift occurs when hovering/unhovering rows.
- **SC-030**: All HP, AC, initiative, condition, and concentration interactions remain fully operable using only a keyboard. - **SC-030**: All HP, AC, initiative, condition, and concentration interactions remain fully operable using only a keyboard.
- **SC-031**: The user can switch rules edition in 2 interactions (open settings → select edition). - **SC-031**: The user can switch game system in 2 interactions (open settings → select system).
- **SC-032**: Condition tooltips accurately reflect the selected edition's rules text for all conditions that differ between editions. - **SC-032**: Condition tooltips accurately reflect the active game system's rules text for all conditions.
- **SC-033**: The rules edition preference survives a full page reload. - **SC-033**: The game system preference survives a full page reload.
- **SC-034**: All PF2e conditions are available and visually distinguishable by icon and color when PF2e is the active game system.
- **SC-035**: PF2e valued conditions display their current value and can be incremented/decremented within 1 click each.
- **SC-036**: Switching game system immediately changes the available conditions, bestiary search results, stat block layout, and initiative calculation — no page reload required.
- **SC-037**: The game system preference survives a full page reload.

Some files were not shown because too many files have changed in this diff Show More