Compare commits

..

21 Commits

Author SHA1 Message Date
Lukas
e161645228 Add PF2e spell description popovers in stat blocks
All checks were successful
CI / check (push) Successful in 2m31s
CI / build-image (push) Successful in 26s
Clicking a spell name in a PF2e creature's stat block now opens a
popover (desktop) or bottom sheet (mobile) showing full spell details:
description, traits, rank, range, target, area, duration, defense,
action cost icons, and heightening rules. All data is sourced from
the embedded Foundry VTT spell items already in the bestiary cache.

- Add SpellReference type replacing bare string spell arrays
- Extract full spell data in pf2e-bestiary-adapter (description,
  traits, traditions, range, target, area, duration, defense,
  action cost, heightening, overlays)
- Strip inline heightening text from descriptions to avoid duplication
- Bold save outcome labels (Critical Success/Failure) in descriptions
- Bump DB_VERSION to 6 for cache invalidation
- Add useSwipeToDismissDown hook for mobile bottom sheet
- Portal popover to document.body to escape transformed ancestors

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-10 16:18:08 +02:00
Lukas
9b0cb38897 Fix oxlint --deny-warnings and eliminate all biome-ignores
--deny warnings was a no-op (not a valid category); the correct flag
is --deny-warnings. Fixed all 8 pre-existing warnings and removed
every biome-ignore from source and test files. Simplified the check
script to zero-tolerance: any biome-ignore now fails the build.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-10 16:17:30 +02:00
Lukas
5cb5721a6f Redesign PF2e action icons with diamond-parallel geometry
All checks were successful
CI / check (push) Successful in 2m27s
CI / build-image (push) Successful in 18s
Align cutout edges to 45° angles parallel to outer diamond shape.
Multi-action icons use outlined diamonds with matched border width.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-09 01:07:45 +02:00
Lukas
48795071f7 Hide concentration UI in PF2e mode
All checks were successful
CI / check (push) Successful in 2m26s
CI / build-image (push) Successful in 18s
PF2e uses action-based spell sustaining, not damage-triggered
concentration checks. The Brain icon, purple border accent, and
damage pulse animation are now hidden when PF2e is active, and
the freed gutter column is reclaimed for row content. Concentration
state is preserved so switching back to D&D restores it.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-09 00:25:54 +02:00
Lukas
f721d7e5da Allow /commit skill to be invoked by other skills
All checks were successful
CI / check (push) Successful in 2m26s
CI / build-image (push) Successful in 5s
Remove disable-model-invocation so /ship can delegate to /commit.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-09 00:13:59 +02:00
Lukas
e7930a1431 Add /ship skill for commit, tag, and push workflow
All checks were successful
CI / check (push) Successful in 2m27s
CI / build-image (push) Successful in 18s
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-09 00:09:03 +02:00
Lukas
553e09f280 Enforce maximum values for PF2e numbered conditions
Cap dying (4), doomed (3), wounded (3), and slowed (3) at their
rule-defined maximums. The domain clamps values in setConditionValue
and the condition picker disables the [+] button at the cap.

Closes #31

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-09 00:04:47 +02:00
Lukas
1c107a500b Switch PF2e data source from Pf2eTools to Foundry VTT PF2e
All checks were successful
CI / check (push) Successful in 2m25s
CI / build-image (push) Successful in 23s
Replace the stagnant Pf2eTools bestiary with Foundry VTT PF2e system
data (github.com/foundryvtt/pf2e, v13-dev branch). This gives us 4,355
remaster-era creatures across 49 sources including Monster Core 1+2 and
all adventure paths.

Changes:
- Rewrite index generation script to walk Foundry pack directories
- Rewrite PF2e normalization adapter for Foundry JSON shape (system.*
  fields, items[] for attacks/abilities/spells)
- Add stripFoundryTags utility for Foundry HTML + enrichment syntax
- Implement multi-file source fetching (one request per creature file)
- Add spellcasting section to PF2e stat block (ranked spells + cantrips)
- Add saveConditional and hpDetails to PF2e domain type and stat block
- Add size and rarity to PF2e trait tags
- Filter redundant glossary abilities (healing when in hp.details,
  spell mechanic reminders, allSaves duplicates)
- Add PF2e stat block component tests (22 tests)
- Bump IndexedDB cache version to 5 for clean migration

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-08 21:05:00 +02:00
Lukas
0c235112ee Improve PF2e stat block action icons, triggers, and tag handling
- Replace unicode action cost chars with custom SVG icons (diamond
  with chevron for actions, outlined diamond for free, curved arrow
  for reaction) rendered inline via ActivityCost on TraitBlock
- Add activity icons to attacks (all Strikes default to single action)
- Add trigger/effect rendering for reaction abilities (bold labels)
- Fix nested tag stripping ({@b ...{@spell ...}...}) by looping
- Move icon after ability name to match AoN format

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-08 10:36:30 +02:00
Lukas
57278e0c82 Add PF2e action cost icons to ability names
All checks were successful
CI / check (push) Successful in 2m21s
CI / build-image (push) Successful in 17s
Show Unicode action icons (◆/◆◆/◆◆◆ for actions, ◇ for free,
↺ for reaction) in ability names from the activity field.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-07 16:31:24 +02:00
Lukas
f9cfaa2570 Include traits on PF2e ability blocks
Parse and display traits (concentrate, divine, polymorph, etc.)
on ability entries, matching how attack traits are already shown.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-07 16:29:08 +02:00
Lukas
3e62e54274 Strip all angle brackets in PF2e attack traits and damage
All checks were successful
CI / check (push) Successful in 2m23s
CI / build-image (push) Successful in 17s
Broaden stripDiceBrackets to stripAngleBrackets to handle all
PF2e tools angle-bracket formatting (e.g. <10 feet>, <15 feet>),
not just dice notation. Also strip in damage text.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-07 15:34:28 +02:00
Lukas
12a089dfd7 Fix PF2e condition tooltip descriptions and sort picker alphabetically
Correct inaccurate PF2e condition descriptions against official AoN
rules (blinded, deafened, confused, grabbed, hidden, paralyzed,
unconscious, drained, fascinated, enfeebled, stunned). Sort condition
picker alphabetically per game system.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-07 14:29:49 +02:00
Lukas
65e4db153b Fix PF2e stat block senses and attack trait rendering
All checks were successful
CI / check (push) Successful in 2m20s
CI / build-image (push) Successful in 17s
- Format senses with type (imprecise/precise) and range in feet,
  and strip {@ability} tags (e.g. tremorsense)
- Strip angle-bracket dice notation in attack traits (<d8> → d8)
- Fix existing weakness/resistance tests to nest under defenses
- Fix non-null assertions in 5e bestiary adapter tests

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-07 12:23:08 +02:00
Lukas
8dbff66ce1 Fix "undefined" in PF2e stat block weaknesses/resistances
All checks were successful
CI / check (push) Successful in 2m23s
CI / build-image (push) Successful in 30s
Some PF2e creatures (e.g. Giant Mining Bee) have qualitative
weaknesses without a numeric amount, causing "undefined" to
render in the stat block. Handle missing amounts gracefully.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-07 12:06:22 +02:00
Lukas
e62c49434c Add Pathfinder 2e game system mode
All checks were successful
CI / check (push) Successful in 2m21s
CI / build-image (push) Successful in 24s
Implements PF2e as an alternative game system alongside D&D 5e/5.5e.
Settings modal "Game System" selector switches conditions, bestiary,
stat block layout, and initiative calculation between systems.

- Valued conditions with increment/decrement UX (Clumsy 2, Frightened 3)
- 2,502 PF2e creatures from bundled search index (77 sources)
- PF2e stat block: level, traits, Perception, Fort/Ref/Will, ability mods
- Perception-based initiative rolling
- System-scoped source cache (D&D and PF2e sources don't collide)
- Backwards-compatible condition rehydration (ConditionId[] → ConditionEntry[])
- Difficulty indicator hidden in PF2e mode (excluded from MVP)

Closes dostulata/initiative#19

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-07 01:26:22 +02:00
Lukas
8f6eebc43b Render structured list and table entries in stat block traits
All checks were successful
CI / check (push) Successful in 2m21s
CI / build-image (push) Successful in 17s
Stat block traits containing 5etools list (e.g. Confusing Burble d4
effects) or table entries were silently dropped. The adapter now
produces structured TraitSegment[] instead of flat text, preserving
lists and tables as first-class data. The stat block component renders
labeled list items inline (bold label + flowing text) matching the
5etools layout. Also fixes support for the singular "entry" field on
list items and bumps the bestiary cache version to force re-normalize.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-04 22:09:11 +02:00
Lukas
817cfddabc Add 2014 DMG encounter difficulty calculation
All checks were successful
CI / check (push) Successful in 2m18s
CI / build-image (push) Successful in 17s
Support the 2014 DMG encounter difficulty as an alternative to the 5.5e
system behind the existing Rules Edition toggle. The 2014 system uses
Easy/Medium/Hard/Deadly thresholds, an encounter multiplier based on
monster count, and party size adjustment (×0.5–×5 range).

- Extract RulesEdition to its own domain module
- Refactor DifficultyTier to abstract numeric values (0–3)
- Restructure DifficultyResult with thresholds array
- Add 2014 XP thresholds table and encounter multiplier logic
- Wire edition from context into difficulty hooks
- Edition-aware labels in indicator and breakdown panel
- Show multiplier, adjusted XP, and party size note for 2014
- Rename settings label from "Conditions" to "Rules Edition"
- Update spec 008 with issue #23 requirements

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-04 14:52:23 +02:00
Lukas
94e1806112 Add combatant side assignment for encounter difficulty
All checks were successful
CI / check (push) Successful in 2m18s
CI / build-image (push) Successful in 17s
Combatants can now be assigned to party or enemy side via a toggle
in the difficulty breakdown panel. Party-side NPCs subtract their XP
from the encounter total, letting allied NPCs reduce difficulty.
PCs default to party, non-PCs to enemy — users who don't use sides
see no change. Side persists across reload and export/import.

Closes #22

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-03 14:15:12 +02:00
Lukas
30e7ed4121 Stabilize turn navigation bar layout with CSS grid
All checks were successful
CI / check (push) Successful in 2m18s
CI / build-image (push) Successful in 17s
Use a three-column grid (1fr / auto / 1fr) so the active combatant
name stays centered while round badge and difficulty indicator are
anchored in the left and right zones. Prevents layout jumps when
the name changes between turns.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-03 02:15:16 +02:00
Lukas
5540baf14c Show concentration icon on mobile as grey affordance
On touch devices, the Brain icon was fully hidden (opacity-0) unlike
the edit and condition buttons. Add pointer-coarse:opacity-50 so it
appears as a discoverable grey icon, matching the other action buttons.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-03 01:02:16 +02:00
104 changed files with 8222 additions and 1265 deletions

View File

@@ -1,7 +1,6 @@
---
name: commit
description: Create a git commit with pre-commit hooks (bypasses sandbox restrictions).
disable-model-invocation: true
allowed-tools: Bash(git *), Bash(pnpm *)
---

View File

@@ -0,0 +1,54 @@
---
name: ship
description: Commit, tag with the next version, and push to remote.
disable-model-invocation: true
allowed-tools: Bash(git *), Bash(pnpm *), Skill
---
## Instructions
Commit current changes, create the next version tag, and push everything to remote.
### Step 1 — Commit
Use the `/commit` skill to stage and commit changes. Pass along any user arguments as the commit message.
```
/commit $ARGUMENTS
```
### Step 2 — Tag
Get the latest tag and increment the patch number (e.g., `0.9.27``0.9.28`). Create the tag:
```bash
git tag --sort=-v:refname | head -1
```
```bash
git tag <next-version>
```
### Step 3 — Push
Push the commit and tag to remote:
```bash
git push && git push --tags
```
### Step 4 — Verify
Confirm the tag exists on the pushed commit:
```bash
git log --oneline -1 --decorate
```
## User arguments
```text
$ARGUMENTS
```
If the user provided arguments, treat them as the commit message or guidance for what to commit.

View File

@@ -69,6 +69,7 @@ docs/agents/ RPI skill artifacts (research reports, plans)
- **oxlint** for type-aware linting that Biome can't do. Configured in `.oxlintrc.json`.
- **TypeScript strict mode** with `verbatimModuleSyntax`. Use `.js` extensions in relative imports.
- **Branded types** for identity values (e.g., `CombatantId`). Prefer immutability/`readonly` where practical.
- **Reuse UI primitives** — before creating custom interactive elements (buttons, inputs, selects, dialogs), check `apps/web/src/components/ui/` for existing components with established variants and hover styles.
- **Domain events** are plain data objects with a `type` discriminant — no classes.
- **Tests** live in `__tests__/` directories adjacent to source. See the Testing section below for conventions on mocking, assertions, and per-layer approach.
- **Quality gates** are enforced at pre-commit via Lefthook (parallel jobs). No gate may exist only as a CI step or manual process.

View File

@@ -29,6 +29,6 @@
"@vitejs/plugin-react": "^6.0.1",
"jsdom": "^29.0.1",
"tailwindcss": "^4.2.2",
"vite": "^8.0.1"
"vite": "^8.0.5"
}
}

View File

@@ -1,5 +1,5 @@
import {
type Creature,
type AnyCreature,
type CreatureId,
EMPTY_UNDO_REDO_STATE,
type Encounter,
@@ -12,10 +12,10 @@ export function createTestAdapters(options?: {
encounter?: Encounter | null;
undoRedoState?: UndoRedoState;
playerCharacters?: PlayerCharacter[];
creatures?: Map<CreatureId, Creature>;
creatures?: Map<CreatureId, AnyCreature>;
sources?: Map<
string,
{ displayName: string; creatures: Creature[]; cachedAt: number }
{ displayName: string; creatures: AnyCreature[]; cachedAt: number }
>;
}): Adapters {
let storedEncounter = options?.encounter ?? null;
@@ -25,7 +25,7 @@ export function createTestAdapters(options?: {
options?.sources ??
new Map<
string,
{ displayName: string; creatures: Creature[]; cachedAt: number }
{ displayName: string; creatures: AnyCreature[]; cachedAt: number }
>();
// Pre-populate sourceStore from creatures map if provided
@@ -33,7 +33,7 @@ export function createTestAdapters(options?: {
// No-op: creatures are accessed directly from the map
}
const creatureMap = options?.creatures ?? new Map<CreatureId, Creature>();
const creatureMap = options?.creatures ?? new Map<CreatureId, AnyCreature>();
return {
encounterPersistence: {
@@ -55,8 +55,9 @@ export function createTestAdapters(options?: {
},
},
bestiaryCache: {
cacheSource(sourceCode, displayName, creatures) {
sourceStore.set(sourceCode, {
cacheSource(system, sourceCode, displayName, creatures) {
const key = `${system}:${sourceCode}`;
sourceStore.set(key, {
displayName,
creatures,
cachedAt: Date.now(),
@@ -66,21 +67,25 @@ export function createTestAdapters(options?: {
}
return Promise.resolve();
},
isSourceCached(sourceCode) {
return Promise.resolve(sourceStore.has(sourceCode));
isSourceCached(system, sourceCode) {
return Promise.resolve(sourceStore.has(`${system}:${sourceCode}`));
},
getCachedSources() {
getCachedSources(system) {
return Promise.resolve(
[...sourceStore.entries()].map(([sourceCode, info]) => ({
sourceCode,
displayName: info.displayName,
creatureCount: info.creatures.length,
cachedAt: info.cachedAt,
})),
[...sourceStore.entries()]
.filter(([key]) => !system || key.startsWith(`${system}:`))
.map(([key, info]) => ({
sourceCode: key.includes(":")
? key.slice(key.indexOf(":") + 1)
: key,
displayName: info.displayName,
creatureCount: info.creatures.length,
cachedAt: info.cachedAt,
})),
);
},
clearSource(sourceCode) {
sourceStore.delete(sourceCode);
clearSource(system, sourceCode) {
sourceStore.delete(`${system}:${sourceCode}`);
return Promise.resolve();
},
clearAll() {
@@ -104,5 +109,13 @@ export function createTestAdapters(options?: {
},
getSourceDisplayName: (sourceCode) => sourceCode,
},
pf2eBestiaryIndex: {
loadIndex: () => ({ sources: {}, creatures: [] }),
getAllSourceCodes: () => [],
getDefaultFetchUrl: (sourceCode) =>
`https://example.com/creatures-${sourceCode.toLowerCase()}.json`,
getSourceDisplayName: (sourceCode) => sourceCode,
getCreaturePathsForSource: () => [],
},
};
}

View File

@@ -33,8 +33,7 @@ async function addCombatant(
opts?: { maxHp?: string },
) {
const inputs = screen.getAllByPlaceholderText("+ Add combatants");
// biome-ignore lint/style/noNonNullAssertion: getAllBy always returns at least one
const input = inputs.at(-1)!;
const input = inputs.at(-1) ?? inputs[0];
await user.type(input, name);
if (opts?.maxHp) {

View File

@@ -198,21 +198,23 @@ describe("ConfirmButton", () => {
it("Enter/Space keydown stops propagation to prevent parent handlers", () => {
const parentHandler = vi.fn();
render(
// biome-ignore lint/a11y/noStaticElementInteractions: test wrapper
// biome-ignore lint/a11y/noNoninteractiveElementInteractions: test wrapper
<div onKeyDown={parentHandler}>
<ConfirmButton
icon={<XIcon />}
label="Remove combatant"
onConfirm={vi.fn()}
/>
</div>,
);
const button = screen.getByRole("button");
function Wrapper() {
return (
<button type="button" onKeyDown={parentHandler}>
<ConfirmButton
icon={<XIcon />}
label="Remove combatant"
onConfirm={vi.fn()}
/>
</button>
);
}
render(<Wrapper />);
const buttons = screen.getAllByRole("button");
const confirmButton = buttons.at(-1) ?? buttons[0];
fireEvent.keyDown(button, { key: "Enter" });
fireEvent.keyDown(button, { key: " " });
fireEvent.keyDown(confirmButton, { key: "Enter" });
fireEvent.keyDown(confirmButton, { key: " " });
expect(parentHandler).not.toHaveBeenCalled();
});

View File

@@ -234,6 +234,57 @@ describe("round-trip: export then import", () => {
expect(imported.encounter.combatants[0].cr).toBe("2");
});
it("round-trips a combatant with side field", () => {
const encounterWithSide: Encounter = {
combatants: [
{
id: combatantId("c-1"),
name: "Allied Guard",
cr: "2",
side: "party",
},
{
id: combatantId("c-2"),
name: "Goblin",
side: "enemy",
},
],
activeIndex: 0,
roundNumber: 1,
};
const emptyUndoRedo: UndoRedoState = {
undoStack: [],
redoStack: [],
};
const bundle = assembleExportBundle(encounterWithSide, emptyUndoRedo, []);
const serialized = JSON.parse(JSON.stringify(bundle));
const result = validateImportBundle(serialized);
expect(typeof result).toBe("object");
const imported = result as ExportBundle;
expect(imported.encounter.combatants[0].side).toBe("party");
expect(imported.encounter.combatants[1].side).toBe("enemy");
});
it("round-trips a combatant without side field as undefined", () => {
const encounterNoSide: Encounter = {
combatants: [{ id: combatantId("c-1"), name: "Custom" }],
activeIndex: 0,
roundNumber: 1,
};
const emptyUndoRedo: UndoRedoState = {
undoStack: [],
redoStack: [],
};
const bundle = assembleExportBundle(encounterNoSide, emptyUndoRedo, []);
const serialized = JSON.parse(JSON.stringify(bundle));
const result = validateImportBundle(serialized);
expect(typeof result).toBe("object");
const imported = result as ExportBundle;
expect(imported.encounter.combatants[0].side).toBeUndefined();
});
it("round-trips an empty encounter", () => {
const emptyEncounter: Encounter = {
combatants: [],

View File

@@ -1,9 +1,24 @@
import type { TraitBlock } from "@initiative/domain";
import { beforeAll, describe, expect, it } from "vitest";
import {
normalizeBestiary,
setSourceDisplayNames,
} from "../bestiary-adapter.js";
/** Flatten segments to a single string for simple text assertions. */
function flatText(trait: TraitBlock | undefined): string {
if (!trait) return "";
return trait.segments
.map((s) =>
s.type === "text"
? s.value
: s.items
.map((i) => (i.label ? `${i.label}. ${i.text}` : i.text))
.join(" "),
)
.join(" ");
}
beforeAll(() => {
setSourceDisplayNames({ XMM: "MM 2024" });
});
@@ -74,11 +89,11 @@ describe("normalizeBestiary", () => {
expect(c.senses).toBe("Darkvision 60 ft.");
expect(c.languages).toBe("Common, Goblin");
expect(c.actions).toHaveLength(1);
expect(c.actions?.[0].text).toContain("Melee Attack Roll:");
expect(c.actions?.[0].text).not.toContain("{@");
expect(flatText(c.actions?.[0])).toContain("Melee Attack Roll:");
expect(flatText(c.actions?.[0])).not.toContain("{@");
expect(c.bonusActions).toHaveLength(1);
expect(c.bonusActions?.[0].text).toContain("Disengage");
expect(c.bonusActions?.[0].text).not.toContain("{@");
expect(flatText(c.bonusActions?.[0])).toContain("Disengage");
expect(flatText(c.bonusActions?.[0])).not.toContain("{@");
});
it("normalizes a creature with legendary actions", () => {
@@ -166,17 +181,20 @@ describe("normalizeBestiary", () => {
expect(sc?.name).toBe("Spellcasting");
expect(sc?.headerText).toContain("DC 15");
expect(sc?.headerText).not.toContain("{@");
expect(sc?.atWill).toEqual(["Detect Magic", "Mage Hand"]);
expect(sc?.atWill).toEqual([
{ name: "Detect Magic" },
{ name: "Mage Hand" },
]);
expect(sc?.daily).toHaveLength(2);
expect(sc?.daily).toContainEqual({
uses: 2,
each: true,
spells: ["Fireball"],
spells: [{ name: "Fireball" }],
});
expect(sc?.daily).toContainEqual({
uses: 1,
each: false,
spells: ["Dimension Door"],
spells: [{ name: "Dimension Door" }],
});
});
@@ -333,9 +351,9 @@ describe("normalizeBestiary", () => {
const creatures = normalizeBestiary(raw);
const bite = creatures[0].actions?.[0];
expect(bite?.text).toContain("Melee Weapon Attack:");
expect(bite?.text).not.toContain("mw");
expect(bite?.text).not.toContain("{@");
expect(flatText(bite)).toContain("Melee Weapon Attack:");
expect(flatText(bite)).not.toContain("mw");
expect(flatText(bite)).not.toContain("{@");
});
it("handles fly speed with hover condition", () => {
@@ -368,4 +386,131 @@ describe("normalizeBestiary", () => {
const creatures = normalizeBestiary(raw);
expect(creatures[0].speed).toBe("10 ft., fly 90 ft. (hover)");
});
it("renders list items with singular entry field (e.g. Confusing Burble d4 effects)", () => {
const raw = {
monster: [
{
name: "Jabberwock",
source: "WBtW",
size: ["H"],
type: "dragon",
ac: [18],
hp: { average: 115, formula: "10d12 + 50" },
speed: { walk: 30 },
str: 22,
dex: 15,
con: 20,
int: 8,
wis: 14,
cha: 16,
passive: 12,
cr: "13",
trait: [
{
name: "Confusing Burble",
entries: [
"The jabberwock burbles unless {@condition incapacitated}. Roll a {@dice d4}:",
{
type: "list",
style: "list-hang-notitle",
items: [
{
type: "item",
name: "1-2",
entry: "The creature does nothing.",
},
{
type: "item",
name: "3",
entry:
"The creature uses all its movement to move in a random direction.",
},
{
type: "item",
name: "4",
entry:
"The creature makes one melee attack against a random creature.",
},
],
},
],
},
],
},
],
};
const creatures = normalizeBestiary(raw);
const trait = creatures[0].traits?.[0];
expect(trait).toBeDefined();
expect(trait?.name).toBe("Confusing Burble");
expect(trait?.segments).toHaveLength(2);
expect(trait?.segments[0]).toEqual({
type: "text",
value: expect.stringContaining("d4"),
});
expect(trait?.segments[1]).toEqual({
type: "list",
items: [
{ label: "1-2", text: "The creature does nothing." },
{
label: "3",
text: expect.stringContaining("random direction"),
},
{ label: "4", text: expect.stringContaining("melee attack") },
],
});
});
it("renders table entries as structured list segments", () => {
const raw = {
monster: [
{
name: "Test Creature",
source: "XMM",
size: ["M"],
type: "humanoid",
ac: [12],
hp: { average: 40, formula: "9d8" },
speed: { walk: 30 },
str: 10,
dex: 10,
con: 10,
int: 10,
wis: 10,
cha: 10,
passive: 10,
cr: "1",
trait: [
{
name: "Random Effect",
entries: [
"Roll on the table:",
{
type: "table",
colLabels: ["d4", "Effect"],
rows: [
["1", "Nothing happens."],
["2", "Something happens."],
],
},
],
},
],
},
],
};
const creatures = normalizeBestiary(raw);
const trait = creatures[0].traits?.[0];
expect(trait).toBeDefined();
expect(trait?.segments[1]).toEqual({
type: "list",
items: [
{ label: "1", text: "Nothing happens." },
{ label: "2", text: "Something happens." },
],
});
});
});

View File

@@ -46,17 +46,17 @@ describe("bestiary-cache fallback (IndexedDB unavailable)", () => {
it("cacheSource falls back to in-memory store", async () => {
const creatures = [makeCreature("mm:goblin", "Goblin")];
await cacheSource("MM", "Monster Manual", creatures);
await cacheSource("dnd", "MM", "Monster Manual", creatures);
expect(await isSourceCached("MM")).toBe(true);
expect(await isSourceCached("dnd", "MM")).toBe(true);
});
it("isSourceCached returns false for uncached source", async () => {
expect(await isSourceCached("XGE")).toBe(false);
expect(await isSourceCached("dnd", "XGE")).toBe(false);
});
it("getCachedSources returns sources from in-memory store", async () => {
await cacheSource("MM", "Monster Manual", [
await cacheSource("dnd", "MM", "Monster Manual", [
makeCreature("mm:goblin", "Goblin"),
]);
@@ -68,7 +68,7 @@ describe("bestiary-cache fallback (IndexedDB unavailable)", () => {
it("loadAllCachedCreatures assembles creatures from in-memory store", async () => {
const goblin = makeCreature("mm:goblin", "Goblin");
await cacheSource("MM", "Monster Manual", [goblin]);
await cacheSource("dnd", "MM", "Monster Manual", [goblin]);
const map = await loadAllCachedCreatures();
expect(map.size).toBe(1);
@@ -76,17 +76,17 @@ describe("bestiary-cache fallback (IndexedDB unavailable)", () => {
});
it("clearSource removes a single source from in-memory store", async () => {
await cacheSource("MM", "Monster Manual", []);
await cacheSource("VGM", "Volo's Guide", []);
await cacheSource("dnd", "MM", "Monster Manual", []);
await cacheSource("dnd", "VGM", "Volo's Guide", []);
await clearSource("MM");
await clearSource("dnd", "MM");
expect(await isSourceCached("MM")).toBe(false);
expect(await isSourceCached("VGM")).toBe(true);
expect(await isSourceCached("dnd", "MM")).toBe(false);
expect(await isSourceCached("dnd", "VGM")).toBe(true);
});
it("clearAll removes all data from in-memory store", async () => {
await cacheSource("MM", "Monster Manual", []);
await cacheSource("dnd", "MM", "Monster Manual", []);
await clearAll();
const sources = await getCachedSources();

View File

@@ -69,17 +69,17 @@ describe("bestiary-cache", () => {
describe("cacheSource", () => {
it("stores creatures and metadata", async () => {
const creatures = [makeCreature("mm:goblin", "Goblin")];
await cacheSource("MM", "Monster Manual", creatures);
await cacheSource("dnd", "MM", "Monster Manual", creatures);
expect(fakeStore.has("MM")).toBe(true);
const record = fakeStore.get("MM") as {
expect(fakeStore.has("dnd:MM")).toBe(true);
const record = fakeStore.get("dnd:MM") as {
sourceCode: string;
displayName: string;
creatures: Creature[];
creatureCount: number;
cachedAt: number;
};
expect(record.sourceCode).toBe("MM");
expect(record.sourceCode).toBe("dnd:MM");
expect(record.displayName).toBe("Monster Manual");
expect(record.creatures).toHaveLength(1);
expect(record.creatureCount).toBe(1);
@@ -89,12 +89,12 @@ describe("bestiary-cache", () => {
describe("isSourceCached", () => {
it("returns false for uncached source", async () => {
expect(await isSourceCached("XGE")).toBe(false);
expect(await isSourceCached("dnd", "XGE")).toBe(false);
});
it("returns true after caching", async () => {
await cacheSource("MM", "Monster Manual", []);
expect(await isSourceCached("MM")).toBe(true);
await cacheSource("dnd", "MM", "Monster Manual", []);
expect(await isSourceCached("dnd", "MM")).toBe(true);
});
});
@@ -105,11 +105,11 @@ describe("bestiary-cache", () => {
});
it("returns source info with creature counts", async () => {
await cacheSource("MM", "Monster Manual", [
await cacheSource("dnd", "MM", "Monster Manual", [
makeCreature("mm:goblin", "Goblin"),
makeCreature("mm:orc", "Orc"),
]);
await cacheSource("VGM", "Volo's Guide", [
await cacheSource("dnd", "VGM", "Volo's Guide", [
makeCreature("vgm:flind", "Flind"),
]);
@@ -137,8 +137,8 @@ describe("bestiary-cache", () => {
const orc = makeCreature("mm:orc", "Orc");
const flind = makeCreature("vgm:flind", "Flind");
await cacheSource("MM", "Monster Manual", [goblin, orc]);
await cacheSource("VGM", "Volo's Guide", [flind]);
await cacheSource("dnd", "MM", "Monster Manual", [goblin, orc]);
await cacheSource("dnd", "VGM", "Volo's Guide", [flind]);
const map = await loadAllCachedCreatures();
expect(map.size).toBe(3);
@@ -150,20 +150,20 @@ describe("bestiary-cache", () => {
describe("clearSource", () => {
it("removes a single source", async () => {
await cacheSource("MM", "Monster Manual", []);
await cacheSource("VGM", "Volo's Guide", []);
await cacheSource("dnd", "MM", "Monster Manual", []);
await cacheSource("dnd", "VGM", "Volo's Guide", []);
await clearSource("MM");
await clearSource("dnd", "MM");
expect(await isSourceCached("MM")).toBe(false);
expect(await isSourceCached("VGM")).toBe(true);
expect(await isSourceCached("dnd", "MM")).toBe(false);
expect(await isSourceCached("dnd", "VGM")).toBe(true);
});
});
describe("clearAll", () => {
it("removes all cached data", async () => {
await cacheSource("MM", "Monster Manual", []);
await cacheSource("VGM", "Volo's Guide", []);
await cacheSource("dnd", "MM", "Monster Manual", []);
await cacheSource("dnd", "VGM", "Volo's Guide", []);
await clearAll();

View File

@@ -0,0 +1,966 @@
import { describe, expect, it } from "vitest";
import { normalizeFoundryCreature } from "../pf2e-bestiary-adapter.js";
function minimalCreature(overrides?: Record<string, unknown>) {
return {
_id: "test-id",
name: "Test Creature",
type: "npc",
system: {
abilities: {
str: { mod: 3 },
dex: { mod: 2 },
con: { mod: 1 },
int: { mod: 0 },
wis: { mod: -1 },
cha: { mod: -2 },
},
attributes: {
ac: { value: 18 },
hp: { max: 45 },
speed: { value: 25 },
},
details: {
level: { value: 3 },
languages: { value: ["common"] },
publication: {
license: "ORC",
remaster: true,
title: "Test Source",
},
},
perception: { mod: 8 },
saves: {
fortitude: { value: 10 },
reflex: { value: 8 },
will: { value: 6 },
},
skills: {},
traits: { rarity: "common", size: { value: "med" }, value: [] },
},
items: [],
...overrides,
};
}
describe("normalizeFoundryCreature", () => {
describe("basic fields", () => {
it("maps top-level fields correctly", () => {
const creature = normalizeFoundryCreature(minimalCreature());
expect(creature.system).toBe("pf2e");
expect(creature.name).toBe("Test Creature");
expect(creature.level).toBe(3);
expect(creature.ac).toBe(18);
expect(creature.hp).toBe(45);
expect(creature.perception).toBe(8);
expect(creature.saveFort).toBe(10);
expect(creature.saveRef).toBe(8);
expect(creature.saveWill).toBe(6);
});
it("maps ability modifiers", () => {
const creature = normalizeFoundryCreature(minimalCreature());
expect(creature.abilityMods).toEqual({
str: 3,
dex: 2,
con: 1,
int: 0,
wis: -1,
cha: -2,
});
});
it("maps AC conditional from details", () => {
const creature = normalizeFoundryCreature(
minimalCreature({
system: {
...minimalCreature().system,
attributes: {
...minimalCreature().system.attributes,
ac: { value: 20, details: "+2 with shield raised" },
},
},
}),
);
expect(creature.acConditional).toBe("+2 with shield raised");
});
});
describe("senses formatting", () => {
it("formats darkvision", () => {
const creature = normalizeFoundryCreature(
minimalCreature({
system: {
...minimalCreature().system,
perception: {
mod: 8,
senses: [{ type: "darkvision" }],
},
},
}),
);
expect(creature.senses).toBe("Darkvision");
});
it("formats sense with acuity and range", () => {
const creature = normalizeFoundryCreature(
minimalCreature({
system: {
...minimalCreature().system,
perception: {
mod: 8,
senses: [{ type: "tremorsense", acuity: "imprecise", range: 30 }],
},
},
}),
);
expect(creature.senses).toBe("Tremorsense (imprecise) 30 feet");
});
it("omits precise acuity", () => {
const creature = normalizeFoundryCreature(
minimalCreature({
system: {
...minimalCreature().system,
perception: {
mod: 8,
senses: [{ type: "scent", acuity: "precise", range: 60 }],
},
},
}),
);
expect(creature.senses).toBe("Scent 60 feet");
});
});
describe("languages formatting", () => {
it("formats language list", () => {
const creature = normalizeFoundryCreature(
minimalCreature({
system: {
...minimalCreature().system,
details: {
...minimalCreature().system.details,
languages: { value: ["common", "draconic"] },
},
},
}),
);
expect(creature.languages).toBe("Common, Draconic");
});
it("includes details", () => {
const creature = normalizeFoundryCreature(
minimalCreature({
system: {
...minimalCreature().system,
details: {
...minimalCreature().system.details,
languages: {
value: ["common"],
details: "telepathy 100 feet",
},
},
},
}),
);
expect(creature.languages).toBe("Common (telepathy 100 feet)");
});
});
describe("skills formatting", () => {
it("formats and sorts skills", () => {
const creature = normalizeFoundryCreature(
minimalCreature({
system: {
...minimalCreature().system,
skills: {
stealth: { base: 10 },
athletics: { base: 8 },
},
},
}),
);
expect(creature.skills).toBe("Athletics +8, Stealth +10");
});
});
describe("defenses formatting", () => {
it("formats immunities with exceptions", () => {
const creature = normalizeFoundryCreature(
minimalCreature({
system: {
...minimalCreature().system,
attributes: {
...minimalCreature().system.attributes,
immunities: [
{ type: "paralyzed", exceptions: [] },
{
type: "physical",
exceptions: ["adamantine"],
},
],
},
},
}),
);
expect(creature.immunities).toBe(
"Paralyzed, Physical (except Adamantine)",
);
});
it("formats resistances with value", () => {
const creature = normalizeFoundryCreature(
minimalCreature({
system: {
...minimalCreature().system,
attributes: {
...minimalCreature().system.attributes,
resistances: [{ type: "fire", value: 10, exceptions: [] }],
},
},
}),
);
expect(creature.resistances).toBe("Fire 10");
});
it("formats weaknesses", () => {
const creature = normalizeFoundryCreature(
minimalCreature({
system: {
...minimalCreature().system,
attributes: {
...minimalCreature().system.attributes,
weaknesses: [{ type: "cold-iron", value: 5 }],
},
},
}),
);
expect(creature.weaknesses).toBe("Cold iron 5");
});
});
describe("speed formatting", () => {
it("formats base speed", () => {
const creature = normalizeFoundryCreature(minimalCreature());
expect(creature.speed).toBe("25 feet");
});
it("includes other speeds", () => {
const creature = normalizeFoundryCreature(
minimalCreature({
system: {
...minimalCreature().system,
attributes: {
...minimalCreature().system.attributes,
speed: {
value: 40,
otherSpeeds: [
{ type: "fly", value: 120 },
{ type: "swim", value: 40 },
],
},
},
},
}),
);
expect(creature.speed).toBe("40 feet, Fly 120 feet, Swim 40 feet");
});
it("includes speed details", () => {
const creature = normalizeFoundryCreature(
minimalCreature({
system: {
...minimalCreature().system,
attributes: {
...minimalCreature().system.attributes,
speed: {
value: 25,
details: "ignores difficult terrain",
},
},
},
}),
);
expect(creature.speed).toBe("25 feet (ignores difficult terrain)");
});
});
describe("attack normalization", () => {
it("normalizes melee attacks with traits and damage", () => {
const creature = normalizeFoundryCreature(
minimalCreature({
items: [
{
_id: "atk1",
name: "dogslicer",
type: "melee",
system: {
bonus: { value: 7 },
damageRolls: {
abc: {
damage: "1d6",
damageType: "slashing",
},
},
traits: {
value: ["agile", "backstabber", "finesse"],
},
},
},
],
}),
);
const attack = creature.attacks?.[0];
expect(attack).toBeDefined();
expect(attack?.name).toBe("Dogslicer");
expect(attack?.activity).toEqual({ number: 1, unit: "action" });
expect(attack?.segments[0]).toEqual({
type: "text",
value: "+7 (agile, backstabber, finesse), 1d6 slashing",
});
});
it("expands slugified trait names", () => {
const creature = normalizeFoundryCreature(
minimalCreature({
items: [
{
_id: "atk1",
name: "claw",
type: "melee",
system: {
bonus: { value: 18 },
damageRolls: {
abc: {
damage: "2d8+6",
damageType: "slashing",
},
},
traits: {
value: ["reach-10", "deadly-d10", "versatile-p"],
},
},
},
],
}),
);
const attack = creature.attacks?.[0];
expect(attack?.segments[0]).toEqual({
type: "text",
value: "+18 (reach 10 feet, deadly d10, versatile P), 2d8+6 slashing",
});
});
it("handles multiple damage types", () => {
const creature = normalizeFoundryCreature(
minimalCreature({
items: [
{
_id: "atk1",
name: "flaming sword",
type: "melee",
system: {
bonus: { value: 15 },
damageRolls: {
abc: {
damage: "2d8+5",
damageType: "slashing",
},
def: {
damage: "1d6",
damageType: "fire",
},
},
traits: { value: [] },
},
},
],
}),
);
const attack = creature.attacks?.[0];
expect(attack?.segments[0]).toEqual(
expect.objectContaining({
type: "text",
value: "+15, 2d8+5 slashing plus 1d6 fire",
}),
);
});
});
describe("ability normalization", () => {
it("routes abilities by category", () => {
const creature = normalizeFoundryCreature(
minimalCreature({
items: [
{
_id: "a1",
name: "Sense Motive",
type: "action",
system: {
category: "interaction",
actionType: { value: "passive" },
actions: { value: null },
traits: { value: [] },
description: { value: "<p>Can sense lies.</p>" },
},
},
{
_id: "a2",
name: "Shield Block",
type: "action",
system: {
category: "defensive",
actionType: { value: "reaction" },
actions: { value: null },
traits: { value: [] },
description: {
value: "<p>Blocks with shield.</p>",
},
},
},
{
_id: "a3",
name: "Breath Weapon",
type: "action",
system: {
category: "offensive",
actionType: { value: "action" },
actions: { value: 2 },
traits: { value: ["arcane", "fire"] },
description: {
value:
"<p>@Damage[8d6[fire]] in a @Template[cone|distance:40].</p>",
},
},
},
],
}),
);
expect(creature.abilitiesTop).toHaveLength(1);
expect(creature.abilitiesTop?.[0]?.name).toBe("Sense Motive");
expect(creature.abilitiesTop?.[0]?.activity).toBeUndefined();
expect(creature.abilitiesMid).toHaveLength(1);
expect(creature.abilitiesMid?.[0]?.name).toBe("Shield Block");
expect(creature.abilitiesMid?.[0]?.activity).toEqual({
number: 1,
unit: "reaction",
});
expect(creature.abilitiesBot).toHaveLength(1);
expect(creature.abilitiesBot?.[0]?.name).toBe("Breath Weapon");
expect(creature.abilitiesBot?.[0]?.activity).toEqual({
number: 2,
unit: "action",
});
});
it("strips Foundry enrichment tags from descriptions", () => {
const creature = normalizeFoundryCreature(
minimalCreature({
items: [
{
_id: "a1",
name: "Flame Burst",
type: "action",
system: {
category: "offensive",
actionType: { value: "action" },
actions: { value: 2 },
traits: { value: [] },
description: {
value:
"<p>Deal @Damage[3d6[fire]] damage, @Check[reflex|dc:20|basic] save.</p>",
},
},
},
],
}),
);
expect(
creature.abilitiesBot?.[0]?.segments[0]?.type === "text"
? creature.abilitiesBot[0].segments[0].value
: undefined,
).toBe("Deal 3d6 fire damage, DC 20 basic Reflex save.");
});
it("parses free action activity", () => {
const creature = normalizeFoundryCreature(
minimalCreature({
items: [
{
_id: "a1",
name: "Quick Draw",
type: "action",
system: {
category: "offensive",
actionType: { value: "free" },
actions: { value: null },
traits: { value: [] },
description: { value: "" },
},
},
],
}),
);
expect(creature.abilitiesBot?.[0]?.activity).toEqual({
number: 1,
unit: "free",
});
});
it("includes traits in ability text", () => {
const creature = normalizeFoundryCreature(
minimalCreature({
items: [
{
_id: "a1",
name: "Change Shape",
type: "action",
system: {
category: "offensive",
actionType: { value: "action" },
actions: { value: 1 },
traits: {
value: ["concentrate", "polymorph"],
},
description: {
value: "<p>Takes a new form.</p>",
},
},
},
],
}),
);
expect(
creature.abilitiesBot?.[0]?.segments[0]?.type === "text"
? creature.abilitiesBot[0].segments[0].value
: undefined,
).toBe("(Concentrate, Polymorph) Takes a new form.");
});
});
describe("spellcasting normalization", () => {
it("normalizes prepared spells by rank", () => {
const creature = normalizeFoundryCreature(
minimalCreature({
items: [
{
_id: "entry1",
name: "Primal Prepared Spells",
type: "spellcastingEntry",
system: {
tradition: { value: "primal" },
prepared: { value: "prepared" },
spelldc: { dc: 30, value: 22 },
},
},
{
_id: "s1",
name: "Earthquake",
type: "spell",
system: {
location: { value: "entry1" },
level: { value: 6 },
traits: { value: [] },
},
},
{
_id: "s2",
name: "Heal",
type: "spell",
system: {
location: { value: "entry1" },
level: { value: 3 },
traits: { value: [] },
},
},
{
_id: "s3",
name: "Detect Magic",
type: "spell",
system: {
location: { value: "entry1" },
level: { value: 1 },
traits: { value: ["cantrip"] },
},
},
],
}),
);
expect(creature.spellcasting).toHaveLength(1);
const sc = creature.spellcasting?.[0];
expect(sc?.name).toBe("Primal Prepared Spells");
expect(sc?.headerText).toBe("DC 30, attack +22");
expect(sc?.daily?.map((d) => d.uses)).toEqual([6, 3]);
expect(sc?.daily?.[0]?.spells.map((s) => s.name)).toEqual(["Earthquake"]);
expect(sc?.daily?.[1]?.spells.map((s) => s.name)).toEqual(["Heal"]);
expect(sc?.atWill?.map((s) => s.name)).toEqual(["Detect Magic"]);
expect(sc?.atWill?.[0]?.rank).toBe(1);
});
it("normalizes innate spells with uses", () => {
const creature = normalizeFoundryCreature(
minimalCreature({
items: [
{
_id: "entry1",
name: "Divine Innate Spells",
type: "spellcastingEntry",
system: {
tradition: { value: "divine" },
prepared: { value: "innate" },
spelldc: { dc: 32 },
},
},
{
_id: "s1",
name: "Sure Strike",
type: "spell",
system: {
location: {
value: "entry1",
heightenedLevel: 1,
uses: { max: 3, value: 3 },
},
level: { value: 1 },
traits: { value: [] },
},
},
],
}),
);
const sc = creature.spellcasting?.[0];
expect(sc?.headerText).toBe("DC 32");
expect(sc?.daily).toHaveLength(1);
const spell = sc?.daily?.[0]?.spells[0];
expect(spell?.name).toBe("Sure Strike");
expect(spell?.usesPerDay).toBe(3);
expect(spell?.rank).toBe(1);
});
it("preserves full spell data including description and heightening", () => {
const creature = normalizeFoundryCreature(
minimalCreature({
items: [
{
_id: "entry1",
name: "Divine Innate Spells",
type: "spellcastingEntry",
system: {
tradition: { value: "divine" },
prepared: { value: "innate" },
spelldc: { dc: 35, value: 27 },
},
},
{
_id: "s1",
name: "Heal",
type: "spell",
system: {
slug: "heal",
location: { value: "entry1" },
level: { value: 6 },
traits: {
rarity: "common",
value: ["healing", "vitality"],
traditions: ["divine", "primal"],
},
description: {
value:
"<p>You channel @UUID[Compendium.pf2e.spells.Item.Heal]{positive} energy to heal the living. The target regains @Damage[2d8[vitality]] Hit Points.</p>",
},
range: { value: "30 feet" },
target: { value: "1 willing creature" },
duration: { value: "" },
defense: undefined,
time: { value: "1" },
heightening: {
type: "interval",
interval: 1,
damage: { value: "2d8" },
},
},
},
{
_id: "s2",
name: "Force Barrage",
type: "spell",
system: {
location: { value: "entry1" },
level: { value: 1 },
traits: { value: ["concentrate", "manipulate"] },
},
},
],
}),
);
const sc = creature.spellcasting?.[0];
expect(sc).toBeDefined();
const heal = sc?.daily
?.flatMap((d) => d.spells)
.find((s) => s.name === "Heal");
expect(heal).toBeDefined();
expect(heal?.slug).toBe("heal");
expect(heal?.rank).toBe(6);
expect(heal?.range).toBe("30 feet");
expect(heal?.target).toBe("1 willing creature");
expect(heal?.traits).toEqual(["healing", "vitality"]);
expect(heal?.traditions).toEqual(["divine", "primal"]);
expect(heal?.actionCost).toBe("1");
// Foundry tags stripped from description
expect(heal?.description).toContain("positive");
expect(heal?.description).not.toContain("@UUID");
expect(heal?.description).not.toContain("@Damage");
// Interval heightening formatted and not duplicated in description
expect(heal?.heightening).toBe("Heightened (+1) damage increases by 2d8");
// Spell without optional data still has name + rank
const fb = sc?.daily
?.flatMap((d) => d.spells)
.find((s) => s.name === "Force Barrage");
expect(fb).toBeDefined();
expect(fb?.rank).toBe(1);
expect(fb?.description).toBeUndefined();
expect(fb?.usesPerDay).toBeUndefined();
});
it("formats fixed-type heightening levels", () => {
const creature = normalizeFoundryCreature(
minimalCreature({
items: [
{
_id: "entry1",
name: "Divine Prepared Spells",
type: "spellcastingEntry",
system: {
tradition: { value: "divine" },
prepared: { value: "prepared" },
spelldc: { dc: 30 },
},
},
{
_id: "s1",
name: "Magic Missile",
type: "spell",
system: {
location: { value: "entry1" },
level: { value: 1 },
traits: { value: [] },
heightening: {
type: "fixed",
levels: {
"3": { text: "<p>You shoot two more missiles.</p>" },
"5": { text: "<p>You shoot four more missiles.</p>" },
},
},
},
},
],
}),
);
const spell = creature.spellcasting?.[0]?.daily
?.flatMap((d) => d.spells)
.find((s) => s.name === "Magic Missile");
expect(spell?.heightening).toContain(
"Heightened (3) You shoot two more missiles.",
);
expect(spell?.heightening).toContain(
"Heightened (5) You shoot four more missiles.",
);
});
it("formats save defense", () => {
const creature = normalizeFoundryCreature(
minimalCreature({
items: [
{
_id: "entry1",
name: "Arcane Innate Spells",
type: "spellcastingEntry",
system: {
tradition: { value: "arcane" },
prepared: { value: "innate" },
spelldc: { dc: 25 },
},
},
{
_id: "s1",
name: "Fireball",
type: "spell",
system: {
location: { value: "entry1" },
level: { value: 3 },
traits: { value: ["fire"] },
area: { type: "burst", value: 20 },
defense: {
save: { statistic: "reflex", basic: true },
},
},
},
],
}),
);
const fireball = creature.spellcasting?.[0]?.daily
?.flatMap((d) => d.spells)
.find((s) => s.name === "Fireball");
expect(fireball?.defense).toBe("basic Reflex");
expect(fireball?.area).toBe("20-foot burst");
});
it("strips inline heightening text from description when structured heightening exists", () => {
const creature = normalizeFoundryCreature(
minimalCreature({
items: [
{
_id: "entry1",
name: "Arcane Prepared Spells",
type: "spellcastingEntry",
system: {
tradition: { value: "arcane" },
prepared: { value: "prepared" },
spelldc: { dc: 30 },
},
},
{
_id: "s1",
name: "Chain Lightning",
type: "spell",
system: {
location: { value: "entry1" },
level: { value: 6 },
traits: { value: ["electricity"] },
description: {
value:
"<p>You discharge a bolt of lightning. The damage is 8d12.</p><p>Heightened (+1) The damage increases by 1d12.</p>",
},
heightening: {
type: "interval",
interval: 1,
damage: { value: "1d12" },
},
},
},
],
}),
);
const spell = creature.spellcasting?.[0]?.daily
?.flatMap((d) => d.spells)
.find((s) => s.name === "Chain Lightning");
expect(spell?.description).toBe(
"You discharge a bolt of lightning. The damage is 8d12.",
);
expect(spell?.description).not.toContain("Heightened");
expect(spell?.heightening).toBe(
"Heightened (+1) damage increases by 1d12",
);
});
it("formats overlays when heightening is absent", () => {
const creature = normalizeFoundryCreature(
minimalCreature({
items: [
{
_id: "entry1",
name: "Arcane Innate Spells",
type: "spellcastingEntry",
system: {
tradition: { value: "arcane" },
prepared: { value: "innate" },
spelldc: { dc: 28 },
},
},
{
_id: "s1",
name: "Force Barrage",
type: "spell",
system: {
location: { value: "entry1" },
level: { value: 1 },
traits: { value: ["force", "manipulate"] },
description: {
value: "<p>You fire darts of force.</p>",
},
overlays: {
variant1: {
name: "2 actions",
system: {
description: {
value: "<p>You fire two darts.</p>",
},
},
},
variant2: {
name: "3 actions",
system: {
description: {
value: "<p>You fire three darts.</p>",
},
},
},
},
},
},
],
}),
);
const spell = creature.spellcasting?.[0]?.daily
?.flatMap((d) => d.spells)
.find((s) => s.name === "Force Barrage");
expect(spell?.heightening).toContain("2 actions: You fire two darts.");
expect(spell?.heightening).toContain("3 actions: You fire three darts.");
});
it("prefers heightening over overlays when both present", () => {
const creature = normalizeFoundryCreature(
minimalCreature({
items: [
{
_id: "entry1",
name: "Arcane Prepared Spells",
type: "spellcastingEntry",
system: {
tradition: { value: "arcane" },
prepared: { value: "prepared" },
spelldc: { dc: 30 },
},
},
{
_id: "s1",
name: "Test Spell",
type: "spell",
system: {
location: { value: "entry1" },
level: { value: 1 },
traits: { value: [] },
heightening: {
type: "interval",
interval: 2,
damage: { value: "1d6" },
},
overlays: {
variant1: {
name: "Variant",
system: {
description: {
value: "<p>Should be ignored.</p>",
},
},
},
},
},
},
],
}),
);
const spell = creature.spellcasting?.[0]?.daily
?.flatMap((d) => d.spells)
.find((s) => s.name === "Test Spell");
expect(spell?.heightening).toBe(
"Heightened (+2) damage increases by 1d6",
);
expect(spell?.heightening).not.toContain("Should be ignored");
});
});
});

View File

@@ -0,0 +1,103 @@
import { describe, expect, it } from "vitest";
const PACK_DIR_PREFIX = /^pathfinder-monster-core\//;
const JSON_EXTENSION = /\.json$/;
import {
getAllPf2eSourceCodes,
getCreaturePathsForSource,
getDefaultPf2eFetchUrl,
getPf2eSourceDisplayName,
loadPf2eBestiaryIndex,
} from "../pf2e-bestiary-index-adapter.js";
describe("loadPf2eBestiaryIndex", () => {
it("returns an object with sources and creatures", () => {
const index = loadPf2eBestiaryIndex();
expect(index.sources).toBeDefined();
expect(index.creatures).toBeDefined();
expect(Array.isArray(index.creatures)).toBe(true);
});
it("creatures have the expected PF2e shape", () => {
const index = loadPf2eBestiaryIndex();
expect(index.creatures.length).toBeGreaterThan(0);
const first = index.creatures[0];
expect(first).toHaveProperty("name");
expect(first).toHaveProperty("source");
expect(first).toHaveProperty("level");
expect(first).toHaveProperty("ac");
expect(first).toHaveProperty("hp");
expect(first).toHaveProperty("perception");
expect(first).toHaveProperty("size");
expect(first).toHaveProperty("type");
});
it("contains a substantial number of creatures", () => {
const index = loadPf2eBestiaryIndex();
expect(index.creatures.length).toBeGreaterThan(2500);
});
it("creatures have size and type populated", () => {
const index = loadPf2eBestiaryIndex();
const withSize = index.creatures.filter((c) => c.size !== "");
const withType = index.creatures.filter((c) => c.type !== "");
expect(withSize.length).toBeGreaterThan(index.creatures.length * 0.9);
expect(withType.length).toBeGreaterThan(index.creatures.length * 0.8);
});
it("returns the same cached instance on subsequent calls", () => {
const a = loadPf2eBestiaryIndex();
const b = loadPf2eBestiaryIndex();
expect(a).toBe(b);
});
});
describe("getAllPf2eSourceCodes", () => {
it("returns all keys from the index sources", () => {
const codes = getAllPf2eSourceCodes();
const index = loadPf2eBestiaryIndex();
expect(codes).toEqual(Object.keys(index.sources));
});
});
describe("getDefaultPf2eFetchUrl", () => {
it("returns Foundry VTT PF2e base URL", () => {
const url = getDefaultPf2eFetchUrl("pathfinder-monster-core");
expect(url).toBe(
"https://raw.githubusercontent.com/foundryvtt/pf2e/v13-dev/packs/pf2e/",
);
});
it("normalizes custom base URL with trailing slash", () => {
const url = getDefaultPf2eFetchUrl(
"pathfinder-monster-core",
"https://example.com/pf2e",
);
expect(url).toBe("https://example.com/pf2e/");
});
});
describe("getPf2eSourceDisplayName", () => {
it("returns display name for a known source", () => {
const name = getPf2eSourceDisplayName("pathfinder-monster-core");
expect(name).toBe("Monster Core");
});
it("falls back to source code for unknown source", () => {
expect(getPf2eSourceDisplayName("UNKNOWN")).toBe("UNKNOWN");
});
});
describe("getCreaturePathsForSource", () => {
it("returns file paths for a known source", () => {
const paths = getCreaturePathsForSource("pathfinder-monster-core");
expect(paths.length).toBeGreaterThan(100);
expect(paths[0]).toMatch(PACK_DIR_PREFIX);
expect(paths[0]).toMatch(JSON_EXTENSION);
});
it("returns empty array for unknown source", () => {
expect(getCreaturePathsForSource("nonexistent")).toEqual([]);
});
});

View File

@@ -0,0 +1,162 @@
import { describe, expect, it } from "vitest";
import { stripFoundryTags } from "../strip-foundry-tags.js";
describe("stripFoundryTags", () => {
describe("@Damage tags", () => {
it("formats damage with type bracket", () => {
expect(stripFoundryTags("@Damage[3d6+10[fire]]")).toBe("3d6+10 fire");
});
it("prefers display text when present", () => {
expect(
stripFoundryTags("@Damage[3d6+10[fire]]{3d6+10 fire damage}"),
).toBe("3d6+10 fire damage");
});
it("handles multiple damage types", () => {
expect(
stripFoundryTags("@Damage[2d8+5[slashing]] plus @Damage[1d6[fire]]"),
).toBe("2d8+5 slashing plus 1d6 fire");
});
});
describe("@Check tags", () => {
it("formats basic saving throw", () => {
expect(stripFoundryTags("@Check[reflex|dc:33|basic]")).toBe(
"DC 33 basic Reflex",
);
});
it("formats non-basic check", () => {
expect(stripFoundryTags("@Check[athletics|dc:25]")).toBe(
"DC 25 Athletics",
);
});
it("formats check without DC", () => {
expect(stripFoundryTags("@Check[fortitude]")).toBe("Fortitude");
});
});
describe("@UUID tags", () => {
it("extracts display text", () => {
expect(
stripFoundryTags(
"@UUID[Compendium.pf2e.conditionitems.Item.Grabbed]{Grabbed}",
),
).toBe("Grabbed");
});
it("extracts last segment when no display text", () => {
expect(
stripFoundryTags("@UUID[Compendium.pf2e.conditionitems.Item.Grabbed]"),
).toBe("Grabbed");
});
});
describe("@Template tags", () => {
it("formats cone template", () => {
expect(stripFoundryTags("@Template[cone|distance:40]")).toBe(
"40-foot cone",
);
});
it("formats emanation template", () => {
expect(stripFoundryTags("@Template[emanation|distance:10]")).toBe(
"10-foot emanation",
);
});
it("prefers display text", () => {
expect(
stripFoundryTags("@Template[cone|distance:40]{40-foot cone}"),
).toBe("40-foot cone");
});
});
describe("unknown @Tag patterns", () => {
it("uses display text for unknown tags", () => {
expect(stripFoundryTags("@Localize[some.key]{Some Text}")).toBe(
"Some Text",
);
});
it("strips unknown tags without display text", () => {
expect(stripFoundryTags("@Localize[some.key]")).toBe("");
});
});
describe("HTML stripping", () => {
it("strips paragraph tags", () => {
expect(stripFoundryTags("<p>text</p>")).toBe("text");
});
it("converts br to newline", () => {
expect(stripFoundryTags("line1<br />line2")).toBe("line1\nline2");
});
it("converts hr to newline", () => {
expect(stripFoundryTags("before<hr />after")).toBe("before\nafter");
});
it("strips strong and em tags", () => {
expect(stripFoundryTags("<strong>bold</strong> <em>italic</em>")).toBe(
"bold italic",
);
});
it("converts p-to-p transitions to newlines", () => {
expect(stripFoundryTags("<p>first</p><p>second</p>")).toBe(
"first\nsecond",
);
});
it("strips action-glyph spans", () => {
expect(
stripFoundryTags('<span class="action-glyph">1</span> Strike'),
).toBe("Strike");
});
});
describe("HTML entities", () => {
it("decodes &amp;", () => {
expect(stripFoundryTags("fire &amp; ice")).toBe("fire & ice");
});
it("decodes &lt; and &gt;", () => {
expect(stripFoundryTags("&lt;tag&gt;")).toBe("<tag>");
});
it("decodes &quot;", () => {
expect(stripFoundryTags("&quot;hello&quot;")).toBe('"hello"');
});
});
describe("whitespace handling", () => {
it("collapses multiple spaces", () => {
expect(stripFoundryTags("a b c")).toBe("a b c");
});
it("collapses multiple blank lines", () => {
expect(stripFoundryTags("a\n\n\nb")).toBe("a\nb");
});
it("trims leading and trailing whitespace", () => {
expect(stripFoundryTags(" hello ")).toBe("hello");
});
});
describe("combined/edge cases", () => {
it("handles enrichment tags inside HTML", () => {
expect(
stripFoundryTags(
"<p>Deal @Damage[2d6[fire]] damage, @Check[reflex|dc:20|basic] save.</p>",
),
).toBe("Deal 2d6 fire damage, DC 20 basic Reflex save.");
});
it("handles empty string", () => {
expect(stripFoundryTags("")).toBe("");
});
});
});

View File

@@ -138,12 +138,20 @@ describe("stripTags", () => {
);
});
it("handles nested tags gracefully", () => {
it("handles sibling tags in the same string", () => {
expect(
stripTags("The spell {@spell Fireball|XPHB} deals {@damage 8d6}."),
).toBe("The spell Fireball deals 8d6.");
});
it("handles nested tags (outer wrapping inner)", () => {
expect(
stripTags(
"{@b Arcane Innate Spells DC 24; 3rd {@spell fireball}, {@spell slow}}",
),
).toBe("Arcane Innate Spells DC 24; 3rd fireball, slow");
});
it("handles text with no tags", () => {
expect(stripTags("Just plain text.")).toBe("Just plain text.");
});

View File

@@ -4,7 +4,10 @@ import type {
DailySpells,
LegendaryBlock,
SpellcastingBlock,
SpellReference,
TraitBlock,
TraitListItem,
TraitSegment,
} from "@initiative/domain";
import { creatureId, proficiencyBonus } from "@initiative/domain";
import { stripTags } from "./strip-tags.js";
@@ -63,11 +66,18 @@ interface RawEntryObject {
type: string;
items?: (
| string
| { type: string; name?: string; entries?: (string | RawEntryObject)[] }
| {
type: string;
name?: string;
entry?: string;
entries?: (string | RawEntryObject)[];
}
)[];
style?: string;
name?: string;
entries?: (string | RawEntryObject)[];
colLabels?: string[];
rows?: (string | RawEntryObject)[][];
}
interface RawSpellcasting {
@@ -257,23 +267,34 @@ function formatConditionImmunities(
.join(", ");
}
function renderListItem(item: string | RawEntryObject): string | undefined {
function toListItem(
item:
| string
| {
type: string;
name?: string;
entry?: string;
entries?: (string | RawEntryObject)[];
},
): TraitListItem | undefined {
if (typeof item === "string") {
return `${stripTags(item)}`;
return { text: stripTags(item) };
}
if (item.name && item.entries) {
return `${stripTags(item.name)}: ${renderEntries(item.entries)}`;
return { label: stripTags(item.name), text: renderEntries(item.entries) };
}
if (item.name && item.entry) {
return { label: stripTags(item.name), text: stripTags(item.entry) };
}
return undefined;
}
function renderEntryObject(entry: RawEntryObject, parts: string[]): void {
if (entry.type === "list") {
for (const item of entry.items ?? []) {
const rendered = renderListItem(item);
if (rendered) parts.push(rendered);
}
} else if (entry.type === "item" && entry.name && entry.entries) {
if (entry.type === "list" || entry.type === "table") {
// Handled structurally in segmentizeEntries
return;
}
if (entry.type === "item" && entry.name && entry.entries) {
parts.push(`${stripTags(entry.name)}: ${renderEntries(entry.entries)}`);
} else if (entry.entries) {
parts.push(renderEntries(entry.entries));
@@ -292,11 +313,67 @@ function renderEntries(entries: (string | RawEntryObject)[]): string {
return parts.join(" ");
}
function tableRowToListItem(row: (string | RawEntryObject)[]): TraitListItem {
return {
label: typeof row[0] === "string" ? stripTags(row[0]) : undefined,
text: row
.slice(1)
.map((cell) =>
typeof cell === "string" ? stripTags(cell) : renderEntries([cell]),
)
.join(" "),
};
}
function entryToListSegment(entry: RawEntryObject): TraitSegment | undefined {
if (entry.type === "list") {
const items = (entry.items ?? [])
.map(toListItem)
.filter((i): i is TraitListItem => i !== undefined);
return items.length > 0 ? { type: "list", items } : undefined;
}
if (entry.type === "table" && entry.rows) {
const items = entry.rows.map(tableRowToListItem);
return items.length > 0 ? { type: "list", items } : undefined;
}
return undefined;
}
function segmentizeEntries(
entries: (string | RawEntryObject)[],
): TraitSegment[] {
const segments: TraitSegment[] = [];
const textParts: string[] = [];
const flushText = () => {
if (textParts.length > 0) {
segments.push({ type: "text", value: textParts.join(" ") });
textParts.length = 0;
}
};
for (const entry of entries) {
if (typeof entry === "string") {
textParts.push(stripTags(entry));
continue;
}
const listSeg = entryToListSegment(entry);
if (listSeg) {
flushText();
segments.push(listSeg);
} else {
renderEntryObject(entry, textParts);
}
}
flushText();
return segments;
}
function normalizeTraits(raw?: RawEntry[]): TraitBlock[] | undefined {
if (!raw || raw.length === 0) return undefined;
return raw.map((t) => ({
name: stripTags(t.name),
text: renderEntries(t.entries),
segments: segmentizeEntries(t.entries),
}));
}
@@ -309,7 +386,7 @@ function normalizeSpellcasting(
const block: {
name: string;
headerText: string;
atWill?: string[];
atWill?: SpellReference[];
daily?: DailySpells[];
restLong?: DailySpells[];
} = {
@@ -320,7 +397,7 @@ function normalizeSpellcasting(
const hidden = new Set(sc.hidden ?? []);
if (sc.will && !hidden.has("will")) {
block.atWill = sc.will.map((s) => stripTags(s));
block.atWill = sc.will.map((s) => ({ name: stripTags(s) }));
}
if (sc.daily) {
@@ -342,7 +419,7 @@ function parseDailyMap(map: Record<string, string[]>): DailySpells[] {
return {
uses,
each,
spells: spells.map((s) => stripTags(s)),
spells: spells.map((s) => ({ name: stripTags(s) })),
};
});
}
@@ -361,7 +438,7 @@ function normalizeLegendary(
preamble,
entries: raw.map((e) => ({
name: stripTags(e.name),
text: renderEntries(e.entries),
segments: segmentizeEntries(e.entries),
})),
};
}

View File

@@ -1,23 +1,26 @@
import type { Creature, CreatureId } from "@initiative/domain";
import type { AnyCreature, CreatureId } from "@initiative/domain";
import { type IDBPDatabase, openDB } from "idb";
const DB_NAME = "initiative-bestiary";
const STORE_NAME = "sources";
const DB_VERSION = 2;
// v6 (2026-04-09): SpellReference per-spell data added; old caches are cleared
const DB_VERSION = 6;
interface CachedSourceInfo {
readonly sourceCode: string;
readonly displayName: string;
readonly creatureCount: number;
readonly cachedAt: number;
readonly system?: string;
}
interface CachedSourceRecord {
sourceCode: string;
displayName: string;
creatures: Creature[];
creatures: AnyCreature[];
cachedAt: number;
creatureCount: number;
system?: string;
}
let db: IDBPDatabase | null = null;
@@ -26,6 +29,10 @@ let dbFailed = false;
// In-memory fallback when IndexedDB is unavailable
const memoryStore = new Map<string, CachedSourceRecord>();
function scopedKey(system: string, sourceCode: string): string {
return `${system}:${sourceCode}`;
}
async function getDb(): Promise<IDBPDatabase | null> {
if (db) return db;
if (dbFailed) return null;
@@ -38,8 +45,11 @@ async function getDb(): Promise<IDBPDatabase | null> {
keyPath: "sourceCode",
});
}
if (oldVersion < 2 && database.objectStoreNames.contains(STORE_NAME)) {
// Clear cached creatures to pick up improved tag processing
if (
oldVersion < DB_VERSION &&
database.objectStoreNames.contains(STORE_NAME)
) {
// Clear cached creatures so they get re-normalized with latest rendering
void transaction.objectStore(STORE_NAME).clear();
}
},
@@ -55,60 +65,77 @@ async function getDb(): Promise<IDBPDatabase | null> {
}
export async function cacheSource(
system: string,
sourceCode: string,
displayName: string,
creatures: Creature[],
creatures: AnyCreature[],
): Promise<void> {
const key = scopedKey(system, sourceCode);
const record: CachedSourceRecord = {
sourceCode,
sourceCode: key,
displayName,
creatures,
cachedAt: Date.now(),
creatureCount: creatures.length,
system,
};
const database = await getDb();
if (database) {
await database.put(STORE_NAME, record);
} else {
memoryStore.set(sourceCode, record);
memoryStore.set(key, record);
}
}
export async function isSourceCached(sourceCode: string): Promise<boolean> {
export async function isSourceCached(
system: string,
sourceCode: string,
): Promise<boolean> {
const key = scopedKey(system, sourceCode);
const database = await getDb();
if (database) {
const record = await database.get(STORE_NAME, sourceCode);
const record = await database.get(STORE_NAME, key);
return record !== undefined;
}
return memoryStore.has(sourceCode);
return memoryStore.has(key);
}
export async function getCachedSources(): Promise<CachedSourceInfo[]> {
export async function getCachedSources(
system?: string,
): Promise<CachedSourceInfo[]> {
const database = await getDb();
let records: CachedSourceRecord[];
if (database) {
const all: CachedSourceRecord[] = await database.getAll(STORE_NAME);
return all.map((r) => ({
sourceCode: r.sourceCode,
displayName: r.displayName,
creatureCount: r.creatureCount,
cachedAt: r.cachedAt,
}));
records = await database.getAll(STORE_NAME);
} else {
records = [...memoryStore.values()];
}
return [...memoryStore.values()].map((r) => ({
sourceCode: r.sourceCode,
const filtered = system
? records.filter((r) => r.system === system)
: records;
return filtered.map((r) => ({
sourceCode: r.system
? r.sourceCode.slice(r.system.length + 1)
: r.sourceCode,
displayName: r.displayName,
creatureCount: r.creatureCount,
cachedAt: r.cachedAt,
system: r.system,
}));
}
export async function clearSource(sourceCode: string): Promise<void> {
export async function clearSource(
system: string,
sourceCode: string,
): Promise<void> {
const key = scopedKey(system, sourceCode);
const database = await getDb();
if (database) {
await database.delete(STORE_NAME, sourceCode);
await database.delete(STORE_NAME, key);
} else {
memoryStore.delete(sourceCode);
memoryStore.delete(key);
}
}
@@ -122,9 +149,9 @@ export async function clearAll(): Promise<void> {
}
export async function loadAllCachedCreatures(): Promise<
Map<CreatureId, Creature>
Map<CreatureId, AnyCreature>
> {
const map = new Map<CreatureId, Creature>();
const map = new Map<CreatureId, AnyCreature>();
const database = await getDb();
let records: CachedSourceRecord[];

View File

@@ -0,0 +1,647 @@
import type {
CreatureId,
Pf2eCreature,
SpellcastingBlock,
SpellReference,
TraitBlock,
} from "@initiative/domain";
import { creatureId } from "@initiative/domain";
import { stripFoundryTags } from "./strip-foundry-tags.js";
// -- Raw Foundry VTT types (minimal, for parsing) --
interface RawFoundryCreature {
_id: string;
name: string;
type: string;
system: {
abilities: Record<string, { mod: number }>;
attributes: {
ac: { value: number; details?: string };
hp: { max: number; details?: string };
speed: {
value: number;
otherSpeeds?: { type: string; value: number }[];
details?: string;
};
immunities?: { type: string; exceptions?: string[] }[];
resistances?: { type: string; value: number; exceptions?: string[] }[];
weaknesses?: { type: string; value: number }[];
allSaves?: { value: string };
};
details: {
level: { value: number };
languages: { value?: string[]; details?: string };
publication: { license: string; remaster: boolean; title: string };
};
perception: {
mod: number;
details?: string;
senses?: { type: string; acuity?: string; range?: number }[];
};
saves: {
fortitude: { value: number; saveDetail?: string };
reflex: { value: number; saveDetail?: string };
will: { value: number; saveDetail?: string };
};
skills: Record<string, { base: number; note?: string }>;
traits: { rarity: string; size: { value: string }; value: string[] };
};
items: RawFoundryItem[];
}
interface RawFoundryItem {
_id: string;
name: string;
type: string;
system: Record<string, unknown>;
sort?: number;
}
interface MeleeSystem {
bonus?: { value: number };
damageRolls?: Record<string, { damage: string; damageType: string }>;
traits?: { value: string[] };
}
interface ActionSystem {
category?: string;
actionType?: { value: string };
actions?: { value: number | null };
traits?: { value: string[] };
description?: { value: string };
}
interface SpellcastingEntrySystem {
tradition?: { value: string };
prepared?: { value: string };
spelldc?: { dc: number; value?: number };
}
interface SpellSystem {
slug?: string;
location?: {
value: string;
heightenedLevel?: number;
uses?: { max: number; value: number };
};
level?: { value: number };
traits?: { rarity?: string; value: string[]; traditions?: string[] };
description?: { value: string };
range?: { value: string };
target?: { value: string };
area?: { type?: string; value?: number; details?: string };
duration?: { value: string; sustained?: boolean };
time?: { value: string };
defense?: {
save?: { statistic: string; basic?: boolean };
passive?: { statistic: string };
};
heightening?:
| {
type: "fixed";
levels: Record<string, { text?: string }>;
}
| {
type: "interval";
interval: number;
damage?: { value: string };
}
| undefined;
overlays?: Record<
string,
{ name?: string; system?: { description?: { value: string } } }
>;
}
const SIZE_MAP: Record<string, string> = {
tiny: "tiny",
sm: "small",
med: "medium",
lg: "large",
huge: "huge",
grg: "gargantuan",
};
// -- Helpers --
function capitalize(s: string): string {
return s.charAt(0).toUpperCase() + s.slice(1);
}
function makeCreatureId(source: string, name: string): CreatureId {
const slug = name
.toLowerCase()
.replaceAll(/[^a-z0-9]+/g, "-")
.replaceAll(/(^-|-$)/g, "");
return creatureId(`${source}:${slug}`);
}
const NUMERIC_SLUG = /^(.+)-(\d+)$/;
const LETTER_SLUG = /^(.+)-([a-z])$/;
/** Format rules for traits with a numeric suffix: "reach-10" → "reach 10 feet" */
const NUMERIC_TRAIT_FORMATS: Record<string, (n: string) => string> = {
reach: (n) => `reach ${n} feet`,
range: (n) => `range ${n} feet`,
"range-increment": (n) => `range increment ${n} feet`,
versatile: (n) => `versatile ${n}`,
deadly: (n) => `deadly d${n}`,
fatal: (n) => `fatal d${n}`,
"fatal-aim": (n) => `fatal aim d${n}`,
reload: (n) => `reload ${n}`,
};
/** Format rules for traits with a letter suffix: "versatile-p" → "versatile P" */
const LETTER_TRAIT_FORMATS: Record<string, (l: string) => string> = {
versatile: (l) => `versatile ${l.toUpperCase()}`,
deadly: (l) => `deadly d${l}`,
};
/** Expand slugified trait names: "reach-10" → "reach 10 feet" */
function formatTrait(slug: string): string {
const numMatch = NUMERIC_SLUG.exec(slug);
if (numMatch) {
const [, base, num] = numMatch;
const fmt = NUMERIC_TRAIT_FORMATS[base];
return fmt ? fmt(num) : `${base} ${num}`;
}
const letterMatch = LETTER_SLUG.exec(slug);
if (letterMatch) {
const [, base, letter] = letterMatch;
const fmt = LETTER_TRAIT_FORMATS[base];
if (fmt) return fmt(letter);
}
return slug.replaceAll("-", " ");
}
// -- Formatting --
function formatSenses(
senses: { type: string; acuity?: string; range?: number }[] | undefined,
): string | undefined {
if (!senses || senses.length === 0) return undefined;
return senses
.map((s) => {
const parts = [capitalize(s.type.replaceAll("-", " "))];
if (s.acuity && s.acuity !== "precise") {
parts.push(`(${s.acuity})`);
}
if (s.range != null) parts.push(`${s.range} feet`);
return parts.join(" ");
})
.join(", ");
}
function formatLanguages(
languages: { value?: string[]; details?: string } | undefined,
): string | undefined {
if (!languages?.value || languages.value.length === 0) return undefined;
const list = languages.value.map(capitalize).join(", ");
return languages.details ? `${list} (${languages.details})` : list;
}
function formatSkills(
skills: Record<string, { base: number; note?: string }> | undefined,
): string | undefined {
if (!skills) return undefined;
const entries = Object.entries(skills);
if (entries.length === 0) return undefined;
return entries
.map(([name, val]) => {
const label = capitalize(name.replaceAll("-", " "));
return `${label} +${val.base}`;
})
.sort()
.join(", ");
}
function formatImmunities(
immunities: { type: string; exceptions?: string[] }[] | undefined,
): string | undefined {
if (!immunities || immunities.length === 0) return undefined;
return immunities
.map((i) => {
const base = capitalize(i.type.replaceAll("-", " "));
if (i.exceptions && i.exceptions.length > 0) {
return `${base} (except ${i.exceptions.map((e) => capitalize(e.replaceAll("-", " "))).join(", ")})`;
}
return base;
})
.join(", ");
}
function formatResistances(
resistances:
| { type: string; value: number; exceptions?: string[] }[]
| undefined,
): string | undefined {
if (!resistances || resistances.length === 0) return undefined;
return resistances
.map((r) => {
const base = `${capitalize(r.type.replaceAll("-", " "))} ${r.value}`;
if (r.exceptions && r.exceptions.length > 0) {
return `${base} (except ${r.exceptions.map((e) => capitalize(e.replaceAll("-", " "))).join(", ")})`;
}
return base;
})
.join(", ");
}
function formatWeaknesses(
weaknesses: { type: string; value: number }[] | undefined,
): string | undefined {
if (!weaknesses || weaknesses.length === 0) return undefined;
return weaknesses
.map((w) => `${capitalize(w.type.replaceAll("-", " "))} ${w.value}`)
.join(", ");
}
function formatSpeed(speed: {
value: number;
otherSpeeds?: { type: string; value: number }[];
details?: string;
}): string {
const parts = [`${speed.value} feet`];
if (speed.otherSpeeds) {
for (const s of speed.otherSpeeds) {
parts.push(`${capitalize(s.type)} ${s.value} feet`);
}
}
const base = parts.join(", ");
return speed.details ? `${base} (${speed.details})` : base;
}
// -- Attack normalization --
function normalizeAttack(item: RawFoundryItem): TraitBlock {
const sys = item.system as unknown as MeleeSystem;
const bonus = sys.bonus?.value ?? 0;
const traits = sys.traits?.value ?? [];
const damageEntries = Object.values(sys.damageRolls ?? {});
const damage = damageEntries
.map((d) => `${d.damage} ${d.damageType}`)
.join(" plus ");
const traitStr =
traits.length > 0 ? ` (${traits.map(formatTrait).join(", ")})` : "";
return {
name: capitalize(item.name),
activity: { number: 1, unit: "action" },
segments: [
{
type: "text",
value: `+${bonus}${traitStr}, ${damage}`,
},
],
};
}
function parseActivity(
actionType: string | undefined,
actionCount: number | null | undefined,
): { number: number; unit: "action" | "free" | "reaction" } | undefined {
if (actionType === "action") {
return { number: actionCount ?? 1, unit: "action" };
}
if (actionType === "reaction") {
return { number: 1, unit: "reaction" };
}
if (actionType === "free") {
return { number: 1, unit: "free" };
}
return undefined;
}
// -- Ability normalization --
function normalizeAbility(item: RawFoundryItem): TraitBlock {
const sys = item.system as unknown as ActionSystem;
const actionType = sys.actionType?.value;
const actionCount = sys.actions?.value;
const description = stripFoundryTags(sys.description?.value ?? "");
const traits = sys.traits?.value ?? [];
const activity = parseActivity(actionType, actionCount);
const traitStr =
traits.length > 0
? `(${traits.map((t) => capitalize(formatTrait(t))).join(", ")}) `
: "";
const text = traitStr ? `${traitStr}${description}` : description;
const segments: { type: "text"; value: string }[] = text
? [{ type: "text", value: text }]
: [];
return { name: item.name, activity, segments };
}
// -- Spellcasting normalization --
function formatRange(range: { value: string } | undefined): string | undefined {
if (!range?.value) return undefined;
return range.value;
}
function formatArea(
area: { type?: string; value?: number; details?: string } | undefined,
): string | undefined {
if (!area) return undefined;
if (area.value && area.type) return `${area.value}-foot ${area.type}`;
return area.details ?? undefined;
}
function formatDefense(defense: SpellSystem["defense"]): string | undefined {
if (!defense) return undefined;
if (defense.save) {
const stat = capitalize(defense.save.statistic);
return defense.save.basic ? `basic ${stat}` : stat;
}
if (defense.passive) return capitalize(defense.passive.statistic);
return undefined;
}
function formatHeightening(
heightening: SpellSystem["heightening"],
): string | undefined {
if (!heightening) return undefined;
if (heightening.type === "fixed") {
const parts = Object.entries(heightening.levels)
.filter(([, lvl]) => lvl.text)
.map(
([rank, lvl]) =>
`Heightened (${rank}) ${stripFoundryTags(lvl.text as string)}`,
);
return parts.length > 0 ? parts.join("\n") : undefined;
}
if (heightening.type === "interval") {
const dmg = heightening.damage?.value
? ` damage increases by ${heightening.damage.value}`
: "";
return `Heightened (+${heightening.interval})${dmg}`;
}
return undefined;
}
function formatOverlays(overlays: SpellSystem["overlays"]): string | undefined {
if (!overlays) return undefined;
const parts: string[] = [];
for (const overlay of Object.values(overlays)) {
const desc = overlay.system?.description?.value;
if (!desc) continue;
const label = overlay.name ? `${overlay.name}: ` : "";
parts.push(`${label}${stripFoundryTags(desc)}`);
}
return parts.length > 0 ? parts.join("\n") : undefined;
}
/**
* Foundry descriptions often include heightening rules inline at the end.
* When we extract heightening into a structured field, strip that trailing
* text to avoid duplication.
*/
const HEIGHTENED_SUFFIX = /\s*Heightened\s*\([^)]*\)[\s\S]*$/;
function normalizeSpell(item: RawFoundryItem): SpellReference {
const sys = item.system as unknown as SpellSystem;
const usesMax = sys.location?.uses?.max;
const rank = sys.location?.heightenedLevel ?? sys.level?.value ?? 0;
const heightening =
formatHeightening(sys.heightening) ?? formatOverlays(sys.overlays);
let description: string | undefined;
if (sys.description?.value) {
let text = stripFoundryTags(sys.description.value);
if (heightening) {
text = text.replace(HEIGHTENED_SUFFIX, "").trim();
}
description = text || undefined;
}
return {
name: item.name,
slug: sys.slug,
rank,
description,
traits: sys.traits?.value,
traditions: sys.traits?.traditions,
range: formatRange(sys.range),
target: sys.target?.value || undefined,
area: formatArea(sys.area),
duration: sys.duration?.value || undefined,
defense: formatDefense(sys.defense),
actionCost: sys.time?.value || undefined,
heightening,
usesPerDay: usesMax && usesMax > 1 ? usesMax : undefined,
};
}
function normalizeSpellcastingEntry(
entry: RawFoundryItem,
allSpells: readonly RawFoundryItem[],
): SpellcastingBlock {
const sys = entry.system as unknown as SpellcastingEntrySystem;
const tradition = capitalize(sys.tradition?.value ?? "");
const prepared = sys.prepared?.value ?? "";
const dc = sys.spelldc?.dc ?? 0;
const attack = sys.spelldc?.value ?? 0;
const name = entry.name || `${tradition} ${capitalize(prepared)} Spells`;
const headerText = `DC ${dc}${attack ? `, attack +${attack}` : ""}`;
const linkedSpells = allSpells.filter(
(s) => (s.system as unknown as SpellSystem).location?.value === entry._id,
);
const byRank = new Map<number, SpellReference[]>();
const cantrips: SpellReference[] = [];
for (const spell of linkedSpells) {
const ref = normalizeSpell(spell);
const isCantrip =
(spell.system as unknown as SpellSystem).traits?.value?.includes(
"cantrip",
) ?? false;
if (isCantrip) {
cantrips.push(ref);
continue;
}
const rank = ref.rank ?? 0;
const existing = byRank.get(rank) ?? [];
existing.push(ref);
byRank.set(rank, existing);
}
const daily = [...byRank.entries()]
.sort(([a], [b]) => b - a)
.map(([rank, spells]) => ({
uses: rank,
each: true,
spells,
}));
return {
name,
headerText,
atWill: orUndefined(cantrips),
daily: orUndefined(daily),
};
}
function normalizeSpellcasting(
items: readonly RawFoundryItem[],
): SpellcastingBlock[] {
const entries = items.filter((i) => i.type === "spellcastingEntry");
const spells = items.filter((i) => i.type === "spell");
return entries.map((entry) => normalizeSpellcastingEntry(entry, spells));
}
// -- Main normalization --
function orUndefined<T>(arr: T[]): T[] | undefined {
return arr.length > 0 ? arr : undefined;
}
/** Build display traits: [rarity (if not common), size, ...type traits] */
function buildTraits(traits: {
rarity: string;
size: { value: string };
value: string[];
}): string[] {
const result: string[] = [];
if (traits.rarity && traits.rarity !== "common") {
result.push(traits.rarity);
}
const size = SIZE_MAP[traits.size.value] ?? "medium";
result.push(size);
result.push(...traits.value);
return result;
}
const HEALING_GLOSSARY =
/^<p>@Localize\[PF2E\.NPC\.Abilities\.Glossary\.(FastHealing|Regeneration|NegativeHealing)\]/;
/** Glossary-only abilities that duplicate structured data shown elsewhere. */
const REDUNDANT_GLOSSARY =
/^<p>@Localize\[PF2E\.NPC\.Abilities\.Glossary\.(ConstantSpells|AtWillSpells)\]/;
const STRIP_GLOSSARY_AND_P = /<p>@Localize\[[^\]]+\]<\/p>|<\/?p>/g;
/** True when the description has no user-visible content beyond glossary tags. */
function isGlossaryOnly(desc: string | undefined): boolean {
if (!desc) return true;
return desc.replace(STRIP_GLOSSARY_AND_P, "").trim() === "";
}
function isRedundantAbility(
item: RawFoundryItem,
excludeName: string | undefined,
hpDetails: string | undefined,
): boolean {
const sys = item.system as unknown as ActionSystem;
const desc = sys.description?.value;
// Ability duplicates the allSaves line — suppress only if glossary-only
if (excludeName && item.name.toLowerCase() === excludeName.toLowerCase()) {
return isGlossaryOnly(desc);
}
if (!desc) return false;
// Healing/regen glossary when hp.details already shows the info
if (hpDetails && HEALING_GLOSSARY.test(desc)) return true;
// Spell mechanic glossary reminders shown in the spellcasting section
if (REDUNDANT_GLOSSARY.test(desc)) return true;
return false;
}
function actionsByCategory(
items: readonly RawFoundryItem[],
category: string,
excludeName?: string,
hpDetails?: string,
): TraitBlock[] {
return items
.filter(
(a) =>
a.type === "action" &&
(a.system as unknown as ActionSystem).category === category &&
!isRedundantAbility(a, excludeName, hpDetails),
)
.map(normalizeAbility);
}
function extractAbilityMods(
mods: Record<string, { mod: number }>,
): Pf2eCreature["abilityMods"] {
return {
str: mods.str?.mod ?? 0,
dex: mods.dex?.mod ?? 0,
con: mods.con?.mod ?? 0,
int: mods.int?.mod ?? 0,
wis: mods.wis?.mod ?? 0,
cha: mods.cha?.mod ?? 0,
};
}
export function normalizeFoundryCreature(
raw: unknown,
sourceCode?: string,
sourceDisplayName?: string,
): Pf2eCreature {
const r = raw as RawFoundryCreature;
const sys = r.system;
const publication = sys.details?.publication;
const source = sourceCode ?? publication?.title ?? "";
const items = r.items ?? [];
const allSavesText = sys.attributes.allSaves?.value ?? "";
return {
system: "pf2e",
id: makeCreatureId(source, r.name),
name: r.name,
source,
sourceDisplayName: sourceDisplayName ?? publication?.title ?? "",
level: sys.details?.level?.value ?? 0,
traits: buildTraits(sys.traits),
perception: sys.perception?.mod ?? 0,
senses: formatSenses(sys.perception?.senses),
languages: formatLanguages(sys.details?.languages),
skills: formatSkills(sys.skills),
abilityMods: extractAbilityMods(sys.abilities ?? {}),
ac: sys.attributes.ac.value,
acConditional: sys.attributes.ac.details || undefined,
saveFort: sys.saves.fortitude.value,
saveRef: sys.saves.reflex.value,
saveWill: sys.saves.will.value,
saveConditional: allSavesText || undefined,
hp: sys.attributes.hp.max,
hpDetails: sys.attributes.hp.details || undefined,
immunities: formatImmunities(sys.attributes.immunities),
resistances: formatResistances(sys.attributes.resistances),
weaknesses: formatWeaknesses(sys.attributes.weaknesses),
speed: formatSpeed(sys.attributes.speed),
attacks: orUndefined(
items.filter((i) => i.type === "melee").map(normalizeAttack),
),
abilitiesTop: orUndefined(actionsByCategory(items, "interaction")),
abilitiesMid: orUndefined(
actionsByCategory(
items,
"defensive",
allSavesText || undefined,
sys.attributes.hp.details || undefined,
),
),
abilitiesBot: orUndefined(actionsByCategory(items, "offensive")),
spellcasting: orUndefined(normalizeSpellcasting(items)),
};
}
export function normalizeFoundryCreatures(
rawCreatures: unknown[],
sourceCode?: string,
sourceDisplayName?: string,
): Pf2eCreature[] {
return rawCreatures.map((raw) =>
normalizeFoundryCreature(raw, sourceCode, sourceDisplayName),
);
}

View File

@@ -0,0 +1,75 @@
import type {
Pf2eBestiaryIndex,
Pf2eBestiaryIndexEntry,
} from "@initiative/domain";
import rawIndex from "../../../../data/bestiary/pf2e-index.json";
interface CompactCreature {
readonly n: string;
readonly s: string;
readonly lv: number;
readonly ac: number;
readonly hp: number;
readonly pc: number;
readonly sz: string;
readonly tp: string;
readonly f: string;
readonly li: string;
}
interface CompactIndex {
readonly sources: Record<string, string>;
readonly creatures: readonly CompactCreature[];
}
function mapCreature(c: CompactCreature): Pf2eBestiaryIndexEntry {
return {
name: c.n,
source: c.s,
level: c.lv,
ac: c.ac,
hp: c.hp,
perception: c.pc,
size: c.sz,
type: c.tp,
};
}
let cachedIndex: Pf2eBestiaryIndex | undefined;
export function loadPf2eBestiaryIndex(): Pf2eBestiaryIndex {
if (cachedIndex) return cachedIndex;
const compact = rawIndex as unknown as CompactIndex;
cachedIndex = {
sources: compact.sources,
creatures: compact.creatures.map(mapCreature),
};
return cachedIndex;
}
export function getAllPf2eSourceCodes(): string[] {
const index = loadPf2eBestiaryIndex();
return Object.keys(index.sources);
}
export function getDefaultPf2eFetchUrl(
_sourceCode: string,
baseUrl?: string,
): string {
if (baseUrl !== undefined) {
return baseUrl.endsWith("/") ? baseUrl : `${baseUrl}/`;
}
return "https://raw.githubusercontent.com/foundryvtt/pf2e/v13-dev/packs/pf2e/";
}
export function getCreaturePathsForSource(sourceCode: string): string[] {
const compact = rawIndex as unknown as CompactIndex;
return compact.creatures.filter((c) => c.s === sourceCode).map((c) => c.f);
}
export function getPf2eSourceDisplayName(sourceCode: string): string {
const index = loadPf2eBestiaryIndex();
return index.sources[sourceCode] ?? sourceCode;
}

View File

@@ -1,8 +1,9 @@
import type {
AnyCreature,
BestiaryIndex,
Creature,
CreatureId,
Encounter,
Pf2eBestiaryIndex,
PlayerCharacter,
UndoRedoState,
} from "@initiative/domain";
@@ -31,15 +32,16 @@ export interface CachedSourceInfo {
export interface BestiaryCachePort {
cacheSource(
system: string,
sourceCode: string,
displayName: string,
creatures: Creature[],
creatures: AnyCreature[],
): Promise<void>;
isSourceCached(sourceCode: string): Promise<boolean>;
getCachedSources(): Promise<CachedSourceInfo[]>;
clearSource(sourceCode: string): Promise<void>;
isSourceCached(system: string, sourceCode: string): Promise<boolean>;
getCachedSources(system?: string): Promise<CachedSourceInfo[]>;
clearSource(system: string, sourceCode: string): Promise<void>;
clearAll(): Promise<void>;
loadAllCachedCreatures(): Promise<Map<CreatureId, Creature>>;
loadAllCachedCreatures(): Promise<Map<CreatureId, AnyCreature>>;
}
export interface BestiaryIndexPort {
@@ -48,3 +50,11 @@ export interface BestiaryIndexPort {
getDefaultFetchUrl(sourceCode: string, baseUrl?: string): string;
getSourceDisplayName(sourceCode: string): string;
}
export interface Pf2eBestiaryIndexPort {
loadIndex(): Pf2eBestiaryIndex;
getAllSourceCodes(): string[];
getDefaultFetchUrl(sourceCode: string, baseUrl?: string): string;
getSourceDisplayName(sourceCode: string): string;
getCreaturePathsForSource(sourceCode: string): string[];
}

View File

@@ -13,6 +13,7 @@ import {
} from "../persistence/undo-redo-storage.js";
import * as bestiaryCache from "./bestiary-cache.js";
import * as bestiaryIndex from "./bestiary-index-adapter.js";
import * as pf2eBestiaryIndex from "./pf2e-bestiary-index-adapter.js";
export const productionAdapters: Adapters = {
encounterPersistence: {
@@ -41,4 +42,11 @@ export const productionAdapters: Adapters = {
getDefaultFetchUrl: bestiaryIndex.getDefaultFetchUrl,
getSourceDisplayName: bestiaryIndex.getSourceDisplayName,
},
pf2eBestiaryIndex: {
loadIndex: pf2eBestiaryIndex.loadPf2eBestiaryIndex,
getAllSourceCodes: pf2eBestiaryIndex.getAllPf2eSourceCodes,
getDefaultFetchUrl: pf2eBestiaryIndex.getDefaultPf2eFetchUrl,
getSourceDisplayName: pf2eBestiaryIndex.getPf2eSourceDisplayName,
getCreaturePathsForSource: pf2eBestiaryIndex.getCreaturePathsForSource,
},
};

View File

@@ -0,0 +1,99 @@
/**
* Strips Foundry VTT HTML descriptions with enrichment syntax to plain
* readable text. Handles @Damage, @Check, @UUID, @Template and generic
* @Tag patterns as well as common HTML elements.
*/
// -- Enrichment-param helpers --
function formatDamage(params: string): string {
// "3d6+10[fire]" → "3d6+10 fire"
return params.replaceAll(/\[([^\]]*)\]/g, " $1").trim();
}
function formatCheck(params: string): string {
// "reflex|dc:33|basic" → "DC 33 basic Reflex"
const parts = params.split("|");
const type = parts[0] ?? "";
let dc = "";
let basic = false;
for (const part of parts.slice(1)) {
if (part.startsWith("dc:")) {
dc = part.slice(3);
} else if (part === "basic") {
basic = true;
}
}
const label = type.charAt(0).toUpperCase() + type.slice(1);
const dcStr = dc ? `DC ${dc} ` : "";
const basicStr = basic ? "basic " : "";
return `${dcStr}${basicStr}${label}`;
}
function formatTemplate(params: string): string {
// "cone|distance:40" → "40-foot cone"
const parts = params.split("|");
const shape = parts[0] ?? "";
let distance = "";
for (const part of parts.slice(1)) {
if (part.startsWith("distance:")) {
distance = part.slice(9);
}
}
return distance ? `${distance}-foot ${shape}` : shape;
}
export function stripFoundryTags(html: string): string {
if (typeof html !== "string") return String(html);
let result = html;
// Strip Foundry enrichment tags (with optional display text)
// @Tag[params]{display} → display (prefer display text)
// @Tag[params] → extracted content
// @Damage has nested brackets: @Damage[3d6+10[fire]]
result = result.replaceAll(
/@Damage\[((?:[^[\]]|\[[^\]]*\])*)\](?:\{([^}]+)\})?/g,
(_, params: string, display: string | undefined) =>
display ?? formatDamage(params),
);
result = result.replaceAll(
/@Check\[([^\]]+)\](?:\{([^}]*)\})?/g,
(_, params: string) => formatCheck(params),
);
result = result.replaceAll(
/@UUID\[[^\]]+?([^./\]]+)\](?:\{([^}]+)\})?/g,
(_, lastSegment: string, display: string | undefined) =>
display ?? lastSegment,
);
result = result.replaceAll(
/@Template\[([^\]]+)\](?:\{([^}]+)\})?/g,
(_, params: string, display: string | undefined) =>
display ?? formatTemplate(params),
);
// Catch-all for unknown @Tag patterns
result = result.replaceAll(
/@\w+\[[^\]]*\](?:\{([^}]+)\})?/g,
(_, display: string | undefined) => display ?? "",
);
// Strip action-glyph spans (content is a number the renderer handles)
result = result.replaceAll(/<span class="action-glyph">[^<]*<\/span>/gi, "");
// Strip HTML tags
result = result.replaceAll(/<br\s*\/?>/gi, "\n");
result = result.replaceAll(/<hr\s*\/?>/gi, "\n");
result = result.replaceAll(/<\/p>\s*<p[^>]*>/gi, "\n");
result = result.replaceAll(/<[^>]+>/g, "");
// Decode common HTML entities
result = result.replaceAll("&amp;", "&");
result = result.replaceAll("&lt;", "<");
result = result.replaceAll("&gt;", ">");
result = result.replaceAll("&quot;", '"');
// Collapse whitespace
result = result.replaceAll(/[ \t]+/g, " ");
result = result.replaceAll(/\n\s*\n/g, "\n");
return result.trim();
}

View File

@@ -98,20 +98,26 @@ export function stripTags(text: string): string {
// Generic tags: {@tag Display|Source|...} → Display (first segment before |)
// Covers: spell, condition, damage, dice, variantrule, action, skill,
// creature, hazard, status, plus any unknown tags
result = result.replaceAll(
/\{@(\w+)\s+([^}]+)\}/g,
(_, tag: string, content: string) => {
// For tags with Display|Source format, extract first segment
const segments = content.split("|");
// Run in a loop to resolve nested tags (e.g. {@b ... {@spell fireball} ...})
// from innermost to outermost.
const tagPattern = /\{@(\w+)\s+([^}]+)\}/g;
while (tagPattern.test(result)) {
result = result.replaceAll(
tagPattern,
(_, tag: string, content: string) => {
const segments = content.split("|");
// Some tags have a third segment as display text: {@variantrule Name|Source|Display}
if ((tag === "variantrule" || tag === "action") && segments.length >= 3) {
return segments[2];
}
if (
(tag === "variantrule" || tag === "action") &&
segments.length >= 3
) {
return segments[2];
}
return segments[0];
},
);
return segments[0];
},
);
}
return result;
}

View File

@@ -6,6 +6,7 @@ import userEvent from "@testing-library/user-event";
import { afterEach, describe, expect, it, vi } from "vitest";
import { createTestAdapters } from "../../__tests__/adapters/in-memory-adapters.js";
import { AdapterProvider } from "../../contexts/adapter-context.js";
import { RulesEditionProvider } from "../../contexts/rules-edition-context.js";
import { BulkImportPrompt } from "../bulk-import-prompt.js";
const THREE_SOURCES_REGEX = /3 sources/;
@@ -68,9 +69,11 @@ function createAdaptersWithSources() {
function renderWithAdapters() {
const adapters = createAdaptersWithSources();
return render(
<AdapterProvider adapters={adapters}>
<BulkImportPrompt />
</AdapterProvider>,
<RulesEditionProvider>
<AdapterProvider adapters={adapters}>
<BulkImportPrompt />
</AdapterProvider>
</RulesEditionProvider>,
);
}

View File

@@ -1,7 +1,11 @@
// @vitest-environment jsdom
import "@testing-library/jest-dom/vitest";
import { CONDITION_DEFINITIONS, type ConditionId } from "@initiative/domain";
import {
type ConditionEntry,
type ConditionId,
getConditionsForEdition,
} from "@initiative/domain";
import { cleanup, render, screen } from "@testing-library/react";
import userEvent from "@testing-library/user-event";
import { createRef, type RefObject } from "react";
@@ -13,12 +17,14 @@ afterEach(cleanup);
function renderPicker(
overrides: Partial<{
activeConditions: readonly ConditionId[];
activeConditions: readonly ConditionEntry[];
onToggle: (conditionId: ConditionId) => void;
onSetValue: (conditionId: ConditionId, value: number) => void;
onClose: () => void;
}> = {},
) {
const onToggle = overrides.onToggle ?? vi.fn();
const onSetValue = overrides.onSetValue ?? vi.fn();
const onClose = overrides.onClose ?? vi.fn();
const anchorRef = createRef<HTMLElement>() as RefObject<HTMLElement>;
const anchor = document.createElement("div");
@@ -30,25 +36,27 @@ function renderPicker(
anchorRef={anchorRef}
activeConditions={overrides.activeConditions ?? []}
onToggle={onToggle}
onSetValue={onSetValue}
onClose={onClose}
/>
</RulesEditionProvider>,
);
return { ...result, onToggle, onClose };
return { ...result, onToggle, onSetValue, onClose };
}
describe("ConditionPicker", () => {
it("renders all condition definitions from domain", () => {
it("renders edition-specific conditions from domain", () => {
renderPicker();
for (const def of CONDITION_DEFINITIONS) {
const editionConditions = getConditionsForEdition("5.5e");
for (const def of editionConditions) {
expect(screen.getByText(def.label)).toBeInTheDocument();
}
});
it("active conditions are visually distinguished", () => {
renderPicker({ activeConditions: ["blinded"] });
const blindedButton = screen.getByText("Blinded").closest("button");
expect(blindedButton?.className).toContain("bg-card/50");
renderPicker({ activeConditions: [{ id: "blinded" }] });
const row = screen.getByText("Blinded").closest("div[class]");
expect(row?.className).toContain("bg-card/50");
});
it("clicking a condition calls onToggle with that condition's ID", async () => {
@@ -65,7 +73,7 @@ describe("ConditionPicker", () => {
});
it("active condition labels use foreground color", () => {
renderPicker({ activeConditions: ["charmed"] });
renderPicker({ activeConditions: [{ id: "charmed" }] });
const label = screen.getByText("Charmed");
expect(label.className).toContain("text-foreground");
});

View File

@@ -1,5 +1,5 @@
// @vitest-environment jsdom
import type { ConditionId } from "@initiative/domain";
import type { ConditionEntry } from "@initiative/domain";
import { cleanup, render, screen } from "@testing-library/react";
import { userEvent } from "@testing-library/user-event";
import { afterEach, describe, expect, it, vi } from "vitest";
@@ -14,6 +14,7 @@ function renderTags(props: Partial<Parameters<typeof ConditionTags>[0]> = {}) {
<ConditionTags
conditions={props.conditions}
onRemove={props.onRemove ?? (() => {})}
onDecrement={props.onDecrement ?? (() => {})}
onOpenPicker={props.onOpenPicker ?? (() => {})}
/>
</RulesEditionProvider>,
@@ -28,7 +29,7 @@ describe("ConditionTags", () => {
});
it("renders a button per condition", () => {
const conditions: ConditionId[] = ["blinded", "prone"];
const conditions: ConditionEntry[] = [{ id: "blinded" }, { id: "prone" }];
renderTags({ conditions });
expect(
screen.getByRole("button", { name: "Remove Blinded" }),
@@ -39,7 +40,7 @@ describe("ConditionTags", () => {
it("calls onRemove with condition id when clicked", async () => {
const onRemove = vi.fn();
renderTags({
conditions: ["blinded"] as ConditionId[],
conditions: [{ id: "blinded" }] as ConditionEntry[],
onRemove,
});
@@ -66,4 +67,37 @@ describe("ConditionTags", () => {
// Only add button
expect(screen.getByRole("button", { name: "Add condition" })).toBeDefined();
});
it("displays value badge for valued conditions", () => {
renderTags({ conditions: [{ id: "frightened", value: 3 }] });
expect(screen.getByText("3")).toBeDefined();
});
it("calls onDecrement for valued condition click", async () => {
const onDecrement = vi.fn();
renderTags({
conditions: [{ id: "frightened", value: 2 }],
onDecrement,
});
await userEvent.click(
screen.getByRole("button", { name: "Remove Frightened" }),
);
expect(onDecrement).toHaveBeenCalledWith("frightened");
});
it("calls onRemove for non-valued condition click", async () => {
const onRemove = vi.fn();
renderTags({
conditions: [{ id: "blinded" }],
onRemove,
});
await userEvent.click(
screen.getByRole("button", { name: "Remove Blinded" }),
);
expect(onRemove).toHaveBeenCalledWith("blinded");
});
});

View File

@@ -3,7 +3,13 @@ import "@testing-library/jest-dom/vitest";
import type { Creature, CreatureId, PlayerCharacter } from "@initiative/domain";
import { combatantId, creatureId, playerCharacterId } from "@initiative/domain";
import { cleanup, render, screen, waitFor } from "@testing-library/react";
import {
cleanup,
render,
renderHook,
screen,
waitFor,
} from "@testing-library/react";
import userEvent from "@testing-library/user-event";
import { afterEach, beforeAll, describe, expect, it, vi } from "vitest";
import { createTestAdapters } from "../../__tests__/adapters/in-memory-adapters.js";
@@ -13,6 +19,7 @@ import {
buildEncounter,
} from "../../__tests__/factories/index.js";
import { AllProviders } from "../../__tests__/test-providers.js";
import { useRulesEdition } from "../../hooks/use-rules-edition.js";
import { DifficultyBreakdownPanel } from "../difficulty-breakdown-panel.js";
beforeAll(() => {
@@ -121,7 +128,7 @@ describe("DifficultyBreakdownPanel", () => {
});
});
it("renders bestiary combatant as read-only with source name", async () => {
it("shows PC in party column with level", async () => {
renderPanel({
encounter: defaultEncounter(),
playerCharacters: defaultPCs,
@@ -129,12 +136,53 @@ describe("DifficultyBreakdownPanel", () => {
});
await waitFor(() => {
expect(screen.getByText("Goblin (SRD)")).toBeInTheDocument();
expect(screen.getByText("Hero")).toBeInTheDocument();
expect(screen.getByText("Lv 5")).toBeInTheDocument();
});
});
it("shows monsters in enemy column", async () => {
renderPanel({
encounter: defaultEncounter(),
playerCharacters: defaultPCs,
creatures: new Map([[goblinCreature.id, goblinCreature]]),
});
await waitFor(() => {
expect(screen.getByText("Goblin")).toBeInTheDocument();
expect(screen.getAllByText("CR 1/4").length).toBeGreaterThanOrEqual(1);
});
});
it("renders custom combatant with CR picker", async () => {
it("renders explanation text", async () => {
renderPanel({
encounter: defaultEncounter(),
playerCharacters: defaultPCs,
creatures: new Map([[goblinCreature.id, goblinCreature]]),
});
await waitFor(() => {
expect(
screen.getByText(
"Allied NPC XP is subtracted from encounter difficulty",
),
).toBeInTheDocument();
});
});
it("renders Net Monster XP footer", async () => {
renderPanel({
encounter: defaultEncounter(),
playerCharacters: defaultPCs,
creatures: new Map([[goblinCreature.id, goblinCreature]]),
});
await waitFor(() => {
expect(screen.getByText("Net Monster XP")).toBeInTheDocument();
});
});
it("renders custom combatant with CR picker in enemy column", async () => {
renderPanel({
encounter: defaultEncounter(),
playerCharacters: defaultPCs,
@@ -144,27 +192,10 @@ describe("DifficultyBreakdownPanel", () => {
await waitFor(() => {
const pickers = screen.getAllByLabelText("Challenge rating");
expect(pickers).toHaveLength(2);
// First picker is "Custom Thug" with CR 2
expect(pickers[0]).toHaveValue("2");
});
});
it("renders unassigned combatant with Assign picker and dash for XP", async () => {
renderPanel({
encounter: defaultEncounter(),
playerCharacters: defaultPCs,
creatures: new Map([[goblinCreature.id, goblinCreature]]),
});
await waitFor(() => {
const pickers = screen.getAllByLabelText("Challenge rating");
// Second picker is "Bandit" with no CR
expect(pickers[1]).toHaveValue("");
// "—" appears for unassigned XP
expect(screen.getByText("—")).toBeInTheDocument();
});
});
it("selecting a CR updates the visible XP value", async () => {
const user = userEvent.setup();
renderPanel({
@@ -173,24 +204,19 @@ describe("DifficultyBreakdownPanel", () => {
creatures: new Map([[goblinCreature.id, goblinCreature]]),
});
// Wait for the panel to render with bestiary data
await waitFor(() => {
expect(screen.getByText("—")).toBeInTheDocument();
expect(screen.getAllByLabelText("Challenge rating")).toHaveLength(2);
});
// The Bandit (second picker) has no CR — shows "—" for XP
const pickers = screen.getAllByLabelText("Challenge rating");
// Select CR 5 (1,800 XP) on Bandit
await user.selectOptions(pickers[1], "5");
// XP should update — the "—" should be replaced with an XP value
await waitFor(() => {
expect(screen.getByText("1,800")).toBeInTheDocument();
});
});
it("renders total monster XP", async () => {
it("non-PC combatants show toggle button", async () => {
renderPanel({
encounter: defaultEncounter(),
playerCharacters: defaultPCs,
@@ -198,12 +224,57 @@ describe("DifficultyBreakdownPanel", () => {
});
await waitFor(() => {
expect(screen.getByText("Total Monster XP")).toBeInTheDocument();
// Each non-PC enemy combatant has a toggle button
expect(
screen.getByLabelText("Move Goblin to party side"),
).toBeInTheDocument();
expect(
screen.getByLabelText("Move Custom Thug to party side"),
).toBeInTheDocument();
});
});
it("PC combatants do not show side toggle", async () => {
renderPanel({
encounter: defaultEncounter(),
playerCharacters: defaultPCs,
creatures: new Map([[goblinCreature.id, goblinCreature]]),
});
await waitFor(() => {
expect(screen.getByText("Hero")).toBeInTheDocument();
});
expect(
screen.queryByLabelText("Move Hero to enemy side"),
).not.toBeInTheDocument();
});
it("side toggle moves combatant between sections", async () => {
const user = userEvent.setup();
renderPanel({
encounter: defaultEncounter(),
playerCharacters: defaultPCs,
creatures: new Map([[goblinCreature.id, goblinCreature]]),
});
await waitFor(() => {
expect(screen.getByText("Goblin")).toBeInTheDocument();
});
// Toggle goblin to party side
const toggleBtn = screen.getByLabelText("Move Goblin to party side");
await user.click(toggleBtn);
// After toggle, the aria-label should change to "Move Goblin to enemy side"
await waitFor(() => {
expect(
screen.getByLabelText("Move Goblin to enemy side"),
).toBeInTheDocument();
});
});
it("renders nothing when breakdown data is insufficient", () => {
// No PCs with level → breakdown returns null
const { container } = renderPanel({
encounter: buildEncounter({
combatants: [
@@ -215,6 +286,63 @@ describe("DifficultyBreakdownPanel", () => {
expect(container.innerHTML).toBe("");
});
it("shows 4 threshold columns for 2014 edition", async () => {
const { result: editionResult } = renderHook(() => useRulesEdition());
editionResult.current.setEdition("5e");
try {
renderPanel({
encounter: defaultEncounter(),
playerCharacters: defaultPCs,
creatures: new Map([[goblinCreature.id, goblinCreature]]),
});
await waitFor(() => {
expect(screen.getByText("Easy:", { exact: false })).toBeInTheDocument();
expect(screen.getByText("Med:", { exact: false })).toBeInTheDocument();
expect(screen.getByText("Hard:", { exact: false })).toBeInTheDocument();
expect(
screen.getByText("Deadly:", { exact: false }),
).toBeInTheDocument();
});
} finally {
editionResult.current.setEdition("5.5e");
}
});
it("shows multiplier and adjusted XP for 2014 edition", async () => {
const { result: editionResult } = renderHook(() => useRulesEdition());
editionResult.current.setEdition("5e");
try {
renderPanel({
encounter: defaultEncounter(),
playerCharacters: defaultPCs,
creatures: new Map([[goblinCreature.id, goblinCreature]]),
});
await waitFor(() => {
expect(screen.getByText("Monster XP")).toBeInTheDocument();
// 1 PC (<3) triggers party size adjustment
expect(screen.getByText("Adjusted for 1 PC")).toBeInTheDocument();
});
} finally {
editionResult.current.setEdition("5.5e");
}
});
it("shows Net Monster XP for 5.5e edition (no multiplier)", async () => {
renderPanel({
encounter: defaultEncounter(),
playerCharacters: defaultPCs,
creatures: new Map([[goblinCreature.id, goblinCreature]]),
});
await waitFor(() => {
expect(screen.getByText("Net Monster XP")).toBeInTheDocument();
});
});
it("calls onClose when Escape is pressed", async () => {
const user = userEvent.setup();
const onClose = vi.fn();

View File

@@ -3,7 +3,11 @@ import type { DifficultyResult } from "@initiative/domain";
import { cleanup, render, screen } from "@testing-library/react";
import userEvent from "@testing-library/user-event";
import { afterEach, describe, expect, it, vi } from "vitest";
import { DifficultyIndicator } from "../difficulty-indicator.js";
import {
DifficultyIndicator,
TIER_LABELS_5_5E,
TIER_LABELS_2014,
} from "../difficulty-indicator.js";
afterEach(cleanup);
@@ -11,50 +15,77 @@ function makeResult(tier: DifficultyResult["tier"]): DifficultyResult {
return {
tier,
totalMonsterXp: 100,
partyBudget: { low: 50, moderate: 100, high: 200 },
thresholds: [
{ label: "Low", value: 50 },
{ label: "Moderate", value: 100 },
{ label: "High", value: 200 },
],
encounterMultiplier: undefined,
adjustedXp: undefined,
partySizeAdjusted: undefined,
};
}
describe("DifficultyIndicator", () => {
it("renders 3 bars", () => {
const { container } = render(
<DifficultyIndicator result={makeResult("moderate")} />,
<DifficultyIndicator result={makeResult(2)} labels={TIER_LABELS_5_5E} />,
);
const bars = container.querySelectorAll("[class*='rounded-sm']");
expect(bars).toHaveLength(3);
});
it("shows 'Trivial encounter difficulty' label for trivial tier", () => {
render(<DifficultyIndicator result={makeResult("trivial")} />);
it("shows 'Trivial encounter difficulty' for 5.5e tier 0", () => {
render(
<DifficultyIndicator result={makeResult(0)} labels={TIER_LABELS_5_5E} />,
);
expect(
screen.getByRole("img", {
name: "Trivial encounter difficulty",
}),
screen.getByRole("img", { name: "Trivial encounter difficulty" }),
).toBeDefined();
});
it("shows 'Low encounter difficulty' label for low tier", () => {
render(<DifficultyIndicator result={makeResult("low")} />);
it("shows 'Low encounter difficulty' for 5.5e tier 1", () => {
render(
<DifficultyIndicator result={makeResult(1)} labels={TIER_LABELS_5_5E} />,
);
expect(
screen.getByRole("img", { name: "Low encounter difficulty" }),
).toBeDefined();
});
it("shows 'Moderate encounter difficulty' label for moderate tier", () => {
render(<DifficultyIndicator result={makeResult("moderate")} />);
it("shows 'Moderate encounter difficulty' for 5.5e tier 2", () => {
render(
<DifficultyIndicator result={makeResult(2)} labels={TIER_LABELS_5_5E} />,
);
expect(
screen.getByRole("img", {
name: "Moderate encounter difficulty",
}),
screen.getByRole("img", { name: "Moderate encounter difficulty" }),
).toBeDefined();
});
it("shows 'High encounter difficulty' label for high tier", () => {
render(<DifficultyIndicator result={makeResult("high")} />);
it("shows 'High encounter difficulty' for 5.5e tier 3", () => {
render(
<DifficultyIndicator result={makeResult(3)} labels={TIER_LABELS_5_5E} />,
);
expect(
screen.getByRole("img", {
name: "High encounter difficulty",
}),
screen.getByRole("img", { name: "High encounter difficulty" }),
).toBeDefined();
});
it("shows 'Easy encounter difficulty' for 2014 tier 0", () => {
render(
<DifficultyIndicator result={makeResult(0)} labels={TIER_LABELS_2014} />,
);
expect(
screen.getByRole("img", { name: "Easy encounter difficulty" }),
).toBeDefined();
});
it("shows 'Deadly encounter difficulty' for 2014 tier 3", () => {
render(
<DifficultyIndicator result={makeResult(3)} labels={TIER_LABELS_2014} />,
);
expect(
screen.getByRole("img", { name: "Deadly encounter difficulty" }),
).toBeDefined();
});
@@ -63,22 +94,21 @@ describe("DifficultyIndicator", () => {
const handleClick = vi.fn();
render(
<DifficultyIndicator
result={makeResult("moderate")}
result={makeResult(2)}
labels={TIER_LABELS_5_5E}
onClick={handleClick}
/>,
);
await user.click(
screen.getByRole("img", {
name: "Moderate encounter difficulty",
}),
screen.getByRole("img", { name: "Moderate encounter difficulty" }),
);
expect(handleClick).toHaveBeenCalledOnce();
});
it("renders as div when onClick not provided", () => {
const { container } = render(
<DifficultyIndicator result={makeResult("moderate")} />,
<DifficultyIndicator result={makeResult(2)} labels={TIER_LABELS_5_5E} />,
);
const element = container.querySelector("[role='img']");
expect(element?.tagName).toBe("DIV");
@@ -87,7 +117,8 @@ describe("DifficultyIndicator", () => {
it("renders as button when onClick provided", () => {
const { container } = render(
<DifficultyIndicator
result={makeResult("moderate")}
result={makeResult(2)}
labels={TIER_LABELS_5_5E}
onClick={() => {}}
/>,
);

View File

@@ -0,0 +1,370 @@
// @vitest-environment jsdom
import "@testing-library/jest-dom/vitest";
import type { Pf2eCreature } from "@initiative/domain";
import { creatureId } from "@initiative/domain";
import { cleanup, render, screen } from "@testing-library/react";
import userEvent from "@testing-library/user-event";
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
import { Pf2eStatBlock } from "../pf2e-stat-block.js";
afterEach(cleanup);
const USES_PER_DAY_REGEX = /×3/;
const HEAL_DESCRIPTION_REGEX = /channel positive energy/;
const PERCEPTION_SENSES_REGEX = /\+2.*Darkvision/;
const SKILLS_REGEX = /Acrobatics \+5.*Stealth \+5/;
const SAVE_CONDITIONAL_REGEX = /\+12.*\+1 status to all saves vs\. magic/;
const SAVE_CONDITIONAL_ABSENT_REGEX = /status to all saves/;
const HP_DETAILS_REGEX = /115.*regeneration 20/;
const REGEN_REGEX = /regeneration/;
const ATTACK_NAME_REGEX = /Dogslicer/;
const ATTACK_DAMAGE_REGEX = /1d6 slashing/;
const SPELLCASTING_ENTRY_REGEX = /Divine Innate Spells\./;
const ABILITY_MID_NAME_REGEX = /Goblin Scuttle/;
const ABILITY_MID_DESC_REGEX = /The goblin Steps\./;
const CANTRIPS_REGEX = /Cantrips:/;
const AC_REGEX = /16/;
const GOBLIN_WARRIOR: Pf2eCreature = {
system: "pf2e",
id: creatureId("pathfinder-monster-core:goblin-warrior"),
name: "Goblin Warrior",
source: "pathfinder-monster-core",
sourceDisplayName: "Monster Core",
level: -1,
traits: ["small", "goblin", "humanoid"],
perception: 2,
senses: "Darkvision",
languages: "Common, Goblin",
skills: "Acrobatics +5, Athletics +2, Nature +1, Stealth +5",
abilityMods: { str: 0, dex: 3, con: 1, int: 0, wis: -1, cha: 1 },
ac: 16,
saveFort: 5,
saveRef: 7,
saveWill: 3,
hp: 6,
speed: "25 feet",
attacks: [
{
name: "Dogslicer",
activity: { number: 1, unit: "action" },
segments: [
{
type: "text",
value: "+7 (agile, backstabber, finesse), 1d6 slashing",
},
],
},
],
abilitiesMid: [
{
name: "Goblin Scuttle",
activity: { number: 1, unit: "reaction" },
segments: [{ type: "text", value: "The goblin Steps." }],
},
],
};
const NAUNET: Pf2eCreature = {
system: "pf2e",
id: creatureId("pathfinder-monster-core-2:naunet"),
name: "Naunet",
source: "pathfinder-monster-core-2",
sourceDisplayName: "Monster Core 2",
level: 7,
traits: ["large", "monitor", "protean"],
perception: 14,
senses: "Darkvision",
languages: "Chthonian, Empyrean, Protean",
skills:
"Acrobatics +14, Athletics +16, Intimidation +16, Stealth +14, Survival +12",
abilityMods: { str: 5, dex: 3, con: 5, int: 0, wis: 3, cha: 3 },
ac: 24,
saveFort: 18,
saveRef: 14,
saveWill: 12,
saveConditional: "+1 status to all saves vs. magic",
hp: 120,
resistances: "Precision 5, Protean anatomy 10",
speed: "25 feet, Fly 30 feet, Swim 25 feet (unfettered movement)",
spellcasting: [
{
name: "Divine Innate Spells",
headerText: "DC 25, attack +17",
daily: [
{
uses: 4,
each: true,
spells: [{ name: "Unfettered Movement (Constant)" }],
},
],
atWill: [{ name: "Detect Magic" }],
},
],
};
const TROLL: Pf2eCreature = {
system: "pf2e",
id: creatureId("pathfinder-monster-core:forest-troll"),
name: "Forest Troll",
source: "pathfinder-monster-core",
sourceDisplayName: "Monster Core",
level: 5,
traits: ["large", "giant", "troll"],
perception: 11,
senses: "Darkvision",
languages: "Jotun",
skills: "Athletics +12, Intimidation +12",
abilityMods: { str: 5, dex: 2, con: 6, int: -2, wis: 0, cha: -2 },
ac: 20,
saveFort: 17,
saveRef: 11,
saveWill: 7,
hp: 115,
hpDetails: "regeneration 20 (deactivated by acid or fire)",
weaknesses: "Fire 10",
speed: "30 feet",
};
function renderStatBlock(creature: Pf2eCreature) {
return render(<Pf2eStatBlock creature={creature} />);
}
describe("Pf2eStatBlock", () => {
describe("header", () => {
it("renders creature name and level", () => {
renderStatBlock(GOBLIN_WARRIOR);
expect(
screen.getByRole("heading", { name: "Goblin Warrior" }),
).toBeInTheDocument();
expect(screen.getByText("Level -1")).toBeInTheDocument();
});
it("renders traits as tags", () => {
renderStatBlock(GOBLIN_WARRIOR);
expect(screen.getByText("Small")).toBeInTheDocument();
expect(screen.getByText("Goblin")).toBeInTheDocument();
expect(screen.getByText("Humanoid")).toBeInTheDocument();
});
it("renders source display name", () => {
renderStatBlock(GOBLIN_WARRIOR);
expect(screen.getByText("Monster Core")).toBeInTheDocument();
});
});
describe("perception and senses", () => {
it("renders perception modifier and senses", () => {
renderStatBlock(GOBLIN_WARRIOR);
expect(screen.getByText("Perception")).toBeInTheDocument();
expect(screen.getByText(PERCEPTION_SENSES_REGEX)).toBeInTheDocument();
});
it("renders languages", () => {
renderStatBlock(GOBLIN_WARRIOR);
expect(screen.getByText("Languages")).toBeInTheDocument();
expect(screen.getByText("Common, Goblin")).toBeInTheDocument();
});
it("renders skills", () => {
renderStatBlock(GOBLIN_WARRIOR);
expect(screen.getByText("Skills")).toBeInTheDocument();
expect(screen.getByText(SKILLS_REGEX)).toBeInTheDocument();
});
});
describe("ability modifiers", () => {
it("renders all six ability labels", () => {
renderStatBlock(GOBLIN_WARRIOR);
for (const label of ["Str", "Dex", "Con", "Int", "Wis", "Cha"]) {
expect(screen.getByText(label)).toBeInTheDocument();
}
});
it("renders positive and negative modifiers", () => {
renderStatBlock(GOBLIN_WARRIOR);
expect(screen.getByText("+3")).toBeInTheDocument();
expect(screen.getByText("-1")).toBeInTheDocument();
});
});
describe("defenses", () => {
it("renders AC and saves", () => {
renderStatBlock(GOBLIN_WARRIOR);
expect(screen.getByText("AC")).toBeInTheDocument();
expect(screen.getByText(AC_REGEX)).toBeInTheDocument();
expect(screen.getByText("Fort")).toBeInTheDocument();
expect(screen.getByText("Ref")).toBeInTheDocument();
expect(screen.getByText("Will")).toBeInTheDocument();
});
it("renders HP", () => {
renderStatBlock(GOBLIN_WARRIOR);
expect(screen.getByText("HP")).toBeInTheDocument();
expect(screen.getByText("6")).toBeInTheDocument();
});
it("renders saveConditional inline with saves", () => {
renderStatBlock(NAUNET);
expect(screen.getByText(SAVE_CONDITIONAL_REGEX)).toBeInTheDocument();
});
it("omits saveConditional when absent", () => {
renderStatBlock(GOBLIN_WARRIOR);
expect(
screen.queryByText(SAVE_CONDITIONAL_ABSENT_REGEX),
).not.toBeInTheDocument();
});
it("renders hpDetails in parentheses after HP", () => {
renderStatBlock(TROLL);
expect(screen.getByText(HP_DETAILS_REGEX)).toBeInTheDocument();
});
it("omits hpDetails when absent", () => {
renderStatBlock(GOBLIN_WARRIOR);
expect(screen.queryByText(REGEN_REGEX)).not.toBeInTheDocument();
});
it("renders resistances and weaknesses", () => {
renderStatBlock(NAUNET);
expect(screen.getByText("Resistances")).toBeInTheDocument();
expect(
screen.getByText("Precision 5, Protean anatomy 10"),
).toBeInTheDocument();
});
});
describe("abilities", () => {
it("renders mid (defensive) abilities", () => {
renderStatBlock(GOBLIN_WARRIOR);
expect(screen.getByText(ABILITY_MID_NAME_REGEX)).toBeInTheDocument();
expect(screen.getByText(ABILITY_MID_DESC_REGEX)).toBeInTheDocument();
});
});
describe("speed and attacks", () => {
it("renders speed", () => {
renderStatBlock(GOBLIN_WARRIOR);
expect(screen.getByText("Speed")).toBeInTheDocument();
expect(screen.getByText("25 feet")).toBeInTheDocument();
});
it("renders attacks", () => {
renderStatBlock(GOBLIN_WARRIOR);
expect(screen.getByText(ATTACK_NAME_REGEX)).toBeInTheDocument();
expect(screen.getByText(ATTACK_DAMAGE_REGEX)).toBeInTheDocument();
});
});
describe("spellcasting", () => {
it("renders spellcasting entry with header", () => {
renderStatBlock(NAUNET);
expect(screen.getByText(SPELLCASTING_ENTRY_REGEX)).toBeInTheDocument();
expect(screen.getByText("DC 25, attack +17")).toBeInTheDocument();
});
it("renders ranked spells", () => {
renderStatBlock(NAUNET);
expect(screen.getByText("Rank 4:")).toBeInTheDocument();
expect(
screen.getByText("Unfettered Movement (Constant)"),
).toBeInTheDocument();
});
it("renders cantrips", () => {
renderStatBlock(NAUNET);
expect(screen.getByText("Cantrips:")).toBeInTheDocument();
expect(screen.getByText("Detect Magic")).toBeInTheDocument();
});
it("omits spellcasting when absent", () => {
renderStatBlock(GOBLIN_WARRIOR);
expect(screen.queryByText(CANTRIPS_REGEX)).not.toBeInTheDocument();
});
});
describe("clickable spells", () => {
const SPELLCASTER: Pf2eCreature = {
...NAUNET,
id: creatureId("test:spellcaster"),
name: "Spellcaster",
spellcasting: [
{
name: "Divine Innate Spells",
headerText: "DC 30, attack +20",
atWill: [{ name: "Detect Magic", rank: 1 }],
daily: [
{
uses: 4,
each: true,
spells: [
{
name: "Heal",
description: "You channel positive energy to heal.",
rank: 4,
usesPerDay: 3,
},
{ name: "Restoration", rank: 4 },
],
},
],
},
],
};
beforeEach(() => {
Object.defineProperty(globalThis, "matchMedia", {
writable: true,
configurable: true,
value: vi.fn().mockImplementation(() => ({
matches: true,
media: "(min-width: 1024px)",
onchange: null,
addEventListener: vi.fn(),
removeEventListener: vi.fn(),
addListener: vi.fn(),
removeListener: vi.fn(),
dispatchEvent: vi.fn(),
})),
});
});
it("renders a spell with a description as a clickable button", () => {
renderStatBlock(SPELLCASTER);
expect(screen.getByRole("button", { name: "Heal" })).toBeInTheDocument();
});
it("renders a spell without description as plain text (not a button)", () => {
renderStatBlock(SPELLCASTER);
expect(
screen.queryByRole("button", { name: "Restoration" }),
).not.toBeInTheDocument();
expect(screen.getByText("Restoration")).toBeInTheDocument();
});
it("renders usesPerDay as plain text alongside the spell button", () => {
renderStatBlock(SPELLCASTER);
expect(screen.getByText(USES_PER_DAY_REGEX)).toBeInTheDocument();
});
it("opens the spell popover when a spell button is clicked", async () => {
const user = userEvent.setup();
renderStatBlock(SPELLCASTER);
await user.click(screen.getByRole("button", { name: "Heal" }));
expect(screen.getByText(HEAL_DESCRIPTION_REGEX)).toBeInTheDocument();
});
it("closes the popover when Escape is pressed", async () => {
const user = userEvent.setup();
renderStatBlock(SPELLCASTER);
await user.click(screen.getByRole("button", { name: "Heal" }));
expect(screen.getByText(HEAL_DESCRIPTION_REGEX)).toBeInTheDocument();
await user.keyboard("{Escape}");
expect(
screen.queryByText(HEAL_DESCRIPTION_REGEX),
).not.toBeInTheDocument();
});
});
});

View File

@@ -37,14 +37,18 @@ function renderModal(open = true) {
}
describe("SettingsModal", () => {
it("renders edition toggle buttons", () => {
it("renders game system section with all three options", () => {
renderModal();
expect(screen.getByText("Game System")).toBeInTheDocument();
expect(
screen.getByRole("button", { name: "5e (2014)" }),
).toBeInTheDocument();
expect(
screen.getByRole("button", { name: "5.5e (2024)" }),
).toBeInTheDocument();
expect(
screen.getByRole("button", { name: "Pathfinder 2e" }),
).toBeInTheDocument();
});
it("renders theme toggle buttons", () => {

View File

@@ -6,6 +6,7 @@ import userEvent from "@testing-library/user-event";
import { afterEach, describe, expect, it, vi } from "vitest";
import { createTestAdapters } from "../../__tests__/adapters/in-memory-adapters.js";
import { AdapterProvider } from "../../contexts/adapter-context.js";
import { RulesEditionProvider } from "../../contexts/rules-edition-context.js";
import { SourceFetchPrompt } from "../source-fetch-prompt.js";
const MONSTER_MANUAL_REGEX = /Monster Manual/;
@@ -36,12 +37,14 @@ function renderPrompt(sourceCode = "MM") {
code === "MM" ? "Monster Manual" : code,
};
const result = render(
<AdapterProvider adapters={adapters}>
<SourceFetchPrompt
sourceCode={sourceCode}
onSourceLoaded={onSourceLoaded}
/>
</AdapterProvider>,
<RulesEditionProvider>
<AdapterProvider adapters={adapters}>
<SourceFetchPrompt
sourceCode={sourceCode}
onSourceLoaded={onSourceLoaded}
/>
</AdapterProvider>
</RulesEditionProvider>,
);
return { ...result, onSourceLoaded };
}

View File

@@ -28,7 +28,7 @@ beforeAll(() => {
afterEach(cleanup);
function renderWithSources(sources: CachedSourceInfo[] = []) {
function renderWithSources(sources: CachedSourceInfo[] = []): void {
const adapters = createTestAdapters();
// Wire getCachedSources to return the provided sources initially,
// then empty after clear operations
@@ -36,7 +36,7 @@ function renderWithSources(sources: CachedSourceInfo[] = []) {
adapters.bestiaryCache = {
...adapters.bestiaryCache,
getCachedSources: () => Promise.resolve(currentSources),
clearSource(sourceCode) {
clearSource(_system, sourceCode) {
currentSources = currentSources.filter(
(s) => s.sourceCode !== sourceCode,
);
@@ -57,14 +57,14 @@ function renderWithSources(sources: CachedSourceInfo[] = []) {
describe("SourceManager", () => {
it("shows 'No cached sources' empty state when no sources", async () => {
void renderWithSources([]);
renderWithSources([]);
await waitFor(() => {
expect(screen.getByText("No cached sources")).toBeInTheDocument();
});
});
it("lists cached sources with display name and creature count", async () => {
void renderWithSources([
renderWithSources([
{
sourceCode: "mm",
displayName: "Monster Manual",
@@ -88,7 +88,7 @@ describe("SourceManager", () => {
it("Clear All button removes all sources", async () => {
const user = userEvent.setup();
void renderWithSources([
renderWithSources([
{
sourceCode: "mm",
displayName: "Monster Manual",
@@ -110,7 +110,7 @@ describe("SourceManager", () => {
it("individual source delete button removes that source", async () => {
const user = userEvent.setup();
void renderWithSources([
renderWithSources([
{
sourceCode: "mm",
displayName: "Monster Manual",

View File

@@ -0,0 +1,158 @@
// @vitest-environment jsdom
import "@testing-library/jest-dom/vitest";
import type { SpellReference } from "@initiative/domain";
import { cleanup, fireEvent, render, screen } from "@testing-library/react";
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
import { SpellDetailPopover } from "../spell-detail-popover.js";
afterEach(cleanup);
const FIREBALL: SpellReference = {
name: "Fireball",
slug: "fireball",
rank: 3,
description: "A spark leaps from your fingertip to the target.",
traits: ["fire", "manipulate"],
traditions: ["arcane", "primal"],
range: "500 feet",
area: "20-foot burst",
defense: "basic Reflex",
actionCost: "2",
heightening: "Heightened (+1) The damage increases by 2d6.",
};
const ANCHOR: DOMRect = new DOMRect(100, 100, 50, 20);
const SPARK_LEAPS_REGEX = /spark leaps/;
const HEIGHTENED_REGEX = /Heightened.*2d6/;
const RANGE_REGEX = /500 feet/;
const AREA_REGEX = /20-foot burst/;
const DEFENSE_REGEX = /basic Reflex/;
const NO_DESCRIPTION_REGEX = /No description available/;
const DIALOG_LABEL_REGEX = /Spell details: Fireball/;
beforeEach(() => {
// Force desktop variant in jsdom
Object.defineProperty(globalThis, "matchMedia", {
writable: true,
configurable: true,
value: vi.fn().mockImplementation(() => ({
matches: true,
media: "(min-width: 1024px)",
onchange: null,
addEventListener: vi.fn(),
removeEventListener: vi.fn(),
addListener: vi.fn(),
removeListener: vi.fn(),
dispatchEvent: vi.fn(),
})),
});
});
describe("SpellDetailPopover", () => {
it("renders spell name, rank, traits, and description", () => {
render(
<SpellDetailPopover
spell={FIREBALL}
anchorRect={ANCHOR}
onClose={() => {}}
/>,
);
expect(screen.getByText("Fireball")).toBeInTheDocument();
expect(screen.getByText("3rd")).toBeInTheDocument();
expect(screen.getByText("fire")).toBeInTheDocument();
expect(screen.getByText("manipulate")).toBeInTheDocument();
expect(screen.getByText(SPARK_LEAPS_REGEX)).toBeInTheDocument();
});
it("renders heightening rules when present", () => {
render(
<SpellDetailPopover
spell={FIREBALL}
anchorRect={ANCHOR}
onClose={() => {}}
/>,
);
expect(screen.getByText(HEIGHTENED_REGEX)).toBeInTheDocument();
});
it("renders range, area, and defense", () => {
render(
<SpellDetailPopover
spell={FIREBALL}
anchorRect={ANCHOR}
onClose={() => {}}
/>,
);
expect(screen.getByText(RANGE_REGEX)).toBeInTheDocument();
expect(screen.getByText(AREA_REGEX)).toBeInTheDocument();
expect(screen.getByText(DEFENSE_REGEX)).toBeInTheDocument();
});
it("calls onClose when Escape is pressed", () => {
const onClose = vi.fn();
render(
<SpellDetailPopover
spell={FIREBALL}
anchorRect={ANCHOR}
onClose={onClose}
/>,
);
fireEvent.keyDown(document, { key: "Escape" });
expect(onClose).toHaveBeenCalledTimes(1);
});
it("shows placeholder when description is missing", () => {
const spell: SpellReference = { name: "Mystery", rank: 1 };
render(
<SpellDetailPopover
spell={spell}
anchorRect={ANCHOR}
onClose={() => {}}
/>,
);
expect(screen.getByText(NO_DESCRIPTION_REGEX)).toBeInTheDocument();
});
it("renders the action cost as an icon when it is a numeric action count", () => {
render(
<SpellDetailPopover
spell={FIREBALL}
anchorRect={ANCHOR}
onClose={() => {}}
/>,
);
// Action cost "2" renders as an SVG ActivityIcon (portaled to body)
const dialog = screen.getByRole("dialog");
expect(dialog.querySelector("svg")).toBeInTheDocument();
});
it("renders non-numeric action cost as text", () => {
const spell: SpellReference = {
...FIREBALL,
actionCost: "1 minute",
};
render(
<SpellDetailPopover
spell={spell}
anchorRect={ANCHOR}
onClose={() => {}}
/>,
);
expect(screen.getByText("1 minute")).toBeInTheDocument();
});
it("uses the dialog role with the spell name as label", () => {
render(
<SpellDetailPopover
spell={FIREBALL}
anchorRect={ANCHOR}
onClose={() => {}}
/>,
);
expect(
screen.getByRole("dialog", { name: DIALOG_LABEL_REGEX }),
).toBeInTheDocument();
});
});

View File

@@ -5,7 +5,7 @@ import type { Creature } from "@initiative/domain";
import { creatureId } from "@initiative/domain";
import { cleanup, render, screen } from "@testing-library/react";
import { afterEach, describe, expect, it } from "vitest";
import { StatBlock } from "../stat-block.js";
import { DndStatBlock as StatBlock } from "../dnd-stat-block.js";
afterEach(cleanup);
@@ -46,10 +46,30 @@ const GOBLIN: Creature = {
skills: "Stealth +6",
senses: "darkvision 60 ft., passive Perception 9",
languages: "Common, Goblin",
traits: [{ name: "Nimble Escape", text: "Disengage or Hide as bonus." }],
actions: [{ name: "Scimitar", text: "Melee: +4 to hit, 5 slashing." }],
bonusActions: [{ name: "Nimble", text: "Disengage or Hide." }],
reactions: [{ name: "Redirect", text: "Redirect attack to ally." }],
traits: [
{
name: "Nimble Escape",
segments: [{ type: "text", value: "Disengage or Hide as bonus." }],
},
],
actions: [
{
name: "Scimitar",
segments: [{ type: "text", value: "Melee: +4 to hit, 5 slashing." }],
},
],
bonusActions: [
{
name: "Nimble",
segments: [{ type: "text", value: "Disengage or Hide." }],
},
],
reactions: [
{
name: "Redirect",
segments: [{ type: "text", value: "Redirect attack to ally." }],
},
],
};
const DRAGON: Creature = {
@@ -75,17 +95,31 @@ const DRAGON: Creature = {
legendaryActions: {
preamble: "The dragon can take 3 legendary actions.",
entries: [
{ name: "Detect", text: "Wisdom (Perception) check." },
{ name: "Tail Attack", text: "Tail attack." },
{
name: "Detect",
segments: [
{ type: "text" as const, value: "Wisdom (Perception) check." },
],
},
{
name: "Tail Attack",
segments: [{ type: "text" as const, value: "Tail attack." }],
},
],
},
spellcasting: [
{
name: "Innate Spellcasting",
headerText: "The dragon's spellcasting ability is Charisma.",
atWill: ["detect magic", "suggestion"],
daily: [{ uses: 3, each: true, spells: ["fireball", "wall of fire"] }],
restLong: [{ uses: 1, each: false, spells: ["wish"] }],
atWill: [{ name: "detect magic" }, { name: "suggestion" }],
daily: [
{
uses: 3,
each: true,
spells: [{ name: "fireball" }, { name: "wall of fire" }],
},
],
restLong: [{ uses: 1, each: false, spells: [{ name: "wish" }] }],
},
],
};

View File

@@ -80,7 +80,7 @@ describe("TurnNavigation", () => {
expect(container.textContent).not.toContain("\u2014");
});
it("round badge and combatant name are siblings in the center area", () => {
it("round badge is in the left zone and name is in the center zone", () => {
renderNav(
buildEncounter({
combatants: [buildCombatant({ name: "Goblin" })],
@@ -88,7 +88,8 @@ describe("TurnNavigation", () => {
);
const badge = screen.getByText("R1");
const name = screen.getByText("Goblin");
expect(badge.closest(".flex")).toBe(name.parentElement);
// Badge and name are in separate grid cells to prevent layout shifts
expect(badge.parentElement).not.toBe(name.parentElement);
});
});

View File

@@ -3,23 +3,30 @@ import { useId, useState } from "react";
import { useAdapters } from "../contexts/adapter-context.js";
import { useBestiaryContext } from "../contexts/bestiary-context.js";
import { useBulkImportContext } from "../contexts/bulk-import-context.js";
import { useRulesEditionContext } from "../contexts/rules-edition-context.js";
import { useSidePanelContext } from "../contexts/side-panel-context.js";
import { Button } from "./ui/button.js";
import { Input } from "./ui/input.js";
const DEFAULT_BASE_URL =
const DND_BASE_URL =
"https://raw.githubusercontent.com/5etools-mirror-3/5etools-src/main/data/bestiary/";
const PF2E_BASE_URL =
"https://raw.githubusercontent.com/foundryvtt/pf2e/v13-dev/packs/pf2e/";
export function BulkImportPrompt() {
const { bestiaryIndex } = useAdapters();
const { bestiaryIndex, pf2eBestiaryIndex } = useAdapters();
const { fetchAndCacheSource, isSourceCached, refreshCache } =
useBestiaryContext();
const { state: importState, startImport, reset } = useBulkImportContext();
const { dismissPanel } = useSidePanelContext();
const { edition } = useRulesEditionContext();
const [baseUrl, setBaseUrl] = useState(DEFAULT_BASE_URL);
const indexPort = edition === "pf2e" ? pf2eBestiaryIndex : bestiaryIndex;
const defaultUrl = edition === "pf2e" ? PF2E_BASE_URL : DND_BASE_URL;
const [baseUrl, setBaseUrl] = useState(defaultUrl);
const baseUrlId = useId();
const totalSources = bestiaryIndex.getAllSourceCodes().length;
const totalSources = indexPort.getAllSourceCodes().length;
const handleStart = (url: string) => {
startImport(url, fetchAndCacheSource, isSourceCached, refreshCache);

View File

@@ -1,6 +1,6 @@
import {
type CombatantId,
type ConditionId,
type ConditionEntry,
type CreatureId,
deriveHpStatus,
type PlayerIcon,
@@ -10,6 +10,7 @@ import { Brain, Pencil, X } from "lucide-react";
import { type Ref, useCallback, useEffect, useRef, useState } from "react";
import { useEncounterContext } from "../contexts/encounter-context.js";
import { useInitiativeRollsContext } from "../contexts/initiative-rolls-context.js";
import { useRulesEditionContext } from "../contexts/rules-edition-context.js";
import { useSidePanelContext } from "../contexts/side-panel-context.js";
import { useLongPress } from "../hooks/use-long-press.js";
import { cn } from "../lib/utils.js";
@@ -31,7 +32,7 @@ interface Combatant {
readonly currentHp?: number;
readonly tempHp?: number;
readonly ac?: number;
readonly conditions?: readonly ConditionId[];
readonly conditions?: readonly ConditionEntry[];
readonly isConcentrating?: boolean;
readonly color?: string;
readonly icon?: string;
@@ -415,12 +416,14 @@ function InitiativeDisplay({
function rowBorderClass(
isActive: boolean,
isConcentrating: boolean | undefined,
isPf2e: boolean,
): string {
if (isActive && isConcentrating)
const showConcentration = isConcentrating && !isPf2e;
if (isActive && showConcentration)
return "border border-l-2 border-active-row-border border-l-purple-400 bg-active-row-bg card-glow";
if (isActive)
return "border border-l-2 border-active-row-border bg-active-row-bg card-glow";
if (isConcentrating)
if (showConcentration)
return "border border-l-2 border-transparent border-l-purple-400";
return "border border-l-2 border-transparent";
}
@@ -430,7 +433,7 @@ function concentrationIconClass(
dimmed: boolean,
): string {
if (!isConcentrating)
return "opacity-0 group-hover:opacity-50 text-muted-foreground";
return "opacity-0 pointer-coarse:opacity-50 group-hover:opacity-50 text-muted-foreground";
return dimmed ? "opacity-50 text-purple-400" : "opacity-100 text-purple-400";
}
@@ -448,11 +451,15 @@ export function CombatantRow({
setTempHp,
setAc,
toggleCondition,
setConditionValue,
decrementCondition,
toggleConcentration,
} = useEncounterContext();
const { selectedCreatureId, showCreature, toggleCollapse } =
useSidePanelContext();
const { handleRollInitiative } = useInitiativeRollsContext();
const { edition } = useRulesEditionContext();
const isPf2e = edition === "pf2e";
// Derive what was previously conditional props
const isStatBlockOpen = combatant.creatureId === selectedCreatureId;
@@ -493,12 +500,16 @@ export function CombatantRow({
const tempHpDropped =
prevTempHp !== undefined && (combatant.tempHp ?? 0) < prevTempHp;
if ((realHpDropped || tempHpDropped) && combatant.isConcentrating) {
if (
(realHpDropped || tempHpDropped) &&
combatant.isConcentrating &&
!isPf2e
) {
setIsPulsing(true);
clearTimeout(pulseTimerRef.current);
pulseTimerRef.current = setTimeout(() => setIsPulsing(false), 1200);
}
}, [currentHp, combatant.tempHp, combatant.isConcentrating]);
}, [currentHp, combatant.tempHp, combatant.isConcentrating, isPf2e]);
useEffect(() => {
if (!combatant.isConcentrating) {
@@ -516,24 +527,33 @@ export function CombatantRow({
ref={ref}
className={cn(
"group rounded-lg pr-3 transition-colors",
rowBorderClass(isActive, combatant.isConcentrating),
rowBorderClass(isActive, combatant.isConcentrating, isPf2e),
isPulsing && "animate-concentration-pulse",
)}
>
<div className="grid grid-cols-[2rem_3rem_auto_1fr_auto_2rem] items-center gap-1.5 py-3 sm:grid-cols-[2rem_3.5rem_auto_1fr_auto_2rem] sm:gap-3 sm:py-2">
{/* Concentration */}
<button
type="button"
onClick={() => toggleConcentration(id)}
title="Concentrating"
aria-label="Toggle concentration"
className={cn(
"-my-2 -ml-[2px] flex w-full items-center justify-center self-stretch pl-[14px] transition-opacity hover:text-hover-neutral hover:opacity-100",
concentrationIconClass(combatant.isConcentrating, dimmed),
)}
>
<Brain size={16} />
</button>
<div
className={cn(
"grid items-center gap-1.5 py-3 sm:gap-3 sm:py-2",
isPf2e
? "grid-cols-[3rem_auto_1fr_auto_2rem] pl-3 sm:grid-cols-[3.5rem_auto_1fr_auto_2rem]"
: "grid-cols-[2rem_3rem_auto_1fr_auto_2rem] sm:grid-cols-[2rem_3.5rem_auto_1fr_auto_2rem]",
)}
>
{/* Concentration — hidden in PF2e mode */}
{!isPf2e && (
<button
type="button"
onClick={() => toggleConcentration(id)}
title="Concentrating"
aria-label="Toggle concentration"
className={cn(
"-my-2 -ml-[2px] flex w-full items-center justify-center self-stretch pl-[14px] transition-opacity hover:text-hover-neutral hover:opacity-100",
concentrationIconClass(combatant.isConcentrating, dimmed),
)}
>
<Brain size={16} />
</button>
)}
{/* Initiative */}
<div className="rounded-md bg-muted/30 px-1">
@@ -585,6 +605,7 @@ export function CombatantRow({
<ConditionTags
conditions={combatant.conditions}
onRemove={(conditionId) => toggleCondition(id, conditionId)}
onDecrement={(conditionId) => decrementCondition(id, conditionId)}
onOpenPicker={() => setPickerOpen((prev) => !prev)}
/>
</div>
@@ -593,6 +614,9 @@ export function CombatantRow({
anchorRef={conditionAnchorRef}
activeConditions={combatant.conditions}
onToggle={(conditionId) => toggleCondition(id, conditionId)}
onSetValue={(conditionId, value) =>
setConditionValue(id, conditionId, value)
}
onClose={() => setPickerOpen(false)}
/>
)}

View File

@@ -1,8 +1,10 @@
import {
type ConditionEntry,
type ConditionId,
getConditionDescription,
getConditionsForEdition,
} from "@initiative/domain";
import { Check, Minus, Plus } from "lucide-react";
import { useLayoutEffect, useRef, useState } from "react";
import { createPortal } from "react-dom";
import { useRulesEditionContext } from "../contexts/rules-edition-context.js";
@@ -16,8 +18,9 @@ import { Tooltip } from "./ui/tooltip.js";
interface ConditionPickerProps {
anchorRef: React.RefObject<HTMLElement | null>;
activeConditions: readonly ConditionId[] | undefined;
activeConditions: readonly ConditionEntry[] | undefined;
onToggle: (conditionId: ConditionId) => void;
onSetValue: (conditionId: ConditionId, value: number) => void;
onClose: () => void;
}
@@ -25,6 +28,7 @@ export function ConditionPicker({
anchorRef,
activeConditions,
onToggle,
onSetValue,
onClose,
}: Readonly<ConditionPickerProps>) {
const ref = useRef<HTMLDivElement>(null);
@@ -34,6 +38,11 @@ export function ConditionPicker({
maxHeight: number;
} | null>(null);
const [editing, setEditing] = useState<{
id: ConditionId;
value: number;
} | null>(null);
useLayoutEffect(() => {
const anchor = anchorRef.current;
const el = ref.current;
@@ -59,7 +68,9 @@ export function ConditionPicker({
const { edition } = useRulesEditionContext();
const conditions = getConditionsForEdition(edition);
const active = new Set(activeConditions ?? []);
const activeMap = new Map(
(activeConditions ?? []).map((e) => [e.id, e.value]),
);
return createPortal(
<div
@@ -74,35 +85,127 @@ export function ConditionPicker({
{conditions.map((def) => {
const Icon = CONDITION_ICON_MAP[def.iconName];
if (!Icon) return null;
const isActive = active.has(def.id);
const isActive = activeMap.has(def.id);
const activeValue = activeMap.get(def.id);
const isEditing = editing?.id === def.id;
const colorClass =
CONDITION_COLOR_CLASSES[def.color] ?? "text-muted-foreground";
const handleClick = () => {
if (def.valued && edition === "pf2e") {
const current = activeMap.get(def.id);
setEditing({
id: def.id,
value: current ?? 1,
});
} else {
onToggle(def.id);
}
};
return (
<Tooltip
key={def.id}
content={getConditionDescription(def, edition)}
className="block"
>
<button
type="button"
<div
className={cn(
"flex w-full items-center gap-2 rounded px-2 py-1 text-sm transition-colors hover:bg-hover-neutral-bg",
isActive && "bg-card/50",
"flex w-full items-center gap-2 rounded px-2 py-1 text-sm transition-colors",
(isActive || isEditing) && "bg-card/50",
)}
onClick={() => onToggle(def.id)}
>
<Icon
size={14}
className={isActive ? colorClass : "text-muted-foreground"}
/>
<span
className={
isActive ? "text-foreground" : "text-muted-foreground"
}
<button
type="button"
className="flex flex-1 items-center gap-2"
onClick={handleClick}
>
{def.label}
</span>
</button>
<Icon
size={14}
className={
isActive || isEditing ? colorClass : "text-muted-foreground"
}
/>
<span
className={
isActive || isEditing
? "text-foreground"
: "text-muted-foreground"
}
>
{def.label}
</span>
</button>
{isActive && def.valued && edition === "pf2e" && !isEditing && (
<span className="min-w-5 rounded-full bg-accent px-1.5 py-0.5 text-center font-medium text-primary-foreground text-xs">
{activeValue}
</span>
)}
{isEditing && (
<div className="flex items-center gap-0.5">
<button
type="button"
className="rounded p-0.5 text-foreground hover:bg-accent/40"
onMouseDown={(e) => e.preventDefault()}
onClick={(e) => {
e.stopPropagation();
if (editing.value > 1) {
setEditing({
...editing,
value: editing.value - 1,
});
}
}}
>
<Minus className="h-3 w-3" />
</button>
<span className="min-w-5 rounded-full bg-accent px-1.5 py-0.5 text-center font-medium text-primary-foreground text-xs">
{editing.value}
</span>
{(() => {
const atMax =
def.maxValue !== undefined &&
editing.value >= def.maxValue;
return (
<button
type="button"
className={cn(
"rounded p-0.5",
atMax
? "cursor-not-allowed text-muted-foreground opacity-50"
: "text-foreground hover:bg-accent/40",
)}
disabled={atMax}
onMouseDown={(e) => e.preventDefault()}
onClick={(e) => {
e.stopPropagation();
if (!atMax) {
setEditing({
...editing,
value: editing.value + 1,
});
}
}}
>
<Plus className="h-3 w-3" />
</button>
);
})()}
<button
type="button"
className="ml-0.5 rounded p-0.5 text-foreground hover:bg-accent/40"
onMouseDown={(e) => e.preventDefault()}
onClick={(e) => {
e.stopPropagation();
onSetValue(editing.id, editing.value);
setEditing(null);
}}
>
<Check className="h-3.5 w-3.5" />
</button>
</div>
)}
</div>
</Tooltip>
);
})}

View File

@@ -1,42 +1,74 @@
import type { LucideIcon } from "lucide-react";
import {
Anchor,
ArrowDown,
Ban,
BatteryLow,
BrainCog,
CircleHelp,
CloudFog,
Drama,
Droplet,
Droplets,
EarOff,
Eye,
EyeOff,
Footprints,
Gem,
Ghost,
Hand,
Heart,
HeartCrack,
HeartPulse,
Link,
Moon,
PersonStanding,
ShieldMinus,
ShieldOff,
Siren,
Skull,
Snail,
Sparkles,
Sun,
TrendingDown,
Zap,
ZapOff,
} from "lucide-react";
export const CONDITION_ICON_MAP: Record<string, LucideIcon> = {
EyeOff,
Heart,
EarOff,
BatteryLow,
Siren,
Hand,
Ban,
Ghost,
ZapOff,
Gem,
Droplet,
Anchor,
ArrowDown,
Ban,
BatteryLow,
BrainCog,
CircleHelp,
CloudFog,
Drama,
Droplet,
Droplets,
EarOff,
Eye,
EyeOff,
Footprints,
Gem,
Ghost,
Hand,
Heart,
HeartCrack,
HeartPulse,
Link,
Moon,
PersonStanding,
ShieldMinus,
ShieldOff,
Siren,
Skull,
Snail,
Sparkles,
Moon,
Sun,
TrendingDown,
Zap,
ZapOff,
};
export const CONDITION_COLOR_CLASSES: Record<string, string> = {
@@ -51,4 +83,5 @@ export const CONDITION_COLOR_CLASSES: Record<string, string> = {
green: "text-green-400",
indigo: "text-indigo-400",
sky: "text-sky-400",
red: "text-red-400",
};

View File

@@ -1,5 +1,6 @@
import {
CONDITION_DEFINITIONS,
type ConditionEntry,
type ConditionId,
getConditionDescription,
} from "@initiative/domain";
@@ -13,44 +14,57 @@ import {
import { Tooltip } from "./ui/tooltip.js";
interface ConditionTagsProps {
conditions: readonly ConditionId[] | undefined;
conditions: readonly ConditionEntry[] | undefined;
onRemove: (conditionId: ConditionId) => void;
onDecrement: (conditionId: ConditionId) => void;
onOpenPicker: () => void;
}
export function ConditionTags({
conditions,
onRemove,
onDecrement,
onOpenPicker,
}: Readonly<ConditionTagsProps>) {
const { edition } = useRulesEditionContext();
return (
<div className="flex flex-wrap items-center gap-0.5">
{conditions?.map((condId) => {
const def = CONDITION_DEFINITIONS.find((d) => d.id === condId);
{conditions?.map((entry) => {
const def = CONDITION_DEFINITIONS.find((d) => d.id === entry.id);
if (!def) return null;
const Icon = CONDITION_ICON_MAP[def.iconName];
if (!Icon) return null;
const colorClass =
CONDITION_COLOR_CLASSES[def.color] ?? "text-muted-foreground";
const tooltipLabel =
entry.value === undefined ? def.label : `${def.label} ${entry.value}`;
return (
<Tooltip
key={condId}
content={`${def.label}:\n${getConditionDescription(def, edition)}`}
key={entry.id}
content={`${tooltipLabel}:\n${getConditionDescription(def, edition)}`}
>
<button
type="button"
aria-label={`Remove ${def.label}`}
className={cn(
"inline-flex items-center rounded p-0.5 transition-colors hover:bg-hover-neutral-bg",
"inline-flex items-center gap-0.5 rounded p-0.5 transition-colors hover:bg-hover-neutral-bg",
colorClass,
)}
onClick={(e) => {
e.stopPropagation();
onRemove(condId);
if (entry.value === undefined) {
onRemove(entry.id);
} else {
onDecrement(entry.id);
}
}}
>
<Icon size={14} />
{entry.value !== undefined && (
<span className="font-medium text-xs leading-none">
{entry.value}
</span>
)}
</button>
</Tooltip>
);

View File

@@ -1,37 +1,96 @@
import type { DifficultyTier } from "@initiative/domain";
import type { DifficultyTier, RulesEdition } from "@initiative/domain";
import { ArrowLeftRight } from "lucide-react";
import { useRef } from "react";
import { useEncounterContext } from "../contexts/encounter-context.js";
import { useRulesEditionContext } from "../contexts/rules-edition-context.js";
import { useClickOutside } from "../hooks/use-click-outside.js";
import {
type BreakdownCombatant,
useDifficultyBreakdown,
} from "../hooks/use-difficulty-breakdown.js";
import { CrPicker } from "./cr-picker.js";
import { Button } from "./ui/button.js";
const TIER_LABELS: Record<DifficultyTier, { label: string; color: string }> = {
trivial: { label: "Trivial", color: "text-muted-foreground" },
low: { label: "Low", color: "text-green-500" },
moderate: { label: "Moderate", color: "text-yellow-500" },
high: { label: "High", color: "text-red-500" },
const TIER_LABEL_MAP: Partial<
Record<RulesEdition, Record<DifficultyTier, { label: string; color: string }>>
> = {
"5.5e": {
0: { label: "Trivial", color: "text-muted-foreground" },
1: { label: "Low", color: "text-green-500" },
2: { label: "Moderate", color: "text-yellow-500" },
3: { label: "High", color: "text-red-500" },
},
"5e": {
0: { label: "Easy", color: "text-muted-foreground" },
1: { label: "Medium", color: "text-green-500" },
2: { label: "Hard", color: "text-yellow-500" },
3: { label: "Deadly", color: "text-red-500" },
},
};
/** Short labels for threshold display where horizontal space is limited. */
const SHORT_LABELS: Readonly<Record<string, string>> = {
Moderate: "Mod",
Medium: "Med",
};
function shortLabel(label: string): string {
return SHORT_LABELS[label] ?? label;
}
function formatXp(xp: number): string {
return xp.toLocaleString();
}
function CombatantRow({ entry }: { entry: BreakdownCombatant }) {
const { setCr } = useEncounterContext();
function PcRow({ entry }: { entry: BreakdownCombatant }) {
return (
<div className="col-span-4 grid grid-cols-subgrid items-center text-xs">
<span className="min-w-0 truncate" title={entry.combatant.name}>
{entry.combatant.name}
</span>
<span />
<span className="text-muted-foreground">
{entry.level === undefined ? "\u2014" : `Lv ${entry.level}`}
</span>
<span className="text-right tabular-nums">{"\u2014"}</span>
</div>
);
}
const nameLabel = entry.source
? `${entry.combatant.name} (${entry.source})`
: entry.combatant.name;
function NpcRow({
entry,
onToggleSide,
}: {
entry: BreakdownCombatant;
onToggleSide: () => void;
}) {
const { setCr } = useEncounterContext();
const isParty = entry.side === "party";
const targetSide = isParty ? "enemy" : "party";
let xpDisplay: string;
if (entry.xp == null) {
xpDisplay = "\u2014";
} else if (isParty && entry.cr) {
xpDisplay = `\u2212${formatXp(entry.xp)}`;
} else {
xpDisplay = formatXp(entry.xp);
}
return (
<div className="flex items-center justify-between gap-2 text-xs">
<span className="min-w-0 truncate" title={nameLabel}>
{nameLabel}
<div className="col-span-4 grid grid-cols-subgrid items-center text-xs">
<span className="min-w-0 truncate" title={entry.combatant.name}>
{entry.combatant.name}
</span>
<div className="flex shrink-0 items-center gap-2">
<Button
variant="ghost"
size="icon-sm"
onClick={onToggleSide}
aria-label={`Move ${entry.combatant.name} to ${targetSide} side`}
>
<ArrowLeftRight className="h-3 w-3" />
</Button>
<span>
{entry.editable ? (
<CrPicker
value={entry.cr}
@@ -39,13 +98,11 @@ function CombatantRow({ entry }: { entry: BreakdownCombatant }) {
/>
) : (
<span className="text-muted-foreground">
{entry.cr ? `CR ${entry.cr}` : ""}
{entry.cr ? `CR ${entry.cr}` : "\u2014"}
</span>
)}
<span className="w-12 text-right tabular-nums">
{entry.xp == null ? "—" : formatXp(entry.xp)}
</span>
</div>
</span>
<span className="text-right tabular-nums">{xpDisplay}</span>
</div>
);
}
@@ -53,16 +110,28 @@ function CombatantRow({ entry }: { entry: BreakdownCombatant }) {
export function DifficultyBreakdownPanel({ onClose }: { onClose: () => void }) {
const ref = useRef<HTMLDivElement>(null);
useClickOutside(ref, onClose);
const { setSide } = useEncounterContext();
const { edition } = useRulesEditionContext();
const breakdown = useDifficultyBreakdown();
if (!breakdown) return null;
const tierConfig = TIER_LABELS[breakdown.tier];
const tierLabels = TIER_LABEL_MAP[edition];
if (!tierLabels) return null;
const tierConfig = tierLabels[breakdown.tier];
const handleToggle = (entry: BreakdownCombatant) => {
const newSide = entry.side === "party" ? "enemy" : "party";
setSide(entry.combatant.id, newSide);
};
const isPC = (entry: BreakdownCombatant) =>
entry.combatant.playerCharacterId != null;
return (
<div
ref={ref}
className="absolute top-full right-0 z-50 mt-1 w-72 rounded-lg border border-border bg-card p-3 shadow-lg"
className="absolute top-full right-0 z-50 mt-1 w-80 rounded-lg border border-border bg-card p-3 shadow-lg max-sm:fixed max-sm:top-12 max-sm:right-3 max-sm:left-3 max-sm:w-auto"
>
<div className="mb-2 font-medium text-sm">
Encounter Difficulty:{" "}
@@ -75,35 +144,86 @@ export function DifficultyBreakdownPanel({ onClose }: { onClose: () => void }) {
{breakdown.pcCount === 1 ? "PC" : "PCs"})
</div>
<div className="flex gap-3 text-xs">
<span>
Low: <strong>{formatXp(breakdown.partyBudget.low)}</strong>
</span>
<span>
Mod: <strong>{formatXp(breakdown.partyBudget.moderate)}</strong>
</span>
<span>
High: <strong>{formatXp(breakdown.partyBudget.high)}</strong>
</span>
{breakdown.thresholds.map((t) => (
<span key={t.label}>
{shortLabel(t.label)}: <strong>{formatXp(t.value)}</strong>
</span>
))}
</div>
</div>
<div className="border-border border-t pt-2 pb-2 text-muted-foreground text-xs italic">
Allied NPC XP is subtracted from encounter difficulty
</div>
<div className="border-border border-t pt-2">
<div className="mb-1 flex justify-between text-muted-foreground text-xs">
<span>Monsters</span>
<span>Party</span>
<span>XP</span>
</div>
<div className="flex flex-col gap-1">
{breakdown.combatants.map((entry) => (
<CombatantRow key={entry.combatant.id} entry={entry} />
))}
<div className="grid grid-cols-[1fr_auto_auto_3.5rem] gap-x-2 gap-y-1">
{breakdown.partyCombatants.map((entry) =>
isPC(entry) ? (
<PcRow key={entry.combatant.id} entry={entry} />
) : (
<NpcRow
key={entry.combatant.id}
entry={entry}
onToggleSide={() => handleToggle(entry)}
/>
),
)}
</div>
</div>
<div className="mt-2 border-border border-t pt-2">
<div className="mb-1 flex justify-between text-muted-foreground text-xs">
<span>Enemy</span>
<span>XP</span>
</div>
<div className="grid grid-cols-[1fr_auto_auto_3.5rem] gap-x-2 gap-y-1">
{breakdown.enemyCombatants.map((entry) =>
isPC(entry) ? (
<PcRow key={entry.combatant.id} entry={entry} />
) : (
<NpcRow
key={entry.combatant.id}
entry={entry}
onToggleSide={() => handleToggle(entry)}
/>
),
)}
</div>
</div>
{breakdown.encounterMultiplier !== undefined &&
breakdown.adjustedXp !== undefined ? (
<div className="mt-2 border-border border-t pt-2">
<div className="flex justify-between font-medium text-xs">
<span>Monster XP</span>
<span className="tabular-nums">
{formatXp(breakdown.totalMonsterXp)}{" "}
<span className="text-muted-foreground">
&times;{breakdown.encounterMultiplier}
</span>{" "}
= {formatXp(breakdown.adjustedXp)}
</span>
</div>
{breakdown.partySizeAdjusted === true ? (
<div className="mt-0.5 text-muted-foreground text-xs italic">
Adjusted for {breakdown.pcCount}{" "}
{breakdown.pcCount === 1 ? "PC" : "PCs"}
</div>
) : null}
</div>
) : (
<div className="mt-2 flex justify-between border-border border-t pt-2 font-medium text-xs">
<span>Total Monster XP</span>
<span>Net Monster XP</span>
<span className="tabular-nums">
{formatXp(breakdown.totalMonsterXp)}
</span>
</div>
</div>
)}
</div>
);
}

View File

@@ -1,27 +1,44 @@
import type { DifficultyResult, DifficultyTier } from "@initiative/domain";
import { cn } from "../lib/utils.js";
const TIER_CONFIG: Record<
export const TIER_LABELS_5_5E: Record<DifficultyTier, string> = {
0: "Trivial",
1: "Low",
2: "Moderate",
3: "High",
};
export const TIER_LABELS_2014: Record<DifficultyTier, string> = {
0: "Easy",
1: "Medium",
2: "Hard",
3: "Deadly",
};
const TIER_COLORS: Record<
DifficultyTier,
{ filledBars: number; color: string; label: string }
{ filledBars: number; color: string }
> = {
trivial: { filledBars: 0, color: "", label: "Trivial" },
low: { filledBars: 1, color: "bg-green-500", label: "Low" },
moderate: { filledBars: 2, color: "bg-yellow-500", label: "Moderate" },
high: { filledBars: 3, color: "bg-red-500", label: "High" },
0: { filledBars: 0, color: "" },
1: { filledBars: 1, color: "bg-green-500" },
2: { filledBars: 2, color: "bg-yellow-500" },
3: { filledBars: 3, color: "bg-red-500" },
};
const BAR_HEIGHTS = ["h-2", "h-3", "h-4"] as const;
export function DifficultyIndicator({
result,
labels,
onClick,
}: {
result: DifficultyResult;
labels: Record<DifficultyTier, string>;
onClick?: () => void;
}) {
const config = TIER_CONFIG[result.tier];
const tooltip = `${config.label} encounter difficulty`;
const config = TIER_COLORS[result.tier];
const label = labels[result.tier];
const tooltip = `${label} encounter difficulty`;
const Element = onClick ? "button" : "div";

View File

@@ -1,10 +1,16 @@
import type { Creature } from "@initiative/domain";
import {
type Creature,
calculateInitiative,
formatInitiativeModifier,
} from "@initiative/domain";
import {
PropertyLine,
SectionDivider,
TraitEntry,
TraitSection,
} from "./stat-block-parts.js";
interface StatBlockProps {
interface DndStatBlockProps {
creature: Creature;
}
@@ -13,53 +19,7 @@ function abilityMod(score: number): string {
return mod >= 0 ? `+${mod}` : `${mod}`;
}
function PropertyLine({
label,
value,
}: Readonly<{
label: string;
value: string | undefined;
}>) {
if (!value) return null;
return (
<div className="text-sm">
<span className="font-semibold">{label}</span> {value}
</div>
);
}
function SectionDivider() {
return (
<div className="my-2 h-px bg-gradient-to-r from-stat-divider-from via-stat-divider-via to-transparent" />
);
}
function TraitSection({
entries,
heading,
}: Readonly<{
entries: readonly { name: string; text: string }[] | undefined;
heading?: string;
}>) {
if (!entries || entries.length === 0) return null;
return (
<>
<SectionDivider />
{heading ? (
<h3 className="font-bold text-base text-stat-heading">{heading}</h3>
) : null}
<div className="space-y-2">
{entries.map((e) => (
<div key={e.name} className="text-sm">
<span className="font-semibold italic">{e.name}.</span> {e.text}
</div>
))}
</div>
</>
);
}
export function StatBlock({ creature }: Readonly<StatBlockProps>) {
export function DndStatBlock({ creature }: Readonly<DndStatBlockProps>) {
const abilities = [
{ label: "STR", score: creature.abilities.str },
{ label: "DEX", score: creature.abilities.dex },
@@ -174,7 +134,7 @@ export function StatBlock({ creature }: Readonly<StatBlockProps>) {
{sc.atWill && sc.atWill.length > 0 && (
<div className="pl-2">
<span className="font-semibold">At Will:</span>{" "}
{sc.atWill.join(", ")}
{sc.atWill.map((s) => s.name).join(", ")}
</div>
)}
{sc.daily?.map((d) => (
@@ -183,7 +143,7 @@ export function StatBlock({ creature }: Readonly<StatBlockProps>) {
{d.uses}/day
{d.each ? " each" : ""}:
</span>{" "}
{d.spells.join(", ")}
{d.spells.map((s) => s.name).join(", ")}
</div>
))}
{sc.restLong?.map((d) => (
@@ -195,7 +155,7 @@ export function StatBlock({ creature }: Readonly<StatBlockProps>) {
{d.uses}/long rest
{d.each ? " each" : ""}:
</span>{" "}
{d.spells.join(", ")}
{d.spells.map((s) => s.name).join(", ")}
</div>
))}
</div>
@@ -219,9 +179,7 @@ export function StatBlock({ creature }: Readonly<StatBlockProps>) {
</p>
<div className="space-y-2">
{creature.legendaryActions.entries.map((a) => (
<div key={a.name} className="text-sm">
<span className="font-semibold italic">{a.name}.</span> {a.text}
</div>
<TraitEntry key={a.name} trait={a} />
))}
</div>
</>

View File

@@ -0,0 +1,260 @@
import type { Pf2eCreature, SpellReference } from "@initiative/domain";
import { formatInitiativeModifier } from "@initiative/domain";
import { useCallback, useRef, useState } from "react";
import { SpellDetailPopover } from "./spell-detail-popover.js";
import {
PropertyLine,
SectionDivider,
TraitSection,
} from "./stat-block-parts.js";
interface Pf2eStatBlockProps {
creature: Pf2eCreature;
}
const ALIGNMENTS = new Set([
"lg",
"ng",
"cg",
"ln",
"n",
"cn",
"le",
"ne",
"ce",
]);
function capitalize(s: string): string {
return s.charAt(0).toUpperCase() + s.slice(1);
}
function displayTraits(traits: readonly string[]): string[] {
return traits.filter((t) => !ALIGNMENTS.has(t)).map(capitalize);
}
function formatMod(mod: number): string {
return mod >= 0 ? `+${mod}` : `${mod}`;
}
interface SpellLinkProps {
readonly spell: SpellReference;
readonly onOpen: (spell: SpellReference, rect: DOMRect) => void;
}
function UsesPerDay({ count }: Readonly<{ count: number | undefined }>) {
if (count === undefined || count <= 1) return null;
return <span> (×{count})</span>;
}
function SpellLink({ spell, onOpen }: Readonly<SpellLinkProps>) {
const ref = useRef<HTMLButtonElement>(null);
const handleClick = useCallback(() => {
if (!spell.description) return;
const rect = ref.current?.getBoundingClientRect();
if (rect) onOpen(spell, rect);
}, [spell, onOpen]);
if (!spell.description) {
return (
<span>
{spell.name}
<UsesPerDay count={spell.usesPerDay} />
</span>
);
}
return (
<>
<button
ref={ref}
type="button"
onClick={handleClick}
className="cursor-pointer text-foreground underline decoration-dotted underline-offset-2 hover:text-hover-neutral"
>
{spell.name}
</button>
<UsesPerDay count={spell.usesPerDay} />
</>
);
}
interface SpellListLineProps {
readonly label: string;
readonly spells: readonly SpellReference[];
readonly onOpen: (spell: SpellReference, rect: DOMRect) => void;
}
function SpellListLine({
label,
spells,
onOpen,
}: Readonly<SpellListLineProps>) {
return (
<div className="pl-2">
<span className="font-semibold">{label}:</span>{" "}
{spells.map((spell, i) => (
<span key={spell.slug ?? spell.name}>
{i > 0 ? ", " : ""}
<SpellLink spell={spell} onOpen={onOpen} />
</span>
))}
</div>
);
}
export function Pf2eStatBlock({ creature }: Readonly<Pf2eStatBlockProps>) {
const [openSpell, setOpenSpell] = useState<{
spell: SpellReference;
rect: DOMRect;
} | null>(null);
const handleOpenSpell = useCallback(
(spell: SpellReference, rect: DOMRect) => setOpenSpell({ spell, rect }),
[],
);
const handleCloseSpell = useCallback(() => setOpenSpell(null), []);
const abilityEntries = [
{ label: "Str", mod: creature.abilityMods.str },
{ label: "Dex", mod: creature.abilityMods.dex },
{ label: "Con", mod: creature.abilityMods.con },
{ label: "Int", mod: creature.abilityMods.int },
{ label: "Wis", mod: creature.abilityMods.wis },
{ label: "Cha", mod: creature.abilityMods.cha },
];
return (
<div className="space-y-1 text-foreground">
{/* Header */}
<div>
<div className="flex items-baseline justify-between gap-2">
<h2 className="font-bold text-stat-heading text-xl">
{creature.name}
</h2>
<span className="shrink-0 font-semibold text-sm">
Level {creature.level}
</span>
</div>
<div className="mt-1 flex flex-wrap gap-1">
{displayTraits(creature.traits).map((trait) => (
<span
key={trait}
className="rounded border border-border bg-card px-1.5 py-0.5 text-foreground text-xs"
>
{trait}
</span>
))}
</div>
<p className="mt-1 text-muted-foreground text-xs">
{creature.sourceDisplayName}
</p>
</div>
<SectionDivider />
{/* Perception, Languages, Skills */}
<div className="space-y-0.5 text-sm">
<div>
<span className="font-semibold">Perception</span>{" "}
{formatInitiativeModifier(creature.perception)}
{creature.senses ? `; ${creature.senses}` : ""}
</div>
<PropertyLine label="Languages" value={creature.languages} />
<PropertyLine label="Skills" value={creature.skills} />
</div>
{/* Ability Modifiers */}
<div className="grid grid-cols-6 gap-1 text-center text-sm">
{abilityEntries.map((a) => (
<div key={a.label}>
<div className="font-semibold text-muted-foreground text-xs">
{a.label}
</div>
<div>{formatMod(a.mod)}</div>
</div>
))}
</div>
<PropertyLine label="Items" value={creature.items} />
{/* Top abilities (before defenses) */}
<TraitSection entries={creature.abilitiesTop} />
<SectionDivider />
{/* Defenses */}
<div className="space-y-0.5 text-sm">
<div>
<span className="font-semibold">AC</span> {creature.ac}
{creature.acConditional ? ` (${creature.acConditional})` : ""};{" "}
<span className="font-semibold">Fort</span>{" "}
{formatMod(creature.saveFort)},{" "}
<span className="font-semibold">Ref</span>{" "}
{formatMod(creature.saveRef)},{" "}
<span className="font-semibold">Will</span>{" "}
{formatMod(creature.saveWill)}
{creature.saveConditional ? `; ${creature.saveConditional}` : ""}
</div>
<div>
<span className="font-semibold">HP</span> {creature.hp}
{creature.hpDetails ? ` (${creature.hpDetails})` : ""}
</div>
<PropertyLine label="Immunities" value={creature.immunities} />
<PropertyLine label="Resistances" value={creature.resistances} />
<PropertyLine label="Weaknesses" value={creature.weaknesses} />
</div>
{/* Mid abilities (reactions, auras) */}
<TraitSection entries={creature.abilitiesMid} />
<SectionDivider />
{/* Speed */}
<div className="text-sm">
<span className="font-semibold">Speed</span> {creature.speed}
</div>
{/* Attacks */}
<TraitSection entries={creature.attacks} />
{/* Bottom abilities (active abilities) */}
<TraitSection entries={creature.abilitiesBot} />
{/* Spellcasting */}
{creature.spellcasting && creature.spellcasting.length > 0 && (
<>
<SectionDivider />
{creature.spellcasting.map((sc) => (
<div key={sc.name} className="space-y-1 text-sm">
<div>
<span className="font-semibold italic">{sc.name}.</span>{" "}
{sc.headerText}
</div>
{sc.daily?.map((d) => (
<SpellListLine
key={d.uses}
label={d.uses === 0 ? "Cantrips" : `Rank ${d.uses}`}
spells={d.spells}
onOpen={handleOpenSpell}
/>
))}
{sc.atWill && sc.atWill.length > 0 && (
<SpellListLine
label="Cantrips"
spells={sc.atWill}
onOpen={handleOpenSpell}
/>
)}
</div>
))}
</>
)}
{openSpell ? (
<SpellDetailPopover
spell={openSpell.spell}
anchorRect={openSpell.rect}
onClose={handleCloseSpell}
/>
) : null}
</div>
);
}

View File

@@ -13,6 +13,7 @@ interface SettingsModalProps {
const EDITION_OPTIONS: { value: RulesEdition; label: string }[] = [
{ value: "5e", label: "5e (2014)" },
{ value: "5.5e", label: "5.5e (2024)" },
{ value: "pf2e", label: "Pathfinder 2e" },
];
const THEME_OPTIONS: {
@@ -36,7 +37,7 @@ export function SettingsModal({ open, onClose }: Readonly<SettingsModalProps>) {
<div className="flex flex-col gap-5">
<div>
<span className="mb-2 block font-medium text-muted-foreground text-sm">
Conditions
Game System
</span>
<div className="flex gap-1">
{EDITION_OPTIONS.map((opt) => (

View File

@@ -2,6 +2,7 @@ import { Download, Loader2, Upload } from "lucide-react";
import { useId, useRef, useState } from "react";
import { useAdapters } from "../contexts/adapter-context.js";
import { useBestiaryContext } from "../contexts/bestiary-context.js";
import { useRulesEditionContext } from "../contexts/rules-edition-context.js";
import { Button } from "./ui/button.js";
import { Input } from "./ui/input.js";
@@ -14,11 +15,13 @@ export function SourceFetchPrompt({
sourceCode,
onSourceLoaded,
}: Readonly<SourceFetchPromptProps>) {
const { bestiaryIndex } = useAdapters();
const { bestiaryIndex, pf2eBestiaryIndex } = useAdapters();
const { fetchAndCacheSource, uploadAndCacheSource } = useBestiaryContext();
const sourceDisplayName = bestiaryIndex.getSourceDisplayName(sourceCode);
const { edition } = useRulesEditionContext();
const indexPort = edition === "pf2e" ? pf2eBestiaryIndex : bestiaryIndex;
const sourceDisplayName = indexPort.getSourceDisplayName(sourceCode);
const [url, setUrl] = useState(() =>
bestiaryIndex.getDefaultFetchUrl(sourceCode),
indexPort.getDefaultFetchUrl(sourceCode),
);
const [status, setStatus] = useState<"idle" | "fetching" | "error">("idle");
const [error, setError] = useState<string>("");

View File

@@ -9,12 +9,15 @@ import {
import type { CachedSourceInfo } from "../adapters/ports.js";
import { useAdapters } from "../contexts/adapter-context.js";
import { useBestiaryContext } from "../contexts/bestiary-context.js";
import { useRulesEditionContext } from "../contexts/rules-edition-context.js";
import { Button } from "./ui/button.js";
import { Input } from "./ui/input.js";
export function SourceManager() {
const { bestiaryCache } = useAdapters();
const { refreshCache } = useBestiaryContext();
const { edition } = useRulesEditionContext();
const system = edition === "pf2e" ? "pf2e" : "dnd";
const [sources, setSources] = useState<CachedSourceInfo[]>([]);
const [filter, setFilter] = useState("");
const [optimisticSources, applyOptimistic] = useOptimistic(
@@ -29,9 +32,9 @@ export function SourceManager() {
);
const loadSources = useCallback(async () => {
const cached = await bestiaryCache.getCachedSources();
const cached = await bestiaryCache.getCachedSources(system);
setSources(cached);
}, [bestiaryCache]);
}, [bestiaryCache, system]);
useEffect(() => {
void loadSources();
@@ -39,7 +42,7 @@ export function SourceManager() {
const handleClearSource = async (sourceCode: string) => {
applyOptimistic({ type: "remove", sourceCode });
await bestiaryCache.clearSource(sourceCode);
await bestiaryCache.clearSource(system, sourceCode);
await loadSources();
void refreshCache();
};

View File

@@ -0,0 +1,296 @@
import type { ActivityCost, SpellReference } from "@initiative/domain";
import { useEffect, useLayoutEffect, useRef, useState } from "react";
import { createPortal } from "react-dom";
import { useClickOutside } from "../hooks/use-click-outside.js";
import { useSwipeToDismissDown } from "../hooks/use-swipe-to-dismiss.js";
import { cn } from "../lib/utils.js";
import { ActivityIcon } from "./stat-block-parts.js";
interface SpellDetailPopoverProps {
readonly spell: SpellReference;
readonly anchorRect: DOMRect;
readonly onClose: () => void;
}
const RANK_LABELS = [
"Cantrip",
"1st",
"2nd",
"3rd",
"4th",
"5th",
"6th",
"7th",
"8th",
"9th",
"10th",
];
function formatRank(rank: number | undefined): string {
if (rank === undefined) return "";
return RANK_LABELS[rank] ?? `Rank ${rank}`;
}
function parseActionCost(cost: string): ActivityCost | null {
if (cost === "free") return { number: 1, unit: "free" };
if (cost === "reaction") return { number: 1, unit: "reaction" };
const n = Number(cost);
if (n >= 1 && n <= 3) return { number: n, unit: "action" };
return null;
}
function SpellActionCost({ cost }: Readonly<{ cost: string | undefined }>) {
if (!cost) return null;
const activity = parseActionCost(cost);
if (activity) {
return (
<span className="shrink-0 text-lg">
<ActivityIcon activity={activity} />
</span>
);
}
return <span className="shrink-0 text-muted-foreground text-xs">{cost}</span>;
}
function SpellHeader({ spell }: Readonly<{ spell: SpellReference }>) {
return (
<div className="flex items-center justify-between gap-2">
<h3 className="font-bold text-lg text-stat-heading">{spell.name}</h3>
<SpellActionCost cost={spell.actionCost} />
</div>
);
}
function SpellTraits({ traits }: Readonly<{ traits: readonly string[] }>) {
if (traits.length === 0) return null;
return (
<div className="flex flex-wrap gap-1">
{traits.map((t) => (
<span
key={t}
className="rounded border border-border bg-card px-1.5 py-0.5 text-foreground text-xs"
>
{t}
</span>
))}
</div>
);
}
function LabeledValue({
label,
value,
}: Readonly<{ label: string; value: string }>) {
return (
<>
<span className="font-semibold">{label}</span> {value}
</>
);
}
function SpellRangeLine({ spell }: Readonly<{ spell: SpellReference }>) {
const items: { label: string; value: string }[] = [];
if (spell.range) items.push({ label: "Range", value: spell.range });
if (spell.target) items.push({ label: "Target", value: spell.target });
if (spell.area) items.push({ label: "Area", value: spell.area });
if (items.length === 0) return null;
return (
<div>
{items.map((item, i) => (
<span key={item.label}>
{i > 0 ? "; " : ""}
<LabeledValue label={item.label} value={item.value} />
</span>
))}
</div>
);
}
function SpellMeta({ spell }: Readonly<{ spell: SpellReference }>) {
const hasTraditions =
spell.traditions !== undefined && spell.traditions.length > 0;
return (
<div className="space-y-0.5 text-xs">
{spell.rank === undefined ? null : (
<div>
<span className="font-semibold">{formatRank(spell.rank)}</span>
{hasTraditions ? (
<span className="text-muted-foreground">
{" "}
({spell.traditions?.join(", ")})
</span>
) : null}
</div>
)}
<SpellRangeLine spell={spell} />
{spell.duration ? (
<div>
<LabeledValue label="Duration" value={spell.duration} />
</div>
) : null}
{spell.defense ? (
<div>
<LabeledValue label="Defense" value={spell.defense} />
</div>
) : null}
</div>
);
}
const SAVE_OUTCOME_REGEX =
/(Critical Success|Critical Failure|Success|Failure)/g;
function SpellDescription({ text }: Readonly<{ text: string }>) {
const parts = text.split(SAVE_OUTCOME_REGEX);
const elements: React.ReactNode[] = [];
let offset = 0;
for (const part of parts) {
if (SAVE_OUTCOME_REGEX.test(part)) {
elements.push(<strong key={`b-${offset}`}>{part}</strong>);
} else if (part) {
elements.push(<span key={`t-${offset}`}>{part}</span>);
}
offset += part.length;
}
return <p className="whitespace-pre-line text-foreground">{elements}</p>;
}
function SpellDetailContent({ spell }: Readonly<{ spell: SpellReference }>) {
return (
<div className="space-y-2 text-sm">
<SpellHeader spell={spell} />
<SpellTraits traits={spell.traits ?? []} />
<SpellMeta spell={spell} />
{spell.description ? (
<SpellDescription text={spell.description} />
) : (
<p className="text-muted-foreground italic">
No description available.
</p>
)}
{spell.heightening ? (
<p className="whitespace-pre-line text-foreground text-xs">
{spell.heightening}
</p>
) : null}
</div>
);
}
function DesktopPopover({
spell,
anchorRect,
onClose,
}: Readonly<SpellDetailPopoverProps>) {
const ref = useRef<HTMLDivElement>(null);
const [pos, setPos] = useState<{ top: number; left: number } | null>(null);
useLayoutEffect(() => {
const el = ref.current;
if (!el) return;
const popover = el.getBoundingClientRect();
const vw = document.documentElement.clientWidth;
const vh = document.documentElement.clientHeight;
// Prefer placement to the LEFT of the anchor (panel is on the right edge)
let left = anchorRect.left - popover.width - 8;
if (left < 8) {
left = anchorRect.right + 8;
}
if (left + popover.width > vw - 8) {
left = vw - popover.width - 8;
}
let top = anchorRect.top;
if (top + popover.height > vh - 8) {
top = vh - popover.height - 8;
}
if (top < 8) top = 8;
setPos({ top, left });
}, [anchorRect]);
useClickOutside(ref, onClose);
return (
<div
ref={ref}
className="card-glow fixed z-50 max-h-[calc(100vh-16px)] w-80 max-w-[calc(100vw-16px)] overflow-y-auto rounded-lg border border-border bg-card p-4 shadow-lg"
style={pos ? { top: pos.top, left: pos.left } : { visibility: "hidden" }}
role="dialog"
aria-label={`Spell details: ${spell.name}`}
>
<SpellDetailContent spell={spell} />
</div>
);
}
function MobileSheet({
spell,
onClose,
}: Readonly<{ spell: SpellReference; onClose: () => void }>) {
const { offsetY, isSwiping, handlers } = useSwipeToDismissDown(onClose);
useEffect(() => {
const handler = (e: KeyboardEvent) => {
if (e.key === "Escape") onClose();
};
document.addEventListener("keydown", handler);
return () => document.removeEventListener("keydown", handler);
}, [onClose]);
return (
<div className="fixed inset-0 z-50">
<button
type="button"
className="fade-in absolute inset-0 animate-in bg-black/50"
onClick={onClose}
aria-label="Close spell details"
/>
<div
className={cn(
"panel-glow absolute right-0 bottom-0 left-0 max-h-[80vh] rounded-t-2xl border-border border-t bg-card",
!isSwiping && "animate-slide-in-bottom",
)}
style={
isSwiping ? { transform: `translateY(${offsetY}px)` } : undefined
}
{...handlers}
role="dialog"
aria-label={`Spell details: ${spell.name}`}
>
<div className="flex justify-center pt-2 pb-1">
<div className="h-1 w-10 rounded-full bg-muted-foreground/40" />
</div>
<div className="max-h-[calc(80vh-24px)] overflow-y-auto p-4">
<SpellDetailContent spell={spell} />
</div>
</div>
</div>
);
}
export function SpellDetailPopover({
spell,
anchorRect,
onClose,
}: Readonly<SpellDetailPopoverProps>) {
const [isDesktop, setIsDesktop] = useState(
() => globalThis.matchMedia("(min-width: 1024px)").matches,
);
useEffect(() => {
const mq = globalThis.matchMedia("(min-width: 1024px)");
const handler = (e: MediaQueryListEvent) => setIsDesktop(e.matches);
mq.addEventListener("change", handler);
return () => mq.removeEventListener("change", handler);
}, []);
// Portal to document.body to escape any CSS transforms on ancestors
// (the side panel uses translate-x for collapse animation, which would
// otherwise become the containing block for fixed-positioned children).
const content = isDesktop ? (
<DesktopPopover spell={spell} anchorRect={anchorRect} onClose={onClose} />
) : (
<MobileSheet spell={spell} onClose={onClose} />
);
return createPortal(content, document.body);
}

View File

@@ -1,4 +1,4 @@
import type { CreatureId } from "@initiative/domain";
import type { Creature, CreatureId } from "@initiative/domain";
import { PanelRightClose, Pin, PinOff } from "lucide-react";
import type { ReactNode } from "react";
import { useEffect, useState } from "react";
@@ -7,9 +7,10 @@ import { useSidePanelContext } from "../contexts/side-panel-context.js";
import { useSwipeToDismiss } from "../hooks/use-swipe-to-dismiss.js";
import { cn } from "../lib/utils.js";
import { BulkImportPrompt } from "./bulk-import-prompt.js";
import { DndStatBlock } from "./dnd-stat-block.js";
import { Pf2eStatBlock } from "./pf2e-stat-block.js";
import { SourceFetchPrompt } from "./source-fetch-prompt.js";
import { SourceManager } from "./source-manager.js";
import { StatBlock } from "./stat-block.js";
import { Button } from "./ui/button.js";
interface StatBlockPanelProps {
@@ -20,7 +21,10 @@ interface StatBlockPanelProps {
function extractSourceCode(cId: CreatureId): string {
const colonIndex = cId.indexOf(":");
if (colonIndex === -1) return "";
return cId.slice(0, colonIndex).toUpperCase();
const prefix = cId.slice(0, colonIndex);
// D&D source codes are short uppercase (e.g. "mm" from "MM").
// PF2e source codes use hyphens (e.g. "pathfinder-monster-core").
return prefix.includes("-") ? prefix : prefix.toUpperCase();
}
function CollapsedTab({
@@ -307,7 +311,10 @@ export function StatBlockPanel({
}
if (creature) {
return <StatBlock creature={creature} />;
if ("system" in creature && creature.system === "pf2e") {
return <Pf2eStatBlock creature={creature} />;
}
return <DndStatBlock creature={creature as Creature} />;
}
if (needsFetch && sourceCode) {

View File

@@ -0,0 +1,179 @@
import type {
ActivityCost,
TraitBlock,
TraitSegment,
} from "@initiative/domain";
export function PropertyLine({
label,
value,
}: Readonly<{
label: string;
value: string | undefined;
}>) {
if (!value) return null;
return (
<div className="text-sm">
<span className="font-semibold">{label}</span> {value}
</div>
);
}
export function SectionDivider() {
return (
<div className="my-2 h-px bg-gradient-to-r from-stat-divider-from via-stat-divider-via to-transparent" />
);
}
function segmentKey(seg: TraitSegment): string {
return seg.type === "text"
? seg.value.slice(0, 40)
: seg.items.map((i) => i.label ?? i.text.slice(0, 20)).join(",");
}
function TraitSegments({
segments,
}: Readonly<{ segments: readonly TraitSegment[] }>) {
return (
<>
{segments.map((seg, i) => {
if (seg.type === "text") {
return (
<span key={segmentKey(seg)}>
{i === 0 ? ` ${seg.value}` : seg.value}
</span>
);
}
return (
<div key={segmentKey(seg)} className="mt-1 space-y-0.5">
{seg.items.map((item) => (
<p key={item.label ?? item.text}>
{item.label != null && (
<span className="font-semibold">{item.label}. </span>
)}
{item.text}
</p>
))}
</div>
);
})}
</>
);
}
const ACTION_DIAMOND = "M50 2 L96 50 L50 98 L4 50 Z M48 27 L71 50 L48 73 Z";
const ACTION_DIAMOND_SOLID = "M50 2 L96 50 L50 98 L4 50 Z";
const ACTION_DIAMOND_OUTLINE =
"M90 2 L136 50 L90 98 L44 50 Z M90 29 L111 50 L90 71 L69 50 Z";
const FREE_ACTION_DIAMOND =
"M50 2 L96 50 L50 98 L4 50 Z M50 12 L12 50 L50 88 L88 50 Z";
const FREE_ACTION_CHEVRON = "M48 27 L71 50 L48 73 Z";
const REACTION_ARROW =
"M75 15 A42 42 0 1 0 85 55 L72 55 A30 30 0 1 1 65 25 L65 40 L92 20 L65 0 L65 15 Z";
export function ActivityIcon({
activity,
}: Readonly<{ activity: ActivityCost }>) {
const cls = "inline-block h-[1em] align-[-0.1em]";
if (activity.unit === "free") {
return (
<svg aria-hidden="true" className={cls} viewBox="0 0 100 100">
<path d={FREE_ACTION_DIAMOND} fill="currentColor" fillRule="evenodd" />
<path d={FREE_ACTION_CHEVRON} fill="currentColor" />
</svg>
);
}
if (activity.unit === "reaction") {
return (
<svg aria-hidden="true" className={cls} viewBox="0 0 100 100">
<g transform="translate(100,100) rotate(180)">
<path d={REACTION_ARROW} fill="currentColor" />
</g>
</svg>
);
}
const count = activity.number;
if (count === 1) {
return (
<svg aria-hidden="true" className={cls} viewBox="0 0 100 100">
<path d={ACTION_DIAMOND} fill="currentColor" fillRule="evenodd" />
</svg>
);
}
if (count === 2) {
return (
<svg aria-hidden="true" className={cls} viewBox="0 0 140 100">
<path d={ACTION_DIAMOND_SOLID} fill="currentColor" />
<path
d={ACTION_DIAMOND_OUTLINE}
fill="currentColor"
fillRule="evenodd"
/>
</svg>
);
}
return (
<svg aria-hidden="true" className={cls} viewBox="0 0 180 100">
<path d={ACTION_DIAMOND_SOLID} fill="currentColor" />
<path d="M90 2 L136 50 L90 98 L44 50 Z" fill="currentColor" />
<path
d="M130 2 L176 50 L130 98 L84 50 Z M130 29 L151 50 L130 71 L109 50 Z"
fill="currentColor"
fillRule="evenodd"
/>
</svg>
);
}
export function TraitEntry({ trait }: Readonly<{ trait: TraitBlock }>) {
return (
<div className="text-sm">
<span className="font-semibold italic">
{trait.name}
{trait.activity ? null : "."}
{trait.activity ? (
<>
{" "}
<ActivityIcon activity={trait.activity} />
</>
) : null}
</span>
{trait.trigger ? (
<>
{" "}
<span className="font-semibold">Trigger</span> {trait.trigger}
{trait.segments.length > 0 ? (
<>
{" "}
<span className="font-semibold">Effect</span>
</>
) : null}
</>
) : null}
<TraitSegments segments={trait.segments} />
</div>
);
}
export function TraitSection({
entries,
heading,
}: Readonly<{
entries: readonly TraitBlock[] | undefined;
heading?: string;
}>) {
if (!entries || entries.length === 0) return null;
return (
<>
<SectionDivider />
{heading ? (
<h3 className="font-bold text-base text-stat-heading">{heading}</h3>
) : null}
<div className="space-y-2">
{entries.map((e) => (
<TraitEntry key={e.name} trait={e} />
))}
</div>
</>
);
}

View File

@@ -1,9 +1,14 @@
import { Redo2, StepBack, StepForward, Trash2, Undo2 } from "lucide-react";
import { useState } from "react";
import { useEncounterContext } from "../contexts/encounter-context.js";
import { useRulesEditionContext } from "../contexts/rules-edition-context.js";
import { useDifficulty } from "../hooks/use-difficulty.js";
import { DifficultyBreakdownPanel } from "./difficulty-breakdown-panel.js";
import { DifficultyIndicator } from "./difficulty-indicator.js";
import {
DifficultyIndicator,
TIER_LABELS_5_5E,
TIER_LABELS_2014,
} from "./difficulty-indicator.js";
import { Button } from "./ui/button.js";
import { ConfirmButton } from "./ui/confirm-button.js";
@@ -20,25 +25,27 @@ export function TurnNavigation() {
} = useEncounterContext();
const difficulty = useDifficulty();
const { edition } = useRulesEditionContext();
const tierLabels = edition === "5e" ? TIER_LABELS_2014 : TIER_LABELS_5_5E;
const [showBreakdown, setShowBreakdown] = useState(false);
const hasCombatants = encounter.combatants.length > 0;
const isAtStart = encounter.roundNumber === 1 && encounter.activeIndex === 0;
const activeCombatant = encounter.combatants[encounter.activeIndex];
return (
<div className="card-glow flex items-center gap-3 border-border border-b bg-card px-4 py-3 sm:rounded-lg sm:border">
<Button
variant="ghost"
size="icon"
onClick={retreatTurn}
disabled={!hasCombatants || isAtStart}
title="Previous turn"
aria-label="Previous turn"
>
<StepBack className="h-5 w-5" />
</Button>
<div className="card-glow grid grid-cols-[1fr_minmax(0,auto)_1fr] items-center border-border border-b bg-card px-2 py-3 sm:rounded-lg sm:border sm:px-4">
{/* Left zone: navigation + history + round */}
<div className="flex items-center gap-1">
<Button
variant="ghost"
size="icon"
onClick={retreatTurn}
disabled={!hasCombatants || isAtStart}
title="Previous turn"
aria-label="Previous turn"
>
<StepBack className="h-5 w-5" />
</Button>
<Button
variant="ghost"
size="icon"
@@ -59,23 +66,27 @@ export function TurnNavigation() {
>
<Redo2 className="h-4 w-4" />
</Button>
<span className="ml-1 rounded-md bg-muted px-2 py-0.5 font-semibold text-foreground text-sm tabular-nums">
R{encounter.roundNumber}
</span>
</div>
<div className="flex min-w-0 flex-1 items-center justify-center gap-2 text-sm">
<span className="shrink-0 rounded-md bg-muted px-2 py-0.5 font-semibold text-foreground text-sm">
<span className="-mt-[3px] inline-block">
R{encounter.roundNumber}
</span>
</span>
{/* Center zone: active combatant name */}
<div className="min-w-0 px-2 text-center text-sm">
{activeCombatant ? (
<span className="truncate font-medium">{activeCombatant.name}</span>
) : (
<span className="text-muted-foreground">No combatants</span>
)}
</div>
{/* Right zone: difficulty + destructive + forward */}
<div className="flex items-center justify-end gap-1">
{difficulty && (
<div className="relative">
<div className="relative mr-1">
<DifficultyIndicator
result={difficulty}
labels={tierLabels}
onClick={() => setShowBreakdown((prev) => !prev)}
/>
{showBreakdown ? (
@@ -85,9 +96,6 @@ export function TurnNavigation() {
) : null}
</div>
)}
</div>
<div className="flex flex-shrink-0 items-center gap-3">
<ConfirmButton
icon={<Trash2 className="h-5 w-5" />}
label="Clear encounter"

View File

@@ -3,6 +3,7 @@ import type {
BestiaryCachePort,
BestiaryIndexPort,
EncounterPersistence,
Pf2eBestiaryIndexPort,
PlayerCharacterPersistence,
UndoRedoPersistence,
} from "../adapters/ports.js";
@@ -13,6 +14,7 @@ export interface Adapters {
playerCharacterPersistence: PlayerCharacterPersistence;
bestiaryCache: BestiaryCachePort;
bestiaryIndex: BestiaryIndexPort;
pf2eBestiaryIndex: Pf2eBestiaryIndexPort;
}
const AdapterContext = createContext<Adapters | null>(null);

View File

@@ -1,8 +1,4 @@
import type {
BestiaryIndexEntry,
ConditionId,
PlayerCharacter,
} from "@initiative/domain";
import type { ConditionId, PlayerCharacter } from "@initiative/domain";
import {
combatantId,
createEncounter,
@@ -11,6 +7,7 @@ import {
playerCharacterId,
} from "@initiative/domain";
import { describe, expect, it } from "vitest";
import type { SearchResult } from "../use-bestiary.js";
import { type EncounterState, encounterReducer } from "../use-encounter.js";
function emptyState(): EncounterState {
@@ -45,9 +42,11 @@ function stateWithHp(name: string, maxHp: number): EncounterState {
});
}
const BESTIARY_ENTRY: BestiaryIndexEntry = {
const BESTIARY_ENTRY: SearchResult = {
system: "dnd",
name: "Goblin",
source: "MM",
sourceDisplayName: "Monster Manual",
ac: 15,
hp: 7,
dex: 14,
@@ -57,6 +56,19 @@ const BESTIARY_ENTRY: BestiaryIndexEntry = {
type: "humanoid",
};
const PF2E_BESTIARY_ENTRY: SearchResult = {
system: "pf2e",
name: "Goblin Warrior",
source: "B1",
sourceDisplayName: "Bestiary",
level: -1,
ac: 16,
hp: 6,
perception: 5,
size: "small",
type: "humanoid",
};
describe("encounterReducer", () => {
describe("add-combatant", () => {
it("adds a combatant and pushes undo", () => {
@@ -236,7 +248,9 @@ describe("encounterReducer", () => {
conditionId: "blinded" as ConditionId,
});
expect(next.encounter.combatants[0].conditions).toContain("blinded");
expect(next.encounter.combatants[0].conditions).toContainEqual({
id: "blinded",
});
});
it("toggles concentration", () => {
@@ -327,6 +341,19 @@ describe("encounterReducer", () => {
expect(names).toContain("Goblin 1");
expect(names).toContain("Goblin 2");
});
it("adds PF2e creature with HP, AC, and creatureId", () => {
const next = encounterReducer(emptyState(), {
type: "add-from-bestiary",
entry: PF2E_BESTIARY_ENTRY,
});
const c = next.encounter.combatants[0];
expect(c.name).toBe("Goblin Warrior");
expect(c.maxHp).toBe(6);
expect(c.ac).toBe(16);
expect(c.creatureId).toBe("b1:goblin-warrior");
});
});
describe("add-multiple-from-bestiary", () => {

View File

@@ -12,6 +12,7 @@ import {
} from "../../__tests__/factories/index.js";
import { AllProviders } from "../../__tests__/test-providers.js";
import { useDifficultyBreakdown } from "../use-difficulty-breakdown.js";
import { useRulesEdition } from "../use-rules-edition.js";
beforeAll(() => {
Object.defineProperty(globalThis, "matchMedia", {
@@ -106,7 +107,7 @@ describe("useDifficultyBreakdown", () => {
expect(result.current).toBeNull();
});
it("returns per-combatant entries with correct data", async () => {
it("returns per-combatant entries split by side", async () => {
const wrapper = makeWrapper({
encounter: buildEncounter({
combatants: [
@@ -145,29 +146,34 @@ describe("useDifficultyBreakdown", () => {
const breakdown = result.current;
expect(breakdown).not.toBeNull();
expect(breakdown?.pcCount).toBe(1);
// CR 1/4 = 50 + CR 2 = 450 total 500
// CR 1/4 = 50 + CR 2 = 450 -> total 500
expect(breakdown?.totalMonsterXp).toBe(500);
expect(breakdown?.combatants).toHaveLength(3);
// Bestiary combatant
const goblin = breakdown?.combatants[0];
// PC in party column
expect(breakdown?.partyCombatants).toHaveLength(1);
expect(breakdown?.partyCombatants[0].combatant.name).toBe("Hero");
expect(breakdown?.partyCombatants[0].side).toBe("party");
expect(breakdown?.partyCombatants[0].level).toBe(5);
// Enemies: goblin, thug, bandit
expect(breakdown?.enemyCombatants).toHaveLength(3);
const goblin = breakdown?.enemyCombatants[0];
expect(goblin?.cr).toBe("1/4");
expect(goblin?.xp).toBe(50);
expect(goblin?.source).toBe("SRD");
expect(goblin?.editable).toBe(false);
expect(goblin?.side).toBe("enemy");
// Custom with CR
const thug = breakdown?.combatants[1];
const thug = breakdown?.enemyCombatants[1];
expect(thug?.cr).toBe("2");
expect(thug?.xp).toBe(450);
expect(thug?.source).toBeNull();
expect(thug?.editable).toBe(true);
// Custom without CR
const bandit = breakdown?.combatants[2];
const bandit = breakdown?.enemyCombatants[2];
expect(bandit?.cr).toBeNull();
expect(bandit?.xp).toBeNull();
expect(bandit?.source).toBeNull();
expect(bandit?.editable).toBe(true);
});
});
@@ -203,16 +209,15 @@ describe("useDifficultyBreakdown", () => {
wrapper,
});
// With no bestiary creatures loaded, the Ghost has null CR
const breakdown = result.current;
expect(breakdown).not.toBeNull();
const ghost = breakdown?.combatants[0];
const ghost = breakdown?.enemyCombatants[0];
expect(ghost?.cr).toBeNull();
expect(ghost?.xp).toBeNull();
expect(ghost?.editable).toBe(false);
});
it("excludes PC combatants from breakdown entries", async () => {
it("PC combatants appear in partyCombatants with level", async () => {
const wrapper = makeWrapper({
encounter: buildEncounter({
combatants: [
@@ -239,8 +244,105 @@ describe("useDifficultyBreakdown", () => {
});
await waitFor(() => {
expect(result.current?.combatants).toHaveLength(1);
expect(result.current?.combatants[0].combatant.name).toBe("Goblin");
expect(result.current?.partyCombatants).toHaveLength(1);
expect(result.current?.partyCombatants[0].combatant.name).toBe("Hero");
expect(result.current?.partyCombatants[0].level).toBe(1);
expect(result.current?.partyCombatants[0].side).toBe("party");
});
});
it("combatant with explicit side override is placed correctly", () => {
const wrapper = makeWrapper({
encounter: buildEncounter({
combatants: [
buildCombatant({
id: combatantId("c-1"),
name: "Hero",
playerCharacterId: pcId1,
}),
buildCombatant({
id: combatantId("c-2"),
name: "Allied Guard",
creatureId: goblinCreature.id,
side: "party",
}),
buildCombatant({
id: combatantId("c-3"),
name: "Thug",
cr: "1",
}),
],
}),
playerCharacters: [
{ id: pcId1, name: "Hero", ac: 15, maxHp: 30, level: 5 },
],
creatures: new Map([[goblinCreature.id, goblinCreature]]),
});
const { result } = renderHook(() => useDifficultyBreakdown(), {
wrapper,
});
const breakdown = result.current;
expect(breakdown).not.toBeNull();
// Allied Guard should be in party column
expect(breakdown?.partyCombatants).toHaveLength(2);
expect(breakdown?.partyCombatants[1].combatant.name).toBe("Allied Guard");
expect(breakdown?.partyCombatants[1].side).toBe("party");
// Thug in enemy column
expect(breakdown?.enemyCombatants).toHaveLength(1);
expect(breakdown?.enemyCombatants[0].combatant.name).toBe("Thug");
});
it("exposes encounterMultiplier and adjustedXp for 5e edition", async () => {
const wrapper = makeWrapper({
encounter: buildEncounter({
combatants: [
buildCombatant({
id: combatantId("c-1"),
name: "Hero",
playerCharacterId: pcId1,
}),
buildCombatant({
id: combatantId("c-2"),
name: "Goblin",
creatureId: goblinCreature.id,
}),
buildCombatant({
id: combatantId("c-3"),
name: "Thug",
cr: "1",
}),
],
}),
playerCharacters: [
{ id: pcId1, name: "Hero", ac: 15, maxHp: 30, level: 1 },
],
creatures: new Map([[goblinCreature.id, goblinCreature]]),
});
const { result: editionResult } = renderHook(() => useRulesEdition(), {
wrapper,
});
editionResult.current.setEdition("5e");
try {
const { result } = renderHook(() => useDifficultyBreakdown(), {
wrapper,
});
await waitFor(() => {
const breakdown = result.current;
expect(breakdown).not.toBeNull();
// 2 enemy monsters, 1 PC (<3) → base x1.5, shift up → x2
expect(breakdown?.encounterMultiplier).toBe(2);
// CR 1/4 (50) + CR 1 (200) = 250, x2 = 500
expect(breakdown?.totalMonsterXp).toBe(250);
expect(breakdown?.adjustedXp).toBe(500);
expect(breakdown?.thresholds).toHaveLength(4);
});
} finally {
editionResult.current.setEdition("5.5e");
}
});
});

View File

@@ -1,220 +0,0 @@
// @vitest-environment jsdom
import type {
Combatant,
CreatureId,
Encounter,
PlayerCharacter,
} from "@initiative/domain";
import { combatantId, creatureId, playerCharacterId } from "@initiative/domain";
import { renderHook } from "@testing-library/react";
import { beforeEach, describe, expect, it, vi } from "vitest";
vi.mock("../../contexts/encounter-context.js", () => ({
useEncounterContext: vi.fn(),
}));
vi.mock("../../contexts/player-characters-context.js", () => ({
usePlayerCharactersContext: vi.fn(),
}));
vi.mock("../../contexts/bestiary-context.js", () => ({
useBestiaryContext: vi.fn(),
}));
import { useBestiaryContext } from "../../contexts/bestiary-context.js";
import { useEncounterContext } from "../../contexts/encounter-context.js";
import { usePlayerCharactersContext } from "../../contexts/player-characters-context.js";
import { useDifficulty } from "../use-difficulty.js";
const mockEncounterContext = vi.mocked(useEncounterContext);
const mockPlayerCharactersContext = vi.mocked(usePlayerCharactersContext);
const mockBestiaryContext = vi.mocked(useBestiaryContext);
const pcId1 = playerCharacterId("pc-1");
const pcId2 = playerCharacterId("pc-2");
const crId1 = creatureId("creature-1");
const _crId2 = creatureId("creature-2");
function setup(options: {
combatants: Combatant[];
characters: PlayerCharacter[];
creatures: Map<CreatureId, { cr: string }>;
}) {
const encounter = {
combatants: options.combatants,
activeIndex: 0,
roundNumber: 1,
} as Encounter;
mockEncounterContext.mockReturnValue({
encounter,
} as ReturnType<typeof useEncounterContext>);
mockPlayerCharactersContext.mockReturnValue({
characters: options.characters,
} as ReturnType<typeof usePlayerCharactersContext>);
mockBestiaryContext.mockReturnValue({
getCreature: (id: CreatureId) => options.creatures.get(id),
} as ReturnType<typeof useBestiaryContext>);
}
beforeEach(() => {
vi.clearAllMocks();
});
describe("useDifficulty", () => {
it("returns difficulty result for leveled PCs and bestiary monsters", () => {
setup({
combatants: [
{ id: combatantId("c1"), name: "Hero", playerCharacterId: pcId1 },
{ id: combatantId("c2"), name: "Goblin", creatureId: crId1 },
],
characters: [{ id: pcId1, name: "Hero", ac: 15, maxHp: 30, level: 1 }],
creatures: new Map([[crId1, { cr: "1/4" }]]),
});
const { result } = renderHook(() => useDifficulty());
expect(result.current).not.toBeNull();
expect(result.current?.tier).toBe("low");
expect(result.current?.totalMonsterXp).toBe(50);
});
describe("returns null when data is insufficient (ED-2)", () => {
it("returns null when encounter has no combatants", () => {
setup({ combatants: [], characters: [], creatures: new Map() });
const { result } = renderHook(() => useDifficulty());
expect(result.current).toBeNull();
});
it("returns null when only custom combatants (no creatureId)", () => {
setup({
combatants: [
{
id: combatantId("c1"),
name: "Custom",
playerCharacterId: pcId1,
},
],
characters: [{ id: pcId1, name: "Hero", ac: 15, maxHp: 30, level: 5 }],
creatures: new Map(),
});
const { result } = renderHook(() => useDifficulty());
expect(result.current).toBeNull();
});
it("returns null when bestiary monsters present but no PC combatants", () => {
setup({
combatants: [
{ id: combatantId("c1"), name: "Goblin", creatureId: crId1 },
],
characters: [],
creatures: new Map([[crId1, { cr: "1" }]]),
});
const { result } = renderHook(() => useDifficulty());
expect(result.current).toBeNull();
});
it("returns null when PC combatants have no level", () => {
setup({
combatants: [
{
id: combatantId("c1"),
name: "Hero",
playerCharacterId: pcId1,
},
{ id: combatantId("c2"), name: "Goblin", creatureId: crId1 },
],
characters: [{ id: pcId1, name: "Hero", ac: 15, maxHp: 30 }],
creatures: new Map([[crId1, { cr: "1" }]]),
});
const { result } = renderHook(() => useDifficulty());
expect(result.current).toBeNull();
});
it("returns null when PC combatant references unknown player character", () => {
setup({
combatants: [
{
id: combatantId("c1"),
name: "Hero",
playerCharacterId: pcId2,
},
{ id: combatantId("c2"), name: "Goblin", creatureId: crId1 },
],
characters: [{ id: pcId1, name: "Other", ac: 15, maxHp: 30, level: 5 }],
creatures: new Map([[crId1, { cr: "1" }]]),
});
const { result } = renderHook(() => useDifficulty());
expect(result.current).toBeNull();
});
});
it("handles mixed combatants: only leveled PCs and bestiary monsters contribute", () => {
// Party: one leveled PC, one without level (excluded)
// Monsters: one bestiary creature, one custom (excluded)
setup({
combatants: [
{
id: combatantId("c1"),
name: "Leveled",
playerCharacterId: pcId1,
},
{
id: combatantId("c2"),
name: "No Level",
playerCharacterId: pcId2,
},
{ id: combatantId("c3"), name: "Goblin", creatureId: crId1 },
{ id: combatantId("c4"), name: "Custom Monster" },
],
characters: [
{ id: pcId1, name: "Leveled", ac: 15, maxHp: 30, level: 1 },
{ id: pcId2, name: "No Level", ac: 12, maxHp: 20 },
],
creatures: new Map([[crId1, { cr: "1" }]]),
});
const { result } = renderHook(() => useDifficulty());
expect(result.current).not.toBeNull();
// 1 level-1 PC: budget low=50, mod=75, high=100
// 1 CR 1 monster: 200 XP → high (200 >= 100)
expect(result.current?.tier).toBe("high");
expect(result.current?.totalMonsterXp).toBe(200);
expect(result.current?.partyBudget.low).toBe(50);
});
it("includes duplicate PC combatants in budget", () => {
// Same PC added twice → counts twice
setup({
combatants: [
{
id: combatantId("c1"),
name: "Hero 1",
playerCharacterId: pcId1,
},
{
id: combatantId("c2"),
name: "Hero 2",
playerCharacterId: pcId1,
},
{ id: combatantId("c3"), name: "Goblin", creatureId: crId1 },
],
characters: [{ id: pcId1, name: "Hero", ac: 15, maxHp: 30, level: 1 }],
creatures: new Map([[crId1, { cr: "1/4" }]]),
});
const { result } = renderHook(() => useDifficulty());
expect(result.current).not.toBeNull();
// 2x level 1: budget low=100
expect(result.current?.partyBudget.low).toBe(100);
});
});

View File

@@ -0,0 +1,427 @@
// @vitest-environment jsdom
import type { Creature, CreatureId, PlayerCharacter } from "@initiative/domain";
import { combatantId, creatureId, playerCharacterId } from "@initiative/domain";
import { renderHook, waitFor } from "@testing-library/react";
import type { ReactNode } from "react";
import { beforeAll, describe, expect, it, vi } from "vitest";
import { createTestAdapters } from "../../__tests__/adapters/in-memory-adapters.js";
import {
buildCombatant,
buildCreature,
buildEncounter,
} from "../../__tests__/factories/index.js";
import { AllProviders } from "../../__tests__/test-providers.js";
import { useDifficulty } from "../use-difficulty.js";
import { useRulesEdition } from "../use-rules-edition.js";
beforeAll(() => {
Object.defineProperty(globalThis, "matchMedia", {
writable: true,
value: vi.fn().mockImplementation((query: string) => ({
matches: false,
media: query,
onchange: null,
addListener: vi.fn(),
removeListener: vi.fn(),
addEventListener: vi.fn(),
removeEventListener: vi.fn(),
dispatchEvent: vi.fn(),
})),
});
});
const pcId1 = playerCharacterId("pc-1");
const pcId2 = playerCharacterId("pc-2");
const crId1 = creatureId("srd:goblin");
const goblinCreature = buildCreature({
id: crId1,
name: "Goblin",
cr: "1/4",
});
function makeWrapper(options: {
encounter: ReturnType<typeof buildEncounter>;
playerCharacters?: PlayerCharacter[];
creatures?: Map<CreatureId, Creature>;
}) {
const adapters = createTestAdapters({
encounter: options.encounter,
playerCharacters: options.playerCharacters ?? [],
creatures: options.creatures,
});
return ({ children }: { children: ReactNode }) => (
<AllProviders adapters={adapters}>{children}</AllProviders>
);
}
describe("useDifficulty", () => {
it("returns difficulty result for leveled PCs and bestiary monsters", async () => {
const wrapper = makeWrapper({
encounter: buildEncounter({
combatants: [
buildCombatant({
id: combatantId("c1"),
name: "Hero",
playerCharacterId: pcId1,
}),
buildCombatant({
id: combatantId("c2"),
name: "Goblin",
creatureId: crId1,
}),
],
}),
playerCharacters: [
{ id: pcId1, name: "Hero", ac: 15, maxHp: 30, level: 1 },
],
creatures: new Map([[crId1, goblinCreature]]),
});
const { result } = renderHook(() => useDifficulty(), { wrapper });
await waitFor(() => {
expect(result.current).not.toBeNull();
expect(result.current?.tier).toBe(1);
expect(result.current?.totalMonsterXp).toBe(50);
});
});
describe("returns null when data is insufficient (ED-2)", () => {
it("returns null when encounter has no combatants", () => {
const wrapper = makeWrapper({
encounter: buildEncounter({ combatants: [] }),
});
const { result } = renderHook(() => useDifficulty(), { wrapper });
expect(result.current).toBeNull();
});
it("returns null when only custom combatants (no creatureId)", () => {
const wrapper = makeWrapper({
encounter: buildEncounter({
combatants: [
buildCombatant({
id: combatantId("c1"),
name: "Custom",
playerCharacterId: pcId1,
}),
],
}),
playerCharacters: [
{ id: pcId1, name: "Hero", ac: 15, maxHp: 30, level: 5 },
],
});
const { result } = renderHook(() => useDifficulty(), { wrapper });
expect(result.current).toBeNull();
});
it("returns null when bestiary monsters present but no PC combatants", () => {
const wrapper = makeWrapper({
encounter: buildEncounter({
combatants: [
buildCombatant({
id: combatantId("c1"),
name: "Goblin",
creatureId: crId1,
}),
],
}),
creatures: new Map([[crId1, goblinCreature]]),
});
const { result } = renderHook(() => useDifficulty(), { wrapper });
expect(result.current).toBeNull();
});
it("returns null when PC combatants have no level", () => {
const wrapper = makeWrapper({
encounter: buildEncounter({
combatants: [
buildCombatant({
id: combatantId("c1"),
name: "Hero",
playerCharacterId: pcId1,
}),
buildCombatant({
id: combatantId("c2"),
name: "Goblin",
creatureId: crId1,
}),
],
}),
playerCharacters: [{ id: pcId1, name: "Hero", ac: 15, maxHp: 30 }],
creatures: new Map([[crId1, goblinCreature]]),
});
const { result } = renderHook(() => useDifficulty(), { wrapper });
expect(result.current).toBeNull();
});
it("returns null when PC combatant references unknown player character", () => {
const wrapper = makeWrapper({
encounter: buildEncounter({
combatants: [
buildCombatant({
id: combatantId("c1"),
name: "Hero",
playerCharacterId: pcId2,
}),
buildCombatant({
id: combatantId("c2"),
name: "Goblin",
creatureId: crId1,
}),
],
}),
playerCharacters: [
{ id: pcId1, name: "Other", ac: 15, maxHp: 30, level: 5 },
],
creatures: new Map([[crId1, goblinCreature]]),
});
const { result } = renderHook(() => useDifficulty(), { wrapper });
expect(result.current).toBeNull();
});
});
it("handles mixed combatants: only leveled PCs and CR-bearing monsters contribute", async () => {
const wrapper = makeWrapper({
encounter: buildEncounter({
combatants: [
buildCombatant({
id: combatantId("c1"),
name: "Leveled",
playerCharacterId: pcId1,
}),
buildCombatant({
id: combatantId("c2"),
name: "No Level",
playerCharacterId: pcId2,
}),
buildCombatant({
id: combatantId("c3"),
name: "Goblin",
creatureId: crId1,
}),
buildCombatant({
id: combatantId("c4"),
name: "Custom Monster",
}),
],
}),
playerCharacters: [
{ id: pcId1, name: "Leveled", ac: 15, maxHp: 30, level: 1 },
{ id: pcId2, name: "No Level", ac: 12, maxHp: 20 },
],
creatures: new Map([[crId1, goblinCreature]]),
});
const { result } = renderHook(() => useDifficulty(), { wrapper });
await waitFor(() => {
expect(result.current).not.toBeNull();
// 1 level-1 PC: budget low=50, mod=75, high=100
// CR 1/4 = 50 XP -> low (50 >= 50)
expect(result.current?.tier).toBe(1);
expect(result.current?.totalMonsterXp).toBe(50);
expect(result.current?.thresholds[0].value).toBe(50);
});
});
it("includes duplicate PC combatants in budget", async () => {
const wrapper = makeWrapper({
encounter: buildEncounter({
combatants: [
buildCombatant({
id: combatantId("c1"),
name: "Hero 1",
playerCharacterId: pcId1,
}),
buildCombatant({
id: combatantId("c2"),
name: "Hero 2",
playerCharacterId: pcId1,
}),
buildCombatant({
id: combatantId("c3"),
name: "Goblin",
creatureId: crId1,
}),
],
}),
playerCharacters: [
{ id: pcId1, name: "Hero", ac: 15, maxHp: 30, level: 1 },
],
creatures: new Map([[crId1, goblinCreature]]),
});
const { result } = renderHook(() => useDifficulty(), { wrapper });
await waitFor(() => {
expect(result.current).not.toBeNull();
// 2x level 1: budget low=100
expect(result.current?.thresholds[0].value).toBe(100);
});
});
it("combatant toggled to party side subtracts XP", async () => {
const bugbear = buildCreature({
id: creatureId("srd:bugbear"),
name: "Bugbear",
cr: "1",
});
const wrapper = makeWrapper({
encounter: buildEncounter({
combatants: [
buildCombatant({
id: combatantId("c1"),
name: "Hero",
playerCharacterId: pcId1,
}),
buildCombatant({
id: combatantId("c2"),
name: "Allied Guard",
creatureId: bugbear.id,
side: "party",
}),
buildCombatant({
id: combatantId("c3"),
name: "Thug",
cr: "1",
}),
],
}),
playerCharacters: [
{ id: pcId1, name: "Hero", ac: 15, maxHp: 30, level: 1 },
],
creatures: new Map([[bugbear.id, bugbear]]),
});
const { result } = renderHook(() => useDifficulty(), { wrapper });
await waitFor(() => {
expect(result.current).not.toBeNull();
// Thug CR 1 = 200 XP, Allied Guard CR 1 = 200 XP subtracted, net = 0
expect(result.current?.totalMonsterXp).toBe(0);
expect(result.current?.tier).toBe(0);
});
});
it("default side resolution: PC -> party, non-PC -> enemy", async () => {
const wrapper = makeWrapper({
encounter: buildEncounter({
combatants: [
buildCombatant({
id: combatantId("c1"),
name: "Hero",
playerCharacterId: pcId1,
}),
buildCombatant({
id: combatantId("c2"),
name: "Goblin",
creatureId: crId1,
}),
],
}),
playerCharacters: [
{ id: pcId1, name: "Hero", ac: 15, maxHp: 30, level: 3 },
],
creatures: new Map([[crId1, goblinCreature]]),
});
const { result } = renderHook(() => useDifficulty(), { wrapper });
await waitFor(() => {
expect(result.current).not.toBeNull();
// Level 3 budget: low=150, mod=225, high=400
// CR 1/4 = 50 XP -> trivial
expect(result.current?.thresholds[0].value).toBe(150);
expect(result.current?.totalMonsterXp).toBe(50);
expect(result.current?.tier).toBe(0);
});
});
it("returns 2014 difficulty when edition is 5e", async () => {
const wrapper = makeWrapper({
encounter: buildEncounter({
combatants: [
buildCombatant({
id: combatantId("c1"),
name: "Hero",
playerCharacterId: pcId1,
}),
buildCombatant({
id: combatantId("c2"),
name: "Goblin",
creatureId: crId1,
}),
],
}),
playerCharacters: [
{ id: pcId1, name: "Hero", ac: 15, maxHp: 30, level: 1 },
],
creatures: new Map([[crId1, goblinCreature]]),
});
// Set edition via the hook's external store
const { result: editionResult } = renderHook(() => useRulesEdition(), {
wrapper,
});
editionResult.current.setEdition("5e");
try {
const { result } = renderHook(() => useDifficulty(), { wrapper });
await waitFor(() => {
expect(result.current).not.toBeNull();
// 2014: 4 thresholds with Easy/Medium/Hard/Deadly labels
expect(result.current?.thresholds).toHaveLength(4);
expect(result.current?.thresholds[0].label).toBe("Easy");
// CR 1/4 = 50 XP, 1 PC (<3) shifts x1 → x1.5, adjusted = 75
expect(result.current?.encounterMultiplier).toBe(1.5);
expect(result.current?.adjustedXp).toBe(75);
});
} finally {
editionResult.current.setEdition("5.5e");
}
});
it("custom combatant with CR on party side subtracts XP", async () => {
const wrapper = makeWrapper({
encounter: buildEncounter({
combatants: [
buildCombatant({
id: combatantId("c1"),
name: "Hero",
playerCharacterId: pcId1,
}),
buildCombatant({
id: combatantId("c2"),
name: "Ally",
cr: "2",
side: "party",
}),
buildCombatant({
id: combatantId("c3"),
name: "Goblin",
creatureId: crId1,
}),
],
}),
playerCharacters: [
{ id: pcId1, name: "Hero", ac: 15, maxHp: 30, level: 5 },
],
creatures: new Map([[crId1, goblinCreature]]),
});
const { result } = renderHook(() => useDifficulty(), { wrapper });
await waitFor(() => {
expect(result.current).not.toBeNull();
// CR 1/4 = 50 XP enemy, CR 2 = 450 XP ally subtracted, net = 0 (floored)
expect(result.current?.totalMonsterXp).toBe(0);
});
});
});

View File

@@ -1,11 +1,12 @@
// @vitest-environment jsdom
import type { BestiaryIndexEntry, PlayerCharacter } from "@initiative/domain";
import type { PlayerCharacter } from "@initiative/domain";
import { combatantId, creatureId, playerCharacterId } from "@initiative/domain";
import { act, renderHook } from "@testing-library/react";
import type { ReactNode } from "react";
import { beforeAll, describe, expect, it, vi } from "vitest";
import { createTestAdapters } from "../../__tests__/adapters/in-memory-adapters.js";
import { AllProviders } from "../../__tests__/test-providers.js";
import type { SearchResult } from "../use-bestiary.js";
import { useEncounter } from "../use-encounter.js";
beforeAll(() => {
@@ -152,9 +153,11 @@ describe("useEncounter", () => {
expect(result.current.canRollAllInitiative).toBe(false);
// Add from bestiary to get a creature combatant
const entry: BestiaryIndexEntry = {
const entry: SearchResult = {
system: "dnd",
name: "Goblin",
source: "MM",
sourceDisplayName: "Monster Manual",
ac: 15,
hp: 7,
dex: 14,
@@ -175,9 +178,11 @@ describe("useEncounter", () => {
it("addFromBestiary adds combatant with HP, AC, creatureId", () => {
const { result } = renderHook(() => useEncounter(), { wrapper });
const entry: BestiaryIndexEntry = {
const entry: SearchResult = {
system: "dnd",
name: "Goblin",
source: "MM",
sourceDisplayName: "Monster Manual",
ac: 15,
hp: 7,
dex: 14,
@@ -202,9 +207,11 @@ describe("useEncounter", () => {
it("addFromBestiary auto-numbers duplicate names", () => {
const { result } = renderHook(() => useEncounter(), { wrapper });
const entry: BestiaryIndexEntry = {
const entry: SearchResult = {
system: "dnd",
name: "Goblin",
source: "MM",
sourceDisplayName: "Monster Manual",
ac: 15,
hp: 7,
dex: 14,

View File

@@ -1,9 +1,10 @@
// @vitest-environment jsdom
import { act, renderHook } from "@testing-library/react";
import { afterEach, describe, expect, it } from "vitest";
import { afterEach, describe, expect, it, vi } from "vitest";
import { useRulesEdition } from "../use-rules-edition.js";
const STORAGE_KEY = "initiative:rules-edition";
const STORAGE_KEY = "initiative:game-system";
const OLD_STORAGE_KEY = "initiative:rules-edition";
describe("useRulesEdition", () => {
afterEach(() => {
@@ -11,6 +12,7 @@ describe("useRulesEdition", () => {
const { result } = renderHook(() => useRulesEdition());
act(() => result.current.setEdition("5.5e"));
localStorage.removeItem(STORAGE_KEY);
localStorage.removeItem(OLD_STORAGE_KEY);
});
it("defaults to 5.5e", () => {
@@ -42,4 +44,31 @@ describe("useRulesEdition", () => {
expect(r2.current.edition).toBe("5e");
});
it("accepts pf2e as a valid game system", () => {
const { result } = renderHook(() => useRulesEdition());
act(() => result.current.setEdition("pf2e"));
expect(result.current.edition).toBe("pf2e");
expect(localStorage.getItem(STORAGE_KEY)).toBe("pf2e");
});
it("migrates from old storage key on fresh module load", async () => {
// Set up old key before re-importing the module
localStorage.setItem(OLD_STORAGE_KEY, "5e");
localStorage.removeItem(STORAGE_KEY);
// Force a fresh module so loadEdition() re-runs at init time
vi.resetModules();
const { useRulesEdition: freshHook } = await import(
"../use-rules-edition.js"
);
const { result } = renderHook(() => freshHook());
expect(result.current.edition).toBe("5e");
expect(localStorage.getItem(STORAGE_KEY)).toBe("5e");
expect(localStorage.getItem(OLD_STORAGE_KEY)).toBeNull();
});
});

View File

@@ -1,22 +1,31 @@
import type {
AnyCreature,
BestiaryIndexEntry,
Creature,
CreatureId,
Pf2eBestiaryIndexEntry,
} from "@initiative/domain";
import { useCallback, useEffect, useState } from "react";
import {
normalizeBestiary,
setSourceDisplayNames,
} from "../adapters/bestiary-adapter.js";
import { normalizeFoundryCreatures } from "../adapters/pf2e-bestiary-adapter.js";
import { useAdapters } from "../contexts/adapter-context.js";
import { useRulesEditionContext } from "../contexts/rules-edition-context.js";
export interface SearchResult extends BestiaryIndexEntry {
readonly sourceDisplayName: string;
}
export type SearchResult =
| (BestiaryIndexEntry & {
readonly system: "dnd";
readonly sourceDisplayName: string;
})
| (Pf2eBestiaryIndexEntry & {
readonly system: "pf2e";
readonly sourceDisplayName: string;
});
interface BestiaryHook {
search: (query: string) => SearchResult[];
getCreature: (id: CreatureId) => Creature | undefined;
getCreature: (id: CreatureId) => AnyCreature | undefined;
isLoaded: boolean;
isSourceCached: (sourceCode: string) => Promise<boolean>;
fetchAndCacheSource: (sourceCode: string, url: string) => Promise<void>;
@@ -28,28 +37,46 @@ interface BestiaryHook {
}
export function useBestiary(): BestiaryHook {
const { bestiaryCache, bestiaryIndex } = useAdapters();
const { bestiaryCache, bestiaryIndex, pf2eBestiaryIndex } = useAdapters();
const { edition } = useRulesEditionContext();
const [isLoaded, setIsLoaded] = useState(false);
const [creatureMap, setCreatureMap] = useState(
() => new Map<CreatureId, Creature>(),
() => new Map<CreatureId, AnyCreature>(),
);
useEffect(() => {
const index = bestiaryIndex.loadIndex();
setSourceDisplayNames(index.sources as Record<string, string>);
if (index.creatures.length > 0) {
const pf2eIndex = pf2eBestiaryIndex.loadIndex();
if (index.creatures.length > 0 || pf2eIndex.creatures.length > 0) {
setIsLoaded(true);
}
void bestiaryCache.loadAllCachedCreatures().then((map) => {
setCreatureMap(map);
});
}, [bestiaryCache, bestiaryIndex]);
}, [bestiaryCache, bestiaryIndex, pf2eBestiaryIndex]);
const search = useCallback(
(query: string): SearchResult[] => {
if (query.length < 2) return [];
const lower = query.toLowerCase();
if (edition === "pf2e") {
const index = pf2eBestiaryIndex.loadIndex();
return index.creatures
.filter((c) => c.name.toLowerCase().includes(lower))
.sort((a, b) => a.name.localeCompare(b.name))
.slice(0, 10)
.map((c) => ({
...c,
system: "pf2e" as const,
sourceDisplayName: pf2eBestiaryIndex.getSourceDisplayName(c.source),
}));
}
const index = bestiaryIndex.loadIndex();
return index.creatures
.filter((c) => c.name.toLowerCase().includes(lower))
@@ -57,38 +84,75 @@ export function useBestiary(): BestiaryHook {
.slice(0, 10)
.map((c) => ({
...c,
system: "dnd" as const,
sourceDisplayName: bestiaryIndex.getSourceDisplayName(c.source),
}));
},
[bestiaryIndex],
[bestiaryIndex, pf2eBestiaryIndex, edition],
);
const getCreature = useCallback(
(id: CreatureId): Creature | undefined => {
(id: CreatureId): AnyCreature | undefined => {
return creatureMap.get(id);
},
[creatureMap],
);
const system = edition === "pf2e" ? "pf2e" : "dnd";
const isSourceCachedFn = useCallback(
(sourceCode: string): Promise<boolean> => {
return bestiaryCache.isSourceCached(sourceCode);
return bestiaryCache.isSourceCached(system, sourceCode);
},
[bestiaryCache],
[bestiaryCache, system],
);
const fetchAndCacheSource = useCallback(
async (sourceCode: string, url: string): Promise<void> => {
const response = await fetch(url);
if (!response.ok) {
throw new Error(
`Failed to fetch: ${response.status} ${response.statusText}`,
let creatures: AnyCreature[];
if (edition === "pf2e") {
// PF2e: url is a base URL; fetch each creature file in parallel
const paths = pf2eBestiaryIndex.getCreaturePathsForSource(sourceCode);
const baseUrl = url.endsWith("/") ? url : `${url}/`;
const responses = await Promise.all(
paths.map(async (path) => {
const response = await fetch(`${baseUrl}${path}`);
if (!response.ok) {
throw new Error(
`Failed to fetch ${path}: ${response.status} ${response.statusText}`,
);
}
return response.json();
}),
);
const displayName = pf2eBestiaryIndex.getSourceDisplayName(sourceCode);
creatures = normalizeFoundryCreatures(
responses,
sourceCode,
displayName,
);
} else {
const response = await fetch(url);
if (!response.ok) {
throw new Error(
`Failed to fetch: ${response.status} ${response.statusText}`,
);
}
const json = await response.json();
creatures = normalizeBestiary(json);
}
const json = await response.json();
const creatures = normalizeBestiary(json);
const displayName = bestiaryIndex.getSourceDisplayName(sourceCode);
await bestiaryCache.cacheSource(sourceCode, displayName, creatures);
const displayName =
edition === "pf2e"
? pf2eBestiaryIndex.getSourceDisplayName(sourceCode)
: bestiaryIndex.getSourceDisplayName(sourceCode);
await bestiaryCache.cacheSource(
system,
sourceCode,
displayName,
creatures,
);
setCreatureMap((prev) => {
const next = new Map(prev);
for (const c of creatures) {
@@ -97,15 +161,31 @@ export function useBestiary(): BestiaryHook {
return next;
});
},
[bestiaryCache, bestiaryIndex],
[bestiaryCache, bestiaryIndex, pf2eBestiaryIndex, edition, system],
);
const uploadAndCacheSource = useCallback(
async (sourceCode: string, jsonData: unknown): Promise<void> => {
// biome-ignore lint/suspicious/noExplicitAny: raw JSON shape varies
const creatures = normalizeBestiary(jsonData as any);
const displayName = bestiaryIndex.getSourceDisplayName(sourceCode);
await bestiaryCache.cacheSource(sourceCode, displayName, creatures);
const creatures =
edition === "pf2e"
? normalizeFoundryCreatures(
Array.isArray(jsonData) ? jsonData : [jsonData],
sourceCode,
pf2eBestiaryIndex.getSourceDisplayName(sourceCode),
)
: normalizeBestiary(
jsonData as Parameters<typeof normalizeBestiary>[0],
);
const displayName =
edition === "pf2e"
? pf2eBestiaryIndex.getSourceDisplayName(sourceCode)
: bestiaryIndex.getSourceDisplayName(sourceCode);
await bestiaryCache.cacheSource(
system,
sourceCode,
displayName,
creatures,
);
setCreatureMap((prev) => {
const next = new Map(prev);
for (const c of creatures) {
@@ -114,7 +194,7 @@ export function useBestiary(): BestiaryHook {
return next;
});
},
[bestiaryCache, bestiaryIndex],
[bestiaryCache, bestiaryIndex, pf2eBestiaryIndex, edition, system],
);
const refreshCache = useCallback(async (): Promise<void> => {

View File

@@ -1,5 +1,6 @@
import { useCallback, useRef, useState } from "react";
import { useAdapters } from "../contexts/adapter-context.js";
import { useRulesEditionContext } from "../contexts/rules-edition-context.js";
const BATCH_SIZE = 6;
@@ -29,7 +30,9 @@ interface BulkImportHook {
}
export function useBulkImport(): BulkImportHook {
const { bestiaryIndex } = useAdapters();
const { bestiaryIndex, pf2eBestiaryIndex } = useAdapters();
const { edition } = useRulesEditionContext();
const indexPort = edition === "pf2e" ? pf2eBestiaryIndex : bestiaryIndex;
const [state, setState] = useState<BulkImportState>(IDLE_STATE);
const countersRef = useRef({ completed: 0, failed: 0 });
@@ -40,7 +43,7 @@ export function useBulkImport(): BulkImportHook {
isSourceCached: (sourceCode: string) => Promise<boolean>,
refreshCache: () => Promise<void>,
) => {
const allCodes = bestiaryIndex.getAllSourceCodes();
const allCodes = indexPort.getAllSourceCodes();
const total = allCodes.length;
countersRef.current = { completed: 0, failed: 0 };
@@ -81,7 +84,7 @@ export function useBulkImport(): BulkImportHook {
chain.then(() =>
Promise.allSettled(
batch.map(async ({ code }) => {
const url = bestiaryIndex.getDefaultFetchUrl(code, baseUrl);
const url = indexPort.getDefaultFetchUrl(code, baseUrl);
try {
await fetchAndCacheSource(code, url);
countersRef.current.completed++;
@@ -115,7 +118,7 @@ export function useBulkImport(): BulkImportHook {
});
})();
},
[bestiaryIndex],
[indexPort],
);
const reset = useCallback(() => {

View File

@@ -1,6 +1,7 @@
import type {
Combatant,
CreatureId,
DifficultyThreshold,
DifficultyTier,
PlayerCharacter,
} from "@initiative/domain";
@@ -9,6 +10,8 @@ import { useMemo } from "react";
import { useBestiaryContext } from "../contexts/bestiary-context.js";
import { useEncounterContext } from "../contexts/encounter-context.js";
import { usePlayerCharactersContext } from "../contexts/player-characters-context.js";
import { useRulesEditionContext } from "../contexts/rules-edition-context.js";
import { resolveSide } from "./use-difficulty.js";
export interface BreakdownCombatant {
readonly combatant: Combatant;
@@ -16,125 +19,153 @@ export interface BreakdownCombatant {
readonly xp: number | null;
readonly source: string | null;
readonly editable: boolean;
readonly side: "party" | "enemy";
readonly level: number | undefined;
}
interface DifficultyBreakdown {
readonly tier: DifficultyTier;
readonly totalMonsterXp: number;
readonly partyBudget: {
readonly low: number;
readonly moderate: number;
readonly high: number;
};
readonly thresholds: readonly DifficultyThreshold[];
readonly encounterMultiplier: number | undefined;
readonly adjustedXp: number | undefined;
readonly partySizeAdjusted: boolean | undefined;
readonly pcCount: number;
readonly combatants: readonly BreakdownCombatant[];
readonly partyCombatants: readonly BreakdownCombatant[];
readonly enemyCombatants: readonly BreakdownCombatant[];
}
export function useDifficultyBreakdown(): DifficultyBreakdown | null {
const { encounter } = useEncounterContext();
const { characters } = usePlayerCharactersContext();
const { getCreature } = useBestiaryContext();
const { edition } = useRulesEditionContext();
return useMemo(() => {
const partyLevels = derivePartyLevels(encounter.combatants, characters);
const { entries, crs } = classifyCombatants(
encounter.combatants,
getCreature,
const { partyCombatants, enemyCombatants, descriptors, pcCount } =
classifyCombatants(encounter.combatants, characters, getCreature);
const hasPartyLevel = descriptors.some(
(d) => d.side === "party" && d.level !== undefined,
);
const hasCr = descriptors.some((d) => d.cr !== undefined);
if (partyLevels.length === 0 || crs.length === 0) {
return null;
}
if (!hasPartyLevel || !hasCr) return null;
const result = calculateEncounterDifficulty(partyLevels, crs);
const result = calculateEncounterDifficulty(descriptors, edition);
return {
...result,
pcCount: partyLevels.length,
combatants: entries,
pcCount,
partyCombatants,
enemyCombatants,
};
}, [encounter.combatants, characters, getCreature]);
}, [encounter.combatants, characters, getCreature, edition]);
}
function classifyBestiaryCombatant(
type CreatureInfo = {
cr?: string;
source: string;
sourceDisplayName: string;
};
function buildBreakdownEntry(
c: Combatant,
getCreature: (
id: CreatureId,
) => { cr: string; source: string; sourceDisplayName: string } | undefined,
): { entry: BreakdownCombatant; cr: string | null } {
const creature = c.creatureId ? getCreature(c.creatureId) : undefined;
if (creature) {
side: "party" | "enemy",
level: number | undefined,
creature: CreatureInfo | undefined,
): BreakdownCombatant {
if (c.playerCharacterId) {
return {
entry: {
combatant: c,
cr: creature.cr,
xp: crToXp(creature.cr),
source: creature.sourceDisplayName ?? creature.source,
editable: false,
},
cr: creature.cr,
};
}
return {
entry: {
combatant: c,
cr: null,
xp: null,
source: null,
editable: false,
},
side,
level,
};
}
if (creature) {
const cr = creature.cr ?? null;
return {
combatant: c,
cr,
xp: cr ? crToXp(cr) : null,
source: creature.sourceDisplayName ?? creature.source,
editable: false,
side,
level: undefined,
};
}
if (c.cr) {
return {
combatant: c,
cr: c.cr,
xp: crToXp(c.cr),
source: null,
editable: true,
side,
level: undefined,
};
}
return {
combatant: c,
cr: null,
xp: null,
source: null,
editable: !c.creatureId,
side,
level: undefined,
};
}
function resolveLevel(
c: Combatant,
characters: readonly PlayerCharacter[],
): number | undefined {
if (!c.playerCharacterId) return undefined;
return characters.find((p) => p.id === c.playerCharacterId)?.level;
}
function resolveCr(
c: Combatant,
getCreature: (id: CreatureId) => CreatureInfo | undefined,
): { cr: string | null; creature: CreatureInfo | undefined } {
const creature = c.creatureId ? getCreature(c.creatureId) : undefined;
const cr = creature?.cr ?? c.cr ?? null;
return { cr, creature };
}
function classifyCombatants(
combatants: readonly Combatant[],
getCreature: (
id: CreatureId,
) => { cr: string; source: string; sourceDisplayName: string } | undefined,
): { entries: BreakdownCombatant[]; crs: string[] } {
const entries: BreakdownCombatant[] = [];
const crs: string[] = [];
for (const c of combatants) {
if (c.playerCharacterId) continue;
if (c.creatureId) {
const { entry, cr } = classifyBestiaryCombatant(c, getCreature);
entries.push(entry);
if (cr) crs.push(cr);
} else if (c.cr) {
crs.push(c.cr);
entries.push({
combatant: c,
cr: c.cr,
xp: crToXp(c.cr),
source: null,
editable: true,
});
} else {
entries.push({
combatant: c,
cr: null,
xp: null,
source: null,
editable: true,
});
}
}
return { entries, crs };
}
function derivePartyLevels(
combatants: readonly Combatant[],
characters: readonly PlayerCharacter[],
): number[] {
const levels: number[] = [];
getCreature: (id: CreatureId) => CreatureInfo | undefined,
) {
const partyCombatants: BreakdownCombatant[] = [];
const enemyCombatants: BreakdownCombatant[] = [];
const descriptors: {
level?: number;
cr?: string;
side: "party" | "enemy";
}[] = [];
let pcCount = 0;
for (const c of combatants) {
if (!c.playerCharacterId) continue;
const pc = characters.find((p) => p.id === c.playerCharacterId);
if (pc?.level !== undefined) levels.push(pc.level);
const side = resolveSide(c);
const level = resolveLevel(c, characters);
if (level !== undefined) pcCount++;
const { cr, creature } = resolveCr(c, getCreature);
if (level !== undefined || cr != null) {
descriptors.push({ level, cr: cr ?? undefined, side });
}
const entry = buildBreakdownEntry(c, side, level, creature);
const target = side === "party" ? partyCombatants : enemyCombatants;
target.push(entry);
}
return levels;
return { partyCombatants, enemyCombatants, descriptors, pcCount };
}

View File

@@ -1,5 +1,7 @@
import type {
AnyCreature,
Combatant,
CombatantDescriptor,
CreatureId,
DifficultyResult,
PlayerCharacter,
@@ -9,49 +11,58 @@ import { useMemo } from "react";
import { useBestiaryContext } from "../contexts/bestiary-context.js";
import { useEncounterContext } from "../contexts/encounter-context.js";
import { usePlayerCharactersContext } from "../contexts/player-characters-context.js";
import { useRulesEditionContext } from "../contexts/rules-edition-context.js";
function derivePartyLevels(
combatants: readonly Combatant[],
characters: readonly PlayerCharacter[],
): number[] {
const levels: number[] = [];
for (const c of combatants) {
if (!c.playerCharacterId) continue;
const pc = characters.find((p) => p.id === c.playerCharacterId);
if (pc?.level !== undefined) levels.push(pc.level);
}
return levels;
export function resolveSide(c: Combatant): "party" | "enemy" {
if (c.side) return c.side;
return c.playerCharacterId ? "party" : "enemy";
}
function deriveMonsterCrs(
function buildDescriptors(
combatants: readonly Combatant[],
getCreature: (id: CreatureId) => { cr: string } | undefined,
): string[] {
const crs: string[] = [];
characters: readonly PlayerCharacter[],
getCreature: (id: CreatureId) => AnyCreature | undefined,
): CombatantDescriptor[] {
const descriptors: CombatantDescriptor[] = [];
for (const c of combatants) {
if (c.creatureId) {
const creature = getCreature(c.creatureId);
if (creature) crs.push(creature.cr);
} else if (c.cr) {
crs.push(c.cr);
const side = resolveSide(c);
const level = c.playerCharacterId
? characters.find((p) => p.id === c.playerCharacterId)?.level
: undefined;
const creature = c.creatureId ? getCreature(c.creatureId) : undefined;
const creatureCr =
creature && !("system" in creature) ? creature.cr : undefined;
const cr = creatureCr ?? c.cr ?? undefined;
if (level !== undefined || cr !== undefined) {
descriptors.push({ level, cr, side });
}
}
return crs;
return descriptors;
}
export function useDifficulty(): DifficultyResult | null {
const { encounter } = useEncounterContext();
const { characters } = usePlayerCharactersContext();
const { getCreature } = useBestiaryContext();
const { edition } = useRulesEditionContext();
return useMemo(() => {
const partyLevels = derivePartyLevels(encounter.combatants, characters);
const monsterCrs = deriveMonsterCrs(encounter.combatants, getCreature);
if (edition === "pf2e") return null;
if (partyLevels.length === 0 || monsterCrs.length === 0) {
return null;
}
const descriptors = buildDescriptors(
encounter.combatants,
characters,
getCreature,
);
return calculateEncounterDifficulty(partyLevels, monsterCrs);
}, [encounter.combatants, characters, getCreature]);
const hasPartyLevel = descriptors.some(
(d) => d.side === "party" && d.level !== undefined,
);
const hasCr = descriptors.some((d) => d.cr !== undefined);
if (!hasPartyLevel || !hasCr) return null;
return calculateEncounterDifficulty(descriptors, edition);
}, [encounter.combatants, characters, getCreature, edition]);
}

View File

@@ -4,21 +4,23 @@ import {
adjustHpUseCase,
advanceTurnUseCase,
clearEncounterUseCase,
decrementConditionUseCase,
editCombatantUseCase,
redoUseCase,
removeCombatantUseCase,
retreatTurnUseCase,
setAcUseCase,
setConditionValueUseCase,
setCrUseCase,
setHpUseCase,
setInitiativeUseCase,
setSideUseCase,
setTempHpUseCase,
toggleConcentrationUseCase,
toggleConditionUseCase,
undoUseCase,
} from "@initiative/application";
import type {
BestiaryIndexEntry,
CombatantId,
CombatantInit,
ConditionId,
@@ -39,6 +41,7 @@ import {
} from "@initiative/domain";
import { useCallback, useEffect, useReducer, useRef } from "react";
import { useAdapters } from "../contexts/adapter-context.js";
import type { SearchResult } from "./use-bestiary.js";
// -- Types --
@@ -54,19 +57,31 @@ type EncounterAction =
| { type: "set-temp-hp"; id: CombatantId; tempHp: number | undefined }
| { type: "set-ac"; id: CombatantId; value: number | undefined }
| { type: "set-cr"; id: CombatantId; value: string | undefined }
| { type: "set-side"; id: CombatantId; value: "party" | "enemy" }
| {
type: "toggle-condition";
id: CombatantId;
conditionId: ConditionId;
}
| {
type: "set-condition-value";
id: CombatantId;
conditionId: ConditionId;
value: number;
}
| {
type: "decrement-condition";
id: CombatantId;
conditionId: ConditionId;
}
| { type: "toggle-concentration"; id: CombatantId }
| { type: "clear-encounter" }
| { type: "undo" }
| { type: "redo" }
| { type: "add-from-bestiary"; entry: BestiaryIndexEntry }
| { type: "add-from-bestiary"; entry: SearchResult }
| {
type: "add-multiple-from-bestiary";
entry: BestiaryIndexEntry;
entry: SearchResult;
count: number;
}
| { type: "add-from-player-character"; pc: PlayerCharacter }
@@ -154,7 +169,7 @@ function resolveAndRename(store: EncounterStore, name: string): string {
function addOneFromBestiary(
store: EncounterStore,
entry: BestiaryIndexEntry,
entry: SearchResult,
nextId: number,
): {
cId: CreatureId;
@@ -213,7 +228,7 @@ function handleUndoRedo(
function handleAddFromBestiary(
state: EncounterState,
entry: BestiaryIndexEntry,
entry: SearchResult,
count: number,
): EncounterState {
const { store, getEncounter } = makeStoreFromState(state);
@@ -321,7 +336,10 @@ function dispatchEncounterAction(
| { type: "set-temp-hp" }
| { type: "set-ac" }
| { type: "set-cr" }
| { type: "set-side" }
| { type: "toggle-condition" }
| { type: "set-condition-value" }
| { type: "decrement-condition" }
| { type: "toggle-concentration" }
>,
): EncounterState {
@@ -364,9 +382,23 @@ function dispatchEncounterAction(
case "set-cr":
result = setCrUseCase(store, action.id, action.value);
break;
case "set-side":
result = setSideUseCase(store, action.id, action.value);
break;
case "toggle-condition":
result = toggleConditionUseCase(store, action.id, action.conditionId);
break;
case "set-condition-value":
result = setConditionValueUseCase(
store,
action.id,
action.conditionId,
action.value,
);
break;
case "decrement-condition":
result = decrementConditionUseCase(store, action.id, action.conditionId);
break;
case "toggle-concentration":
result = toggleConcentrationUseCase(store, action.id);
break;
@@ -389,7 +421,10 @@ function dispatchEncounterAction(
export function useEncounter() {
const { encounterPersistence, undoRedoPersistence } = useAdapters();
const [state, dispatch] = useReducer(encounterReducer, null, () =>
initializeState(encounterPersistence.load, undoRedoPersistence.load),
initializeState(
() => encounterPersistence.load(),
() => undoRedoPersistence.load(),
),
);
const { encounter, undoRedoState, events } = state;
@@ -506,11 +541,26 @@ export function useEncounter() {
dispatch({ type: "set-cr", id, value }),
[],
),
setSide: useCallback(
(id: CombatantId, value: "party" | "enemy") =>
dispatch({ type: "set-side", id, value }),
[],
),
toggleCondition: useCallback(
(id: CombatantId, conditionId: ConditionId) =>
dispatch({ type: "toggle-condition", id, conditionId }),
[],
),
setConditionValue: useCallback(
(id: CombatantId, conditionId: ConditionId, value: number) =>
dispatch({ type: "set-condition-value", id, conditionId, value }),
[],
),
decrementCondition: useCallback(
(id: CombatantId, conditionId: ConditionId) =>
dispatch({ type: "decrement-condition", id, conditionId }),
[],
),
toggleConcentration: useCallback(
(id: CombatantId) => dispatch({ type: "toggle-concentration", id }),
[],
@@ -519,15 +569,12 @@ export function useEncounter() {
() => dispatch({ type: "clear-encounter" }),
[],
),
addFromBestiary: useCallback(
(entry: BestiaryIndexEntry): CreatureId | null => {
dispatch({ type: "add-from-bestiary", entry });
return null;
},
[],
),
addFromBestiary: useCallback((entry: SearchResult): CreatureId | null => {
dispatch({ type: "add-from-bestiary", entry });
return null;
}, []),
addMultipleFromBestiary: useCallback(
(entry: BestiaryIndexEntry, count: number): CreatureId | null => {
(entry: SearchResult, count: number): CreatureId | null => {
dispatch({
type: "add-multiple-from-bestiary",
entry,

View File

@@ -1,7 +1,8 @@
import type { RulesEdition } from "@initiative/domain";
import { useCallback, useSyncExternalStore } from "react";
const STORAGE_KEY = "initiative:rules-edition";
const STORAGE_KEY = "initiative:game-system";
const OLD_STORAGE_KEY = "initiative:rules-edition";
const listeners = new Set<() => void>();
let currentEdition: RulesEdition = loadEdition();
@@ -9,7 +10,14 @@ let currentEdition: RulesEdition = loadEdition();
function loadEdition(): RulesEdition {
try {
const raw = localStorage.getItem(STORAGE_KEY);
if (raw === "5e" || raw === "5.5e") return raw;
if (raw === "5e" || raw === "5.5e" || raw === "pf2e") return raw;
// Migrate from old key
const old = localStorage.getItem(OLD_STORAGE_KEY);
if (old === "5e" || old === "5.5e") {
localStorage.setItem(STORAGE_KEY, old);
localStorage.removeItem(OLD_STORAGE_KEY);
return old;
}
} catch {
// storage unavailable
}

View File

@@ -70,3 +70,72 @@ export function useSwipeToDismiss(onDismiss: () => void) {
handlers: { onTouchStart, onTouchMove, onTouchEnd },
};
}
/**
* Vertical (down-only) variant for dismissing bottom sheets via swipe-down.
* Mirrors `useSwipeToDismiss` but locks to vertical direction and tracks
* the sheet height instead of width.
*/
export function useSwipeToDismissDown(onDismiss: () => void) {
const [swipe, setSwipe] = useState<SwipeState>({
offsetX: 0,
isSwiping: false,
});
const startX = useRef(0);
const startY = useRef(0);
const startTime = useRef(0);
const sheetHeight = useRef(0);
const directionLocked = useRef<"horizontal" | "vertical" | null>(null);
const onTouchStart = useCallback((e: React.TouchEvent) => {
const touch = e.touches[0];
startX.current = touch.clientX;
startY.current = touch.clientY;
startTime.current = Date.now();
directionLocked.current = null;
const el = e.currentTarget as HTMLElement;
sheetHeight.current = el.getBoundingClientRect().height;
}, []);
const onTouchMove = useCallback((e: React.TouchEvent) => {
const touch = e.touches[0];
const dx = touch.clientX - startX.current;
const dy = touch.clientY - startY.current;
if (!directionLocked.current) {
if (Math.abs(dx) < 10 && Math.abs(dy) < 10) return;
directionLocked.current =
Math.abs(dy) > Math.abs(dx) ? "vertical" : "horizontal";
}
if (directionLocked.current === "horizontal") return;
const clampedY = Math.max(0, dy);
// `offsetX` is reused as the vertical offset to keep SwipeState shared.
setSwipe({ offsetX: clampedY, isSwiping: true });
}, []);
const onTouchEnd = useCallback(() => {
if (directionLocked.current !== "vertical") {
setSwipe({ offsetX: 0, isSwiping: false });
return;
}
const elapsed = (Date.now() - startTime.current) / 1000;
const velocity = swipe.offsetX / elapsed / sheetHeight.current;
const ratio =
sheetHeight.current > 0 ? swipe.offsetX / sheetHeight.current : 0;
if (ratio > DISMISS_THRESHOLD || velocity > VELOCITY_THRESHOLD) {
onDismiss();
}
setSwipe({ offsetX: 0, isSwiping: false });
}, [swipe.offsetX, onDismiss]);
return {
offsetY: swipe.offsetX,
isSwiping: swipe.isSwiping,
handlers: { onTouchStart, onTouchMove, onTouchEnd },
};
}

View File

@@ -103,6 +103,19 @@
animation: slide-in-right 200ms ease-out;
}
@keyframes slide-in-bottom {
from {
transform: translateY(100%);
}
to {
transform: translateY(0);
}
}
@utility animate-slide-in-bottom {
animation: slide-in-bottom 200ms ease-out;
}
@keyframes confirm-pulse {
0% {
scale: 1;

View File

@@ -154,6 +154,47 @@ describe("loadEncounter", () => {
expect(loaded?.combatants[0].cr).toBe("2");
});
it("round-trip preserves combatant side field", () => {
const result = createEncounter(
[
{
id: combatantId("c-1"),
name: "Allied Guard",
cr: "2",
side: "party",
},
{
id: combatantId("c-2"),
name: "Goblin",
side: "enemy",
},
],
0,
1,
);
if (isDomainError(result)) throw new Error("unreachable");
saveEncounter(result);
const loaded = loadEncounter();
expect(loaded).not.toBeNull();
expect(loaded?.combatants[0].side).toBe("party");
expect(loaded?.combatants[1].side).toBe("enemy");
});
it("round-trip preserves combatant without side field as undefined", () => {
const result = createEncounter(
[{ id: combatantId("c-1"), name: "Custom" }],
0,
1,
);
if (isDomainError(result)) throw new Error("unreachable");
saveEncounter(result);
const loaded = loadEncounter();
expect(loaded).not.toBeNull();
expect(loaded?.combatants[0].side).toBeUndefined();
});
it("saving after modifications persists the latest state", () => {
const encounter = makeEncounter();
saveEncounter(encounter);

View File

@@ -10,7 +10,8 @@
"!coverage",
"!.pnpm-store",
"!.rodney",
"!.agent-tests"
"!.agent-tests",
"!data"
]
},
"assist": {

File diff suppressed because one or more lines are too long

View File

@@ -31,7 +31,7 @@
"knip": "knip",
"jscpd": "jscpd",
"jsinspect": "jsinspect -c .jsinspectrc apps/web/src packages/domain/src packages/application/src",
"oxlint": "oxlint --tsconfig apps/web/tsconfig.json --type-aware --deny warnings",
"oxlint": "oxlint --tsconfig apps/web/tsconfig.json --type-aware --deny-warnings",
"check:ignores": "node scripts/check-lint-ignores.mjs",
"check:classnames": "node scripts/check-cn-classnames.mjs",
"check:props": "node scripts/check-component-props.mjs",

View File

@@ -292,9 +292,9 @@ describe("toggleConditionUseCase", () => {
);
expect(isDomainError(result)).toBe(false);
expect(requireSaved(store.saved).combatants[0].conditions).toContain(
"blinded",
);
expect(requireSaved(store.saved).combatants[0].conditions).toContainEqual({
id: "blinded",
});
});
it("returns domain error for unknown combatant", () => {

View File

@@ -0,0 +1,21 @@
import {
type AnyCreature,
calculateInitiative,
calculatePf2eInitiative,
} from "@initiative/domain";
export function creatureInitiativeModifier(creature: AnyCreature): number {
if ("system" in creature && creature.system === "pf2e") {
return calculatePf2eInitiative(creature.perception).modifier;
}
const c = creature as {
abilities: { dex: number };
cr: string;
initiativeProficiency: number;
};
return calculateInitiative({
dexScore: c.abilities.dex,
cr: c.cr,
initiativeProficiency: c.initiativeProficiency,
}).modifier;
}

View File

@@ -0,0 +1,19 @@
import {
type CombatantId,
type ConditionId,
type DomainError,
type DomainEvent,
decrementCondition,
} from "@initiative/domain";
import type { EncounterStore } from "./ports.js";
import { runEncounterAction } from "./run-encounter-action.js";
export function decrementConditionUseCase(
store: EncounterStore,
combatantId: CombatantId,
conditionId: ConditionId,
): DomainEvent[] | DomainError {
return runEncounterAction(store, (encounter) =>
decrementCondition(encounter, combatantId, conditionId),
);
}

View File

@@ -3,6 +3,7 @@ export { adjustHpUseCase } from "./adjust-hp-use-case.js";
export { advanceTurnUseCase } from "./advance-turn-use-case.js";
export { clearEncounterUseCase } from "./clear-encounter-use-case.js";
export { createPlayerCharacterUseCase } from "./create-player-character-use-case.js";
export { decrementConditionUseCase } from "./decrement-condition-use-case.js";
export { deletePlayerCharacterUseCase } from "./delete-player-character-use-case.js";
export { editCombatantUseCase } from "./edit-combatant-use-case.js";
export { editPlayerCharacterUseCase } from "./edit-player-character-use-case.js";
@@ -21,9 +22,11 @@ export {
} from "./roll-all-initiative-use-case.js";
export { rollInitiativeUseCase } from "./roll-initiative-use-case.js";
export { setAcUseCase } from "./set-ac-use-case.js";
export { setConditionValueUseCase } from "./set-condition-value-use-case.js";
export { setCrUseCase } from "./set-cr-use-case.js";
export { setHpUseCase } from "./set-hp-use-case.js";
export { setInitiativeUseCase } from "./set-initiative-use-case.js";
export { setSideUseCase } from "./set-side-use-case.js";
export { setTempHpUseCase } from "./set-temp-hp-use-case.js";
export { toggleConcentrationUseCase } from "./toggle-concentration-use-case.js";
export { toggleConditionUseCase } from "./toggle-condition-use-case.js";

View File

@@ -1,5 +1,5 @@
import type {
Creature,
AnyCreature,
CreatureId,
Encounter,
PlayerCharacter,
@@ -12,7 +12,7 @@ export interface EncounterStore {
}
export interface BestiarySourceCache {
getCreature(creatureId: CreatureId): Creature | undefined;
getCreature(creatureId: CreatureId): AnyCreature | undefined;
isSourceCached(sourceCode: string): boolean;
}

View File

@@ -1,7 +1,6 @@
import {
type Creature,
type AnyCreature,
type CreatureId,
calculateInitiative,
type DomainError,
type DomainEvent,
isDomainError,
@@ -10,6 +9,7 @@ import {
selectRoll,
setInitiative,
} from "@initiative/domain";
import { creatureInitiativeModifier } from "./creature-initiative-modifier.js";
import type { EncounterStore } from "./ports.js";
export interface RollAllResult {
@@ -20,7 +20,7 @@ export interface RollAllResult {
export function rollAllInitiativeUseCase(
store: EncounterStore,
rollDice: () => number,
getCreature: (id: CreatureId) => Creature | undefined,
getCreature: (id: CreatureId) => AnyCreature | undefined,
mode: RollMode = "normal",
): RollAllResult | DomainError {
let encounter = store.get();
@@ -37,11 +37,7 @@ export function rollAllInitiativeUseCase(
continue;
}
const { modifier } = calculateInitiative({
dexScore: creature.abilities.dex,
cr: creature.cr,
initiativeProficiency: creature.initiativeProficiency,
});
const modifier = creatureInitiativeModifier(creature);
const roll1 = rollDice();
const effectiveRoll =
mode === "normal" ? roll1 : selectRoll(roll1, rollDice(), mode);

View File

@@ -1,8 +1,7 @@
import {
type AnyCreature,
type CombatantId,
type Creature,
type CreatureId,
calculateInitiative,
type DomainError,
type DomainEvent,
isDomainError,
@@ -11,13 +10,14 @@ import {
selectRoll,
setInitiative,
} from "@initiative/domain";
import { creatureInitiativeModifier } from "./creature-initiative-modifier.js";
import type { EncounterStore } from "./ports.js";
export function rollInitiativeUseCase(
store: EncounterStore,
combatantId: CombatantId,
diceRolls: readonly [number, ...number[]],
getCreature: (id: CreatureId) => Creature | undefined,
getCreature: (id: CreatureId) => AnyCreature | undefined,
mode: RollMode = "normal",
): DomainEvent[] | DomainError {
const encounter = store.get();
@@ -48,11 +48,7 @@ export function rollInitiativeUseCase(
};
}
const { modifier } = calculateInitiative({
dexScore: creature.abilities.dex,
cr: creature.cr,
initiativeProficiency: creature.initiativeProficiency,
});
const modifier = creatureInitiativeModifier(creature);
const effectiveRoll =
mode === "normal"
? diceRolls[0]

View File

@@ -0,0 +1,20 @@
import {
type CombatantId,
type ConditionId,
type DomainError,
type DomainEvent,
setConditionValue,
} from "@initiative/domain";
import type { EncounterStore } from "./ports.js";
import { runEncounterAction } from "./run-encounter-action.js";
export function setConditionValueUseCase(
store: EncounterStore,
combatantId: CombatantId,
conditionId: ConditionId,
value: number,
): DomainEvent[] | DomainError {
return runEncounterAction(store, (encounter) =>
setConditionValue(encounter, combatantId, conditionId, value),
);
}

View File

@@ -0,0 +1,18 @@
import {
type CombatantId,
type DomainError,
type DomainEvent,
setSide,
} from "@initiative/domain";
import type { EncounterStore } from "./ports.js";
import { runEncounterAction } from "./run-encounter-action.js";
export function setSideUseCase(
store: EncounterStore,
combatantId: CombatantId,
value: "party" | "enemy",
): DomainEvent[] | DomainError {
return runEncounterAction(store, (encounter) =>
setSide(encounter, combatantId, value),
);
}

View File

@@ -54,7 +54,7 @@ describe("clearEncounter", () => {
maxHp: 50,
currentHp: 30,
ac: 18,
conditions: ["blinded", "poisoned"],
conditions: [{ id: "blinded" }, { id: "poisoned" }],
isConcentrating: true,
},
{
@@ -63,7 +63,7 @@ describe("clearEncounter", () => {
maxHp: 25,
currentHp: 0,
ac: 12,
conditions: ["unconscious"],
conditions: [{ id: "unconscious" }],
},
],
activeIndex: 0,

View File

@@ -26,25 +26,40 @@ describe("getConditionDescription", () => {
);
});
it("universal conditions have both descriptions", () => {
const universal = CONDITION_DEFINITIONS.filter(
(d) => d.edition === undefined,
it("returns pf2e description when edition is pf2e", () => {
const blinded = findCondition("blinded");
expect(getConditionDescription(blinded, "pf2e")).toBe(
blinded.descriptionPf2e,
);
expect(universal.length).toBeGreaterThan(0);
for (const def of universal) {
});
it("falls back to default description for pf2e when no pf2e text", () => {
const paralyzed = findCondition("paralyzed");
expect(getConditionDescription(paralyzed, "pf2e")).toBe(
paralyzed.descriptionPf2e,
);
});
it("shared D&D conditions have both description and description5e", () => {
const sharedDndConditions = CONDITION_DEFINITIONS.filter(
(d) =>
d.systems === undefined ||
(d.systems.includes("5e") && d.systems.includes("5.5e")),
);
for (const def of sharedDndConditions) {
expect(def.description).toBeTruthy();
expect(def.description5e).toBeTruthy();
}
});
it("edition-specific conditions have their edition description", () => {
it("system-specific conditions use the systems field", () => {
const sapped = findCondition("sapped");
expect(sapped.description).toBeTruthy();
expect(sapped.edition).toBe("5.5e");
expect(sapped.systems).toContain("5.5e");
const slowed = findCondition("slowed");
expect(slowed.description).toBeTruthy();
expect(slowed.edition).toBe("5.5e");
expect(slowed.systems).toContain("5.5e");
});
it("conditions with identical rules share the same text", () => {
@@ -79,4 +94,34 @@ describe("getConditionsForEdition", () => {
expect(ids5e).toContain("blinded");
expect(ids55e).toContain("blinded");
});
it("returns PF2e conditions for pf2e edition", () => {
const conditions = getConditionsForEdition("pf2e");
const ids = conditions.map((d) => d.id);
expect(ids).toContain("clumsy");
expect(ids).toContain("drained");
expect(ids).toContain("off-guard");
expect(ids).toContain("sickened");
expect(ids).not.toContain("charmed");
expect(ids).not.toContain("exhaustion");
expect(ids).not.toContain("grappled");
});
it("returns D&D conditions for 5.5e", () => {
const conditions = getConditionsForEdition("5.5e");
const ids = conditions.map((d) => d.id);
expect(ids).toContain("charmed");
expect(ids).toContain("exhaustion");
expect(ids).not.toContain("clumsy");
expect(ids).not.toContain("off-guard");
});
it("shared conditions appear in both D&D and PF2e", () => {
const dndIds = getConditionsForEdition("5.5e").map((d) => d.id);
const pf2eIds = getConditionsForEdition("pf2e").map((d) => d.id);
expect(dndIds).toContain("blinded");
expect(pf2eIds).toContain("blinded");
expect(dndIds).toContain("prone");
expect(pf2eIds).toContain("prone");
});
});

View File

@@ -36,98 +36,353 @@ describe("crToXp", () => {
});
});
describe("calculateEncounterDifficulty", () => {
it("returns trivial when monster XP is below Low threshold", () => {
/** Helper to build party-side descriptors with level. */
function party(level: number) {
return { level, side: "party" as const };
}
/** Helper to build enemy-side descriptors with CR. */
function enemy(cr: string) {
return { cr, side: "enemy" as const };
}
describe("calculateEncounterDifficulty — 5.5e edition", () => {
it("returns tier 0 when monster XP is below Low threshold", () => {
// 4x level 1: Low = 200, Moderate = 300, High = 400
// 1x CR 0 = 0 XP → trivial
const result = calculateEncounterDifficulty([1, 1, 1, 1], ["0"]);
expect(result.tier).toBe("trivial");
// 1x CR 0 = 0 XP -> tier 0
const result = calculateEncounterDifficulty(
[party(1), party(1), party(1), party(1), enemy("0")],
"5.5e",
);
expect(result.tier).toBe(0);
expect(result.totalMonsterXp).toBe(0);
expect(result.partyBudget).toEqual({
low: 200,
moderate: 300,
high: 400,
});
expect(result.thresholds).toEqual([
{ label: "Low", value: 200 },
{ label: "Moderate", value: 300 },
{ label: "High", value: 400 },
]);
expect(result.encounterMultiplier).toBeUndefined();
expect(result.adjustedXp).toBeUndefined();
expect(result.partySizeAdjusted).toBeUndefined();
});
it("returns low for 4x level 1 vs Bugbear (CR 1)", () => {
// DMG example: 4x level 1 PCs vs 1 Bugbear (CR 1, 200 XP)
// Low = 200, Moderate = 300 → 200 >= 200 but < 300 → Low
const result = calculateEncounterDifficulty([1, 1, 1, 1], ["1"]);
expect(result.tier).toBe("low");
it("returns tier 1 for 4x level 1 vs Bugbear (CR 1)", () => {
const result = calculateEncounterDifficulty(
[party(1), party(1), party(1), party(1), enemy("1")],
"5.5e",
);
expect(result.tier).toBe(1);
expect(result.totalMonsterXp).toBe(200);
});
it("returns moderate for 5x level 3 vs 1125 XP", () => {
it("returns tier 2 for 5x level 3 vs 1150 XP", () => {
// 5x level 3: Low = 750, Moderate = 1125, High = 2000
// 1125 XP >= 1125 Moderate but < 2000 High → Moderate
// Using CR 3 (700) + CR 2 (450) = 1150 XP ≈ 1125 threshold
// Let's use exact: 5 * 225 = 1125 moderate budget
// Need monsters that sum exactly to 1125: CR 3 (700) + CR 2 (450) = 1150
const result = calculateEncounterDifficulty([3, 3, 3, 3, 3], ["3", "2"]);
expect(result.tier).toBe("moderate");
// CR 3 (700) + CR 2 (450) = 1150 XP >= 1125 Moderate
const result = calculateEncounterDifficulty(
[
party(3),
party(3),
party(3),
party(3),
party(3),
enemy("3"),
enemy("2"),
],
"5.5e",
);
expect(result.tier).toBe(2);
expect(result.totalMonsterXp).toBe(1150);
expect(result.partyBudget.moderate).toBe(1125);
expect(result.thresholds[1].value).toBe(1125);
});
it("returns high when XP meets High threshold", () => {
it("returns tier 3 when XP meets High threshold", () => {
// 4x level 1: High = 400
// 2x CR 1 = 400 XP → High
const result = calculateEncounterDifficulty([1, 1, 1, 1], ["1", "1"]);
expect(result.tier).toBe("high");
// 2x CR 1 = 400 XP -> tier 3
const result = calculateEncounterDifficulty(
[party(1), party(1), party(1), party(1), enemy("1"), enemy("1")],
"5.5e",
);
expect(result.tier).toBe(3);
expect(result.totalMonsterXp).toBe(400);
});
it("caps at high when XP far exceeds threshold", () => {
// 4x level 1: High = 400
// CR 30 = 155000 XP → still High (no tier above)
const result = calculateEncounterDifficulty([1, 1, 1, 1], ["30"]);
expect(result.tier).toBe("high");
it("caps at tier 3 when XP far exceeds threshold", () => {
const result = calculateEncounterDifficulty(
[party(1), party(1), party(1), party(1), enemy("30")],
"5.5e",
);
expect(result.tier).toBe(3);
expect(result.totalMonsterXp).toBe(155000);
});
it("handles mixed party levels", () => {
// 3x level 3 + 1x level 2
// level 3: low=150, mod=225, high=400 (x3 = 450, 675, 1200)
// level 2: low=100, mod=150, high=200 (x1 = 100, 150, 200)
// Total: low=550, mod=825, high=1400
const result = calculateEncounterDifficulty([3, 3, 3, 2], ["3"]);
expect(result.partyBudget).toEqual({
low: 550,
moderate: 825,
high: 1400,
});
const result = calculateEncounterDifficulty(
[party(3), party(3), party(3), party(2), enemy("3")],
"5.5e",
);
expect(result.thresholds).toEqual([
{ label: "Low", value: 550 },
{ label: "Moderate", value: 825 },
{ label: "High", value: 1400 },
]);
expect(result.totalMonsterXp).toBe(700);
expect(result.tier).toBe("low");
expect(result.tier).toBe(1);
});
it("returns trivial with empty monster array", () => {
const result = calculateEncounterDifficulty([5, 5], []);
expect(result.tier).toBe("trivial");
it("returns tier 0 with no enemies", () => {
const result = calculateEncounterDifficulty([party(5), party(5)], "5.5e");
expect(result.tier).toBe(0);
expect(result.totalMonsterXp).toBe(0);
});
it("returns high with empty party array (zero budget thresholds)", () => {
// Domain function treats empty party as zero budgets — any XP exceeds all thresholds.
// The useDifficulty hook guards this path by returning null when no leveled PCs exist.
const result = calculateEncounterDifficulty([], ["1"]);
expect(result.tier).toBe("high");
it("returns tier 3 with no party levels (zero budget thresholds)", () => {
const result = calculateEncounterDifficulty([enemy("1")], "5.5e");
expect(result.tier).toBe(3);
expect(result.totalMonsterXp).toBe(200);
expect(result.partyBudget).toEqual({ low: 0, moderate: 0, high: 0 });
expect(result.thresholds).toEqual([
{ label: "Low", value: 0 },
{ label: "Moderate", value: 0 },
{ label: "High", value: 0 },
]);
});
it("handles fractional CRs", () => {
const result = calculateEncounterDifficulty(
[1, 1, 1, 1],
["1/8", "1/4", "1/2"],
[
party(1),
party(1),
party(1),
party(1),
enemy("1/8"),
enemy("1/4"),
enemy("1/2"),
],
"5.5e",
);
expect(result.totalMonsterXp).toBe(175); // 25 + 50 + 100
expect(result.tier).toBe("trivial"); // 175 < 200 Low
expect(result.tier).toBe(0); // 175 < 200 Low
});
it("ignores unknown CRs (0 XP)", () => {
const result = calculateEncounterDifficulty([1, 1, 1, 1], ["unknown"]);
const result = calculateEncounterDifficulty(
[party(1), party(1), party(1), party(1), enemy("unknown")],
"5.5e",
);
expect(result.totalMonsterXp).toBe(0);
expect(result.tier).toBe("trivial");
expect(result.tier).toBe(0);
});
it("subtracts XP for party-side combatant with CR", () => {
// 4x level 1 party, 1 enemy CR 2 (450 XP), 1 party CR 1 (200 XP)
// Net = 450 - 200 = 250
const result = calculateEncounterDifficulty(
[
party(1),
party(1),
party(1),
party(1),
enemy("2"),
{ cr: "1", side: "party" },
],
"5.5e",
);
expect(result.totalMonsterXp).toBe(250);
expect(result.tier).toBe(1); // 250 >= 200 Low, < 300 Moderate
});
it("floors net monster XP at 0", () => {
// Party ally has more XP than enemy
const result = calculateEncounterDifficulty(
[
party(1),
{ cr: "5", side: "party" }, // 1800 XP subtracted
enemy("1"), // 200 XP added
],
"5.5e",
);
expect(result.totalMonsterXp).toBe(0);
expect(result.tier).toBe(0);
});
it("dual contribution: combatant with both level and CR on party side", () => {
// Party combatant with level 1 AND CR 1 on party side
// Level contributes to budget, CR subtracts from monster XP
const result = calculateEncounterDifficulty(
[
{ level: 1, cr: "1", side: "party" }, // budget += lv1, monsterXp -= 200
enemy("2"), // monsterXp += 450
],
"5.5e",
);
expect(result.thresholds).toEqual([
{ label: "Low", value: 50 },
{ label: "Moderate", value: 75 },
{ label: "High", value: 100 },
]);
expect(result.totalMonsterXp).toBe(250); // 450 - 200
});
it("enemy-side combatant with level does NOT contribute to budget", () => {
const result = calculateEncounterDifficulty(
[party(1), { level: 5, side: "enemy" }, enemy("1")],
"5.5e",
);
// Only level 1 party contributes to budget
expect(result.thresholds).toEqual([
{ label: "Low", value: 50 },
{ label: "Moderate", value: 75 },
{ label: "High", value: 100 },
]);
expect(result.totalMonsterXp).toBe(200);
});
it("mixed sides calculate correctly", () => {
// 2 party PCs (level 3), 1 party ally (CR 1, 200 XP), 2 enemies (CR 2, 450 each)
// Budget: 2x level 3 = low 300, mod 450, high 800
// Monster XP: 900 - 200 = 700
const result = calculateEncounterDifficulty(
[party(3), party(3), { cr: "1", side: "party" }, enemy("2"), enemy("2")],
"5.5e",
);
expect(result.thresholds).toEqual([
{ label: "Low", value: 300 },
{ label: "Moderate", value: 450 },
{ label: "High", value: 800 },
]);
expect(result.totalMonsterXp).toBe(700);
expect(result.tier).toBe(2); // 700 >= 450 Moderate, < 800 High
});
});
describe("calculateEncounterDifficulty — 2014 edition", () => {
it("uses 2014 XP thresholds table", () => {
// 4x level 1: Easy=100, Medium=200, Hard=300, Deadly=400
// 1 enemy CR 1 = 200 XP, x1 multiplier = 200 adjusted
// 200 >= 200 Medium → tier 1
const result = calculateEncounterDifficulty(
[party(1), party(1), party(1), party(1), enemy("1")],
"5e",
);
expect(result.tier).toBe(1);
expect(result.thresholds).toEqual([
{ label: "Easy", value: 100 },
{ label: "Medium", value: 200 },
{ label: "Hard", value: 300 },
{ label: "Deadly", value: 400 },
]);
});
it("applies encounter multiplier for 3 monsters (x2)", () => {
const result = calculateEncounterDifficulty(
[
party(1),
party(1),
party(1),
party(1),
enemy("1/8"),
enemy("1/8"),
enemy("1/8"),
],
"5e",
);
// Base: 75 XP, 3 monsters → x2 = 150 adjusted
expect(result.totalMonsterXp).toBe(75);
expect(result.encounterMultiplier).toBe(2);
expect(result.adjustedXp).toBe(150);
});
it("shifts multiplier up for fewer than 3 PCs", () => {
const result = calculateEncounterDifficulty(
[party(1), party(1), enemy("1")],
"5e",
);
// 1 monster, 2 PCs → base x1 shifts up to x1.5
expect(result.encounterMultiplier).toBe(1.5);
expect(result.partySizeAdjusted).toBe(true);
});
it("shifts multiplier down for 6+ PCs", () => {
const result = calculateEncounterDifficulty(
[
party(1),
party(1),
party(1),
party(1),
party(1),
party(1),
enemy("1"),
enemy("1"),
enemy("1"),
],
"5e",
);
// 3 monsters, 6 PCs → base x2 shifts down to x1.5
expect(result.encounterMultiplier).toBe(1.5);
expect(result.partySizeAdjusted).toBe(true);
});
it("shifts multiplier to x5 for 15+ monsters with <3 PCs", () => {
const result = calculateEncounterDifficulty(
[party(1), party(1), ...Array.from({ length: 15 }, () => enemy("0"))],
"5e",
);
// 15+ monsters = x4 base, shift up → x5
expect(result.encounterMultiplier).toBe(5);
expect(result.partySizeAdjusted).toBe(true);
});
it("shifts multiplier to x0.5 for 1 monster with 6+ PCs", () => {
const result = calculateEncounterDifficulty(
[party(1), party(1), party(1), party(1), party(1), party(1), enemy("1")],
"5e",
);
expect(result.encounterMultiplier).toBe(0.5);
expect(result.partySizeAdjusted).toBe(true);
});
it("only counts enemy-side combatants for monster count", () => {
const result = calculateEncounterDifficulty(
[
party(1),
party(1),
party(1),
party(1),
{ cr: "1", side: "party" },
enemy("1"),
enemy("1"),
enemy("1"),
],
"5e",
);
// 3 enemy monsters → x2, NOT 4
expect(result.encounterMultiplier).toBe(2);
});
it("returns tier 0 when adjusted XP meets Easy but not Medium", () => {
// 4x level 1: Easy=100, Medium=200
// 1 enemy CR 1/2 = 100 XP, x1 multiplier = 100 adjusted
// 100 >= Easy(100) but < Medium(200) → tier 0
const result = calculateEncounterDifficulty(
[party(1), party(1), party(1), party(1), enemy("1/2")],
"5e",
);
expect(result.tier).toBe(0);
expect(result.adjustedXp).toBe(100);
});
it("returns no party size adjustment for standard party (3-5)", () => {
const result = calculateEncounterDifficulty(
[party(1), party(1), party(1), party(1), enemy("1")],
"5e",
);
expect(result.partySizeAdjusted).toBe(false);
});
it("returns undefined multiplier/adjustedXp for 5.5e", () => {
const result = calculateEncounterDifficulty([party(1), enemy("1")], "5.5e");
expect(result.encounterMultiplier).toBeUndefined();
expect(result.adjustedXp).toBeUndefined();
});
});

View File

@@ -1,6 +1,7 @@
import { describe, expect, it } from "vitest";
import {
calculateInitiative,
calculatePf2eInitiative,
formatInitiativeModifier,
} from "../initiative.js";
@@ -93,6 +94,26 @@ describe("calculateInitiative", () => {
});
});
describe("calculatePf2eInitiative", () => {
it("returns perception as both modifier and passive", () => {
const result = calculatePf2eInitiative(11);
expect(result.modifier).toBe(11);
expect(result.passive).toBe(11);
});
it("handles zero perception", () => {
const result = calculatePf2eInitiative(0);
expect(result.modifier).toBe(0);
expect(result.passive).toBe(0);
});
it("handles negative perception", () => {
const result = calculatePf2eInitiative(-2);
expect(result.modifier).toBe(-2);
expect(result.passive).toBe(-2);
});
});
describe("formatInitiativeModifier", () => {
it("formats positive modifier with plus sign", () => {
expect(formatInitiativeModifier(7)).toBe("+7");

View File

@@ -35,7 +35,7 @@ describe("rehydrateCombatant", () => {
expect(result?.maxHp).toBe(7);
expect(result?.currentHp).toBe(5);
expect(result?.tempHp).toBe(3);
expect(result?.conditions).toEqual(["poisoned"]);
expect(result?.conditions).toEqual([{ id: "poisoned" }]);
expect(result?.isConcentrating).toBe(true);
expect(result?.creatureId).toBe("creature-goblin");
expect(result?.color).toBe("red");
@@ -165,7 +165,45 @@ describe("rehydrateCombatant", () => {
...minimalCombatant(),
conditions: ["poisoned", "fake", "blinded"],
});
expect(result?.conditions).toEqual(["poisoned", "blinded"]);
expect(result?.conditions).toEqual([
{ id: "poisoned" },
{ id: "blinded" },
]);
});
it("converts old bare string format to ConditionEntry", () => {
const result = rehydrateCombatant({
...minimalCombatant(),
conditions: ["blinded", "prone"],
});
expect(result?.conditions).toEqual([{ id: "blinded" }, { id: "prone" }]);
});
it("passes through new ConditionEntry format with values", () => {
const result = rehydrateCombatant({
...minimalCombatant(),
conditions: [{ id: "blinded" }, { id: "frightened", value: 2 }],
});
expect(result?.conditions).toEqual([
{ id: "blinded" },
{ id: "frightened", value: 2 },
]);
});
it("handles mixed old and new format entries", () => {
const result = rehydrateCombatant({
...minimalCombatant(),
conditions: ["blinded", { id: "prone" }],
});
expect(result?.conditions).toEqual([{ id: "blinded" }, { id: "prone" }]);
});
it("drops ConditionEntry with invalid value", () => {
const result = rehydrateCombatant({
...minimalCombatant(),
conditions: [{ id: "blinded", value: -1 }],
});
expect(result?.conditions).toEqual([{ id: "blinded" }]);
});
it("drops invalid color — keeps combatant", () => {
@@ -241,6 +279,28 @@ describe("rehydrateCombatant", () => {
expect(result?.cr).toBeUndefined();
});
it("preserves valid side field", () => {
for (const side of ["party", "enemy"]) {
const result = rehydrateCombatant({ ...minimalCombatant(), side });
expect(result).not.toBeNull();
expect(result?.side).toBe(side);
}
});
it("drops invalid side field", () => {
for (const side of ["ally", "", 42, null, true]) {
const result = rehydrateCombatant({ ...minimalCombatant(), side });
expect(result).not.toBeNull();
expect(result?.side).toBeUndefined();
}
});
it("combatant without side rehydrates as before", () => {
const result = rehydrateCombatant(minimalCombatant());
expect(result).not.toBeNull();
expect(result?.side).toBeUndefined();
});
it("drops invalid tempHp — keeps combatant", () => {
for (const tempHp of [-1, 1.5, "3"]) {
const result = rehydrateCombatant({

View File

@@ -0,0 +1,115 @@
import { describe, expect, it } from "vitest";
import { setSide } from "../set-side.js";
import type { Combatant, Encounter } from "../types.js";
import { combatantId, isDomainError } from "../types.js";
import { expectDomainError } from "./test-helpers.js";
function makeCombatant(name: string, side?: "party" | "enemy"): Combatant {
return side === undefined
? { id: combatantId(name), name }
: { id: combatantId(name), name, side };
}
function enc(
combatants: Combatant[],
activeIndex = 0,
roundNumber = 1,
): Encounter {
return { combatants, activeIndex, roundNumber };
}
function successResult(
encounter: Encounter,
id: string,
value: "party" | "enemy",
) {
const result = setSide(encounter, combatantId(id), value);
if (isDomainError(result)) {
throw new Error(`Expected success, got error: ${result.message}`);
}
return result;
}
describe("setSide", () => {
it("sets side to party", () => {
const e = enc([makeCombatant("A"), makeCombatant("B")]);
const { encounter, events } = successResult(e, "A", "party");
expect(encounter.combatants[0].side).toBe("party");
expect(events).toEqual([
{
type: "SideSet",
combatantId: combatantId("A"),
previousSide: undefined,
newSide: "party",
},
]);
});
it("sets side to enemy", () => {
const e = enc([makeCombatant("A")]);
const { encounter } = successResult(e, "A", "enemy");
expect(encounter.combatants[0].side).toBe("enemy");
});
it("records previous side in event", () => {
const e = enc([makeCombatant("A", "party")]);
const { events } = successResult(e, "A", "enemy");
expect(events[0]).toMatchObject({
previousSide: "party",
newSide: "enemy",
});
});
it("returns error for nonexistent combatant", () => {
const e = enc([makeCombatant("A")]);
const result = setSide(e, combatantId("nonexistent"), "party");
expectDomainError(result, "combatant-not-found");
});
it("preserves other fields when setting side", () => {
const combatant: Combatant = {
id: combatantId("A"),
name: "Aria",
initiative: 15,
maxHp: 20,
currentHp: 18,
ac: 14,
cr: "2",
};
const e = enc([combatant]);
const { encounter } = successResult(e, "A", "party");
const updated = encounter.combatants[0];
expect(updated.side).toBe("party");
expect(updated.name).toBe("Aria");
expect(updated.initiative).toBe(15);
expect(updated.cr).toBe("2");
});
it("does not reorder combatants", () => {
const e = enc([makeCombatant("A"), makeCombatant("B")]);
const { encounter } = successResult(e, "B", "party");
expect(encounter.combatants[0].id).toBe(combatantId("A"));
expect(encounter.combatants[1].id).toBe(combatantId("B"));
});
it("preserves activeIndex and roundNumber", () => {
const e = enc([makeCombatant("A"), makeCombatant("B")], 1, 5);
const { encounter } = successResult(e, "A", "party");
expect(encounter.activeIndex).toBe(1);
expect(encounter.roundNumber).toBe(5);
});
it("does not mutate input encounter", () => {
const e = enc([makeCombatant("A")]);
const original = JSON.parse(JSON.stringify(e));
setSide(e, combatantId("A"), "party");
expect(e).toEqual(original);
});
});

View File

@@ -1,14 +1,18 @@
import { describe, expect, it } from "vitest";
import type { ConditionId } from "../conditions.js";
import type { ConditionEntry, ConditionId } from "../conditions.js";
import { CONDITION_DEFINITIONS } from "../conditions.js";
import { toggleCondition } from "../toggle-condition.js";
import {
decrementCondition,
setConditionValue,
toggleCondition,
} from "../toggle-condition.js";
import type { Combatant, Encounter } from "../types.js";
import { combatantId, isDomainError } from "../types.js";
import { expectDomainError } from "./test-helpers.js";
function makeCombatant(
name: string,
conditions?: readonly ConditionId[],
conditions?: readonly ConditionEntry[],
): Combatant {
return conditions
? { id: combatantId(name), name, conditions }
@@ -32,7 +36,7 @@ describe("toggleCondition", () => {
const e = enc([makeCombatant("A")]);
const { encounter, events } = success(e, "A", "blinded");
expect(encounter.combatants[0].conditions).toEqual(["blinded"]);
expect(encounter.combatants[0].conditions).toEqual([{ id: "blinded" }]);
expect(events).toEqual([
{
type: "ConditionAdded",
@@ -43,7 +47,7 @@ describe("toggleCondition", () => {
});
it("removes a condition when already present", () => {
const e = enc([makeCombatant("A", ["blinded"])]);
const e = enc([makeCombatant("A", [{ id: "blinded" }])]);
const { encounter, events } = success(e, "A", "blinded");
expect(encounter.combatants[0].conditions).toBeUndefined();
@@ -57,14 +61,17 @@ describe("toggleCondition", () => {
});
it("maintains definition order when adding conditions", () => {
const e = enc([makeCombatant("A", ["poisoned"])]);
const e = enc([makeCombatant("A", [{ id: "poisoned" }])]);
const { encounter } = success(e, "A", "blinded");
expect(encounter.combatants[0].conditions).toEqual(["blinded", "poisoned"]);
expect(encounter.combatants[0].conditions).toEqual([
{ id: "blinded" },
{ id: "poisoned" },
]);
});
it("prevents duplicate conditions", () => {
const e = enc([makeCombatant("A", ["blinded"])]);
const e = enc([makeCombatant("A", [{ id: "blinded" }])]);
// Toggling blinded again removes it, not duplicates
const { encounter } = success(e, "A", "blinded");
expect(encounter.combatants[0].conditions).toBeUndefined();
@@ -96,7 +103,7 @@ describe("toggleCondition", () => {
});
it("normalizes empty array to undefined on removal", () => {
const e = enc([makeCombatant("A", ["charmed"])]);
const e = enc([makeCombatant("A", [{ id: "charmed" }])]);
const { encounter } = success(e, "A", "charmed");
expect(encounter.combatants[0].conditions).toBeUndefined();
@@ -110,6 +117,145 @@ describe("toggleCondition", () => {
const result = success(e, "A", cond);
e = result.encounter;
}
expect(e.combatants[0].conditions).toEqual(order);
expect(e.combatants[0].conditions).toEqual(order.map((id) => ({ id })));
});
});
describe("setConditionValue", () => {
it("adds a valued condition at the specified value", () => {
const e = enc([makeCombatant("A")]);
const result = setConditionValue(e, combatantId("A"), "frightened", 2);
if (isDomainError(result)) throw new Error(result.message);
expect(result.encounter.combatants[0].conditions).toEqual([
{ id: "frightened", value: 2 },
]);
expect(result.events).toEqual([
{
type: "ConditionAdded",
combatantId: combatantId("A"),
condition: "frightened",
value: 2,
},
]);
});
it("updates the value of an existing condition", () => {
const e = enc([makeCombatant("A", [{ id: "frightened", value: 1 }])]);
const result = setConditionValue(e, combatantId("A"), "frightened", 3);
if (isDomainError(result)) throw new Error(result.message);
expect(result.encounter.combatants[0].conditions).toEqual([
{ id: "frightened", value: 3 },
]);
});
it("removes condition when value is 0", () => {
const e = enc([makeCombatant("A", [{ id: "frightened", value: 2 }])]);
const result = setConditionValue(e, combatantId("A"), "frightened", 0);
if (isDomainError(result)) throw new Error(result.message);
expect(result.encounter.combatants[0].conditions).toBeUndefined();
expect(result.events[0].type).toBe("ConditionRemoved");
});
it("rejects unknown condition", () => {
const e = enc([makeCombatant("A")]);
const result = setConditionValue(
e,
combatantId("A"),
"flying" as ConditionId,
1,
);
expectDomainError(result, "unknown-condition");
});
it("clamps value to maxValue for capped conditions", () => {
const e = enc([makeCombatant("A")]);
const result = setConditionValue(e, combatantId("A"), "dying", 6);
if (isDomainError(result)) throw new Error(result.message);
expect(result.encounter.combatants[0].conditions).toEqual([
{ id: "dying", value: 4 },
]);
expect(result.events[0]).toMatchObject({
type: "ConditionAdded",
value: 4,
});
});
it("allows value at exactly the max", () => {
const e = enc([makeCombatant("A")]);
const result = setConditionValue(e, combatantId("A"), "doomed", 3);
if (isDomainError(result)) throw new Error(result.message);
expect(result.encounter.combatants[0].conditions).toEqual([
{ id: "doomed", value: 3 },
]);
});
it("allows value below the max", () => {
const e = enc([makeCombatant("A")]);
const result = setConditionValue(e, combatantId("A"), "wounded", 2);
if (isDomainError(result)) throw new Error(result.message);
expect(result.encounter.combatants[0].conditions).toEqual([
{ id: "wounded", value: 2 },
]);
});
it("does not cap conditions without a maxValue", () => {
const e = enc([makeCombatant("A")]);
const result = setConditionValue(e, combatantId("A"), "frightened", 10);
if (isDomainError(result)) throw new Error(result.message);
expect(result.encounter.combatants[0].conditions).toEqual([
{ id: "frightened", value: 10 },
]);
});
it("clamps when updating an existing capped condition", () => {
const e = enc([makeCombatant("A", [{ id: "slowed-pf2e", value: 2 }])]);
const result = setConditionValue(e, combatantId("A"), "slowed-pf2e", 5);
if (isDomainError(result)) throw new Error(result.message);
expect(result.encounter.combatants[0].conditions).toEqual([
{ id: "slowed-pf2e", value: 3 },
]);
});
});
describe("decrementCondition", () => {
it("decrements value by 1", () => {
const e = enc([makeCombatant("A", [{ id: "frightened", value: 3 }])]);
const result = decrementCondition(e, combatantId("A"), "frightened");
if (isDomainError(result)) throw new Error(result.message);
expect(result.encounter.combatants[0].conditions).toEqual([
{ id: "frightened", value: 2 },
]);
});
it("removes condition when value reaches 0", () => {
const e = enc([makeCombatant("A", [{ id: "frightened", value: 1 }])]);
const result = decrementCondition(e, combatantId("A"), "frightened");
if (isDomainError(result)) throw new Error(result.message);
expect(result.encounter.combatants[0].conditions).toBeUndefined();
expect(result.events[0].type).toBe("ConditionRemoved");
});
it("removes non-valued condition (value undefined treated as 1)", () => {
const e = enc([makeCombatant("A", [{ id: "blinded" }])]);
const result = decrementCondition(e, combatantId("A"), "blinded");
if (isDomainError(result)) throw new Error(result.message);
expect(result.encounter.combatants[0].conditions).toBeUndefined();
});
it("returns error for inactive condition", () => {
const e = enc([makeCombatant("A")]);
const result = decrementCondition(e, combatantId("A"), "frightened");
expectDomainError(result, "condition-not-active");
});
});

View File

@@ -1,3 +1,28 @@
const DIGITS_ONLY = /^\d+$/;
function scanExisting(
baseName: string,
existingNames: readonly string[],
): { exactMatches: number[]; maxNumber: number } {
const exactMatches: number[] = [];
let maxNumber = 0;
const prefix = `${baseName} `;
for (let i = 0; i < existingNames.length; i++) {
const name = existingNames[i];
if (name === baseName) {
exactMatches.push(i);
} else if (name.startsWith(prefix)) {
const suffix = name.slice(prefix.length);
if (DIGITS_ONLY.test(suffix)) {
const num = Number.parseInt(suffix, 10);
if (num > maxNumber) maxNumber = num;
}
}
}
return { exactMatches, maxNumber };
}
/**
* Resolves a creature name against existing combatant names,
* handling auto-numbering for duplicates.
@@ -14,25 +39,7 @@ export function resolveCreatureName(
newName: string;
renames: ReadonlyArray<{ from: string; to: string }>;
} {
// Find exact matches and numbered matches (e.g., "Goblin 1", "Goblin 2")
const exactMatches: number[] = [];
let maxNumber = 0;
for (let i = 0; i < existingNames.length; i++) {
const name = existingNames[i];
if (name === baseName) {
exactMatches.push(i);
} else {
const match = new RegExp(
String.raw`^${escapeRegExp(baseName)} (\d+)$`,
).exec(name);
// biome-ignore lint/nursery/noUnnecessaryConditions: RegExp.exec() returns null on no match — false positive
if (match) {
const num = Number.parseInt(match[1], 10);
if (num > maxNumber) maxNumber = num;
}
}
}
const { exactMatches, maxNumber } = scanExisting(baseName, existingNames);
// No conflict at all
if (exactMatches.length === 0 && maxNumber === 0) {
@@ -51,7 +58,3 @@ export function resolveCreatureName(
const nextNumber = Math.max(maxNumber, exactMatches.length) + 1;
return { newName: `${baseName} ${nextNumber}`, renames: [] };
}
function escapeRegExp(s: string): string {
return s.replaceAll(/[.*+?^${}()|[\]\\]/g, String.raw`\$&`);
}

View File

@@ -1,43 +1,76 @@
export type ConditionId =
| "blinded"
| "charmed"
| "clumsy"
| "concealed"
| "confused"
| "controlled"
| "dazzled"
| "deafened"
| "doomed"
| "drained"
| "dying"
| "enfeebled"
| "exhaustion"
| "fascinated"
| "fatigued"
| "fleeing"
| "frightened"
| "grabbed"
| "grappled"
| "hidden"
| "immobilized"
| "incapacitated"
| "invisible"
| "off-guard"
| "paralyzed"
| "petrified"
| "poisoned"
| "prone"
| "quickened"
| "restrained"
| "sapped"
| "sickened"
| "slowed"
| "slowed-pf2e"
| "stunned"
| "unconscious";
| "stupefied"
| "unconscious"
| "undetected"
| "wounded";
export type RulesEdition = "5e" | "5.5e";
export interface ConditionEntry {
readonly id: ConditionId;
readonly value?: number;
}
import type { RulesEdition } from "./rules-edition.js";
export interface ConditionDefinition {
readonly id: ConditionId;
readonly label: string;
readonly description: string;
readonly description5e: string;
readonly descriptionPf2e?: string;
readonly iconName: string;
readonly color: string;
/** When set, the condition only appears in this edition's picker. */
readonly edition?: RulesEdition;
/** When set, the condition only appears in these systems' pickers. */
readonly systems?: readonly RulesEdition[];
readonly valued?: boolean;
/** Rule-defined maximum value for PF2e valued conditions. */
readonly maxValue?: number;
}
export function getConditionDescription(
def: ConditionDefinition,
edition: RulesEdition,
): string {
if (edition === "pf2e" && def.descriptionPf2e) return def.descriptionPf2e;
return edition === "5e" ? def.description5e : def.description;
}
export const CONDITION_DEFINITIONS: readonly ConditionDefinition[] = [
// ── Shared conditions (D&D + PF2e) ──
{
id: "blinded",
label: "Blinded",
@@ -45,6 +78,8 @@ export const CONDITION_DEFINITIONS: readonly ConditionDefinition[] = [
"Can't see. Auto-fail sight checks. Attacks have Disadvantage; attacks against have Advantage.",
description5e:
"Can't see. Auto-fail sight checks. Attacks have Disadvantage; attacks against have Advantage.",
descriptionPf2e:
"Can't see. All terrain is difficult terrain. Auto-fail checks requiring sight. Immune to visual effects. Overrides dazzled.",
iconName: "EyeOff",
color: "neutral",
},
@@ -57,12 +92,15 @@ export const CONDITION_DEFINITIONS: readonly ConditionDefinition[] = [
"Can't attack or target the charmer with harmful abilities. Charmer has Advantage on social checks.",
iconName: "Heart",
color: "pink",
systems: ["5e", "5.5e"],
},
{
id: "deafened",
label: "Deafened",
description: "Can't hear. Auto-fail hearing checks.",
description5e: "Can't hear. Auto-fail hearing checks.",
descriptionPf2e:
"Can't hear. Auto-critically-fail hearing checks. 2 status penalty to Perception. Auditory actions require DC 5 flat check. Immune to auditory effects.",
iconName: "EarOff",
color: "neutral",
},
@@ -75,6 +113,7 @@ export const CONDITION_DEFINITIONS: readonly ConditionDefinition[] = [
"L1: Disadvantage on ability checks\nL2: Speed halved\nL3: Disadvantage on attacks and saves\nL4: HP max halved\nL5: Speed 0\nL6: Death\nLong rest removes 1 level.",
iconName: "BatteryLow",
color: "amber",
systems: ["5e", "5.5e"],
},
{
id: "frightened",
@@ -83,8 +122,11 @@ export const CONDITION_DEFINITIONS: readonly ConditionDefinition[] = [
"Disadvantage on ability checks and attacks while source of fear is in line of sight. Can't willingly move closer to the source.",
description5e:
"Disadvantage on ability checks and attacks while source of fear is in line of sight. Can't willingly move closer to the source.",
descriptionPf2e:
"X status penalty to all checks and DCs (X = value). Can't willingly approach the source.",
iconName: "Siren",
color: "orange",
valued: true,
},
{
id: "grappled",
@@ -95,6 +137,7 @@ export const CONDITION_DEFINITIONS: readonly ConditionDefinition[] = [
"Speed 0. Ends if grappler is Incapacitated or moved out of reach.",
iconName: "Hand",
color: "neutral",
systems: ["5e", "5.5e"],
},
{
id: "incapacitated",
@@ -104,6 +147,7 @@ export const CONDITION_DEFINITIONS: readonly ConditionDefinition[] = [
description5e: "Can't take Actions or Reactions.",
iconName: "Ban",
color: "gray",
systems: ["5e", "5.5e"],
},
{
id: "invisible",
@@ -112,6 +156,8 @@ export const CONDITION_DEFINITIONS: readonly ConditionDefinition[] = [
"Can't be seen. Advantage on Initiative. Not affected by effects requiring sight (unless caster sees you). Attacks have Advantage; attacks against have Disadvantage.",
description5e:
"Impossible to see without magic or special sense. Heavily Obscured. Attacks have Advantage; attacks against have Disadvantage.",
descriptionPf2e:
"Can't be seen except by special senses. Undetected to everyone. Can't be targeted except by effects that don't require sight.",
iconName: "Ghost",
color: "violet",
},
@@ -122,6 +168,8 @@ export const CONDITION_DEFINITIONS: readonly ConditionDefinition[] = [
"Incapacitated. Can't move or speak. Auto-fail Str/Dex saves. Attacks against have Advantage. Hits within 5 ft. are critical.",
description5e:
"Incapacitated. Can't move or speak. Auto-fail Str/Dex saves. Attacks against have Advantage. Hits within 5 ft. are critical.",
descriptionPf2e:
"Can't act. Off-guard. Can only Recall Knowledge or use mental actions.",
iconName: "ZapOff",
color: "yellow",
},
@@ -132,6 +180,8 @@ export const CONDITION_DEFINITIONS: readonly ConditionDefinition[] = [
"Turned to stone. Weight \u00D710. Incapacitated. Can't move or speak. Attacks against have Advantage. Auto-fail Str/Dex saves. Resistant to all damage. Immune to poison and disease.",
description5e:
"Turned to stone. Weight \u00D710. Incapacitated. Can't move or speak. Attacks against have Advantage. Auto-fail Str/Dex saves. Resistant to all damage. Immune to poison and disease.",
descriptionPf2e:
"Can't act. Can't sense anything. AC = 9. Hardness 8. Immune to most effects.",
iconName: "Gem",
color: "slate",
},
@@ -142,6 +192,7 @@ export const CONDITION_DEFINITIONS: readonly ConditionDefinition[] = [
description5e: "Disadvantage on attack rolls and ability checks.",
iconName: "Droplet",
color: "green",
systems: ["5e", "5.5e"],
},
{
id: "prone",
@@ -150,6 +201,8 @@ export const CONDITION_DEFINITIONS: readonly ConditionDefinition[] = [
"Can only crawl (costs extra movement). Disadvantage on attacks. Attacks within 5 ft. have Advantage; ranged attacks have Disadvantage. Standing up costs half movement.",
description5e:
"Can only crawl (costs extra movement). Disadvantage on attacks. Attacks within 5 ft. have Advantage; ranged attacks have Disadvantage. Standing up costs half movement.",
descriptionPf2e:
"Off-guard. 2 circumstance penalty to attack rolls. Only movement is Crawl and Stand. +1 circumstance bonus to AC vs. ranged attacks, 2 vs. melee.",
iconName: "ArrowDown",
color: "neutral",
},
@@ -160,6 +213,8 @@ export const CONDITION_DEFINITIONS: readonly ConditionDefinition[] = [
"Speed is 0. Attacks have Disadvantage. Attacks against have Advantage. Disadvantage on Dex saves.",
description5e:
"Speed is 0. Attacks have Disadvantage. Attacks against have Advantage. Disadvantage on Dex saves.",
descriptionPf2e:
"Off-guard. Immobilized. Can't use any actions with the attack trait except to attempt to Escape.",
iconName: "Link",
color: "neutral",
},
@@ -171,7 +226,7 @@ export const CONDITION_DEFINITIONS: readonly ConditionDefinition[] = [
description5e: "",
iconName: "ShieldMinus",
color: "amber",
edition: "5.5e",
systems: ["5.5e"],
},
{
id: "slowed",
@@ -181,7 +236,7 @@ export const CONDITION_DEFINITIONS: readonly ConditionDefinition[] = [
description5e: "",
iconName: "Snail",
color: "sky",
edition: "5.5e",
systems: ["5.5e"],
},
{
id: "stunned",
@@ -190,8 +245,11 @@ export const CONDITION_DEFINITIONS: readonly ConditionDefinition[] = [
"Incapacitated (can't act or speak). Auto-fail Str/Dex saves. Attacks against have Advantage.",
description5e:
"Incapacitated. Can't move. Can speak only falteringly. Auto-fail Str/Dex saves. Attacks against have Advantage.",
descriptionPf2e:
"Can't act. Lose X total actions across turns, then the condition ends. Overrides slowed.",
iconName: "Sparkles",
color: "yellow",
valued: true,
},
{
id: "unconscious",
@@ -200,9 +258,265 @@ export const CONDITION_DEFINITIONS: readonly ConditionDefinition[] = [
"Incapacitated. Speed 0. Can't move or speak. Unaware of surroundings. Drops held items, falls Prone. Auto-fail Str/Dex saves. Attacks against have Advantage. Hits within 5 ft. are critical.",
description5e:
"Incapacitated. Speed 0. Can't move or speak. Unaware of surroundings. Drops held items, falls Prone. Auto-fail Str/Dex saves. Attacks against have Advantage. Hits within 5 ft. are critical.",
descriptionPf2e:
"Can't act. Off-guard. Blinded. 4 status penalty to AC, Perception, and Reflex saves. Fall prone, drop items.",
iconName: "Moon",
color: "indigo",
},
// ── PF2e-only conditions ──
{
id: "clumsy",
label: "Clumsy",
description: "",
description5e: "",
descriptionPf2e:
"X status penalty to Dex-based checks and DCs, including AC, Reflex saves, and ranged attack rolls.",
iconName: "Footprints",
color: "amber",
systems: ["pf2e"],
valued: true,
},
{
id: "concealed",
label: "Concealed",
description: "",
description5e: "",
descriptionPf2e:
"DC 5 flat check for targeted attacks. Doesn't change which creatures can see you.",
iconName: "CloudFog",
color: "slate",
systems: ["pf2e"],
},
{
id: "confused",
label: "Confused",
description: "",
description5e: "",
descriptionPf2e:
"Off-guard. Can't Delay, Ready, or use reactions. Must Strike or cast offensive cantrips at random targets. DC 11 flat check when damaged to end.",
iconName: "CircleHelp",
color: "pink",
systems: ["pf2e"],
},
{
id: "controlled",
label: "Controlled",
description: "",
description5e: "",
descriptionPf2e:
"Another creature determines your actions. You gain no actions of your own.",
iconName: "Drama",
color: "pink",
systems: ["pf2e"],
},
{
id: "dazzled",
label: "Dazzled",
description: "",
description5e: "",
descriptionPf2e:
"All creatures and objects are concealed to you. DC 5 flat check for targeted attacks requiring sight.",
iconName: "Sun",
color: "yellow",
systems: ["pf2e"],
},
{
id: "doomed",
label: "Doomed",
description: "",
description5e: "",
descriptionPf2e:
"Die at dying X (where X = 4 doomed value instead of dying 4). Decreases by 1 on full night's rest.",
iconName: "Skull",
color: "red",
systems: ["pf2e"],
valued: true,
maxValue: 3,
},
{
id: "drained",
label: "Drained",
description: "",
description5e: "",
descriptionPf2e:
"X status penalty to Con-based checks and DCs. Lose X × level in max HP. Decreases by 1 on full night's rest.",
iconName: "Droplets",
color: "red",
systems: ["pf2e"],
valued: true,
},
{
id: "dying",
label: "Dying",
description: "",
description5e: "",
descriptionPf2e:
"Unconscious. Make recovery checks at start of turn. At dying 4 (or 4 doomed), you die.",
iconName: "HeartPulse",
color: "red",
systems: ["pf2e"],
valued: true,
maxValue: 4,
},
{
id: "enfeebled",
label: "Enfeebled",
description: "",
description5e: "",
descriptionPf2e:
"X status penalty to Str-based rolls and DCs, including melee attack and damage rolls and Athletics checks.",
iconName: "TrendingDown",
color: "amber",
systems: ["pf2e"],
valued: true,
},
{
id: "fascinated",
label: "Fascinated",
description: "",
description5e: "",
descriptionPf2e:
"2 status penalty to Perception and skill checks. Can't use concentrate actions unless related to the fascination. Ends if hostile action is used against you or allies.",
iconName: "Eye",
color: "violet",
systems: ["pf2e"],
},
{
id: "fatigued",
label: "Fatigued",
description: "",
description5e: "",
descriptionPf2e:
"1 status penalty to AC and saves. Can't use exploration activities while traveling. Recover after a full night's rest.",
iconName: "BatteryLow",
color: "amber",
systems: ["pf2e"],
},
{
id: "fleeing",
label: "Fleeing",
description: "",
description5e: "",
descriptionPf2e:
"Must spend actions to move away from the source. Can't Delay or Ready.",
iconName: "PersonStanding",
color: "orange",
systems: ["pf2e"],
},
{
id: "grabbed",
label: "Grabbed",
description: "",
description5e: "",
descriptionPf2e:
"Off-guard. Immobilized. Manipulate actions require DC 5 flat check or are wasted.",
iconName: "Hand",
color: "neutral",
systems: ["pf2e"],
},
{
id: "hidden",
label: "Hidden",
description: "",
description5e: "",
descriptionPf2e:
"Known location but can't be seen. Off-guard to that creature. DC 11 flat check to target or miss.",
iconName: "EyeOff",
color: "slate",
systems: ["pf2e"],
},
{
id: "immobilized",
label: "Immobilized",
description: "",
description5e: "",
descriptionPf2e:
"Can't use any action with the move trait to change position.",
iconName: "Anchor",
color: "neutral",
systems: ["pf2e"],
},
{
id: "off-guard",
label: "Off-Guard",
description: "",
description5e: "",
descriptionPf2e: "2 circumstance penalty to AC. (Formerly flat-footed.)",
iconName: "ShieldOff",
color: "amber",
systems: ["pf2e"],
},
{
id: "quickened",
label: "Quickened",
description: "",
description5e: "",
descriptionPf2e:
"Gain 1 extra action at the start of your turn each round (limited uses specified by the effect).",
iconName: "Zap",
color: "green",
systems: ["pf2e"],
},
{
id: "sickened",
label: "Sickened",
description: "",
description5e: "",
descriptionPf2e:
"X status penalty to all checks and DCs. Can't willingly ingest anything. Reduce by retching (Fortitude save).",
iconName: "Droplet",
color: "green",
systems: ["pf2e"],
valued: true,
},
{
id: "slowed-pf2e",
label: "Slowed",
description: "",
description5e: "",
descriptionPf2e: "Lose X actions at the start of your turn each round.",
iconName: "Snail",
color: "sky",
systems: ["pf2e"],
valued: true,
maxValue: 3,
},
{
id: "stupefied",
label: "Stupefied",
description: "",
description5e: "",
descriptionPf2e:
"X status penalty to Int/Wis/Cha-based checks and DCs, including spell attack rolls and spell DCs. DC 5 + X flat check to cast spells or lose the spell.",
iconName: "BrainCog",
color: "violet",
systems: ["pf2e"],
valued: true,
},
{
id: "undetected",
label: "Undetected",
description: "",
description5e: "",
descriptionPf2e:
"Location unknown. Must pick a square to target; DC 11 flat check. Attacker is off-guard against your attacks.",
iconName: "Ghost",
color: "violet",
systems: ["pf2e"],
},
{
id: "wounded",
label: "Wounded",
description: "",
description5e: "",
descriptionPf2e:
"Next time you gain dying, add wounded value to dying value. Wounded 1 when you recover from dying; increases if already wounded.",
iconName: "HeartCrack",
color: "red",
systems: ["pf2e"],
valued: true,
maxValue: 3,
},
] as const;
export const VALID_CONDITION_IDS: ReadonlySet<string> = new Set(
@@ -213,6 +527,8 @@ export function getConditionsForEdition(
edition: RulesEdition,
): readonly ConditionDefinition[] {
return CONDITION_DEFINITIONS.filter(
(d) => d.edition === undefined || d.edition === edition,
);
(d) => d.systems === undefined || d.systems.includes(edition),
)
.slice()
.sort((a, b) => a.label.localeCompare(b.label));
}

View File

@@ -5,9 +5,25 @@ export function creatureId(id: string): CreatureId {
return id as CreatureId;
}
export type TraitSegment =
| { readonly type: "text"; readonly value: string }
| { readonly type: "list"; readonly items: readonly TraitListItem[] };
export interface TraitListItem {
readonly label?: string;
readonly text: string;
}
export interface ActivityCost {
readonly number: number;
readonly unit: "action" | "free" | "reaction";
}
export interface TraitBlock {
readonly name: string;
readonly text: string;
readonly activity?: ActivityCost;
readonly trigger?: string;
readonly segments: readonly TraitSegment[];
}
export interface LegendaryBlock {
@@ -15,16 +31,71 @@ export interface LegendaryBlock {
readonly entries: readonly TraitBlock[];
}
/**
* A single spell entry within a creature's spellcasting block.
*
* `name` is always populated. All other fields are optional and are only
* populated for PF2e creatures (sourced from embedded Foundry VTT spell items).
* D&D 5e creatures populate only `name`.
*/
export interface SpellReference {
readonly name: string;
/** Stable slug from Foundry VTT (e.g. "magic-missile"). PF2e only. */
readonly slug?: string;
/** Plain-text description with Foundry enrichment tags stripped. */
readonly description?: string;
/** Spell rank/level (0 = cantrip). */
readonly rank?: number;
/** Trait slugs (e.g. ["concentrate", "manipulate", "force"]). */
readonly traits?: readonly string[];
/** Tradition labels (e.g. ["arcane", "occult"]). */
readonly traditions?: readonly string[];
/** Range (e.g. "30 feet", "touch"). */
readonly range?: string;
/** Target (e.g. "1 creature"). */
readonly target?: string;
/** Area (e.g. "20-foot burst"). */
readonly area?: string;
/** Duration (e.g. "1 minute", "sustained up to 1 minute"). */
readonly duration?: string;
/** Defense / save (e.g. "basic Reflex", "Will"). */
readonly defense?: string;
/** Action cost. PF2e: number = action count, "reaction", "free", or
* "1 minute" / "10 minutes" for cast time. */
readonly actionCost?: string;
/**
* Heightening rules text. May come from `system.heightening` (fixed
* intervals) or `system.overlays` (variant casts). Plain text after
* tag stripping.
*/
readonly heightening?: string;
/** Uses per day for "(×N)" rendering, when > 1. PF2e only. */
readonly usesPerDay?: number;
}
export interface DailySpells {
readonly uses: number;
readonly each: boolean;
readonly spells: readonly string[];
readonly spells: readonly SpellReference[];
}
export interface SpellcastingBlock {
readonly name: string;
readonly headerText: string;
readonly atWill?: readonly string[];
readonly atWill?: readonly SpellReference[];
readonly daily?: readonly DailySpells[];
readonly restLong?: readonly DailySpells[];
}
@@ -92,6 +163,64 @@ export interface BestiaryIndex {
readonly creatures: readonly BestiaryIndexEntry[];
}
export interface Pf2eCreature {
readonly system: "pf2e";
readonly id: CreatureId;
readonly name: string;
readonly source: string;
readonly sourceDisplayName: string;
readonly level: number;
readonly traits: readonly string[];
readonly perception: number;
readonly senses?: string;
readonly languages?: string;
readonly skills?: string;
readonly abilityMods: {
readonly str: number;
readonly dex: number;
readonly con: number;
readonly int: number;
readonly wis: number;
readonly cha: number;
};
readonly items?: string;
readonly ac: number;
readonly acConditional?: string;
readonly saveFort: number;
readonly saveRef: number;
readonly saveWill: number;
readonly saveConditional?: string;
readonly hp: number;
readonly hpDetails?: string;
readonly immunities?: string;
readonly resistances?: string;
readonly weaknesses?: string;
readonly speed: string;
readonly attacks?: readonly TraitBlock[];
readonly abilitiesTop?: readonly TraitBlock[];
readonly abilitiesMid?: readonly TraitBlock[];
readonly abilitiesBot?: readonly TraitBlock[];
readonly spellcasting?: readonly SpellcastingBlock[];
}
export type AnyCreature = Creature | Pf2eCreature;
export interface Pf2eBestiaryIndexEntry {
readonly name: string;
readonly source: string;
readonly level: number;
readonly ac: number;
readonly hp: number;
readonly perception: number;
readonly size: string;
readonly type: string;
}
export interface Pf2eBestiaryIndex {
readonly sources: Readonly<Record<string, string>>;
readonly creatures: readonly Pf2eBestiaryIndexEntry[];
}
/** Maps a CR string to the corresponding proficiency bonus. */
export function proficiencyBonus(cr: string): number {
const numericCr = cr.includes("/")

View File

@@ -1,13 +1,23 @@
export type DifficultyTier = "trivial" | "low" | "moderate" | "high";
import type { RulesEdition } from "./rules-edition.js";
/** Abstract difficulty severity: 0 = negligible, 3 = maximum. Maps to filled bar count. */
export type DifficultyTier = 0 | 1 | 2 | 3;
export interface DifficultyThreshold {
readonly label: string;
readonly value: number;
}
export interface DifficultyResult {
readonly tier: DifficultyTier;
readonly totalMonsterXp: number;
readonly partyBudget: {
readonly low: number;
readonly moderate: number;
readonly high: number;
};
readonly thresholds: readonly DifficultyThreshold[];
/** 2014 only: the encounter multiplier applied to base monster XP. */
readonly encounterMultiplier: number | undefined;
/** 2014 only: monster XP after applying the encounter multiplier. */
readonly adjustedXp: number | undefined;
/** 2014 only: true when the multiplier was shifted due to party size (<3 or 6+). */
readonly partySizeAdjusted: boolean | undefined;
}
/** Maps challenge rating strings to XP values (standard 5e). */
@@ -74,6 +84,82 @@ const XP_BUDGET_PER_CHARACTER: Readonly<
20: { low: 6400, moderate: 13200, high: 22000 },
};
/** Maps character level (1-20) to XP thresholds (2014 DMG). */
const XP_THRESHOLDS_2014: Readonly<
Record<number, { easy: number; medium: number; hard: number; deadly: number }>
> = {
1: { easy: 25, medium: 50, hard: 75, deadly: 100 },
2: { easy: 50, medium: 100, hard: 150, deadly: 200 },
3: { easy: 75, medium: 150, hard: 225, deadly: 400 },
4: { easy: 125, medium: 250, hard: 375, deadly: 500 },
5: { easy: 250, medium: 500, hard: 750, deadly: 1100 },
6: { easy: 300, medium: 600, hard: 900, deadly: 1400 },
7: { easy: 350, medium: 750, hard: 1100, deadly: 1700 },
8: { easy: 450, medium: 900, hard: 1400, deadly: 2100 },
9: { easy: 550, medium: 1100, hard: 1600, deadly: 2400 },
10: { easy: 600, medium: 1200, hard: 1900, deadly: 2800 },
11: { easy: 800, medium: 1600, hard: 2400, deadly: 3600 },
12: { easy: 1000, medium: 2000, hard: 3000, deadly: 4500 },
13: { easy: 1100, medium: 2200, hard: 3400, deadly: 5100 },
14: { easy: 1250, medium: 2500, hard: 3800, deadly: 5700 },
15: { easy: 1400, medium: 2800, hard: 4300, deadly: 6400 },
16: { easy: 1600, medium: 3200, hard: 4800, deadly: 7200 },
17: { easy: 2000, medium: 3900, hard: 5900, deadly: 8800 },
18: { easy: 2100, medium: 4200, hard: 6300, deadly: 9500 },
19: { easy: 2400, medium: 4900, hard: 7300, deadly: 10900 },
20: { easy: 2800, medium: 5700, hard: 8500, deadly: 12700 },
};
/** 2014 encounter multiplier by number of enemy-side monsters. */
const ENCOUNTER_MULTIPLIER_TABLE: readonly {
max: number;
multiplier: number;
}[] = [
{ max: 1, multiplier: 1 },
{ max: 2, multiplier: 1.5 },
{ max: 6, multiplier: 2 },
{ max: 10, multiplier: 2.5 },
{ max: 14, multiplier: 3 },
{ max: Number.POSITIVE_INFINITY, multiplier: 4 },
];
/**
* Multiplier values in ascending order for party size shifting.
* Extends beyond the base table: x0.5 (6+ PCs, 1 monster) and x5 (<3 PCs, 15+ monsters)
* per 2014 DMG party size adjustment rules.
*/
const MULTIPLIER_STEPS = [0.5, 1, 1.5, 2, 2.5, 3, 4, 5] as const;
/** Index into MULTIPLIER_STEPS for each base table entry (before party size adjustment). */
const BASE_STEP_INDEX = [1, 2, 3, 4, 5, 6] as const;
function getEncounterMultiplier(
monsterCount: number,
partySize: number,
): { multiplier: number; partySizeAdjusted: boolean } {
const tableIndex = ENCOUNTER_MULTIPLIER_TABLE.findIndex(
(entry) => monsterCount <= entry.max,
);
let stepIndex: number =
BASE_STEP_INDEX[
tableIndex === -1 ? BASE_STEP_INDEX.length - 1 : tableIndex
];
let partySizeAdjusted = false;
if (partySize < 3) {
stepIndex = Math.min(stepIndex + 1, MULTIPLIER_STEPS.length - 1);
partySizeAdjusted = true;
} else if (partySize >= 6) {
stepIndex = Math.max(stepIndex - 1, 0);
partySizeAdjusted = true;
}
return {
multiplier: MULTIPLIER_STEPS[stepIndex] as number,
partySizeAdjusted,
};
}
/** All standard 5e challenge rating strings, in ascending order. */
export const VALID_CR_VALUES: readonly string[] = Object.keys(CR_TO_XP);
@@ -82,48 +168,131 @@ export function crToXp(cr: string): number {
return CR_TO_XP[cr] ?? 0;
}
/**
* Calculates encounter difficulty from party levels and monster CRs.
* Both arrays should be pre-filtered (only PCs with levels, only bestiary-linked monsters).
*/
export function calculateEncounterDifficulty(
partyLevels: readonly number[],
monsterCrs: readonly string[],
): DifficultyResult {
let budgetLow = 0;
let budgetModerate = 0;
let budgetHigh = 0;
export interface CombatantDescriptor {
readonly level?: number;
readonly cr?: string;
readonly side: "party" | "enemy";
}
for (const level of partyLevels) {
const budget = XP_BUDGET_PER_CHARACTER[level];
if (budget) {
budgetLow += budget.low;
budgetModerate += budget.moderate;
budgetHigh += budget.high;
function determineTier(
xp: number,
tierThresholds: readonly number[],
): DifficultyTier {
for (let i = tierThresholds.length - 1; i >= 0; i--) {
if (xp >= tierThresholds[i]) return (i + 1) as DifficultyTier;
}
return 0;
}
function accumulateBudget5_5e(levels: readonly number[]) {
const budget = { low: 0, moderate: 0, high: 0 };
for (const level of levels) {
const b = XP_BUDGET_PER_CHARACTER[level];
if (b) {
budget.low += b.low;
budget.moderate += b.moderate;
budget.high += b.high;
}
}
return budget;
}
function accumulateBudget2014(levels: readonly number[]) {
const budget = { easy: 0, medium: 0, hard: 0, deadly: 0 };
for (const level of levels) {
const b = XP_THRESHOLDS_2014[level];
if (b) {
budget.easy += b.easy;
budget.medium += b.medium;
budget.hard += b.hard;
budget.deadly += b.deadly;
}
}
return budget;
}
function scanCombatants(combatants: readonly CombatantDescriptor[]) {
let totalMonsterXp = 0;
let monsterCount = 0;
const partyLevels: number[] = [];
for (const c of combatants) {
if (c.level !== undefined && c.side === "party") {
partyLevels.push(c.level);
}
if (c.cr !== undefined) {
const xp = crToXp(c.cr);
if (c.side === "enemy") {
totalMonsterXp += xp;
monsterCount++;
} else {
totalMonsterXp -= xp;
}
}
}
let totalMonsterXp = 0;
for (const cr of monsterCrs) {
totalMonsterXp += crToXp(cr);
}
let tier: DifficultyTier = "trivial";
if (totalMonsterXp >= budgetHigh) {
tier = "high";
} else if (totalMonsterXp >= budgetModerate) {
tier = "moderate";
} else if (totalMonsterXp >= budgetLow) {
tier = "low";
}
return {
tier,
totalMonsterXp,
partyBudget: {
low: budgetLow,
moderate: budgetModerate,
high: budgetHigh,
},
totalMonsterXp: Math.max(0, totalMonsterXp),
monsterCount,
partyLevels,
};
}
/**
* Calculates encounter difficulty from combatant descriptors.
* Party-side combatants with level contribute to the budget.
* Enemy-side combatants with CR add XP; party-side with CR subtract XP (floored at 0).
*/
export function calculateEncounterDifficulty(
combatants: readonly CombatantDescriptor[],
edition: RulesEdition,
): DifficultyResult {
const { totalMonsterXp, monsterCount, partyLevels } =
scanCombatants(combatants);
if (edition === "5.5e") {
const budget = accumulateBudget5_5e(partyLevels);
const thresholds: DifficultyThreshold[] = [
{ label: "Low", value: budget.low },
{ label: "Moderate", value: budget.moderate },
{ label: "High", value: budget.high },
];
return {
tier: determineTier(totalMonsterXp, [
budget.low,
budget.moderate,
budget.high,
]),
totalMonsterXp,
thresholds,
encounterMultiplier: undefined,
adjustedXp: undefined,
partySizeAdjusted: undefined,
};
}
// 2014 edition
const budget = accumulateBudget2014(partyLevels);
const { multiplier: encounterMultiplier, partySizeAdjusted } =
getEncounterMultiplier(monsterCount, partyLevels.length);
const adjustedXp = Math.round(totalMonsterXp * encounterMultiplier);
const thresholds: DifficultyThreshold[] = [
{ label: "Easy", value: budget.easy },
{ label: "Medium", value: budget.medium },
{ label: "Hard", value: budget.hard },
{ label: "Deadly", value: budget.deadly },
];
return {
tier: determineTier(adjustedXp, [
budget.medium,
budget.hard,
budget.deadly,
]),
totalMonsterXp,
thresholds,
encounterMultiplier,
adjustedXp,
partySizeAdjusted,
};
}

View File

@@ -101,16 +101,25 @@ export interface CrSet {
readonly newCr: string | undefined;
}
export interface SideSet {
readonly type: "SideSet";
readonly combatantId: CombatantId;
readonly previousSide: "party" | "enemy" | undefined;
readonly newSide: "party" | "enemy";
}
export interface ConditionAdded {
readonly type: "ConditionAdded";
readonly combatantId: CombatantId;
readonly condition: ConditionId;
readonly value?: number;
}
export interface ConditionRemoved {
readonly type: "ConditionRemoved";
readonly combatantId: CombatantId;
readonly condition: ConditionId;
readonly value?: number;
}
export interface ConcentrationStarted {
@@ -161,6 +170,7 @@ export type DomainEvent =
| RoundRetreated
| AcSet
| CrSet
| SideSet
| ConditionAdded
| ConditionRemoved
| ConcentrationStarted

View File

@@ -13,10 +13,10 @@ export {
export {
CONDITION_DEFINITIONS,
type ConditionDefinition,
type ConditionEntry,
type ConditionId,
getConditionDescription,
getConditionsForEdition,
type RulesEdition,
VALID_CONDITION_IDS,
} from "./conditions.js";
export {
@@ -24,6 +24,8 @@ export {
createPlayerCharacter,
} from "./create-player-character.js";
export {
type ActivityCost,
type AnyCreature,
type BestiaryIndex,
type BestiaryIndexEntry,
type BestiarySource,
@@ -32,9 +34,15 @@ export {
creatureId,
type DailySpells,
type LegendaryBlock,
type Pf2eBestiaryIndex,
type Pf2eBestiaryIndexEntry,
type Pf2eCreature,
proficiencyBonus,
type SpellcastingBlock,
type SpellReference,
type TraitBlock,
type TraitListItem,
type TraitSegment,
} from "./creature-types.js";
export {
type DeletePlayerCharacterSuccess,
@@ -49,9 +57,11 @@ export {
editPlayerCharacter,
} from "./edit-player-character.js";
export {
type CombatantDescriptor,
calculateEncounterDifficulty,
crToXp,
type DifficultyResult,
type DifficultyThreshold,
type DifficultyTier,
VALID_CR_VALUES,
} from "./encounter-difficulty.js";
@@ -75,6 +85,7 @@ export type {
PlayerCharacterUpdated,
RoundAdvanced,
RoundRetreated,
SideSet,
TempHpSet,
TurnAdvanced,
TurnRetreated,
@@ -83,6 +94,7 @@ export type { ExportBundle } from "./export-bundle.js";
export { deriveHpStatus, type HpStatus } from "./hp-status.js";
export {
calculateInitiative,
calculatePf2eInitiative,
formatInitiativeModifier,
type InitiativeResult,
} from "./initiative.js";
@@ -108,6 +120,7 @@ export {
rollInitiative,
selectRoll,
} from "./roll-initiative.js";
export type { RulesEdition } from "./rules-edition.js";
export { type SetAcSuccess, setAc } from "./set-ac.js";
export { type SetCrSuccess, setCr } from "./set-cr.js";
export { type SetHpSuccess, setHp } from "./set-hp.js";
@@ -115,12 +128,15 @@ export {
type SetInitiativeSuccess,
setInitiative,
} from "./set-initiative.js";
export { type SetSideSuccess, setSide } from "./set-side.js";
export { type SetTempHpSuccess, setTempHp } from "./set-temp-hp.js";
export {
type ToggleConcentrationSuccess,
toggleConcentration,
} from "./toggle-concentration.js";
export {
decrementCondition,
setConditionValue,
type ToggleConditionSuccess,
toggleCondition,
} from "./toggle-condition.js";

View File

@@ -20,6 +20,14 @@ export function calculateInitiative(creature: {
return { modifier, passive: 10 + modifier };
}
/**
* Returns the PF2e initiative result directly from the Perception modifier.
* No proficiency bonus calculation — PF2e uses Perception as-is.
*/
export function calculatePf2eInitiative(perception: number): InitiativeResult {
return { modifier: perception, passive: perception };
}
/**
* Formats an initiative modifier with explicit sign.
* Uses U+2212 () for negative values.

View File

@@ -1,4 +1,4 @@
import type { ConditionId } from "./conditions.js";
import type { ConditionEntry, ConditionId } from "./conditions.js";
import { VALID_CONDITION_IDS } from "./conditions.js";
import { creatureId } from "./creature-types.js";
import { VALID_CR_VALUES } from "./encounter-difficulty.js";
@@ -16,13 +16,30 @@ function validateAc(value: unknown): number | undefined {
: undefined;
}
function validateConditions(value: unknown): ConditionId[] | undefined {
function validateConditions(value: unknown): ConditionEntry[] | undefined {
if (!Array.isArray(value)) return undefined;
const valid = value.filter(
(v): v is ConditionId =>
typeof v === "string" && VALID_CONDITION_IDS.has(v),
);
return valid.length > 0 ? valid : undefined;
const entries: ConditionEntry[] = [];
for (const item of value) {
if (typeof item === "string" && VALID_CONDITION_IDS.has(item)) {
entries.push({ id: item as ConditionId });
} else if (
typeof item === "object" &&
item !== null &&
typeof (item as Record<string, unknown>).id === "string" &&
VALID_CONDITION_IDS.has((item as Record<string, unknown>).id as string)
) {
const id = (item as Record<string, unknown>).id as ConditionId;
const rawValue = (item as Record<string, unknown>).value;
const entry: ConditionEntry =
typeof rawValue === "number" &&
Number.isInteger(rawValue) &&
rawValue > 0
? { id, value: rawValue }
: { id };
entries.push(entry);
}
}
return entries.length > 0 ? entries : undefined;
}
function validateHp(
@@ -76,6 +93,14 @@ function validateCr(value: unknown): string | undefined {
: undefined;
}
const VALID_SIDES = new Set(["party", "enemy"]);
function validateSide(value: unknown): "party" | "enemy" | undefined {
return typeof value === "string" && VALID_SIDES.has(value)
? (value as "party" | "enemy")
: undefined;
}
function parseOptionalFields(entry: Record<string, unknown>) {
return {
initiative: validateInteger(entry.initiative),
@@ -86,6 +111,7 @@ function parseOptionalFields(entry: Record<string, unknown>) {
? creatureId(entry.creatureId as string)
: undefined,
cr: validateCr(entry.cr),
side: validateSide(entry.side),
color: validateSetMember(entry.color, VALID_PLAYER_COLORS),
icon: validateSetMember(entry.icon, VALID_PLAYER_ICONS),
playerCharacterId: validateNonEmptyString(entry.playerCharacterId)

View File

@@ -0,0 +1 @@
export type RulesEdition = "5e" | "5.5e" | "pf2e";

View File

@@ -0,0 +1,54 @@
import type { DomainEvent } from "./events.js";
import {
type CombatantId,
type DomainError,
type Encounter,
findCombatant,
isDomainError,
} from "./types.js";
export interface SetSideSuccess {
readonly encounter: Encounter;
readonly events: DomainEvent[];
}
const VALID_SIDES = new Set(["party", "enemy"]);
export function setSide(
encounter: Encounter,
combatantId: CombatantId,
value: "party" | "enemy",
): SetSideSuccess | DomainError {
const found = findCombatant(encounter, combatantId);
if (isDomainError(found)) return found;
if (!VALID_SIDES.has(value)) {
return {
kind: "domain-error",
code: "invalid-side",
message: `Side must be "party" or "enemy", got "${value}"`,
};
}
const previousSide = found.combatant.side;
const updatedCombatants = encounter.combatants.map((c) =>
c.id === combatantId ? { ...c, side: value } : c,
);
return {
encounter: {
combatants: updatedCombatants,
activeIndex: encounter.activeIndex,
roundNumber: encounter.roundNumber,
},
events: [
{
type: "SideSet",
combatantId,
previousSide,
newSide: value,
},
],
};
}

View File

@@ -1,4 +1,4 @@
import type { ConditionId } from "./conditions.js";
import type { ConditionEntry, ConditionId } from "./conditions.js";
import { CONDITION_DEFINITIONS, VALID_CONDITION_IDS } from "./conditions.js";
import type { DomainEvent } from "./events.js";
import {
@@ -14,11 +14,13 @@ export interface ToggleConditionSuccess {
readonly events: DomainEvent[];
}
export function toggleCondition(
encounter: Encounter,
combatantId: CombatantId,
conditionId: ConditionId,
): ToggleConditionSuccess | DomainError {
function sortByDefinitionOrder(entries: ConditionEntry[]): ConditionEntry[] {
const order = CONDITION_DEFINITIONS.map((d) => d.id);
entries.sort((a, b) => order.indexOf(a.id) - order.indexOf(b.id));
return entries;
}
function validateConditionId(conditionId: ConditionId): DomainError | null {
if (!VALID_CONDITION_IDS.has(conditionId)) {
return {
kind: "domain-error",
@@ -26,38 +28,169 @@ export function toggleCondition(
message: `Unknown condition "${conditionId}"`,
};
}
return null;
}
function applyConditions(
encounter: Encounter,
combatantId: CombatantId,
newConditions: readonly ConditionEntry[] | undefined,
): Encounter {
return {
combatants: encounter.combatants.map((c) =>
c.id === combatantId ? { ...c, conditions: newConditions } : c,
),
activeIndex: encounter.activeIndex,
roundNumber: encounter.roundNumber,
};
}
export function toggleCondition(
encounter: Encounter,
combatantId: CombatantId,
conditionId: ConditionId,
): ToggleConditionSuccess | DomainError {
const err = validateConditionId(conditionId);
if (err) return err;
const found = findCombatant(encounter, combatantId);
if (isDomainError(found)) return found;
const { combatant: target } = found;
const current = target.conditions ?? [];
const isActive = current.includes(conditionId);
const isActive = current.some((c) => c.id === conditionId);
let newConditions: readonly ConditionId[] | undefined;
let newConditions: readonly ConditionEntry[] | undefined;
let event: DomainEvent;
if (isActive) {
const filtered = current.filter((c) => c !== conditionId);
const filtered = current.filter((c) => c.id !== conditionId);
newConditions = filtered.length > 0 ? filtered : undefined;
event = { type: "ConditionRemoved", combatantId, condition: conditionId };
} else {
const added = [...current, conditionId];
const order = CONDITION_DEFINITIONS.map((d) => d.id);
added.sort((a, b) => order.indexOf(a) - order.indexOf(b));
const added = sortByDefinitionOrder([...current, { id: conditionId }]);
newConditions = added;
event = { type: "ConditionAdded", combatantId, condition: conditionId };
}
const updatedCombatants = encounter.combatants.map((c) =>
c.id === combatantId ? { ...c, conditions: newConditions } : c,
);
return {
encounter: {
combatants: updatedCombatants,
activeIndex: encounter.activeIndex,
roundNumber: encounter.roundNumber,
},
encounter: applyConditions(encounter, combatantId, newConditions),
events: [event],
};
}
export function setConditionValue(
encounter: Encounter,
combatantId: CombatantId,
conditionId: ConditionId,
value: number,
): ToggleConditionSuccess | DomainError {
const err = validateConditionId(conditionId);
if (err) return err;
const found = findCombatant(encounter, combatantId);
if (isDomainError(found)) return found;
const { combatant: target } = found;
const current = target.conditions ?? [];
const def = CONDITION_DEFINITIONS.find((d) => d.id === conditionId);
const clampedValue =
def?.maxValue === undefined ? value : Math.min(value, def.maxValue);
if (clampedValue <= 0) {
const filtered = current.filter((c) => c.id !== conditionId);
const newConditions = filtered.length > 0 ? filtered : undefined;
return {
encounter: applyConditions(encounter, combatantId, newConditions),
events: [
{ type: "ConditionRemoved", combatantId, condition: conditionId },
],
};
}
const existing = current.find((c) => c.id === conditionId);
if (existing) {
const updated = current.map((c) =>
c.id === conditionId ? { ...c, value: clampedValue } : c,
);
return {
encounter: applyConditions(encounter, combatantId, updated),
events: [
{
type: "ConditionAdded",
combatantId,
condition: conditionId,
value: clampedValue,
},
],
};
}
const added = sortByDefinitionOrder([
...current,
{ id: conditionId, value: clampedValue },
]);
return {
encounter: applyConditions(encounter, combatantId, added),
events: [
{
type: "ConditionAdded",
combatantId,
condition: conditionId,
value: clampedValue,
},
],
};
}
export function decrementCondition(
encounter: Encounter,
combatantId: CombatantId,
conditionId: ConditionId,
): ToggleConditionSuccess | DomainError {
const err = validateConditionId(conditionId);
if (err) return err;
const found = findCombatant(encounter, combatantId);
if (isDomainError(found)) return found;
const { combatant: target } = found;
const current = target.conditions ?? [];
const existing = current.find((c) => c.id === conditionId);
if (!existing) {
return {
kind: "domain-error",
code: "condition-not-active",
message: `Condition "${conditionId}" is not active`,
};
}
const newValue = (existing.value ?? 1) - 1;
if (newValue <= 0) {
const filtered = current.filter((c) => c.id !== conditionId);
return {
encounter: applyConditions(
encounter,
combatantId,
filtered.length > 0 ? filtered : undefined,
),
events: [
{ type: "ConditionRemoved", combatantId, condition: conditionId },
],
};
}
const updated = current.map((c) =>
c.id === conditionId ? { ...c, value: newValue } : c,
);
return {
encounter: applyConditions(encounter, combatantId, updated),
events: [
{
type: "ConditionAdded",
combatantId,
condition: conditionId,
value: newValue,
},
],
};
}

View File

@@ -5,7 +5,7 @@ export function combatantId(id: string): CombatantId {
return id as CombatantId;
}
import type { ConditionId } from "./conditions.js";
import type { ConditionEntry } from "./conditions.js";
import type { CreatureId } from "./creature-types.js";
import type { PlayerCharacterId } from "./player-character-types.js";
@@ -17,10 +17,11 @@ export interface Combatant {
readonly currentHp?: number;
readonly tempHp?: number;
readonly ac?: number;
readonly conditions?: readonly ConditionId[];
readonly conditions?: readonly ConditionEntry[];
readonly isConcentrating?: boolean;
readonly creatureId?: CreatureId;
readonly cr?: string;
readonly side?: "party" | "enemy";
readonly color?: string;
readonly icon?: string;
readonly playerCharacterId?: PlayerCharacterId;

218
pnpm-lock.yaml generated
View File

@@ -17,7 +17,7 @@ importers:
version: 2.4.8
'@vitest/coverage-v8':
specifier: ^4.1.0
version: 4.1.0(vitest@4.1.0(@types/node@25.3.3)(jsdom@29.0.1)(vite@8.0.1(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3)))
version: 4.1.0(vitest@4.1.0(@types/node@25.3.3)(jsdom@29.0.1)(vite@8.0.5(@emnapi/core@1.8.1)(@emnapi/runtime@1.8.1)(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3)))
jscpd:
specifier: ^4.0.8
version: 4.0.8
@@ -41,7 +41,7 @@ importers:
version: 5.9.3
vitest:
specifier: ^4.1.0
version: 4.1.0(@types/node@25.3.3)(jsdom@29.0.1)(vite@8.0.1(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3))
version: 4.1.0(@types/node@25.3.3)(jsdom@29.0.1)(vite@8.0.5(@emnapi/core@1.8.1)(@emnapi/runtime@1.8.1)(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3))
apps/web:
dependencies:
@@ -75,7 +75,7 @@ importers:
devDependencies:
'@tailwindcss/vite':
specifier: ^4.2.2
version: 4.2.2(vite@8.0.1(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3))
version: 4.2.2(vite@8.0.5(@emnapi/core@1.8.1)(@emnapi/runtime@1.8.1)(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3))
'@testing-library/jest-dom':
specifier: ^6.9.1
version: 6.9.1
@@ -93,7 +93,7 @@ importers:
version: 19.2.3(@types/react@19.2.14)
'@vitejs/plugin-react':
specifier: ^6.0.1
version: 6.0.1(vite@8.0.1(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3))
version: 6.0.1(vite@8.0.5(@emnapi/core@1.8.1)(@emnapi/runtime@1.8.1)(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3))
jsdom:
specifier: ^29.0.1
version: 29.0.1
@@ -101,8 +101,8 @@ importers:
specifier: ^4.2.2
version: 4.2.2
vite:
specifier: ^8.0.1
version: 8.0.1(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3)
specifier: ^8.0.5
version: 8.0.5(@emnapi/core@1.8.1)(@emnapi/runtime@1.8.1)(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3)
packages/application:
dependencies:
@@ -162,6 +162,10 @@ packages:
resolution: {integrity: sha512-05WQkdpL9COIMz4LjTxGpPNCdlpyimKppYNoJ5Di5EUObifl8t4tuLuUBBZEpoLYOmfvIWrsp9fCl0HoPRVTdA==}
engines: {node: '>=6.9.0'}
'@babel/runtime@7.29.2':
resolution: {integrity: sha512-JiDShH45zKHWyGe4ZNVRrCjBz8Nh9TMmZG1kh4QTK8hCBTWBi8Da+i7s1fJw7/lYpM4ccepSNfqzZ/QvABBi5g==}
engines: {node: '>=6.9.0'}
'@babel/types@7.29.0':
resolution: {integrity: sha512-LwdZHpScM4Qz8Xw2iKSzS+cfglZzJGvofQICy7W7v4caru4EaAmyUuO6BGrbyQ2mYV11W0U8j5mBhd14dd3B0A==}
engines: {node: '>=6.9.0'}
@@ -327,6 +331,12 @@ packages:
'@napi-rs/wasm-runtime@1.1.1':
resolution: {integrity: sha512-p64ah1M1ld8xjWv3qbvFwHiFVWrq1yFvV4f7w+mzaqiR4IlSgkqhcRdHwsGgomwzBH51sRY4NEowLxnaBjcW/A==}
'@napi-rs/wasm-runtime@1.1.2':
resolution: {integrity: sha512-sNXv5oLJ7ob93xkZ1XnxisYhGYXfaG9f65/ZgYuAu3qt7b3NadcOEhLvx28hv31PgX8SZJRYrAIPQilQmFpLVw==}
peerDependencies:
'@emnapi/core': ^1.7.1
'@emnapi/runtime': ^1.7.1
'@nodelib/fs.scandir@2.1.5':
resolution: {integrity: sha512-vq24Bq3ym5HEQm2NKCr3yXDwjc7vTsEThRDnkp2DK9p1uqLR+DHurm/NOTo0KG7HYHU7eppKZj3MyqYuMBf62g==}
engines: {node: '>= 8'}
@@ -339,8 +349,8 @@ packages:
resolution: {integrity: sha512-oGB+UxlgWcgQkgwo8GcEGwemoTFt3FIO9ababBmaGwXIoBKZ+GTy0pP185beGg7Llih/NSHSV2XAs1lnznocSg==}
engines: {node: '>= 8'}
'@oxc-project/types@0.120.0':
resolution: {integrity: sha512-k1YNu55DuvAip/MGE1FTsIuU3FUCn6v/ujG9V7Nq5Df/kX2CWb13hhwD0lmJGMGqE+bE1MXvv9SZVnMzEXlWcg==}
'@oxc-project/types@0.122.0':
resolution: {integrity: sha512-oLAl5kBpV4w69UtFZ9xqcmTi+GENWOcPF7FCrczTiBbmC0ibXxCwyvZGbO39rCVEuLGAZM84DH0pUIyyv/YJzA==}
'@oxc-resolver/binding-android-arm-eabi@11.19.1':
resolution: {integrity: sha512-aUs47y+xyXHUKlbhqHUjBABjvycq6YSD7bpxSW7vplUmdzAlJ93yXY6ZR0c1o1x5A/QKbENCvs3+NlY8IpIVzg==}
@@ -602,103 +612,103 @@ packages:
cpu: [x64]
os: [win32]
'@rolldown/binding-android-arm64@1.0.0-rc.10':
resolution: {integrity: sha512-jOHxwXhxmFKuXztiu1ORieJeTbx5vrTkcOkkkn2d35726+iwhrY1w/+nYY/AGgF12thg33qC3R1LMBF5tHTZHg==}
'@rolldown/binding-android-arm64@1.0.0-rc.12':
resolution: {integrity: sha512-pv1y2Fv0JybcykuiiD3qBOBdz6RteYojRFY1d+b95WVuzx211CRh+ytI/+9iVyWQ6koTh5dawe4S/yRfOFjgaA==}
engines: {node: ^20.19.0 || >=22.12.0}
cpu: [arm64]
os: [android]
'@rolldown/binding-darwin-arm64@1.0.0-rc.10':
resolution: {integrity: sha512-gED05Teg/vtTZbIJBc4VNMAxAFDUPkuO/rAIyyxZjTj1a1/s6z5TII/5yMGZ0uLRCifEtwUQn8OlYzuYc0m70w==}
'@rolldown/binding-darwin-arm64@1.0.0-rc.12':
resolution: {integrity: sha512-cFYr6zTG/3PXXF3pUO+umXxt1wkRK/0AYT8lDwuqvRC+LuKYWSAQAQZjCWDQpAH172ZV6ieYrNnFzVVcnSflAg==}
engines: {node: ^20.19.0 || >=22.12.0}
cpu: [arm64]
os: [darwin]
'@rolldown/binding-darwin-x64@1.0.0-rc.10':
resolution: {integrity: sha512-rI15NcM1mA48lqrIxVkHfAqcyFLcQwyXWThy+BQ5+mkKKPvSO26ir+ZDp36AgYoYVkqvMcdS8zOE6SeBsR9e8A==}
'@rolldown/binding-darwin-x64@1.0.0-rc.12':
resolution: {integrity: sha512-ZCsYknnHzeXYps0lGBz8JrF37GpE9bFVefrlmDrAQhOEi4IOIlcoU1+FwHEtyXGx2VkYAvhu7dyBf75EJQffBw==}
engines: {node: ^20.19.0 || >=22.12.0}
cpu: [x64]
os: [darwin]
'@rolldown/binding-freebsd-x64@1.0.0-rc.10':
resolution: {integrity: sha512-XZRXHdTa+4ME1MuDVp021+doQ+z6Ei4CCFmNc5/sKbqb8YmkiJdj8QKlV3rCI0AJtAeSB5n0WGPuJWNL9p/L2w==}
'@rolldown/binding-freebsd-x64@1.0.0-rc.12':
resolution: {integrity: sha512-dMLeprcVsyJsKolRXyoTH3NL6qtsT0Y2xeuEA8WQJquWFXkEC4bcu1rLZZSnZRMtAqwtrF/Ib9Ddtpa/Gkge9Q==}
engines: {node: ^20.19.0 || >=22.12.0}
cpu: [x64]
os: [freebsd]
'@rolldown/binding-linux-arm-gnueabihf@1.0.0-rc.10':
resolution: {integrity: sha512-R0SQMRluISSLzFE20sPWYHVmJdDQnRyc/FzSCN72BqQmh2SOZUFG+N3/vBZpR4C6WpEUVYJLrYUXaj43sJsNLA==}
'@rolldown/binding-linux-arm-gnueabihf@1.0.0-rc.12':
resolution: {integrity: sha512-YqWjAgGC/9M1lz3GR1r1rP79nMgo3mQiiA+Hfo+pvKFK1fAJ1bCi0ZQVh8noOqNacuY1qIcfyVfP6HoyBRZ85Q==}
engines: {node: ^20.19.0 || >=22.12.0}
cpu: [arm]
os: [linux]
'@rolldown/binding-linux-arm64-gnu@1.0.0-rc.10':
resolution: {integrity: sha512-Y1reMrV/o+cwpduYhJuOE3OMKx32RMYCidf14y+HssARRmhDuWXJ4yVguDg2R/8SyyGNo+auzz64LnPK9Hq6jg==}
'@rolldown/binding-linux-arm64-gnu@1.0.0-rc.12':
resolution: {integrity: sha512-/I5AS4cIroLpslsmzXfwbe5OmWvSsrFuEw3mwvbQ1kDxJ822hFHIx+vsN/TAzNVyepI/j/GSzrtCIwQPeKCLIg==}
engines: {node: ^20.19.0 || >=22.12.0}
cpu: [arm64]
os: [linux]
libc: [glibc]
'@rolldown/binding-linux-arm64-musl@1.0.0-rc.10':
resolution: {integrity: sha512-vELN+HNb2IzuzSBUOD4NHmP9yrGwl1DVM29wlQvx1OLSclL0NgVWnVDKl/8tEks79EFek/kebQKnNJkIAA4W2g==}
'@rolldown/binding-linux-arm64-musl@1.0.0-rc.12':
resolution: {integrity: sha512-V6/wZztnBqlx5hJQqNWwFdxIKN0m38p8Jas+VoSfgH54HSj9tKTt1dZvG6JRHcjh6D7TvrJPWFGaY9UBVOaWPw==}
engines: {node: ^20.19.0 || >=22.12.0}
cpu: [arm64]
os: [linux]
libc: [musl]
'@rolldown/binding-linux-ppc64-gnu@1.0.0-rc.10':
resolution: {integrity: sha512-ZqrufYTgzxbHwpqOjzSsb0UV/aV2TFIY5rP8HdsiPTv/CuAgCRjM6s9cYFwQ4CNH+hf9Y4erHW1GjZuZ7WoI7w==}
'@rolldown/binding-linux-ppc64-gnu@1.0.0-rc.12':
resolution: {integrity: sha512-AP3E9BpcUYliZCxa3w5Kwj9OtEVDYK6sVoUzy4vTOJsjPOgdaJZKFmN4oOlX0Wp0RPV2ETfmIra9x1xuayFB7g==}
engines: {node: ^20.19.0 || >=22.12.0}
cpu: [ppc64]
os: [linux]
libc: [glibc]
'@rolldown/binding-linux-s390x-gnu@1.0.0-rc.10':
resolution: {integrity: sha512-gSlmVS1FZJSRicA6IyjoRoKAFK7IIHBs7xJuHRSmjImqk3mPPWbR7RhbnfH2G6bcmMEllCt2vQ/7u9e6bBnByg==}
'@rolldown/binding-linux-s390x-gnu@1.0.0-rc.12':
resolution: {integrity: sha512-nWwpvUSPkoFmZo0kQazZYOrT7J5DGOJ/+QHHzjvNlooDZED8oH82Yg67HvehPPLAg5fUff7TfWFHQS8IV1n3og==}
engines: {node: ^20.19.0 || >=22.12.0}
cpu: [s390x]
os: [linux]
libc: [glibc]
'@rolldown/binding-linux-x64-gnu@1.0.0-rc.10':
resolution: {integrity: sha512-eOCKUpluKgfObT2pHjztnaWEIbUabWzk3qPZ5PuacuPmr4+JtQG4k2vGTY0H15edaTnicgU428XW/IH6AimcQw==}
'@rolldown/binding-linux-x64-gnu@1.0.0-rc.12':
resolution: {integrity: sha512-RNrafz5bcwRy+O9e6P8Z/OCAJW/A+qtBczIqVYwTs14pf4iV1/+eKEjdOUta93q2TsT/FI0XYDP3TCky38LMAg==}
engines: {node: ^20.19.0 || >=22.12.0}
cpu: [x64]
os: [linux]
libc: [glibc]
'@rolldown/binding-linux-x64-musl@1.0.0-rc.10':
resolution: {integrity: sha512-Xdf2jQbfQowJnLcgYfD/m0Uu0Qj5OdxKallD78/IPPfzaiaI4KRAwZzHcKQ4ig1gtg1SuzC7jovNiM2TzQsBXA==}
'@rolldown/binding-linux-x64-musl@1.0.0-rc.12':
resolution: {integrity: sha512-Jpw/0iwoKWx3LJ2rc1yjFrj+T7iHZn2JDg1Yny1ma0luviFS4mhAIcd1LFNxK3EYu3DHWCps0ydXQ5i/rrJ2ig==}
engines: {node: ^20.19.0 || >=22.12.0}
cpu: [x64]
os: [linux]
libc: [musl]
'@rolldown/binding-openharmony-arm64@1.0.0-rc.10':
resolution: {integrity: sha512-o1hYe8hLi1EY6jgPFyxQgQ1wcycX+qz8eEbVmot2hFkgUzPxy9+kF0u0NIQBeDq+Mko47AkaFFaChcvZa9UX9Q==}
'@rolldown/binding-openharmony-arm64@1.0.0-rc.12':
resolution: {integrity: sha512-vRugONE4yMfVn0+7lUKdKvN4D5YusEiPilaoO2sgUWpCvrncvWgPMzK00ZFFJuiPgLwgFNP5eSiUlv2tfc+lpA==}
engines: {node: ^20.19.0 || >=22.12.0}
cpu: [arm64]
os: [openharmony]
'@rolldown/binding-wasm32-wasi@1.0.0-rc.10':
resolution: {integrity: sha512-Ugv9o7qYJudqQO5Y5y2N2SOo6S4WiqiNOpuQyoPInnhVzCY+wi/GHltcLHypG9DEUYMB0iTB/huJrpadiAcNcA==}
'@rolldown/binding-wasm32-wasi@1.0.0-rc.12':
resolution: {integrity: sha512-ykGiLr/6kkiHc0XnBfmFJuCjr5ZYKKofkx+chJWDjitX+KsJuAmrzWhwyOMSHzPhzOHOy7u9HlFoa5MoAOJ/Zg==}
engines: {node: '>=14.0.0'}
cpu: [wasm32]
'@rolldown/binding-win32-arm64-msvc@1.0.0-rc.10':
resolution: {integrity: sha512-7UODQb4fQUNT/vmgDZBl3XOBAIOutP5R3O/rkxg0aLfEGQ4opbCgU5vOw/scPe4xOqBwL9fw7/RP1vAMZ6QlAQ==}
'@rolldown/binding-win32-arm64-msvc@1.0.0-rc.12':
resolution: {integrity: sha512-5eOND4duWkwx1AzCxadcOrNeighiLwMInEADT0YM7xeEOOFcovWZCq8dadXgcRHSf3Ulh1kFo/qvzoFiCLOL1Q==}
engines: {node: ^20.19.0 || >=22.12.0}
cpu: [arm64]
os: [win32]
'@rolldown/binding-win32-x64-msvc@1.0.0-rc.10':
resolution: {integrity: sha512-PYxKHMVHOb5NJuDL53vBUl1VwUjymDcYI6rzpIni0C9+9mTiJedvUxSk7/RPp7OOAm3v+EjgMu9bIy3N6b408w==}
'@rolldown/binding-win32-x64-msvc@1.0.0-rc.12':
resolution: {integrity: sha512-PyqoipaswDLAZtot351MLhrlrh6lcZPo2LSYE+VDxbVk24LVKAGOuE4hb8xZQmrPAuEtTZW8E6D2zc5EUZX4Lw==}
engines: {node: ^20.19.0 || >=22.12.0}
cpu: [x64]
os: [win32]
'@rolldown/pluginutils@1.0.0-rc.10':
resolution: {integrity: sha512-UkVDEFk1w3mveXeKgaTuYfKWtPbvgck1dT8TUG3bnccrH0XtLTuAyfCoks4Q/M5ZGToSVJTIQYCzy2g/atAOeg==}
'@rolldown/pluginutils@1.0.0-rc.12':
resolution: {integrity: sha512-HHMwmarRKvoFsJorqYlFeFRzXZqCt2ETQlEDOb9aqssrnVBB1/+xgTGtuTrIk5vzLNX1MjMtTf7W9z3tsSbrxw==}
'@rolldown/pluginutils@1.0.0-rc.7':
resolution: {integrity: sha512-qujRfC8sFVInYSPPMLQByRh7zhwkGFS4+tyMQ83srV1qrxL4g8E2tyxVVyxd0+8QeBM1mIk9KbWxkegRr76XzA==}
@@ -1657,8 +1667,8 @@ packages:
resolution: {integrity: sha512-g6QUff04oZpHs0eG5p83rFLhHeV00ug/Yf9nZM6fLeUrPguBTkTQOdpAWWspMh55TZfVQDPaN3NQJfbVRAxdIw==}
engines: {iojs: '>=1.0.0', node: '>=0.10.0'}
rolldown@1.0.0-rc.10:
resolution: {integrity: sha512-q7j6vvarRFmKpgJUT8HCAUljkgzEp4LAhPlJUvQhA5LA1SUL36s5QCysMutErzL3EbNOZOkoziSx9iZC4FddKA==}
rolldown@1.0.0-rc.12:
resolution: {integrity: sha512-yP4USLIMYrwpPHEFB5JGH1uxhcslv6/hL0OyvTuY+3qlOSJvZ7ntYnoWpehBxufkgN0cvXxppuTu5hHa/zPh+A==}
engines: {node: ^20.19.0 || >=22.12.0}
hasBin: true
@@ -1821,14 +1831,14 @@ packages:
resolution: {integrity: sha512-gptHNQghINnc/vTGIk0SOFGFNXw7JVrlRUtConJRlvaw6DuX0wO5Jeko9sWrMBhh+PsYAZ7oXAiOnf/UKogyiw==}
engines: {node: '>= 10.0.0'}
vite@8.0.1:
resolution: {integrity: sha512-wt+Z2qIhfFt85uiyRt5LPU4oVEJBXj8hZNWKeqFG4gRG/0RaRGJ7njQCwzFVjO+v4+Ipmf5CY7VdmZRAYYBPHw==}
vite@8.0.5:
resolution: {integrity: sha512-nmu43Qvq9UopTRfMx2jOYW5l16pb3iDC1JH6yMuPkpVbzK0k+L7dfsEDH4jRgYFmsg0sTAqkojoZgzLMlwHsCQ==}
engines: {node: ^20.19.0 || >=22.12.0}
hasBin: true
peerDependencies:
'@types/node': ^20.19.0 || >=22.12.0
'@vitejs/devtools': ^0.1.0
esbuild: ^0.27.0
esbuild: ^0.27.0 || ^0.28.0
jiti: '>=1.21.0'
less: ^4.0.0
sass: ^1.70.0
@@ -2001,6 +2011,8 @@ snapshots:
'@babel/runtime@7.28.6': {}
'@babel/runtime@7.29.2': {}
'@babel/types@7.29.0':
dependencies:
'@babel/helper-string-parser': 7.27.1
@@ -2158,6 +2170,13 @@ snapshots:
'@tybys/wasm-util': 0.10.1
optional: true
'@napi-rs/wasm-runtime@1.1.2(@emnapi/core@1.8.1)(@emnapi/runtime@1.8.1)':
dependencies:
'@emnapi/core': 1.8.1
'@emnapi/runtime': 1.8.1
'@tybys/wasm-util': 0.10.1
optional: true
'@nodelib/fs.scandir@2.1.5':
dependencies:
'@nodelib/fs.stat': 2.0.5
@@ -2170,7 +2189,7 @@ snapshots:
'@nodelib/fs.scandir': 2.1.5
fastq: 1.20.1
'@oxc-project/types@0.120.0': {}
'@oxc-project/types@0.122.0': {}
'@oxc-resolver/binding-android-arm-eabi@11.19.1':
optional: true
@@ -2309,54 +2328,57 @@ snapshots:
'@oxlint/binding-win32-x64-msvc@1.56.0':
optional: true
'@rolldown/binding-android-arm64@1.0.0-rc.10':
'@rolldown/binding-android-arm64@1.0.0-rc.12':
optional: true
'@rolldown/binding-darwin-arm64@1.0.0-rc.10':
'@rolldown/binding-darwin-arm64@1.0.0-rc.12':
optional: true
'@rolldown/binding-darwin-x64@1.0.0-rc.10':
'@rolldown/binding-darwin-x64@1.0.0-rc.12':
optional: true
'@rolldown/binding-freebsd-x64@1.0.0-rc.10':
'@rolldown/binding-freebsd-x64@1.0.0-rc.12':
optional: true
'@rolldown/binding-linux-arm-gnueabihf@1.0.0-rc.10':
'@rolldown/binding-linux-arm-gnueabihf@1.0.0-rc.12':
optional: true
'@rolldown/binding-linux-arm64-gnu@1.0.0-rc.10':
'@rolldown/binding-linux-arm64-gnu@1.0.0-rc.12':
optional: true
'@rolldown/binding-linux-arm64-musl@1.0.0-rc.10':
'@rolldown/binding-linux-arm64-musl@1.0.0-rc.12':
optional: true
'@rolldown/binding-linux-ppc64-gnu@1.0.0-rc.10':
'@rolldown/binding-linux-ppc64-gnu@1.0.0-rc.12':
optional: true
'@rolldown/binding-linux-s390x-gnu@1.0.0-rc.10':
'@rolldown/binding-linux-s390x-gnu@1.0.0-rc.12':
optional: true
'@rolldown/binding-linux-x64-gnu@1.0.0-rc.10':
'@rolldown/binding-linux-x64-gnu@1.0.0-rc.12':
optional: true
'@rolldown/binding-linux-x64-musl@1.0.0-rc.10':
'@rolldown/binding-linux-x64-musl@1.0.0-rc.12':
optional: true
'@rolldown/binding-openharmony-arm64@1.0.0-rc.10':
'@rolldown/binding-openharmony-arm64@1.0.0-rc.12':
optional: true
'@rolldown/binding-wasm32-wasi@1.0.0-rc.10':
'@rolldown/binding-wasm32-wasi@1.0.0-rc.12(@emnapi/core@1.8.1)(@emnapi/runtime@1.8.1)':
dependencies:
'@napi-rs/wasm-runtime': 1.1.1
'@napi-rs/wasm-runtime': 1.1.2(@emnapi/core@1.8.1)(@emnapi/runtime@1.8.1)
transitivePeerDependencies:
- '@emnapi/core'
- '@emnapi/runtime'
optional: true
'@rolldown/binding-win32-arm64-msvc@1.0.0-rc.10':
'@rolldown/binding-win32-arm64-msvc@1.0.0-rc.12':
optional: true
'@rolldown/binding-win32-x64-msvc@1.0.0-rc.10':
'@rolldown/binding-win32-x64-msvc@1.0.0-rc.12':
optional: true
'@rolldown/pluginutils@1.0.0-rc.10': {}
'@rolldown/pluginutils@1.0.0-rc.12': {}
'@rolldown/pluginutils@1.0.0-rc.7': {}
@@ -2423,17 +2445,17 @@ snapshots:
'@tailwindcss/oxide-win32-arm64-msvc': 4.2.2
'@tailwindcss/oxide-win32-x64-msvc': 4.2.2
'@tailwindcss/vite@4.2.2(vite@8.0.1(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3))':
'@tailwindcss/vite@4.2.2(vite@8.0.5(@emnapi/core@1.8.1)(@emnapi/runtime@1.8.1)(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3))':
dependencies:
'@tailwindcss/node': 4.2.2
'@tailwindcss/oxide': 4.2.2
tailwindcss: 4.2.2
vite: 8.0.1(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3)
vite: 8.0.5(@emnapi/core@1.8.1)(@emnapi/runtime@1.8.1)(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3)
'@testing-library/dom@10.4.1':
dependencies:
'@babel/code-frame': 7.29.0
'@babel/runtime': 7.28.6
'@babel/runtime': 7.29.2
'@types/aria-query': 5.0.4
aria-query: 5.3.0
dom-accessibility-api: 0.5.16
@@ -2494,12 +2516,12 @@ snapshots:
'@types/sarif@2.1.7': {}
'@vitejs/plugin-react@6.0.1(vite@8.0.1(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3))':
'@vitejs/plugin-react@6.0.1(vite@8.0.5(@emnapi/core@1.8.1)(@emnapi/runtime@1.8.1)(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3))':
dependencies:
'@rolldown/pluginutils': 1.0.0-rc.7
vite: 8.0.1(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3)
vite: 8.0.5(@emnapi/core@1.8.1)(@emnapi/runtime@1.8.1)(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3)
'@vitest/coverage-v8@4.1.0(vitest@4.1.0(@types/node@25.3.3)(jsdom@29.0.1)(vite@8.0.1(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3)))':
'@vitest/coverage-v8@4.1.0(vitest@4.1.0(@types/node@25.3.3)(jsdom@29.0.1)(vite@8.0.5(@emnapi/core@1.8.1)(@emnapi/runtime@1.8.1)(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3)))':
dependencies:
'@bcoe/v8-coverage': 1.0.2
'@vitest/utils': 4.1.0
@@ -2511,7 +2533,7 @@ snapshots:
obug: 2.1.1
std-env: 4.0.0
tinyrainbow: 3.1.0
vitest: 4.1.0(@types/node@25.3.3)(jsdom@29.0.1)(vite@8.0.1(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3))
vitest: 4.1.0(@types/node@25.3.3)(jsdom@29.0.1)(vite@8.0.5(@emnapi/core@1.8.1)(@emnapi/runtime@1.8.1)(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3))
'@vitest/expect@4.1.0':
dependencies:
@@ -2522,13 +2544,13 @@ snapshots:
chai: 6.2.2
tinyrainbow: 3.1.0
'@vitest/mocker@4.1.0(vite@8.0.1(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3))':
'@vitest/mocker@4.1.0(vite@8.0.5(@emnapi/core@1.8.1)(@emnapi/runtime@1.8.1)(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3))':
dependencies:
'@vitest/spy': 4.1.0
estree-walker: 3.0.3
magic-string: 0.30.21
optionalDependencies:
vite: 8.0.1(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3)
vite: 8.0.5(@emnapi/core@1.8.1)(@emnapi/runtime@1.8.1)(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3)
'@vitest/pretty-format@4.1.0':
dependencies:
@@ -3330,26 +3352,29 @@ snapshots:
reusify@1.1.0: {}
rolldown@1.0.0-rc.10:
rolldown@1.0.0-rc.12(@emnapi/core@1.8.1)(@emnapi/runtime@1.8.1):
dependencies:
'@oxc-project/types': 0.120.0
'@rolldown/pluginutils': 1.0.0-rc.10
'@oxc-project/types': 0.122.0
'@rolldown/pluginutils': 1.0.0-rc.12
optionalDependencies:
'@rolldown/binding-android-arm64': 1.0.0-rc.10
'@rolldown/binding-darwin-arm64': 1.0.0-rc.10
'@rolldown/binding-darwin-x64': 1.0.0-rc.10
'@rolldown/binding-freebsd-x64': 1.0.0-rc.10
'@rolldown/binding-linux-arm-gnueabihf': 1.0.0-rc.10
'@rolldown/binding-linux-arm64-gnu': 1.0.0-rc.10
'@rolldown/binding-linux-arm64-musl': 1.0.0-rc.10
'@rolldown/binding-linux-ppc64-gnu': 1.0.0-rc.10
'@rolldown/binding-linux-s390x-gnu': 1.0.0-rc.10
'@rolldown/binding-linux-x64-gnu': 1.0.0-rc.10
'@rolldown/binding-linux-x64-musl': 1.0.0-rc.10
'@rolldown/binding-openharmony-arm64': 1.0.0-rc.10
'@rolldown/binding-wasm32-wasi': 1.0.0-rc.10
'@rolldown/binding-win32-arm64-msvc': 1.0.0-rc.10
'@rolldown/binding-win32-x64-msvc': 1.0.0-rc.10
'@rolldown/binding-android-arm64': 1.0.0-rc.12
'@rolldown/binding-darwin-arm64': 1.0.0-rc.12
'@rolldown/binding-darwin-x64': 1.0.0-rc.12
'@rolldown/binding-freebsd-x64': 1.0.0-rc.12
'@rolldown/binding-linux-arm-gnueabihf': 1.0.0-rc.12
'@rolldown/binding-linux-arm64-gnu': 1.0.0-rc.12
'@rolldown/binding-linux-arm64-musl': 1.0.0-rc.12
'@rolldown/binding-linux-ppc64-gnu': 1.0.0-rc.12
'@rolldown/binding-linux-s390x-gnu': 1.0.0-rc.12
'@rolldown/binding-linux-x64-gnu': 1.0.0-rc.12
'@rolldown/binding-linux-x64-musl': 1.0.0-rc.12
'@rolldown/binding-openharmony-arm64': 1.0.0-rc.12
'@rolldown/binding-wasm32-wasi': 1.0.0-rc.12(@emnapi/core@1.8.1)(@emnapi/runtime@1.8.1)
'@rolldown/binding-win32-arm64-msvc': 1.0.0-rc.12
'@rolldown/binding-win32-x64-msvc': 1.0.0-rc.12
transitivePeerDependencies:
- '@emnapi/core'
- '@emnapi/runtime'
run-parallel@1.2.0:
dependencies:
@@ -3467,23 +3492,26 @@ snapshots:
universalify@2.0.1: {}
vite@8.0.1(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3):
vite@8.0.5(@emnapi/core@1.8.1)(@emnapi/runtime@1.8.1)(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3):
dependencies:
lightningcss: 1.32.0
picomatch: 4.0.4
postcss: 8.5.8
rolldown: 1.0.0-rc.10
rolldown: 1.0.0-rc.12(@emnapi/core@1.8.1)(@emnapi/runtime@1.8.1)
tinyglobby: 0.2.15
optionalDependencies:
'@types/node': 25.3.3
fsevents: 2.3.3
jiti: 2.6.1
yaml: 2.8.3
transitivePeerDependencies:
- '@emnapi/core'
- '@emnapi/runtime'
vitest@4.1.0(@types/node@25.3.3)(jsdom@29.0.1)(vite@8.0.1(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3)):
vitest@4.1.0(@types/node@25.3.3)(jsdom@29.0.1)(vite@8.0.5(@emnapi/core@1.8.1)(@emnapi/runtime@1.8.1)(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3)):
dependencies:
'@vitest/expect': 4.1.0
'@vitest/mocker': 4.1.0(vite@8.0.1(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3))
'@vitest/mocker': 4.1.0(vite@8.0.5(@emnapi/core@1.8.1)(@emnapi/runtime@1.8.1)(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3))
'@vitest/pretty-format': 4.1.0
'@vitest/runner': 4.1.0
'@vitest/snapshot': 4.1.0
@@ -3500,7 +3528,7 @@ snapshots:
tinyexec: 1.0.4
tinyglobby: 0.2.15
tinyrainbow: 3.1.0
vite: 8.0.1(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3)
vite: 8.0.5(@emnapi/core@1.8.1)(@emnapi/runtime@1.8.1)(@types/node@25.3.3)(jiti@2.6.1)(yaml@2.8.3)
why-is-node-running: 2.3.0
optionalDependencies:
'@types/node': 25.3.3

View File

@@ -1,29 +1,14 @@
/**
* Backpressure check for biome-ignore comments.
* Zero-tolerance check for biome-ignore comments.
*
* 1. Ratcheting cap — source and test files have separate max counts.
* Lower these numbers as you fix ignores; they can never go up silently.
* 2. Banned rules — ignoring certain rule categories is never allowed.
* 3. Justification — every ignore must have a non-empty explanation after
* the rule name.
* Any `biome-ignore` in tracked .ts/.tsx files fails the build.
* Fix the underlying issue instead of suppressing the rule.
*/
import { execSync } from "node:child_process";
import { readFileSync } from "node:fs";
// ── Configuration ──────────────────────────────────────────────────────
const MAX_SOURCE_IGNORES = 2;
const MAX_TEST_IGNORES = 3;
/** Rule prefixes that must never be suppressed. */
const BANNED_PREFIXES = [
"lint/security/",
"lint/correctness/noGlobalObjectCalls",
"lint/correctness/noUnsafeFinally",
];
// ───────────────────────────────────────────────────────────────────────
const IGNORE_PATTERN = /biome-ignore\s+([\w/]+)(?::\s*(.*))?/;
const IGNORE_PATTERN = /biome-ignore\s+([\w/]+)/;
function findFiles() {
return execSync("git ls-files -- '*.ts' '*.tsx'", { encoding: "utf-8" })
@@ -32,17 +17,7 @@ function findFiles() {
.filter(Boolean);
}
function isTestFile(path) {
return (
path.includes("__tests__/") ||
path.endsWith(".test.ts") ||
path.endsWith(".test.tsx")
);
}
let errors = 0;
let sourceCount = 0;
let testCount = 0;
let count = 0;
for (const file of findFiles()) {
const lines = readFileSync(file, "utf-8").split("\n");
@@ -51,58 +26,16 @@ for (const file of findFiles()) {
const match = lines[i].match(IGNORE_PATTERN);
if (!match) continue;
const rule = match[1];
const justification = (match[2] ?? "").trim();
const loc = `${file}:${i + 1}`;
// Count by category
if (isTestFile(file)) {
testCount++;
} else {
sourceCount++;
}
// Banned rules
for (const prefix of BANNED_PREFIXES) {
if (rule.startsWith(prefix)) {
console.error(`BANNED: ${loc}${rule} must not be suppressed`);
errors++;
}
}
// Justification required
if (!justification) {
console.error(
`MISSING JUSTIFICATION: ${loc} — biome-ignore ${rule} needs an explanation after the colon`,
);
errors++;
}
count++;
console.error(`FORBIDDEN: ${file}:${i + 1} — biome-ignore ${match[1]}`);
}
}
// Ratcheting caps
if (sourceCount > MAX_SOURCE_IGNORES) {
if (count > 0) {
console.error(
`SOURCE CAP EXCEEDED: ${sourceCount} biome-ignore comments in source (max ${MAX_SOURCE_IGNORES}). Fix issues and lower the cap.`,
`\n${count} biome-ignore comment(s) found. Fix the issue or restructure the code.`,
);
errors++;
}
if (testCount > MAX_TEST_IGNORES) {
console.error(
`TEST CAP EXCEEDED: ${testCount} biome-ignore comments in tests (max ${MAX_TEST_IGNORES}). Fix issues and lower the cap.`,
);
errors++;
}
// Summary
console.log(
`biome-ignore: ${sourceCount} source (max ${MAX_SOURCE_IGNORES}), ${testCount} test (max ${MAX_TEST_IGNORES})`,
);
if (errors > 0) {
console.error(`\n${errors} problem(s) found.`);
process.exit(1);
} else {
console.log("All checks passed.");
console.log("biome-ignore: 0 — all clear.");
}

Some files were not shown because too many files have changed in this diff Show More