Compare commits
13 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
e161645228 | ||
|
|
9b0cb38897 | ||
|
|
5cb5721a6f | ||
|
|
48795071f7 | ||
|
|
f721d7e5da | ||
|
|
e7930a1431 | ||
|
|
553e09f280 | ||
|
|
1c107a500b | ||
|
|
0c235112ee | ||
|
|
57278e0c82 | ||
|
|
f9cfaa2570 | ||
|
|
3e62e54274 | ||
|
|
12a089dfd7 |
@@ -1,7 +1,6 @@
|
|||||||
---
|
---
|
||||||
name: commit
|
name: commit
|
||||||
description: Create a git commit with pre-commit hooks (bypasses sandbox restrictions).
|
description: Create a git commit with pre-commit hooks (bypasses sandbox restrictions).
|
||||||
disable-model-invocation: true
|
|
||||||
allowed-tools: Bash(git *), Bash(pnpm *)
|
allowed-tools: Bash(git *), Bash(pnpm *)
|
||||||
---
|
---
|
||||||
|
|
||||||
|
|||||||
54
.claude/skills/ship/SKILL.md
Normal file
54
.claude/skills/ship/SKILL.md
Normal file
@@ -0,0 +1,54 @@
|
|||||||
|
---
|
||||||
|
name: ship
|
||||||
|
description: Commit, tag with the next version, and push to remote.
|
||||||
|
disable-model-invocation: true
|
||||||
|
allowed-tools: Bash(git *), Bash(pnpm *), Skill
|
||||||
|
---
|
||||||
|
|
||||||
|
## Instructions
|
||||||
|
|
||||||
|
Commit current changes, create the next version tag, and push everything to remote.
|
||||||
|
|
||||||
|
### Step 1 — Commit
|
||||||
|
|
||||||
|
Use the `/commit` skill to stage and commit changes. Pass along any user arguments as the commit message.
|
||||||
|
|
||||||
|
```
|
||||||
|
/commit $ARGUMENTS
|
||||||
|
```
|
||||||
|
|
||||||
|
### Step 2 — Tag
|
||||||
|
|
||||||
|
Get the latest tag and increment the patch number (e.g., `0.9.27` → `0.9.28`). Create the tag:
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git tag --sort=-v:refname | head -1
|
||||||
|
```
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git tag <next-version>
|
||||||
|
```
|
||||||
|
|
||||||
|
### Step 3 — Push
|
||||||
|
|
||||||
|
Push the commit and tag to remote:
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git push && git push --tags
|
||||||
|
```
|
||||||
|
|
||||||
|
### Step 4 — Verify
|
||||||
|
|
||||||
|
Confirm the tag exists on the pushed commit:
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git log --oneline -1 --decorate
|
||||||
|
```
|
||||||
|
|
||||||
|
## User arguments
|
||||||
|
|
||||||
|
```text
|
||||||
|
$ARGUMENTS
|
||||||
|
```
|
||||||
|
|
||||||
|
If the user provided arguments, treat them as the commit message or guidance for what to commit.
|
||||||
@@ -115,6 +115,7 @@ export function createTestAdapters(options?: {
|
|||||||
getDefaultFetchUrl: (sourceCode) =>
|
getDefaultFetchUrl: (sourceCode) =>
|
||||||
`https://example.com/creatures-${sourceCode.toLowerCase()}.json`,
|
`https://example.com/creatures-${sourceCode.toLowerCase()}.json`,
|
||||||
getSourceDisplayName: (sourceCode) => sourceCode,
|
getSourceDisplayName: (sourceCode) => sourceCode,
|
||||||
|
getCreaturePathsForSource: () => [],
|
||||||
},
|
},
|
||||||
};
|
};
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -33,8 +33,7 @@ async function addCombatant(
|
|||||||
opts?: { maxHp?: string },
|
opts?: { maxHp?: string },
|
||||||
) {
|
) {
|
||||||
const inputs = screen.getAllByPlaceholderText("+ Add combatants");
|
const inputs = screen.getAllByPlaceholderText("+ Add combatants");
|
||||||
// biome-ignore lint/style/noNonNullAssertion: getAllBy always returns at least one
|
const input = inputs.at(-1) ?? inputs[0];
|
||||||
const input = inputs.at(-1)!;
|
|
||||||
await user.type(input, name);
|
await user.type(input, name);
|
||||||
|
|
||||||
if (opts?.maxHp) {
|
if (opts?.maxHp) {
|
||||||
|
|||||||
@@ -198,21 +198,23 @@ describe("ConfirmButton", () => {
|
|||||||
|
|
||||||
it("Enter/Space keydown stops propagation to prevent parent handlers", () => {
|
it("Enter/Space keydown stops propagation to prevent parent handlers", () => {
|
||||||
const parentHandler = vi.fn();
|
const parentHandler = vi.fn();
|
||||||
render(
|
function Wrapper() {
|
||||||
// biome-ignore lint/a11y/noStaticElementInteractions: test wrapper
|
return (
|
||||||
// biome-ignore lint/a11y/noNoninteractiveElementInteractions: test wrapper
|
<button type="button" onKeyDown={parentHandler}>
|
||||||
<div onKeyDown={parentHandler}>
|
<ConfirmButton
|
||||||
<ConfirmButton
|
icon={<XIcon />}
|
||||||
icon={<XIcon />}
|
label="Remove combatant"
|
||||||
label="Remove combatant"
|
onConfirm={vi.fn()}
|
||||||
onConfirm={vi.fn()}
|
/>
|
||||||
/>
|
</button>
|
||||||
</div>,
|
);
|
||||||
);
|
}
|
||||||
const button = screen.getByRole("button");
|
render(<Wrapper />);
|
||||||
|
const buttons = screen.getAllByRole("button");
|
||||||
|
const confirmButton = buttons.at(-1) ?? buttons[0];
|
||||||
|
|
||||||
fireEvent.keyDown(button, { key: "Enter" });
|
fireEvent.keyDown(confirmButton, { key: "Enter" });
|
||||||
fireEvent.keyDown(button, { key: " " });
|
fireEvent.keyDown(confirmButton, { key: " " });
|
||||||
|
|
||||||
expect(parentHandler).not.toHaveBeenCalled();
|
expect(parentHandler).not.toHaveBeenCalled();
|
||||||
});
|
});
|
||||||
|
|||||||
@@ -181,17 +181,20 @@ describe("normalizeBestiary", () => {
|
|||||||
expect(sc?.name).toBe("Spellcasting");
|
expect(sc?.name).toBe("Spellcasting");
|
||||||
expect(sc?.headerText).toContain("DC 15");
|
expect(sc?.headerText).toContain("DC 15");
|
||||||
expect(sc?.headerText).not.toContain("{@");
|
expect(sc?.headerText).not.toContain("{@");
|
||||||
expect(sc?.atWill).toEqual(["Detect Magic", "Mage Hand"]);
|
expect(sc?.atWill).toEqual([
|
||||||
|
{ name: "Detect Magic" },
|
||||||
|
{ name: "Mage Hand" },
|
||||||
|
]);
|
||||||
expect(sc?.daily).toHaveLength(2);
|
expect(sc?.daily).toHaveLength(2);
|
||||||
expect(sc?.daily).toContainEqual({
|
expect(sc?.daily).toContainEqual({
|
||||||
uses: 2,
|
uses: 2,
|
||||||
each: true,
|
each: true,
|
||||||
spells: ["Fireball"],
|
spells: [{ name: "Fireball" }],
|
||||||
});
|
});
|
||||||
expect(sc?.daily).toContainEqual({
|
expect(sc?.daily).toContainEqual({
|
||||||
uses: 1,
|
uses: 1,
|
||||||
each: false,
|
each: false,
|
||||||
spells: ["Dimension Door"],
|
spells: [{ name: "Dimension Door" }],
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
|||||||
File diff suppressed because it is too large
Load Diff
@@ -1,6 +1,11 @@
|
|||||||
import { describe, expect, it } from "vitest";
|
import { describe, expect, it } from "vitest";
|
||||||
|
|
||||||
|
const PACK_DIR_PREFIX = /^pathfinder-monster-core\//;
|
||||||
|
const JSON_EXTENSION = /\.json$/;
|
||||||
|
|
||||||
import {
|
import {
|
||||||
getAllPf2eSourceCodes,
|
getAllPf2eSourceCodes,
|
||||||
|
getCreaturePathsForSource,
|
||||||
getDefaultPf2eFetchUrl,
|
getDefaultPf2eFetchUrl,
|
||||||
getPf2eSourceDisplayName,
|
getPf2eSourceDisplayName,
|
||||||
loadPf2eBestiaryIndex,
|
loadPf2eBestiaryIndex,
|
||||||
@@ -30,7 +35,15 @@ describe("loadPf2eBestiaryIndex", () => {
|
|||||||
|
|
||||||
it("contains a substantial number of creatures", () => {
|
it("contains a substantial number of creatures", () => {
|
||||||
const index = loadPf2eBestiaryIndex();
|
const index = loadPf2eBestiaryIndex();
|
||||||
expect(index.creatures.length).toBeGreaterThan(2000);
|
expect(index.creatures.length).toBeGreaterThan(2500);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("creatures have size and type populated", () => {
|
||||||
|
const index = loadPf2eBestiaryIndex();
|
||||||
|
const withSize = index.creatures.filter((c) => c.size !== "");
|
||||||
|
const withType = index.creatures.filter((c) => c.type !== "");
|
||||||
|
expect(withSize.length).toBeGreaterThan(index.creatures.length * 0.9);
|
||||||
|
expect(withType.length).toBeGreaterThan(index.creatures.length * 0.8);
|
||||||
});
|
});
|
||||||
|
|
||||||
it("returns the same cached instance on subsequent calls", () => {
|
it("returns the same cached instance on subsequent calls", () => {
|
||||||
@@ -49,20 +62,42 @@ describe("getAllPf2eSourceCodes", () => {
|
|||||||
});
|
});
|
||||||
|
|
||||||
describe("getDefaultPf2eFetchUrl", () => {
|
describe("getDefaultPf2eFetchUrl", () => {
|
||||||
it("returns Pf2eTools GitHub URL with lowercase source code", () => {
|
it("returns Foundry VTT PF2e base URL", () => {
|
||||||
const url = getDefaultPf2eFetchUrl("B1");
|
const url = getDefaultPf2eFetchUrl("pathfinder-monster-core");
|
||||||
expect(url).toBe(
|
expect(url).toBe(
|
||||||
"https://raw.githubusercontent.com/Pf2eToolsOrg/Pf2eTools/dev/data/bestiary/creatures-b1.json",
|
"https://raw.githubusercontent.com/foundryvtt/pf2e/v13-dev/packs/pf2e/",
|
||||||
);
|
);
|
||||||
});
|
});
|
||||||
|
|
||||||
|
it("normalizes custom base URL with trailing slash", () => {
|
||||||
|
const url = getDefaultPf2eFetchUrl(
|
||||||
|
"pathfinder-monster-core",
|
||||||
|
"https://example.com/pf2e",
|
||||||
|
);
|
||||||
|
expect(url).toBe("https://example.com/pf2e/");
|
||||||
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
describe("getPf2eSourceDisplayName", () => {
|
describe("getPf2eSourceDisplayName", () => {
|
||||||
it("returns display name for a known source", () => {
|
it("returns display name for a known source", () => {
|
||||||
expect(getPf2eSourceDisplayName("B1")).toBe("Bestiary");
|
const name = getPf2eSourceDisplayName("pathfinder-monster-core");
|
||||||
|
expect(name).toBe("Monster Core");
|
||||||
});
|
});
|
||||||
|
|
||||||
it("falls back to source code for unknown source", () => {
|
it("falls back to source code for unknown source", () => {
|
||||||
expect(getPf2eSourceDisplayName("UNKNOWN")).toBe("UNKNOWN");
|
expect(getPf2eSourceDisplayName("UNKNOWN")).toBe("UNKNOWN");
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
describe("getCreaturePathsForSource", () => {
|
||||||
|
it("returns file paths for a known source", () => {
|
||||||
|
const paths = getCreaturePathsForSource("pathfinder-monster-core");
|
||||||
|
expect(paths.length).toBeGreaterThan(100);
|
||||||
|
expect(paths[0]).toMatch(PACK_DIR_PREFIX);
|
||||||
|
expect(paths[0]).toMatch(JSON_EXTENSION);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("returns empty array for unknown source", () => {
|
||||||
|
expect(getCreaturePathsForSource("nonexistent")).toEqual([]);
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|||||||
162
apps/web/src/adapters/__tests__/strip-foundry-tags.test.ts
Normal file
162
apps/web/src/adapters/__tests__/strip-foundry-tags.test.ts
Normal file
@@ -0,0 +1,162 @@
|
|||||||
|
import { describe, expect, it } from "vitest";
|
||||||
|
import { stripFoundryTags } from "../strip-foundry-tags.js";
|
||||||
|
|
||||||
|
describe("stripFoundryTags", () => {
|
||||||
|
describe("@Damage tags", () => {
|
||||||
|
it("formats damage with type bracket", () => {
|
||||||
|
expect(stripFoundryTags("@Damage[3d6+10[fire]]")).toBe("3d6+10 fire");
|
||||||
|
});
|
||||||
|
|
||||||
|
it("prefers display text when present", () => {
|
||||||
|
expect(
|
||||||
|
stripFoundryTags("@Damage[3d6+10[fire]]{3d6+10 fire damage}"),
|
||||||
|
).toBe("3d6+10 fire damage");
|
||||||
|
});
|
||||||
|
|
||||||
|
it("handles multiple damage types", () => {
|
||||||
|
expect(
|
||||||
|
stripFoundryTags("@Damage[2d8+5[slashing]] plus @Damage[1d6[fire]]"),
|
||||||
|
).toBe("2d8+5 slashing plus 1d6 fire");
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe("@Check tags", () => {
|
||||||
|
it("formats basic saving throw", () => {
|
||||||
|
expect(stripFoundryTags("@Check[reflex|dc:33|basic]")).toBe(
|
||||||
|
"DC 33 basic Reflex",
|
||||||
|
);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("formats non-basic check", () => {
|
||||||
|
expect(stripFoundryTags("@Check[athletics|dc:25]")).toBe(
|
||||||
|
"DC 25 Athletics",
|
||||||
|
);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("formats check without DC", () => {
|
||||||
|
expect(stripFoundryTags("@Check[fortitude]")).toBe("Fortitude");
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe("@UUID tags", () => {
|
||||||
|
it("extracts display text", () => {
|
||||||
|
expect(
|
||||||
|
stripFoundryTags(
|
||||||
|
"@UUID[Compendium.pf2e.conditionitems.Item.Grabbed]{Grabbed}",
|
||||||
|
),
|
||||||
|
).toBe("Grabbed");
|
||||||
|
});
|
||||||
|
|
||||||
|
it("extracts last segment when no display text", () => {
|
||||||
|
expect(
|
||||||
|
stripFoundryTags("@UUID[Compendium.pf2e.conditionitems.Item.Grabbed]"),
|
||||||
|
).toBe("Grabbed");
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe("@Template tags", () => {
|
||||||
|
it("formats cone template", () => {
|
||||||
|
expect(stripFoundryTags("@Template[cone|distance:40]")).toBe(
|
||||||
|
"40-foot cone",
|
||||||
|
);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("formats emanation template", () => {
|
||||||
|
expect(stripFoundryTags("@Template[emanation|distance:10]")).toBe(
|
||||||
|
"10-foot emanation",
|
||||||
|
);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("prefers display text", () => {
|
||||||
|
expect(
|
||||||
|
stripFoundryTags("@Template[cone|distance:40]{40-foot cone}"),
|
||||||
|
).toBe("40-foot cone");
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe("unknown @Tag patterns", () => {
|
||||||
|
it("uses display text for unknown tags", () => {
|
||||||
|
expect(stripFoundryTags("@Localize[some.key]{Some Text}")).toBe(
|
||||||
|
"Some Text",
|
||||||
|
);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("strips unknown tags without display text", () => {
|
||||||
|
expect(stripFoundryTags("@Localize[some.key]")).toBe("");
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe("HTML stripping", () => {
|
||||||
|
it("strips paragraph tags", () => {
|
||||||
|
expect(stripFoundryTags("<p>text</p>")).toBe("text");
|
||||||
|
});
|
||||||
|
|
||||||
|
it("converts br to newline", () => {
|
||||||
|
expect(stripFoundryTags("line1<br />line2")).toBe("line1\nline2");
|
||||||
|
});
|
||||||
|
|
||||||
|
it("converts hr to newline", () => {
|
||||||
|
expect(stripFoundryTags("before<hr />after")).toBe("before\nafter");
|
||||||
|
});
|
||||||
|
|
||||||
|
it("strips strong and em tags", () => {
|
||||||
|
expect(stripFoundryTags("<strong>bold</strong> <em>italic</em>")).toBe(
|
||||||
|
"bold italic",
|
||||||
|
);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("converts p-to-p transitions to newlines", () => {
|
||||||
|
expect(stripFoundryTags("<p>first</p><p>second</p>")).toBe(
|
||||||
|
"first\nsecond",
|
||||||
|
);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("strips action-glyph spans", () => {
|
||||||
|
expect(
|
||||||
|
stripFoundryTags('<span class="action-glyph">1</span> Strike'),
|
||||||
|
).toBe("Strike");
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe("HTML entities", () => {
|
||||||
|
it("decodes &", () => {
|
||||||
|
expect(stripFoundryTags("fire & ice")).toBe("fire & ice");
|
||||||
|
});
|
||||||
|
|
||||||
|
it("decodes < and >", () => {
|
||||||
|
expect(stripFoundryTags("<tag>")).toBe("<tag>");
|
||||||
|
});
|
||||||
|
|
||||||
|
it("decodes "", () => {
|
||||||
|
expect(stripFoundryTags(""hello"")).toBe('"hello"');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe("whitespace handling", () => {
|
||||||
|
it("collapses multiple spaces", () => {
|
||||||
|
expect(stripFoundryTags("a b c")).toBe("a b c");
|
||||||
|
});
|
||||||
|
|
||||||
|
it("collapses multiple blank lines", () => {
|
||||||
|
expect(stripFoundryTags("a\n\n\nb")).toBe("a\nb");
|
||||||
|
});
|
||||||
|
|
||||||
|
it("trims leading and trailing whitespace", () => {
|
||||||
|
expect(stripFoundryTags(" hello ")).toBe("hello");
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe("combined/edge cases", () => {
|
||||||
|
it("handles enrichment tags inside HTML", () => {
|
||||||
|
expect(
|
||||||
|
stripFoundryTags(
|
||||||
|
"<p>Deal @Damage[2d6[fire]] damage, @Check[reflex|dc:20|basic] save.</p>",
|
||||||
|
),
|
||||||
|
).toBe("Deal 2d6 fire damage, DC 20 basic Reflex save.");
|
||||||
|
});
|
||||||
|
|
||||||
|
it("handles empty string", () => {
|
||||||
|
expect(stripFoundryTags("")).toBe("");
|
||||||
|
});
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -138,12 +138,20 @@ describe("stripTags", () => {
|
|||||||
);
|
);
|
||||||
});
|
});
|
||||||
|
|
||||||
it("handles nested tags gracefully", () => {
|
it("handles sibling tags in the same string", () => {
|
||||||
expect(
|
expect(
|
||||||
stripTags("The spell {@spell Fireball|XPHB} deals {@damage 8d6}."),
|
stripTags("The spell {@spell Fireball|XPHB} deals {@damage 8d6}."),
|
||||||
).toBe("The spell Fireball deals 8d6.");
|
).toBe("The spell Fireball deals 8d6.");
|
||||||
});
|
});
|
||||||
|
|
||||||
|
it("handles nested tags (outer wrapping inner)", () => {
|
||||||
|
expect(
|
||||||
|
stripTags(
|
||||||
|
"{@b Arcane Innate Spells DC 24; 3rd {@spell fireball}, {@spell slow}}",
|
||||||
|
),
|
||||||
|
).toBe("Arcane Innate Spells DC 24; 3rd fireball, slow");
|
||||||
|
});
|
||||||
|
|
||||||
it("handles text with no tags", () => {
|
it("handles text with no tags", () => {
|
||||||
expect(stripTags("Just plain text.")).toBe("Just plain text.");
|
expect(stripTags("Just plain text.")).toBe("Just plain text.");
|
||||||
});
|
});
|
||||||
|
|||||||
@@ -4,6 +4,7 @@ import type {
|
|||||||
DailySpells,
|
DailySpells,
|
||||||
LegendaryBlock,
|
LegendaryBlock,
|
||||||
SpellcastingBlock,
|
SpellcastingBlock,
|
||||||
|
SpellReference,
|
||||||
TraitBlock,
|
TraitBlock,
|
||||||
TraitListItem,
|
TraitListItem,
|
||||||
TraitSegment,
|
TraitSegment,
|
||||||
@@ -385,7 +386,7 @@ function normalizeSpellcasting(
|
|||||||
const block: {
|
const block: {
|
||||||
name: string;
|
name: string;
|
||||||
headerText: string;
|
headerText: string;
|
||||||
atWill?: string[];
|
atWill?: SpellReference[];
|
||||||
daily?: DailySpells[];
|
daily?: DailySpells[];
|
||||||
restLong?: DailySpells[];
|
restLong?: DailySpells[];
|
||||||
} = {
|
} = {
|
||||||
@@ -396,7 +397,7 @@ function normalizeSpellcasting(
|
|||||||
const hidden = new Set(sc.hidden ?? []);
|
const hidden = new Set(sc.hidden ?? []);
|
||||||
|
|
||||||
if (sc.will && !hidden.has("will")) {
|
if (sc.will && !hidden.has("will")) {
|
||||||
block.atWill = sc.will.map((s) => stripTags(s));
|
block.atWill = sc.will.map((s) => ({ name: stripTags(s) }));
|
||||||
}
|
}
|
||||||
|
|
||||||
if (sc.daily) {
|
if (sc.daily) {
|
||||||
@@ -418,7 +419,7 @@ function parseDailyMap(map: Record<string, string[]>): DailySpells[] {
|
|||||||
return {
|
return {
|
||||||
uses,
|
uses,
|
||||||
each,
|
each,
|
||||||
spells: spells.map((s) => stripTags(s)),
|
spells: spells.map((s) => ({ name: stripTags(s) })),
|
||||||
};
|
};
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -3,7 +3,8 @@ import { type IDBPDatabase, openDB } from "idb";
|
|||||||
|
|
||||||
const DB_NAME = "initiative-bestiary";
|
const DB_NAME = "initiative-bestiary";
|
||||||
const STORE_NAME = "sources";
|
const STORE_NAME = "sources";
|
||||||
const DB_VERSION = 4;
|
// v6 (2026-04-09): SpellReference per-spell data added; old caches are cleared
|
||||||
|
const DB_VERSION = 6;
|
||||||
|
|
||||||
interface CachedSourceInfo {
|
interface CachedSourceInfo {
|
||||||
readonly sourceCode: string;
|
readonly sourceCode: string;
|
||||||
|
|||||||
@@ -1,348 +1,647 @@
|
|||||||
import type {
|
import type {
|
||||||
CreatureId,
|
CreatureId,
|
||||||
Pf2eCreature,
|
Pf2eCreature,
|
||||||
|
SpellcastingBlock,
|
||||||
|
SpellReference,
|
||||||
TraitBlock,
|
TraitBlock,
|
||||||
TraitSegment,
|
|
||||||
} from "@initiative/domain";
|
} from "@initiative/domain";
|
||||||
import { creatureId } from "@initiative/domain";
|
import { creatureId } from "@initiative/domain";
|
||||||
import { stripTags } from "./strip-tags.js";
|
import { stripFoundryTags } from "./strip-foundry-tags.js";
|
||||||
|
|
||||||
// -- Raw Pf2eTools types (minimal, for parsing) --
|
// -- Raw Foundry VTT types (minimal, for parsing) --
|
||||||
|
|
||||||
interface RawPf2eCreature {
|
interface RawFoundryCreature {
|
||||||
|
_id: string;
|
||||||
name: string;
|
name: string;
|
||||||
source: string;
|
type: string;
|
||||||
level?: number;
|
system: {
|
||||||
traits?: string[];
|
abilities: Record<string, { mod: number }>;
|
||||||
perception?: { std?: number };
|
attributes: {
|
||||||
senses?: { name?: string; type?: string; range?: number }[];
|
ac: { value: number; details?: string };
|
||||||
languages?: { languages?: string[] };
|
hp: { max: number; details?: string };
|
||||||
skills?: Record<string, { std?: number }>;
|
speed: {
|
||||||
abilityMods?: Record<string, number>;
|
value: number;
|
||||||
items?: string[];
|
otherSpeeds?: { type: string; value: number }[];
|
||||||
defenses?: RawDefenses;
|
details?: string;
|
||||||
speed?: Record<string, number | { number: number }>;
|
};
|
||||||
attacks?: RawAttack[];
|
immunities?: { type: string; exceptions?: string[] }[];
|
||||||
abilities?: {
|
resistances?: { type: string; value: number; exceptions?: string[] }[];
|
||||||
top?: RawAbility[];
|
weaknesses?: { type: string; value: number }[];
|
||||||
mid?: RawAbility[];
|
allSaves?: { value: string };
|
||||||
bot?: RawAbility[];
|
};
|
||||||
|
details: {
|
||||||
|
level: { value: number };
|
||||||
|
languages: { value?: string[]; details?: string };
|
||||||
|
publication: { license: string; remaster: boolean; title: string };
|
||||||
|
};
|
||||||
|
perception: {
|
||||||
|
mod: number;
|
||||||
|
details?: string;
|
||||||
|
senses?: { type: string; acuity?: string; range?: number }[];
|
||||||
|
};
|
||||||
|
saves: {
|
||||||
|
fortitude: { value: number; saveDetail?: string };
|
||||||
|
reflex: { value: number; saveDetail?: string };
|
||||||
|
will: { value: number; saveDetail?: string };
|
||||||
|
};
|
||||||
|
skills: Record<string, { base: number; note?: string }>;
|
||||||
|
traits: { rarity: string; size: { value: string }; value: string[] };
|
||||||
};
|
};
|
||||||
_copy?: unknown;
|
items: RawFoundryItem[];
|
||||||
}
|
}
|
||||||
|
|
||||||
interface RawDefenses {
|
interface RawFoundryItem {
|
||||||
ac?: Record<string, unknown>;
|
_id: string;
|
||||||
savingThrows?: {
|
|
||||||
fort?: { std?: number };
|
|
||||||
ref?: { std?: number };
|
|
||||||
will?: { std?: number };
|
|
||||||
};
|
|
||||||
hp?: { hp?: number }[];
|
|
||||||
immunities?: (string | { name: string })[];
|
|
||||||
resistances?: { amount?: number; name: string; note?: string }[];
|
|
||||||
weaknesses?: { amount?: number; name: string; note?: string }[];
|
|
||||||
}
|
|
||||||
|
|
||||||
interface RawAbility {
|
|
||||||
name?: string;
|
|
||||||
entries?: RawEntry[];
|
|
||||||
}
|
|
||||||
|
|
||||||
interface RawAttack {
|
|
||||||
range?: string;
|
|
||||||
name: string;
|
name: string;
|
||||||
attack?: number;
|
type: string;
|
||||||
traits?: string[];
|
system: Record<string, unknown>;
|
||||||
damage?: string;
|
sort?: number;
|
||||||
}
|
}
|
||||||
|
|
||||||
type RawEntry = string | RawEntryObject;
|
interface MeleeSystem {
|
||||||
|
bonus?: { value: number };
|
||||||
interface RawEntryObject {
|
damageRolls?: Record<string, { damage: string; damageType: string }>;
|
||||||
type?: string;
|
traits?: { value: string[] };
|
||||||
items?: (string | { name?: string; entry?: string })[];
|
|
||||||
entries?: RawEntry[];
|
|
||||||
}
|
}
|
||||||
|
|
||||||
// -- Module state --
|
interface ActionSystem {
|
||||||
|
category?: string;
|
||||||
let sourceDisplayNames: Record<string, string> = {};
|
actionType?: { value: string };
|
||||||
|
actions?: { value: number | null };
|
||||||
export function setPf2eSourceDisplayNames(names: Record<string, string>): void {
|
traits?: { value: string[] };
|
||||||
sourceDisplayNames = names;
|
description?: { value: string };
|
||||||
}
|
}
|
||||||
|
|
||||||
|
interface SpellcastingEntrySystem {
|
||||||
|
tradition?: { value: string };
|
||||||
|
prepared?: { value: string };
|
||||||
|
spelldc?: { dc: number; value?: number };
|
||||||
|
}
|
||||||
|
|
||||||
|
interface SpellSystem {
|
||||||
|
slug?: string;
|
||||||
|
location?: {
|
||||||
|
value: string;
|
||||||
|
heightenedLevel?: number;
|
||||||
|
uses?: { max: number; value: number };
|
||||||
|
};
|
||||||
|
level?: { value: number };
|
||||||
|
traits?: { rarity?: string; value: string[]; traditions?: string[] };
|
||||||
|
description?: { value: string };
|
||||||
|
range?: { value: string };
|
||||||
|
target?: { value: string };
|
||||||
|
area?: { type?: string; value?: number; details?: string };
|
||||||
|
duration?: { value: string; sustained?: boolean };
|
||||||
|
time?: { value: string };
|
||||||
|
defense?: {
|
||||||
|
save?: { statistic: string; basic?: boolean };
|
||||||
|
passive?: { statistic: string };
|
||||||
|
};
|
||||||
|
heightening?:
|
||||||
|
| {
|
||||||
|
type: "fixed";
|
||||||
|
levels: Record<string, { text?: string }>;
|
||||||
|
}
|
||||||
|
| {
|
||||||
|
type: "interval";
|
||||||
|
interval: number;
|
||||||
|
damage?: { value: string };
|
||||||
|
}
|
||||||
|
| undefined;
|
||||||
|
overlays?: Record<
|
||||||
|
string,
|
||||||
|
{ name?: string; system?: { description?: { value: string } } }
|
||||||
|
>;
|
||||||
|
}
|
||||||
|
|
||||||
|
const SIZE_MAP: Record<string, string> = {
|
||||||
|
tiny: "tiny",
|
||||||
|
sm: "small",
|
||||||
|
med: "medium",
|
||||||
|
lg: "large",
|
||||||
|
huge: "huge",
|
||||||
|
grg: "gargantuan",
|
||||||
|
};
|
||||||
|
|
||||||
// -- Helpers --
|
// -- Helpers --
|
||||||
|
|
||||||
function capitalize(s: string): string {
|
function capitalize(s: string): string {
|
||||||
return s.charAt(0).toUpperCase() + s.slice(1);
|
return s.charAt(0).toUpperCase() + s.slice(1);
|
||||||
}
|
}
|
||||||
|
|
||||||
function stripDiceBrackets(s: string): string {
|
|
||||||
return s.replaceAll(/<(\d*d\d+)>/g, "$1");
|
|
||||||
}
|
|
||||||
|
|
||||||
function makeCreatureId(source: string, name: string): CreatureId {
|
function makeCreatureId(source: string, name: string): CreatureId {
|
||||||
const slug = name
|
const slug = name
|
||||||
.toLowerCase()
|
.toLowerCase()
|
||||||
.replaceAll(/[^a-z0-9]+/g, "-")
|
.replaceAll(/[^a-z0-9]+/g, "-")
|
||||||
.replaceAll(/(^-|-$)/g, "");
|
.replaceAll(/(^-|-$)/g, "");
|
||||||
return creatureId(`${source.toLowerCase()}:${slug}`);
|
return creatureId(`${source}:${slug}`);
|
||||||
}
|
}
|
||||||
|
|
||||||
function formatSpeed(
|
const NUMERIC_SLUG = /^(.+)-(\d+)$/;
|
||||||
speed: Record<string, number | { number: number }> | undefined,
|
const LETTER_SLUG = /^(.+)-([a-z])$/;
|
||||||
): string {
|
|
||||||
if (!speed) return "";
|
/** Format rules for traits with a numeric suffix: "reach-10" → "reach 10 feet" */
|
||||||
const parts: string[] = [];
|
const NUMERIC_TRAIT_FORMATS: Record<string, (n: string) => string> = {
|
||||||
for (const [mode, value] of Object.entries(speed)) {
|
reach: (n) => `reach ${n} feet`,
|
||||||
if (typeof value === "number") {
|
range: (n) => `range ${n} feet`,
|
||||||
parts.push(
|
"range-increment": (n) => `range increment ${n} feet`,
|
||||||
mode === "walk" ? `${value} feet` : `${capitalize(mode)} ${value} feet`,
|
versatile: (n) => `versatile ${n}`,
|
||||||
);
|
deadly: (n) => `deadly d${n}`,
|
||||||
} else if (typeof value === "object" && "number" in value) {
|
fatal: (n) => `fatal d${n}`,
|
||||||
parts.push(
|
"fatal-aim": (n) => `fatal aim d${n}`,
|
||||||
mode === "walk"
|
reload: (n) => `reload ${n}`,
|
||||||
? `${value.number} feet`
|
};
|
||||||
: `${capitalize(mode)} ${value.number} feet`,
|
|
||||||
);
|
/** Format rules for traits with a letter suffix: "versatile-p" → "versatile P" */
|
||||||
}
|
const LETTER_TRAIT_FORMATS: Record<string, (l: string) => string> = {
|
||||||
|
versatile: (l) => `versatile ${l.toUpperCase()}`,
|
||||||
|
deadly: (l) => `deadly d${l}`,
|
||||||
|
};
|
||||||
|
|
||||||
|
/** Expand slugified trait names: "reach-10" → "reach 10 feet" */
|
||||||
|
function formatTrait(slug: string): string {
|
||||||
|
const numMatch = NUMERIC_SLUG.exec(slug);
|
||||||
|
if (numMatch) {
|
||||||
|
const [, base, num] = numMatch;
|
||||||
|
const fmt = NUMERIC_TRAIT_FORMATS[base];
|
||||||
|
return fmt ? fmt(num) : `${base} ${num}`;
|
||||||
}
|
}
|
||||||
return parts.join(", ");
|
const letterMatch = LETTER_SLUG.exec(slug);
|
||||||
|
if (letterMatch) {
|
||||||
|
const [, base, letter] = letterMatch;
|
||||||
|
const fmt = LETTER_TRAIT_FORMATS[base];
|
||||||
|
if (fmt) return fmt(letter);
|
||||||
|
}
|
||||||
|
return slug.replaceAll("-", " ");
|
||||||
}
|
}
|
||||||
|
|
||||||
function formatSkills(
|
// -- Formatting --
|
||||||
skills: Record<string, { std?: number }> | undefined,
|
|
||||||
): string | undefined {
|
|
||||||
if (!skills) return undefined;
|
|
||||||
const parts = Object.entries(skills)
|
|
||||||
.map(([name, val]) => `${capitalize(name)} +${val.std ?? 0}`)
|
|
||||||
.sort();
|
|
||||||
return parts.length > 0 ? parts.join(", ") : undefined;
|
|
||||||
}
|
|
||||||
|
|
||||||
function formatSenses(
|
function formatSenses(
|
||||||
senses:
|
senses: { type: string; acuity?: string; range?: number }[] | undefined,
|
||||||
| readonly { name?: string; type?: string; range?: number }[]
|
|
||||||
| undefined,
|
|
||||||
): string | undefined {
|
): string | undefined {
|
||||||
if (!senses || senses.length === 0) return undefined;
|
if (!senses || senses.length === 0) return undefined;
|
||||||
return senses
|
return senses
|
||||||
.map((s) => {
|
.map((s) => {
|
||||||
const label = stripTags(s.name ?? s.type ?? "");
|
const parts = [capitalize(s.type.replaceAll("-", " "))];
|
||||||
if (!label) return "";
|
if (s.acuity && s.acuity !== "precise") {
|
||||||
const parts = [capitalize(label)];
|
parts.push(`(${s.acuity})`);
|
||||||
if (s.type && s.name) parts.push(`(${s.type})`);
|
}
|
||||||
if (s.range != null) parts.push(`${s.range} feet`);
|
if (s.range != null) parts.push(`${s.range} feet`);
|
||||||
return parts.join(" ");
|
return parts.join(" ");
|
||||||
})
|
})
|
||||||
.filter(Boolean)
|
|
||||||
.join(", ");
|
.join(", ");
|
||||||
}
|
}
|
||||||
|
|
||||||
function formatLanguages(
|
function formatLanguages(
|
||||||
languages: { languages?: string[] } | undefined,
|
languages: { value?: string[]; details?: string } | undefined,
|
||||||
): string | undefined {
|
): string | undefined {
|
||||||
if (!languages?.languages || languages.languages.length === 0)
|
if (!languages?.value || languages.value.length === 0) return undefined;
|
||||||
return undefined;
|
const list = languages.value.map(capitalize).join(", ");
|
||||||
return languages.languages.map(capitalize).join(", ");
|
return languages.details ? `${list} (${languages.details})` : list;
|
||||||
|
}
|
||||||
|
|
||||||
|
function formatSkills(
|
||||||
|
skills: Record<string, { base: number; note?: string }> | undefined,
|
||||||
|
): string | undefined {
|
||||||
|
if (!skills) return undefined;
|
||||||
|
const entries = Object.entries(skills);
|
||||||
|
if (entries.length === 0) return undefined;
|
||||||
|
return entries
|
||||||
|
.map(([name, val]) => {
|
||||||
|
const label = capitalize(name.replaceAll("-", " "));
|
||||||
|
return `${label} +${val.base}`;
|
||||||
|
})
|
||||||
|
.sort()
|
||||||
|
.join(", ");
|
||||||
}
|
}
|
||||||
|
|
||||||
function formatImmunities(
|
function formatImmunities(
|
||||||
immunities: readonly (string | { name: string })[] | undefined,
|
immunities: { type: string; exceptions?: string[] }[] | undefined,
|
||||||
): string | undefined {
|
): string | undefined {
|
||||||
if (!immunities || immunities.length === 0) return undefined;
|
if (!immunities || immunities.length === 0) return undefined;
|
||||||
return immunities
|
return immunities
|
||||||
.map((i) => capitalize(typeof i === "string" ? i : i.name))
|
.map((i) => {
|
||||||
|
const base = capitalize(i.type.replaceAll("-", " "));
|
||||||
|
if (i.exceptions && i.exceptions.length > 0) {
|
||||||
|
return `${base} (except ${i.exceptions.map((e) => capitalize(e.replaceAll("-", " "))).join(", ")})`;
|
||||||
|
}
|
||||||
|
return base;
|
||||||
|
})
|
||||||
.join(", ");
|
.join(", ");
|
||||||
}
|
}
|
||||||
|
|
||||||
function formatResistances(
|
function formatResistances(
|
||||||
resistances:
|
resistances:
|
||||||
| readonly { amount?: number; name: string; note?: string }[]
|
| { type: string; value: number; exceptions?: string[] }[]
|
||||||
| undefined,
|
| undefined,
|
||||||
): string | undefined {
|
): string | undefined {
|
||||||
if (!resistances || resistances.length === 0) return undefined;
|
if (!resistances || resistances.length === 0) return undefined;
|
||||||
return resistances
|
return resistances
|
||||||
.map((r) => {
|
.map((r) => {
|
||||||
const base =
|
const base = `${capitalize(r.type.replaceAll("-", " "))} ${r.value}`;
|
||||||
r.amount == null
|
if (r.exceptions && r.exceptions.length > 0) {
|
||||||
? capitalize(r.name)
|
return `${base} (except ${r.exceptions.map((e) => capitalize(e.replaceAll("-", " "))).join(", ")})`;
|
||||||
: `${capitalize(r.name)} ${r.amount}`;
|
}
|
||||||
return r.note ? `${base} (${r.note})` : base;
|
return base;
|
||||||
})
|
})
|
||||||
.join(", ");
|
.join(", ");
|
||||||
}
|
}
|
||||||
|
|
||||||
function formatWeaknesses(
|
function formatWeaknesses(
|
||||||
weaknesses:
|
weaknesses: { type: string; value: number }[] | undefined,
|
||||||
| readonly { amount?: number; name: string; note?: string }[]
|
|
||||||
| undefined,
|
|
||||||
): string | undefined {
|
): string | undefined {
|
||||||
if (!weaknesses || weaknesses.length === 0) return undefined;
|
if (!weaknesses || weaknesses.length === 0) return undefined;
|
||||||
return weaknesses
|
return weaknesses
|
||||||
.map((w) => {
|
.map((w) => `${capitalize(w.type.replaceAll("-", " "))} ${w.value}`)
|
||||||
const base =
|
|
||||||
w.amount == null
|
|
||||||
? capitalize(w.name)
|
|
||||||
: `${capitalize(w.name)} ${w.amount}`;
|
|
||||||
return w.note ? `${base} (${w.note})` : base;
|
|
||||||
})
|
|
||||||
.join(", ");
|
.join(", ");
|
||||||
}
|
}
|
||||||
|
|
||||||
// -- Entry parsing --
|
function formatSpeed(speed: {
|
||||||
|
value: number;
|
||||||
function segmentizeEntries(entries: unknown): TraitSegment[] {
|
otherSpeeds?: { type: string; value: number }[];
|
||||||
if (!Array.isArray(entries)) return [];
|
details?: string;
|
||||||
const segments: TraitSegment[] = [];
|
}): string {
|
||||||
for (const entry of entries) {
|
const parts = [`${speed.value} feet`];
|
||||||
if (typeof entry === "string") {
|
if (speed.otherSpeeds) {
|
||||||
segments.push({ type: "text", value: stripTags(entry) });
|
for (const s of speed.otherSpeeds) {
|
||||||
} else if (typeof entry === "object" && entry !== null) {
|
parts.push(`${capitalize(s.type)} ${s.value} feet`);
|
||||||
const obj = entry as RawEntryObject;
|
|
||||||
if (obj.type === "list" && Array.isArray(obj.items)) {
|
|
||||||
segments.push({
|
|
||||||
type: "list",
|
|
||||||
items: obj.items.map((item) => {
|
|
||||||
if (typeof item === "string") {
|
|
||||||
return { text: stripTags(item) };
|
|
||||||
}
|
|
||||||
return { label: item.name, text: stripTags(item.entry ?? "") };
|
|
||||||
}),
|
|
||||||
});
|
|
||||||
} else if (Array.isArray(obj.entries)) {
|
|
||||||
segments.push(...segmentizeEntries(obj.entries));
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
return segments;
|
const base = parts.join(", ");
|
||||||
|
return speed.details ? `${base} (${speed.details})` : base;
|
||||||
}
|
}
|
||||||
|
|
||||||
function formatAffliction(a: Record<string, unknown>): TraitSegment[] {
|
// -- Attack normalization --
|
||||||
const parts: string[] = [];
|
|
||||||
if (a.note) parts.push(stripTags(String(a.note)));
|
|
||||||
if (a.DC) parts.push(`DC ${a.DC}`);
|
|
||||||
if (a.savingThrow) parts.push(String(a.savingThrow));
|
|
||||||
const stages = a.stages as
|
|
||||||
| { stage: number; entry: string; duration: string }[]
|
|
||||||
| undefined;
|
|
||||||
if (stages) {
|
|
||||||
for (const s of stages) {
|
|
||||||
parts.push(`Stage ${s.stage}: ${stripTags(s.entry)} (${s.duration})`);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
return parts.length > 0 ? [{ type: "text", value: parts.join("; ") }] : [];
|
|
||||||
}
|
|
||||||
|
|
||||||
function normalizeAbilities(
|
function normalizeAttack(item: RawFoundryItem): TraitBlock {
|
||||||
abilities: readonly RawAbility[] | undefined,
|
const sys = item.system as unknown as MeleeSystem;
|
||||||
): TraitBlock[] | undefined {
|
const bonus = sys.bonus?.value ?? 0;
|
||||||
if (!abilities || abilities.length === 0) return undefined;
|
const traits = sys.traits?.value ?? [];
|
||||||
return abilities
|
const damageEntries = Object.values(sys.damageRolls ?? {});
|
||||||
.filter((a) => a.name)
|
const damage = damageEntries
|
||||||
.map((a) => {
|
.map((d) => `${d.damage} ${d.damageType}`)
|
||||||
const raw = a as Record<string, unknown>;
|
.join(" plus ");
|
||||||
return {
|
const traitStr =
|
||||||
name: stripTags(a.name as string),
|
traits.length > 0 ? ` (${traits.map(formatTrait).join(", ")})` : "";
|
||||||
segments: Array.isArray(a.entries)
|
|
||||||
? segmentizeEntries(a.entries)
|
|
||||||
: formatAffliction(raw),
|
|
||||||
};
|
|
||||||
});
|
|
||||||
}
|
|
||||||
|
|
||||||
function normalizeAttacks(
|
|
||||||
attacks: readonly RawAttack[] | undefined,
|
|
||||||
): TraitBlock[] | undefined {
|
|
||||||
if (!attacks || attacks.length === 0) return undefined;
|
|
||||||
return attacks.map((a) => {
|
|
||||||
const parts: string[] = [];
|
|
||||||
if (a.range) parts.push(a.range);
|
|
||||||
const attackMod = a.attack == null ? "" : ` +${a.attack}`;
|
|
||||||
const traits =
|
|
||||||
a.traits && a.traits.length > 0
|
|
||||||
? ` (${a.traits.map((t) => stripDiceBrackets(stripTags(t))).join(", ")})`
|
|
||||||
: "";
|
|
||||||
const damage = a.damage ? `, ${stripTags(a.damage)}` : "";
|
|
||||||
return {
|
|
||||||
name: capitalize(stripTags(a.name)),
|
|
||||||
segments: [
|
|
||||||
{
|
|
||||||
type: "text" as const,
|
|
||||||
value: `${parts.join(" ")}${attackMod}${traits}${damage}`,
|
|
||||||
},
|
|
||||||
],
|
|
||||||
};
|
|
||||||
});
|
|
||||||
}
|
|
||||||
|
|
||||||
// -- Defenses extraction --
|
|
||||||
|
|
||||||
function extractDefenses(defenses: RawDefenses | undefined) {
|
|
||||||
const acRecord = defenses?.ac ?? {};
|
|
||||||
const acStd = (acRecord.std as number | undefined) ?? 0;
|
|
||||||
const acEntries = Object.entries(acRecord).filter(([k]) => k !== "std");
|
|
||||||
return {
|
return {
|
||||||
ac: acStd,
|
name: capitalize(item.name),
|
||||||
acConditional:
|
activity: { number: 1, unit: "action" },
|
||||||
acEntries.length > 0
|
segments: [
|
||||||
? acEntries.map(([k, v]) => `${v} ${k}`).join(", ")
|
{
|
||||||
: undefined,
|
type: "text",
|
||||||
saveFort: defenses?.savingThrows?.fort?.std ?? 0,
|
value: `+${bonus}${traitStr}, ${damage}`,
|
||||||
saveRef: defenses?.savingThrows?.ref?.std ?? 0,
|
},
|
||||||
saveWill: defenses?.savingThrows?.will?.std ?? 0,
|
],
|
||||||
hp: defenses?.hp?.[0]?.hp ?? 0,
|
|
||||||
immunities: formatImmunities(defenses?.immunities),
|
|
||||||
resistances: formatResistances(defenses?.resistances),
|
|
||||||
weaknesses: formatWeaknesses(defenses?.weaknesses),
|
|
||||||
};
|
};
|
||||||
}
|
}
|
||||||
|
|
||||||
|
function parseActivity(
|
||||||
|
actionType: string | undefined,
|
||||||
|
actionCount: number | null | undefined,
|
||||||
|
): { number: number; unit: "action" | "free" | "reaction" } | undefined {
|
||||||
|
if (actionType === "action") {
|
||||||
|
return { number: actionCount ?? 1, unit: "action" };
|
||||||
|
}
|
||||||
|
if (actionType === "reaction") {
|
||||||
|
return { number: 1, unit: "reaction" };
|
||||||
|
}
|
||||||
|
if (actionType === "free") {
|
||||||
|
return { number: 1, unit: "free" };
|
||||||
|
}
|
||||||
|
return undefined;
|
||||||
|
}
|
||||||
|
|
||||||
|
// -- Ability normalization --
|
||||||
|
|
||||||
|
function normalizeAbility(item: RawFoundryItem): TraitBlock {
|
||||||
|
const sys = item.system as unknown as ActionSystem;
|
||||||
|
const actionType = sys.actionType?.value;
|
||||||
|
const actionCount = sys.actions?.value;
|
||||||
|
const description = stripFoundryTags(sys.description?.value ?? "");
|
||||||
|
const traits = sys.traits?.value ?? [];
|
||||||
|
|
||||||
|
const activity = parseActivity(actionType, actionCount);
|
||||||
|
|
||||||
|
const traitStr =
|
||||||
|
traits.length > 0
|
||||||
|
? `(${traits.map((t) => capitalize(formatTrait(t))).join(", ")}) `
|
||||||
|
: "";
|
||||||
|
|
||||||
|
const text = traitStr ? `${traitStr}${description}` : description;
|
||||||
|
const segments: { type: "text"; value: string }[] = text
|
||||||
|
? [{ type: "text", value: text }]
|
||||||
|
: [];
|
||||||
|
|
||||||
|
return { name: item.name, activity, segments };
|
||||||
|
}
|
||||||
|
|
||||||
|
// -- Spellcasting normalization --
|
||||||
|
|
||||||
|
function formatRange(range: { value: string } | undefined): string | undefined {
|
||||||
|
if (!range?.value) return undefined;
|
||||||
|
return range.value;
|
||||||
|
}
|
||||||
|
|
||||||
|
function formatArea(
|
||||||
|
area: { type?: string; value?: number; details?: string } | undefined,
|
||||||
|
): string | undefined {
|
||||||
|
if (!area) return undefined;
|
||||||
|
if (area.value && area.type) return `${area.value}-foot ${area.type}`;
|
||||||
|
return area.details ?? undefined;
|
||||||
|
}
|
||||||
|
|
||||||
|
function formatDefense(defense: SpellSystem["defense"]): string | undefined {
|
||||||
|
if (!defense) return undefined;
|
||||||
|
if (defense.save) {
|
||||||
|
const stat = capitalize(defense.save.statistic);
|
||||||
|
return defense.save.basic ? `basic ${stat}` : stat;
|
||||||
|
}
|
||||||
|
if (defense.passive) return capitalize(defense.passive.statistic);
|
||||||
|
return undefined;
|
||||||
|
}
|
||||||
|
|
||||||
|
function formatHeightening(
|
||||||
|
heightening: SpellSystem["heightening"],
|
||||||
|
): string | undefined {
|
||||||
|
if (!heightening) return undefined;
|
||||||
|
if (heightening.type === "fixed") {
|
||||||
|
const parts = Object.entries(heightening.levels)
|
||||||
|
.filter(([, lvl]) => lvl.text)
|
||||||
|
.map(
|
||||||
|
([rank, lvl]) =>
|
||||||
|
`Heightened (${rank}) ${stripFoundryTags(lvl.text as string)}`,
|
||||||
|
);
|
||||||
|
return parts.length > 0 ? parts.join("\n") : undefined;
|
||||||
|
}
|
||||||
|
if (heightening.type === "interval") {
|
||||||
|
const dmg = heightening.damage?.value
|
||||||
|
? ` damage increases by ${heightening.damage.value}`
|
||||||
|
: "";
|
||||||
|
return `Heightened (+${heightening.interval})${dmg}`;
|
||||||
|
}
|
||||||
|
return undefined;
|
||||||
|
}
|
||||||
|
|
||||||
|
function formatOverlays(overlays: SpellSystem["overlays"]): string | undefined {
|
||||||
|
if (!overlays) return undefined;
|
||||||
|
const parts: string[] = [];
|
||||||
|
for (const overlay of Object.values(overlays)) {
|
||||||
|
const desc = overlay.system?.description?.value;
|
||||||
|
if (!desc) continue;
|
||||||
|
const label = overlay.name ? `${overlay.name}: ` : "";
|
||||||
|
parts.push(`${label}${stripFoundryTags(desc)}`);
|
||||||
|
}
|
||||||
|
return parts.length > 0 ? parts.join("\n") : undefined;
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Foundry descriptions often include heightening rules inline at the end.
|
||||||
|
* When we extract heightening into a structured field, strip that trailing
|
||||||
|
* text to avoid duplication.
|
||||||
|
*/
|
||||||
|
const HEIGHTENED_SUFFIX = /\s*Heightened\s*\([^)]*\)[\s\S]*$/;
|
||||||
|
|
||||||
|
function normalizeSpell(item: RawFoundryItem): SpellReference {
|
||||||
|
const sys = item.system as unknown as SpellSystem;
|
||||||
|
const usesMax = sys.location?.uses?.max;
|
||||||
|
const rank = sys.location?.heightenedLevel ?? sys.level?.value ?? 0;
|
||||||
|
const heightening =
|
||||||
|
formatHeightening(sys.heightening) ?? formatOverlays(sys.overlays);
|
||||||
|
|
||||||
|
let description: string | undefined;
|
||||||
|
if (sys.description?.value) {
|
||||||
|
let text = stripFoundryTags(sys.description.value);
|
||||||
|
if (heightening) {
|
||||||
|
text = text.replace(HEIGHTENED_SUFFIX, "").trim();
|
||||||
|
}
|
||||||
|
description = text || undefined;
|
||||||
|
}
|
||||||
|
|
||||||
|
return {
|
||||||
|
name: item.name,
|
||||||
|
slug: sys.slug,
|
||||||
|
rank,
|
||||||
|
description,
|
||||||
|
traits: sys.traits?.value,
|
||||||
|
traditions: sys.traits?.traditions,
|
||||||
|
range: formatRange(sys.range),
|
||||||
|
target: sys.target?.value || undefined,
|
||||||
|
area: formatArea(sys.area),
|
||||||
|
duration: sys.duration?.value || undefined,
|
||||||
|
defense: formatDefense(sys.defense),
|
||||||
|
actionCost: sys.time?.value || undefined,
|
||||||
|
heightening,
|
||||||
|
usesPerDay: usesMax && usesMax > 1 ? usesMax : undefined,
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
function normalizeSpellcastingEntry(
|
||||||
|
entry: RawFoundryItem,
|
||||||
|
allSpells: readonly RawFoundryItem[],
|
||||||
|
): SpellcastingBlock {
|
||||||
|
const sys = entry.system as unknown as SpellcastingEntrySystem;
|
||||||
|
const tradition = capitalize(sys.tradition?.value ?? "");
|
||||||
|
const prepared = sys.prepared?.value ?? "";
|
||||||
|
const dc = sys.spelldc?.dc ?? 0;
|
||||||
|
const attack = sys.spelldc?.value ?? 0;
|
||||||
|
|
||||||
|
const name = entry.name || `${tradition} ${capitalize(prepared)} Spells`;
|
||||||
|
const headerText = `DC ${dc}${attack ? `, attack +${attack}` : ""}`;
|
||||||
|
|
||||||
|
const linkedSpells = allSpells.filter(
|
||||||
|
(s) => (s.system as unknown as SpellSystem).location?.value === entry._id,
|
||||||
|
);
|
||||||
|
|
||||||
|
const byRank = new Map<number, SpellReference[]>();
|
||||||
|
const cantrips: SpellReference[] = [];
|
||||||
|
|
||||||
|
for (const spell of linkedSpells) {
|
||||||
|
const ref = normalizeSpell(spell);
|
||||||
|
const isCantrip =
|
||||||
|
(spell.system as unknown as SpellSystem).traits?.value?.includes(
|
||||||
|
"cantrip",
|
||||||
|
) ?? false;
|
||||||
|
if (isCantrip) {
|
||||||
|
cantrips.push(ref);
|
||||||
|
continue;
|
||||||
|
}
|
||||||
|
const rank = ref.rank ?? 0;
|
||||||
|
const existing = byRank.get(rank) ?? [];
|
||||||
|
existing.push(ref);
|
||||||
|
byRank.set(rank, existing);
|
||||||
|
}
|
||||||
|
|
||||||
|
const daily = [...byRank.entries()]
|
||||||
|
.sort(([a], [b]) => b - a)
|
||||||
|
.map(([rank, spells]) => ({
|
||||||
|
uses: rank,
|
||||||
|
each: true,
|
||||||
|
spells,
|
||||||
|
}));
|
||||||
|
|
||||||
|
return {
|
||||||
|
name,
|
||||||
|
headerText,
|
||||||
|
atWill: orUndefined(cantrips),
|
||||||
|
daily: orUndefined(daily),
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
function normalizeSpellcasting(
|
||||||
|
items: readonly RawFoundryItem[],
|
||||||
|
): SpellcastingBlock[] {
|
||||||
|
const entries = items.filter((i) => i.type === "spellcastingEntry");
|
||||||
|
const spells = items.filter((i) => i.type === "spell");
|
||||||
|
return entries.map((entry) => normalizeSpellcastingEntry(entry, spells));
|
||||||
|
}
|
||||||
|
|
||||||
// -- Main normalization --
|
// -- Main normalization --
|
||||||
|
|
||||||
function normalizeCreature(raw: RawPf2eCreature): Pf2eCreature {
|
function orUndefined<T>(arr: T[]): T[] | undefined {
|
||||||
const source = raw.source ?? "";
|
return arr.length > 0 ? arr : undefined;
|
||||||
const defenses = extractDefenses(raw.defenses);
|
}
|
||||||
const mods = raw.abilityMods ?? {};
|
|
||||||
|
|
||||||
|
/** Build display traits: [rarity (if not common), size, ...type traits] */
|
||||||
|
function buildTraits(traits: {
|
||||||
|
rarity: string;
|
||||||
|
size: { value: string };
|
||||||
|
value: string[];
|
||||||
|
}): string[] {
|
||||||
|
const result: string[] = [];
|
||||||
|
if (traits.rarity && traits.rarity !== "common") {
|
||||||
|
result.push(traits.rarity);
|
||||||
|
}
|
||||||
|
const size = SIZE_MAP[traits.size.value] ?? "medium";
|
||||||
|
result.push(size);
|
||||||
|
result.push(...traits.value);
|
||||||
|
return result;
|
||||||
|
}
|
||||||
|
|
||||||
|
const HEALING_GLOSSARY =
|
||||||
|
/^<p>@Localize\[PF2E\.NPC\.Abilities\.Glossary\.(FastHealing|Regeneration|NegativeHealing)\]/;
|
||||||
|
|
||||||
|
/** Glossary-only abilities that duplicate structured data shown elsewhere. */
|
||||||
|
const REDUNDANT_GLOSSARY =
|
||||||
|
/^<p>@Localize\[PF2E\.NPC\.Abilities\.Glossary\.(ConstantSpells|AtWillSpells)\]/;
|
||||||
|
|
||||||
|
const STRIP_GLOSSARY_AND_P = /<p>@Localize\[[^\]]+\]<\/p>|<\/?p>/g;
|
||||||
|
|
||||||
|
/** True when the description has no user-visible content beyond glossary tags. */
|
||||||
|
function isGlossaryOnly(desc: string | undefined): boolean {
|
||||||
|
if (!desc) return true;
|
||||||
|
return desc.replace(STRIP_GLOSSARY_AND_P, "").trim() === "";
|
||||||
|
}
|
||||||
|
|
||||||
|
function isRedundantAbility(
|
||||||
|
item: RawFoundryItem,
|
||||||
|
excludeName: string | undefined,
|
||||||
|
hpDetails: string | undefined,
|
||||||
|
): boolean {
|
||||||
|
const sys = item.system as unknown as ActionSystem;
|
||||||
|
const desc = sys.description?.value;
|
||||||
|
// Ability duplicates the allSaves line — suppress only if glossary-only
|
||||||
|
if (excludeName && item.name.toLowerCase() === excludeName.toLowerCase()) {
|
||||||
|
return isGlossaryOnly(desc);
|
||||||
|
}
|
||||||
|
if (!desc) return false;
|
||||||
|
// Healing/regen glossary when hp.details already shows the info
|
||||||
|
if (hpDetails && HEALING_GLOSSARY.test(desc)) return true;
|
||||||
|
// Spell mechanic glossary reminders shown in the spellcasting section
|
||||||
|
if (REDUNDANT_GLOSSARY.test(desc)) return true;
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
|
||||||
|
function actionsByCategory(
|
||||||
|
items: readonly RawFoundryItem[],
|
||||||
|
category: string,
|
||||||
|
excludeName?: string,
|
||||||
|
hpDetails?: string,
|
||||||
|
): TraitBlock[] {
|
||||||
|
return items
|
||||||
|
.filter(
|
||||||
|
(a) =>
|
||||||
|
a.type === "action" &&
|
||||||
|
(a.system as unknown as ActionSystem).category === category &&
|
||||||
|
!isRedundantAbility(a, excludeName, hpDetails),
|
||||||
|
)
|
||||||
|
.map(normalizeAbility);
|
||||||
|
}
|
||||||
|
|
||||||
|
function extractAbilityMods(
|
||||||
|
mods: Record<string, { mod: number }>,
|
||||||
|
): Pf2eCreature["abilityMods"] {
|
||||||
return {
|
return {
|
||||||
system: "pf2e",
|
str: mods.str?.mod ?? 0,
|
||||||
id: makeCreatureId(source, raw.name),
|
dex: mods.dex?.mod ?? 0,
|
||||||
name: raw.name,
|
con: mods.con?.mod ?? 0,
|
||||||
source,
|
int: mods.int?.mod ?? 0,
|
||||||
sourceDisplayName: sourceDisplayNames[source] ?? source,
|
wis: mods.wis?.mod ?? 0,
|
||||||
level: raw.level ?? 0,
|
cha: mods.cha?.mod ?? 0,
|
||||||
traits: raw.traits ?? [],
|
|
||||||
perception: raw.perception?.std ?? 0,
|
|
||||||
senses: formatSenses(raw.senses),
|
|
||||||
languages: formatLanguages(raw.languages),
|
|
||||||
skills: formatSkills(raw.skills),
|
|
||||||
abilityMods: {
|
|
||||||
str: mods.str ?? 0,
|
|
||||||
dex: mods.dex ?? 0,
|
|
||||||
con: mods.con ?? 0,
|
|
||||||
int: mods.int ?? 0,
|
|
||||||
wis: mods.wis ?? 0,
|
|
||||||
cha: mods.cha ?? 0,
|
|
||||||
},
|
|
||||||
...defenses,
|
|
||||||
speed: formatSpeed(raw.speed),
|
|
||||||
attacks: normalizeAttacks(raw.attacks),
|
|
||||||
abilitiesTop: normalizeAbilities(raw.abilities?.top),
|
|
||||||
abilitiesMid: normalizeAbilities(raw.abilities?.mid),
|
|
||||||
abilitiesBot: normalizeAbilities(raw.abilities?.bot),
|
|
||||||
};
|
};
|
||||||
}
|
}
|
||||||
|
|
||||||
export function normalizePf2eBestiary(raw: {
|
export function normalizeFoundryCreature(
|
||||||
creature: unknown[];
|
raw: unknown,
|
||||||
}): Pf2eCreature[] {
|
sourceCode?: string,
|
||||||
return (raw.creature ?? [])
|
sourceDisplayName?: string,
|
||||||
.filter((c: unknown) => {
|
): Pf2eCreature {
|
||||||
const obj = c as { _copy?: unknown };
|
const r = raw as RawFoundryCreature;
|
||||||
return !obj._copy;
|
const sys = r.system;
|
||||||
})
|
const publication = sys.details?.publication;
|
||||||
.map((c) => normalizeCreature(c as RawPf2eCreature));
|
|
||||||
|
const source = sourceCode ?? publication?.title ?? "";
|
||||||
|
const items = r.items ?? [];
|
||||||
|
const allSavesText = sys.attributes.allSaves?.value ?? "";
|
||||||
|
|
||||||
|
return {
|
||||||
|
system: "pf2e",
|
||||||
|
id: makeCreatureId(source, r.name),
|
||||||
|
name: r.name,
|
||||||
|
source,
|
||||||
|
sourceDisplayName: sourceDisplayName ?? publication?.title ?? "",
|
||||||
|
level: sys.details?.level?.value ?? 0,
|
||||||
|
traits: buildTraits(sys.traits),
|
||||||
|
perception: sys.perception?.mod ?? 0,
|
||||||
|
senses: formatSenses(sys.perception?.senses),
|
||||||
|
languages: formatLanguages(sys.details?.languages),
|
||||||
|
skills: formatSkills(sys.skills),
|
||||||
|
abilityMods: extractAbilityMods(sys.abilities ?? {}),
|
||||||
|
ac: sys.attributes.ac.value,
|
||||||
|
acConditional: sys.attributes.ac.details || undefined,
|
||||||
|
saveFort: sys.saves.fortitude.value,
|
||||||
|
saveRef: sys.saves.reflex.value,
|
||||||
|
saveWill: sys.saves.will.value,
|
||||||
|
saveConditional: allSavesText || undefined,
|
||||||
|
hp: sys.attributes.hp.max,
|
||||||
|
hpDetails: sys.attributes.hp.details || undefined,
|
||||||
|
immunities: formatImmunities(sys.attributes.immunities),
|
||||||
|
resistances: formatResistances(sys.attributes.resistances),
|
||||||
|
weaknesses: formatWeaknesses(sys.attributes.weaknesses),
|
||||||
|
speed: formatSpeed(sys.attributes.speed),
|
||||||
|
attacks: orUndefined(
|
||||||
|
items.filter((i) => i.type === "melee").map(normalizeAttack),
|
||||||
|
),
|
||||||
|
abilitiesTop: orUndefined(actionsByCategory(items, "interaction")),
|
||||||
|
abilitiesMid: orUndefined(
|
||||||
|
actionsByCategory(
|
||||||
|
items,
|
||||||
|
"defensive",
|
||||||
|
allSavesText || undefined,
|
||||||
|
sys.attributes.hp.details || undefined,
|
||||||
|
),
|
||||||
|
),
|
||||||
|
abilitiesBot: orUndefined(actionsByCategory(items, "offensive")),
|
||||||
|
spellcasting: orUndefined(normalizeSpellcasting(items)),
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
export function normalizeFoundryCreatures(
|
||||||
|
rawCreatures: unknown[],
|
||||||
|
sourceCode?: string,
|
||||||
|
sourceDisplayName?: string,
|
||||||
|
): Pf2eCreature[] {
|
||||||
|
return rawCreatures.map((raw) =>
|
||||||
|
normalizeFoundryCreature(raw, sourceCode, sourceDisplayName),
|
||||||
|
);
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -14,6 +14,8 @@ interface CompactCreature {
|
|||||||
readonly pc: number;
|
readonly pc: number;
|
||||||
readonly sz: string;
|
readonly sz: string;
|
||||||
readonly tp: string;
|
readonly tp: string;
|
||||||
|
readonly f: string;
|
||||||
|
readonly li: string;
|
||||||
}
|
}
|
||||||
|
|
||||||
interface CompactIndex {
|
interface CompactIndex {
|
||||||
@@ -53,15 +55,18 @@ export function getAllPf2eSourceCodes(): string[] {
|
|||||||
}
|
}
|
||||||
|
|
||||||
export function getDefaultPf2eFetchUrl(
|
export function getDefaultPf2eFetchUrl(
|
||||||
sourceCode: string,
|
_sourceCode: string,
|
||||||
baseUrl?: string,
|
baseUrl?: string,
|
||||||
): string {
|
): string {
|
||||||
const filename = `creatures-${sourceCode.toLowerCase()}.json`;
|
|
||||||
if (baseUrl !== undefined) {
|
if (baseUrl !== undefined) {
|
||||||
const normalized = baseUrl.endsWith("/") ? baseUrl : `${baseUrl}/`;
|
return baseUrl.endsWith("/") ? baseUrl : `${baseUrl}/`;
|
||||||
return `${normalized}${filename}`;
|
|
||||||
}
|
}
|
||||||
return `https://raw.githubusercontent.com/Pf2eToolsOrg/Pf2eTools/dev/data/bestiary/${filename}`;
|
return "https://raw.githubusercontent.com/foundryvtt/pf2e/v13-dev/packs/pf2e/";
|
||||||
|
}
|
||||||
|
|
||||||
|
export function getCreaturePathsForSource(sourceCode: string): string[] {
|
||||||
|
const compact = rawIndex as unknown as CompactIndex;
|
||||||
|
return compact.creatures.filter((c) => c.s === sourceCode).map((c) => c.f);
|
||||||
}
|
}
|
||||||
|
|
||||||
export function getPf2eSourceDisplayName(sourceCode: string): string {
|
export function getPf2eSourceDisplayName(sourceCode: string): string {
|
||||||
|
|||||||
@@ -56,4 +56,5 @@ export interface Pf2eBestiaryIndexPort {
|
|||||||
getAllSourceCodes(): string[];
|
getAllSourceCodes(): string[];
|
||||||
getDefaultFetchUrl(sourceCode: string, baseUrl?: string): string;
|
getDefaultFetchUrl(sourceCode: string, baseUrl?: string): string;
|
||||||
getSourceDisplayName(sourceCode: string): string;
|
getSourceDisplayName(sourceCode: string): string;
|
||||||
|
getCreaturePathsForSource(sourceCode: string): string[];
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -47,5 +47,6 @@ export const productionAdapters: Adapters = {
|
|||||||
getAllSourceCodes: pf2eBestiaryIndex.getAllPf2eSourceCodes,
|
getAllSourceCodes: pf2eBestiaryIndex.getAllPf2eSourceCodes,
|
||||||
getDefaultFetchUrl: pf2eBestiaryIndex.getDefaultPf2eFetchUrl,
|
getDefaultFetchUrl: pf2eBestiaryIndex.getDefaultPf2eFetchUrl,
|
||||||
getSourceDisplayName: pf2eBestiaryIndex.getPf2eSourceDisplayName,
|
getSourceDisplayName: pf2eBestiaryIndex.getPf2eSourceDisplayName,
|
||||||
|
getCreaturePathsForSource: pf2eBestiaryIndex.getCreaturePathsForSource,
|
||||||
},
|
},
|
||||||
};
|
};
|
||||||
|
|||||||
99
apps/web/src/adapters/strip-foundry-tags.ts
Normal file
99
apps/web/src/adapters/strip-foundry-tags.ts
Normal file
@@ -0,0 +1,99 @@
|
|||||||
|
/**
|
||||||
|
* Strips Foundry VTT HTML descriptions with enrichment syntax to plain
|
||||||
|
* readable text. Handles @Damage, @Check, @UUID, @Template and generic
|
||||||
|
* @Tag patterns as well as common HTML elements.
|
||||||
|
*/
|
||||||
|
|
||||||
|
// -- Enrichment-param helpers --
|
||||||
|
|
||||||
|
function formatDamage(params: string): string {
|
||||||
|
// "3d6+10[fire]" → "3d6+10 fire"
|
||||||
|
return params.replaceAll(/\[([^\]]*)\]/g, " $1").trim();
|
||||||
|
}
|
||||||
|
|
||||||
|
function formatCheck(params: string): string {
|
||||||
|
// "reflex|dc:33|basic" → "DC 33 basic Reflex"
|
||||||
|
const parts = params.split("|");
|
||||||
|
const type = parts[0] ?? "";
|
||||||
|
let dc = "";
|
||||||
|
let basic = false;
|
||||||
|
for (const part of parts.slice(1)) {
|
||||||
|
if (part.startsWith("dc:")) {
|
||||||
|
dc = part.slice(3);
|
||||||
|
} else if (part === "basic") {
|
||||||
|
basic = true;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
const label = type.charAt(0).toUpperCase() + type.slice(1);
|
||||||
|
const dcStr = dc ? `DC ${dc} ` : "";
|
||||||
|
const basicStr = basic ? "basic " : "";
|
||||||
|
return `${dcStr}${basicStr}${label}`;
|
||||||
|
}
|
||||||
|
|
||||||
|
function formatTemplate(params: string): string {
|
||||||
|
// "cone|distance:40" → "40-foot cone"
|
||||||
|
const parts = params.split("|");
|
||||||
|
const shape = parts[0] ?? "";
|
||||||
|
let distance = "";
|
||||||
|
for (const part of parts.slice(1)) {
|
||||||
|
if (part.startsWith("distance:")) {
|
||||||
|
distance = part.slice(9);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return distance ? `${distance}-foot ${shape}` : shape;
|
||||||
|
}
|
||||||
|
|
||||||
|
export function stripFoundryTags(html: string): string {
|
||||||
|
if (typeof html !== "string") return String(html);
|
||||||
|
let result = html;
|
||||||
|
|
||||||
|
// Strip Foundry enrichment tags (with optional display text)
|
||||||
|
// @Tag[params]{display} → display (prefer display text)
|
||||||
|
// @Tag[params] → extracted content
|
||||||
|
|
||||||
|
// @Damage has nested brackets: @Damage[3d6+10[fire]]
|
||||||
|
result = result.replaceAll(
|
||||||
|
/@Damage\[((?:[^[\]]|\[[^\]]*\])*)\](?:\{([^}]+)\})?/g,
|
||||||
|
(_, params: string, display: string | undefined) =>
|
||||||
|
display ?? formatDamage(params),
|
||||||
|
);
|
||||||
|
result = result.replaceAll(
|
||||||
|
/@Check\[([^\]]+)\](?:\{([^}]*)\})?/g,
|
||||||
|
(_, params: string) => formatCheck(params),
|
||||||
|
);
|
||||||
|
result = result.replaceAll(
|
||||||
|
/@UUID\[[^\]]+?([^./\]]+)\](?:\{([^}]+)\})?/g,
|
||||||
|
(_, lastSegment: string, display: string | undefined) =>
|
||||||
|
display ?? lastSegment,
|
||||||
|
);
|
||||||
|
result = result.replaceAll(
|
||||||
|
/@Template\[([^\]]+)\](?:\{([^}]+)\})?/g,
|
||||||
|
(_, params: string, display: string | undefined) =>
|
||||||
|
display ?? formatTemplate(params),
|
||||||
|
);
|
||||||
|
// Catch-all for unknown @Tag patterns
|
||||||
|
result = result.replaceAll(
|
||||||
|
/@\w+\[[^\]]*\](?:\{([^}]+)\})?/g,
|
||||||
|
(_, display: string | undefined) => display ?? "",
|
||||||
|
);
|
||||||
|
|
||||||
|
// Strip action-glyph spans (content is a number the renderer handles)
|
||||||
|
result = result.replaceAll(/<span class="action-glyph">[^<]*<\/span>/gi, "");
|
||||||
|
|
||||||
|
// Strip HTML tags
|
||||||
|
result = result.replaceAll(/<br\s*\/?>/gi, "\n");
|
||||||
|
result = result.replaceAll(/<hr\s*\/?>/gi, "\n");
|
||||||
|
result = result.replaceAll(/<\/p>\s*<p[^>]*>/gi, "\n");
|
||||||
|
result = result.replaceAll(/<[^>]+>/g, "");
|
||||||
|
|
||||||
|
// Decode common HTML entities
|
||||||
|
result = result.replaceAll("&", "&");
|
||||||
|
result = result.replaceAll("<", "<");
|
||||||
|
result = result.replaceAll(">", ">");
|
||||||
|
result = result.replaceAll(""", '"');
|
||||||
|
|
||||||
|
// Collapse whitespace
|
||||||
|
result = result.replaceAll(/[ \t]+/g, " ");
|
||||||
|
result = result.replaceAll(/\n\s*\n/g, "\n");
|
||||||
|
return result.trim();
|
||||||
|
}
|
||||||
@@ -98,20 +98,26 @@ export function stripTags(text: string): string {
|
|||||||
// Generic tags: {@tag Display|Source|...} → Display (first segment before |)
|
// Generic tags: {@tag Display|Source|...} → Display (first segment before |)
|
||||||
// Covers: spell, condition, damage, dice, variantrule, action, skill,
|
// Covers: spell, condition, damage, dice, variantrule, action, skill,
|
||||||
// creature, hazard, status, plus any unknown tags
|
// creature, hazard, status, plus any unknown tags
|
||||||
result = result.replaceAll(
|
// Run in a loop to resolve nested tags (e.g. {@b ... {@spell fireball} ...})
|
||||||
/\{@(\w+)\s+([^}]+)\}/g,
|
// from innermost to outermost.
|
||||||
(_, tag: string, content: string) => {
|
const tagPattern = /\{@(\w+)\s+([^}]+)\}/g;
|
||||||
// For tags with Display|Source format, extract first segment
|
while (tagPattern.test(result)) {
|
||||||
const segments = content.split("|");
|
result = result.replaceAll(
|
||||||
|
tagPattern,
|
||||||
|
(_, tag: string, content: string) => {
|
||||||
|
const segments = content.split("|");
|
||||||
|
|
||||||
// Some tags have a third segment as display text: {@variantrule Name|Source|Display}
|
if (
|
||||||
if ((tag === "variantrule" || tag === "action") && segments.length >= 3) {
|
(tag === "variantrule" || tag === "action") &&
|
||||||
return segments[2];
|
segments.length >= 3
|
||||||
}
|
) {
|
||||||
|
return segments[2];
|
||||||
|
}
|
||||||
|
|
||||||
return segments[0];
|
return segments[0];
|
||||||
},
|
},
|
||||||
);
|
);
|
||||||
|
}
|
||||||
|
|
||||||
return result;
|
return result;
|
||||||
}
|
}
|
||||||
|
|||||||
370
apps/web/src/components/__tests__/pf2e-stat-block.test.tsx
Normal file
370
apps/web/src/components/__tests__/pf2e-stat-block.test.tsx
Normal file
@@ -0,0 +1,370 @@
|
|||||||
|
// @vitest-environment jsdom
|
||||||
|
import "@testing-library/jest-dom/vitest";
|
||||||
|
|
||||||
|
import type { Pf2eCreature } from "@initiative/domain";
|
||||||
|
import { creatureId } from "@initiative/domain";
|
||||||
|
import { cleanup, render, screen } from "@testing-library/react";
|
||||||
|
import userEvent from "@testing-library/user-event";
|
||||||
|
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
||||||
|
import { Pf2eStatBlock } from "../pf2e-stat-block.js";
|
||||||
|
|
||||||
|
afterEach(cleanup);
|
||||||
|
|
||||||
|
const USES_PER_DAY_REGEX = /×3/;
|
||||||
|
const HEAL_DESCRIPTION_REGEX = /channel positive energy/;
|
||||||
|
const PERCEPTION_SENSES_REGEX = /\+2.*Darkvision/;
|
||||||
|
const SKILLS_REGEX = /Acrobatics \+5.*Stealth \+5/;
|
||||||
|
const SAVE_CONDITIONAL_REGEX = /\+12.*\+1 status to all saves vs\. magic/;
|
||||||
|
const SAVE_CONDITIONAL_ABSENT_REGEX = /status to all saves/;
|
||||||
|
const HP_DETAILS_REGEX = /115.*regeneration 20/;
|
||||||
|
const REGEN_REGEX = /regeneration/;
|
||||||
|
const ATTACK_NAME_REGEX = /Dogslicer/;
|
||||||
|
const ATTACK_DAMAGE_REGEX = /1d6 slashing/;
|
||||||
|
const SPELLCASTING_ENTRY_REGEX = /Divine Innate Spells\./;
|
||||||
|
const ABILITY_MID_NAME_REGEX = /Goblin Scuttle/;
|
||||||
|
const ABILITY_MID_DESC_REGEX = /The goblin Steps\./;
|
||||||
|
const CANTRIPS_REGEX = /Cantrips:/;
|
||||||
|
const AC_REGEX = /16/;
|
||||||
|
|
||||||
|
const GOBLIN_WARRIOR: Pf2eCreature = {
|
||||||
|
system: "pf2e",
|
||||||
|
id: creatureId("pathfinder-monster-core:goblin-warrior"),
|
||||||
|
name: "Goblin Warrior",
|
||||||
|
source: "pathfinder-monster-core",
|
||||||
|
sourceDisplayName: "Monster Core",
|
||||||
|
level: -1,
|
||||||
|
traits: ["small", "goblin", "humanoid"],
|
||||||
|
perception: 2,
|
||||||
|
senses: "Darkvision",
|
||||||
|
languages: "Common, Goblin",
|
||||||
|
skills: "Acrobatics +5, Athletics +2, Nature +1, Stealth +5",
|
||||||
|
abilityMods: { str: 0, dex: 3, con: 1, int: 0, wis: -1, cha: 1 },
|
||||||
|
ac: 16,
|
||||||
|
saveFort: 5,
|
||||||
|
saveRef: 7,
|
||||||
|
saveWill: 3,
|
||||||
|
hp: 6,
|
||||||
|
speed: "25 feet",
|
||||||
|
attacks: [
|
||||||
|
{
|
||||||
|
name: "Dogslicer",
|
||||||
|
activity: { number: 1, unit: "action" },
|
||||||
|
segments: [
|
||||||
|
{
|
||||||
|
type: "text",
|
||||||
|
value: "+7 (agile, backstabber, finesse), 1d6 slashing",
|
||||||
|
},
|
||||||
|
],
|
||||||
|
},
|
||||||
|
],
|
||||||
|
abilitiesMid: [
|
||||||
|
{
|
||||||
|
name: "Goblin Scuttle",
|
||||||
|
activity: { number: 1, unit: "reaction" },
|
||||||
|
segments: [{ type: "text", value: "The goblin Steps." }],
|
||||||
|
},
|
||||||
|
],
|
||||||
|
};
|
||||||
|
|
||||||
|
const NAUNET: Pf2eCreature = {
|
||||||
|
system: "pf2e",
|
||||||
|
id: creatureId("pathfinder-monster-core-2:naunet"),
|
||||||
|
name: "Naunet",
|
||||||
|
source: "pathfinder-monster-core-2",
|
||||||
|
sourceDisplayName: "Monster Core 2",
|
||||||
|
level: 7,
|
||||||
|
traits: ["large", "monitor", "protean"],
|
||||||
|
perception: 14,
|
||||||
|
senses: "Darkvision",
|
||||||
|
languages: "Chthonian, Empyrean, Protean",
|
||||||
|
skills:
|
||||||
|
"Acrobatics +14, Athletics +16, Intimidation +16, Stealth +14, Survival +12",
|
||||||
|
abilityMods: { str: 5, dex: 3, con: 5, int: 0, wis: 3, cha: 3 },
|
||||||
|
ac: 24,
|
||||||
|
saveFort: 18,
|
||||||
|
saveRef: 14,
|
||||||
|
saveWill: 12,
|
||||||
|
saveConditional: "+1 status to all saves vs. magic",
|
||||||
|
hp: 120,
|
||||||
|
resistances: "Precision 5, Protean anatomy 10",
|
||||||
|
speed: "25 feet, Fly 30 feet, Swim 25 feet (unfettered movement)",
|
||||||
|
spellcasting: [
|
||||||
|
{
|
||||||
|
name: "Divine Innate Spells",
|
||||||
|
headerText: "DC 25, attack +17",
|
||||||
|
daily: [
|
||||||
|
{
|
||||||
|
uses: 4,
|
||||||
|
each: true,
|
||||||
|
spells: [{ name: "Unfettered Movement (Constant)" }],
|
||||||
|
},
|
||||||
|
],
|
||||||
|
atWill: [{ name: "Detect Magic" }],
|
||||||
|
},
|
||||||
|
],
|
||||||
|
};
|
||||||
|
|
||||||
|
const TROLL: Pf2eCreature = {
|
||||||
|
system: "pf2e",
|
||||||
|
id: creatureId("pathfinder-monster-core:forest-troll"),
|
||||||
|
name: "Forest Troll",
|
||||||
|
source: "pathfinder-monster-core",
|
||||||
|
sourceDisplayName: "Monster Core",
|
||||||
|
level: 5,
|
||||||
|
traits: ["large", "giant", "troll"],
|
||||||
|
perception: 11,
|
||||||
|
senses: "Darkvision",
|
||||||
|
languages: "Jotun",
|
||||||
|
skills: "Athletics +12, Intimidation +12",
|
||||||
|
abilityMods: { str: 5, dex: 2, con: 6, int: -2, wis: 0, cha: -2 },
|
||||||
|
ac: 20,
|
||||||
|
saveFort: 17,
|
||||||
|
saveRef: 11,
|
||||||
|
saveWill: 7,
|
||||||
|
hp: 115,
|
||||||
|
hpDetails: "regeneration 20 (deactivated by acid or fire)",
|
||||||
|
weaknesses: "Fire 10",
|
||||||
|
speed: "30 feet",
|
||||||
|
};
|
||||||
|
|
||||||
|
function renderStatBlock(creature: Pf2eCreature) {
|
||||||
|
return render(<Pf2eStatBlock creature={creature} />);
|
||||||
|
}
|
||||||
|
|
||||||
|
describe("Pf2eStatBlock", () => {
|
||||||
|
describe("header", () => {
|
||||||
|
it("renders creature name and level", () => {
|
||||||
|
renderStatBlock(GOBLIN_WARRIOR);
|
||||||
|
expect(
|
||||||
|
screen.getByRole("heading", { name: "Goblin Warrior" }),
|
||||||
|
).toBeInTheDocument();
|
||||||
|
expect(screen.getByText("Level -1")).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it("renders traits as tags", () => {
|
||||||
|
renderStatBlock(GOBLIN_WARRIOR);
|
||||||
|
expect(screen.getByText("Small")).toBeInTheDocument();
|
||||||
|
expect(screen.getByText("Goblin")).toBeInTheDocument();
|
||||||
|
expect(screen.getByText("Humanoid")).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it("renders source display name", () => {
|
||||||
|
renderStatBlock(GOBLIN_WARRIOR);
|
||||||
|
expect(screen.getByText("Monster Core")).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe("perception and senses", () => {
|
||||||
|
it("renders perception modifier and senses", () => {
|
||||||
|
renderStatBlock(GOBLIN_WARRIOR);
|
||||||
|
expect(screen.getByText("Perception")).toBeInTheDocument();
|
||||||
|
expect(screen.getByText(PERCEPTION_SENSES_REGEX)).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it("renders languages", () => {
|
||||||
|
renderStatBlock(GOBLIN_WARRIOR);
|
||||||
|
expect(screen.getByText("Languages")).toBeInTheDocument();
|
||||||
|
expect(screen.getByText("Common, Goblin")).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it("renders skills", () => {
|
||||||
|
renderStatBlock(GOBLIN_WARRIOR);
|
||||||
|
expect(screen.getByText("Skills")).toBeInTheDocument();
|
||||||
|
expect(screen.getByText(SKILLS_REGEX)).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe("ability modifiers", () => {
|
||||||
|
it("renders all six ability labels", () => {
|
||||||
|
renderStatBlock(GOBLIN_WARRIOR);
|
||||||
|
for (const label of ["Str", "Dex", "Con", "Int", "Wis", "Cha"]) {
|
||||||
|
expect(screen.getByText(label)).toBeInTheDocument();
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
|
it("renders positive and negative modifiers", () => {
|
||||||
|
renderStatBlock(GOBLIN_WARRIOR);
|
||||||
|
expect(screen.getByText("+3")).toBeInTheDocument();
|
||||||
|
expect(screen.getByText("-1")).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe("defenses", () => {
|
||||||
|
it("renders AC and saves", () => {
|
||||||
|
renderStatBlock(GOBLIN_WARRIOR);
|
||||||
|
expect(screen.getByText("AC")).toBeInTheDocument();
|
||||||
|
expect(screen.getByText(AC_REGEX)).toBeInTheDocument();
|
||||||
|
expect(screen.getByText("Fort")).toBeInTheDocument();
|
||||||
|
expect(screen.getByText("Ref")).toBeInTheDocument();
|
||||||
|
expect(screen.getByText("Will")).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it("renders HP", () => {
|
||||||
|
renderStatBlock(GOBLIN_WARRIOR);
|
||||||
|
expect(screen.getByText("HP")).toBeInTheDocument();
|
||||||
|
expect(screen.getByText("6")).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it("renders saveConditional inline with saves", () => {
|
||||||
|
renderStatBlock(NAUNET);
|
||||||
|
expect(screen.getByText(SAVE_CONDITIONAL_REGEX)).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it("omits saveConditional when absent", () => {
|
||||||
|
renderStatBlock(GOBLIN_WARRIOR);
|
||||||
|
expect(
|
||||||
|
screen.queryByText(SAVE_CONDITIONAL_ABSENT_REGEX),
|
||||||
|
).not.toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it("renders hpDetails in parentheses after HP", () => {
|
||||||
|
renderStatBlock(TROLL);
|
||||||
|
expect(screen.getByText(HP_DETAILS_REGEX)).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it("omits hpDetails when absent", () => {
|
||||||
|
renderStatBlock(GOBLIN_WARRIOR);
|
||||||
|
expect(screen.queryByText(REGEN_REGEX)).not.toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it("renders resistances and weaknesses", () => {
|
||||||
|
renderStatBlock(NAUNET);
|
||||||
|
expect(screen.getByText("Resistances")).toBeInTheDocument();
|
||||||
|
expect(
|
||||||
|
screen.getByText("Precision 5, Protean anatomy 10"),
|
||||||
|
).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe("abilities", () => {
|
||||||
|
it("renders mid (defensive) abilities", () => {
|
||||||
|
renderStatBlock(GOBLIN_WARRIOR);
|
||||||
|
expect(screen.getByText(ABILITY_MID_NAME_REGEX)).toBeInTheDocument();
|
||||||
|
expect(screen.getByText(ABILITY_MID_DESC_REGEX)).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe("speed and attacks", () => {
|
||||||
|
it("renders speed", () => {
|
||||||
|
renderStatBlock(GOBLIN_WARRIOR);
|
||||||
|
expect(screen.getByText("Speed")).toBeInTheDocument();
|
||||||
|
expect(screen.getByText("25 feet")).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it("renders attacks", () => {
|
||||||
|
renderStatBlock(GOBLIN_WARRIOR);
|
||||||
|
expect(screen.getByText(ATTACK_NAME_REGEX)).toBeInTheDocument();
|
||||||
|
expect(screen.getByText(ATTACK_DAMAGE_REGEX)).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe("spellcasting", () => {
|
||||||
|
it("renders spellcasting entry with header", () => {
|
||||||
|
renderStatBlock(NAUNET);
|
||||||
|
expect(screen.getByText(SPELLCASTING_ENTRY_REGEX)).toBeInTheDocument();
|
||||||
|
expect(screen.getByText("DC 25, attack +17")).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it("renders ranked spells", () => {
|
||||||
|
renderStatBlock(NAUNET);
|
||||||
|
expect(screen.getByText("Rank 4:")).toBeInTheDocument();
|
||||||
|
expect(
|
||||||
|
screen.getByText("Unfettered Movement (Constant)"),
|
||||||
|
).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it("renders cantrips", () => {
|
||||||
|
renderStatBlock(NAUNET);
|
||||||
|
expect(screen.getByText("Cantrips:")).toBeInTheDocument();
|
||||||
|
expect(screen.getByText("Detect Magic")).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it("omits spellcasting when absent", () => {
|
||||||
|
renderStatBlock(GOBLIN_WARRIOR);
|
||||||
|
expect(screen.queryByText(CANTRIPS_REGEX)).not.toBeInTheDocument();
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe("clickable spells", () => {
|
||||||
|
const SPELLCASTER: Pf2eCreature = {
|
||||||
|
...NAUNET,
|
||||||
|
id: creatureId("test:spellcaster"),
|
||||||
|
name: "Spellcaster",
|
||||||
|
spellcasting: [
|
||||||
|
{
|
||||||
|
name: "Divine Innate Spells",
|
||||||
|
headerText: "DC 30, attack +20",
|
||||||
|
atWill: [{ name: "Detect Magic", rank: 1 }],
|
||||||
|
daily: [
|
||||||
|
{
|
||||||
|
uses: 4,
|
||||||
|
each: true,
|
||||||
|
spells: [
|
||||||
|
{
|
||||||
|
name: "Heal",
|
||||||
|
description: "You channel positive energy to heal.",
|
||||||
|
rank: 4,
|
||||||
|
usesPerDay: 3,
|
||||||
|
},
|
||||||
|
{ name: "Restoration", rank: 4 },
|
||||||
|
],
|
||||||
|
},
|
||||||
|
],
|
||||||
|
},
|
||||||
|
],
|
||||||
|
};
|
||||||
|
|
||||||
|
beforeEach(() => {
|
||||||
|
Object.defineProperty(globalThis, "matchMedia", {
|
||||||
|
writable: true,
|
||||||
|
configurable: true,
|
||||||
|
value: vi.fn().mockImplementation(() => ({
|
||||||
|
matches: true,
|
||||||
|
media: "(min-width: 1024px)",
|
||||||
|
onchange: null,
|
||||||
|
addEventListener: vi.fn(),
|
||||||
|
removeEventListener: vi.fn(),
|
||||||
|
addListener: vi.fn(),
|
||||||
|
removeListener: vi.fn(),
|
||||||
|
dispatchEvent: vi.fn(),
|
||||||
|
})),
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
it("renders a spell with a description as a clickable button", () => {
|
||||||
|
renderStatBlock(SPELLCASTER);
|
||||||
|
expect(screen.getByRole("button", { name: "Heal" })).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it("renders a spell without description as plain text (not a button)", () => {
|
||||||
|
renderStatBlock(SPELLCASTER);
|
||||||
|
expect(
|
||||||
|
screen.queryByRole("button", { name: "Restoration" }),
|
||||||
|
).not.toBeInTheDocument();
|
||||||
|
expect(screen.getByText("Restoration")).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it("renders usesPerDay as plain text alongside the spell button", () => {
|
||||||
|
renderStatBlock(SPELLCASTER);
|
||||||
|
expect(screen.getByText(USES_PER_DAY_REGEX)).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it("opens the spell popover when a spell button is clicked", async () => {
|
||||||
|
const user = userEvent.setup();
|
||||||
|
renderStatBlock(SPELLCASTER);
|
||||||
|
await user.click(screen.getByRole("button", { name: "Heal" }));
|
||||||
|
expect(screen.getByText(HEAL_DESCRIPTION_REGEX)).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it("closes the popover when Escape is pressed", async () => {
|
||||||
|
const user = userEvent.setup();
|
||||||
|
renderStatBlock(SPELLCASTER);
|
||||||
|
await user.click(screen.getByRole("button", { name: "Heal" }));
|
||||||
|
expect(screen.getByText(HEAL_DESCRIPTION_REGEX)).toBeInTheDocument();
|
||||||
|
await user.keyboard("{Escape}");
|
||||||
|
expect(
|
||||||
|
screen.queryByText(HEAL_DESCRIPTION_REGEX),
|
||||||
|
).not.toBeInTheDocument();
|
||||||
|
});
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -28,7 +28,7 @@ beforeAll(() => {
|
|||||||
|
|
||||||
afterEach(cleanup);
|
afterEach(cleanup);
|
||||||
|
|
||||||
function renderWithSources(sources: CachedSourceInfo[] = []) {
|
function renderWithSources(sources: CachedSourceInfo[] = []): void {
|
||||||
const adapters = createTestAdapters();
|
const adapters = createTestAdapters();
|
||||||
// Wire getCachedSources to return the provided sources initially,
|
// Wire getCachedSources to return the provided sources initially,
|
||||||
// then empty after clear operations
|
// then empty after clear operations
|
||||||
@@ -57,14 +57,14 @@ function renderWithSources(sources: CachedSourceInfo[] = []) {
|
|||||||
|
|
||||||
describe("SourceManager", () => {
|
describe("SourceManager", () => {
|
||||||
it("shows 'No cached sources' empty state when no sources", async () => {
|
it("shows 'No cached sources' empty state when no sources", async () => {
|
||||||
void renderWithSources([]);
|
renderWithSources([]);
|
||||||
await waitFor(() => {
|
await waitFor(() => {
|
||||||
expect(screen.getByText("No cached sources")).toBeInTheDocument();
|
expect(screen.getByText("No cached sources")).toBeInTheDocument();
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
it("lists cached sources with display name and creature count", async () => {
|
it("lists cached sources with display name and creature count", async () => {
|
||||||
void renderWithSources([
|
renderWithSources([
|
||||||
{
|
{
|
||||||
sourceCode: "mm",
|
sourceCode: "mm",
|
||||||
displayName: "Monster Manual",
|
displayName: "Monster Manual",
|
||||||
@@ -88,7 +88,7 @@ describe("SourceManager", () => {
|
|||||||
|
|
||||||
it("Clear All button removes all sources", async () => {
|
it("Clear All button removes all sources", async () => {
|
||||||
const user = userEvent.setup();
|
const user = userEvent.setup();
|
||||||
void renderWithSources([
|
renderWithSources([
|
||||||
{
|
{
|
||||||
sourceCode: "mm",
|
sourceCode: "mm",
|
||||||
displayName: "Monster Manual",
|
displayName: "Monster Manual",
|
||||||
@@ -110,7 +110,7 @@ describe("SourceManager", () => {
|
|||||||
|
|
||||||
it("individual source delete button removes that source", async () => {
|
it("individual source delete button removes that source", async () => {
|
||||||
const user = userEvent.setup();
|
const user = userEvent.setup();
|
||||||
void renderWithSources([
|
renderWithSources([
|
||||||
{
|
{
|
||||||
sourceCode: "mm",
|
sourceCode: "mm",
|
||||||
displayName: "Monster Manual",
|
displayName: "Monster Manual",
|
||||||
|
|||||||
158
apps/web/src/components/__tests__/spell-detail-popover.test.tsx
Normal file
158
apps/web/src/components/__tests__/spell-detail-popover.test.tsx
Normal file
@@ -0,0 +1,158 @@
|
|||||||
|
// @vitest-environment jsdom
|
||||||
|
import "@testing-library/jest-dom/vitest";
|
||||||
|
|
||||||
|
import type { SpellReference } from "@initiative/domain";
|
||||||
|
import { cleanup, fireEvent, render, screen } from "@testing-library/react";
|
||||||
|
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
||||||
|
import { SpellDetailPopover } from "../spell-detail-popover.js";
|
||||||
|
|
||||||
|
afterEach(cleanup);
|
||||||
|
|
||||||
|
const FIREBALL: SpellReference = {
|
||||||
|
name: "Fireball",
|
||||||
|
slug: "fireball",
|
||||||
|
rank: 3,
|
||||||
|
description: "A spark leaps from your fingertip to the target.",
|
||||||
|
traits: ["fire", "manipulate"],
|
||||||
|
traditions: ["arcane", "primal"],
|
||||||
|
range: "500 feet",
|
||||||
|
area: "20-foot burst",
|
||||||
|
defense: "basic Reflex",
|
||||||
|
actionCost: "2",
|
||||||
|
heightening: "Heightened (+1) The damage increases by 2d6.",
|
||||||
|
};
|
||||||
|
|
||||||
|
const ANCHOR: DOMRect = new DOMRect(100, 100, 50, 20);
|
||||||
|
|
||||||
|
const SPARK_LEAPS_REGEX = /spark leaps/;
|
||||||
|
const HEIGHTENED_REGEX = /Heightened.*2d6/;
|
||||||
|
const RANGE_REGEX = /500 feet/;
|
||||||
|
const AREA_REGEX = /20-foot burst/;
|
||||||
|
const DEFENSE_REGEX = /basic Reflex/;
|
||||||
|
const NO_DESCRIPTION_REGEX = /No description available/;
|
||||||
|
const DIALOG_LABEL_REGEX = /Spell details: Fireball/;
|
||||||
|
|
||||||
|
beforeEach(() => {
|
||||||
|
// Force desktop variant in jsdom
|
||||||
|
Object.defineProperty(globalThis, "matchMedia", {
|
||||||
|
writable: true,
|
||||||
|
configurable: true,
|
||||||
|
value: vi.fn().mockImplementation(() => ({
|
||||||
|
matches: true,
|
||||||
|
media: "(min-width: 1024px)",
|
||||||
|
onchange: null,
|
||||||
|
addEventListener: vi.fn(),
|
||||||
|
removeEventListener: vi.fn(),
|
||||||
|
addListener: vi.fn(),
|
||||||
|
removeListener: vi.fn(),
|
||||||
|
dispatchEvent: vi.fn(),
|
||||||
|
})),
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe("SpellDetailPopover", () => {
|
||||||
|
it("renders spell name, rank, traits, and description", () => {
|
||||||
|
render(
|
||||||
|
<SpellDetailPopover
|
||||||
|
spell={FIREBALL}
|
||||||
|
anchorRect={ANCHOR}
|
||||||
|
onClose={() => {}}
|
||||||
|
/>,
|
||||||
|
);
|
||||||
|
expect(screen.getByText("Fireball")).toBeInTheDocument();
|
||||||
|
expect(screen.getByText("3rd")).toBeInTheDocument();
|
||||||
|
expect(screen.getByText("fire")).toBeInTheDocument();
|
||||||
|
expect(screen.getByText("manipulate")).toBeInTheDocument();
|
||||||
|
expect(screen.getByText(SPARK_LEAPS_REGEX)).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it("renders heightening rules when present", () => {
|
||||||
|
render(
|
||||||
|
<SpellDetailPopover
|
||||||
|
spell={FIREBALL}
|
||||||
|
anchorRect={ANCHOR}
|
||||||
|
onClose={() => {}}
|
||||||
|
/>,
|
||||||
|
);
|
||||||
|
expect(screen.getByText(HEIGHTENED_REGEX)).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it("renders range, area, and defense", () => {
|
||||||
|
render(
|
||||||
|
<SpellDetailPopover
|
||||||
|
spell={FIREBALL}
|
||||||
|
anchorRect={ANCHOR}
|
||||||
|
onClose={() => {}}
|
||||||
|
/>,
|
||||||
|
);
|
||||||
|
expect(screen.getByText(RANGE_REGEX)).toBeInTheDocument();
|
||||||
|
expect(screen.getByText(AREA_REGEX)).toBeInTheDocument();
|
||||||
|
expect(screen.getByText(DEFENSE_REGEX)).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it("calls onClose when Escape is pressed", () => {
|
||||||
|
const onClose = vi.fn();
|
||||||
|
render(
|
||||||
|
<SpellDetailPopover
|
||||||
|
spell={FIREBALL}
|
||||||
|
anchorRect={ANCHOR}
|
||||||
|
onClose={onClose}
|
||||||
|
/>,
|
||||||
|
);
|
||||||
|
fireEvent.keyDown(document, { key: "Escape" });
|
||||||
|
expect(onClose).toHaveBeenCalledTimes(1);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("shows placeholder when description is missing", () => {
|
||||||
|
const spell: SpellReference = { name: "Mystery", rank: 1 };
|
||||||
|
render(
|
||||||
|
<SpellDetailPopover
|
||||||
|
spell={spell}
|
||||||
|
anchorRect={ANCHOR}
|
||||||
|
onClose={() => {}}
|
||||||
|
/>,
|
||||||
|
);
|
||||||
|
expect(screen.getByText(NO_DESCRIPTION_REGEX)).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it("renders the action cost as an icon when it is a numeric action count", () => {
|
||||||
|
render(
|
||||||
|
<SpellDetailPopover
|
||||||
|
spell={FIREBALL}
|
||||||
|
anchorRect={ANCHOR}
|
||||||
|
onClose={() => {}}
|
||||||
|
/>,
|
||||||
|
);
|
||||||
|
// Action cost "2" renders as an SVG ActivityIcon (portaled to body)
|
||||||
|
const dialog = screen.getByRole("dialog");
|
||||||
|
expect(dialog.querySelector("svg")).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it("renders non-numeric action cost as text", () => {
|
||||||
|
const spell: SpellReference = {
|
||||||
|
...FIREBALL,
|
||||||
|
actionCost: "1 minute",
|
||||||
|
};
|
||||||
|
render(
|
||||||
|
<SpellDetailPopover
|
||||||
|
spell={spell}
|
||||||
|
anchorRect={ANCHOR}
|
||||||
|
onClose={() => {}}
|
||||||
|
/>,
|
||||||
|
);
|
||||||
|
expect(screen.getByText("1 minute")).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it("uses the dialog role with the spell name as label", () => {
|
||||||
|
render(
|
||||||
|
<SpellDetailPopover
|
||||||
|
spell={FIREBALL}
|
||||||
|
anchorRect={ANCHOR}
|
||||||
|
onClose={() => {}}
|
||||||
|
/>,
|
||||||
|
);
|
||||||
|
expect(
|
||||||
|
screen.getByRole("dialog", { name: DIALOG_LABEL_REGEX }),
|
||||||
|
).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -111,9 +111,15 @@ const DRAGON: Creature = {
|
|||||||
{
|
{
|
||||||
name: "Innate Spellcasting",
|
name: "Innate Spellcasting",
|
||||||
headerText: "The dragon's spellcasting ability is Charisma.",
|
headerText: "The dragon's spellcasting ability is Charisma.",
|
||||||
atWill: ["detect magic", "suggestion"],
|
atWill: [{ name: "detect magic" }, { name: "suggestion" }],
|
||||||
daily: [{ uses: 3, each: true, spells: ["fireball", "wall of fire"] }],
|
daily: [
|
||||||
restLong: [{ uses: 1, each: false, spells: ["wish"] }],
|
{
|
||||||
|
uses: 3,
|
||||||
|
each: true,
|
||||||
|
spells: [{ name: "fireball" }, { name: "wall of fire" }],
|
||||||
|
},
|
||||||
|
],
|
||||||
|
restLong: [{ uses: 1, each: false, spells: [{ name: "wish" }] }],
|
||||||
},
|
},
|
||||||
],
|
],
|
||||||
};
|
};
|
||||||
|
|||||||
@@ -12,7 +12,7 @@ const DND_BASE_URL =
|
|||||||
"https://raw.githubusercontent.com/5etools-mirror-3/5etools-src/main/data/bestiary/";
|
"https://raw.githubusercontent.com/5etools-mirror-3/5etools-src/main/data/bestiary/";
|
||||||
|
|
||||||
const PF2E_BASE_URL =
|
const PF2E_BASE_URL =
|
||||||
"https://raw.githubusercontent.com/Pf2eToolsOrg/Pf2eTools/dev/data/bestiary/";
|
"https://raw.githubusercontent.com/foundryvtt/pf2e/v13-dev/packs/pf2e/";
|
||||||
|
|
||||||
export function BulkImportPrompt() {
|
export function BulkImportPrompt() {
|
||||||
const { bestiaryIndex, pf2eBestiaryIndex } = useAdapters();
|
const { bestiaryIndex, pf2eBestiaryIndex } = useAdapters();
|
||||||
|
|||||||
@@ -10,6 +10,7 @@ import { Brain, Pencil, X } from "lucide-react";
|
|||||||
import { type Ref, useCallback, useEffect, useRef, useState } from "react";
|
import { type Ref, useCallback, useEffect, useRef, useState } from "react";
|
||||||
import { useEncounterContext } from "../contexts/encounter-context.js";
|
import { useEncounterContext } from "../contexts/encounter-context.js";
|
||||||
import { useInitiativeRollsContext } from "../contexts/initiative-rolls-context.js";
|
import { useInitiativeRollsContext } from "../contexts/initiative-rolls-context.js";
|
||||||
|
import { useRulesEditionContext } from "../contexts/rules-edition-context.js";
|
||||||
import { useSidePanelContext } from "../contexts/side-panel-context.js";
|
import { useSidePanelContext } from "../contexts/side-panel-context.js";
|
||||||
import { useLongPress } from "../hooks/use-long-press.js";
|
import { useLongPress } from "../hooks/use-long-press.js";
|
||||||
import { cn } from "../lib/utils.js";
|
import { cn } from "../lib/utils.js";
|
||||||
@@ -415,12 +416,14 @@ function InitiativeDisplay({
|
|||||||
function rowBorderClass(
|
function rowBorderClass(
|
||||||
isActive: boolean,
|
isActive: boolean,
|
||||||
isConcentrating: boolean | undefined,
|
isConcentrating: boolean | undefined,
|
||||||
|
isPf2e: boolean,
|
||||||
): string {
|
): string {
|
||||||
if (isActive && isConcentrating)
|
const showConcentration = isConcentrating && !isPf2e;
|
||||||
|
if (isActive && showConcentration)
|
||||||
return "border border-l-2 border-active-row-border border-l-purple-400 bg-active-row-bg card-glow";
|
return "border border-l-2 border-active-row-border border-l-purple-400 bg-active-row-bg card-glow";
|
||||||
if (isActive)
|
if (isActive)
|
||||||
return "border border-l-2 border-active-row-border bg-active-row-bg card-glow";
|
return "border border-l-2 border-active-row-border bg-active-row-bg card-glow";
|
||||||
if (isConcentrating)
|
if (showConcentration)
|
||||||
return "border border-l-2 border-transparent border-l-purple-400";
|
return "border border-l-2 border-transparent border-l-purple-400";
|
||||||
return "border border-l-2 border-transparent";
|
return "border border-l-2 border-transparent";
|
||||||
}
|
}
|
||||||
@@ -455,6 +458,8 @@ export function CombatantRow({
|
|||||||
const { selectedCreatureId, showCreature, toggleCollapse } =
|
const { selectedCreatureId, showCreature, toggleCollapse } =
|
||||||
useSidePanelContext();
|
useSidePanelContext();
|
||||||
const { handleRollInitiative } = useInitiativeRollsContext();
|
const { handleRollInitiative } = useInitiativeRollsContext();
|
||||||
|
const { edition } = useRulesEditionContext();
|
||||||
|
const isPf2e = edition === "pf2e";
|
||||||
|
|
||||||
// Derive what was previously conditional props
|
// Derive what was previously conditional props
|
||||||
const isStatBlockOpen = combatant.creatureId === selectedCreatureId;
|
const isStatBlockOpen = combatant.creatureId === selectedCreatureId;
|
||||||
@@ -495,12 +500,16 @@ export function CombatantRow({
|
|||||||
const tempHpDropped =
|
const tempHpDropped =
|
||||||
prevTempHp !== undefined && (combatant.tempHp ?? 0) < prevTempHp;
|
prevTempHp !== undefined && (combatant.tempHp ?? 0) < prevTempHp;
|
||||||
|
|
||||||
if ((realHpDropped || tempHpDropped) && combatant.isConcentrating) {
|
if (
|
||||||
|
(realHpDropped || tempHpDropped) &&
|
||||||
|
combatant.isConcentrating &&
|
||||||
|
!isPf2e
|
||||||
|
) {
|
||||||
setIsPulsing(true);
|
setIsPulsing(true);
|
||||||
clearTimeout(pulseTimerRef.current);
|
clearTimeout(pulseTimerRef.current);
|
||||||
pulseTimerRef.current = setTimeout(() => setIsPulsing(false), 1200);
|
pulseTimerRef.current = setTimeout(() => setIsPulsing(false), 1200);
|
||||||
}
|
}
|
||||||
}, [currentHp, combatant.tempHp, combatant.isConcentrating]);
|
}, [currentHp, combatant.tempHp, combatant.isConcentrating, isPf2e]);
|
||||||
|
|
||||||
useEffect(() => {
|
useEffect(() => {
|
||||||
if (!combatant.isConcentrating) {
|
if (!combatant.isConcentrating) {
|
||||||
@@ -518,24 +527,33 @@ export function CombatantRow({
|
|||||||
ref={ref}
|
ref={ref}
|
||||||
className={cn(
|
className={cn(
|
||||||
"group rounded-lg pr-3 transition-colors",
|
"group rounded-lg pr-3 transition-colors",
|
||||||
rowBorderClass(isActive, combatant.isConcentrating),
|
rowBorderClass(isActive, combatant.isConcentrating, isPf2e),
|
||||||
isPulsing && "animate-concentration-pulse",
|
isPulsing && "animate-concentration-pulse",
|
||||||
)}
|
)}
|
||||||
>
|
>
|
||||||
<div className="grid grid-cols-[2rem_3rem_auto_1fr_auto_2rem] items-center gap-1.5 py-3 sm:grid-cols-[2rem_3.5rem_auto_1fr_auto_2rem] sm:gap-3 sm:py-2">
|
<div
|
||||||
{/* Concentration */}
|
className={cn(
|
||||||
<button
|
"grid items-center gap-1.5 py-3 sm:gap-3 sm:py-2",
|
||||||
type="button"
|
isPf2e
|
||||||
onClick={() => toggleConcentration(id)}
|
? "grid-cols-[3rem_auto_1fr_auto_2rem] pl-3 sm:grid-cols-[3.5rem_auto_1fr_auto_2rem]"
|
||||||
title="Concentrating"
|
: "grid-cols-[2rem_3rem_auto_1fr_auto_2rem] sm:grid-cols-[2rem_3.5rem_auto_1fr_auto_2rem]",
|
||||||
aria-label="Toggle concentration"
|
)}
|
||||||
className={cn(
|
>
|
||||||
"-my-2 -ml-[2px] flex w-full items-center justify-center self-stretch pl-[14px] transition-opacity hover:text-hover-neutral hover:opacity-100",
|
{/* Concentration — hidden in PF2e mode */}
|
||||||
concentrationIconClass(combatant.isConcentrating, dimmed),
|
{!isPf2e && (
|
||||||
)}
|
<button
|
||||||
>
|
type="button"
|
||||||
<Brain size={16} />
|
onClick={() => toggleConcentration(id)}
|
||||||
</button>
|
title="Concentrating"
|
||||||
|
aria-label="Toggle concentration"
|
||||||
|
className={cn(
|
||||||
|
"-my-2 -ml-[2px] flex w-full items-center justify-center self-stretch pl-[14px] transition-opacity hover:text-hover-neutral hover:opacity-100",
|
||||||
|
concentrationIconClass(combatant.isConcentrating, dimmed),
|
||||||
|
)}
|
||||||
|
>
|
||||||
|
<Brain size={16} />
|
||||||
|
</button>
|
||||||
|
)}
|
||||||
|
|
||||||
{/* Initiative */}
|
{/* Initiative */}
|
||||||
<div className="rounded-md bg-muted/30 px-1">
|
<div className="rounded-md bg-muted/30 px-1">
|
||||||
|
|||||||
@@ -162,20 +162,35 @@ export function ConditionPicker({
|
|||||||
<span className="min-w-5 rounded-full bg-accent px-1.5 py-0.5 text-center font-medium text-primary-foreground text-xs">
|
<span className="min-w-5 rounded-full bg-accent px-1.5 py-0.5 text-center font-medium text-primary-foreground text-xs">
|
||||||
{editing.value}
|
{editing.value}
|
||||||
</span>
|
</span>
|
||||||
<button
|
{(() => {
|
||||||
type="button"
|
const atMax =
|
||||||
className="rounded p-0.5 text-foreground hover:bg-accent/40"
|
def.maxValue !== undefined &&
|
||||||
onMouseDown={(e) => e.preventDefault()}
|
editing.value >= def.maxValue;
|
||||||
onClick={(e) => {
|
return (
|
||||||
e.stopPropagation();
|
<button
|
||||||
setEditing({
|
type="button"
|
||||||
...editing,
|
className={cn(
|
||||||
value: editing.value + 1,
|
"rounded p-0.5",
|
||||||
});
|
atMax
|
||||||
}}
|
? "cursor-not-allowed text-muted-foreground opacity-50"
|
||||||
>
|
: "text-foreground hover:bg-accent/40",
|
||||||
<Plus className="h-3 w-3" />
|
)}
|
||||||
</button>
|
disabled={atMax}
|
||||||
|
onMouseDown={(e) => e.preventDefault()}
|
||||||
|
onClick={(e) => {
|
||||||
|
e.stopPropagation();
|
||||||
|
if (!atMax) {
|
||||||
|
setEditing({
|
||||||
|
...editing,
|
||||||
|
value: editing.value + 1,
|
||||||
|
});
|
||||||
|
}
|
||||||
|
}}
|
||||||
|
>
|
||||||
|
<Plus className="h-3 w-3" />
|
||||||
|
</button>
|
||||||
|
);
|
||||||
|
})()}
|
||||||
<button
|
<button
|
||||||
type="button"
|
type="button"
|
||||||
className="ml-0.5 rounded p-0.5 text-foreground hover:bg-accent/40"
|
className="ml-0.5 rounded p-0.5 text-foreground hover:bg-accent/40"
|
||||||
|
|||||||
@@ -134,7 +134,7 @@ export function DndStatBlock({ creature }: Readonly<DndStatBlockProps>) {
|
|||||||
{sc.atWill && sc.atWill.length > 0 && (
|
{sc.atWill && sc.atWill.length > 0 && (
|
||||||
<div className="pl-2">
|
<div className="pl-2">
|
||||||
<span className="font-semibold">At Will:</span>{" "}
|
<span className="font-semibold">At Will:</span>{" "}
|
||||||
{sc.atWill.join(", ")}
|
{sc.atWill.map((s) => s.name).join(", ")}
|
||||||
</div>
|
</div>
|
||||||
)}
|
)}
|
||||||
{sc.daily?.map((d) => (
|
{sc.daily?.map((d) => (
|
||||||
@@ -143,7 +143,7 @@ export function DndStatBlock({ creature }: Readonly<DndStatBlockProps>) {
|
|||||||
{d.uses}/day
|
{d.uses}/day
|
||||||
{d.each ? " each" : ""}:
|
{d.each ? " each" : ""}:
|
||||||
</span>{" "}
|
</span>{" "}
|
||||||
{d.spells.join(", ")}
|
{d.spells.map((s) => s.name).join(", ")}
|
||||||
</div>
|
</div>
|
||||||
))}
|
))}
|
||||||
{sc.restLong?.map((d) => (
|
{sc.restLong?.map((d) => (
|
||||||
@@ -155,7 +155,7 @@ export function DndStatBlock({ creature }: Readonly<DndStatBlockProps>) {
|
|||||||
{d.uses}/long rest
|
{d.uses}/long rest
|
||||||
{d.each ? " each" : ""}:
|
{d.each ? " each" : ""}:
|
||||||
</span>{" "}
|
</span>{" "}
|
||||||
{d.spells.join(", ")}
|
{d.spells.map((s) => s.name).join(", ")}
|
||||||
</div>
|
</div>
|
||||||
))}
|
))}
|
||||||
</div>
|
</div>
|
||||||
|
|||||||
@@ -1,5 +1,7 @@
|
|||||||
import type { Pf2eCreature } from "@initiative/domain";
|
import type { Pf2eCreature, SpellReference } from "@initiative/domain";
|
||||||
import { formatInitiativeModifier } from "@initiative/domain";
|
import { formatInitiativeModifier } from "@initiative/domain";
|
||||||
|
import { useCallback, useRef, useState } from "react";
|
||||||
|
import { SpellDetailPopover } from "./spell-detail-popover.js";
|
||||||
import {
|
import {
|
||||||
PropertyLine,
|
PropertyLine,
|
||||||
SectionDivider,
|
SectionDivider,
|
||||||
@@ -34,7 +36,83 @@ function formatMod(mod: number): string {
|
|||||||
return mod >= 0 ? `+${mod}` : `${mod}`;
|
return mod >= 0 ? `+${mod}` : `${mod}`;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
interface SpellLinkProps {
|
||||||
|
readonly spell: SpellReference;
|
||||||
|
readonly onOpen: (spell: SpellReference, rect: DOMRect) => void;
|
||||||
|
}
|
||||||
|
|
||||||
|
function UsesPerDay({ count }: Readonly<{ count: number | undefined }>) {
|
||||||
|
if (count === undefined || count <= 1) return null;
|
||||||
|
return <span> (×{count})</span>;
|
||||||
|
}
|
||||||
|
|
||||||
|
function SpellLink({ spell, onOpen }: Readonly<SpellLinkProps>) {
|
||||||
|
const ref = useRef<HTMLButtonElement>(null);
|
||||||
|
const handleClick = useCallback(() => {
|
||||||
|
if (!spell.description) return;
|
||||||
|
const rect = ref.current?.getBoundingClientRect();
|
||||||
|
if (rect) onOpen(spell, rect);
|
||||||
|
}, [spell, onOpen]);
|
||||||
|
|
||||||
|
if (!spell.description) {
|
||||||
|
return (
|
||||||
|
<span>
|
||||||
|
{spell.name}
|
||||||
|
<UsesPerDay count={spell.usesPerDay} />
|
||||||
|
</span>
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
return (
|
||||||
|
<>
|
||||||
|
<button
|
||||||
|
ref={ref}
|
||||||
|
type="button"
|
||||||
|
onClick={handleClick}
|
||||||
|
className="cursor-pointer text-foreground underline decoration-dotted underline-offset-2 hover:text-hover-neutral"
|
||||||
|
>
|
||||||
|
{spell.name}
|
||||||
|
</button>
|
||||||
|
<UsesPerDay count={spell.usesPerDay} />
|
||||||
|
</>
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
interface SpellListLineProps {
|
||||||
|
readonly label: string;
|
||||||
|
readonly spells: readonly SpellReference[];
|
||||||
|
readonly onOpen: (spell: SpellReference, rect: DOMRect) => void;
|
||||||
|
}
|
||||||
|
|
||||||
|
function SpellListLine({
|
||||||
|
label,
|
||||||
|
spells,
|
||||||
|
onOpen,
|
||||||
|
}: Readonly<SpellListLineProps>) {
|
||||||
|
return (
|
||||||
|
<div className="pl-2">
|
||||||
|
<span className="font-semibold">{label}:</span>{" "}
|
||||||
|
{spells.map((spell, i) => (
|
||||||
|
<span key={spell.slug ?? spell.name}>
|
||||||
|
{i > 0 ? ", " : ""}
|
||||||
|
<SpellLink spell={spell} onOpen={onOpen} />
|
||||||
|
</span>
|
||||||
|
))}
|
||||||
|
</div>
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
export function Pf2eStatBlock({ creature }: Readonly<Pf2eStatBlockProps>) {
|
export function Pf2eStatBlock({ creature }: Readonly<Pf2eStatBlockProps>) {
|
||||||
|
const [openSpell, setOpenSpell] = useState<{
|
||||||
|
spell: SpellReference;
|
||||||
|
rect: DOMRect;
|
||||||
|
} | null>(null);
|
||||||
|
const handleOpenSpell = useCallback(
|
||||||
|
(spell: SpellReference, rect: DOMRect) => setOpenSpell({ spell, rect }),
|
||||||
|
[],
|
||||||
|
);
|
||||||
|
const handleCloseSpell = useCallback(() => setOpenSpell(null), []);
|
||||||
|
|
||||||
const abilityEntries = [
|
const abilityEntries = [
|
||||||
{ label: "Str", mod: creature.abilityMods.str },
|
{ label: "Str", mod: creature.abilityMods.str },
|
||||||
{ label: "Dex", mod: creature.abilityMods.dex },
|
{ label: "Dex", mod: creature.abilityMods.dex },
|
||||||
@@ -114,9 +192,11 @@ export function Pf2eStatBlock({ creature }: Readonly<Pf2eStatBlockProps>) {
|
|||||||
{formatMod(creature.saveRef)},{" "}
|
{formatMod(creature.saveRef)},{" "}
|
||||||
<span className="font-semibold">Will</span>{" "}
|
<span className="font-semibold">Will</span>{" "}
|
||||||
{formatMod(creature.saveWill)}
|
{formatMod(creature.saveWill)}
|
||||||
|
{creature.saveConditional ? `; ${creature.saveConditional}` : ""}
|
||||||
</div>
|
</div>
|
||||||
<div>
|
<div>
|
||||||
<span className="font-semibold">HP</span> {creature.hp}
|
<span className="font-semibold">HP</span> {creature.hp}
|
||||||
|
{creature.hpDetails ? ` (${creature.hpDetails})` : ""}
|
||||||
</div>
|
</div>
|
||||||
<PropertyLine label="Immunities" value={creature.immunities} />
|
<PropertyLine label="Immunities" value={creature.immunities} />
|
||||||
<PropertyLine label="Resistances" value={creature.resistances} />
|
<PropertyLine label="Resistances" value={creature.resistances} />
|
||||||
@@ -138,6 +218,43 @@ export function Pf2eStatBlock({ creature }: Readonly<Pf2eStatBlockProps>) {
|
|||||||
|
|
||||||
{/* Bottom abilities (active abilities) */}
|
{/* Bottom abilities (active abilities) */}
|
||||||
<TraitSection entries={creature.abilitiesBot} />
|
<TraitSection entries={creature.abilitiesBot} />
|
||||||
|
|
||||||
|
{/* Spellcasting */}
|
||||||
|
{creature.spellcasting && creature.spellcasting.length > 0 && (
|
||||||
|
<>
|
||||||
|
<SectionDivider />
|
||||||
|
{creature.spellcasting.map((sc) => (
|
||||||
|
<div key={sc.name} className="space-y-1 text-sm">
|
||||||
|
<div>
|
||||||
|
<span className="font-semibold italic">{sc.name}.</span>{" "}
|
||||||
|
{sc.headerText}
|
||||||
|
</div>
|
||||||
|
{sc.daily?.map((d) => (
|
||||||
|
<SpellListLine
|
||||||
|
key={d.uses}
|
||||||
|
label={d.uses === 0 ? "Cantrips" : `Rank ${d.uses}`}
|
||||||
|
spells={d.spells}
|
||||||
|
onOpen={handleOpenSpell}
|
||||||
|
/>
|
||||||
|
))}
|
||||||
|
{sc.atWill && sc.atWill.length > 0 && (
|
||||||
|
<SpellListLine
|
||||||
|
label="Cantrips"
|
||||||
|
spells={sc.atWill}
|
||||||
|
onOpen={handleOpenSpell}
|
||||||
|
/>
|
||||||
|
)}
|
||||||
|
</div>
|
||||||
|
))}
|
||||||
|
</>
|
||||||
|
)}
|
||||||
|
{openSpell ? (
|
||||||
|
<SpellDetailPopover
|
||||||
|
spell={openSpell.spell}
|
||||||
|
anchorRect={openSpell.rect}
|
||||||
|
onClose={handleCloseSpell}
|
||||||
|
/>
|
||||||
|
) : null}
|
||||||
</div>
|
</div>
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|||||||
296
apps/web/src/components/spell-detail-popover.tsx
Normal file
296
apps/web/src/components/spell-detail-popover.tsx
Normal file
@@ -0,0 +1,296 @@
|
|||||||
|
import type { ActivityCost, SpellReference } from "@initiative/domain";
|
||||||
|
import { useEffect, useLayoutEffect, useRef, useState } from "react";
|
||||||
|
import { createPortal } from "react-dom";
|
||||||
|
import { useClickOutside } from "../hooks/use-click-outside.js";
|
||||||
|
import { useSwipeToDismissDown } from "../hooks/use-swipe-to-dismiss.js";
|
||||||
|
import { cn } from "../lib/utils.js";
|
||||||
|
import { ActivityIcon } from "./stat-block-parts.js";
|
||||||
|
|
||||||
|
interface SpellDetailPopoverProps {
|
||||||
|
readonly spell: SpellReference;
|
||||||
|
readonly anchorRect: DOMRect;
|
||||||
|
readonly onClose: () => void;
|
||||||
|
}
|
||||||
|
|
||||||
|
const RANK_LABELS = [
|
||||||
|
"Cantrip",
|
||||||
|
"1st",
|
||||||
|
"2nd",
|
||||||
|
"3rd",
|
||||||
|
"4th",
|
||||||
|
"5th",
|
||||||
|
"6th",
|
||||||
|
"7th",
|
||||||
|
"8th",
|
||||||
|
"9th",
|
||||||
|
"10th",
|
||||||
|
];
|
||||||
|
|
||||||
|
function formatRank(rank: number | undefined): string {
|
||||||
|
if (rank === undefined) return "";
|
||||||
|
return RANK_LABELS[rank] ?? `Rank ${rank}`;
|
||||||
|
}
|
||||||
|
|
||||||
|
function parseActionCost(cost: string): ActivityCost | null {
|
||||||
|
if (cost === "free") return { number: 1, unit: "free" };
|
||||||
|
if (cost === "reaction") return { number: 1, unit: "reaction" };
|
||||||
|
const n = Number(cost);
|
||||||
|
if (n >= 1 && n <= 3) return { number: n, unit: "action" };
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
|
||||||
|
function SpellActionCost({ cost }: Readonly<{ cost: string | undefined }>) {
|
||||||
|
if (!cost) return null;
|
||||||
|
const activity = parseActionCost(cost);
|
||||||
|
if (activity) {
|
||||||
|
return (
|
||||||
|
<span className="shrink-0 text-lg">
|
||||||
|
<ActivityIcon activity={activity} />
|
||||||
|
</span>
|
||||||
|
);
|
||||||
|
}
|
||||||
|
return <span className="shrink-0 text-muted-foreground text-xs">{cost}</span>;
|
||||||
|
}
|
||||||
|
|
||||||
|
function SpellHeader({ spell }: Readonly<{ spell: SpellReference }>) {
|
||||||
|
return (
|
||||||
|
<div className="flex items-center justify-between gap-2">
|
||||||
|
<h3 className="font-bold text-lg text-stat-heading">{spell.name}</h3>
|
||||||
|
<SpellActionCost cost={spell.actionCost} />
|
||||||
|
</div>
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
function SpellTraits({ traits }: Readonly<{ traits: readonly string[] }>) {
|
||||||
|
if (traits.length === 0) return null;
|
||||||
|
return (
|
||||||
|
<div className="flex flex-wrap gap-1">
|
||||||
|
{traits.map((t) => (
|
||||||
|
<span
|
||||||
|
key={t}
|
||||||
|
className="rounded border border-border bg-card px-1.5 py-0.5 text-foreground text-xs"
|
||||||
|
>
|
||||||
|
{t}
|
||||||
|
</span>
|
||||||
|
))}
|
||||||
|
</div>
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
function LabeledValue({
|
||||||
|
label,
|
||||||
|
value,
|
||||||
|
}: Readonly<{ label: string; value: string }>) {
|
||||||
|
return (
|
||||||
|
<>
|
||||||
|
<span className="font-semibold">{label}</span> {value}
|
||||||
|
</>
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
function SpellRangeLine({ spell }: Readonly<{ spell: SpellReference }>) {
|
||||||
|
const items: { label: string; value: string }[] = [];
|
||||||
|
if (spell.range) items.push({ label: "Range", value: spell.range });
|
||||||
|
if (spell.target) items.push({ label: "Target", value: spell.target });
|
||||||
|
if (spell.area) items.push({ label: "Area", value: spell.area });
|
||||||
|
|
||||||
|
if (items.length === 0) return null;
|
||||||
|
return (
|
||||||
|
<div>
|
||||||
|
{items.map((item, i) => (
|
||||||
|
<span key={item.label}>
|
||||||
|
{i > 0 ? "; " : ""}
|
||||||
|
<LabeledValue label={item.label} value={item.value} />
|
||||||
|
</span>
|
||||||
|
))}
|
||||||
|
</div>
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
function SpellMeta({ spell }: Readonly<{ spell: SpellReference }>) {
|
||||||
|
const hasTraditions =
|
||||||
|
spell.traditions !== undefined && spell.traditions.length > 0;
|
||||||
|
return (
|
||||||
|
<div className="space-y-0.5 text-xs">
|
||||||
|
{spell.rank === undefined ? null : (
|
||||||
|
<div>
|
||||||
|
<span className="font-semibold">{formatRank(spell.rank)}</span>
|
||||||
|
{hasTraditions ? (
|
||||||
|
<span className="text-muted-foreground">
|
||||||
|
{" "}
|
||||||
|
({spell.traditions?.join(", ")})
|
||||||
|
</span>
|
||||||
|
) : null}
|
||||||
|
</div>
|
||||||
|
)}
|
||||||
|
<SpellRangeLine spell={spell} />
|
||||||
|
{spell.duration ? (
|
||||||
|
<div>
|
||||||
|
<LabeledValue label="Duration" value={spell.duration} />
|
||||||
|
</div>
|
||||||
|
) : null}
|
||||||
|
{spell.defense ? (
|
||||||
|
<div>
|
||||||
|
<LabeledValue label="Defense" value={spell.defense} />
|
||||||
|
</div>
|
||||||
|
) : null}
|
||||||
|
</div>
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
const SAVE_OUTCOME_REGEX =
|
||||||
|
/(Critical Success|Critical Failure|Success|Failure)/g;
|
||||||
|
|
||||||
|
function SpellDescription({ text }: Readonly<{ text: string }>) {
|
||||||
|
const parts = text.split(SAVE_OUTCOME_REGEX);
|
||||||
|
const elements: React.ReactNode[] = [];
|
||||||
|
let offset = 0;
|
||||||
|
for (const part of parts) {
|
||||||
|
if (SAVE_OUTCOME_REGEX.test(part)) {
|
||||||
|
elements.push(<strong key={`b-${offset}`}>{part}</strong>);
|
||||||
|
} else if (part) {
|
||||||
|
elements.push(<span key={`t-${offset}`}>{part}</span>);
|
||||||
|
}
|
||||||
|
offset += part.length;
|
||||||
|
}
|
||||||
|
return <p className="whitespace-pre-line text-foreground">{elements}</p>;
|
||||||
|
}
|
||||||
|
|
||||||
|
function SpellDetailContent({ spell }: Readonly<{ spell: SpellReference }>) {
|
||||||
|
return (
|
||||||
|
<div className="space-y-2 text-sm">
|
||||||
|
<SpellHeader spell={spell} />
|
||||||
|
<SpellTraits traits={spell.traits ?? []} />
|
||||||
|
<SpellMeta spell={spell} />
|
||||||
|
{spell.description ? (
|
||||||
|
<SpellDescription text={spell.description} />
|
||||||
|
) : (
|
||||||
|
<p className="text-muted-foreground italic">
|
||||||
|
No description available.
|
||||||
|
</p>
|
||||||
|
)}
|
||||||
|
{spell.heightening ? (
|
||||||
|
<p className="whitespace-pre-line text-foreground text-xs">
|
||||||
|
{spell.heightening}
|
||||||
|
</p>
|
||||||
|
) : null}
|
||||||
|
</div>
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
function DesktopPopover({
|
||||||
|
spell,
|
||||||
|
anchorRect,
|
||||||
|
onClose,
|
||||||
|
}: Readonly<SpellDetailPopoverProps>) {
|
||||||
|
const ref = useRef<HTMLDivElement>(null);
|
||||||
|
const [pos, setPos] = useState<{ top: number; left: number } | null>(null);
|
||||||
|
|
||||||
|
useLayoutEffect(() => {
|
||||||
|
const el = ref.current;
|
||||||
|
if (!el) return;
|
||||||
|
const popover = el.getBoundingClientRect();
|
||||||
|
const vw = document.documentElement.clientWidth;
|
||||||
|
const vh = document.documentElement.clientHeight;
|
||||||
|
// Prefer placement to the LEFT of the anchor (panel is on the right edge)
|
||||||
|
let left = anchorRect.left - popover.width - 8;
|
||||||
|
if (left < 8) {
|
||||||
|
left = anchorRect.right + 8;
|
||||||
|
}
|
||||||
|
if (left + popover.width > vw - 8) {
|
||||||
|
left = vw - popover.width - 8;
|
||||||
|
}
|
||||||
|
let top = anchorRect.top;
|
||||||
|
if (top + popover.height > vh - 8) {
|
||||||
|
top = vh - popover.height - 8;
|
||||||
|
}
|
||||||
|
if (top < 8) top = 8;
|
||||||
|
setPos({ top, left });
|
||||||
|
}, [anchorRect]);
|
||||||
|
|
||||||
|
useClickOutside(ref, onClose);
|
||||||
|
|
||||||
|
return (
|
||||||
|
<div
|
||||||
|
ref={ref}
|
||||||
|
className="card-glow fixed z-50 max-h-[calc(100vh-16px)] w-80 max-w-[calc(100vw-16px)] overflow-y-auto rounded-lg border border-border bg-card p-4 shadow-lg"
|
||||||
|
style={pos ? { top: pos.top, left: pos.left } : { visibility: "hidden" }}
|
||||||
|
role="dialog"
|
||||||
|
aria-label={`Spell details: ${spell.name}`}
|
||||||
|
>
|
||||||
|
<SpellDetailContent spell={spell} />
|
||||||
|
</div>
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
function MobileSheet({
|
||||||
|
spell,
|
||||||
|
onClose,
|
||||||
|
}: Readonly<{ spell: SpellReference; onClose: () => void }>) {
|
||||||
|
const { offsetY, isSwiping, handlers } = useSwipeToDismissDown(onClose);
|
||||||
|
|
||||||
|
useEffect(() => {
|
||||||
|
const handler = (e: KeyboardEvent) => {
|
||||||
|
if (e.key === "Escape") onClose();
|
||||||
|
};
|
||||||
|
document.addEventListener("keydown", handler);
|
||||||
|
return () => document.removeEventListener("keydown", handler);
|
||||||
|
}, [onClose]);
|
||||||
|
|
||||||
|
return (
|
||||||
|
<div className="fixed inset-0 z-50">
|
||||||
|
<button
|
||||||
|
type="button"
|
||||||
|
className="fade-in absolute inset-0 animate-in bg-black/50"
|
||||||
|
onClick={onClose}
|
||||||
|
aria-label="Close spell details"
|
||||||
|
/>
|
||||||
|
<div
|
||||||
|
className={cn(
|
||||||
|
"panel-glow absolute right-0 bottom-0 left-0 max-h-[80vh] rounded-t-2xl border-border border-t bg-card",
|
||||||
|
!isSwiping && "animate-slide-in-bottom",
|
||||||
|
)}
|
||||||
|
style={
|
||||||
|
isSwiping ? { transform: `translateY(${offsetY}px)` } : undefined
|
||||||
|
}
|
||||||
|
{...handlers}
|
||||||
|
role="dialog"
|
||||||
|
aria-label={`Spell details: ${spell.name}`}
|
||||||
|
>
|
||||||
|
<div className="flex justify-center pt-2 pb-1">
|
||||||
|
<div className="h-1 w-10 rounded-full bg-muted-foreground/40" />
|
||||||
|
</div>
|
||||||
|
<div className="max-h-[calc(80vh-24px)] overflow-y-auto p-4">
|
||||||
|
<SpellDetailContent spell={spell} />
|
||||||
|
</div>
|
||||||
|
</div>
|
||||||
|
</div>
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
export function SpellDetailPopover({
|
||||||
|
spell,
|
||||||
|
anchorRect,
|
||||||
|
onClose,
|
||||||
|
}: Readonly<SpellDetailPopoverProps>) {
|
||||||
|
const [isDesktop, setIsDesktop] = useState(
|
||||||
|
() => globalThis.matchMedia("(min-width: 1024px)").matches,
|
||||||
|
);
|
||||||
|
|
||||||
|
useEffect(() => {
|
||||||
|
const mq = globalThis.matchMedia("(min-width: 1024px)");
|
||||||
|
const handler = (e: MediaQueryListEvent) => setIsDesktop(e.matches);
|
||||||
|
mq.addEventListener("change", handler);
|
||||||
|
return () => mq.removeEventListener("change", handler);
|
||||||
|
}, []);
|
||||||
|
|
||||||
|
// Portal to document.body to escape any CSS transforms on ancestors
|
||||||
|
// (the side panel uses translate-x for collapse animation, which would
|
||||||
|
// otherwise become the containing block for fixed-positioned children).
|
||||||
|
const content = isDesktop ? (
|
||||||
|
<DesktopPopover spell={spell} anchorRect={anchorRect} onClose={onClose} />
|
||||||
|
) : (
|
||||||
|
<MobileSheet spell={spell} onClose={onClose} />
|
||||||
|
);
|
||||||
|
return createPortal(content, document.body);
|
||||||
|
}
|
||||||
@@ -21,7 +21,10 @@ interface StatBlockPanelProps {
|
|||||||
function extractSourceCode(cId: CreatureId): string {
|
function extractSourceCode(cId: CreatureId): string {
|
||||||
const colonIndex = cId.indexOf(":");
|
const colonIndex = cId.indexOf(":");
|
||||||
if (colonIndex === -1) return "";
|
if (colonIndex === -1) return "";
|
||||||
return cId.slice(0, colonIndex).toUpperCase();
|
const prefix = cId.slice(0, colonIndex);
|
||||||
|
// D&D source codes are short uppercase (e.g. "mm" from "MM").
|
||||||
|
// PF2e source codes use hyphens (e.g. "pathfinder-monster-core").
|
||||||
|
return prefix.includes("-") ? prefix : prefix.toUpperCase();
|
||||||
}
|
}
|
||||||
|
|
||||||
function CollapsedTab({
|
function CollapsedTab({
|
||||||
|
|||||||
@@ -1,4 +1,8 @@
|
|||||||
import type { TraitBlock, TraitSegment } from "@initiative/domain";
|
import type {
|
||||||
|
ActivityCost,
|
||||||
|
TraitBlock,
|
||||||
|
TraitSegment,
|
||||||
|
} from "@initiative/domain";
|
||||||
|
|
||||||
export function PropertyLine({
|
export function PropertyLine({
|
||||||
label,
|
label,
|
||||||
@@ -57,10 +61,95 @@ function TraitSegments({
|
|||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
const ACTION_DIAMOND = "M50 2 L96 50 L50 98 L4 50 Z M48 27 L71 50 L48 73 Z";
|
||||||
|
const ACTION_DIAMOND_SOLID = "M50 2 L96 50 L50 98 L4 50 Z";
|
||||||
|
const ACTION_DIAMOND_OUTLINE =
|
||||||
|
"M90 2 L136 50 L90 98 L44 50 Z M90 29 L111 50 L90 71 L69 50 Z";
|
||||||
|
const FREE_ACTION_DIAMOND =
|
||||||
|
"M50 2 L96 50 L50 98 L4 50 Z M50 12 L12 50 L50 88 L88 50 Z";
|
||||||
|
const FREE_ACTION_CHEVRON = "M48 27 L71 50 L48 73 Z";
|
||||||
|
const REACTION_ARROW =
|
||||||
|
"M75 15 A42 42 0 1 0 85 55 L72 55 A30 30 0 1 1 65 25 L65 40 L92 20 L65 0 L65 15 Z";
|
||||||
|
|
||||||
|
export function ActivityIcon({
|
||||||
|
activity,
|
||||||
|
}: Readonly<{ activity: ActivityCost }>) {
|
||||||
|
const cls = "inline-block h-[1em] align-[-0.1em]";
|
||||||
|
if (activity.unit === "free") {
|
||||||
|
return (
|
||||||
|
<svg aria-hidden="true" className={cls} viewBox="0 0 100 100">
|
||||||
|
<path d={FREE_ACTION_DIAMOND} fill="currentColor" fillRule="evenodd" />
|
||||||
|
<path d={FREE_ACTION_CHEVRON} fill="currentColor" />
|
||||||
|
</svg>
|
||||||
|
);
|
||||||
|
}
|
||||||
|
if (activity.unit === "reaction") {
|
||||||
|
return (
|
||||||
|
<svg aria-hidden="true" className={cls} viewBox="0 0 100 100">
|
||||||
|
<g transform="translate(100,100) rotate(180)">
|
||||||
|
<path d={REACTION_ARROW} fill="currentColor" />
|
||||||
|
</g>
|
||||||
|
</svg>
|
||||||
|
);
|
||||||
|
}
|
||||||
|
const count = activity.number;
|
||||||
|
if (count === 1) {
|
||||||
|
return (
|
||||||
|
<svg aria-hidden="true" className={cls} viewBox="0 0 100 100">
|
||||||
|
<path d={ACTION_DIAMOND} fill="currentColor" fillRule="evenodd" />
|
||||||
|
</svg>
|
||||||
|
);
|
||||||
|
}
|
||||||
|
if (count === 2) {
|
||||||
|
return (
|
||||||
|
<svg aria-hidden="true" className={cls} viewBox="0 0 140 100">
|
||||||
|
<path d={ACTION_DIAMOND_SOLID} fill="currentColor" />
|
||||||
|
<path
|
||||||
|
d={ACTION_DIAMOND_OUTLINE}
|
||||||
|
fill="currentColor"
|
||||||
|
fillRule="evenodd"
|
||||||
|
/>
|
||||||
|
</svg>
|
||||||
|
);
|
||||||
|
}
|
||||||
|
return (
|
||||||
|
<svg aria-hidden="true" className={cls} viewBox="0 0 180 100">
|
||||||
|
<path d={ACTION_DIAMOND_SOLID} fill="currentColor" />
|
||||||
|
<path d="M90 2 L136 50 L90 98 L44 50 Z" fill="currentColor" />
|
||||||
|
<path
|
||||||
|
d="M130 2 L176 50 L130 98 L84 50 Z M130 29 L151 50 L130 71 L109 50 Z"
|
||||||
|
fill="currentColor"
|
||||||
|
fillRule="evenodd"
|
||||||
|
/>
|
||||||
|
</svg>
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
export function TraitEntry({ trait }: Readonly<{ trait: TraitBlock }>) {
|
export function TraitEntry({ trait }: Readonly<{ trait: TraitBlock }>) {
|
||||||
return (
|
return (
|
||||||
<div className="text-sm">
|
<div className="text-sm">
|
||||||
<span className="font-semibold italic">{trait.name}.</span>
|
<span className="font-semibold italic">
|
||||||
|
{trait.name}
|
||||||
|
{trait.activity ? null : "."}
|
||||||
|
{trait.activity ? (
|
||||||
|
<>
|
||||||
|
{" "}
|
||||||
|
<ActivityIcon activity={trait.activity} />
|
||||||
|
</>
|
||||||
|
) : null}
|
||||||
|
</span>
|
||||||
|
{trait.trigger ? (
|
||||||
|
<>
|
||||||
|
{" "}
|
||||||
|
<span className="font-semibold">Trigger</span> {trait.trigger}
|
||||||
|
{trait.segments.length > 0 ? (
|
||||||
|
<>
|
||||||
|
{" "}
|
||||||
|
<span className="font-semibold">Effect</span>
|
||||||
|
</>
|
||||||
|
) : null}
|
||||||
|
</>
|
||||||
|
) : null}
|
||||||
<TraitSegments segments={trait.segments} />
|
<TraitSegments segments={trait.segments} />
|
||||||
</div>
|
</div>
|
||||||
);
|
);
|
||||||
|
|||||||
@@ -9,10 +9,7 @@ import {
|
|||||||
normalizeBestiary,
|
normalizeBestiary,
|
||||||
setSourceDisplayNames,
|
setSourceDisplayNames,
|
||||||
} from "../adapters/bestiary-adapter.js";
|
} from "../adapters/bestiary-adapter.js";
|
||||||
import {
|
import { normalizeFoundryCreatures } from "../adapters/pf2e-bestiary-adapter.js";
|
||||||
normalizePf2eBestiary,
|
|
||||||
setPf2eSourceDisplayNames,
|
|
||||||
} from "../adapters/pf2e-bestiary-adapter.js";
|
|
||||||
import { useAdapters } from "../contexts/adapter-context.js";
|
import { useAdapters } from "../contexts/adapter-context.js";
|
||||||
import { useRulesEditionContext } from "../contexts/rules-edition-context.js";
|
import { useRulesEditionContext } from "../contexts/rules-edition-context.js";
|
||||||
|
|
||||||
@@ -52,7 +49,6 @@ export function useBestiary(): BestiaryHook {
|
|||||||
setSourceDisplayNames(index.sources as Record<string, string>);
|
setSourceDisplayNames(index.sources as Record<string, string>);
|
||||||
|
|
||||||
const pf2eIndex = pf2eBestiaryIndex.loadIndex();
|
const pf2eIndex = pf2eBestiaryIndex.loadIndex();
|
||||||
setPf2eSourceDisplayNames(pf2eIndex.sources as Record<string, string>);
|
|
||||||
|
|
||||||
if (index.creatures.length > 0 || pf2eIndex.creatures.length > 0) {
|
if (index.creatures.length > 0 || pf2eIndex.creatures.length > 0) {
|
||||||
setIsLoaded(true);
|
setIsLoaded(true);
|
||||||
@@ -113,17 +109,40 @@ export function useBestiary(): BestiaryHook {
|
|||||||
|
|
||||||
const fetchAndCacheSource = useCallback(
|
const fetchAndCacheSource = useCallback(
|
||||||
async (sourceCode: string, url: string): Promise<void> => {
|
async (sourceCode: string, url: string): Promise<void> => {
|
||||||
const response = await fetch(url);
|
let creatures: AnyCreature[];
|
||||||
if (!response.ok) {
|
|
||||||
throw new Error(
|
if (edition === "pf2e") {
|
||||||
`Failed to fetch: ${response.status} ${response.statusText}`,
|
// PF2e: url is a base URL; fetch each creature file in parallel
|
||||||
|
const paths = pf2eBestiaryIndex.getCreaturePathsForSource(sourceCode);
|
||||||
|
const baseUrl = url.endsWith("/") ? url : `${url}/`;
|
||||||
|
const responses = await Promise.all(
|
||||||
|
paths.map(async (path) => {
|
||||||
|
const response = await fetch(`${baseUrl}${path}`);
|
||||||
|
if (!response.ok) {
|
||||||
|
throw new Error(
|
||||||
|
`Failed to fetch ${path}: ${response.status} ${response.statusText}`,
|
||||||
|
);
|
||||||
|
}
|
||||||
|
return response.json();
|
||||||
|
}),
|
||||||
);
|
);
|
||||||
|
const displayName = pf2eBestiaryIndex.getSourceDisplayName(sourceCode);
|
||||||
|
creatures = normalizeFoundryCreatures(
|
||||||
|
responses,
|
||||||
|
sourceCode,
|
||||||
|
displayName,
|
||||||
|
);
|
||||||
|
} else {
|
||||||
|
const response = await fetch(url);
|
||||||
|
if (!response.ok) {
|
||||||
|
throw new Error(
|
||||||
|
`Failed to fetch: ${response.status} ${response.statusText}`,
|
||||||
|
);
|
||||||
|
}
|
||||||
|
const json = await response.json();
|
||||||
|
creatures = normalizeBestiary(json);
|
||||||
}
|
}
|
||||||
const json = await response.json();
|
|
||||||
const creatures =
|
|
||||||
edition === "pf2e"
|
|
||||||
? normalizePf2eBestiary(json)
|
|
||||||
: normalizeBestiary(json);
|
|
||||||
const displayName =
|
const displayName =
|
||||||
edition === "pf2e"
|
edition === "pf2e"
|
||||||
? pf2eBestiaryIndex.getSourceDisplayName(sourceCode)
|
? pf2eBestiaryIndex.getSourceDisplayName(sourceCode)
|
||||||
@@ -149,7 +168,11 @@ export function useBestiary(): BestiaryHook {
|
|||||||
async (sourceCode: string, jsonData: unknown): Promise<void> => {
|
async (sourceCode: string, jsonData: unknown): Promise<void> => {
|
||||||
const creatures =
|
const creatures =
|
||||||
edition === "pf2e"
|
edition === "pf2e"
|
||||||
? normalizePf2eBestiary(jsonData as { creature: unknown[] })
|
? normalizeFoundryCreatures(
|
||||||
|
Array.isArray(jsonData) ? jsonData : [jsonData],
|
||||||
|
sourceCode,
|
||||||
|
pf2eBestiaryIndex.getSourceDisplayName(sourceCode),
|
||||||
|
)
|
||||||
: normalizeBestiary(
|
: normalizeBestiary(
|
||||||
jsonData as Parameters<typeof normalizeBestiary>[0],
|
jsonData as Parameters<typeof normalizeBestiary>[0],
|
||||||
);
|
);
|
||||||
|
|||||||
@@ -421,7 +421,10 @@ function dispatchEncounterAction(
|
|||||||
export function useEncounter() {
|
export function useEncounter() {
|
||||||
const { encounterPersistence, undoRedoPersistence } = useAdapters();
|
const { encounterPersistence, undoRedoPersistence } = useAdapters();
|
||||||
const [state, dispatch] = useReducer(encounterReducer, null, () =>
|
const [state, dispatch] = useReducer(encounterReducer, null, () =>
|
||||||
initializeState(encounterPersistence.load, undoRedoPersistence.load),
|
initializeState(
|
||||||
|
() => encounterPersistence.load(),
|
||||||
|
() => undoRedoPersistence.load(),
|
||||||
|
),
|
||||||
);
|
);
|
||||||
const { encounter, undoRedoState, events } = state;
|
const { encounter, undoRedoState, events } = state;
|
||||||
|
|
||||||
|
|||||||
@@ -70,3 +70,72 @@ export function useSwipeToDismiss(onDismiss: () => void) {
|
|||||||
handlers: { onTouchStart, onTouchMove, onTouchEnd },
|
handlers: { onTouchStart, onTouchMove, onTouchEnd },
|
||||||
};
|
};
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Vertical (down-only) variant for dismissing bottom sheets via swipe-down.
|
||||||
|
* Mirrors `useSwipeToDismiss` but locks to vertical direction and tracks
|
||||||
|
* the sheet height instead of width.
|
||||||
|
*/
|
||||||
|
export function useSwipeToDismissDown(onDismiss: () => void) {
|
||||||
|
const [swipe, setSwipe] = useState<SwipeState>({
|
||||||
|
offsetX: 0,
|
||||||
|
isSwiping: false,
|
||||||
|
});
|
||||||
|
const startX = useRef(0);
|
||||||
|
const startY = useRef(0);
|
||||||
|
const startTime = useRef(0);
|
||||||
|
const sheetHeight = useRef(0);
|
||||||
|
const directionLocked = useRef<"horizontal" | "vertical" | null>(null);
|
||||||
|
|
||||||
|
const onTouchStart = useCallback((e: React.TouchEvent) => {
|
||||||
|
const touch = e.touches[0];
|
||||||
|
startX.current = touch.clientX;
|
||||||
|
startY.current = touch.clientY;
|
||||||
|
startTime.current = Date.now();
|
||||||
|
directionLocked.current = null;
|
||||||
|
const el = e.currentTarget as HTMLElement;
|
||||||
|
sheetHeight.current = el.getBoundingClientRect().height;
|
||||||
|
}, []);
|
||||||
|
|
||||||
|
const onTouchMove = useCallback((e: React.TouchEvent) => {
|
||||||
|
const touch = e.touches[0];
|
||||||
|
const dx = touch.clientX - startX.current;
|
||||||
|
const dy = touch.clientY - startY.current;
|
||||||
|
|
||||||
|
if (!directionLocked.current) {
|
||||||
|
if (Math.abs(dx) < 10 && Math.abs(dy) < 10) return;
|
||||||
|
directionLocked.current =
|
||||||
|
Math.abs(dy) > Math.abs(dx) ? "vertical" : "horizontal";
|
||||||
|
}
|
||||||
|
|
||||||
|
if (directionLocked.current === "horizontal") return;
|
||||||
|
|
||||||
|
const clampedY = Math.max(0, dy);
|
||||||
|
// `offsetX` is reused as the vertical offset to keep SwipeState shared.
|
||||||
|
setSwipe({ offsetX: clampedY, isSwiping: true });
|
||||||
|
}, []);
|
||||||
|
|
||||||
|
const onTouchEnd = useCallback(() => {
|
||||||
|
if (directionLocked.current !== "vertical") {
|
||||||
|
setSwipe({ offsetX: 0, isSwiping: false });
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
const elapsed = (Date.now() - startTime.current) / 1000;
|
||||||
|
const velocity = swipe.offsetX / elapsed / sheetHeight.current;
|
||||||
|
const ratio =
|
||||||
|
sheetHeight.current > 0 ? swipe.offsetX / sheetHeight.current : 0;
|
||||||
|
|
||||||
|
if (ratio > DISMISS_THRESHOLD || velocity > VELOCITY_THRESHOLD) {
|
||||||
|
onDismiss();
|
||||||
|
}
|
||||||
|
|
||||||
|
setSwipe({ offsetX: 0, isSwiping: false });
|
||||||
|
}, [swipe.offsetX, onDismiss]);
|
||||||
|
|
||||||
|
return {
|
||||||
|
offsetY: swipe.offsetX,
|
||||||
|
isSwiping: swipe.isSwiping,
|
||||||
|
handlers: { onTouchStart, onTouchMove, onTouchEnd },
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|||||||
@@ -103,6 +103,19 @@
|
|||||||
animation: slide-in-right 200ms ease-out;
|
animation: slide-in-right 200ms ease-out;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@keyframes slide-in-bottom {
|
||||||
|
from {
|
||||||
|
transform: translateY(100%);
|
||||||
|
}
|
||||||
|
to {
|
||||||
|
transform: translateY(0);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
@utility animate-slide-in-bottom {
|
||||||
|
animation: slide-in-bottom 200ms ease-out;
|
||||||
|
}
|
||||||
|
|
||||||
@keyframes confirm-pulse {
|
@keyframes confirm-pulse {
|
||||||
0% {
|
0% {
|
||||||
scale: 1;
|
scale: 1;
|
||||||
|
|||||||
@@ -10,7 +10,8 @@
|
|||||||
"!coverage",
|
"!coverage",
|
||||||
"!.pnpm-store",
|
"!.pnpm-store",
|
||||||
"!.rodney",
|
"!.rodney",
|
||||||
"!.agent-tests"
|
"!.agent-tests",
|
||||||
|
"!data"
|
||||||
]
|
]
|
||||||
},
|
},
|
||||||
"assist": {
|
"assist": {
|
||||||
|
|||||||
File diff suppressed because one or more lines are too long
@@ -31,7 +31,7 @@
|
|||||||
"knip": "knip",
|
"knip": "knip",
|
||||||
"jscpd": "jscpd",
|
"jscpd": "jscpd",
|
||||||
"jsinspect": "jsinspect -c .jsinspectrc apps/web/src packages/domain/src packages/application/src",
|
"jsinspect": "jsinspect -c .jsinspectrc apps/web/src packages/domain/src packages/application/src",
|
||||||
"oxlint": "oxlint --tsconfig apps/web/tsconfig.json --type-aware --deny warnings",
|
"oxlint": "oxlint --tsconfig apps/web/tsconfig.json --type-aware --deny-warnings",
|
||||||
"check:ignores": "node scripts/check-lint-ignores.mjs",
|
"check:ignores": "node scripts/check-lint-ignores.mjs",
|
||||||
"check:classnames": "node scripts/check-cn-classnames.mjs",
|
"check:classnames": "node scripts/check-cn-classnames.mjs",
|
||||||
"check:props": "node scripts/check-component-props.mjs",
|
"check:props": "node scripts/check-component-props.mjs",
|
||||||
|
|||||||
@@ -47,8 +47,8 @@ describe("getConditionDescription", () => {
|
|||||||
(d.systems.includes("5e") && d.systems.includes("5.5e")),
|
(d.systems.includes("5e") && d.systems.includes("5.5e")),
|
||||||
);
|
);
|
||||||
for (const def of sharedDndConditions) {
|
for (const def of sharedDndConditions) {
|
||||||
expect(def.description, `${def.id} missing description`).toBeTruthy();
|
expect(def.description).toBeTruthy();
|
||||||
expect(def.description5e, `${def.id} missing description5e`).toBeTruthy();
|
expect(def.description5e).toBeTruthy();
|
||||||
}
|
}
|
||||||
});
|
});
|
||||||
|
|
||||||
|
|||||||
@@ -169,6 +169,60 @@ describe("setConditionValue", () => {
|
|||||||
);
|
);
|
||||||
expectDomainError(result, "unknown-condition");
|
expectDomainError(result, "unknown-condition");
|
||||||
});
|
});
|
||||||
|
|
||||||
|
it("clamps value to maxValue for capped conditions", () => {
|
||||||
|
const e = enc([makeCombatant("A")]);
|
||||||
|
const result = setConditionValue(e, combatantId("A"), "dying", 6);
|
||||||
|
if (isDomainError(result)) throw new Error(result.message);
|
||||||
|
|
||||||
|
expect(result.encounter.combatants[0].conditions).toEqual([
|
||||||
|
{ id: "dying", value: 4 },
|
||||||
|
]);
|
||||||
|
expect(result.events[0]).toMatchObject({
|
||||||
|
type: "ConditionAdded",
|
||||||
|
value: 4,
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
it("allows value at exactly the max", () => {
|
||||||
|
const e = enc([makeCombatant("A")]);
|
||||||
|
const result = setConditionValue(e, combatantId("A"), "doomed", 3);
|
||||||
|
if (isDomainError(result)) throw new Error(result.message);
|
||||||
|
|
||||||
|
expect(result.encounter.combatants[0].conditions).toEqual([
|
||||||
|
{ id: "doomed", value: 3 },
|
||||||
|
]);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("allows value below the max", () => {
|
||||||
|
const e = enc([makeCombatant("A")]);
|
||||||
|
const result = setConditionValue(e, combatantId("A"), "wounded", 2);
|
||||||
|
if (isDomainError(result)) throw new Error(result.message);
|
||||||
|
|
||||||
|
expect(result.encounter.combatants[0].conditions).toEqual([
|
||||||
|
{ id: "wounded", value: 2 },
|
||||||
|
]);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("does not cap conditions without a maxValue", () => {
|
||||||
|
const e = enc([makeCombatant("A")]);
|
||||||
|
const result = setConditionValue(e, combatantId("A"), "frightened", 10);
|
||||||
|
if (isDomainError(result)) throw new Error(result.message);
|
||||||
|
|
||||||
|
expect(result.encounter.combatants[0].conditions).toEqual([
|
||||||
|
{ id: "frightened", value: 10 },
|
||||||
|
]);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("clamps when updating an existing capped condition", () => {
|
||||||
|
const e = enc([makeCombatant("A", [{ id: "slowed-pf2e", value: 2 }])]);
|
||||||
|
const result = setConditionValue(e, combatantId("A"), "slowed-pf2e", 5);
|
||||||
|
if (isDomainError(result)) throw new Error(result.message);
|
||||||
|
|
||||||
|
expect(result.encounter.combatants[0].conditions).toEqual([
|
||||||
|
{ id: "slowed-pf2e", value: 3 },
|
||||||
|
]);
|
||||||
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
describe("decrementCondition", () => {
|
describe("decrementCondition", () => {
|
||||||
|
|||||||
@@ -1,3 +1,28 @@
|
|||||||
|
const DIGITS_ONLY = /^\d+$/;
|
||||||
|
|
||||||
|
function scanExisting(
|
||||||
|
baseName: string,
|
||||||
|
existingNames: readonly string[],
|
||||||
|
): { exactMatches: number[]; maxNumber: number } {
|
||||||
|
const exactMatches: number[] = [];
|
||||||
|
let maxNumber = 0;
|
||||||
|
const prefix = `${baseName} `;
|
||||||
|
|
||||||
|
for (let i = 0; i < existingNames.length; i++) {
|
||||||
|
const name = existingNames[i];
|
||||||
|
if (name === baseName) {
|
||||||
|
exactMatches.push(i);
|
||||||
|
} else if (name.startsWith(prefix)) {
|
||||||
|
const suffix = name.slice(prefix.length);
|
||||||
|
if (DIGITS_ONLY.test(suffix)) {
|
||||||
|
const num = Number.parseInt(suffix, 10);
|
||||||
|
if (num > maxNumber) maxNumber = num;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return { exactMatches, maxNumber };
|
||||||
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Resolves a creature name against existing combatant names,
|
* Resolves a creature name against existing combatant names,
|
||||||
* handling auto-numbering for duplicates.
|
* handling auto-numbering for duplicates.
|
||||||
@@ -14,25 +39,7 @@ export function resolveCreatureName(
|
|||||||
newName: string;
|
newName: string;
|
||||||
renames: ReadonlyArray<{ from: string; to: string }>;
|
renames: ReadonlyArray<{ from: string; to: string }>;
|
||||||
} {
|
} {
|
||||||
// Find exact matches and numbered matches (e.g., "Goblin 1", "Goblin 2")
|
const { exactMatches, maxNumber } = scanExisting(baseName, existingNames);
|
||||||
const exactMatches: number[] = [];
|
|
||||||
let maxNumber = 0;
|
|
||||||
|
|
||||||
for (let i = 0; i < existingNames.length; i++) {
|
|
||||||
const name = existingNames[i];
|
|
||||||
if (name === baseName) {
|
|
||||||
exactMatches.push(i);
|
|
||||||
} else {
|
|
||||||
const match = new RegExp(
|
|
||||||
String.raw`^${escapeRegExp(baseName)} (\d+)$`,
|
|
||||||
).exec(name);
|
|
||||||
// biome-ignore lint/nursery/noUnnecessaryConditions: RegExp.exec() returns null on no match — false positive
|
|
||||||
if (match) {
|
|
||||||
const num = Number.parseInt(match[1], 10);
|
|
||||||
if (num > maxNumber) maxNumber = num;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
// No conflict at all
|
// No conflict at all
|
||||||
if (exactMatches.length === 0 && maxNumber === 0) {
|
if (exactMatches.length === 0 && maxNumber === 0) {
|
||||||
@@ -51,7 +58,3 @@ export function resolveCreatureName(
|
|||||||
const nextNumber = Math.max(maxNumber, exactMatches.length) + 1;
|
const nextNumber = Math.max(maxNumber, exactMatches.length) + 1;
|
||||||
return { newName: `${baseName} ${nextNumber}`, renames: [] };
|
return { newName: `${baseName} ${nextNumber}`, renames: [] };
|
||||||
}
|
}
|
||||||
|
|
||||||
function escapeRegExp(s: string): string {
|
|
||||||
return s.replaceAll(/[.*+?^${}()|[\]\\]/g, String.raw`\$&`);
|
|
||||||
}
|
|
||||||
|
|||||||
@@ -57,6 +57,8 @@ export interface ConditionDefinition {
|
|||||||
/** When set, the condition only appears in these systems' pickers. */
|
/** When set, the condition only appears in these systems' pickers. */
|
||||||
readonly systems?: readonly RulesEdition[];
|
readonly systems?: readonly RulesEdition[];
|
||||||
readonly valued?: boolean;
|
readonly valued?: boolean;
|
||||||
|
/** Rule-defined maximum value for PF2e valued conditions. */
|
||||||
|
readonly maxValue?: number;
|
||||||
}
|
}
|
||||||
|
|
||||||
export function getConditionDescription(
|
export function getConditionDescription(
|
||||||
@@ -77,7 +79,7 @@ export const CONDITION_DEFINITIONS: readonly ConditionDefinition[] = [
|
|||||||
description5e:
|
description5e:
|
||||||
"Can't see. Auto-fail sight checks. Attacks have Disadvantage; attacks against have Advantage.",
|
"Can't see. Auto-fail sight checks. Attacks have Disadvantage; attacks against have Advantage.",
|
||||||
descriptionPf2e:
|
descriptionPf2e:
|
||||||
"Can't see. All terrain is difficult terrain. –4 status penalty to Perception checks involving sight. Immune to visual effects. Auto-fail checks requiring sight. Off-guard.",
|
"Can't see. All terrain is difficult terrain. Auto-fail checks requiring sight. Immune to visual effects. Overrides dazzled.",
|
||||||
iconName: "EyeOff",
|
iconName: "EyeOff",
|
||||||
color: "neutral",
|
color: "neutral",
|
||||||
},
|
},
|
||||||
@@ -98,7 +100,7 @@ export const CONDITION_DEFINITIONS: readonly ConditionDefinition[] = [
|
|||||||
description: "Can't hear. Auto-fail hearing checks.",
|
description: "Can't hear. Auto-fail hearing checks.",
|
||||||
description5e: "Can't hear. Auto-fail hearing checks.",
|
description5e: "Can't hear. Auto-fail hearing checks.",
|
||||||
descriptionPf2e:
|
descriptionPf2e:
|
||||||
"Can't hear. –2 status penalty to Perception checks and Initiative. Auto-fail hearing checks. Immune to auditory effects.",
|
"Can't hear. Auto-critically-fail hearing checks. –2 status penalty to Perception. Auditory actions require DC 5 flat check. Immune to auditory effects.",
|
||||||
iconName: "EarOff",
|
iconName: "EarOff",
|
||||||
color: "neutral",
|
color: "neutral",
|
||||||
},
|
},
|
||||||
@@ -166,7 +168,8 @@ export const CONDITION_DEFINITIONS: readonly ConditionDefinition[] = [
|
|||||||
"Incapacitated. Can't move or speak. Auto-fail Str/Dex saves. Attacks against have Advantage. Hits within 5 ft. are critical.",
|
"Incapacitated. Can't move or speak. Auto-fail Str/Dex saves. Attacks against have Advantage. Hits within 5 ft. are critical.",
|
||||||
description5e:
|
description5e:
|
||||||
"Incapacitated. Can't move or speak. Auto-fail Str/Dex saves. Attacks against have Advantage. Hits within 5 ft. are critical.",
|
"Incapacitated. Can't move or speak. Auto-fail Str/Dex saves. Attacks against have Advantage. Hits within 5 ft. are critical.",
|
||||||
descriptionPf2e: "Can't act. Off-guard. –4 status penalty to AC.",
|
descriptionPf2e:
|
||||||
|
"Can't act. Off-guard. Can only Recall Knowledge or use mental actions.",
|
||||||
iconName: "ZapOff",
|
iconName: "ZapOff",
|
||||||
color: "yellow",
|
color: "yellow",
|
||||||
},
|
},
|
||||||
@@ -243,7 +246,7 @@ export const CONDITION_DEFINITIONS: readonly ConditionDefinition[] = [
|
|||||||
description5e:
|
description5e:
|
||||||
"Incapacitated. Can't move. Can speak only falteringly. Auto-fail Str/Dex saves. Attacks against have Advantage.",
|
"Incapacitated. Can't move. Can speak only falteringly. Auto-fail Str/Dex saves. Attacks against have Advantage.",
|
||||||
descriptionPf2e:
|
descriptionPf2e:
|
||||||
"Can't act. –X value to actions per turn while the value counts down.",
|
"Can't act. Lose X total actions across turns, then the condition ends. Overrides slowed.",
|
||||||
iconName: "Sparkles",
|
iconName: "Sparkles",
|
||||||
color: "yellow",
|
color: "yellow",
|
||||||
valued: true,
|
valued: true,
|
||||||
@@ -256,7 +259,7 @@ export const CONDITION_DEFINITIONS: readonly ConditionDefinition[] = [
|
|||||||
description5e:
|
description5e:
|
||||||
"Incapacitated. Speed 0. Can't move or speak. Unaware of surroundings. Drops held items, falls Prone. Auto-fail Str/Dex saves. Attacks against have Advantage. Hits within 5 ft. are critical.",
|
"Incapacitated. Speed 0. Can't move or speak. Unaware of surroundings. Drops held items, falls Prone. Auto-fail Str/Dex saves. Attacks against have Advantage. Hits within 5 ft. are critical.",
|
||||||
descriptionPf2e:
|
descriptionPf2e:
|
||||||
"Can't act. Off-guard. –4 status penalty to AC. –3 to Perception. Fall prone, drop items.",
|
"Can't act. Off-guard. Blinded. –4 status penalty to AC, Perception, and Reflex saves. Fall prone, drop items.",
|
||||||
iconName: "Moon",
|
iconName: "Moon",
|
||||||
color: "indigo",
|
color: "indigo",
|
||||||
},
|
},
|
||||||
@@ -290,7 +293,7 @@ export const CONDITION_DEFINITIONS: readonly ConditionDefinition[] = [
|
|||||||
description: "",
|
description: "",
|
||||||
description5e: "",
|
description5e: "",
|
||||||
descriptionPf2e:
|
descriptionPf2e:
|
||||||
"Off-guard. Can't Delay, Ready, or use reactions. GM determines targets randomly. Flat check DC 11 to act normally each turn.",
|
"Off-guard. Can't Delay, Ready, or use reactions. Must Strike or cast offensive cantrips at random targets. DC 11 flat check when damaged to end.",
|
||||||
iconName: "CircleHelp",
|
iconName: "CircleHelp",
|
||||||
color: "pink",
|
color: "pink",
|
||||||
systems: ["pf2e"],
|
systems: ["pf2e"],
|
||||||
@@ -328,6 +331,7 @@ export const CONDITION_DEFINITIONS: readonly ConditionDefinition[] = [
|
|||||||
color: "red",
|
color: "red",
|
||||||
systems: ["pf2e"],
|
systems: ["pf2e"],
|
||||||
valued: true,
|
valued: true,
|
||||||
|
maxValue: 3,
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
id: "drained",
|
id: "drained",
|
||||||
@@ -335,7 +339,7 @@ export const CONDITION_DEFINITIONS: readonly ConditionDefinition[] = [
|
|||||||
description: "",
|
description: "",
|
||||||
description5e: "",
|
description5e: "",
|
||||||
descriptionPf2e:
|
descriptionPf2e:
|
||||||
"–X status penalty to Con-based checks and DCs. Lose X × Hit Die in max HP. Decreases by 1 on full night's rest.",
|
"–X status penalty to Con-based checks and DCs. Lose X × level in max HP. Decreases by 1 on full night's rest.",
|
||||||
iconName: "Droplets",
|
iconName: "Droplets",
|
||||||
color: "red",
|
color: "red",
|
||||||
systems: ["pf2e"],
|
systems: ["pf2e"],
|
||||||
@@ -352,6 +356,7 @@ export const CONDITION_DEFINITIONS: readonly ConditionDefinition[] = [
|
|||||||
color: "red",
|
color: "red",
|
||||||
systems: ["pf2e"],
|
systems: ["pf2e"],
|
||||||
valued: true,
|
valued: true,
|
||||||
|
maxValue: 4,
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
id: "enfeebled",
|
id: "enfeebled",
|
||||||
@@ -359,7 +364,7 @@ export const CONDITION_DEFINITIONS: readonly ConditionDefinition[] = [
|
|||||||
description: "",
|
description: "",
|
||||||
description5e: "",
|
description5e: "",
|
||||||
descriptionPf2e:
|
descriptionPf2e:
|
||||||
"–X status penalty to Str-based rolls, including melee attack and damage rolls.",
|
"–X status penalty to Str-based rolls and DCs, including melee attack and damage rolls and Athletics checks.",
|
||||||
iconName: "TrendingDown",
|
iconName: "TrendingDown",
|
||||||
color: "amber",
|
color: "amber",
|
||||||
systems: ["pf2e"],
|
systems: ["pf2e"],
|
||||||
@@ -371,7 +376,7 @@ export const CONDITION_DEFINITIONS: readonly ConditionDefinition[] = [
|
|||||||
description: "",
|
description: "",
|
||||||
description5e: "",
|
description5e: "",
|
||||||
descriptionPf2e:
|
descriptionPf2e:
|
||||||
"–2 status penalty to all checks. Can't use hostile actions. Ends if hostile action is used against you.",
|
"–2 status penalty to Perception and skill checks. Can't use concentrate actions unless related to the fascination. Ends if hostile action is used against you or allies.",
|
||||||
iconName: "Eye",
|
iconName: "Eye",
|
||||||
color: "violet",
|
color: "violet",
|
||||||
systems: ["pf2e"],
|
systems: ["pf2e"],
|
||||||
@@ -404,7 +409,7 @@ export const CONDITION_DEFINITIONS: readonly ConditionDefinition[] = [
|
|||||||
description: "",
|
description: "",
|
||||||
description5e: "",
|
description5e: "",
|
||||||
descriptionPf2e:
|
descriptionPf2e:
|
||||||
"Immobilized. Off-guard. Can't use actions with the move trait unless to Break Grapple.",
|
"Off-guard. Immobilized. Manipulate actions require DC 5 flat check or are wasted.",
|
||||||
iconName: "Hand",
|
iconName: "Hand",
|
||||||
color: "neutral",
|
color: "neutral",
|
||||||
systems: ["pf2e"],
|
systems: ["pf2e"],
|
||||||
@@ -415,7 +420,7 @@ export const CONDITION_DEFINITIONS: readonly ConditionDefinition[] = [
|
|||||||
description: "",
|
description: "",
|
||||||
description5e: "",
|
description5e: "",
|
||||||
descriptionPf2e:
|
descriptionPf2e:
|
||||||
"Known location but can't be seen. DC 11 flat check to target. Can use Seek to find.",
|
"Known location but can't be seen. Off-guard to that creature. DC 11 flat check to target or miss.",
|
||||||
iconName: "EyeOff",
|
iconName: "EyeOff",
|
||||||
color: "slate",
|
color: "slate",
|
||||||
systems: ["pf2e"],
|
systems: ["pf2e"],
|
||||||
@@ -474,6 +479,7 @@ export const CONDITION_DEFINITIONS: readonly ConditionDefinition[] = [
|
|||||||
color: "sky",
|
color: "sky",
|
||||||
systems: ["pf2e"],
|
systems: ["pf2e"],
|
||||||
valued: true,
|
valued: true,
|
||||||
|
maxValue: 3,
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
id: "stupefied",
|
id: "stupefied",
|
||||||
@@ -509,6 +515,7 @@ export const CONDITION_DEFINITIONS: readonly ConditionDefinition[] = [
|
|||||||
color: "red",
|
color: "red",
|
||||||
systems: ["pf2e"],
|
systems: ["pf2e"],
|
||||||
valued: true,
|
valued: true,
|
||||||
|
maxValue: 3,
|
||||||
},
|
},
|
||||||
] as const;
|
] as const;
|
||||||
|
|
||||||
@@ -521,5 +528,7 @@ export function getConditionsForEdition(
|
|||||||
): readonly ConditionDefinition[] {
|
): readonly ConditionDefinition[] {
|
||||||
return CONDITION_DEFINITIONS.filter(
|
return CONDITION_DEFINITIONS.filter(
|
||||||
(d) => d.systems === undefined || d.systems.includes(edition),
|
(d) => d.systems === undefined || d.systems.includes(edition),
|
||||||
);
|
)
|
||||||
|
.slice()
|
||||||
|
.sort((a, b) => a.label.localeCompare(b.label));
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -14,8 +14,15 @@ export interface TraitListItem {
|
|||||||
readonly text: string;
|
readonly text: string;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
export interface ActivityCost {
|
||||||
|
readonly number: number;
|
||||||
|
readonly unit: "action" | "free" | "reaction";
|
||||||
|
}
|
||||||
|
|
||||||
export interface TraitBlock {
|
export interface TraitBlock {
|
||||||
readonly name: string;
|
readonly name: string;
|
||||||
|
readonly activity?: ActivityCost;
|
||||||
|
readonly trigger?: string;
|
||||||
readonly segments: readonly TraitSegment[];
|
readonly segments: readonly TraitSegment[];
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -24,16 +31,71 @@ export interface LegendaryBlock {
|
|||||||
readonly entries: readonly TraitBlock[];
|
readonly entries: readonly TraitBlock[];
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* A single spell entry within a creature's spellcasting block.
|
||||||
|
*
|
||||||
|
* `name` is always populated. All other fields are optional and are only
|
||||||
|
* populated for PF2e creatures (sourced from embedded Foundry VTT spell items).
|
||||||
|
* D&D 5e creatures populate only `name`.
|
||||||
|
*/
|
||||||
|
export interface SpellReference {
|
||||||
|
readonly name: string;
|
||||||
|
|
||||||
|
/** Stable slug from Foundry VTT (e.g. "magic-missile"). PF2e only. */
|
||||||
|
readonly slug?: string;
|
||||||
|
|
||||||
|
/** Plain-text description with Foundry enrichment tags stripped. */
|
||||||
|
readonly description?: string;
|
||||||
|
|
||||||
|
/** Spell rank/level (0 = cantrip). */
|
||||||
|
readonly rank?: number;
|
||||||
|
|
||||||
|
/** Trait slugs (e.g. ["concentrate", "manipulate", "force"]). */
|
||||||
|
readonly traits?: readonly string[];
|
||||||
|
|
||||||
|
/** Tradition labels (e.g. ["arcane", "occult"]). */
|
||||||
|
readonly traditions?: readonly string[];
|
||||||
|
|
||||||
|
/** Range (e.g. "30 feet", "touch"). */
|
||||||
|
readonly range?: string;
|
||||||
|
|
||||||
|
/** Target (e.g. "1 creature"). */
|
||||||
|
readonly target?: string;
|
||||||
|
|
||||||
|
/** Area (e.g. "20-foot burst"). */
|
||||||
|
readonly area?: string;
|
||||||
|
|
||||||
|
/** Duration (e.g. "1 minute", "sustained up to 1 minute"). */
|
||||||
|
readonly duration?: string;
|
||||||
|
|
||||||
|
/** Defense / save (e.g. "basic Reflex", "Will"). */
|
||||||
|
readonly defense?: string;
|
||||||
|
|
||||||
|
/** Action cost. PF2e: number = action count, "reaction", "free", or
|
||||||
|
* "1 minute" / "10 minutes" for cast time. */
|
||||||
|
readonly actionCost?: string;
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Heightening rules text. May come from `system.heightening` (fixed
|
||||||
|
* intervals) or `system.overlays` (variant casts). Plain text after
|
||||||
|
* tag stripping.
|
||||||
|
*/
|
||||||
|
readonly heightening?: string;
|
||||||
|
|
||||||
|
/** Uses per day for "(×N)" rendering, when > 1. PF2e only. */
|
||||||
|
readonly usesPerDay?: number;
|
||||||
|
}
|
||||||
|
|
||||||
export interface DailySpells {
|
export interface DailySpells {
|
||||||
readonly uses: number;
|
readonly uses: number;
|
||||||
readonly each: boolean;
|
readonly each: boolean;
|
||||||
readonly spells: readonly string[];
|
readonly spells: readonly SpellReference[];
|
||||||
}
|
}
|
||||||
|
|
||||||
export interface SpellcastingBlock {
|
export interface SpellcastingBlock {
|
||||||
readonly name: string;
|
readonly name: string;
|
||||||
readonly headerText: string;
|
readonly headerText: string;
|
||||||
readonly atWill?: readonly string[];
|
readonly atWill?: readonly SpellReference[];
|
||||||
readonly daily?: readonly DailySpells[];
|
readonly daily?: readonly DailySpells[];
|
||||||
readonly restLong?: readonly DailySpells[];
|
readonly restLong?: readonly DailySpells[];
|
||||||
}
|
}
|
||||||
@@ -127,7 +189,9 @@ export interface Pf2eCreature {
|
|||||||
readonly saveFort: number;
|
readonly saveFort: number;
|
||||||
readonly saveRef: number;
|
readonly saveRef: number;
|
||||||
readonly saveWill: number;
|
readonly saveWill: number;
|
||||||
|
readonly saveConditional?: string;
|
||||||
readonly hp: number;
|
readonly hp: number;
|
||||||
|
readonly hpDetails?: string;
|
||||||
readonly immunities?: string;
|
readonly immunities?: string;
|
||||||
readonly resistances?: string;
|
readonly resistances?: string;
|
||||||
readonly weaknesses?: string;
|
readonly weaknesses?: string;
|
||||||
|
|||||||
@@ -24,6 +24,7 @@ export {
|
|||||||
createPlayerCharacter,
|
createPlayerCharacter,
|
||||||
} from "./create-player-character.js";
|
} from "./create-player-character.js";
|
||||||
export {
|
export {
|
||||||
|
type ActivityCost,
|
||||||
type AnyCreature,
|
type AnyCreature,
|
||||||
type BestiaryIndex,
|
type BestiaryIndex,
|
||||||
type BestiaryIndexEntry,
|
type BestiaryIndexEntry,
|
||||||
@@ -38,6 +39,7 @@ export {
|
|||||||
type Pf2eCreature,
|
type Pf2eCreature,
|
||||||
proficiencyBonus,
|
proficiencyBonus,
|
||||||
type SpellcastingBlock,
|
type SpellcastingBlock,
|
||||||
|
type SpellReference,
|
||||||
type TraitBlock,
|
type TraitBlock,
|
||||||
type TraitListItem,
|
type TraitListItem,
|
||||||
type TraitSegment,
|
type TraitSegment,
|
||||||
|
|||||||
@@ -92,7 +92,11 @@ export function setConditionValue(
|
|||||||
const { combatant: target } = found;
|
const { combatant: target } = found;
|
||||||
const current = target.conditions ?? [];
|
const current = target.conditions ?? [];
|
||||||
|
|
||||||
if (value <= 0) {
|
const def = CONDITION_DEFINITIONS.find((d) => d.id === conditionId);
|
||||||
|
const clampedValue =
|
||||||
|
def?.maxValue === undefined ? value : Math.min(value, def.maxValue);
|
||||||
|
|
||||||
|
if (clampedValue <= 0) {
|
||||||
const filtered = current.filter((c) => c.id !== conditionId);
|
const filtered = current.filter((c) => c.id !== conditionId);
|
||||||
const newConditions = filtered.length > 0 ? filtered : undefined;
|
const newConditions = filtered.length > 0 ? filtered : undefined;
|
||||||
return {
|
return {
|
||||||
@@ -106,7 +110,7 @@ export function setConditionValue(
|
|||||||
const existing = current.find((c) => c.id === conditionId);
|
const existing = current.find((c) => c.id === conditionId);
|
||||||
if (existing) {
|
if (existing) {
|
||||||
const updated = current.map((c) =>
|
const updated = current.map((c) =>
|
||||||
c.id === conditionId ? { ...c, value } : c,
|
c.id === conditionId ? { ...c, value: clampedValue } : c,
|
||||||
);
|
);
|
||||||
return {
|
return {
|
||||||
encounter: applyConditions(encounter, combatantId, updated),
|
encounter: applyConditions(encounter, combatantId, updated),
|
||||||
@@ -115,17 +119,25 @@ export function setConditionValue(
|
|||||||
type: "ConditionAdded",
|
type: "ConditionAdded",
|
||||||
combatantId,
|
combatantId,
|
||||||
condition: conditionId,
|
condition: conditionId,
|
||||||
value,
|
value: clampedValue,
|
||||||
},
|
},
|
||||||
],
|
],
|
||||||
};
|
};
|
||||||
}
|
}
|
||||||
|
|
||||||
const added = sortByDefinitionOrder([...current, { id: conditionId, value }]);
|
const added = sortByDefinitionOrder([
|
||||||
|
...current,
|
||||||
|
{ id: conditionId, value: clampedValue },
|
||||||
|
]);
|
||||||
return {
|
return {
|
||||||
encounter: applyConditions(encounter, combatantId, added),
|
encounter: applyConditions(encounter, combatantId, added),
|
||||||
events: [
|
events: [
|
||||||
{ type: "ConditionAdded", combatantId, condition: conditionId, value },
|
{
|
||||||
|
type: "ConditionAdded",
|
||||||
|
combatantId,
|
||||||
|
condition: conditionId,
|
||||||
|
value: clampedValue,
|
||||||
|
},
|
||||||
],
|
],
|
||||||
};
|
};
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -1,29 +1,14 @@
|
|||||||
/**
|
/**
|
||||||
* Backpressure check for biome-ignore comments.
|
* Zero-tolerance check for biome-ignore comments.
|
||||||
*
|
*
|
||||||
* 1. Ratcheting cap — source and test files have separate max counts.
|
* Any `biome-ignore` in tracked .ts/.tsx files fails the build.
|
||||||
* Lower these numbers as you fix ignores; they can never go up silently.
|
* Fix the underlying issue instead of suppressing the rule.
|
||||||
* 2. Banned rules — ignoring certain rule categories is never allowed.
|
|
||||||
* 3. Justification — every ignore must have a non-empty explanation after
|
|
||||||
* the rule name.
|
|
||||||
*/
|
*/
|
||||||
|
|
||||||
import { execSync } from "node:child_process";
|
import { execSync } from "node:child_process";
|
||||||
import { readFileSync } from "node:fs";
|
import { readFileSync } from "node:fs";
|
||||||
|
|
||||||
// ── Configuration ──────────────────────────────────────────────────────
|
const IGNORE_PATTERN = /biome-ignore\s+([\w/]+)/;
|
||||||
const MAX_SOURCE_IGNORES = 2;
|
|
||||||
const MAX_TEST_IGNORES = 3;
|
|
||||||
|
|
||||||
/** Rule prefixes that must never be suppressed. */
|
|
||||||
const BANNED_PREFIXES = [
|
|
||||||
"lint/security/",
|
|
||||||
"lint/correctness/noGlobalObjectCalls",
|
|
||||||
"lint/correctness/noUnsafeFinally",
|
|
||||||
];
|
|
||||||
// ───────────────────────────────────────────────────────────────────────
|
|
||||||
|
|
||||||
const IGNORE_PATTERN = /biome-ignore\s+([\w/]+)(?::\s*(.*))?/;
|
|
||||||
|
|
||||||
function findFiles() {
|
function findFiles() {
|
||||||
return execSync("git ls-files -- '*.ts' '*.tsx'", { encoding: "utf-8" })
|
return execSync("git ls-files -- '*.ts' '*.tsx'", { encoding: "utf-8" })
|
||||||
@@ -32,17 +17,7 @@ function findFiles() {
|
|||||||
.filter(Boolean);
|
.filter(Boolean);
|
||||||
}
|
}
|
||||||
|
|
||||||
function isTestFile(path) {
|
let count = 0;
|
||||||
return (
|
|
||||||
path.includes("__tests__/") ||
|
|
||||||
path.endsWith(".test.ts") ||
|
|
||||||
path.endsWith(".test.tsx")
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
let errors = 0;
|
|
||||||
let sourceCount = 0;
|
|
||||||
let testCount = 0;
|
|
||||||
|
|
||||||
for (const file of findFiles()) {
|
for (const file of findFiles()) {
|
||||||
const lines = readFileSync(file, "utf-8").split("\n");
|
const lines = readFileSync(file, "utf-8").split("\n");
|
||||||
@@ -51,58 +26,16 @@ for (const file of findFiles()) {
|
|||||||
const match = lines[i].match(IGNORE_PATTERN);
|
const match = lines[i].match(IGNORE_PATTERN);
|
||||||
if (!match) continue;
|
if (!match) continue;
|
||||||
|
|
||||||
const rule = match[1];
|
count++;
|
||||||
const justification = (match[2] ?? "").trim();
|
console.error(`FORBIDDEN: ${file}:${i + 1} — biome-ignore ${match[1]}`);
|
||||||
const loc = `${file}:${i + 1}`;
|
|
||||||
|
|
||||||
// Count by category
|
|
||||||
if (isTestFile(file)) {
|
|
||||||
testCount++;
|
|
||||||
} else {
|
|
||||||
sourceCount++;
|
|
||||||
}
|
|
||||||
|
|
||||||
// Banned rules
|
|
||||||
for (const prefix of BANNED_PREFIXES) {
|
|
||||||
if (rule.startsWith(prefix)) {
|
|
||||||
console.error(`BANNED: ${loc} — ${rule} must not be suppressed`);
|
|
||||||
errors++;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
// Justification required
|
|
||||||
if (!justification) {
|
|
||||||
console.error(
|
|
||||||
`MISSING JUSTIFICATION: ${loc} — biome-ignore ${rule} needs an explanation after the colon`,
|
|
||||||
);
|
|
||||||
errors++;
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// Ratcheting caps
|
if (count > 0) {
|
||||||
if (sourceCount > MAX_SOURCE_IGNORES) {
|
|
||||||
console.error(
|
console.error(
|
||||||
`SOURCE CAP EXCEEDED: ${sourceCount} biome-ignore comments in source (max ${MAX_SOURCE_IGNORES}). Fix issues and lower the cap.`,
|
`\n${count} biome-ignore comment(s) found. Fix the issue or restructure the code.`,
|
||||||
);
|
);
|
||||||
errors++;
|
|
||||||
}
|
|
||||||
|
|
||||||
if (testCount > MAX_TEST_IGNORES) {
|
|
||||||
console.error(
|
|
||||||
`TEST CAP EXCEEDED: ${testCount} biome-ignore comments in tests (max ${MAX_TEST_IGNORES}). Fix issues and lower the cap.`,
|
|
||||||
);
|
|
||||||
errors++;
|
|
||||||
}
|
|
||||||
|
|
||||||
// Summary
|
|
||||||
console.log(
|
|
||||||
`biome-ignore: ${sourceCount} source (max ${MAX_SOURCE_IGNORES}), ${testCount} test (max ${MAX_TEST_IGNORES})`,
|
|
||||||
);
|
|
||||||
|
|
||||||
if (errors > 0) {
|
|
||||||
console.error(`\n${errors} problem(s) found.`);
|
|
||||||
process.exit(1);
|
process.exit(1);
|
||||||
} else {
|
} else {
|
||||||
console.log("All checks passed.");
|
console.log("biome-ignore: 0 — all clear.");
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -1,123 +1,103 @@
|
|||||||
import { readdirSync, readFileSync, writeFileSync } from "node:fs";
|
import { readdirSync, readFileSync, writeFileSync } from "node:fs";
|
||||||
import { join } from "node:path";
|
import { join, relative } from "node:path";
|
||||||
|
|
||||||
// Usage: node scripts/generate-pf2e-bestiary-index.mjs <path-to-Pf2eTools>
|
// Usage: node scripts/generate-pf2e-bestiary-index.mjs <path-to-foundry-pf2e>
|
||||||
//
|
//
|
||||||
// Requires a local clone/checkout of https://github.com/Pf2eToolsOrg/Pf2eTools (dev branch)
|
// Requires a local clone of https://github.com/foundryvtt/pf2e (v13-dev branch).
|
||||||
// with at least data/bestiary/.
|
|
||||||
//
|
//
|
||||||
// Example:
|
// Example:
|
||||||
// git clone --depth 1 --branch dev --sparse https://github.com/Pf2eToolsOrg/Pf2eTools.git /tmp/pf2etools
|
// git clone --depth 1 --branch v13-dev https://github.com/foundryvtt/pf2e.git /tmp/foundry-pf2e
|
||||||
// cd /tmp/pf2etools && git sparse-checkout set data/bestiary data
|
// node scripts/generate-pf2e-bestiary-index.mjs /tmp/foundry-pf2e
|
||||||
// node scripts/generate-pf2e-bestiary-index.mjs /tmp/pf2etools
|
|
||||||
|
|
||||||
const TOOLS_ROOT = process.argv[2];
|
const FOUNDRY_ROOT = process.argv[2];
|
||||||
if (!TOOLS_ROOT) {
|
if (!FOUNDRY_ROOT) {
|
||||||
console.error(
|
console.error(
|
||||||
"Usage: node scripts/generate-pf2e-bestiary-index.mjs <Pf2eTools-path>",
|
"Usage: node scripts/generate-pf2e-bestiary-index.mjs <foundry-pf2e-path>",
|
||||||
);
|
);
|
||||||
process.exit(1);
|
process.exit(1);
|
||||||
}
|
}
|
||||||
|
|
||||||
const PROJECT_ROOT = join(import.meta.dirname, "..");
|
const PROJECT_ROOT = join(import.meta.dirname, "..");
|
||||||
const BESTIARY_DIR = join(TOOLS_ROOT, "data/bestiary");
|
const PACKS_DIR = join(FOUNDRY_ROOT, "packs/pf2e");
|
||||||
const OUTPUT_PATH = join(PROJECT_ROOT, "data/bestiary/pf2e-index.json");
|
const OUTPUT_PATH = join(PROJECT_ROOT, "data/bestiary/pf2e-index.json");
|
||||||
|
|
||||||
// --- Source display names ---
|
// Legacy bestiaries superseded by Monster Core / Monster Core 2
|
||||||
// Pf2eTools doesn't have a single books.json with all adventure paths.
|
const EXCLUDED_PACKS = new Set([
|
||||||
// We map known source codes to display names here.
|
"pathfinder-bestiary",
|
||||||
const SOURCE_NAMES = {
|
"pathfinder-bestiary-2",
|
||||||
B1: "Bestiary",
|
"pathfinder-bestiary-3",
|
||||||
B2: "Bestiary 2",
|
|
||||||
B3: "Bestiary 3",
|
|
||||||
CRB: "Core Rulebook",
|
|
||||||
GMG: "Gamemastery Guide",
|
|
||||||
LOME: "Lost Omens: The Mwangi Expanse",
|
|
||||||
LOMM: "Lost Omens: Monsters of Myth",
|
|
||||||
LOIL: "Lost Omens: Impossible Lands",
|
|
||||||
LOCG: "Lost Omens: Character Guide",
|
|
||||||
LOSK: "Lost Omens: Knights of Lastwall",
|
|
||||||
LOTXWG: "Lost Omens: Travel Guide",
|
|
||||||
LOACLO: "Lost Omens: Absalom, City of Lost Omens",
|
|
||||||
LOHh: "Lost Omens: Highhelm",
|
|
||||||
AoA1: "Age of Ashes #1: Hellknight Hill",
|
|
||||||
AoA2: "Age of Ashes #2: Cult of Cinders",
|
|
||||||
AoA3: "Age of Ashes #3: Tomorrow Must Burn",
|
|
||||||
AoA4: "Age of Ashes #4: Fires of the Haunted City",
|
|
||||||
AoA5: "Age of Ashes #5: Against the Scarlet Triad",
|
|
||||||
AoA6: "Age of Ashes #6: Broken Promises",
|
|
||||||
AoE1: "Agents of Edgewatch #1",
|
|
||||||
AoE2: "Agents of Edgewatch #2",
|
|
||||||
AoE3: "Agents of Edgewatch #3",
|
|
||||||
AoE4: "Agents of Edgewatch #4",
|
|
||||||
AoE5: "Agents of Edgewatch #5",
|
|
||||||
AoE6: "Agents of Edgewatch #6",
|
|
||||||
EC1: "Extinction Curse #1",
|
|
||||||
EC2: "Extinction Curse #2",
|
|
||||||
EC3: "Extinction Curse #3",
|
|
||||||
EC4: "Extinction Curse #4",
|
|
||||||
EC5: "Extinction Curse #5",
|
|
||||||
EC6: "Extinction Curse #6",
|
|
||||||
AV1: "Abomination Vaults #1",
|
|
||||||
AV2: "Abomination Vaults #2",
|
|
||||||
AV3: "Abomination Vaults #3",
|
|
||||||
FRP1: "Fists of the Ruby Phoenix #1",
|
|
||||||
FRP2: "Fists of the Ruby Phoenix #2",
|
|
||||||
FRP3: "Fists of the Ruby Phoenix #3",
|
|
||||||
SoT1: "Strength of Thousands #1",
|
|
||||||
SoT2: "Strength of Thousands #2",
|
|
||||||
SoT3: "Strength of Thousands #3",
|
|
||||||
SoT4: "Strength of Thousands #4",
|
|
||||||
SoT5: "Strength of Thousands #5",
|
|
||||||
SoT6: "Strength of Thousands #6",
|
|
||||||
OoA1: "Outlaws of Alkenstar #1",
|
|
||||||
OoA2: "Outlaws of Alkenstar #2",
|
|
||||||
OoA3: "Outlaws of Alkenstar #3",
|
|
||||||
BotD: "Book of the Dead",
|
|
||||||
DA: "Dark Archive",
|
|
||||||
FoP: "The Fall of Plaguestone",
|
|
||||||
LTiBA: "Little Trouble in Big Absalom",
|
|
||||||
Sli: "The Slithering",
|
|
||||||
TiO: "Troubles in Otari",
|
|
||||||
NGD: "Night of the Gray Death",
|
|
||||||
BB: "Beginner Box",
|
|
||||||
SoG1: "Sky King's Tomb #1",
|
|
||||||
SoG2: "Sky King's Tomb #2",
|
|
||||||
SoG3: "Sky King's Tomb #3",
|
|
||||||
GW1: "Gatewalkers #1",
|
|
||||||
GW2: "Gatewalkers #2",
|
|
||||||
GW3: "Gatewalkers #3",
|
|
||||||
WoW1: "Wardens of Wildwood #1",
|
|
||||||
WoW2: "Wardens of Wildwood #2",
|
|
||||||
WoW3: "Wardens of Wildwood #3",
|
|
||||||
SF1: "Season of Ghosts #1",
|
|
||||||
SF2: "Season of Ghosts #2",
|
|
||||||
SF3: "Season of Ghosts #3",
|
|
||||||
POS1: "Pathfinder One-Shots",
|
|
||||||
AFoF: "A Fistful of Flowers",
|
|
||||||
TaL: "Threshold of Knowledge",
|
|
||||||
ToK: "Threshold of Knowledge",
|
|
||||||
DaLl: "Dinner at Lionlodge",
|
|
||||||
MotM: "Monsters of the Multiverse",
|
|
||||||
Mal: "Malevolence",
|
|
||||||
TEC: "The Enmity Cycle",
|
|
||||||
SaS: "Shadows at Sundown",
|
|
||||||
Rust: "Rusthenge",
|
|
||||||
CotT: "Crown of the Kobold King",
|
|
||||||
SoM: "Secrets of Magic",
|
|
||||||
};
|
|
||||||
|
|
||||||
// --- Size extraction from traits ---
|
|
||||||
const SIZES = new Set([
|
|
||||||
"tiny",
|
|
||||||
"small",
|
|
||||||
"medium",
|
|
||||||
"large",
|
|
||||||
"huge",
|
|
||||||
"gargantuan",
|
|
||||||
]);
|
]);
|
||||||
|
|
||||||
// Creature type traits (PF2e types are lowercase in the traits array)
|
// PFS (Pathfinder Society) scenario packs — organized play content not on
|
||||||
|
// Archives of Nethys, mostly reskinned variants for specific scenarios.
|
||||||
|
const isPfsPack = (name) => name.startsWith("pfs-");
|
||||||
|
|
||||||
|
// Pack directory → display name mapping. Foundry pack directories are stable
|
||||||
|
// identifiers; new ones are added ~2-3 times per year with new AP volumes.
|
||||||
|
// Run the script with an unknown pack to see unmapped entries in the output.
|
||||||
|
const SOURCE_NAMES = {
|
||||||
|
"abomination-vaults-bestiary": "Abomination Vaults",
|
||||||
|
"age-of-ashes-bestiary": "Age of Ashes",
|
||||||
|
"agents-of-edgewatch-bestiary": "Agents of Edgewatch",
|
||||||
|
"battlecry-bestiary": "Battlecry!",
|
||||||
|
"blog-bestiary": "Pathfinder Blog",
|
||||||
|
"blood-lords-bestiary": "Blood Lords",
|
||||||
|
"book-of-the-dead-bestiary": "Book of the Dead",
|
||||||
|
"claws-of-the-tyrant-bestiary": "Claws of the Tyrant",
|
||||||
|
"crown-of-the-kobold-king-bestiary": "Crown of the Kobold King",
|
||||||
|
"curtain-call-bestiary": "Curtain Call",
|
||||||
|
"extinction-curse-bestiary": "Extinction Curse",
|
||||||
|
"fall-of-plaguestone": "The Fall of Plaguestone",
|
||||||
|
"fists-of-the-ruby-phoenix-bestiary": "Fists of the Ruby Phoenix",
|
||||||
|
"gatewalkers-bestiary": "Gatewalkers",
|
||||||
|
"hellbreakers-bestiary": "Hellbreakers",
|
||||||
|
"howl-of-the-wild-bestiary": "Howl of the Wild",
|
||||||
|
"kingmaker-bestiary": "Kingmaker",
|
||||||
|
"lost-omens-bestiary": "Lost Omens",
|
||||||
|
"malevolence-bestiary": "Malevolence",
|
||||||
|
"menace-under-otari-bestiary": "Beginner Box",
|
||||||
|
"myth-speaker-bestiary": "Myth Speaker",
|
||||||
|
"night-of-the-gray-death-bestiary": "Night of the Gray Death",
|
||||||
|
"npc-gallery": "NPC Gallery",
|
||||||
|
"one-shot-bestiary": "One-Shots",
|
||||||
|
"outlaws-of-alkenstar-bestiary": "Outlaws of Alkenstar",
|
||||||
|
"pathfinder-dark-archive": "Dark Archive",
|
||||||
|
"pathfinder-monster-core": "Monster Core",
|
||||||
|
"pathfinder-monster-core-2": "Monster Core 2",
|
||||||
|
"pathfinder-npc-core": "NPC Core",
|
||||||
|
"prey-for-death-bestiary": "Prey for Death",
|
||||||
|
"quest-for-the-frozen-flame-bestiary": "Quest for the Frozen Flame",
|
||||||
|
"rage-of-elements-bestiary": "Rage of Elements",
|
||||||
|
"revenge-of-the-runelords-bestiary": "Revenge of the Runelords",
|
||||||
|
"rusthenge-bestiary": "Rusthenge",
|
||||||
|
"season-of-ghosts-bestiary": "Season of Ghosts",
|
||||||
|
"seven-dooms-for-sandpoint-bestiary": "Seven Dooms for Sandpoint",
|
||||||
|
"shades-of-blood-bestiary": "Shades of Blood",
|
||||||
|
"shadows-at-sundown-bestiary": "Shadows at Sundown",
|
||||||
|
"sky-kings-tomb-bestiary": "Sky King's Tomb",
|
||||||
|
"spore-war-bestiary": "Spore War",
|
||||||
|
"standalone-adventures": "Standalone Adventures",
|
||||||
|
"stolen-fate-bestiary": "Stolen Fate",
|
||||||
|
"strength-of-thousands-bestiary": "Strength of Thousands",
|
||||||
|
"the-enmity-cycle-bestiary": "The Enmity Cycle",
|
||||||
|
"the-slithering-bestiary": "The Slithering",
|
||||||
|
"triumph-of-the-tusk-bestiary": "Triumph of the Tusk",
|
||||||
|
"troubles-in-otari-bestiary": "Troubles in Otari",
|
||||||
|
"war-of-immortals-bestiary": "War of Immortals",
|
||||||
|
"wardens-of-wildwood-bestiary": "Wardens of Wildwood",
|
||||||
|
};
|
||||||
|
|
||||||
|
// Size code mapping from Foundry abbreviations to full names
|
||||||
|
const SIZE_MAP = {
|
||||||
|
tiny: "tiny",
|
||||||
|
sm: "small",
|
||||||
|
med: "medium",
|
||||||
|
lg: "large",
|
||||||
|
huge: "huge",
|
||||||
|
grg: "gargantuan",
|
||||||
|
};
|
||||||
|
|
||||||
|
// Creature type traits
|
||||||
const CREATURE_TYPES = new Set([
|
const CREATURE_TYPES = new Set([
|
||||||
"aberration",
|
"aberration",
|
||||||
"animal",
|
"animal",
|
||||||
@@ -143,64 +123,99 @@ const CREATURE_TYPES = new Set([
|
|||||||
"undead",
|
"undead",
|
||||||
]);
|
]);
|
||||||
|
|
||||||
function extractSize(traits) {
|
// --- Helpers ---
|
||||||
if (!Array.isArray(traits)) return "medium";
|
|
||||||
const found = traits.find((t) => SIZES.has(t.toLowerCase()));
|
|
||||||
return found ? found.toLowerCase() : "medium";
|
|
||||||
}
|
|
||||||
|
|
||||||
function extractType(traits) {
|
/** Recursively collect all .json files (excluding _*.json metadata files). */
|
||||||
if (!Array.isArray(traits)) return "";
|
function collectJsonFiles(dir) {
|
||||||
const found = traits.find((t) => CREATURE_TYPES.has(t.toLowerCase()));
|
const results = [];
|
||||||
return found ? found.toLowerCase() : "";
|
for (const entry of readdirSync(dir, { withFileTypes: true })) {
|
||||||
|
if (entry.name.startsWith("_")) continue;
|
||||||
|
const full = join(dir, entry.name);
|
||||||
|
if (entry.isDirectory()) {
|
||||||
|
results.push(...collectJsonFiles(full));
|
||||||
|
} else if (entry.name.endsWith(".json")) {
|
||||||
|
results.push(full);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return results;
|
||||||
}
|
}
|
||||||
|
|
||||||
// --- Main ---
|
// --- Main ---
|
||||||
|
|
||||||
const files = readdirSync(BESTIARY_DIR).filter(
|
const packDirs = readdirSync(PACKS_DIR, { withFileTypes: true })
|
||||||
(f) => f.startsWith("creatures-") && f.endsWith(".json"),
|
.filter(
|
||||||
);
|
(d) => d.isDirectory() && !EXCLUDED_PACKS.has(d.name) && !isPfsPack(d.name),
|
||||||
|
)
|
||||||
|
.map((d) => d.name)
|
||||||
|
.sort();
|
||||||
|
|
||||||
const creatures = [];
|
const creatures = [];
|
||||||
const seenSources = new Set();
|
const sources = {};
|
||||||
|
const missingData = [];
|
||||||
|
|
||||||
for (const file of files.sort()) {
|
for (const packDir of packDirs) {
|
||||||
const raw = JSON.parse(readFileSync(join(BESTIARY_DIR, file), "utf-8"));
|
const packPath = join(PACKS_DIR, packDir);
|
||||||
const entries = raw.creature ?? [];
|
let files;
|
||||||
|
try {
|
||||||
|
files = collectJsonFiles(packPath).sort();
|
||||||
|
} catch {
|
||||||
|
continue;
|
||||||
|
}
|
||||||
|
|
||||||
for (const c of entries) {
|
for (const filePath of files) {
|
||||||
// Skip copies/references
|
let raw;
|
||||||
if (c._copy) continue;
|
try {
|
||||||
|
raw = JSON.parse(readFileSync(filePath, "utf-8"));
|
||||||
|
} catch {
|
||||||
|
continue;
|
||||||
|
}
|
||||||
|
|
||||||
const source = c.source ?? "";
|
// Only include NPC-type creatures
|
||||||
seenSources.add(source);
|
if (raw.type !== "npc") continue;
|
||||||
|
|
||||||
const ac = c.defenses?.ac?.std ?? 0;
|
const system = raw.system;
|
||||||
const hp = c.defenses?.hp?.[0]?.hp ?? 0;
|
if (!system) continue;
|
||||||
const perception = c.perception?.std ?? 0;
|
|
||||||
|
const name = raw.name;
|
||||||
|
const level = system.details?.level?.value ?? 0;
|
||||||
|
const ac = system.attributes?.ac?.value ?? 0;
|
||||||
|
const hp = system.attributes?.hp?.max ?? 0;
|
||||||
|
const perception = system.perception?.mod ?? 0;
|
||||||
|
const sizeCode = system.traits?.size?.value ?? "med";
|
||||||
|
const size = SIZE_MAP[sizeCode] ?? "medium";
|
||||||
|
const traits = system.traits?.value ?? [];
|
||||||
|
const type =
|
||||||
|
traits.find((t) => CREATURE_TYPES.has(t.toLowerCase()))?.toLowerCase() ??
|
||||||
|
"";
|
||||||
|
const relativePath = relative(PACKS_DIR, filePath);
|
||||||
|
const license = system.details?.publication?.license ?? "";
|
||||||
|
|
||||||
|
if (!name || ac === 0 || hp === 0) {
|
||||||
|
missingData.push(`${relativePath}: name=${name} ac=${ac} hp=${hp}`);
|
||||||
|
}
|
||||||
|
|
||||||
creatures.push({
|
creatures.push({
|
||||||
n: c.name,
|
n: name,
|
||||||
s: source,
|
s: packDir,
|
||||||
lv: c.level ?? 0,
|
lv: level,
|
||||||
ac,
|
ac,
|
||||||
hp,
|
hp,
|
||||||
pc: perception,
|
pc: perception,
|
||||||
sz: extractSize(c.traits),
|
sz: size,
|
||||||
tp: extractType(c.traits),
|
tp: type,
|
||||||
|
f: relativePath,
|
||||||
|
li: license,
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
|
if (creatures.some((c) => c.s === packDir)) {
|
||||||
|
sources[packDir] = SOURCE_NAMES[packDir] ?? packDir;
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// Sort by name then source for stable output
|
// Sort by name then source for stable output
|
||||||
creatures.sort((a, b) => a.n.localeCompare(b.n) || a.s.localeCompare(b.s));
|
creatures.sort((a, b) => a.n.localeCompare(b.n) || a.s.localeCompare(b.s));
|
||||||
|
|
||||||
// Build source map from seen sources
|
|
||||||
const sources = {};
|
|
||||||
for (const code of [...seenSources].sort()) {
|
|
||||||
sources[code] = SOURCE_NAMES[code] ?? code;
|
|
||||||
}
|
|
||||||
|
|
||||||
const output = { sources, creatures };
|
const output = { sources, creatures };
|
||||||
writeFileSync(OUTPUT_PATH, JSON.stringify(output));
|
writeFileSync(OUTPUT_PATH, JSON.stringify(output));
|
||||||
|
|
||||||
@@ -209,7 +224,19 @@ console.log(`Sources: ${Object.keys(sources).length}`);
|
|||||||
console.log(`Creatures: ${creatures.length}`);
|
console.log(`Creatures: ${creatures.length}`);
|
||||||
console.log(`Output size: ${(rawSize / 1024).toFixed(1)} KB`);
|
console.log(`Output size: ${(rawSize / 1024).toFixed(1)} KB`);
|
||||||
|
|
||||||
const unmapped = [...seenSources].filter((s) => !SOURCE_NAMES[s]);
|
const unmapped = Object.keys(sources).filter((s) => !SOURCE_NAMES[s]);
|
||||||
if (unmapped.length > 0) {
|
if (unmapped.length > 0) {
|
||||||
console.log(`Unmapped sources: ${unmapped.sort().join(", ")}`);
|
console.log(
|
||||||
|
`\nUnmapped packs (using directory name as-is): ${unmapped.join(", ")}`,
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
if (missingData.length > 0) {
|
||||||
|
console.log(`\nCreatures with missing data (${missingData.length}):`);
|
||||||
|
for (const msg of missingData.slice(0, 20)) {
|
||||||
|
console.log(` ${msg}`);
|
||||||
|
}
|
||||||
|
if (missingData.length > 20) {
|
||||||
|
console.log(` ... and ${missingData.length - 20} more`);
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -260,6 +260,8 @@ Acceptance scenarios:
|
|||||||
4. **Given** concentration is active and the row is not hovered, **Then** the Brain icon remains visible.
|
4. **Given** concentration is active and the row is not hovered, **Then** the Brain icon remains visible.
|
||||||
5. **Given** concentration is active, **When** the user clicks the Brain icon again, **Then** concentration deactivates and the icon hides (unless the row is still hovered).
|
5. **Given** concentration is active, **When** the user clicks the Brain icon again, **Then** concentration deactivates and the icon hides (unless the row is still hovered).
|
||||||
6. **Given** the Brain icon is visible, **When** the user hovers over it, **Then** a tooltip reading "Concentrating" appears.
|
6. **Given** the Brain icon is visible, **When** the user hovers over it, **Then** a tooltip reading "Concentrating" appears.
|
||||||
|
7. **Given** the game system is Pathfinder 2e, **When** viewing any combatant row (hovered or not), **Then** the Brain icon is not shown — even if `isConcentrating` is true.
|
||||||
|
8. **Given** a combatant has `isConcentrating` true and the game system is PF2e, **When** the user switches to a D&D system, **Then** the Brain icon appears with active styling (concentration state was preserved).
|
||||||
|
|
||||||
**Story CC-6 — Visual Feedback for Concentration (P2)**
|
**Story CC-6 — Visual Feedback for Concentration (P2)**
|
||||||
As a DM, I want concentrating combatants to have a visible row accent so I can identify them at a glance without interacting.
|
As a DM, I want concentrating combatants to have a visible row accent so I can identify them at a glance without interacting.
|
||||||
@@ -268,6 +270,7 @@ Acceptance scenarios:
|
|||||||
1. **Given** concentration is active, **When** viewing the encounter tracker, **Then** the combatant row shows a colored left border accent (`border-l-purple-400`).
|
1. **Given** concentration is active, **When** viewing the encounter tracker, **Then** the combatant row shows a colored left border accent (`border-l-purple-400`).
|
||||||
2. **Given** concentration is inactive, **Then** no concentration accent is shown.
|
2. **Given** concentration is inactive, **Then** no concentration accent is shown.
|
||||||
3. **Given** concentration is toggled off, **Then** the left border accent disappears immediately.
|
3. **Given** concentration is toggled off, **Then** the left border accent disappears immediately.
|
||||||
|
4. **Given** the game system is Pathfinder 2e and a combatant has `isConcentrating` true, **When** viewing the encounter tracker, **Then** no purple left border accent is shown on that row.
|
||||||
|
|
||||||
**Story CC-7 — Damage Pulse Alert (P3)**
|
**Story CC-7 — Damage Pulse Alert (P3)**
|
||||||
As a DM, I want a visual alert when a concentrating combatant takes damage so I remember to call for a concentration check.
|
As a DM, I want a visual alert when a concentrating combatant takes damage so I remember to call for a concentration check.
|
||||||
@@ -277,6 +280,7 @@ Acceptance scenarios:
|
|||||||
2. **Given** a combatant is concentrating, **When** the combatant is healed, **Then** no pulse/flash occurs.
|
2. **Given** a combatant is concentrating, **When** the combatant is healed, **Then** no pulse/flash occurs.
|
||||||
3. **Given** a combatant is NOT concentrating, **When** damage is taken, **Then** no pulse/flash occurs.
|
3. **Given** a combatant is NOT concentrating, **When** damage is taken, **Then** no pulse/flash occurs.
|
||||||
4. **Given** a concentrating combatant takes damage, **When** the animation completes, **Then** the row returns to its normal concentration-active appearance.
|
4. **Given** a concentrating combatant takes damage, **When** the animation completes, **Then** the row returns to its normal concentration-active appearance.
|
||||||
|
5. **Given** the game system is Pathfinder 2e and a combatant has `isConcentrating` true, **When** the combatant takes damage, **Then** no pulse/flash animation occurs.
|
||||||
|
|
||||||
**Story CC-8 — Game System Setting (P2)**
|
**Story CC-8 — Game System Setting (P2)**
|
||||||
As a DM who runs games across D&D 5e, 5.5e, and Pathfinder 2e, I want to choose which game system the tracker uses so that conditions, bestiary search, stat block layout, and initiative calculation all match the game I am running.
|
As a DM who runs games across D&D 5e, 5.5e, and Pathfinder 2e, I want to choose which game system the tracker uses so that conditions, bestiary search, stat block layout, and initiative calculation all match the game I am running.
|
||||||
@@ -310,6 +314,16 @@ Acceptance scenarios:
|
|||||||
9. **Given** a combatant has Clumsy 3, **When** the user hovers over the condition icon, **Then** the tooltip shows the condition name, the current value, and the PF2e rules description.
|
9. **Given** a combatant has Clumsy 3, **When** the user hovers over the condition icon, **Then** the tooltip shows the condition name, the current value, and the PF2e rules description.
|
||||||
10. **Given** a valued condition counter is showing, **When** the user clicks a different valued condition, **Then** the previous counter is replaced (only one counter at a time).
|
10. **Given** a valued condition counter is showing, **When** the user clicks a different valued condition, **Then** the previous counter is replaced (only one counter at a time).
|
||||||
|
|
||||||
|
**Story CC-10 — Condition Value Maximums (P2)**
|
||||||
|
As a DM running a PF2e encounter, I want valued conditions to be capped at their rule-defined maximum so I cannot accidentally increment them beyond their meaningful range.
|
||||||
|
|
||||||
|
Acceptance scenarios:
|
||||||
|
1. **Given** the game system is Pathfinder 2e, **When** a valued condition reaches its maximum (dying 4, doomed 3, wounded 3, slowed 3), **Then** the `[+]` button in the condition picker counter is disabled.
|
||||||
|
2. **Given** a combatant has Dying 4, **When** the user opens the condition picker, **Then** the counter shows 4 and `[+]` is disabled; `[-]` and `[✓]` remain active.
|
||||||
|
3. **Given** a combatant has Slowed 3, **When** the user clicks the Slowed icon tag on the row, **Then** the value decrements to 2 (decrement is unaffected by the cap).
|
||||||
|
4. **Given** the game system is D&D (5e or 5.5e), **When** interacting with conditions, **Then** no maximum enforcement is applied.
|
||||||
|
5. **Given** a PF2e valued condition without a defined maximum (e.g., Frightened, Clumsy), **When** incrementing, **Then** no cap is enforced — the value can increase without limit.
|
||||||
|
|
||||||
### Requirements
|
### Requirements
|
||||||
|
|
||||||
- **FR-032**: When a D&D game system is active, the system MUST support the following 15 standard D&D 5e/5.5e conditions: blinded, charmed, deafened, exhaustion, frightened, grappled, incapacitated, invisible, paralyzed, petrified, poisoned, prone, restrained, stunned, unconscious. When Pathfinder 2e is active, the system MUST support the PF2e condition set (see FR-103).
|
- **FR-032**: When a D&D game system is active, the system MUST support the following 15 standard D&D 5e/5.5e conditions: blinded, charmed, deafened, exhaustion, frightened, grappled, incapacitated, invisible, paralyzed, petrified, poisoned, prone, restrained, stunned, unconscious. When Pathfinder 2e is active, the system MUST support the PF2e condition set (see FR-103).
|
||||||
@@ -360,6 +374,11 @@ Acceptance scenarios:
|
|||||||
- **FR-105**: For PF2e valued conditions, the condition icon tag MUST display the current value as a small numeric badge (e.g., "2" next to the Frightened icon). Non-valued PF2e conditions display without a badge.
|
- **FR-105**: For PF2e valued conditions, the condition icon tag MUST display the current value as a small numeric badge (e.g., "2" next to the Frightened icon). Non-valued PF2e conditions display without a badge.
|
||||||
- **FR-106**: The condition data model MUST use `ConditionEntry` objects (`{ id: ConditionId, value?: number }`) instead of bare `ConditionId` values. D&D conditions MUST be stored without a `value` field (backwards-compatible).
|
- **FR-106**: The condition data model MUST use `ConditionEntry` objects (`{ id: ConditionId, value?: number }`) instead of bare `ConditionId` values. D&D conditions MUST be stored without a `value` field (backwards-compatible).
|
||||||
- **FR-107**: Switching the game system MUST NOT clear existing combatant conditions. Conditions from the previous game system that are not valid in the new system remain stored but are hidden from display until the user switches back.
|
- **FR-107**: Switching the game system MUST NOT clear existing combatant conditions. Conditions from the previous game system that are not valid in the new system remain stored but are hidden from display until the user switches back.
|
||||||
|
- **FR-108**: The following PF2e valued conditions MUST have maximum values enforced: dying (max 4), doomed (max 3), wounded (max 3), slowed (max 3). All other valued conditions have no enforced maximum.
|
||||||
|
- **FR-109**: When a PF2e valued condition is at its maximum value, the `[+]` increment button in the condition picker counter MUST be disabled (visually dimmed and non-interactive).
|
||||||
|
- **FR-110**: Maximum value enforcement MUST only apply when the Pathfinder 2e game system is active. D&D conditions are unaffected.
|
||||||
|
- **FR-111**: When Pathfinder 2e is the active game system, the concentration UI (Brain icon toggle, purple left border accent, damage pulse animation) MUST be hidden entirely. The Brain icon MUST NOT be shown on hover or at rest, and the concentration toggle MUST NOT be interactive.
|
||||||
|
- **FR-112**: Switching the game system MUST NOT clear or modify `isConcentrating` state on any combatant. The state MUST be preserved in storage and restored to the UI when switching back to a D&D game system.
|
||||||
|
|
||||||
### Edge Cases
|
### Edge Cases
|
||||||
|
|
||||||
@@ -375,8 +394,9 @@ Acceptance scenarios:
|
|||||||
- The settings modal is app-level UI; it does not interact with encounter state.
|
- The settings modal is app-level UI; it does not interact with encounter state.
|
||||||
- When the game system is switched from D&D to PF2e, existing D&D conditions on combatants are hidden (not deleted). Switching back to D&D restores them.
|
- When the game system is switched from D&D to PF2e, existing D&D conditions on combatants are hidden (not deleted). Switching back to D&D restores them.
|
||||||
- PF2e valued condition at value 0 is treated as removed — it MUST NOT appear on the row.
|
- PF2e valued condition at value 0 is treated as removed — it MUST NOT appear on the row.
|
||||||
- Dying 4 in PF2e has special mechanical significance (death), but the system does not enforce this automatically — it displays the value only.
|
- Dying, doomed, wounded, and slowed have enforced maximum values in PF2e (4, 3, 3, 3 respectively). The `[+]` button is disabled at the cap. The dynamic dying cap based on doomed value (dying max = 4 − doomed) is not enforced — only the static maximum applies.
|
||||||
- Persistent damage is excluded from the PF2e MVP condition set. It can be added as a follow-up feature.
|
- Persistent damage is excluded from the PF2e MVP condition set. It can be added as a follow-up feature.
|
||||||
|
- When PF2e is active, concentration state (`isConcentrating`) is preserved in storage but the entire concentration UI is hidden. Switching back to D&D restores Brain icons, purple borders, and pulse behavior without data loss.
|
||||||
|
|
||||||
---
|
---
|
||||||
|
|
||||||
|
|||||||
@@ -8,7 +8,7 @@
|
|||||||
|
|
||||||
## Overview
|
## Overview
|
||||||
|
|
||||||
The Bestiary feature provides creature search across pre-indexed creature libraries: 3,312+ D&D creatures from 102+ sources and ~2,700+ Pathfinder 2e creatures from 79 Pf2eTools sources. The active game system setting (see `specs/003-combatant-state/spec.md`, FR-096) determines which index the search operates against. Stat block display, source management, and creature pre-fill all adapt to the active game system.
|
The Bestiary feature provides creature search across pre-indexed creature libraries: 3,312+ D&D creatures from 102+ sources and 2,500+ Pathfinder 2e creatures from the Foundry VTT PF2e system (remaster-era content: Monster Core, Monster Core 2, and post-remaster books). The active game system setting (see `specs/003-combatant-state/spec.md`, FR-096) determines which index the search operates against. Stat block display, source management, and creature pre-fill all adapt to the active game system.
|
||||||
|
|
||||||
The feature also includes full creature reference via stat block display during combat, source data management via on-demand fetch or file upload, and a dual-panel UX with collapse/expand and pin capabilities. Creatures can be added individually or in batch from a search dropdown, with stats pre-filled from the index.
|
The feature also includes full creature reference via stat block display during combat, source data management via on-demand fetch or file upload, and a dual-panel UX with collapse/expand and pin capabilities. Creatures can be added individually or in batch from a search dropdown, with stats pre-filled from the index.
|
||||||
|
|
||||||
@@ -98,6 +98,11 @@ A view button in the search bar (repurposed from the current search icon) opens
|
|||||||
**US-D3 — Responsive Layout (P4)**
|
**US-D3 — Responsive Layout (P4)**
|
||||||
As a DM using the app on different devices, I want the layout to adapt between side-by-side (desktop) and drawer (mobile) so that the stat block is usable regardless of screen size.
|
As a DM using the app on different devices, I want the layout to adapt between side-by-side (desktop) and drawer (mobile) so that the stat block is usable regardless of screen size.
|
||||||
|
|
||||||
|
**US-D4 — View Spell Descriptions Inline (P2)**
|
||||||
|
As a DM running a PF2e encounter, I want to click a spell name in a creature's stat block to see the spell's full description without leaving the stat block, so I can quickly resolve what a spell does mid-combat without consulting external tools.
|
||||||
|
|
||||||
|
A click on any spell name in the spellcasting section opens a popover (desktop) or bottom sheet (mobile) showing the spell's description, level, traits, range, action cost, target/area, duration, defense/save, and heightening rules. The data is read directly from the cached creature data (already embedded in NPC JSON from Foundry VTT) — no additional network fetch is required, and the feature works offline once the source has been loaded. Dismiss with click-outside, Escape, or (on mobile) swipe-down.
|
||||||
|
|
||||||
### Requirements
|
### Requirements
|
||||||
|
|
||||||
- **FR-016**: The system MUST display a stat block panel with full creature information when a creature is selected.
|
- **FR-016**: The system MUST display a stat block panel with full creature information when a creature is selected.
|
||||||
@@ -113,9 +118,16 @@ As a DM using the app on different devices, I want the layout to adapt between s
|
|||||||
- **FR-064**: PF2e stat blocks MUST display level in place of challenge rating. Level MUST appear in the stat block header.
|
- **FR-064**: PF2e stat blocks MUST display level in place of challenge rating. Level MUST appear in the stat block header.
|
||||||
- **FR-065**: PF2e stat blocks MUST display three saving throws (Fortitude, Reflex, Will) instead of D&D's six ability-based saves.
|
- **FR-065**: PF2e stat blocks MUST display three saving throws (Fortitude, Reflex, Will) instead of D&D's six ability-based saves.
|
||||||
- **FR-066**: PF2e stat blocks MUST display ability modifiers directly (e.g., "Str +4") rather than ability scores with derived modifiers.
|
- **FR-066**: PF2e stat blocks MUST display ability modifiers directly (e.g., "Str +4") rather than ability scores with derived modifiers.
|
||||||
- **FR-067**: PF2e stat blocks MUST organize abilities into three sections: top (above defenses), mid (reactions and auras), and bot (active abilities), matching the Pf2eTools source structure.
|
- **FR-067**: PF2e stat blocks MUST organize abilities into three sections: top (above defenses), mid (reactions and auras), and bot (active abilities), matching the Foundry VTT PF2e item categorization.
|
||||||
- **FR-068**: PF2e stat blocks MUST strip Pf2eTools markup tags (e.g., `{@damage 1d8+7}`, `{@condition frightened}`) and render them as plain readable text, using the same tag-stripping approach as D&D (FR-019).
|
- **FR-068**: PF2e stat blocks MUST strip HTML tags from Foundry VTT ability descriptions and render them as plain readable text. The HTML-to-text conversion serves the same role as the D&D tag-stripping approach (FR-019).
|
||||||
- **FR-062**: Bestiary-linked combatant rows MUST display a small book icon (Lucide `BookOpen`) as the dedicated stat block trigger. The icon MUST have a tooltip ("View stat block") and an `aria-label="View stat block"` for accessibility. The book icon is the only way to manually open a stat block from the tracker — clicking the combatant name always enters inline rename mode. Non-bestiary combatant rows MUST NOT display the book icon.
|
- **FR-062**: Bestiary-linked combatant rows MUST display a small book icon (Lucide `BookOpen`) as the dedicated stat block trigger. The icon MUST have a tooltip ("View stat block") and an `aria-label="View stat block"` for accessibility. The book icon is the only way to manually open a stat block from the tracker — clicking the combatant name always enters inline rename mode. Non-bestiary combatant rows MUST NOT display the book icon.
|
||||||
|
- **FR-077**: PF2e stat blocks MUST render each spell name in the spellcasting section as an interactive element (clickable button), not as plain joined text.
|
||||||
|
- **FR-078**: Clicking a spell name MUST open a popover (desktop) or bottom sheet (mobile) displaying the spell's description, level, traits, range, time/actions, target/area, duration, defense/save, and heightening rules.
|
||||||
|
- **FR-079**: The spell description popover/sheet MUST render content from the spell data already embedded in the cached creature JSON — no additional network fetch is required.
|
||||||
|
- **FR-080**: The spell description popover/sheet MUST be dismissible by clicking outside, pressing Escape, or (on mobile) swiping the sheet down.
|
||||||
|
- **FR-081**: Spell descriptions MUST be processed through the existing Foundry tag-stripping utility before display (consistent with FR-068).
|
||||||
|
- **FR-082**: When a spell name has a parenthetical modifier (e.g., "Heal (×3)", "Unfettered Movement (Constant)"), only the spell name portion MUST be the click target; the modifier MUST remain as adjacent plain text.
|
||||||
|
- **FR-083**: The spell description display MUST handle both representations of heightening present in Foundry VTT data: `system.heightening` and `system.overlays`.
|
||||||
|
|
||||||
### Acceptance Scenarios
|
### Acceptance Scenarios
|
||||||
|
|
||||||
@@ -131,12 +143,19 @@ As a DM using the app on different devices, I want the layout to adapt between s
|
|||||||
10. **Given** a bestiary-linked combatant row is visible, **When** the user clicks the combatant's name, **Then** inline rename mode is entered — the stat block does NOT open.
|
10. **Given** a bestiary-linked combatant row is visible, **When** the user clicks the combatant's name, **Then** inline rename mode is entered — the stat block does NOT open.
|
||||||
11. **Given** a PF2e creature is selected, **When** the stat block opens, **Then** it displays: name, level, traits as tags, Perception, senses, languages, skills, ability modifiers, AC, Fort/Ref/Will saves, HP, speed, attacks, abilities (top/mid/bot sections), and spellcasting (if applicable). No CR, no ability scores, no legendary actions.
|
11. **Given** a PF2e creature is selected, **When** the stat block opens, **Then** it displays: name, level, traits as tags, Perception, senses, languages, skills, ability modifiers, AC, Fort/Ref/Will saves, HP, speed, attacks, abilities (top/mid/bot sections), and spellcasting (if applicable). No CR, no ability scores, no legendary actions.
|
||||||
12. **Given** a PF2e creature with conditional AC (e.g., "with shield raised"), **When** viewing the stat block, **Then** both the standard AC and conditional AC are shown.
|
12. **Given** a PF2e creature with conditional AC (e.g., "with shield raised"), **When** viewing the stat block, **Then** both the standard AC and conditional AC are shown.
|
||||||
|
13. **Given** a PF2e creature with spellcasting is displayed in the stat block panel, **When** the DM clicks a spell name in the spellcasting section, **Then** a popover (desktop) or bottom sheet (mobile) opens showing the spell's description, level, traits, range, action cost, and any heightening rules.
|
||||||
|
14. **Given** the spell description popover is open, **When** the DM clicks outside it or presses Escape, **Then** the popover dismisses.
|
||||||
|
15. **Given** the spell description bottom sheet is open on mobile, **When** the DM swipes the sheet down, **Then** the sheet dismisses.
|
||||||
|
16. **Given** a creature from a legacy (non-remastered) PF2e source has spells with pre-remaster names (e.g., "Magic Missile", "True Strike"), **When** the DM clicks one of those spell names, **Then** the spell description still displays correctly using the embedded data.
|
||||||
|
17. **Given** a spell name appears as "Heal (×3)" in the stat block, **When** the DM looks at the rendered output, **Then** "Heal" is the clickable element and "(×3)" appears as plain text next to it.
|
||||||
|
|
||||||
### Edge Cases
|
### Edge Cases
|
||||||
|
|
||||||
- Creatures with no traits or legendary actions: those sections are omitted from the stat block display.
|
- Creatures with no traits or legendary actions: those sections are omitted from the stat block display.
|
||||||
- Very long content (e.g., a Lich with extensive spellcasting): the stat block panel scrolls independently of the encounter tracker.
|
- Very long content (e.g., a Lich with extensive spellcasting): the stat block panel scrolls independently of the encounter tracker.
|
||||||
- Viewport resized from wide to narrow while stat block is open: the layout transitions from panel to drawer.
|
- Viewport resized from wide to narrow while stat block is open: the layout transitions from panel to drawer.
|
||||||
|
- Embedded spell item missing description text: the popover/sheet shows the available metadata (level, traits, range, etc.) and a placeholder note for the missing description.
|
||||||
|
- Cached source data from before the spell description feature was added: existing cached entries lack the new per-spell data fields. The IndexedDB schema version MUST be bumped to invalidate old caches and trigger re-fetch (re-normalization from raw Foundry data is not possible because the original raw JSON is not retained).
|
||||||
|
|
||||||
---
|
---
|
||||||
|
|
||||||
@@ -176,7 +195,7 @@ A DM wants to see which sources are cached, find a specific source, clear a spec
|
|||||||
- **FR-034**: An import button (Lucide Import icon) in the top bar MUST open the stat block side panel with the bulk import prompt.
|
- **FR-034**: An import button (Lucide Import icon) in the top bar MUST open the stat block side panel with the bulk import prompt.
|
||||||
- **FR-035**: The bulk import prompt MUST show a descriptive text explaining the operation, including approximate data volume (~12.5 MB) and the dynamic number of sources derived from the bestiary index at runtime.
|
- **FR-035**: The bulk import prompt MUST show a descriptive text explaining the operation, including approximate data volume (~12.5 MB) and the dynamic number of sources derived from the bestiary index at runtime.
|
||||||
- **FR-036**: The system MUST pre-fill a base URL that the user can edit.
|
- **FR-036**: The system MUST pre-fill a base URL that the user can edit.
|
||||||
- **FR-037**: The system MUST construct individual fetch URLs by appending the appropriate filename pattern to the base URL: `bestiary-{sourceCode}.json` for D&D sources, `creatures-{sourceCode}.json` for PF2e sources (matching the Pf2eTools naming convention).
|
- **FR-037**: The system MUST construct individual fetch URLs by appending the appropriate filename pattern to the base URL: `bestiary-{sourceCode}.json` for D&D sources, and the Foundry VTT PF2e per-creature file pattern for PF2e sources.
|
||||||
- **FR-038**: All fetch requests during bulk import MUST fire concurrently (browser handles connection pooling).
|
- **FR-038**: All fetch requests during bulk import MUST fire concurrently (browser handles connection pooling).
|
||||||
- **FR-039**: Already-cached sources MUST be skipped during bulk import.
|
- **FR-039**: Already-cached sources MUST be skipped during bulk import.
|
||||||
- **FR-040**: The system MUST show a text counter ("Loading sources... N/T") and progress bar during bulk import.
|
- **FR-040**: The system MUST show a text counter ("Loading sources... N/T") and progress bar during bulk import.
|
||||||
@@ -189,10 +208,15 @@ A DM wants to see which sources are cached, find a specific source, clear a spec
|
|||||||
- **FR-047**: The app MUST provide a management UI showing cached sources with a filter input for searching by display name and options to clear individual sources or all cached data.
|
- **FR-047**: The app MUST provide a management UI showing cached sources with a filter input for searching by display name and options to clear individual sources or all cached data.
|
||||||
- **FR-048**: The normalization adapter and tag-stripping utility MUST remain the canonical pipeline for all fetched and uploaded data.
|
- **FR-048**: The normalization adapter and tag-stripping utility MUST remain the canonical pipeline for all fetched and uploaded data.
|
||||||
- **FR-049**: The distributed app bundle MUST contain zero copyrighted prose content — only mechanical facts and creature names in the search index.
|
- **FR-049**: The distributed app bundle MUST contain zero copyrighted prose content — only mechanical facts and creature names in the search index.
|
||||||
- **FR-069**: The system MUST use a separate normalization pipeline for PF2e source data, mapping the Pf2eTools JSON structure to the PF2e creature type. Both pipelines (D&D and PF2e) MUST use the canonical tag-stripping utility.
|
- **FR-069**: The system MUST use a separate normalization pipeline for PF2e source data, mapping the Foundry VTT PF2e JSON structure (`system.*` fields and `items[]` array) to the PF2e creature type. Both pipelines (D&D and PF2e) MUST use the canonical tag-stripping utility (HTML-to-text for PF2e, markup-to-text for D&D).
|
||||||
- **FR-070**: The source cache MUST be scoped by game system. D&D and PF2e sources MUST NOT collide in IndexedDB (e.g., both may have a source code "B1" but they are different sources).
|
- **FR-070**: The source cache MUST be scoped by game system. D&D and PF2e sources MUST NOT collide in IndexedDB (e.g., both may have a source code "B1" but they are different sources).
|
||||||
- **FR-071**: The bulk import prompt MUST adapt to the active game system: showing the correct source count, base URL (Pf2eTools for PF2e, 5etools for D&D), and approximate data volume for the active system.
|
- **FR-071**: The bulk import prompt MUST adapt to the active game system: showing the correct source count, base URL (Foundry VTT PF2e repo for PF2e, 5etools for D&D), and approximate data volume for the active system.
|
||||||
- **FR-072**: The source management UI MUST show only sources for the active game system.
|
- **FR-072**: The source management UI MUST show only sources for the active game system.
|
||||||
|
- **FR-073**: The PF2e index generation script MUST read Foundry VTT PF2e one-file-per-creature JSON from the `packs/pf2e/` directory structure.
|
||||||
|
- **FR-074**: The PF2e index MUST exclude legacy/pre-remaster creatures based on the `publication.remaster` field — only remaster-era content is included by default.
|
||||||
|
- **FR-075**: PF2e creature abilities MUST have complete descriptive text in stat blocks. Stubs, generic feat references, and unresolved copy entries are not acceptable.
|
||||||
|
- **FR-076**: The PF2e index SHOULD carry per-creature license tagging (ORC/OGL) derived from the Foundry VTT source data.
|
||||||
|
- **FR-084**: The PF2e normalization pipeline MUST preserve per-spell data (slug, level, traits, range, time, target, area, duration, defense, description, heightening/overlays) from embedded `items[type=spell]` entries on NPCs, in addition to the spell name. This data MUST be stored in the cached source data and persisted across browser sessions.
|
||||||
|
|
||||||
### Acceptance Scenarios
|
### Acceptance Scenarios
|
||||||
|
|
||||||
@@ -215,7 +239,7 @@ A DM wants to see which sources are cached, find a specific source, clear a spec
|
|||||||
17. **Given** the source management UI is open, **When** the DM clears a single source, **Then** that source's data is removed; stat blocks for its creatures require re-fetching, while other cached sources remain.
|
17. **Given** the source management UI is open, **When** the DM clears a single source, **Then** that source's data is removed; stat blocks for its creatures require re-fetching, while other cached sources remain.
|
||||||
18. **Given** the source management UI is open, **When** the DM clears all cached data, **Then** all source data is removed and all stat blocks require re-fetching.
|
18. **Given** the source management UI is open, **When** the DM clears all cached data, **Then** all source data is removed and all stat blocks require re-fetching.
|
||||||
19. **Given** many sources are cached, **When** the DM types a partial name in the filter input, **Then** only sources whose display name matches (case-insensitive) are shown.
|
19. **Given** many sources are cached, **When** the DM types a partial name in the filter input, **Then** only sources whose display name matches (case-insensitive) are shown.
|
||||||
20. **Given** the game system is Pathfinder 2e, **When** the user clicks the import button, **Then** the bulk import prompt shows the PF2e source count (~79), a Pf2eTools-based URL, and a PF2e-appropriate data volume estimate.
|
20. **Given** the game system is Pathfinder 2e, **When** the user clicks the import button, **Then** the bulk import prompt shows the PF2e source count, a Foundry VTT PF2e-based URL, and a PF2e-appropriate data volume estimate.
|
||||||
21. **Given** the game system is Pathfinder 2e and a PF2e source is cached, **When** the user opens a PF2e creature's stat block from that source, **Then** the PF2e stat block renders correctly from cached data.
|
21. **Given** the game system is Pathfinder 2e and a PF2e source is cached, **When** the user opens a PF2e creature's stat block from that source, **Then** the PF2e stat block renders correctly from cached data.
|
||||||
|
|
||||||
### Edge Cases
|
### Edge Cases
|
||||||
@@ -294,7 +318,7 @@ As a DM with a creature pinned, I want to collapse the right (browse) panel inde
|
|||||||
- **Search Index (D&D)** (`BestiaryIndex`): Pre-shipped lightweight dataset keyed by name + source, containing mechanical facts (name, source code, AC, HP average, DEX score, CR, initiative proficiency multiplier, size, type) for all creatures. Sufficient for adding combatants; insufficient for rendering a full stat block.
|
- **Search Index (D&D)** (`BestiaryIndex`): Pre-shipped lightweight dataset keyed by name + source, containing mechanical facts (name, source code, AC, HP average, DEX score, CR, initiative proficiency multiplier, size, type) for all creatures. Sufficient for adding combatants; insufficient for rendering a full stat block.
|
||||||
- **Search Index (PF2e)** (`Pf2eBestiaryIndex`): Pre-shipped lightweight dataset for PF2e creatures, containing name, source code, AC, HP, level, Perception modifier, size, and creature type. Parallel to the D&D search index but with PF2e-specific fields (level instead of CR, Perception instead of DEX/proficiency).
|
- **Search Index (PF2e)** (`Pf2eBestiaryIndex`): Pre-shipped lightweight dataset for PF2e creatures, containing name, source code, AC, HP, level, Perception modifier, size, and creature type. Parallel to the D&D search index but with PF2e-specific fields (level instead of CR, Perception instead of DEX/proficiency).
|
||||||
- **Source** (`BestiarySource`): A D&D or PF2e publication identified by a code (e.g., "XMM") with a display name (e.g., "Monster Manual (2025)"). Caching and fetching operate at the source level.
|
- **Source** (`BestiarySource`): A D&D or PF2e publication identified by a code (e.g., "XMM") with a display name (e.g., "Monster Manual (2025)"). Caching and fetching operate at the source level.
|
||||||
- **Creature (Full)** (`Creature`): A complete creature record with all stat block data (traits, actions, legendary actions, spellcasting, etc.), available only after source data is fetched/uploaded and cached. Identified by a branded `CreatureId`.
|
- **Creature (Full)** (`Creature`): A complete creature record with all stat block data (traits, actions, legendary actions, spellcasting, etc.), available only after source data is fetched/uploaded and cached. Identified by a branded `CreatureId`. For PF2e creatures, each spell entry inside `spellcasting` carries full per-spell data (slug, level, traits, range, action cost, target/area, duration, defense, description, heightening) extracted from the embedded `items[type=spell]` data on the source NPC, enabling inline spell description display without additional fetches.
|
||||||
- **Cached Source Data**: The full normalized bestiary data for a single source, stored in IndexedDB. Contains complete creature stat blocks.
|
- **Cached Source Data**: The full normalized bestiary data for a single source, stored in IndexedDB. Contains complete creature stat blocks.
|
||||||
- **Combatant** (extended): Gains an optional `creatureId` reference to a `Creature`, enabling stat block lookup and stat pre-fill on creation.
|
- **Combatant** (extended): Gains an optional `creatureId` reference to a `Creature`, enabling stat block lookup and stat pre-fill on creation.
|
||||||
- **Queued Creature**: Transient UI-only state representing a bestiary creature selected for batch-add, containing the creature reference and a count (1+). Not persisted.
|
- **Queued Creature**: Transient UI-only state representing a bestiary creature selected for batch-add, containing the creature reference and a count (1+). Not persisted.
|
||||||
@@ -306,7 +330,7 @@ As a DM with a creature pinned, I want to collapse the right (browse) panel inde
|
|||||||
|
|
||||||
## Success Criteria *(mandatory)*
|
## Success Criteria *(mandatory)*
|
||||||
|
|
||||||
- **SC-001**: All indexed creatures for the active game system (3,312+ D&D or ~2,700+ PF2e) are searchable immediately on app load, with search results appearing within 100ms of typing.
|
- **SC-001**: All indexed creatures for the active game system (3,312+ D&D or 2,500+ PF2e) are searchable immediately on app load, with search results appearing within 100ms of typing.
|
||||||
- **SC-002**: Adding a creature from search to the encounter completes without any network request and within 200ms.
|
- **SC-002**: Adding a creature from search to the encounter completes without any network request and within 200ms.
|
||||||
- **SC-003**: After a source is cached, stat blocks for any creature from that source display within 200ms with no additional prompt.
|
- **SC-003**: After a source is cached, stat blocks for any creature from that source display within 200ms with no additional prompt.
|
||||||
- **SC-004**: The distributed app bundle contains zero copyrighted prose content — only mechanical facts and creature names in the search index.
|
- **SC-004**: The distributed app bundle contains zero copyrighted prose content — only mechanical facts and creature names in the search index.
|
||||||
@@ -323,7 +347,9 @@ As a DM with a creature pinned, I want to collapse the right (browse) panel inde
|
|||||||
- **SC-015**: Users can pin a creature and browse a different creature's stat block simultaneously, without any additional navigation steps.
|
- **SC-015**: Users can pin a creature and browse a different creature's stat block simultaneously, without any additional navigation steps.
|
||||||
- **SC-016**: The pinned panel is never visible on screens narrower than the dual-panel breakpoint, ensuring mobile usability is not degraded.
|
- **SC-016**: The pinned panel is never visible on screens narrower than the dual-panel breakpoint, ensuring mobile usability is not degraded.
|
||||||
- **SC-017**: All collapse/expand and pin/unpin interactions are discoverable through visible button controls without requiring documentation or tooltips.
|
- **SC-017**: All collapse/expand and pin/unpin interactions are discoverable through visible button controls without requiring documentation or tooltips.
|
||||||
- **SC-018**: All ~2,700+ PF2e indexed creatures are searchable when PF2e is the active game system, with search results appearing within 100ms of typing.
|
- **SC-018**: All 2,500+ PF2e indexed creatures (remaster-era content from Foundry VTT PF2e) are searchable when PF2e is the active game system, with search results appearing within 100ms of typing.
|
||||||
- **SC-019**: PF2e stat blocks render the correct layout (level, three saves, ability modifiers, ability sections) for all PF2e creatures — no D&D-specific fields (CR, ability scores, legendary actions) are shown.
|
- **SC-019**: PF2e stat blocks render the correct layout (level, three saves, ability modifiers, ability sections) for all PF2e creatures — no D&D-specific fields (CR, ability scores, legendary actions) are shown.
|
||||||
- **SC-020**: Switching game system immediately changes which creatures appear in search — no page reload required.
|
- **SC-020**: Switching game system immediately changes which creatures appear in search — no page reload required.
|
||||||
- **SC-021**: Both D&D and PF2e search indexes ship bundled with the app; no network fetch is required to search creatures in either system.
|
- **SC-021**: Both D&D and PF2e search indexes ship bundled with the app; no network fetch is required to search creatures in either system.
|
||||||
|
- **SC-022**: Clicking any spell in a PF2e creature's stat block opens its description display within 100ms — no network I/O is performed.
|
||||||
|
- **SC-023**: PF2e spell descriptions are available offline once the bestiary source containing the creature has been cached.
|
||||||
|
|||||||
Reference in New Issue
Block a user